Jeff Young
6ccaf5e27d
Flip all layers of a zone.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10621
2022-02-21 22:02:19 +00:00
Jeff Young
a24912d01d
A bit of safety.
2022-02-21 22:02:19 +00:00
Jeff Young
2498655cc5
Respect ERROR_OUTSIDE when inflating polygons.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10896
(cherry picked from commit e6c617b74d
)
2022-02-21 17:32:25 +00:00
Jeff Young
a5305aa235
A more discerning un-flashed-connectivity test.
...
(cherry picked from commit aa2c8e9b0c
)
2022-02-21 11:20:48 +00:00
Tomasz Wlostowski
680163f8a8
Cherry-pick commits from Master and about SVG import:
...
*Fixes in the SVG import polygon postprocessing:
- don't drop subsequent polys when a non-filled primitive is imported 'in between'
- fix missing holes (also related to the interleaving of stroke and filled shapes, depending on the software that wrote the SVG file)
*GRAPHICS_IMPORTER_BUFFER: forgot to store the indices of the paths belonging to a compound shape
*pcbnew: GRAPHICS_IMPORTER can now recognize multi-path shapes (and postprocess polygons with holes into Kicad-compatible fractured polysets)
*SHAPE_POLY_SET: polysets can now be built from a bunch of arbitraily ordered oriented outlines.
Used by the SVG hole support
*SVG_IMPORT_PLUGIN: enable postprocessing of polygons with degeneracy and holes
*pcbnew: SVG importer support for even-odd fill rule
2022-02-21 10:50:05 +01:00
Jeff Young
f8d15a641a
Use only a physical connection to determine flashing of pads.
...
Checking for proper nets just confuses things when the nets are set
wrongly for some reason. This way we generate clearer DRC errors.
Fixes https://gitlab.com/kicad/code/kicad/issues/10645
2022-02-20 20:52:39 +00:00
Jeff Young
d56e488f2d
Remove unnecessary validations.
...
Not sure if this will fix the bug or not as I can't reproduce it, but
I'd say odds are pretty good.
Fixes https://gitlab.com/kicad/code/kicad/issues/10467
2022-02-20 20:52:39 +00:00
jean-pierre charras
d5ca09dffc
Optimize DIALOG_GLOBAL_EDIT_TRACKS_AND_VIAS: a time consuming call (OnModify())
...
was made for each item change.
It is now made only once.
Fixes #10905
https://gitlab.com/kicad/code/kicad/issues/10905
2022-02-20 20:12:36 +01:00
Jeff Young
b24f51908b
Fix nullptr error (no router tool in footprint editor).
...
(cherry picked from commit df3291c59d
)
2022-02-20 16:57:54 +00:00
Jeff Young
246b6fcdd6
Use router to update message panel when routing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10068
2022-02-20 13:54:01 +00:00
Jeff Young
2b7c79541b
While flags are in prefs, actual clearance values are in board setup.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10852
(cherry picked from commit 7ddd3137a3
)
2022-02-20 01:03:08 +00:00
Jeff Young
7f40cac4b0
Fix collapsing name column in Net Inspector.
...
(cherry picked from commit 4966e2ebc2
)
2022-02-20 01:03:08 +00:00
Jeff Young
7978c8c291
Allow Rule Areas on all physical layers.
...
Required to do things like modify silk_clearance rules.
(cherry picked from commit 8f670552a6
)
2022-02-20 01:03:08 +00:00
Jeff Young
fc6ec23ac1
On-the-fly language updating for appearance panel & selection filter.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10040
(cherry picked from commit 6ce63d66e8
)
2022-02-20 01:03:08 +00:00
Jeff Young
02ec87b036
Cancel or commit pad edit mode when switching footprints.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10209
(cherry picked from commit 85805b95ba
)
2022-02-20 01:03:08 +00:00
Jeff Young
762258203c
Add zone margin when subtracting other graphics and zones.
...
It was already added for pads and tracks, but not the other objects.
Fixes https://gitlab.com/kicad/code/kicad/issues/10896
(cherry picked from commit 81bed9ab96
)
2022-02-20 01:03:08 +00:00
Seth Hillbrand
f0d7a09af9
Remove broken call to normalize outlines
...
We should never be editing the user's outlines for them. This creates
broken zones that are hard to repair. In this case, there was also a
secondary zone with no outline that would crash the system
Fixes https://gitlab.com/kicad/code/kicad/issues/10904
2022-02-18 09:30:26 -08:00
jean-pierre charras
7be3a6b3c5
pcbnew: fix incorrect calculation of the board thickness from board stackup.
...
dielectric sub layers were not taken in account.
Fixes #10899
https://gitlab.com/kicad/code/kicad/issues/10899
2022-02-18 18:10:49 +01:00
Seth Hillbrand
ed2148d634
Prevent merging tracks across pads
...
When merging co-linear tracks, we should maintain the existing break if
it exists on pads, vias and other connection points
(cherry picked from commit 3a29d94c0a
)
2022-02-17 19:44:33 -08:00
Seth Hillbrand
8e9d44942f
Maintain connectivity while cleaning tracks/vias
...
When merging segments that loop back on each other, we need to merge
them in such a way to to keep the resulting endpoints connected to the
original adjoining endpoints
Fixes https://gitlab.com/kicad/code/kicad/issues/10780
2022-02-17 15:24:23 -08:00
qu1ck
8b1f1c0296
Fix double loading plugins and sys.path entires multiplying
...
(cherry picked from commit b53b68c686
)
2022-02-17 10:59:52 -08:00
Tomasz Wlostowski
4eb9440a42
router: include arc approximation tollerance in arc hull clearance calculation
...
fixes: https://gitlab.com/kicad/code/kicad/-/issues/10470
(cherry picked from commit ce28525172
)
2022-02-17 09:22:19 -08:00
jean-pierre charras
7cf7270738
GERBER_JOBFILE_WRITER: allows all *_User layers to be listed in *gbrjob file.
2022-02-17 15:35:49 +01:00
Mikolaj Wielgus
46f7223dd9
Fix sizing of the two last columns in drill statistics table
2022-02-17 14:16:31 +01:00
Mikolaj Wielgus
75bba51b0b
Fix board statistics drill grid column sizing
...
And remove the horizontal scrollbar.
2022-02-17 14:16:31 +01:00
jean-pierre charras
34ed850a23
GERBER_JOBFILE_WRITER: fix missing handling of User_1 to User_9 user layers.
...
Fixes #10878
https://gitlab.com/kicad/code/kicad/issues/10878
2022-02-17 11:48:40 +01:00
Jeff Young
71eefc8322
Don't force user to be overly pedantic when writing diffpair rules.
...
(cherry picked from commit fe7e72538e
)
2022-02-15 20:57:45 +00:00
jean-pierre charras
35968dfe18
DIALOG_PLOT: use a short living quasimodal dialog instead of a long living window.
...
In this case, a quasimodal dialog is the right way.
From master branch, commit 43f5a7c74
2022-02-15 09:24:16 +01:00
Seth Hillbrand
6147e997ff
Format string for translation
2022-02-14 09:17:53 -08:00
jean-pierre charras
54a3ca06c0
Pcbnew, DIALOG_GRAPHIC_ITEM_PROPERTIES: fix incorrect test for arcs.
...
It was due to mixing decidegrees and degrees, and seen for 180 deg arcs
Fixes #10841
https://gitlab.com/kicad/code/kicad/issues/10841
2022-02-14 09:46:57 +01:00
jean-pierre charras
0cb82a0985
Import netlist: fix issues: do not read netlist before it is selected.
...
Now the netlist must be explicitly selected and read instead of beeing
read during dialog creation.
It also avoid a useless netlist read when closing the dialog or trying
to change the netlist filename.
From master branch
2022-02-14 08:37:53 +01:00
Graham Keeth
30276fb5f7
update custom rule syntax help to make diff pair rule examples clearer
...
(cherry picked from commit 4442f76add
)
2022-02-13 20:15:47 +00:00
Jeff Young
f37531ed39
Fix repaints getting done after the wrong dialog.
...
(cherry picked from commit b7c9a1ad55
)
2022-02-13 18:37:44 +00:00
Jeff Young
fd4ac7c5df
Error messages for zone merging.
...
Also fixes a bug where zones meeting at a point would get merged
resulting in a self-intersecting zone.
Also fixes a bug where undo would not be handled correctly when zones
could not be merged.
Fixes https://gitlab.com/kicad/code/kicad/issues/10466
(cherry picked from commit d5a2059c21
)
2022-02-13 18:30:32 +00:00
Jeff Young
f561f85ebb
Move CN_VISITOR from HitTest() to Collide().
...
The former isn't sufficiently aware of layer differences (such as for
pads with some layers unflashed).
(cherry picked from commit 6e063247e5
)
2022-02-13 18:22:18 +00:00
Jeff Young
7cba8e847d
Don't use bounding box cache during insideArea.
...
For starters we can't rely on it having been updated, but we also
cache the entire result so there's no huge cost-savings anyway.
Fixes https://gitlab.com/kicad/code/kicad/issues/10821
(cherry picked from commit 8dcc933fc3
)
2022-02-13 18:20:31 +00:00
木 王
7c910c2d0b
fix-npth
2022-02-12 11:56:46 +01:00
Seth Hillbrand
861589d837
Use wxEmptyString instead of wxT( "" )
...
Also fixes places where ternaries did autopromotion instead of returning
an empty wxString
2022-02-09 10:33:52 -08:00
Seth Hillbrand
8fc831cbc2
Validate arc output when editing
...
Handles checking output of the arc to ensure we don't end up generating
an invalid arc. Also keeps the limit of the arc angle to be (360,360)
excluding 0.
Fixes https://gitlab.com/kicad/code/kicad/issues/10070
2022-02-06 17:18:04 -08:00
Jeff Young
3af606a020
Wide string decls for gerbview.
2022-02-05 19:59:29 +00:00
Roberto Fernandez Bautista
f412d8d461
CADSTAR: Fix potential nullptr dereferencing bug
...
Don't assume the footprint will have the pad index that the file references.
2022-02-05 19:22:05 +00:00
Marek Roszko
71bcc9883a
Fix typoed test condition for TH no hole pads PVS V501
...
(cherry picked from commit b9f1aaf029
)
2022-02-05 18:32:08 +00:00
Marek Roszko
be958e3fdb
Avoid potential divide by zero in footprint spreading PVS V609
...
(cherry picked from commit 8588bea4b2
)
2022-02-05 18:31:00 +00:00
Marek Roszko
b2c99dd953
Fix some leaking objects identified by PVS Studio V773
...
(cherry picked from commit a7ebfc31f9
)
2022-02-05 18:30:24 +00:00
Jeff Young
471c0c4c1d
More wide-string declarations.
2022-02-05 13:29:00 +00:00
Jeff Young
9e5e46514d
More wide-string declarations.
2022-02-05 13:29:00 +00:00
jean-pierre charras
ba70f202ce
Fix a compil issue.
2022-02-05 11:16:56 +01:00
Jeff Young
4657614e4f
More wxString wide literals.
2022-02-04 23:12:09 +00:00
Jeff Young
2365c1e96f
Add duplicated items to parent group.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10155
(cherry picked from commit 42917874dd
)
2022-02-04 18:14:25 +00:00
Jeff Young
430c4862b6
Log an undo item when filling zones.
...
If we wanted to put it into the parent's undo item, then the *parent*
would need to not start a new undo record. Not starting one in the
zone filler tries to add it to the *previous* change, not to the parent
change.
Fixes https://gitlab.com/kicad/code/kicad/issues/10091
(cherry picked from commit 4cc1ced2f3
)
2022-02-04 18:14:25 +00:00