haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
31,929 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

517 Commits

Author SHA1 Message Date
Jeff Young ec92def539 Add support for unitless values to PCB_EXPR_EVALUATOR. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13016

(cherry picked from commit 8260f0ee13)
 2022-11-29 23:28:37 +00:00
Jeff Young e083cbaf50 Allow a single net collision with a free pad. 
(cherry picked from commit 3534cfbba8)
 2022-11-29 22:16:15 +00:00
Seth Hillbrand 42bd43407a Remove clone's group info 2022-11-28 09:17:17 -08:00
Jeff Young fde2b429b9 Make sure pair caches are layer-specific where they need to be. 
(cherry picked from commit 909358e643)
 2022-10-24 10:57:07 +01:00
Jeff Young dde5f2bed1 Respect DRCEpsilon in diff-pair coupling test. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12587

(cherry picked from commit 9119b5072a)
 2022-10-19 14:26:19 +01:00
Jeff Young 914e396e2e Implement annular ring checking for pads. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12109

(cherry picked from commit 9a4136de00)
 2022-10-19 13:49:40 +01:00
Seth Hillbrand e834374ad2 Drill size is absolute 
Use hole plating size for visibility only, not zone filling, routing or
DRC

(cherry picked from commit b4f3390626)
 2022-10-04 10:00:36 -07:00
Seth Hillbrand c45aa734b0 Fix missing DRC via/track check 
Depending on pointer ordering, the via/track clearance check might not
run as we were only checking when the first element was a track not via.

Re-written version of 0150655ed3 for v6
 2022-09-20 15:32:55 -07:00
Jeff Young e25d937fd8 Null-ptr safety for diff-pair-coupling test. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12329

(cherry picked from commit 854acd4c77)
 2022-09-02 01:18:18 +01:00
Jeff Young bf272e379f Run hole-to-hole checks on Edge_Cuts layer. 
Also makes the flashing logic inside PAD::GetEffectiveShape() easier
to understand.

Fixes https://gitlab.com/kicad/code/kicad/issues/12296

(cherry picked from commit e0f6a6e475)
 2022-09-02 01:11:20 +01:00
Jeff Young 36a0c2a9cc Fix issue with caches not being initialized when printing msg bar. 
(cherry picked from commit 43df863df2)
 2022-08-04 13:04:21 +01:00
Seth Hillbrand 55de16e874 Remove extraneous files added in 69858ab4c0 
Files were master-only
 2022-06-30 11:09:03 -07:00
Seth Hillbrand 45329ceafa Push wxString allocation to smaller context 
Prevents creation of new wxString on stack for each clearance check

(cherry picked from commit 4043dca613)
 2022-06-21 10:30:42 -07:00
Seth Hillbrand 69858ab4c0 Remove shared wxString instance in DRC 
Threaded DRC access will write to this string, re-allocating the memory
without any synchronization between threads using the string.  Comment
adding this listed performance as a reason for using shared strings.
Measured performance does not seem noticeably different in either case,
even with high-error count boards.  If there is a case where the
performance is limiting, we can replace these wxStrings with
std::wstring and utilize fmt

Fixes https://gitlab.com/kicad/code/kicad/issues/9888

(cherry picked from commit 5327b10064)
 2022-06-21 10:27:21 -07:00
Seth Hillbrand d0796399a2 DP tolerance needs to be 1IU on each axis 
ApproximatelyParallel will only check for parallel within 1 IU, so a 1x1
SEG will always be parallel and the projection is invalid
 2022-04-11 16:55:54 -07:00
Jeff Young 529048dac1 Better error reporting for DP uncoupled length. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10087

(cherry picked from commit 722b2588f4)
 2022-04-09 23:09:10 +01:00
Jeff Young f8c92e355b Plating thickness appears on both sides of hole wall. 2022-04-04 21:51:30 +01:00
Jeff Young 8054f1a948 Apply a more sophisticated test for ignoring isInCoupledDiffPair. 
The basic problem is that the DRC engine does length testing and skew
testing by collecting all the diff pair constituent parts and pairing them
itself.  Since each part is collected on its own, we need to ignore the
'B' unit when evaluating any conditional expressions.  However, doing this
in general means that when evaluating "OwnClearance()" we also ignore the
'B' unit and return the diff pair CLEARANCE_CONSTRAINT when we shouldn't.

This implements a more discerning test which know what the current requested
constraint is when evaluating expressions.

See also https://forum.kicad.info/t/solved-custom-differencing-rule-not-working-drc/34034/6

Fixes https://gitlab.com/kicad/code/kicad/issues/11314

(cherry picked from commit f7cdc7af75)
 2022-04-03 18:23:41 +01:00
Jeff Young eeee5afdfd Zero out parent rule when overridden by local property. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11197

(cherry picked from commit b679a21651)
 2022-03-21 20:56:00 +00:00
Jeff Young ff604cc6a3 Pull some fixes back from master. 
Mostly wxT(), but also some performance, and some for better response
to Cancel button.

(cherry picked from commit 5c63df28e4)
 2022-03-18 12:49:54 -07:00
Seth Hillbrand b0f8055377 Revert "Pull some fixes back from master." 
This reverts commit 5c63df28e4.
 2022-03-17 16:21:37 -07:00
Jeff Young 5c63df28e4 Pull some fixes back from master. 
Mostly wxT(), but also some performance, and some for better response
to Cancel button.
 2022-03-16 15:15:09 +00:00
Jeff Young 53bd87d792 Performance fixes for the board from hell.... 
(cherry picked from commit e4b56ab7f1)
 2022-03-16 15:14:51 +00:00
Jeff Young 9e5e46514d More wide-string declarations. 2022-02-05 13:29:00 +00:00
Seth Hillbrand c2707f3cc0 Fix large memory leak in DRC 
All elements get effective shapes, many of which get triangulated.  This
memory needs to be freed when destroying the tree
 2022-01-28 17:07:11 -08:00
Jeff Young c02cadec2a Exclude rules which match no enabled layers. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10227

(cherry picked from commit 0967cc82e2)
 2022-01-21 15:06:18 +00:00
Erwan Rouault 11c967b259 pcbnew: Add via height support in drc length 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10135
 2021-12-30 14:34:44 +00:00
Seth Hillbrand 24fe5bc2a8 Fix DRC thread locking 2021-12-15 06:05:40 -08:00
Seth Hillbrand 40d44c94cd Fix single-threaded loads/connectivity 
We cannot set thread counts to hardware_concurrency()-1 without
considering that single core machines will get a thread count of 0.
 2021-12-14 17:18:46 -08:00
Jeff Young 0dcbfa2b69 Always use UUIDs for implicit keepout rules. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9580
 2021-11-09 17:57:47 +00:00
Jeff Young 6af031be05 Use double-quotes for rule expressions. 
The Mac double-quote bug is now fixed and strings inside expressions
are single quoted making single-quoting the entire expression pretty
hard to visually parse.
 2021-11-08 20:53:59 +00:00
Jeff Young ffd1139cfe Make sure a pad is at least as big as its hole in the RTree. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9516
 2021-11-03 18:53:26 +00:00
jean-pierre charras 40e6a9a926 Fp editor: add DRC test for through hole pads without hole. 2021-10-19 14:47:29 +02:00
Jeff Young 856cc26d4c Allow vias the same same-net waiver that pads have for hole clearance 
Note that in 7.0 we have physical_hole_clearance rules to give a bit
more expressivity here.

Fixes https://gitlab.com/kicad/code/kicad/issues/9420
 2021-10-18 18:09:40 +01:00
Jeff Young b52529521e Replace individual LIB_* shapes with LIB_SHAPE (based on EDA_SHAPE). 
Also moves to more capable FILL_T model that can be shared.
 2021-10-15 12:45:43 +01:00
Seth Hillbrand fce054319c Update DRC MatchDPSuffix routine 
This matches the router matchDPSuffix routine until we merge the two
into a common utility
 2021-10-11 10:33:50 -07:00
Jeff Young dfe4997664 Fix nullptr crash. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9250
 2021-09-27 10:27:25 +01:00
Seth Hillbrand 3e7310a219 Move FP type check to FP DRC 
Checks for validity are better centrally located where they don't
interrupt user actions
 2021-09-25 08:56:27 -07:00
Jeff Young c38de1dcaf Pull back some 7.0 fixes to Custom Rules code completion. 2021-09-23 13:08:31 +01:00
Jon Evans 814b6b8e86 Fix disabled layer error text 2021-09-12 17:14:24 -04:00
Jeff Young 0ac765c5bb Special case footprint zones which can be on "inner layers". 
Also improves the reporting so that it reports the actual conflict
layer rather than just the first layer the object is on.

Fixes https://gitlab.com/kicad/code/kicad/issues/9144
 2021-09-12 13:53:12 +01:00
Jeff Young 1a43515128 Repair multi-layer disabled layer tests. 2021-09-09 16:43:47 +01:00
Jeff Young bb2efa0649 Improve disabled layer test. 
1) handle graphic items on copper layers
2) handle items on multiple layers
 2021-09-09 15:20:48 +01:00
Wayne Stambaugh 3b16c38756 Coverity issue fixes. 
Fix Coverity issues 157138, 338547, and 338716.
 2021-09-08 14:51:27 -04:00
Jeff Young a397e85589 Implement PTH/NPTH/courtyard collision tests. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9081
 2021-09-04 00:16:26 +01:00
Jeff Young 436ad0ede7 Add missing token to DRC rule parser. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9041
 2021-08-27 12:49:07 +01:00
Jeff Young f4905cb1ae Cherry-pick fix from 7.0 branch back to master. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9005
 2021-08-25 20:14:11 +01:00
Jeff Young e6ca9837a2 Clear numbers from non-numberable pads and don't run DRC on them. 
This was also the last straw on the misnamed PAD::GetName() and
PAD::SetName(), which are now PAD::GetNumber() and PAD::SetNumber().

Fixes https://gitlab.com/kicad/code/kicad/issues/9017
 2021-08-24 01:03:06 +01:00
Jeff Young fec34e8dd8 Get rid of an extraneous layer parameter. 
Also adds a bit of nullptr safety.
 2021-08-23 20:00:17 +01:00
Jeff Young 9770962ab4 Fix logic bug in rule processing. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9011
 2021-08-22 20:16:58 +01:00