bc7742cb2e
Various text object defaults don't necessarily match file defaults.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10862
2022-02-15 23:25:59 +00:00
940e03e567
Remove arc end swapping when parsing.
...
See: 2366b06e77 (note_839061664)
2022-02-11 13:10:52 +00:00
2366b06e77
Don't parse multiple items in a single c'tor or function call.
...
The C++ optimizer is not always your friend and may do them in the
reverse order.
2022-02-10 17:54:13 +00:00
d33d092e8e
Add a second fix for backwards arcs.
...
This one *should* also be good when we support larger-than-180
degree arcs.
2022-02-10 15:46:02 +00:00
cb8e803788
Formatting.
2022-02-10 13:04:29 +00:00
b9843a23eb
Eeschema, legacy *lib files: fix issues with 180 deg arcs.
...
180 deg arcs are a limit, so when importing them convert them to slightly
smaller arc (arc angle = 179.5 deg)
Fixes #10455
https://gitlab.com/kicad/code/kicad/issues/10455
2022-02-10 12:45:54 +01:00
3f8f90db9f
Factor out common s-expression library cache source code.
2022-02-09 11:20:14 -05:00
7181f0b40b
Fix clang broken build.
2022-02-09 07:55:50 -05:00
fe82f2dd40
Factor out common schematic s-expression source code.
2022-02-08 14:44:38 -05:00
fc3cad0b54
Hash symbol libraries per library rather than statically per cache type.
2022-02-07 15:40:21 -05:00
b57ac3d517
Handle SCH_TEXTBOX in SCH_SEXPR_PLUGIN::Format.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10771
2022-02-06 19:43:25 +00:00
d9c04da407
Sprinkle in some make_unique
2022-02-05 21:26:36 -05:00
ca7840334c
Mark some limits as constexpr
...
gcc doesn't need it and computes during compile regardless, but experimenting in godbolt, both clang and MSVC actually do need it or else it's partially computed at runtime
2022-02-04 07:50:13 -05:00
fa1d316d84
Fix windows build error
2022-02-02 17:43:47 -05:00
e590d07224
Fix clang build error.
2022-02-02 07:44:11 -05:00
9260431fe4
Abstract out symbol library parser object.
2022-02-02 07:07:39 -05:00
6fcc6f7c9d
Factor out common legacy schematic and symbol library parser code.
2022-02-01 16:30:15 -05:00
f3cd36d1d7
Bring EEschema textboxes in line with PCBNew's.
...
Also adds Border checkboxes and fixes a bunch of bugs.
2022-01-31 21:46:40 +00:00
b36e31c49f
Factor out common and remove dead legacy symbol library code.
2022-01-29 14:13:00 -05:00
c6a8100d46
Schematic and symbol text boxes.
...
Also fixes some plot bugs with arcs.
Also moves polygonization of arcs (when required) in plotting code
from 5 degrees to calculated based on ARC_HIGH_DEF.
Fixes https://gitlab.com/kicad/code/kicad/issues/5017
2022-01-28 21:38:15 +00:00
3409783d9f
Break sch_text.h/.cpp into sch_text and sch_label.
...
Also moves SCH_NETCLASS_FLAG to SCH_DIRECTIVE_LABEL, and remaps Altium
harnesses from SCH_TEXT to SCH_DIRECTIVE_LABEL.
2022-01-28 21:38:15 +00:00
a6203617d9
Fix Altium schematic port component import assertion.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10322
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10401
2022-01-28 15:52:30 +00:00
8a17fb8d19
SCH_SEXPR_PARSER::parseArc(): fix a very annoying issue: each time the lib or
...
sch files are saved and reopened, 180 deg arcs were flipped.
This fix is a workaround, but avoid flipped arcs after saving/reopening these files.
2022-01-26 18:19:52 +01:00
694ae59664
fix a minor compil warning (shadowed vars)
2022-01-21 14:09:42 +01:00
c8a50d9b50
Remove unit-less angles from VECTOR2I/D APIs.
2022-01-20 23:58:20 +00:00
3ba89f50ef
Maybe, just maybe, fix LibEdit arc parsing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10455
2022-01-19 22:22:18 +00:00
8445783216
Fix backwards arcs in legacy LIB_ARCs.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10455
2022-01-18 14:08:47 +00:00
de31b813f3
Angle cleanup in the Cadstar importer.
2022-01-18 02:31:37 +00:00
622f94e7b9
Angle cleanup in Altium importer.
2022-01-18 02:31:37 +00:00
0218b782f4
Angle cleanup in Eagle importer.
2022-01-18 02:31:37 +00:00
0129e49b79
altium: Introduce new ALTIUM_COMPOUND_FILE object to handle file opening and searching for streams at a central place
2022-01-17 19:54:26 +01:00
e61144d45a
Finish with EDA_ANGLE.
2022-01-16 21:15:40 +00:00
e84c574830
Some more EDA_ANGLE cleanup.
2022-01-16 19:16:18 +00:00
516d038bdf
Eeschema: fix incorrect stored rotation value in file of the global and hierarch. labels.
...
The stored value was the rotation of the text (always 0 or 90 deg), but these labels can also
be rotated by -90 or 180 deg
Fixes #10450
https://gitlab.com/kicad/code/kicad/issues/10450
Fixes #10457
https://gitlab.com/kicad/code/kicad/issues/10457
2022-01-16 17:19:36 +01:00
9b661aea10
EDA_ANGLE for plotters.
...
Also fixes a compile error in the PNS Playground.
2022-01-16 01:19:45 +00:00
07013d00e1
More EDA_ANGLE.
2022-01-14 16:08:19 +00:00
1b19ff5f42
More EDA_ANGLE changes.
2022-01-14 16:08:19 +00:00
e048e51f5d
Improve SNR of EDA_ANGLE stuff.
2022-01-14 16:08:18 +00:00
e244ce1431
Fix cherry-picked wxPoint
2022-01-12 15:49:03 -08:00
d3f24308e6
Handle rotated symbol rectangles in Eagle import
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10360
(cherry picked from commit dcb8f29317
2022-01-12 15:11:18 -08:00
3d8288f919
Remove unused vars, verified there was no other intention with them;
...
rectangle are OK
2022-01-11 20:16:35 +00:00
76368af7b9
Font cleanup and bug fixes.
2022-01-09 18:33:53 +00:00
27c967421c
Commenting and "auto" reduction.
2022-01-08 16:47:45 +00:00
72b69e8d7f
File format changes for fonts.
2022-01-08 16:47:45 +00:00
3ace4446e7
Use 'special' escaping for certain fields
...
Most fields are escaped using the `\` notation. But the VALUE field and
the symbol name need to be escaped using braces notation.
Fixes https://gitlab.com/kicad/code/kicad/issues/10097
(cherry picked from commit 71e7b4b77b
2022-01-05 17:19:36 -08:00
3ced3afa68
eeschema: automatic generated symbol library from EAGLE plugin does not include footprint reference
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10262
2022-01-05 19:48:40 +00:00
502e34349e
eeschema: EAGLE plugin does not reference footprint with library suffix
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10261
2022-01-05 19:14:27 +00:00
9ca41cc8ee
Set readable flags correctly on open
...
Missing files may be thrown during open. These should have existence
and readable flags set correctly
(cherry picked from commit a05ec04ee8
2022-01-05 09:55:51 -08:00
726d873c53
Tear down the wxPoint trigo helpers
2022-01-04 21:23:11 -05:00
ac715d2e51
Scoop up some more wxPoint instances
2022-01-03 20:00:53 -05:00
9daa4d0e2c
Move duplicate field handling into field parser
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10130
(cherry picked from commit ea99c42df6
2022-01-02 13:19:54 -05:00
ea613cf448
Another batch of point changes
2022-01-01 13:17:12 -05:00
c4c56de708
Neurotically update position wxPoint usages
2022-01-01 11:55:51 -05:00
347e03363a
Convert wxPoint/wxSize starting from EDA_RECT usages
2022-01-01 11:30:33 -05:00
640cc60bf4
fix a compil warning.
2021-12-31 15:53:24 +01:00
480a548171
PCB_PAINTER: do not show track arc clearance when not needed
...
fix also a minor compil warning.
Fixes #10137
https://gitlab.com/kicad/code/kicad/issues/10137
2021-12-30 09:21:35 +01:00
ccb94fd1a7
APIs for passing KIFONT::FONT pointers around.
...
Also some clean-up and bug fixes.
2021-12-29 17:32:19 +00:00
dd6cd7d184
Pull some more improvements in from rockola/kicad-strokefont.
...
This one is primarily about pushing TEXT_ATTRIBUTES in to the GAL
API, but it also includes adding EDA_ANGLE signatures to some trig
routines to ease integration.
2021-12-29 17:32:19 +00:00
56a31900d3
Formatting.
2021-12-28 22:47:05 +00:00
86cb57f4a7
Cherry-pick TEXT_ATTRIBUTES and EDA_ANGLE from rockola/kicad-strokefont
2021-12-28 22:15:20 +00:00
9ba733f23f
altium: Import POLY shape instead of line approximation ( #8741 )
2021-12-27 17:22:28 +01:00
82ab04c1d6
altium: Use newly introduced RECT shape, apply fill and improve stroke handling ( #8741 )
2021-12-27 16:50:30 +01:00
8b714deae1
altium: Add support for circle and arc in schematic ( #8741 )
2021-12-27 16:02:12 +01:00
80e7b6eb1f
Save and load fill color of SHAPE_T objects properly
2021-12-24 21:20:54 +00:00
889970a449
SCH_NETCLASS_FLAGs and SCH_FIELDs for labels.
...
ADDED: a new label type for netclass flags.
ADDED: the ability to define fields on labels.
2021-12-24 16:13:27 +00:00
92e589b398
Use board maxError value, and return SH_ARC for unfilled circle.
2021-12-23 20:36:11 +00:00
2bc86fa0a8
Shapes for schematic.
...
ADDED arc, circle and rectangle shapes for schematic. Shapes support
line styles and fill colors.
CHANGED sheet background color in Edit Text & Graphics Properties to
fill color (and it now affects shapes).
Pushed STROKE_PARAMS down into common and moved all shapes to using it
for stroke descriptions.
2021-12-23 20:36:07 +00:00
f2ad8bffe0
Fix a mistake in Altium parser
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10011
2021-12-16 05:49:39 +03:00
067fa65756
Eeschema: fix a multitude of LIB_FIELD object comparison and index bugs.
...
It is no longer acceptable to set a LIB_FIELD index to -1. This was
trashing the sorting on load cause all kinds of false field comparison
failures. There are now assertions when attempting to use -1 as a field
index.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9811
2021-12-12 17:06:32 -05:00
91dace3e5e
Update Eagle importer
...
Fixes arc orientation
Sets root schematic and page numbers
Fixes https://gitlab.com/kicad/code/kicad/issues/9907
2021-12-10 15:41:25 -08:00
af280f80e0
Fix debug assertion in Altium and CADSTAR schematic importers.
2021-12-09 12:56:03 +00:00
b7af66e3f9
Eeschema: fix broken page numbers when renaming a sheet file name.
...
Always use full sheet paths when storing sheet instances. Partial sheet
paths cannot be full resolved resulting in lost page numbers when renaming
sheet file name.
Fixes #9782
2021-12-09 12:56:03 +00:00
a03e6e4926
Revert "Eeschema: fix broken page numbers when renaming a sheet file name."
...
This reverts commit a468a79948
2021-12-06 07:47:18 -05:00
3a00d76207
Fix a compil warning (shadowed var) and add a comment.
2021-12-01 11:05:16 +01:00
bfe595819a
Prevent error when loading bitmaps from some old schematics
2021-12-01 09:54:48 +00:00
a468a79948
Eeschema: fix broken page numbers when renaming a sheet file name.
...
Remove duplicate instance data saved in both root SCH_SCREEN and SCH_SHEET
objects that was causing them to be out of sync. All sheet instance data
is stored in the SCH_SHEET object itself and rebuilt on the fly so it is
always current.
Remove Get/SetPageNumber from SCH_SHEET_PATH object so it doesn't obfuscate
where the actual sheet page number information exists.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9782
2021-11-30 08:11:24 -05:00
9bb370e6b4
SCH_SHEET_PIN: Rename GetEdge, SetEdge to GetSide, SetSide
2021-11-28 20:07:06 +01:00
58b5ac4970
Don't create SCH_LINE till we know the layer.
...
The CTOR makes some decisions on initialization based on the layer.
2021-11-28 17:09:24 +00:00
3660597082
Use canonical names when saving sheet name and filename fields
2021-11-27 20:38:51 +00:00
228edd4121
Don't generate duplicate IDs in line/wire/bus tool.
...
Also cleans up existing duplicate IDs when reading.
Fixes https://gitlab.com/kicad/code/kicad/issues/9749
2021-11-24 13:20:44 +00:00
b052d56c7b
R/W uuids for junctions.
2021-11-24 13:20:44 +00:00
025d9f82ea
Remove atrophied schematic default wire and bus widths.
...
(They're now in the netclasses, and specifically the default netclass
if no other netclass is assigned.)
Fixes https://gitlab.com/kicad/code/kicad/issues/9628
2021-11-13 22:56:50 +00:00
80c5b1efb1
File formatting improvements and fixes.
...
Symbol library IDs included the library nickname which is incorrect
and meaningless since it will be overwritten by the symbol library
table code. This is not a file format change as there are no behavioral
differences.
2021-11-13 12:57:18 -05:00
54e00569d8
Don't fetch the root sheet's UUID out of the sheet instances.
...
1) we're storing it now anyway
2) the root sheet UUID is the one UUID that's *not* in the instance
array, and previously we were erroneously grabbing the first sub-sheet's
UUID (producing duplicate UUIDs).
2021-11-09 16:07:30 +00:00
cf6b18ec7e
Remove escaped double-quotes
...
For some reason, escaped double quotes in wxString::Format cause issues
on Mac. We can replace them with single quotes in most places without
loss of clarity
2021-11-03 17:03:14 -07:00
c2371f3943
Revert e4b61de792.
...
It doesn't seem to fix the testcase on Linux, and the tests pass on
my machine in either configuration.
2021-11-03 10:30:34 +00:00
e4b61de792
Special case sheet ordering in file.
2021-11-02 23:14:01 +00:00
7cf72aaa41
Fix bezier import in Altium schematics
2021-11-02 15:45:30 -07:00
4d46445ce1
Fix Bezier reading.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9512
2021-11-02 22:19:41 +00:00
4acff58c7a
Implement a forced ordering for LIB_ITEMs until we have UUIDs.
...
(Once we read/write the UUIDs, we should just compare the type
and then the UUID like we do for SCH_ITEMs.)
2021-11-02 20:07:34 +00:00
eaf10a04dd
Improved naming.
2021-11-02 20:07:34 +00:00
af95a4b424
Fix duplicate stroke when formatting circles.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9507
2021-11-01 21:29:46 +00:00
b6c12b6b55
CADSTAR Sch: Fix positioning of symbol fields when the symbol is mirrored
...
The text aligment needs to be rotated and/or mirrored depending on whether
the text field is vertical or horizontal.
2021-10-31 16:12:08 +00:00
8367c7f238
CADSTAR Sch: Fix calculation of page size
...
Don't attempt to calculate bounding box of text variables. We do not
know the resolution of the text variable inside the importer. The
resolved text could be shorter than the text variable (e.g. ${#}
page number)
2021-10-30 21:49:34 +01:00
0aba025d66
CADSTAR Sch: Autoplace intersheet references (instead of 0,0)
2021-10-30 21:49:34 +01:00
18e36155a5
CADSTAR sch: Include gate in error message when symbols are scaled
2021-10-30 21:49:34 +01:00
52a936ac61
CADSTAR Sch: Fix spurious pin length and orientation of some symbols
...
Ensure deterministic sorting of std::map in fixUpLibraryPins
2021-10-30 21:49:34 +01:00
c1515dd31c
CADSTAR Sch: Fix block names - load as stand-alone text items instead
...
KiCad doesn't support multi-line text in fields, so we can't load it as
a text field (even if that would be the closest thing).
We should update this when KiCad supports multi-line text in fields.
2021-10-30 18:14:23 +01:00
0cdffa16d4
Fix off-by-one error in fill mode writing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9111
2021-10-28 19:29:47 +01:00
8fdfc0e63d
Replace legacy sch writing code for rescue functionality.
2021-10-28 15:11:15 +01:00
cb1709b4ca
Improve Eagle importer's label positioning.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9466
2021-10-27 13:49:13 +01:00
3ea3d5274c
CADSTAR Schematic: Hide all KiCad sheet properties
...
Sheet name/filename not applicable in CADSTAR so displaying it just
makes the import look messy.
2021-10-23 10:58:15 +01:00
d6d800ccbb
CADSTAR Schematic: Fix crash when trying to fix library pins
...
Need to copy the chain as we might have deleted it.
2021-10-17 17:57:51 +01:00
a1c1f60665
Coverity fixes.
2021-10-16 16:27:35 +01:00
ce55dd2893
Fix botched merge.
2021-10-15 21:27:16 +01:00
f9861b4a6c
Finish arc rework and push out to file formats.
2021-10-15 12:45:43 +01:00
b52529521e
Replace individual LIB_* shapes with LIB_SHAPE (based on EDA_SHAPE).
...
Also moves to more capable FILL_T model that can be shared.
2021-10-15 12:45:43 +01:00
9b9e379aa0
Overhaul arc internal model to not over-specify information.
2021-10-15 12:45:43 +01:00
c61af21da8
Eeschema: don't stat files when updating title bar text.
...
The tests for file existence and write status perform two file stats
which cause performance issues on slow network shares. Now the file
state is determined at load time and stored in the SCH_SCREEN object
so file access is no longer required.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9343
2021-10-14 10:52:58 -04:00
7aa3514042
CADSTAR Schematic: Add net labels for named nets on symbol pins
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9371
2021-10-11 18:30:21 +01:00
d39f79b55b
Fix schematic custom paper size check to use same limits as rest of eeschema
...
Fix #9223
2021-09-24 00:46:02 -04:00
552f053a55
Remove pins from symbol hit-testing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8508
2021-09-23 22:07:51 +01:00
469d3ea329
Don't add global labels when a power symbol is connected.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7497
2021-09-20 21:31:19 +01:00
ae8f817938
Use consistent label size and fix issues with rotation.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5950
2021-09-20 21:31:19 +01:00
40b4e5c024
Formatting.
2021-09-20 21:31:19 +01:00
4663da4709
Eeschema: don't escape document file alias names in legacy plugin.
...
Escaping the document file (.dcm) alias names breaks the link between the
document file and the library (.lib) file. This causes the information in
the document file to be lost.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9130
2021-09-16 09:09:44 -04:00
efc9279a19
Fix unfortunate line-break.
2021-09-13 13:28:05 +01:00
52f99e41e6
Fix merge screw up.
2021-09-12 22:57:25 +01:00
625e56676a
Add progress reporting to CADSTAR Schematic & PCB importers
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8685
2021-09-11 17:50:19 +01:00
c736bd3fd0
Patch Altium import of oddly constructed line segments.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8974
2021-09-11 15:29:51 +01:00
451f8eefc0
Eeschema: fix broken project symbol rescue bug.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9111
2021-09-09 10:21:09 -04:00
ad7275f0a3
Repair saving of default line styles.
...
Note that the file format version was NOT bumped because we were
correctly reading the default, just no writing it.
Fixes https://gitlab.com/kicad/code/kicad/issues/9045
2021-09-07 00:14:18 +01:00
8268c4ad17
CADSTAR Schematic: Ensure library ID is valid
...
Previously the library created was invalid - opening it resulted
in a parsing error due to invalid characters in the name.
2021-09-01 20:25:39 +01:00
be9ff7a7d5
CADSTAR Schematic: Load text sizes for pin names/numbers and net labels
2021-09-01 20:25:39 +01:00
0aa37d1173
Fix issues with new overbar syntax
...
- Update sch text help (~~ no longer gets converted to single ~)
- Update Eagle importer to correctly handle new overbar syntax
- Update CADSTAR importer to correctly handle new overbar syntax
2021-09-01 20:25:39 +01:00
0cd8a4d846
CADSTAR Schematic: Load line thickness in symbols
2021-08-29 19:55:47 +01:00
69fac89e86
Fix some issues with incorrectly scaled defaults given in mils.
2021-08-25 20:04:06 +01:00
4ac2aa675a
lib symbols: make fp filter tolerant to spaces in names.
...
For historical reasons they are stored in a string using spaces as separators.
So each fp filter is now escaped to remove spaces (replaced by {space})
Fixes #9009
https://gitlab.com/kicad/code/kicad/issues/9009
2021-08-23 18:01:31 +02:00
8879b887df
Fix missing overbar notation conversions in legacy library parsing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8981
2021-08-18 22:48:29 +01:00
46b959c3e3
Move plotter headers into include folder.
2021-08-18 16:38:31 -04:00
41619ebbe2
Decouple PROGRESS_REPORTER interface from implementations.
2021-08-14 21:05:49 +01:00
1818846cff
Minor improvements to some error messages.
2021-08-14 12:11:47 +01:00
bed51a5fc1
altium schematic importer, replace record 211 with compile masks
2021-08-14 11:05:56 +00:00
6ab45d0a6d
Fix double-escaping in Eagle importer.
...
This has actually been there since dot, but the old escaping method
just deleted chars it didn't like so you could run it as many times
as you wanted.
Fixes https://gitlab.com/kicad/code/kicad/issues/8694
2021-07-31 20:07:25 +01:00
6aaf4413b3
Fix kicad_string.h / string.cpp mismatch.
...
They don't define a KiCad string class, so the header file name was
somewhat misleading. But the fact that they didn't match definitely
made coding more difficult.
2021-07-29 16:03:25 +01:00
f221220fe2
Rename layer ids file.
...
It hasn't had anything to do with colors or visibility for some time
now.
2021-07-29 16:03:25 +01:00
8ff76de18e
DIALOG_EDIT_ONE_FIELD: fix a non resizable widgets and fix a compil warning.
...
Fixes #8877
https://gitlab.com/kicad/code/kicad/issues/8877
2021-07-27 14:12:46 +02:00
8467fe5405
Altium schematic import: text positioning and arc fixes
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8844 (power port text positioning, only use 0, 90deg for text)
Adjust text justification due to rotation on import
Set field position through SCH_FIELD::SetPosition
Honor hidden net names at power ports
Calculate start/end points for imported arcs in symbols
2021-07-26 19:49:56 +00:00
8fd83cbb95
Pass wxPoint objects by reference instead of on the stack.
2021-07-26 15:35:33 -04:00
010247bb7f
Add overbar conversion to the legacy SCH reader.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8855
2021-07-25 13:11:30 +01:00
531f5480a7
Reduce line-breaks and increase SNR.
2021-07-24 14:25:59 +01:00
cb72da294a
More NULL expunging.
2021-07-16 16:13:41 -04:00
0446d35f0d
Fix source comment/doc typos (follow-up)
...
Found via `codespell -q 3 -S *.po,./thirdparty -L aactual,acount,aline,alocation,alog,anormal,anumber,aother,apoints,aparent,aray,dout,einstance,modul,ot,overide,serie,te,,tesselate,tesselator,tht`
2021-07-13 10:48:17 +00:00
ad7e563e24
Do not translate something similar to a proper noun
2021-07-12 09:02:04 +02:00
a4263ebce5
Clean up Altium special string handling
...
1) Fix a couple of bugs in case processing
2) Make case processing more explicit to prevent more (1)
3) Move label processing to AltiumSpecialStringsToKiCadVariables
4) Strip double-quotes from special strings (and add test cases)
5) Change PROJECTNAME to just filename, not full path
6) PROJECTREV and REVISION are two different things
7) Add support for Altium's Application_BuildNumber
8) Fix some issues in trimming spaces around special strings
2021-07-08 15:34:38 +01:00
3f165c70e1
Import more Alitum parameters.
...
ADDED CURRENT_DATE titleblock token (to go with existing ISSUE_DATE)
ADDED PROJECTNAME schematic token (to go with FILENAME and SHEETNAME)
Converts other parameters to project text variables.
2021-07-08 00:19:31 +01:00
c1db5dc0b1
Make the variable replacement table a little easier to read.
...
Yes, this probably violates all our formatting conventions EXCEPT
the one that says code should be easy to read/visually parse.
2021-07-07 22:06:35 +01:00
9351a88091
Variable references are case insensitive in Altium.
2021-07-07 22:04:00 +01:00
5a57f6ba98
Clear NEW flags after import.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8750
2021-07-07 20:05:50 +01:00
db91908c18
Add sheetpath instances when importing sheets from Altium.
2021-07-07 20:05:50 +01:00
a81c6b21b6
Formatting.
2021-07-07 20:05:50 +01:00
5e9a8e3488
altium: Improve handling of footprint references
...
Don't assume the implementation list index is always correct by order.
2021-07-07 21:03:21 +02:00
a17862d646
Import Altium harness labels as text.
...
One day we'll do better, but at least this way the user knows there's
something they need to migrate manually.
Fixes https://gitlab.com/kicad/code/kicad/issues/8748
2021-07-07 17:54:22 +01:00
5ab56e5320
More Altium importer error reporting cleanup.
...
1) Use REPORTER instead of wxLog
2) Use consistent, non-techy strings
3) Use consistent severity levels
Fixes https://gitlab.com/kicad/code/kicad/issues/8747
2021-07-07 12:43:33 +01:00
3b288b1b1b
Pull textframe processing out from under note and allow both.
...
Note that there's still a bunch of stuff we don't support regarding
textframes such as wordwrap and background colours, but this at least
keeps the text from getting lost.
Fixes https://gitlab.com/kicad/code/kicad/issues/8741
2021-07-06 20:27:28 +01:00
190b0ecdeb
Formatting.
2021-07-06 20:27:28 +01:00
0be91c5b7d
Import Altium footprint references into symbols.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7751
2021-07-06 14:40:29 +01:00
3288971a7c
Allow titleblock vars to be resolved outside the titleblock.
...
Also implements some variable resolving for Altium imports.
2021-07-06 13:30:17 +01:00
b0c07a28b3
Add importing of Altium notes.
...
Import is incomplete because KiCad doesn't support text boxes yet
(so we can't do borders, word-wrap, background fills, etc.).
Fixes https://gitlab.com/kicad/code/kicad/issues/8734
2021-07-05 23:59:43 +01:00
26df39e71a
Naming conventions.
2021-07-05 11:05:46 +01:00
aa5902bd99
Process Altium pin name and number hidden flags.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7853
2021-07-04 00:18:42 +01:00
eff75b630f
Get rid of anonymous struct typedefs
...
We are using C++14 where there is no reason for this and is banned in C++20 under P1766R1. MSVC generates a warning under C++14 as a reminder.
2021-07-01 18:28:41 -04:00
f8a34d98b3
Support for overbar syntax in Altium importer.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7979
2021-07-01 21:03:53 +01:00
6810912f09
Refuse to load schematics from the future.
...
Also fixes a bug where an empty window would get left when loading
a file from the KiCad manager window errored out.
Also fixes a bug where we were getting the wrong exception because
we were rethrowing the type-casted one (rather than just calling
throw).
Fixes https://gitlab.com/kicad/code/kicad/issues/8604
2021-06-30 18:32:07 +01:00
5cac8afe1d
Remove long-dead revision support for LIB_IDs.
2021-06-30 13:12:57 +01:00
b1b4caee6a
Escape "naughty" characters in symbol names.
...
It's tempting to say that we don't need to exclude filename chars
from symbols, but we might regret that decision down the road. Better
to just escape them.
Fixes https://gitlab.com/kicad/code/kicad/issues/8694
2021-06-30 13:12:57 +01:00
a1dfc36233
More error message regularization.
2021-06-29 01:08:26 +01:00
062c4fda62
More error message regularization (and translatability improvements).
2021-06-28 00:45:24 +01:00
4aa8318dc2
More error message regularization.
2021-06-27 14:24:02 +01:00
0dfb5fcaf9
Error message cleanup.
...
wxString::Format is redundant in a wxLogXXX call.
Error messages should generally be translatable.
Error messages should use generally consistent sentence forms.
2021-06-26 22:53:24 +01:00
5c21f93803
Consistency in progress and error messages.
2021-06-26 13:23:43 +01:00
8502fd6877
Divide-by-zero safety.
2021-06-24 12:18:22 +01:00
5fa5a73c6d
File open/import progress dialogs.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6864
Fixes https://gitlab.com/kicad/code/kicad/issues/2166
2021-06-23 23:55:54 +01:00
6d223931fb
Convert overbar syntax in bus aliases.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8647
2021-06-21 20:13:21 +01:00
19f76ae77c
Convert pin names to new overbar format
...
Fixes bug 6 of https://gitlab.com/kicad/code/kicad/issues/8591 , thereby
closing the issue:
Fixes https://gitlab.com/kicad/code/kicad/issues/8591
2021-06-20 09:00:16 +00:00
d811ae0aa3
Improved ASCII art.
2021-06-18 12:01:16 +01:00
c35cceca62
fix compil warnings ( "multi-line comment" ) and missing override
2021-06-18 09:38:19 +02:00
bdeeace2ab
More Eagle importer fixes.
...
1) Don't process wires more than once when looking for bus entries.
2) Don't allow processing a wire to mess up iteration over the RTree.
2021-06-17 18:16:38 +01:00
b10f156dd0
Don't convert overbar syntax in most fields.
...
You probably do want it in VALUE, but not REFERENCE, and certainly
not FOOTPRINT or DATASHEET. User fields are more likely to be
part numbers, etc. (and don't want conversion).
Fixes https://gitlab.com/kicad/code/kicad/issues/8617
2021-06-17 00:05:17 +01:00
c23c5b7f18
Allow import of Eagle schematics without libraries.
2021-06-16 22:02:50 +01:00
4b28bac89a
Fixes for Eagle importer.
...
1) Make sure we set an absolute path on the sheet.
2) Don't mix RTree iterators; wires get skipped between buses.
3) Implement a real ERC error so we don't assert.
Fixes https://gitlab.com/kicad/code/kicad/issues/7042
2021-06-16 21:44:18 +01:00
21b869bd1f
Fix a few cases missed in the last merge.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7042
2021-06-16 00:01:28 +01:00
3a84ee27fd
First take at repairing Eagle import of bus entries.
...
Simplify logic by adding quadrant-based BUS_ENTRY ctor.
Fix issue with bus entry size having been in mils rather than IU.
Fix issues with logic.
Fixes https://gitlab.com/kicad/code/kicad/issues/7042
2021-06-15 23:23:47 +01:00
ff099453c8
Rename class_library.[h|cpp] to symbol_library.[h|cpp].
2021-06-15 09:24:55 -04:00
ee3eac325d
Expunge the use of the word part from Eeschema code.
2021-06-15 08:32:11 -04:00
fb46cd8bc5
Expunge the use of the word component from Eeschema code.
...
The only exception to this is the SPICE simulator's use of component
when referring to physical component (R, L, C, etc.) values.
2021-06-14 14:00:21 -04:00
71c183d7bb
Rename LIB_PART to LIB_SYMBOL.
2021-06-14 07:11:17 -04:00
ade38f48bc
Add conversion from old `~...~` to new `~{...}` notation
2021-06-11 18:40:57 +00:00
fbc135e69f
Rename SCH_COMPONENT to SCH_SYMBOL.
2021-06-10 10:34:49 -04:00
f968fc8719
Fix source comment / documentation typos
2021-06-09 19:32:58 +00:00
d946d6e68f
Cleanup some pgm_base.h includes
2021-06-08 21:56:00 -04:00
9ebabb222c
Pass objects by reference instead of on the stack.
2021-06-08 10:09:38 -04:00
022dd6072c
Add utility method to resolve symlinks
...
The same logic block to resolve possible symlinks exists in 5 different
places now. This change moves this duplicated code to a static member
function of WX_FILENAME instead.
2021-06-07 20:59:59 +00:00
fc3cea2cca
Remove wx/xml/xml.h from sch_eagle_plugin.h
2021-06-06 09:34:57 -04:00
06e967354f
Fix symlink read-/write-through code
...
Use `realpath(3)` instead of `readlink(3)`, which offers support for
relative and absolute symlinks alike, since all symbolic links will be
resolved to the absolute path of the linked-to file.
Fixes #8082
2021-06-05 14:22:50 +00:00
4df3cb912d
Remove another leaky wx/log.h header
2021-06-03 08:11:15 -04:00
af2707929d
Don't leak a wx header via eda_item.h
...
Turns out this provided the translation header globally :D
2021-06-02 19:18:48 -04:00
eeb405c196
Cleanup some more excess math/util includes
2021-06-02 00:50:46 -04:00
cf2bb5692a
Remove the wxLog calls from math/util.h for now
...
This was leaking windows headers and partial wx headers to 1084 compilation units......
This also means math/util.h is leaking to 1084 compilation units which seems a bit high too.
2021-06-01 18:44:22 -04:00
3ac5aa5369
enum class SHEET_SIDE
2021-05-30 21:23:46 -04:00
382dca4e6f
Fix uninitialized member warnings
...
Based on PVS Studio report
2021-05-30 20:01:01 -04:00
be5b281501
Cleanup RAD2DEG and unused vars
2021-05-28 12:37:57 -07:00
9a9c9d38e8
CADSTAR Schematic: Cleanup pins in symbols
...
In CADSTAR pins are single points. We can replicate the original look
of the schematic in most cases by searching the symbol for straight
segments that are coincident with the pin and use those to calculate
a suitable pin length and angle.
2021-05-28 20:13:11 +01:00
29d1b84939
CADSTAR Schematic: Fix positioning of symbol attributes
...
Symbol attributes were being placed at the wrong location
due to incorrect relative angle calculation
2021-05-28 20:13:10 +01:00
8d788b7a09
CADSTAR Schematic: Fix assert regarding sheet absolute path
2021-05-28 20:13:10 +01:00
b985c4d2e9
CADSTAR Schematic: Handle scaled symbols
...
Create a new LIB_PART for scaled symbols. These will be then embedded
into the schematic file. However when "update from library" is done,
it will revert to the unscaled symbol.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8494
2021-05-28 20:13:10 +01:00
752ae4d519
Rename modification flag routines
...
Differentiates better between the EDA_ITEM IsModified(), referring to
items themselves changing and the EDA_SCREEN IsContentModified(),
referring to whether we have made any unsaved changes.
2021-05-28 12:07:04 -07:00
be436ec977
Remove whitespace from page numbers on load and use # if page is empty
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8350
2021-05-21 22:52:47 +01:00
ebd53cd45c
Eeschema: fix text justification terminology.
...
Use justification instead of orientation relative to the anchor point when
describing text direction and alignment. This seems to be the preferred
method by most users so hopefully this will eliminate some confusion.
Fix a bug in the s-expression schematic parser that failed to take into
account how graphical text alignment is defined for graphic text objects
compared to label text objects.
Fixes https://gitlab.com/kicad/code/kicad/issues/6489
2021-05-14 13:44:17 -04:00
2e3860de6f
Naming conventions.
2021-05-05 22:58:40 +01:00
c7345096f8
Use wxFFileInputStream explicitly when loading xml documents
...
wxFFile (FILE, buffered) is better than wxFile (syscalls)
2021-05-03 19:39:56 -04:00
cf2dc06add
Fix latent bugs in SCHEMATIC and SCH_SEXPR_PLUGIN
...
Noticed after writing the qa test: when loading a file immediately
after having loaded a previous one, it was resulting in a nullptr
exception.
2021-05-03 19:38:31 +01:00
5822cd85c4
Fix eeschema copy/paste: save and load sheet and symbol instances
...
Save sheet and symbol instance information to the clipboard on copy
Load sheet and symbol instance information from the clipboard on paste
and renumber page numbers after loading.
Correctly handle pasting in a multiple hierarchy by ensuring symbol and
sheet instances are updated for all instances of the destination sheet.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8207
2021-05-03 19:38:31 +01:00
91fd28c4be
Refactor saving sheet and symbol instances in SCH_SEXPR_PLUGIN::Format
...
Avoid code duplication by moving all common code to a new function
SCH_SEXPR_PLUGIN::saveInstances
Also fixes a bug that was resulting in footprint and value information
not being saved for subsheets that were root sheets in a different
project.
2021-05-03 16:54:42 +01:00
ecd9bf696e
Be consistent about using nullptr instead of 0
...
0 can be too easily overloaded into an int, so ensure we use nullptr
when we mean pointers.
2021-04-22 22:20:34 +01:00
ae91042544
Implement thread safety for symbol loading routines
...
These functions can be called from any thread of the library
loader, so we need to ensure we have some thread safety with them.
2021-04-18 18:39:46 +01:00
31e9895a1a
Fix a minor compil warning
2021-04-15 19:49:41 +02:00
45409ec314
CADSTAR Schematic: Fix orientation of symbol fields
2021-04-12 20:25:04 +01:00
9148542219
CADSTAR Schematic: Fix Text Positioning within Symbols
2021-04-12 20:25:03 +01:00
f13eb13b9a
altium: import images from SchDoc
2021-04-10 21:52:37 +02:00
2b86b34124
Eeschema: split out SCH_SHEET_PIN declarations into separate header.
2021-04-06 17:15:49 -04:00
df186a2049
Eeschema: fix root sheet UUID changing in project file.
...
This change is a bit more invasive than the description above would
suggest. UUIDs have been added to all schematics. For now, it's only
useful to the root schematic so that the UUID in the project file does
not change every time the project file is save. In the future, it may
be useful to store and check the schematic UUIDs against the one's saved
in the project file.
Fixes https://gitlab.com/kicad/code/kicad/issues/7763
2021-04-06 14:28:01 -04:00
d041578150
CADSTAR Schematic: Fix import of text alignment
...
Ensure that the text alignment applied to text objects corresponds to
valid text alignments that can be set within eeschema
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8090
2021-04-05 20:15:08 +01:00
cb17c9f3dd
Typo fix: Correct various misspelled words
...
agressive -> aggressive
decription -> description
miscellanous-> miscellaneous
rectange -> rectangle
Unkown -> Unknown
2021-04-03 13:39:50 +00:00
ebfbe14185
Persist fields_autoplaced information.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8086
2021-04-02 17:08:58 +01:00
655a696589
fix compil issue
2021-04-01 11:36:30 +02:00
6499b5f296
Eeschema: protect lib symbols against duplicate field names.
...
If a field name is already in use, try to rename the new field name
(adding the suffix "_1" or "_2" or ... )
This is especially critical when a non mandatory field has the same name as
a mandatory field (was crashing before)
Fixes #8081
https://gitlab.com/kicad/code/kicad/issues/8081
2021-04-01 11:27:14 +02:00
2ad69fc56b
Move importers from wxLog to REPORTER.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6389
2021-03-31 22:54:30 +01:00
c5e4220b5b
CADSTAR Schematic: Fix duplicate pins
...
Fixes a bug that was causing duplicate pins to be loaded
(one on top of the other) for all symbols.
2021-03-30 13:03:56 +00:00
1629b038e1
CADSTAR Schematic: Fix loading of symbol instances differing from part
...
The previous assumption was that a part definition would always hold
the information about the symbol. However some designs have symbol
instances that refer to a different symbol definition than that
specified in the part.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7808
2021-03-30 13:03:56 +00:00
e6c7ddc271
CADSTAR Schematic: Fix loading of symbol attributes
...
Fixes an issue that resulted in incorrect field values being loaded
2021-03-30 13:03:56 +00:00
51db9cfcef
CADSTAR Schematic: Text Loading improvements
2021-03-30 13:03:56 +00:00
a0a5e93782
Remove m_props from symbol library plugins. It's not thread-safe.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/8035
2021-03-26 21:57:32 +00:00
3d6c05b210
Apply symbol field id fixup logic to lib parts.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7903
2021-03-26 21:57:32 +00:00
e0d2724f68
CADSTAR Schematic: Increase "tiny" bus labels to 0.4mm text size
...
Also fix incorrect label orientation
2021-03-25 19:10:49 +00:00
6494e0bf25
CADSTAR Schematic: Fix orientation of net labels and sheet pins
2021-03-25 17:50:33 +00:00
5a74fb9bb1
CADSTAR Schematic: Ensure connectivity with tiny labels at Bus Entries
...
Always add a label at bus terminals to ensure connectivity. The original
design might already have a bus terminal with a given location.
If the original design does not have a label, just make it very small
to keep connectivity but make the design look visually similar to
the original.
2021-03-25 17:50:33 +00:00
cfaca0e4bb
Revert "Eeschema: remove all legacy schematic and symbol library save code."
...
This reverts commit 9c19c2306ehttps://gitlab.com/kicad/code/kicad/issues/7986
2021-03-22 08:19:47 -04:00
a0889705e7
EAGLE and Altium SCH importers: UpdateSymbolLinks after import
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7687
2021-03-21 20:13:20 +00:00
d9229697d8
altium: special string override map should be case-insensitive
...
This only fixes overrides where we explicitly map an override. Wrongly written variables pointing to fields are not corrected by this.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/6256
2021-03-20 20:42:25 +01:00
9c19c2306e
Eeschema: remove all legacy schematic and symbol library save code.
...
Legacy schematic and symbol library saving is officially deprecated.
2021-03-20 13:29:44 -04:00
c04e19f9ac
Include optimization: move some things from common.h to point-of-use
2021-03-20 12:09:18 -04:00
4482b3baba
altium: Handle special strings and convert them into KiCad variables. Use Comment for VALUE.
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/6256
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/7736
2021-03-14 16:40:36 +01:00
2a9186d9e9
Don't re-use FieldIDs when assigning ids on save.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7849
2021-03-09 15:09:31 +00:00
e2aa7be4b3
Added a lot of consts and refactored a few lines
2021-03-08 12:49:48 -08:00
7a00e01b3e
Eeschema: fix false positive library symbol changed ERC errors.
...
This fix required sorting all of the LIB_PART draw items to ensure
accurate comparison between the symbols stored in the schematic and the
original library symbols. This has a noticeable impact on symbol library
load performance. It may also cause significant changes the next time
the library is saved due to changes in the draw item sorting. Hashing
may be a better solution here but this addressed the immediate problem.
A skeleton method SCH_SCREEN::SwapSymbolLinks() was added because there
is most likely an issue with orphaned symbols in the schematic library
symbol cache during undo/redo operations. More testing is required to
verify this.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/7263
2021-03-04 17:59:24 -05:00
ff23f4324a
Do not hardcode altium file extension length
2021-03-04 12:20:40 +00:00
908de37e7c
Don't hardcode the file extensions where possible
2021-03-03 01:13:59 +00:00
2c289b3f35
Check for ".SchDoc" before replacing to ".kicad_sch" for subsheet
2021-03-02 22:30:08 +00:00
f83b9236ac
Formatting
2021-03-02 22:30:08 +00:00
Jeff Young
jean-pierre charras
Wayne Stambaugh
Marek Roszko
Franck
Thomas Pointhuber
Seth Hillbrand
Ola Rinta-Koski
Steffen Mauch
Jon Evans
Jonathan Haas
dsa-t
Mikolaj Wielgus
Roberto Fernandez Bautista
Stefan
david-beinder
luz paz
luz paz
Johannes Maibaum
Ian McInerney
Carsten Schoenert
Dominik Wernberger
WhiteChairFromIkea