2d6ab62da4
ADDED: schematic/library diff for symbols.
2023-03-09 18:04:52 +00:00
e4ec74e1ac
Fix link issue for qa_utils on MINGW/msys2
...
For some obscure reason, using Boost_UNIT_TEST_FRAMEWORK_LIBRARY as library
name to link does not work. So use the actual filename.
2023-03-08 17:47:50 +01:00
671f555bc8
CMake: add flag to turn off spice QA tests (tests default to on)
2023-03-07 12:05:01 -05:00
7653a2bf99
Smarten connection width checker looking for splits
...
Fractured polygons are always fractured along the x-axis, so when
checking to see if a segment is a fracture point, we check if the y
coordinate is equal. This avoids situations where there are multiple
fracture points between two inflection points
Additionally, we add a second check to ensure we don't hit spurious
blobs (all kinks should be symmetric and therefore be substantial in
each direction)
Fixes https://gitlab.com/kicad/code/kicad/issues/14130
2023-03-06 16:14:34 -08:00
d96598c87c
Add 12505 to the regression test suite.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12505
2023-03-06 10:26:59 +00:00
4e99812145
Coverity fixes and code cleaning.
2023-03-04 13:02:05 -05:00
bce402a01c
Revert font spacing/tabs to the v6 model
...
While convoluted, this model matches as best we have found so far, the
alignment with scintilla. The spacing is character size for N-1 of the
characters in the 4-space tab stops. The final character is sized for
the actual space character in the stroke font (0.761905)
Fixes https://gitlab.com/kicad/code/kicad/issues/13791
2023-02-24 17:15:57 -08:00
9dca70a773
Eeschema netlist output: Propagate NC across hierarchical schematics
...
Fixes #12580
Additionally does not export no_connect netlist annotation on pins
which are both connected to another pin and a NC item, unless all
connected pins are stacked at the symbol level.
Adds testing of pin types to netlist QA unit tests.
2023-02-25 00:02:46 +00:00
959a19a461
Power Symbols: automatically fix mismatched legacy symbols, add tests
...
Has netlist generation test for legacy power symbols, and test for
fixing legacy mismatched power symbol text fields and invisible pin names.
2023-02-22 18:01:47 +00:00
5995e0e516
Power Symbols: make value editable, use as netname
...
QA: update tests for editable power symbol values
2023-02-22 18:01:47 +00:00
ca5004b1d2
Power Symbols: rename IsPowerConnection to IsGlobalPower
...
It's kind of confusing because we have power type pins, and pins that
make global power nets as part of power symbols.
2023-02-22 18:01:47 +00:00
68fe146861
Remove most of SIM_VALUE in favour of good old wxString.
...
This allows us to save the user's intent, including units, formatting,
and crucially variable references.
2023-02-22 10:45:27 +00:00
be19e967dc
Remove WX_COMPATIBILITY flag
...
Some classes had been originally designed to be usable separate from wx,
but over time our uses of the classes have become entertwined with wx
features (e.g. colors), and various changes have also leaked wx into the
classes unguarded. So just remove the option to hide wx in those classes
to simplify the code.
2023-02-22 01:44:06 +00:00
bcb93e9aa7
Modernize setting of compiler definitions in CMake
...
add_compile_definitions was added in 3.12, and our minimum is now
greater than that.
2023-02-22 01:44:06 +00:00
2a3b70b7eb
sim - Remember the option to save powers
...
Fixes #13978
2023-02-20 19:30:45 +01:00
aacc9746e3
Yeet the last of wxSize/wxPoint to stop leaking gdicmn everywhere
2023-02-18 22:57:18 -05:00
07f79208b9
Minor fixes: Coverity and compil minor warnings.
2023-02-18 13:04:43 +01:00
05b68413f7
Fix a QA test for bitmaps, to work with latest changes in bitmap code.
2023-02-15 14:37:01 +01:00
5c45b53f88
Rollback testing changes that were accidentally checked in.
2023-02-11 21:11:07 +00:00
bc108023b3
ADDED operating point overlay for SCH_EDIT_FRAME.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11253
2023-02-11 21:11:07 +00:00
2a5bb71fbd
ADDED operating point text variables for labels and symbols.
...
ADDED formatting for cursors and operationg points
Also fixes a bunch of bugs to make the new cursors work with .ac sims.
Fixes https://gitlab.com/kicad/code/kicad/issues/11253
Fixes https://gitlab.com/kicad/code/kicad/issues/6965
2023-02-11 21:11:07 +00:00
09822c7f18
ADDED direct access to signals & cursors.
...
ADDED differential cursors.
Fixes https://gitlab.com/kicad/code/kicad/issues/4447
Fixes https://gitlab.com/kicad/code/kicad/issues/6221
2023-02-11 21:11:07 +00:00
e066454c61
Zones: use metric defaults and limits instead of mixed units
...
Update testcases to reflect new defaults
2023-02-11 07:39:29 -05:00
8b03c093f9
Move potentiometer pin model to r0, wiper, r1, and remove flipping code.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13741
2023-02-02 16:22:13 +00:00
9ca539b416
Remove TL072.031 from regression test.
2023-01-31 14:57:52 +00:00
c939b1ef76
Followed-by-3-digits doesn't guarantee a thousands separator.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13708
2023-01-30 21:22:48 +00:00
963e82ee7f
CADSTAR PCB: Correctly handle anticlockwise arcs
...
Also add some qa tests for EDA_SHAPE::SetAngleAndEnd
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13626
2023-01-30 19:56:22 +00:00
0ecad1ef2e
Add EDA_ANGLE::NormalizeNegative() and qa tests
2023-01-30 19:56:22 +00:00
5beb79bbdc
Disable spice directives test for now
2023-01-29 12:15:04 -05:00
675b6b5d5c
Fix logic error in ec4d377d
...
Also fixup goldens for importers for new default island mode
2023-01-27 10:16:56 -05:00
fef3274e8e
Eeschema: ERC checks handle connections between a common sub-circuit
...
Fixes #10926
Contains the following changes:
- Adds a new ERC_SCH_PIN_CONTEXT class which is used to provide deterministic
comparison between items causing ERC violations (e.g. pins) when associated
with a SCH_SHEET_PATH context.
- Adds association of SCH_SHEET_PATHs for ERC_ITEMs and the sub-schematic items
which caused an ERC violation. This allows correct display of markers on the
sheets of interest only, and allows correct naming resolution and cross-probing
from the ERC dialog.
- Adds a new ERC_TREE_MODEL class, derived from RC_TREE_MODEL, which correctly
resolves component references across heirarchical sheets using the associated
SCH_SHEET_PATHs. This allows sheet-specific component references to be displayed
correctly in the ERC results tree.
- Updates SCH_MARKER to only draw sheet-specific markers on the sheet causing
an ERC violation.
- Increments the schematic file version.
- When loading a schematic with legacy ERC exclusions, discards those of type
ERCE_PIN_TO_PIN_WARNING, ERCE_PIN_TO_PIN_ERROR, ERCE_HIERACHICAL_LABEL, and
ERCE_DIFFERENT_UNIT_NET as there is no safe way to automatically infer the
information which is now stored with these exclusions (sheet paths for error
location and related items). Requiring users to (once) re-add exclusions is
preferable to silently incorrectly matching new ERC issues to legacy exclusions.
2023-01-24 14:11:01 +00:00
24fd659bce
Eeschema: QA schematic loader now traverses hierarchical sheets
...
(Assumes all nested schematics are in the same directory as the root schematic)
2023-01-24 14:11:01 +00:00
9861ed1a5f
Don't special case power symbol re-annotation
...
When the designer asks to reset annotations, we reset all annotations
including power symbols. This may create additional churn in the files
but only when requested and is useful to fix schematic errors
Fixes https://gitlab.com/kicad/code/kicad/issues/13138
2023-01-23 13:19:01 -08:00
f6d9a2574b
Fix a QA simulation test on W1/msys2:
...
- Gives a bigger relative tolerance when comparing 2 values to pass some tests
- Fix error in test_sim_regressions.cpp for 3 TestNetlist() calls
2023-01-22 16:52:11 +01:00
232e4d34f1
Use default error limits. They're already relative to the value.
2023-01-22 14:35:27 +00:00
241dc0d96b
Add SPICE regression test.
2023-01-21 19:32:25 +00:00
259e382041
Add simulation regression test for legacy fixups.
2023-01-21 19:32:25 +00:00
e218c7109b
Test case for immediate SBCKT models.
2023-01-21 19:32:25 +00:00
6053b86a24
Add new spice regression test for windows path separators.
2023-01-21 19:32:25 +00:00
b2421c7d9f
Fix tiny bug in double 2 string formatting
...
- I forgot to handle the trailing dots when I added the fmt variant
- UIDouble2Str (the original) lacked the comma check
- Add unit test lol
2023-01-21 13:54:52 -05:00
6fa2eedb4b
Avoid the obsolete GetNextPin() call
...
This iterated over all pins to find the pin after a given item. Because
out pattern is consistently to iterate in the outer loop, this means
that we were an O(n^2) loop for the pins just to find their names. This
affected very large parts (e.g. FPGAs) when switching sheets to display
2023-01-20 14:12:15 -08:00
358a05a2c8
msvc warning fix
2023-01-16 22:44:19 -05:00
167e430fd9
Fix a compil issue in mocks.cpp.
2023-01-16 20:04:03 +01:00
355e817302
Move DefaultTransform definition to transform.cpp, so it can be shared
2023-01-15 19:17:51 +01:00
d063eb431b
Move FixupJunctions to SCHEMATIC
2023-01-15 19:17:50 +01:00
7da98a447a
qa: enable tool framework for the P&S debug tool
2023-01-12 23:37:07 +01:00
dd1a780d1f
qa: follow up router API changes in the PNS log player/regression test tool
2023-01-12 23:37:07 +01:00
1c90eeaa5a
Fix missing parameter in CADSTAR test
2023-01-10 16:48:07 -08:00
ee6e86d1db
Add conversion from CADSTAR SHAPE to SHAPE_POLY_SET
2023-01-10 22:28:01 +01:00
31202a2eb3
Fix a compil issue in QA tests
2023-01-09 19:44:04 +01:00
e9a21130a8
Add a few more MARKUP_PARSER test cases.
2023-01-08 23:33:36 +00:00
e7e151c46c
MARKUP_PARSER grammar should match everything, even incomplete markup
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13438
2023-01-09 00:17:11 +01:00
570fa246ae
Fix typo in matrix3 multiply, add unit tests
2023-01-05 21:06:52 -05:00
fc86998bf6
Ensure duplicate pin names get unique nets
...
Same pin name != same net name unless the pins are explicitly connected
Also add pin number to all unconnected pads ensuring they have unique
nets
Fixes https://gitlab.com/kicad/code/kicad/issues/13236
2023-01-04 11:32:15 -08:00
9b9795a87d
Reduce reliance on exception processing -- it's waay too bugy at present.
...
This moves some stuff to REPORTER APIs. Moving more stuff would be good,
but it probably too high-risk at present. We'll wait for 8.0 for that....
Fixes https://gitlab.com/kicad/code/kicad/issues/13359
2023-01-03 17:20:23 +00:00
7d40bbdf38
router: mark the head trace (as opposed to the 'fixed tail') with fully saturated color
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11386
2022-12-29 17:54:59 +01:00
6940333f40
Update test cases for unknown-variable = error.
2022-12-27 20:14:13 +00:00
438c4b58a3
Try to fix a QA issue probably due to the order some Ctors are called.
...
This is not the first time an issue is created by the order of ctors.
2022-12-27 19:56:04 +01:00
78e2f0fd4d
Sheet instance handling improvements.
2022-12-26 08:30:03 -05:00
b85fab9ab6
Support DXF ellipses and elliptical arcs
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12563
2022-12-24 22:46:07 -05:00
7abfa46531
Inferred sim value improvements, and a unit test for them.
2022-12-21 17:03:49 +00:00
a3a2e2e5b1
Update demos and legacy qa files SpiceMapping -> Spice_Node_Sequence.
...
Also removes migration in the code as it will no longer be needed.
2022-12-19 12:04:53 +00:00
50ccc4e6da
Fix issue converting legacy SPICE models.
...
1) if a legacy model references a library then we need to see if said
libraray exists and read model from it if so
2) legacy node ordering is by index, not pin name
3) we can't auto-generate a pin map when we don't know the pin names,
so don't try
2022-12-14 13:36:28 +00:00
ba11de6e66
Update QA test schematics with valid and invalid variants
2022-12-09 02:14:05 +00:00
63da407345
Add tests for no connect flag
2022-12-09 02:14:05 +00:00
cfbf14ebfd
Attempt to fix build issue with NGSPICE off.
2022-12-08 23:57:42 +00:00
ce8fa2ad00
Move previous fix to subclass (which overrides the base class).
2022-12-07 17:13:19 +00:00
5aa204e194
Another attempted sim testcases fix.
2022-12-07 15:07:25 +00:00
b9287968d6
Update symbol default prefixes after updating instance data.
...
Also moves the sim model fixups after the instance data updating as
it uses the prefixes.
2022-12-07 01:34:56 +00:00
69448afb47
Don't run simulation twice when the sim command is overridden.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12731
2022-12-07 01:34:56 +00:00
38906397d2
Move V6->V7 sim model migration from sheets to screens.
...
Also moves passive RLC inference out from migration to just-in-time
creation for the simulator or netlisting.
Also fixes a version guard mismatch because the spice migration was
done inside UpdateSymbolInstances (which has its own version guard).
Also changed UpdateSymbolInstances to UpdateSymbolInstanceData so
someone else in the future doesn't think it's a general-purpose symbol
instance updater.
2022-12-06 16:01:18 +00:00
8260f0ee13
Add support for unitless values to PCB_EXPR_EVALUATOR.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13016
2022-11-29 14:24:20 +00:00
9055043409
Sim QA: Test for duplicates and wrongly deduplicated parameters
...
(adapt tests to the names of the newly deduplicated parameters)
2022-11-29 15:04:38 +01:00
b025b103de
Sim Model Editor: Make the VBIC model the first BJT model to select
2022-11-29 10:13:20 +01:00
484620eeb5
Sim QA: Add test for VDMOS
2022-11-29 09:48:01 +01:00
5fb191e4d6
Sim QA: Test all BJT parameters in each model
2022-11-28 09:49:48 +01:00
26644952a4
Sim QA: Test all diode parameters
2022-11-28 08:01:50 +01:00
d836fbaaaa
Sim: Add VBIC model support
...
Update generate_sim_model_ngspice_data.bash a little, but it's still
outdated.
2022-11-28 04:45:36 +01:00
f2fb734e06
Sim QA: Add test for Numparam expressions inside .subckt
2022-11-27 06:32:17 +01:00
08d37d2795
Sim QA: Add Spice .subckt parsing tests
2022-11-26 10:24:11 +01:00
9766351ee6
Sim: Update QA to tests to match the new model upgrade scheme
2022-11-25 05:38:21 +01:00
0b0c35c4dc
Adjust test result.
2022-11-23 21:37:50 +00:00
cd92088b7a
Fix disabled schematic page numbering unit tests.
2022-11-23 08:05:35 -05:00
d37015bada
Temporarily disable unit tests so builds pass.
2022-11-22 19:08:08 -05:00
833146cf50
Sim QA: Fix QA errors
...
Let's not allow units in fields for now. (is 1m one meter or one milli?)
2022-11-22 21:18:01 +01:00
729e64f33a
Add call modification missed from previous commit.
2022-11-22 17:25:09 +00:00
e9fe59a28c
Sim: Rename the missed Sim_* fields to Sim.*
2022-11-21 03:33:11 +01:00
6969362813
Sim Model Editor: Don't provide library-only models as builtins
2022-11-20 22:07:39 +01:00
8498630876
Ibis: correctly load QA files up to v2.1
2022-11-20 19:10:46 +00:00
059ca8fc48
Sim: Rename Sim_* fields to Sim.*
2022-11-20 03:37:54 +01:00
e09e521162
Remove GUI calls from netlisting.
2022-11-18 15:29:16 +00:00
cab5f65685
qa/pns: added test case for via drag walkaround
2022-11-18 15:14:34 +01:00
bf4671aa16
qa: PNS debug tool should draw COMPOUND shapes too...
2022-11-18 15:14:34 +01:00
e7c43ca20a
Sim: Remove inference from Reference and Value
2022-11-18 08:39:15 +01:00
a61ac363c2
Excise the remaining occurrences of "Alias" for derived symbols.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12895
2022-11-16 18:37:40 +00:00
33594e92fa
router: qa test case for backspace (unfix) regression
2022-11-15 23:05:53 +01:00
26a38797c7
router: log and replay the 'unfix' events too
2022-11-15 23:05:53 +01:00
3dd2ae762d
Refactor step export to use our normal board processing routines
2022-11-12 21:27:10 -05:00
9d525e82f5
Fix qa tests so they don't assert on cleanup.
2022-11-11 20:31:39 +00:00
c07477b94c
Move to explicit symbol properties mapping
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12845
2022-11-08 22:19:08 -05:00
Jeff Young
jean-pierre charras
Mike Williams
Seth Hillbrand
Wayne Stambaugh
JamesJCode
Ian McInerney
Fabien Corona
Marek Roszko
Jon Evans
Roberto Fernandez Bautista
Tomasz Wlostowski
Barabas Raffai
Mikolaj Wielgus