haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
28,620 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

464 Commits

Author SHA1 Message Date
Jeff Young 8b5f393804 DRC bug fixes and debugging improvements. 
1) Don't wait for UpdateUserInterface to build the (global) list of
layer names.

2) Report clearance resolution between a silk layer and a mask layer.

3) When writing DRC reports, include info about the violating rule.

4) Report "no relevant layers" if we fail to find anything to write
a clearance resolution report about.

Fixes https://gitlab.com/kicad/code/kicad/issues/8963
 2021-08-17 15:41:12 +01:00
Jeff Young 1a252b4f96 Add a compile error for ill-defined rules, and more performance. 
Also adds const-safety to GetBoard().
 2021-08-16 12:14:17 +01:00
Jeff Young eaccbce48b Fix logic errors in progress reporting in a couple of DRC providers. 2021-08-15 22:24:44 +01:00
Jeff Young 1ec70d30af Cherry-pick some 7.0 Clearance Resolution improvements. 
6.0 will be in the field for a long time, and the better the debugging
tools we have available the less costly it will be to maintain.

Fixes https://gitlab.com/kicad/code/kicad/issues/8961
 2021-08-15 19:03:58 +01:00
Jeff Young 41619ebbe2 Decouple PROGRESS_REPORTER interface from implementations. 2021-08-14 21:05:49 +01:00
Jeff Young e5586fb974 Accept legacy hole token as well as new hole_size. 2021-08-13 21:28:11 +01:00
Jeff Young d34e9e8946 Code safety. 2021-08-13 21:28:11 +01:00
Jeff Young 4c3954aea8 Clearer DRC rule token name for hole_size. 2021-08-13 16:18:56 +01:00
jean-pierre charras f4a7565b9c fix a compil warning 2021-08-11 08:16:26 +02:00
Jeff Young 13fc16b03f Fix uninitialized variable. 2021-08-10 16:51:30 +01:00
Jeff Young a208dac8d8 Convert hole clearance tests from NPTH holes to all holes. 2021-08-09 22:26:00 +01:00
Jeff Young bafa105ed0 Enforce hole clearance on NPTHs in zones. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8924
 2021-08-06 18:16:38 +01:00
Jeff Young faa1ff4ec6 Add false-negative DRC tests (and fix first bug found by them). 2021-07-31 16:41:44 +01:00
Jeff Young 8c69a856fc Add zone filler tests. 
One test has pads of a bunch of different shapes and provokes some
errors to make sure they're caught.

The others are all past issues with the zone filler to make sure we
don't suffer any regressions.  (They should all just pass with no DRC
errors.)
 2021-07-30 17:09:24 +01:00
Jeff Young 6aaf4413b3 Fix kicad_string.h / string.cpp mismatch. 
They don't define a KiCad string class, so the header file name was
somewhat misleading. But the fact that they didn't match definitely
made coding more difficult.
 2021-07-29 16:03:25 +01:00
Jeff Young f221220fe2 Rename layer ids file. 
It hasn't had anything to do with colors or visibility for some time
now.
 2021-07-29 16:03:25 +01:00
Jeff Young 46338403e7 Unwrap some std::library typedefs. 2021-07-28 22:16:38 +01:00
Wayne Stambaugh 8fd83cbb95 Pass wxPoint objects by reference instead of on the stack. 2021-07-26 15:35:33 -04:00
Jeff Young 0fb864d596 Pull some name changes back from 7.0 to ease merging. 2021-07-21 20:58:59 +01:00
Wayne Stambaugh cf00319c85 More NULL expunging. 2021-07-20 07:27:18 -04:00
Wayne Stambaugh 6c3ba1c20b Coverity issue fixes. 
Issues #332032, #332086, #332157, and #332171.
 2021-07-09 10:56:35 -04:00
Jeff Young 4aa8318dc2 More error message regularization. 2021-06-27 14:24:02 +01:00
Jeff Young 81fc710a5d Use consistent terminology. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8681
 2021-06-26 10:11:41 +01:00
Jeff Young 232ffe97be Diff pair gap only overrides netclass clearance when it's smaller. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8676
 2021-06-24 16:56:53 +01:00
Jeff Young 096e342386 Prefix TRACK, ARC and VIA. 2021-06-11 22:07:02 +01:00
Jeff Young 16b0147af8 Prefix DIMENSION types. 2021-06-11 17:59:44 +01:00
luz paz f968fc8719 Fix source comment / documentation typos 2021-06-09 19:32:58 +00:00
Marek Roszko 10e60acf34 Clean up including of board_design_settings.h 2021-06-06 15:03:42 -04:00
Marek Roszko b610b905fc Cleanup track.h includes 2021-06-06 09:06:55 -04:00
Ian McInerney 4f05262705 Cleanup includes in board.h and footprint.h 2021-06-03 20:19:52 +01:00
Seth Hillbrand f40f696c37 Don't extract dp segment info from minimal-length 
segments with 1IU of length are approximately parallel to everything and
the distance projections break down into rounding errors

Fixes https://gitlab.com/kicad/code/kicad/issues/8541
 2021-06-03 08:44:17 -07:00
Seth Hillbrand 7f56ff4d42 Minor performance improvement 
Don't keep searching the DRC RTree for collisions after we detect a true
(not clearance-based) collision
 2021-06-02 08:15:37 -07:00
Jeff Young 00ed75b891 Fix DRC performance with multi-layer keepout zones. 
The main issue was a parameter mismatch which caused On^2 behaviour
for zone layers.

But there are several other performance optimizations here, along
with status bar updating for zones while running the dissallow test.

Fixes https://gitlab.com/kicad/code/kicad/issues/8521
 2021-06-02 14:11:43 +01:00
Jon Evans 6381ffd10a Fix diff pair coupling test when gap constraint is in a different rule 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8519
 2021-05-31 10:13:05 -04:00
Marek Roszko 382dca4e6f Fix uninitialized member warnings 
Based on PVS Studio report
 2021-05-30 20:01:01 -04:00
Jeff Young 5f22025611 Don't drop text on Edge.Cuts when plotting. 
While -our- user model is that Edge.Cuts is just for edges, it's best
not to dictate a particular model to users.

ADDED a DRC error when text (or a dimension) appears on the Edge.Cuts
layer.

Fixes https://gitlab.com/kicad/code/kicad/issues/8470
 2021-05-24 19:54:52 +01:00
Jeff Young e93e9fa3e5 Add rudimentary type checking to rule eval with reporter. 
Also cleaned up existing error reporting to not expend CPU cycles
when there was no reporter.

Fixes https://gitlab.com/kicad/code/kicad/issues/8438
 2021-05-20 23:06:24 +01:00
Jeff Young 4c3d78dec0 Break out separate holes-co-located violation. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8456
 2021-05-20 10:36:56 +01:00
jean-pierre charras 56058314be Fix minor Coverity warnings and minor compil warnings. 
(uninitialized or shadowed vars)
 2021-05-05 08:58:55 +02:00
Marek Roszko 03cf2b517f Enum class PAD_ATTR_T 
Renamed such that python stays the same
 2021-05-01 10:51:54 -04:00
Marek Roszko 21fde9b629 enum class PCB_SHAPE_TYPE_T 2021-04-30 22:36:12 -04:00
Jeff Young 7df9fa0631 Diffpair gap should only override clearance within a coupled diffpair. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7975
 2021-04-30 18:39:21 +01:00
Jeff Young c149ed8905 Allow diffpair gap to override normal netclass clearance. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7975
 2021-04-29 10:23:49 +01:00
Jeff Young b65b1f8e9c Revert NPTH commit, and add some comments. 2021-04-26 17:33:49 +01:00
Jeff Young e3eacafbcb Run hole clearance tests on NPTH pads, but not copper clearance. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8295
 2021-04-25 17:55:43 +01:00
Jeff Young b7279c0bab Don't allow rounding errors to flag DRC violations in hole2hole. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8295
 2021-04-25 17:55:43 +01:00
Jeff Young e5d029af6b Margin layer missing from some edge clearance tests. 
Fixes bug reported on KiCad Forums.
 2021-04-21 21:58:47 +01:00
Jeff Young 23a1f8b17a Enforce board minimum clearance over local clearance overrides. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8199
 2021-04-15 21:44:04 +01:00
Jon Evans 4920692bcd DIFF_PAIR_GAP_CONSTRAINT does not need to be restricted to two items 
We just need one item to see what netclass we're in; the constraint
itself is specific to diff pairs so the condition doesn't need to be.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8205
 2021-04-14 23:43:43 -04:00
Jeff Young d79057b83a Fix merge wreckage in building netclasses. 2021-04-13 17:56:50 +01:00