haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
36,726 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

731 Commits

Author SHA1 Message Date
Jeff Young 6d22b8c6ed Negative clearance means test won't run, not rule won't match. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13947
 2023-02-16 18:10:26 +00:00
Seth Hillbrand f56fcb0a14 Better handling of vertex sorting 
Nominally, the zcode of a vertex is unique.  This is not 100% true,
however, as we must interlace two 32-bit numbers into a single 32-bit
number.  Sorting needs to account for the possibility that the zcode
will be the same while other elements of the vertex are different.  This
commit fixes the broken boolean logic to more clearly handle these cases

Fixes https://gitlab.com/kicad/code/kicad/issues/13867

(cherry picked from commit e7fe69b97f)
 2023-02-13 11:23:14 -08:00
Seth Hillbrand 90a388571e Fix copy-pasta 
testing 'othervia' for dynamic_cast success needs to use `othervia`
rather than `via` which might still be null

Fixes Sentry issue KICAD-5K
 2023-02-10 13:33:21 -08:00
Jeff Young a59c1afa53 Fix two bugs in RTree polygon collions special case. 
1) Special case doesn't work for polygons with holes
2) Fix special case to handle intersecting lines where neither end is
   in the polygon.

Note that only (1) is required for the bug below.  (2) was just
discovered while implementing (1).

Fixes https://gitlab.com/kicad/code/kicad/issues/13779
 2023-02-04 13:46:40 +00:00
Jeff Young 8ecf64b6c5 Don't run DRC rules on non-existant layers. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13753
 2023-02-03 15:08:31 +00:00
Jeff Young 235925d62c Clearer reporting of negative clearances. 2023-02-03 15:08:31 +00:00
Jon Evans 26b9d2f5ac DRC: Allow disabling DP constraints in specific areas 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13743
 2023-02-01 23:11:39 -05:00
Jeff Young 50e9685490 Check for tented vias before expanding solder mask. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13705
 2023-01-30 17:56:35 +00:00
Jeff Young e886ccacbd Cleanup unused local variable. 2023-01-24 23:45:55 +00:00
Jeff Young 00e2bbac5a Special-case net-ties for solder mask bridging. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13646
 2023-01-24 11:33:08 +00:00
Jon Evans 12b0a12d74 Handle DP checks for board minimum rules 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13640
 2023-01-23 17:45:16 -05:00
Jeff Young ece775c53c Blind/buried vias are drilled, and drilled holes need to avoid prior-burned holes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13627
 2023-01-23 16:25:29 +00:00
Jeff Young e490728226 Don't run the footprint checker's shorting pads routine at board level. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13555
 2023-01-16 16:44:16 +00:00
Jon Evans c530bdb5a1 Rename GetSelectMenuText to GetItemDescription 
This descriptive text is used for many more things than
just the select menu these days.
 2023-01-11 22:27:44 -05:00
Seth Hillbrand 14339aa786 Fix shadowing variable 
Move check into switch block
 2023-01-03 17:15:44 -08:00
Jeff Young 375fdb7a49 Exact clearance is allowed; less than clearance is an error. 
Also fixes a bug where the units weren't shown for extra precision
numbers.

Fixes https://gitlab.com/kicad/code/kicad/issues/13262
 2023-01-04 00:03:11 +00:00
Jeff Young 0094a0fc15 Treat teardrops as tracks not zones for disallow constraints. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13264
 2022-12-26 11:33:09 +00:00
jean-pierre charras eef47c2a79 DRC: ensure tracks are tested against holes, even if hole clearance is set to 0. 
Even with clearance = 0, copper to hole must be tested because it cannot be
inside the hole
 2022-12-23 14:06:10 +01:00
Jeff Young e28f6ecc00 Fetch a better location for keepout area collsions. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13220
 2022-12-21 18:22:15 +00:00
Seth Hillbrand 2fd500e20b Respect the "report all errors" checkbox 
When we have objects spanning multiple layers, the user doesn't need to
see every layer/hole combination violation if they do not request it

(cherry picked from commit c07043e762)
 2022-12-12 11:14:38 -08:00
Jeff Young 492e6548ff If item is on mask layer then we won't call it again on copper layer. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13075
 2022-12-10 13:51:00 +00:00
Jeff Young 295ef6588d Fix uninitialized variable. 2022-12-05 14:42:05 +00:00
Seth Hillbrand 92266635cc Add an advanced config value for the minimum sliver 
The hard coded value was too small for certain calculations.  Better to
have a configurable value that is initially set to our error level to
allow for deviations that don't meet the visibility test for spikes.
These have become more apparent with Clipper2
 2022-12-03 16:03:43 -08:00
Seth Hillbrand b5bd633625 Strict-order points in connection_width 
The connection width checker uses morton codes to order elements.  The
sort should be primarily morton-based but needs to be stable in order to
ensure that nextZ/prevZ elements are properly placed as the actual
next/prev elements in the list.  Otherwise, hitting a fracture point
might make us skip in the wrong direction

Fixes https://gitlab.com/kicad/code/kicad/issues/12831
 2022-12-03 16:03:43 -08:00
Jeff Young 3501ad1b4d Record layer for starved thermal exclusions. 2022-12-01 18:04:34 +00:00
Jeff Young 19eab62516 More safety around ratsnest state. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13011
 2022-11-30 13:00:21 +00:00
Jeff Young 8260f0ee13 Add support for unitless values to PCB_EXPR_EVALUATOR. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13016
 2022-11-29 14:24:20 +00:00
Seth Hillbrand d232ade752 Remove cloned items from groups 
When destroying, the group must be null and there's no group purpose in
the DRC checks
 2022-11-28 09:11:20 -08:00
Jeff Young 1e3186b9cb Allow pad-to-copper-graphic collisions in net-ties. 
This is done under the same conditions as track-to-copper-graphic --
the pad or track must also collide with a net-tie pad, and the pad or
track to copper-graphic collision must be within the boundary of said
pad.

Fixes https://gitlab.com/kicad/code/kicad/issues/13008
 2022-11-26 15:04:33 +00:00
Jeff Young 4aff5c7618 Keep courtyard caches alive during move. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12999
 2022-11-25 17:20:11 +00:00
Jeff Young 5de4bfde93 Move drilled NPTH holes to hole-clearance checking. Edge-clearance 
checking is just for milled holes (slots).

Fixes https://gitlab.com/kicad/code/kicad/issues/12980
 2022-11-23 13:31:51 +00:00
Jeff Young 97fd99ec99 Re-resolve netclasses after assigning netclass to pattern. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12965
 2022-11-22 14:54:08 +00:00
Alex 5e7c4b734c Small optimizations in DRC and SHAPE_POLY_SET. 2022-11-17 02:10:22 +05:00
Jeff Young 619c340d92 Handle holes when building outlines for copper sliver checker. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12797
 2022-11-01 23:33:44 +00:00
Wayne Stambaugh 6a0db3e7e2 Fix Coverity warnings. 2022-10-26 14:39:44 -04:00
Jeff Young 9380b9a451 Trim pad layers to current board before comparing. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12758
 2022-10-25 23:53:10 +01:00
Jeff Young cef7cd8f7c Move default font to RENDER_SETTINGS. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12723
 2022-10-22 21:32:42 +01:00
Jeff Young d16b23d16e Name shortening and line-break reduction. 2022-10-21 18:41:39 +01:00
Jeff Young de5980b92e Share more of the courtyard collision highlighting code. 2022-10-14 10:42:07 +01:00
Jeff Young 11dc5424cb Pull interactive courtyard checker out of move tool to share with router. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12594
 2022-10-14 00:48:37 +01:00
Jeff Young 098e96f1c7 Use more precise formatting in DRC messages when less precise values are identical. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12587
 2022-10-06 22:18:53 +01:00
Jeff Young 9119b5072a Respect DRCEpsilon in diff-pair coupling test. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12587
 2022-10-06 22:18:53 +01:00
Jeff Young d6c7f46842 Formatting. 2022-10-06 22:18:53 +01:00
Jeff Young 6927e75eae Handle keepout areas with holes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12581
 2022-10-06 15:08:56 +01:00
Seth Hillbrand b4f3390626 Drill size is absolute 
Use hole plating size for visibility only, not zone filling, routing or
DRC
 2022-10-04 09:52:40 -07:00
Jeff Young e49de68a59 Implement a more durable zone bounding box caching strategy. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10821
 2022-10-01 22:10:43 +01:00
Jeff Young d67437a2aa Move ratsnest exclusion processing to a post-pass. 
Also fixes a few cases where we were unnecessarily rebuilding
connectivity more than once for an operation.
 2022-09-29 17:08:49 +01:00
Jeff Young 503385f52e Don't use FindNamedPad for net-tie logic. It only reutrns the *first* 
pad of a given number.

Also improves other DRC logic to tighten up the net-tie rules now that
we know which pads are allowed to short with which other pads.

Also removes the "Overlapping pads" DRC violation now that we know
whether or not overlapping pads in a net-tie footprint constitute a
short.

Fixes https://gitlab.com/kicad/code/kicad/issues/12506
 2022-09-25 17:38:31 +01:00
Seth Hillbrand 0150655ed3 Fix missing DRC check with via 
When the via is first and not second in our ordering, the hole-copper
clearance was not checked as the track did not have a hole.

We also calculated the NPTH-via clearance incorrectly in the inspector
 2022-09-20 13:43:01 -07:00
Jeff Young 64a6fc0fd4 Push UNITS_PROVIDER down into a low-level mixin. 
This allows us to also construct cheap UNIT_PROVIDERs for specific
tasks when necessary.
 2022-09-19 17:10:59 +01:00