4904ece0b5
eeschema gal: keep grid visibility setting when switching between back-ends
2018-10-11 18:45:18 +02:00
4d8534a7a6
libedit: Prevent segfault when deleting part
...
emptyScreen() sets the current part to NULL. This gracefully handles
the case by allowing a cleared screen when no part is currently
selected.
2018-10-11 09:22:54 -07:00
5c8c1cdb8f
Eeschema doesn't show highlight net until a screen redraw is made.
...
Fixes: lp:1796989
https://bugs.launchpad.net/kicad/+bug/1796989
2018-10-11 14:19:29 +02:00
bea75753dd
Eeschema fix: highlight component from pcbnew doesn't switch sheets
...
Fixes: lp:1797249
https://bugs.launchpad.net/kicad/+bug/1797249
2018-10-11 11:28:07 +02:00
0dfd0c5f52
Minot cosmetic enhancement
2018-10-11 11:26:59 +02:00
0090bea24e
eeschema-gal: cache & update bboxes of EDA_ITEMS on each redraw
2018-10-10 17:27:21 +02:00
9b027628ef
Symbol editor: Fix usability issues of mirror and rotation commands
...
Fix also mirrorX and mirrorY command to have the same behavior as the schematic editor
Fixes: lp:1797090
https://bugs.launchpad.net/kicad/+bug/1797090
2018-10-10 16:42:58 +02:00
06dccf715d
Code cleanup.
2018-10-10 14:28:03 +01:00
779ef044b7
Fix wxGrid column dragging bugs.
...
Close an open editor when dragging (as wxWidgets won't move it).
Make sure native column headers aren't in use where we need dragging:
their interaction with wxWidgets' dragging is buggy.
Fixes: lp:1796398
* https://bugs.launchpad.net/kicad/+bug/1796398
Fixes: lp:1796396
* https://bugs.launchpad.net/kicad/+bug/1796396
2018-10-09 21:33:43 +01:00
5f0ffe8490
Copy isDangling flag when changing label type.
...
Fixes: lp:1796775
* https://bugs.launchpad.net/kicad/+bug/1796775
2018-10-09 21:33:43 +01:00
55c1ca1191
Handle pin sorting properly for values.
...
The pin number sorter doesn't handle units at all, and seems to
stumble on negative numbers.
Fixes: lp:1796869
* https://bugs.launchpad.net/kicad/+bug/1796869
2018-10-09 14:56:29 +01:00
cbf74d6939
Fix off-grid block paste
...
Center point of a block may not always be located on a grid point,
therefore it needs to be rounded to the grid size to prevent off grid
component placement.
2018-10-09 11:08:56 +01:00
6e2b7521d0
Coding style and lint fixes.
2018-10-09 11:08:56 +01:00
06e63c3073
Add control over worksheet colour in eeschema.
2018-10-09 11:08:56 +01:00
637029c292
Remove polygon fix as it causes more issues than it solves.
2018-10-09 11:08:56 +01:00
5a910e9ee3
Make sure filled polygons are closed when rendering.
2018-10-09 11:08:56 +01:00
4a65df8281
Add default case in edit_label.cpp (-Wswitch)
...
This should never ben hit as it's defended against above,
but lack of a default causes lots of -Wswitch warnings, so
add an assert and a return.
2018-10-09 11:08:56 +01:00
9dfcc839a4
Fix color issues with cursor and sheet pins.
2018-10-09 11:08:56 +01:00
4a92a5e628
Fix a Eeschema crash when using a SYMBOL_PREVIEW_WIDGET. Fix also a few draw artifacts.
2018-10-09 11:08:56 +01:00
a6d014d959
Fix some artifacts when drawing items, both on Cairo and Opengl.
...
Fix also incorrect selection of De Morgan style selection in SYMBOL_PREVIEW_WIDGET.
2018-10-09 11:08:56 +01:00
2d5baac77d
Fix up zoom and pan issues entering/leaving sheets.
2018-10-09 11:08:56 +01:00
929786ce50
Fixes to grid color and some more CLangTidy fixes.
2018-10-09 11:08:56 +01:00
0af31e1bf0
Fix CLangTidy warnings and improve SNR.
2018-10-09 11:08:56 +01:00
0058ef5825
Eeschema: fix a crash at startup in OpenGL engine, when Eeschema is started from Kicad.
...
Can be platform dependent. The crash was due to a wxPaintEvent fired before the GAL engine is fully initialized.
2018-10-09 11:08:56 +01:00
88cdce8d62
Make SYMBOL_PREVIEW_WIDGET working, and using the canvas type of the caller. Fix an issue with F3 zoom key in libedit.
2018-10-09 11:08:56 +01:00
6f89b41f18
Cleanup.
2018-10-09 11:08:56 +01:00
3b59c6cf0a
Don't add item to view twice.
2018-10-09 11:08:56 +01:00
33386ec980
Fix zoom issues in Eeschema (F1 to F4 and popup zoom commands) Fix also not saving the Gal Canvas type on eeschema exit.
2018-10-09 11:08:56 +01:00
f283667fb0
add option to switch between opengl and cairo in eeschema (step 1)
2018-10-09 11:08:56 +01:00
f9faa6ea16
Reduce "Clarify Selection" menus.
2018-10-09 11:08:56 +01:00
97c83766db
Refresh issues around sheet pins.
2018-10-09 11:08:56 +01:00
96724af2c4
Ensure junctions and no-connects are visible even on fat wires.
...
Also adds a preference for junction size.
Fixes: lp:1545422
* https://bugs.launchpad.net/kicad/+bug/1545422
2018-10-09 11:08:56 +01:00
ca3751fbbb
Add GAL refresh for some more commands and remove unused DC params.
2018-10-09 11:08:56 +01:00
8e09aa554a
Improve dangling pin drawing logic.
2018-10-09 11:08:56 +01:00
268565ee41
Refresh component when children change.
2018-10-09 11:08:56 +01:00
37cfa3fed9
Cleanup unused and redundant stuff.
2018-10-09 11:08:56 +01:00
e2ea9b772a
Fix offset issue when moving text.
2018-10-09 11:08:56 +01:00
d9d2822fe0
Fix cross-probing.
2018-10-09 11:08:56 +01:00
9f9251c11d
Minor code cleanup.
2018-10-09 11:08:56 +01:00
2b6e3de90e
Get rid of asserts when adding line segments.
2018-10-09 11:08:56 +01:00
1a0f3b79cc
Fix SCH_BITMAP handling in gal.
2018-10-09 11:08:56 +01:00
e55763947e
Set the reight grid visibility at start. Display axis in libedit and viewlib.
2018-10-09 11:08:56 +01:00
98296334fd
Hook up panning options to GAL canvas.
2018-10-09 11:08:56 +01:00
5b602d02ab
Set block start position when grabbing single items.
2018-10-09 11:08:56 +01:00
6f0c6f946c
Fixup some more cursor issues.
2018-10-09 11:08:56 +01:00
b09a4b341c
Update moved items so they get reinserted into the RTree.
2018-10-09 11:08:56 +01:00
fee52e127f
Add line style drawing.
2018-10-09 11:08:56 +01:00
808beed191
Warp pointer after context-menu duplicate.
2018-10-09 11:08:56 +01:00
1e3a5c1b21
Fixup of last commit.
2018-10-09 11:08:55 +01:00
0063f2c12d
Stroke rectangles after filling so fill doesn't cover 1/2 of stroke.
2018-10-09 11:08:55 +01:00
48688b5074
Hook up "always show cursor" preference.
2018-10-09 11:08:55 +01:00
f1346030d7
sch_painter.cpp: fix a few incorrect color selections Fix also dangling symbol thickness of bus entries
2018-10-09 11:08:55 +01:00
4fe58922aa
Draw lines in wire, bus, or graphic color.
2018-10-09 11:08:55 +01:00
fa0124bee7
Enforce a minimum line thickness for labels.
2018-10-09 11:08:55 +01:00
4161bb6756
Overhaul block logic to support rotate/mirror on the fly.
...
The old code delayed duplicating till the end which means the
rotate/mirror would affect the original, and then be duplicated
leaving the original incorrectly rotated/mirrored.
2018-10-09 11:08:55 +01:00
906c52deff
minor compil warnings and drawings fix
2018-10-09 11:08:55 +01:00
3c82ad3220
Finish up the block rotate/mirror fixes.
...
Block rotate and mirror now work like they do in Pcbnew (that is
they're treated as part of the block move/duplicate/whatever
rather than finishing it).
Fixes: lp:1780794
* https://bugs.launchpad.net/kicad/+bug/1780794
2018-10-09 11:08:55 +01:00
924e56e076
WIP for block rotate and mirror.
...
Block rotate now doesn't drop the block, but it does introduce one
extra undo step per rotate.
Fixes: lp:1780794
* https://bugs.launchpad.net/kicad/+bug/1780794
2018-10-09 11:08:55 +01:00
7216eda202
Fix bugs in block operations.
...
1) when duplicating don’t keep original hidden until end of drag
2) reset selectionArea when showing it so it doesn’t flash in its previous location
3) center a pasted block on the cursor
4) don’t draw the source selectionArea when pasting a block
5) implement selection-style highlighting for contents of blocks
6) add pasted items to view so they don’t disappear when the block is placed
Fixes: lp:1747197
* https://bugs.launchpad.net/kicad/+bug/1747197
2018-10-09 11:08:55 +01:00
27df8937b8
Apply a bit of transparency for body backgrounds while dragging.
2018-10-09 11:08:55 +01:00
7d5e4de815
Implement MoveCursorToCrossHair.
2018-10-09 11:08:55 +01:00
cb8e6c0df5
Handle GAL view refresh for breaking wires.
2018-10-09 11:08:55 +01:00
38f38b16c0
Fix dissappearance of moved items.
2018-10-09 11:08:55 +01:00
5fd20ee786
Implementation of ERC markers.
2018-10-09 11:08:55 +01:00
47189034aa
Grid settings for LibEdit.
2018-10-09 11:08:55 +01:00
e45e3b3640
Fix bug with Preferences turning hidden items to black.
2018-10-09 11:08:55 +01:00
bbe1d996fd
Fix initialization order issue when switching symbols in LibEdit.
2018-10-09 11:08:55 +01:00
269e8159d4
Grid settings for LibEdit.
2018-10-09 11:08:55 +01:00
9e9db3afe5
Start an empty document with a reasonable grid size.
2018-10-09 11:08:55 +01:00
d7178c7833
Implement GAL refresh for a bunch of operations.
2018-10-09 11:08:55 +01:00
afeebc8944
Grid settings for Eeschema GAL.
...
Split antialiasing options out from display options. Move
antialiasing to common. Duplicate the rest of display options
for Eeschema.
Implement OnSelectGrid and hookup GAL canvas refresh to
SetPresetGrid.
Add Grid Settings... to View menu and move Show Grid from
preferences to View Menu to match Pcbnew.
2018-10-09 11:08:55 +01:00
8390b7a7ac
Don't paint GAL canvas when it isn't shown.
...
Fixes: lp:1790502
* https://bugs.launchpad.net/kicad/+bug/1790502
2018-10-09 11:08:55 +01:00
c5330ac0bf
Implement zoom for GAL canvas.
2018-10-09 11:08:55 +01:00
a67d8c60df
Fix text size measurement.
...
5.0 doesn't set the GAL's line width. It gets away with this since
it's using the same GAL to measure as to set up the drawing, so
the width happens to be set correctly for other reasons. 5.1 uses
a separate GAL and so isn't so lucky.
2018-10-09 11:08:55 +01:00
1c52824913
Rewrite unit/convert handling so it also works for LibEdit.
2018-10-09 11:08:55 +01:00
e9c974fcdc
Fix issues with orientation and justification.
...
Support all symbol orientations. (Yes, SCH_COMPONENT said only the
first 8 were used, but it lied.)
Fix cases where SetTextAttributes() was overwriting previously-
set justifications.
Correct rotation of vertical text.
Fix issue where bold global label would affect thickness of next
label's outline.
2018-10-09 11:08:55 +01:00
c3479154ca
Fix draw order issues in eeschema and libedit.
...
Eeschema (where only the parent component is in the view) uses
draw order.
LibEdit (where the individual items are in the view) uses the
viewPriority setting.
2018-10-09 11:08:55 +01:00
917943f8f8
Uniform handling of hidden objects.
2018-10-09 11:08:55 +01:00
17ce36d4b7
Add dangling end support for lables and lines.
2018-10-09 11:08:55 +01:00
6eafb9a2fd
Convert Rescue Symbols dialog previews to GAL.
2018-10-09 11:08:55 +01:00
893f7641ce
Handle hidden and dangling pins.
2018-10-09 11:08:55 +01:00
8a017d99d2
Fix pin drawing offsets and implement electrical type drawing.
2018-10-09 11:08:55 +01:00
538a5d49ee
Fix up GAL version of Symbol Viewer.
...
Also includes some preliminary work for supporting hidden pins,
pin electrical names, and other preferences.
2018-10-09 11:08:55 +01:00
da4fb4ae3a
Move galDisplayOptions access from pcbnew to common.
2018-10-09 11:08:55 +01:00
a03dc577f8
Add support for units.
2018-10-09 11:08:55 +01:00
7cbfa08ddd
Move symbol chooser dialog preview to GAL.
2018-10-09 11:08:55 +01:00
8e915ae8d8
Add support for LIB_ALIAS objects.
2018-10-09 11:08:55 +01:00
8b4f01b6b7
Add common property initialisation to sch_draw_panel.
2018-10-09 11:08:55 +01:00
a3563851b2
eeschema-gal: started work on library viewer canvas
2018-10-09 11:08:55 +01:00
48d36f854e
eeschema-gal: fix cursor shape switching
2018-10-09 11:08:55 +01:00
ccb594f599
eeschema-gal: support for global labels and bitmaps
2018-10-09 11:08:55 +01:00
d8b9899516
eeschema-gal: configurable worksheet & grid colors
2018-10-09 11:08:55 +01:00
5f7c923b8b
eeschema-gal: post-rebase fixes
2018-10-09 11:08:52 +01:00
90c7c60471
eeschema-gal: initial GALified version. Lots of stuff still to do!
2018-10-09 11:08:52 +01:00
14fed877c8
eeschema-gal: factor out libedit controller code into separate directory
2018-10-09 11:08:52 +01:00
c024fce625
eeschema-gal: moved libedit to a separate directory
2018-10-09 11:08:52 +01:00
cb90e5b9e2
libedit: Fix memory leak
...
The copy of the original lib_part was not released when aliases could
not be located.
2018-10-08 09:51:26 -07:00
d2906f7975
eeschema: fix mistaken wire removal bug
...
The wire between two points should not be trimmed if it starts or ends
on one of the component's connection points.
2018-10-08 08:42:06 -07:00
90df7a8b22
Sort references before removing duplicates.
...
std::unique only works within consecutive blocks, so the list must
be sorted first. (We need it sorted in the end anyway, so no
big deal.)
2018-10-08 00:14:07 +01:00
34ea79eddb
Fix LIB_ID illegal character tests.
...
The '/' and ':' are reserved and cannot be used in symbol or footprint
names. They will cause the LIB_ID parser and formatter to fail. While
it seems like they should be legal in symbol alias names, they will
trigger a symbol rescue the next time the schematic is loaded.
Use ID_SCH as in the Eagle schematic plugin rather than ID_ALIAS to
ensure symbol names do not need rescued the next time the schematic is
opened.
Remove ID_ALIAS since the rules for alias names are the same as the
rules for symbol names. Otherwise, allowing '/' and ':' in alias names
will force a symbol rescue on the next schematic load.
Fixes lp:1795600
https://bugs.launchpad.net/kicad/+bug/1795600
2018-10-07 09:09:27 -04:00
9a213207fb
Clearer titles for editing board footprints.
...
Also cleans up the naming on the symbol editor side.
2018-10-05 14:17:58 +01:00
8015334683
Don't resize hidden columns.
...
wxGrid columns are hidden by setting their width to 0. Resizing
them will "unhide" them.
Fixes: lp:1796150
* https://bugs.launchpad.net/kicad/+bug/1796150
2018-10-05 14:17:58 +01:00
c9ca1013b2
Make ModEdit and LibEdit library tree actions more consistent.
...
Adds Cut/Copy/Paste and Revert for footprints; introduces a new
shared Revert Changes? dialog; hooks up Add Library for footprints,
standardizes the Save As terminology.
2018-10-03 22:46:41 +01:00
3c2aafd7b7
Move Edit Symbol References to standard text/button control.
2018-09-29 22:07:31 +01:00
094f340359
Eeschema: Opening "Edit Symbol Fields" dialog crashes Eeschema
...
Fixes: lp:1795088
https://bugs.launchpad.net/kicad/+bug/1795088
2018-09-29 10:08:29 +02:00
19b1ae35ce
Don't assume GetFlags() != 0 means it's being edited.
...
It could just mean it's selected, highlighted or brightened.
Fixes: lp:1794624
* https://bugs.launchpad.net/kicad/+bug/1794624
2018-09-27 22:18:13 +01:00
6fdfd0932e
Use newer wxWidgets calls (old ones aren't available on MSW).
2018-09-27 18:53:46 +01:00
5703060d87
Turn off escaping names for now.
...
Fixes: lp:1794816
* https://bugs.launchpad.net/kicad/+bug/1794816
2018-09-27 17:21:49 +01:00
e456ecd0a1
Calculate column widths based on all data, not just shown data.
...
Also caps the calculated width at 1/3 of the default dialog width.
Fixes: lp:1794625
* https://bugs.launchpad.net/kicad/+bug/1794625
2018-09-27 16:57:25 +01:00
521183a587
Work in progress to allow arbitrary chars in references, etc.
2018-09-27 11:56:51 +01:00
618374db88
eeschema: Re-add auto-wire removal
...
Somewhere during v5 rc cycle, the trimming of wires laid over simple
components was removed. The wires were still removed as soon as the
user moved the component again. This corrects the first behavior to
intended action for simple components.
Fixes: lp:1794019
* https://bugs.launchpad.net/kicad/+bug/1794019
(cherry picked from commit 9831a14ef3
2018-09-24 08:31:50 -07:00
1253020a8b
Add missing header
2018-09-24 10:47:15 -04:00
c95c6c8db7
Scroll library into view after open from Kicad app.
...
Fixes: lp:1793621
* https://bugs.launchpad.net/kicad/+bug/1793621
2018-09-24 15:46:45 +01:00
533b26e8a1
Add hotkey for viewing symbol datasheet.
...
Also fixes a bug when there are multiple datasheets to choose from.
Fixes: lp:1793978
* https://bugs.launchpad.net/kicad/+bug/1793978
2018-09-24 15:46:45 +01:00
3c86bc951a
Eeschema: fix yet another lock file issues.
...
Reset lock file when saving a schematic sheet to a different file name.
This prevents a file is already open error from being displayed when
opening the original file.
Fixes lp:1788507
https://bugs.launchpad.net/kicad/+bug/1788507
2018-09-24 08:59:03 -04:00
b70d0f43b6
Fix minor compil warnings.
2018-09-24 13:12:47 +02:00
85ef058458
Spice simulator: change gain units to dBV
2018-09-22 19:05:04 +02:00
e6f2c49eae
Spice model editor: support for JFET models
2018-09-22 19:05:01 +02:00
f2f6dffd16
Refactored logic in Spice model editor dialog
...
- Removed redundant enums
- Stored Spice model description in an array
- Made code generic by using the model description array
2018-09-22 19:04:54 +02:00
5974899fa5
Clean up file locations and names.
2018-09-22 16:23:13 +01:00
618182dcd6
Use pin number sorting algorithm in pin table.
...
Fixes: lp:1793180
* https://bugs.launchpad.net/kicad/+bug/1793180
2018-09-19 22:23:18 +01:00
3f7e5d2ce4
Eeschema: fix minor bug in block handler.
...
Under certain conditions, it was possible for the block handler to be
entered with no mouse capture callback which would raise a rather
cryptic error message to the user. This should have always been an
assertion so users will not see this issue in release builds.
Fixes lp:1791839
https://bugs.launchpad.net/kicad/+bug/1791839
2018-09-19 15:32:51 -04:00
0b39b68d37
Generate error dialog when a symbol library can't be found.
...
Fixes: lp:1789047
* https://bugs.launchpad.net/kicad/+bug/1789047
2018-09-17 18:01:08 +01:00
e45afdb912
Revert absolute-path asserts and fix off-by-one bug.
...
Fixes: lp:1767582
* https://bugs.launchpad.net/kicad/+bug/1767582
2018-09-15 22:36:09 +01:00
02a3f83040
Implement poor-man's RTTI for use over KiWAY.
...
Fixes: lp:1777883
* https://bugs.launchpad.net/kicad/+bug/1777883
2018-09-15 20:06:42 +01:00
872e1e6532
Remove asserts for absolute paths.
...
You can, for instance, specify relative paths via the command
line.
Fixes: lp:1767582
* https://bugs.launchpad.net/kicad/+bug/1767582
2018-09-15 20:06:42 +01:00
3e61a32fbe
Attempt to use envVars when adding new libraries.
...
Fixes: lp:1785441
* https://bugs.launchpad.net/kicad/+bug/1785441
2018-09-15 20:06:42 +01:00
cac7479e33
Eeschema, fix broken instances of symbols in rescue dialog.
...
The symbol library table rescue candidate was only using the item name
of the library ID object which was being compared to the fully formatted
library ID causing a comparison failure so no instances of any rescued
symbols was shown in the dialog.
Fixes lp:1791805
https://bugs.launchpad.net/kicad/+bug/1791805
2018-09-14 17:42:14 -04:00
243b05b2c3
Fix range-based reference formatter.
...
Fixes: lp:1792483
* https://bugs.launchpad.net/kicad/+bug/1792483
2018-09-14 13:05:13 +01:00
3f23e9ac46
Don't use nullprt for a dialog's parent.
...
Fixes: lp:1791561
* https://bugs.launchpad.net/kicad/+bug/1791561
2018-09-14 10:21:45 +01:00
3f1525f268
Bump up number of items allowed in Clarify Selection menu.
...
Fixes: lp:1792146
* https://bugs.launchpad.net/kicad/+bug/1792146
2018-09-14 10:21:45 +01:00
e5e1a315f1
Keep name & value in sync for library items.
...
Also fixes library reference highlighting from board footprints.
Fixes: lp:1792243
* https://bugs.launchpad.net/kicad/+bug/1792243
Fixes: lp:1792256
* https://bugs.launchpad.net/kicad/+bug/1792256
2018-09-13 16:41:23 +01:00
10a032abdb
Remove limit for number of errors reported when annotating.
...
Fixes: lp:1785714
* https://bugs.launchpad.net/kicad/+bug/1785714
2018-09-13 16:41:23 +01:00
0167ff880c
Don't attempt to move bitmaps from anchor point.
...
It works poorly for large bitmaps, and they're unlikely to have
well-defined anchor points anyway.
Fixes: lp:1787964
* https://bugs.launchpad.net/kicad/+bug/1787964
2018-09-13 16:41:23 +01:00
806b1fc63d
Fix bugs to enable read-only grid cells to be copied.
...
Fixes: lp:1791129
* https://bugs.launchpad.net/kicad/+bug/1791129
2018-09-12 14:01:36 +01:00
2c217499b5
Eagle SCH importer: fix slash characters when fixing symbol names
...
Even though slash is a valid character in symbol names, it is a revision
separator, but is not the case with Eagle symbol names.
Fixes: lp:1791653
* https://bugs.launchpad.net/kicad/+bug/1791653
2018-09-12 10:13:13 +02:00
4a57541b76
Spice netlist exporter: make directives case insensitive, extra comments
2018-09-10 10:18:22 +02:00
36f2eb1116
Spice netlist exporter: handle .control .. .endc blocks
...
Spice may include a list of directives that are wrapped with
.control and .endc. Such directives do not have a dot prefix, so
they need to be handled in a special way.
Fixes: lp:1787902
* https://bugs.launchpad.net/kicad/+bug/1787902
2018-09-10 10:18:17 +02:00
e3924c12ee
eeschema: Only allow dragging of draggable items
...
When expanding the drag item to allow corners, we accidentally picked up
other items in the list. This limits the items that can be dragged to
only those that are explicitly in the draggable list.
A side effect of this commit is that when converting from move to drag
(with tab), items not in the draggable list will be left in place.
Fixes: lp:1787966
* https://bugs.launchpad.net/kicad/+bug/1787966
2018-09-06 13:44:37 -07:00
bfb0fac015
Minor fixes related to I18n
2018-09-05 13:59:20 +02:00
86f5d4e665
Eeschema: fix incorrect/incomplete annotation clearing in duplicate and paste block (happens in complex hierarchy)
2018-09-04 18:46:03 +02:00
181ce46b91
Eeschema: fix incorrect references clearing for shared sheet paths.
...
Previously, when creating a new instance of a sheet, the full set of references
was cleared.
Moreover, if this sheet has sub-sheets, the annotation was incorrectly handled
Now only (and all) new sheet path(s) created have a reference cleared, as expected.
(new sheet paths can be more than one, if the new instance of the sheet has sub-sheets)
Fixes: lp:1789048
https://bugs.launchpad.net/kicad/+bug/1789048
2018-09-04 12:36:38 +02:00
202b35bc90
Eeschema: Fix incorrect parsing of old schematic files (version 2) for HLabels and GLabels
2018-09-03 19:51:17 +02:00
95a08d0dbc
Follow file naming conventions.
2018-09-01 14:05:16 +01:00
270f81f03d
Make fill colour terminology more consistent.
...
Fixes: lp:1789855
* https://bugs.launchpad.net/kicad/+bug/1789855
2018-09-01 14:05:16 +01:00
c90a3efea2
Change KIDIALOG hashing algorithm to __FILE__ + __LINE__.
...
Using Title + Message wasn't working for all the dialogs which
did substitutions in the message (which was a lot of them).
Fixes: lp:1789348
* https://bugs.launchpad.net/kicad/+bug/1789348
2018-08-29 23:38:23 +01:00
12213d994a
Re-instate LibEdit cut/copy/paste of symbols.
...
Fixes: lp:1788975
* https://bugs.launchpad.net/kicad/+bug/1788975
2018-08-29 21:53:59 +01:00
f9aaa01329
Don't rebuild component tree when not necessary.
...
Fixes: lp:1780363
* https://bugs.launchpad.net/kicad/+bug/1780363
2018-08-29 20:08:01 +01:00
946f4a217d
Fix grid sizing for symbol aliases.
2018-08-29 20:08:01 +01:00
e16a2ef80a
Fix misleading warning regarding replacing library.
...
Fixes: lp:1788489
* https://bugs.launchpad.net/kicad/+bug/1788489
2018-08-29 20:08:01 +01:00
00b2c21820
Missed a HIG destructive button separation.
2018-08-29 20:08:00 +01:00
11f746b53e
Give user opportunity to add exported library to lib table.
...
Fixes: lp:1788490
* https://bugs.launchpad.net/kicad/+bug/1788490
2018-08-29 19:59:02 +01:00
a9c8a7b69c
Remove unused warp mouse parameter.
2018-08-29 19:59:02 +01:00
e632816562
Add Save Schematic Sheet As... to eeschema.
...
Fixes: lp:1748680
* https://bugs.launchpad.net/kicad/+bug/1748680
2018-08-29 19:59:02 +01:00
f9412f0fd4
Implement double-click for other filetypes in project tree.
...
Fixes: lp:1787207
* https://bugs.launchpad.net/kicad/+bug/1787207
2018-08-29 19:59:02 +01:00
45bc1b1aff
Add single-click editing to grid cells. (Experimental.)
2018-08-29 19:59:02 +01:00
b90a261d5c
More safety fixes for uncommitted grid changes.
2018-08-29 19:59:01 +01:00
d0ea844557
eeschema: Close ERC before placing components
...
We have a dialog shim that raises the ERC dialog in front of the
schematic frame, which is useful for keeping the ERC dialog visible
during debugging. But mouse move events do not pass through to the
schematic, resulting in a captured mouse pointer but no drawing updates.
As a work-around we close the ERC dialog while placing new components.
Previous ERC data still exist when the window is launched again.
Fixes: lp:1779851
* https://bugs.launchpad.net/kicad/+bug/1779851
2018-08-28 16:03:43 -07:00
089f27f485
Remove more dialog control borders.
2018-08-27 15:11:27 -04:00
4eef4be038
Make library symbol Save As do a Save Copy As.
...
It feels odd to have a library item moved.
Fixes: lp:1788425
* https://bugs.launchpad.net/kicad/+bug/1788425
2018-08-23 00:58:05 +01:00
24149a87fa
Eeschema: fix an assert ( "meOwner" failed in DeleteAll() ) when appending a sheet from an other project to the schematic.
...
It was only a overzealous (in this case) assert, with no issue.
The fix avoid calling DeleteAll() when there is nothing to delete.
Fixes: lp:1787810
https://bugs.launchpad.net/kicad/+bug/1787810
2018-08-22 17:14:30 +02:00
e33e8d02e9
Fix overzealous wxASSERT
2018-08-22 17:14:30 +02:00
c756fc318e
Fix a few wxWidgets minor alerts in DIALOG_EDIT_COMPONENTS_LIBID_BASE.
2018-08-22 17:14:30 +02:00
dbd3900e28
Add comments and show recently used even when empty.
2018-08-21 11:20:17 +01:00
779398891d
Follow HIG guidelines for destructive button separation.
2018-08-21 10:34:41 +01:00
65f62f93ef
Fix MSW spacing issues.
2018-08-21 10:34:41 +01:00
afacb6e7cb
Improve safety around un-committed grid changes.
2018-08-21 10:34:41 +01:00
86a801aabc
Allow updating of file history size on the fly.
...
Also updates the file menu IDs so that we can actually handle
more than 9 items in the file history.
Also adds configurable file history length to the other gerber
files (zip, drill and job).
Fixes: lp:1745729
* https://bugs.launchpad.net/kicad/+bug/1745729
2018-08-21 10:34:41 +01:00
00d912f0b8
eeschema: fix dangling pin marker after adding NoConnect
...
Fixes: lp:1787858
* https://bugs.launchpad.net/kicad/+bug/1787858
2018-08-19 19:48:22 -07:00
5bd959d92c
Eagle: Fix NULL-dereference on malformed Eagle files
...
Eagle files that are edited may be missing required data. While we do
not need to handle these files, we do need to prevent segfaults in KiCad
when reading them.
2018-08-19 19:48:10 -07:00
53cd923305
Minor fix to tooltip and comment.
2018-08-19 17:02:47 +01:00
7a10feb35d
Libedit: Fix a crash when trying to revert changes in a library
...
(No crash when reverting changes in a part, only in a library)
Fixes: lp:1787772
https://bugs.launchpad.net/kicad/+bug/1787772
2018-08-19 10:33:05 +02:00
8fd686e8f4
Eeschema: Fix 2 minor compil warnings. Pcbnew, very minor fix: avoid using fixed scaling factor in code. Use internal units conversion instead.
2018-08-15 13:39:25 +02:00
122d7ed3b3
Improve document file handling.
...
Fixes: lp:1779512
* https://bugs.launchpad.net/kicad/+bug/1779512
2018-08-14 13:54:04 +01:00
d72fdaed29
Rewrite Library Symbol Properties dialog.
...
Fix the user-model issues around aliases and alias selection.
Fold Library Symbol Fields into Library Symbol Properties.
Update to the new look.
Fixes: lp:1744773
* https://bugs.launchpad.net/kicad/+bug/1744773
Fixes: lp:1766205
* https://bugs.launchpad.net/kicad/+bug/1766205
Fixes: lp:1786339
* https://bugs.launchpad.net/kicad/+bug/1786339
2018-08-14 13:54:04 +01:00
01882d3103
Add more/better error messages for file i/o problems.
2018-08-14 13:54:04 +01:00
529521a7ba
Increase max-units to 'ZZ' (676).
...
Fixes: lp:1786659
* https://bugs.launchpad.net/kicad/+bug/1786659
2018-08-14 13:54:04 +01:00
d5ee3296b2
Spice simulator: search each line of a text field for a Spice directive
...
Fixes: lp:1786119
* https://bugs.launchpad.net/kicad/+bug/1786119
2018-08-14 10:25:28 +02:00
f82b839d06
Spice simulator: prevent double quoting library file names
...
Fixes: lp:1786559
* https://bugs.launchpad.net/kicad/+bug/1786559
2018-08-14 09:46:52 +02:00
4b1a31ffad
Regularize save-changes dialogs.
2018-08-12 00:02:37 +01:00
d81faa72c9
Overhaul border drawing in all the Kicad frames.
...
Primary change is to replace most control/window borders with
AUI pane borders. We implement our own AUI border drawing
routine which avoids the ugly one-pixel white frames around
dark canvasses.
Also increases the signal-to-noise ratio of all the pane
creation code in the various frames.
2018-08-11 17:25:38 +01:00
e932eed738
Allow TemplateFieldNames to specify URL-behaviour.
...
Fixes: lp:1785879
* https://bugs.launchpad.net/kicad/+bug/1785879
2018-08-11 17:14:27 +01:00
d2eb9e0735
Eeschema, Dialog annotate: fix incorrect management that creates a crash when try to open it a second time.
...
Fixes: lp:1786618
https://bugs.launchpad.net/kicad/+bug/1786618
2018-08-11 17:19:24 +02:00
45395f9b59
Eeschema: fix a bug when reading .dcm files (the eol char was not stripped, giving broken fields values)
...
The parser also now skip empty lines.
This bug created unreadable saved .dcm files and .sch files after adding a new symbol.
Fixes: lp:1786141
https://bugs.launchpad.net/kicad/+bug/1786141
2018-08-09 09:09:36 +02:00
8884298f29
Add file:// to list of things recognized as URL.
...
Fixes: lp:1785879
* https://bugs.launchpad.net/kicad/+bug/1785879
2018-08-08 12:51:31 +01:00
5f31ce03f7
viewlib_frame: fix incorrect management of the unit selection combo box.
2018-08-08 11:48:29 +02:00
21195a751d
Eeschema: sch_legacy_plugin.cpp: fix incorrect parsing of pin position.
...
The issue is in:
wxPoint( parseInt( aReader, line, &line ), parseInt( aReader, line, &line ) )
that calls parseInt() twice, but parseInt changes parameters at each call.
(Does not return the same value at each call).
However, due to some side effect or compil optimization, the value returned is incorrect.
It can be dependent of the compiler, and optimization level.
This kind of code must be avoided.
2018-08-08 10:15:44 +02:00
99ed476de1
Treat user fields starting with http:// or https:// as a URL.
...
Fixes: lp:1785879
* https://bugs.launchpad.net/kicad/+bug/1785879
2018-08-08 01:43:26 +01:00
20bf6827e7
Minor performance enhancements to symbol loading.
2018-08-07 17:01:44 +01:00
bea98d8265
Reimplement close for Annotation dialog.
...
wxWidgets auto-dialog-handling for modeless dialogs just hides
them.
Fixes: lp:1785526
* https://bugs.launchpad.net/kicad/+bug/1785526
2018-08-07 17:01:44 +01:00
9aa043ef48
Reinstate close/cancel handling for ERC dialog.
...
It needs it because it's a modeless dialog.
Fixes: lp:1785655
* https://bugs.launchpad.net/kicad/+bug/1785655
2018-08-06 21:31:53 +01:00
d788c9d479
Move library table dialogs from PLAYER to KIFACE interface.
...
Spooling up a full PLAYER in the background takes too long.
This also fixes bugs around how the tables are saved, although
that was just missing code rather than anything architectural.
Fixes: lp:1785436
* https://bugs.launchpad.net/kicad/+bug/1785436
2018-08-06 21:31:53 +01:00
be1d6113d6
More performance enhancements.
...
Be more intelligent about sorting lib tree items. (Footprint
entries, for instance, come out of an already-sorted list.)
Don't recreate menus twice when laoding Footprint Editor.
More pervasive use of WX_FILENAME to avoid expensive calls to
wxFileName::SplitPath() and string concatenation.
For POSIX kernels do all the work on the file-system side so we
don't have to keep converting back and forth between encodings.
2018-08-06 13:49:27 +01:00
9e84c3fc3b
Use a white background for "No symbol selected" message.
2018-08-06 13:48:17 +01:00
0fbe702043
Layout adjustments to Choose Symbol and Choose Footprint.
2018-08-06 13:48:17 +01:00
08bcec9ac0
Make sure symbols have a valid lib nickname...
...
... even if the library pointer isn't set.
Also fixes the "every symbol as a Unit A" issue.
Fixes: lp:1785438
* https://bugs.launchpad.net/kicad/+bug/1785438
2018-08-06 13:48:17 +01:00
fd3e57d67f
Layout adjustments and language-change-updating for modview.
2018-08-04 12:59:04 +01:00
e556cb8c91
Fix a minor wxWidgets debug alert.
2018-08-03 21:28:44 +02:00
8e7d6063fd
Minor dialog and frame window improvements.
...
Drop all uses of wxRAISED_BORDER and wxSUNKEN_BORDER from dialogs and
panels used in main frame windows.
Drop use of wxSP_3DSASH options on all wxSplitterWindow definitions.
Minor dialog alignment and spacing fixes.
2018-08-02 13:00:41 -04:00
ce3760438c
Fix a few wxWidgets minor asserts. Fix also a missing bitmap button initialization.
...
Fixes: lp:1783703
https://bugs.launchpad.net/kicad/+bug/1783703
2018-08-02 13:22:11 +02:00
d8d4f75fa1
Fix button order and genralize Exit dialog so it can be shared more.
...
This also fixes a bunch of bugs where an error during save would
still close the window (rather than cancelling the close action).
Fixes: lp:1785034
* https://bugs.launchpad.net/kicad/+bug/1785034
2018-08-02 11:01:03 +01:00
53236a3838
Removed redundant 'v' in noise simulation command
...
Fixes: lp:1784282
* https://bugs.launchpad.net/kicad/+bug/1784282
2018-08-01 17:28:55 +02:00
2155dd6591
Simplify ExitDialog and make platform-compliant.
...
Put the buttons in platform-compliant order.
Get rid of SaveMultiOptions in favour of repeated standard save
dialogs with a "Apply to all" checkbox.
Fixes: lp:1783444
* https://bugs.launchpad.net/kicad/+bug/1783444
2018-08-01 15:27:54 +01:00
196bdc05db
Delete empty fields from Symbol Fields editor.
...
Fixes: lp:1784718
* https://bugs.launchpad.net/kicad/+bug/1784718
2018-08-01 09:35:46 +01:00
f8a5e2c1c8
Performance enhancements in fp loading, string cmp, etc.
...
Knocks about 1/3 off the first footprint load, and more than 1/2
off subsequent loads.
2018-08-01 09:35:46 +01:00
0a35c5c97e
Convert Footprint Editor to component tree.
...
Fixes: lp:1784178
* https://bugs.launchpad.net/kicad/+bug/1784178
Fixes: lp:1780363
* https://bugs.launchpad.net/kicad/+bug/1780363
2018-08-01 09:35:46 +01:00
97f7bd4cb9
Push component tree down into common.
...
Precondition to reusing component tree for footprints.
2018-08-01 09:35:45 +01:00
91e3d21d68
Eeschema: Copy attributes from eagle.
...
Eagle allows for variants of components to be listed in the schematic.
This patch copies the variant data into the imported schematic item,
prefixing the alternate variant names with "VARIANT_" and keeping the
alternate values.
2018-07-31 11:58:01 -07:00
61b68e2476
Eeschema: fix print dialog button sizer layout issue.
2018-07-31 10:34:30 -04:00
e750382e75
Fix a few wxWidgets minor asserts
2018-07-29 17:27:11 +02:00
f5e23e4f1a
Fix a few wxWidgets minor asserts
2018-07-29 12:54:36 +02:00
d73db8c73a
Make a few strings not internationalized, because they must not be translated (html format strings)
2018-07-28 12:47:23 +02:00
3e5cd86288
Fix a few wxWidgets minor asserts. Fix a compil warning
2018-07-28 10:31:04 +02:00
421204ae80
Improve Reset to Defaults button lable.
...
Also updates action buttons to a sdbSizer so the order is correct
on OSX.
Fixes: lp:1783584
* https://bugs.launchpad.net/kicad/+bug/1783584
2018-07-27 14:58:19 +01:00
3c2c5c38ad
Make icon buttons slightly wider for MSW.
...
Fixes: lp:1783703
* https://bugs.launchpad.net/kicad/+bug/1783703
2018-07-27 14:58:19 +01:00
4dfae16c1b
Consolidate to single menu actions for save, revert, etc.
...
There's no point in having both Save Symbol and Save Library when
only one can be selected at a time.
Also cleans up a bunch of extraneous icons, and fixes a few
copy/paste errors in menus and toolbars.
2018-07-27 14:58:19 +01:00
0cca1c6721
Remove active library concept from footprint editor.
...
Also bring the menu system and toolbar in line with Pcbnew,
eeschema, and the symbol library editor, which includes moving
to a standard Save As paradigm for renaming/moving items.
Fixes: lp:1748474
* https://bugs.launchpad.net/kicad/+bug/1748474
Fixes: lp:1778202
* https://bugs.launchpad.net/kicad/+bug/1778202
2018-07-26 21:34:25 +01:00
cd3d4b106a
Add event.Skip() call so someone else handles the focus.
...
DIALOG_EDIT_ONE_FIELD::OnSetFocusText() is only for setting the
selection correctly, not doing the actual focus.
Fixes: lp:1783615
* https://bugs.launchpad.net/kicad/+bug/1783615
2018-07-26 15:43:53 +01:00
cb61525394
Handle separate parsing rules for ID_SCH and ID_PCB.
...
This removes the existing constructors so that all parsing must
be explicit and callers are made aware that they need to think
about illegal characters, malformed ids, etc.
Fixes: lp:1783474
* https://bugs.launchpad.net/kicad/+bug/1783474
2018-07-26 15:43:53 +01:00
9ec6efbf13
Add icon for update PCB from Schematic
...
This previously used the "import board file" icon, which is a bit
confusing, as the action is not importing into a PCB.
2018-07-26 15:43:53 +01:00
b5634b1d08
Dialog spacing cleanup.
2018-07-26 15:43:53 +01:00
f3983cc47f
eeschema: fixed typo Brighened -> Brightened
...
This affects a color string in the eeschema config file.
2018-07-26 15:43:53 +01:00
f13a546c9b
Fix a few wxWidgets asserts or alerts.
2018-07-25 20:26:55 +02:00
05b2060e12
Replace missing growable-row spec.
...
Fixes: lp:1783545
* https://bugs.launchpad.net/kicad/+bug/1783545
2018-07-25 14:41:20 +01:00
f01cf15528
Add field properties icon: opamp + T
...
This was just a text icon, which was not clear about the function
of the button.
2018-07-25 14:41:20 +01:00
822ebf6955
Move symbol management to a standard Save As... model.
...
Also brings horizontal toolbar in line with Pcbnew and Eeschema.
And updates the EDA_LIST_DIALOG to current practices.
This finishes the removal of the active library concept from the
Symbol Editor (started with the new component tree in 5.0).
Fixes: lp:1740717
* https://bugs.launchpad.net/kicad/+bug/1740717
2018-07-25 14:41:20 +01:00
7fa3491616
Make it clear that we're append the content of a schematic.
...
Fixes: lp:1563477
* https://bugs.launchpad.net/kicad/+bug/1563477
2018-07-24 18:03:40 +01:00
83a56263d0
Strip returns, tabs and linefeeds from SCH fields.
...
Fixes: lp:1783285
* https://bugs.launchpad.net/kicad/+bug/1783285
2018-07-24 16:41:19 +01:00
f79ca271e3
Replace missing #ifndef's.
...
We only process symlinks on POSIX kernels (Linux and OSX).
Fixes: lp:1548798
* https://bugs.launchpad.net/kicad/+bug/1548798
2018-07-24 09:05:39 +01:00
bc47f085df
Support symlinks for .pretty and .lib files.
...
Fixes: lp:1548798
* https://bugs.launchpad.net/kicad/+bug/1548798
2018-07-23 23:50:13 +01:00
4d3aeb3339
Make sure cur_lib_table is initialized.
...
The panel doesn't get Show() events so do it in the constructor.
2018-07-23 23:50:13 +01:00
306729f3b7
DIALOG_ANNOTATE: fix a minor cosmetic issue, and make translation of 2 texts more easy.
2018-07-23 15:48:28 +02:00
9ca9225977
Add elipsis to Page Setup button.
2018-07-22 23:39:18 +01:00
2a9856ba34
Refresh eeschema print dialog.
...
Use standard button layout and remove extraneous heading.
Move to TransferDataTo/FromWindow.
Close dialog after printing.
Fixes: lp:1763319
* https://bugs.launchpad.net/kicad/+bug/1763319
2018-07-22 23:29:07 +01:00
7f64f41242
Fix layout issues in Global Label dialog.
...
Fixes: lp:1782904
* https://bugs.launchpad.net/kicad/+bug/1782904
2018-07-22 16:21:51 +01:00
07a665f4fd
Improve validation of symbol fields editor.
...
Don't beep when inserting character from focused grid cell (but
before editor is opened).
Handle reference validation separately from name validation and
separately from user field value validation. The old way of setting
the fieldId on the validator wasn't working because the validator
gets copied.
Run validation when leaving cell. Don't just check for empty
(particularly for fields that CAN be empty).
Fixes: lp:1782917
* https://bugs.launchpad.net/kicad/+bug/1782917
(cherry picked from commit 79e04de)
2018-07-21 21:28:13 +01:00
b6934bf547
Remove duplicate labels from global label popup.
...
Fixes: lp:1782895
* https://bugs.launchpad.net/kicad/+bug/1782895
2018-07-21 14:51:35 +01:00
6d2dfbb5c3
Add Select Footprint and Show Datasheet to Symbol Fields Editor.
...
Fixes: lp:1782848
* https://bugs.launchpad.net/kicad/+bug/1782848
2018-07-20 23:27:50 +01:00
c1df78d531
Finish project frame library table editing.
...
Fixes: lp:1782761
* https://bugs.launchpad.net/kicad/+bug/1782761
2018-07-20 18:48:06 +01:00
bd90341e91
Add Footprint & Datasheet buttons to Edit Symbol dialog.
2018-07-20 18:48:06 +01:00
c08ef3e8f9
Fix untranslatable label.
...
Column label "Qty" of the symbol fields editor is translatable now.
(cherry picked from commit e7b9b0e)
2018-07-19 23:09:41 +01:00
ba0c823673
Fix flicking issues on non-double-buffered platforms.
2018-07-19 21:46:41 +01:00
3a67300001
Fix reference text smart selection for Windows and Linux.
...
Fixes: lp:1782382
* https://bugs.launchpad.net/kicad/+bug/1782382
2018-07-19 21:46:41 +01:00
eaf5b913b6
Add Manage Symbol and Footprint Library tables to project frame.
...
Fixes: lp:1780604
* https://bugs.launchpad.net/kicad/+bug/1780604
2018-07-19 21:46:41 +01:00
829ba27206
Another round of dialog spacing/font adjustments for Windows.
2018-07-18 17:59:05 +01:00
879ffa4d1c
Adjust dialog spacing for Windows.
2018-07-17 22:18:27 +01:00
977f27f3c4
Adjust spacing on preference panels.
...
Giving them the correct parent changed the spacing.
(cherry picked from commit 7f602f3)
(cherry picked from commit 718db46)
2018-07-17 15:14:25 +01:00
909f850d16
Give panels the correct parent (the treebook, not the dialog).
...
(cherry picked from commit 7338533)
(cherry picked from commit 3ce75be)
2018-07-17 15:14:19 +01:00
99db5cb543
Allow for reduced nagging with wider use of KIDIALOG.
...
(cherry picked from commit c2dd5df)
2018-07-17 15:13:53 +01:00
7dcc8e346f
Add Edit context menu item for EEschema graphic lines.
...
Fixes: lp:1779554
* https://bugs.launchpad.net/kicad/+bug/1779554
(cherry picked from commit 02b29ba)
2018-07-17 15:13:49 +01:00
jean-pierre charras
Seth Hillbrand
Tomasz Włostowski
Jeff Young
Maciej Suminski
John Beard
Wayne Stambaugh
Simon Richter
Joël Bertrand
Ronnie Gaensli
Mark van Doesburg
Martin Aberg
Baranovskiy Konstantin