haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
31,120 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

97 Commits

Author SHA1 Message Date
Jeff Young d56e488f2d Remove unnecessary validations. 
Not sure if this will fix the bug or not as I can't reproduce it, but
I'd say odds are pretty good.

Fixes https://gitlab.com/kicad/code/kicad/issues/10467
 2022-02-20 20:52:39 +00:00
jean-pierre charras 54a3ca06c0 Pcbnew, DIALOG_GRAPHIC_ITEM_PROPERTIES: fix incorrect test for arcs. 
It was due to mixing decidegrees and degrees, and seen for 180 deg arcs
Fixes #10841
https://gitlab.com/kicad/code/kicad/issues/10841
 2022-02-14 09:46:57 +01:00
Seth Hillbrand 8fc831cbc2 Validate arc output when editing 
Handles checking output of the arc to ensure we don't end up generating
an invalid arc.  Also keeps the limit of the arc angle to be (360,360)
excluding 0.

Fixes https://gitlab.com/kicad/code/kicad/issues/10070
 2022-02-06 17:18:04 -08:00
Seth Hillbrand ef94f31204 Update error message to match new arc dialog 
We now provide arc end points and interior angle, so we cannot check for
null radius in the same fashion.  Instead, the starpoint==endpoint
indicates a zero radius

Fixes https://gitlab.com/kicad/code/kicad/issues/10714
 2022-02-03 14:31:58 -08:00
Seth Hillbrand 4907b90215 Fix FP circle validity check 
Radius is encoded by m_endX

Fixes https://gitlab.com/kicad/code/kicad/issues/10337
 2022-01-10 10:54:23 -08:00
Jeff Young f9861b4a6c Finish arc rework and push out to file formats. 2021-10-15 12:45:43 +01:00
Jeff Young 9b9e379aa0 Overhaul arc internal model to not over-specify information. 2021-10-15 12:45:43 +01:00
Jeff Young a41944020d Push most of PCB_SHAPE impl down in to EDA_SHAPE. 2021-10-15 12:45:43 +01:00
Jeff Young 3aae3c6f65 Dark mode for a bunch of HTML dialogs. 
WX_HTML_REPORT_BOX
WX_HTML_REPORT_PANEL
HTML_MESSAGEBOX
DIALOG_DISPLAY_HTML_TEXT

Fixes https://gitlab.com/kicad/code/kicad/issues/9157

Fixes https://gitlab.com/kicad/code/kicad/issues/9156
 2021-09-14 21:23:57 +01:00
Jeff Young 0fb864d596 Pull some name changes back from 7.0 to ease merging. 2021-07-21 20:58:59 +01:00
Jeff Young e61822c9e0 Naming conventions and a bug fix on arc points. 2021-07-19 13:17:12 +01:00
Jeff Young 0eed73ea73 Make PCB_POINT_EDITOR honour locked flag. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8254
 2021-05-25 18:13:24 +01:00
Marek Roszko 21fde9b629 enum class PCB_SHAPE_TYPE_T 2021-04-30 22:36:12 -04:00
Jon Evans c04e19f9ac Include optimization: move some things from common.h to point-of-use 2021-03-20 12:09:18 -04:00
Jeff Young faf9cca938 Fix many cases of old mils flag getting interpreted as allowEval flag. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7883
 2021-03-12 15:15:50 +00:00
Jeff Young 4b88d4beed Don't police the user. 
There are too many holes and the police-state just makes it harder to
get back from error conditions.

Fixes https://gitlab.com/kicad/code/kicad/issues/7867
 2021-03-11 10:38:32 +00:00
jean-pierre charras be25b7a132 Use ShowQuasiModal to show a few dialogs. 
This change is mainly due to the fact Modal dialogs do not work when our
current tool is the tool used to create new item (text, zone, graphic).
If when this tool is active, one try to edit the properties of the new item
being created (or being placed) the modal dialog does not capture the event tool
and hangs (cannot be dismissed)
Our quasi modal dialogs have their own event loop and work.
Fixes #7585
https://gitlab.com/kicad/code/kicad/issues/7585
 2021-02-20 14:24:57 +01:00
Seth Hillbrand c09dc5abdd Prevent locking items in footprint editor 
Adding footprints to the board now has a preference for whether we want
pads locked or unlocked by default
 2021-01-11 11:23:26 -08:00
Jeff Young 01fe3b91e9 Implement locking for graphic shapes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6972
 2021-01-07 17:39:18 +00:00
Seth Hillbrand 5a3e5781bf Allow polygon drawing on edge cuts and courtyard 
Prevents line splitting behavior needed in v5 when drawing polygons on
courtyards. Also provide property dialog with some smarts to handle
special layers

Fixes https://gitlab.com/kicad/code/kicad/issues/6900
 2020-12-30 14:10:30 -08:00
jean-pierre charras e4b60b03d1 fp editor: fix incorrect initialization of arc center when edited by the 
graphic item properties dialog.
The arc center (in local coordinates) was initialized before the actual
value was calculated.
Fixes #6772
https://gitlab.com/kicad/code/kicad/issues/6772
 2020-12-17 16:32:10 +01:00
Jeff Young a207bd97bb Naming conventions. 2020-11-17 16:05:49 +00:00
Jeff Young dff5173baf Exorcise some instances of "modedit". 2020-11-17 16:05:48 +00:00
Jeff Young ec020dd19f First-class support for filled shapes. 2020-11-14 01:40:32 +00:00
Jeff Young a6552f14f1 Improve SNR (code, status bar and user messages). 
Fixes https://gitlab.com/kicad/code/kicad/issues/6304
 2020-11-05 16:38:04 +00:00
Marek Roszko e49ac45b84 HTML_MESSAGE_BOX is a dialog 2020-10-25 20:01:12 -04:00
Jeff Young 92d84b0d67 Naming updates. 2020-10-15 01:35:16 +01:00
Jeff Young 2f49db49bf Fix fly-off arc handles and move Arc Properties to start/end/angle. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5791
 2020-10-08 11:33:32 +01:00
Jeff Young 75185f6723 Don't allow negative line widths for grahpic shapes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5599
 2020-10-07 18:30:55 +01:00
Jeff Young 37906511f5 Class renaming. 
DRAWSEGMENT  -> PCB_SHAPE
EDGE_MODULE  -> FP_SHAPE
TEXTE_PCB    -> PCB_TEXT
TEXTE_MODULE -> FP_TEXT
 2020-10-05 11:55:33 +01:00
jean-pierre charras 3144bab36f final cleanup about removing useless include 2020-10-03 16:40:36 +02:00
Reece R. Pollack a9c835275a Apply display origin transforms in Pcbnew dialog classes 
This commit applies display origin transforms to all Pcbnew
dialog classes that use UNIT_BINDER for their formatting:

  * DIALOG_CREATE_ARRAY
  * DIALOG_FOOTPRINT_BOARD_EDITOR
  * DIALOG_GRAPHIC_ITEM_PROPERTIES
  * DIALOG_GRID_SETTINGS
  * DIALOG_MOVE_EXACT
  * DIALOG_PAD_PROPERTIES
  * DIALOG_POSITION_RELATIVE
  * DIALOG_TEXT_PROPERTIES
  * DIALOG_TRACK_VIA_PROPERTIES
 2020-08-26 17:54:22 +00:00
Jeff Young 970921f88b Support for filled DRAWSEGMENT::S_RECT and S_CIRCLE. 
One more step in unifying pad primitives and draw segments.
 2020-06-20 14:34:53 +01:00
Jeff Young aeed8e6e2c Finish implementation of DRAWSEGMENT::C_RECT. 
It's currently only supported in the Footprint Editor.  It could be
easily added to the board editor (all the code is there), but the board
editor is a little short on room in the drawing tools toolbar.
 2020-06-15 20:51:31 +01:00
Ian McInerney 99dcadf7e6 Introduce new KI_FALLTHROUGH macro 
Annotate purposeful fallthroughs in switch statements with the
KI_FALLTHROUGH macro.
 2020-04-25 00:44:09 +01:00
Ian McInerney 4ffbefb9dc Use the layer from the module item instead 
They are both from the same argument, but this one make coverity happy.
 2020-01-12 19:39:39 +00:00
Mark Roszko 11ff16be4e Switch to scoped enums 2019-12-20 14:11:39 +00:00
Jeff Young 807b8d4cf1 Lower x (or y) value always defines "Start Point". 
"End Point" is the other.  (The user doesn't care what the variable
names in the code are.)

Also re-lays-out the dialog for better comprehension.

Fixes: lp:1694964
* https://bugs.launchpad.net/kicad/+bug/1694964
 2019-07-11 17:36:32 +01:00
Jeff Young c2662b0e11 Retire EDA_DRAW_PANEL and legacy_wx/EDA_DRAW_FRAME. 2019-05-31 21:55:30 +01:00
Jeff Young d2daab808c Remove some legacy cursor handling stuff. 2019-05-31 21:54:22 +01:00
jean-pierre charras 9cac0a38cc DIALOG_GRAPHIC_ITEM_PROPERTIES: better tooltip. 
minor other code enhancement (does not create any actual change)
 2019-01-19 12:35:35 +01:00
Jeff Young 4f5771f79f Don't nag user about changes they made in a text editor. 
Fixes: lp:1806748
* https://bugs.launchpad.net/kicad/+bug/1806748
 2018-12-04 23:32:55 +00:00
Jeff Young 42ee4f79e4 Fix assert in Graphic Item Properties. 
Fixes: lp:1792201
* https://bugs.launchpad.net/kicad/+bug/1792201
 2018-10-09 11:08:56 +01:00
Jeff Young 56de78c130 Remove layer limitations and warnigns now that DRC handles them. 2018-08-27 18:38:56 +01:00
jean-pierre charras 4cac974420 Add Bezier curve (S_CURVE shape) support in DIALOG_GRAPHIC_ITEM_PROPERTIES. 
Fix some issues related to S_CURVE shape support.
 2018-07-22 18:39:48 +02:00
Jeff Young 99db5cb543 Allow for reduced nagging with wider use of KIDIALOG. 
(cherry picked from commit c2dd5df)
 2018-07-17 15:13:53 +01:00
Jeff Young 40c1c8285d Combine PCBnew and ModEdit Graphic Item Properties dialogs. 
Also UNIT_BINDERizes the result.

(cherry picked from commit edd3b25)
 2018-07-17 15:12:21 +01:00
Seth Hillbrand 5d8dd38664 Standardize graphical edit window 
The graphical editor window for pcbnew and modedit have slight
differences, so different classes.  But they should appear the same to
the user.  This merges the differences into a dialog that looks the same
to the user.

Fixes: lp:1772389
* https://bugs.launchpad.net/kicad/+bug/1772389
 2018-05-21 09:37:04 -07:00
Seth Hillbrand 0c2f9b1827 Keep circles controlled by radius 
Circles are defined by center and a point on their edge.  This requires
the user to do extra math to figure out the size of the circle.  The
patch allows the user to edit and draw circles using radial coordinates.
 2018-05-20 17:16:44 -07:00
jean-pierre charras 62c5a706d5 DIALOG_GRAPHIC_ITEM_PROPERTIES: fix a not very understandable error message (especially when Dwgs.User layer is disabled). 
Rename the method PCB_LAYER_BOX_SELECTOR::SetLayerSet to the better name SetNotAllowedLayerSet
 2018-03-31 10:46:52 +02:00