jean-pierre charras
906c08afc6
Cross probing: ensure highlighted net in Eeschema is shown when cross probed from Pcbnew.
2018-10-15 20:16:48 +02:00
jean-pierre charras
9c398dbf90
Pcbnew, CMakeLists.txt: remove duplicate lines.
...
For some reason, a few files were included 3 times in the same dependency. One time is enough.
2018-10-15 20:14:27 +02:00
Seth Hillbrand
bf164f7c4b
GAL: Lock context when triggering resize
...
This action adjusts the compositor, so it must have exclusive access to
the context.
2018-10-15 09:55:53 -07:00
Seth Hillbrand
a7672716f8
Revert "pcbnew: Fix memory leak in Eagle importer"
...
This reverts commit 45d438cd13
.
2018-10-15 08:26:04 -07:00
Tomasz Włostowski
d66e0d4f7a
eeschema-gal: implemented EnableDepthTest() in GAL, fixed drawing order in eeschema
2018-10-15 00:09:59 +02:00
jean-pierre charras
0777d11188
Eeschema Better fix for highlight visibility issue for cached items due to last change in code in opengl
2018-10-14 14:59:40 +02:00
jean-pierre charras
9a62f508a4
Revert "Eeschema Fix highlight visibility issue for cached items due to last change in code"
...
This reverts commit b389236a72
, not working in opengl.
2018-10-14 14:57:45 +02:00
jean-pierre charras
b389236a72
Eeschema Fix highlight visibility issue for cached items due to last change in code
2018-10-14 12:47:06 +02:00
jean-pierre charras
fff739631c
EEschema: fix wrong pin rendering for pin style PINSHAPE_OUTPUT_LOW
...
Fixes: lp:1797750
https://bugs.launchpad.net/kicad/+bug/1797750
2018-10-14 12:36:02 +02:00
Jeff Young
0bd0558833
Auto-select reference numbers in PcbNew like we do in Eeschema.
2018-10-14 00:06:41 +01:00
Jeff Young
275d5e336f
Fix issue with component children disappearing when canvas origin not in view.
2018-10-13 20:54:50 +01:00
Jeff Young
f1e2f142a6
Work-around for preference crash with multiple GAL docs open.
2018-10-13 19:41:45 +01:00
Jeff Young
29e0e6921b
Turn on OpenGL caching. Time to smoke out the bugs.
2018-10-13 15:53:54 +01:00
Jeff Young
3158273c1a
Revert window-locking change which didn't fix preferences crash.
2018-10-13 15:53:54 +01:00
jean-pierre charras
650478f757
Eeschema, highlight connection: show selected junctions and labels in highlight color
...
Previously, only wires were shown in highlight color.
2018-10-13 16:12:36 +02:00
Jeff Young
6a5744adb1
Show compile errors and go back to GLSL V120.
2018-10-13 12:39:53 +01:00
jean-pierre charras
9df7626e31
Fix issue: Symbol library editor: Moving pins jumps to origin
...
Also: remove outdated lines in code.
Fixes: lp:1797266
https://bugs.launchpad.net/kicad/+bug/1797266
2018-10-13 12:09:49 +02:00
jean-pierre charras
1bce69b9f0
Fix a minor compil warning.
2018-10-13 08:24:31 +02:00
jean-pierre charras
7df4ddc74d
Use our DIALOG_COLOR_PICKER in 3D viewer to set a color.
...
the wxWidgets color picker is not the best for the 3D viewer that does not use transparency color.
2018-10-13 08:23:14 +02:00
Seth Hillbrand
aa622994e1
eeschema: Ensure is_moved flag is set when moving
...
Prior to placing, cleaning routines need to know which schematic items
are being moved to avoid cleaning them relative to themselves. The
IS_MOVED flag communicates this and is cleared by ClearDrawingState()
Fixes: lp:1797576
* https://bugs.launchpad.net/kicad/+bug/1797576
2018-10-12 17:08:10 -07:00
Seth Hillbrand
4a730e6c54
pcbnew: refactor connectivity locking
...
Locks protect the std::set in each item. Devolving the mutex to the
CN_ITEM allows multiple threads to make simultaneous connections to
different items where they do not conflict.
2018-10-12 17:07:31 -07:00
Seth Hillbrand
59adb109a6
Organizing connectivity
...
Moved large routines out of headers in into cpp. Moved trivial routines
into headers.
2018-10-12 16:31:09 -07:00
Seth Hillbrand
cfaf7c1f23
pcbnew: re-organizing connectivity
...
The connectivity files were unwieldy. This separates them logically
into data, algo and items where the items classes are those that hold,
surprise, surprise, the items, lists and clusters.
2018-10-12 16:31:09 -07:00
Seth Hillbrand
4460313104
pcbnew: Separating connectivity to subdir
2018-10-12 16:31:09 -07:00
Seth Hillbrand
9e4cad666e
pcbnew: Code Cleanup removing unused fns
...
IsDirty() is generic, so we keep the clearer m_items.isDirty() sub
function and clear out old defs.
2018-10-12 16:31:09 -07:00
Seth Hillbrand
cc776f71a9
pcbnew: Code cleanup
...
Moving functions to std:: algorithms where feasible to reduce the code
burden.
2018-10-12 16:31:09 -07:00
Jeff Young
6c34fdefd7
Better exception handling and context locking for GAL.
...
This prevents deadlocks when exceptions are thrown and the context
ends up not getting unlocked.
It also removes an earlier hack to try and minimize this which
didn't work anyway.
2018-10-12 23:44:49 +01:00
Tomasz Włostowski
a676034e36
OPENGL_GAL::DrawGrid(): flush drawing buffer after drawing small crosses grid so that it's correctly composited
...
Fixes: lp:1797642
* https://bugs.launchpad.net/kicad/+bug/1797642
2018-10-12 23:52:35 +02:00
Tomasz Włostowski
22300e4f02
Null pointer check in FOOTPRINT_LIST::GetInstance()
2018-10-12 23:51:31 +02:00
Tomasz Włostowski
e988cd9c25
Fixed crash in footprint chooser in eeschema triggering in standalone/no-pcbnew mode
...
Fixes: lp:1797644
* https://bugs.launchpad.net/kicad/+bug/1797644
2018-10-12 23:43:08 +02:00
Tomasz Włostowski
30f0e93dbb
Synchronize the GAL view after invoking 'autoplace fields' tool
...
Fixes: lp:1797268
* https://bugs.launchpad.net/kicad/+bug/1797268
2018-10-12 23:27:39 +02:00
Tomasz Włostowski
7f132ca261
EDA_DRAW_FRAME: avoid cursor flickering in GAL when changing cursor size
...
Fixes: lp:1797437
2018-10-12 23:20:28 +02:00
Tomasz Włostowski
711b278248
gal/opengl: handle single-pixel line width clamping in hardware (new shader). Correct grid rendering in GAL for pixel-sized lines
2018-10-12 19:13:54 +02:00
John Beard
b64c6dbf35
Use wxCHECKs to protect non-position TOOL_EVENTS
...
Getting the position of a non-position TOOL_EVENT will
now result in a wxCHECK, and a null-position (0,0) will
be returned. The new interface HasPosition() can be used
to determine if a call to a position function is safe to
make from the caller.
Fixes the underlying danger behind lp:1796045, which has
already been neutralised by a4966adb6
, which avoids calling
the Position() functions when the TOOL_EVENT is not known
to be a position.
Fixes: lp:1796045
* https://bugs.launchpad.net/kicad/+bug/1796045
2018-10-12 09:08:07 -07:00
jean-pierre charras
dbc9130da9
Fix: 3D footprint preview does not zoom using mouse wheel (Windows specific)
...
This was due to clicking on the preview canvas does dot give the focus to the canvas on Windows.
Now the focus is set when clicking on this canvas.
Fixes: lp:1794090
https://bugs.launchpad.net/kicad/+bug/1794090
2018-10-12 13:41:44 +02:00
Seth Hillbrand
915d2ed374
pcbnew: Zone tool follows active layer
...
Refactor the polygon event loop into its parent function to allow access
to the params structure. Active layer now updates the drawing layer for
add/cutout zones.
Fixes: lp:1797483
* https://bugs.launchpad.net/kicad/+bug/1797483
2018-10-11 21:16:05 -07:00
Seth Hillbrand
92758ea4ef
eeschema: Fix minor compile warning
2018-10-11 15:31:10 -07:00
Seth Hillbrand
4f672f0d39
Fixing a number of dynamic_casts
...
Dynamic casts should only be used when we explicitly check for the
resulting pointer to be NULL. Where we know the class is castable we
can use static_cast, save on overhead and ensure our resulting pointer
is non-null.
2018-10-11 15:24:12 -07:00
Seth Hillbrand
ddea4e11d1
3d-viewer: Fix intersection bug
...
Bounding box check always returned false, leading to incorrect BBox
checks when one bbox is interior to the other
2018-10-11 14:47:06 -07:00
Seth Hillbrand
dff92f915c
eeschema: Formatting grid table
...
Missing breaks could cause grid table to return odd text for bad values.
With the breaks, odd values are flagged for fixing
2018-10-11 14:45:23 -07:00
Seth Hillbrand
d03b08a03f
gerbview: Prevent NULL dereference
...
There was a possible NULL dereference when executing tool_up even
though we should never hit it, we protect against bad files.
Also converts a couple untranslated error strings.
2018-10-11 14:23:07 -07:00
Seth Hillbrand
a16e21665a
view_layers: Initialize variables
...
Fixes a couple spots where uninitialized variables cause unknown results.
2018-10-11 14:08:35 -07:00
Seth Hillbrand
bfa7f16b44
Wrap printfs in DBG defines
...
This places the remaining printf statements behind DBG() macros to
suppress their output on release builds. We should remove these prior
to 5.1
2018-10-11 13:32:20 -07:00
Jeff Young
a69635f539
Adjustment to net selector list sizing for GTK.
...
Thanks to John Beard.
2018-10-11 18:53:00 +01:00
Jeff Young
9f7bc6a9f9
A bit of a hack to keep OpenGL from puking.
2018-10-11 18:53:00 +01:00
Jeff Young
732e0b0bf8
Remove extra rebuild of toolbar.
...
It's called from CommmonSettingsChanged() anyway.
2018-10-11 18:53:00 +01:00
Jeff Young
d9bf1550e4
Improve slightly confusing error message.
2018-10-11 18:53:00 +01:00
jean-pierre charras
4904ece0b5
eeschema gal: keep grid visibility setting when switching between back-ends
2018-10-11 18:45:18 +02:00
Seth Hillbrand
4d8534a7a6
libedit: Prevent segfault when deleting part
...
emptyScreen() sets the current part to NULL. This gracefully handles
the case by allowing a cleared screen when no part is currently
selected.
2018-10-11 09:22:54 -07:00
jean-pierre charras
5c8c1cdb8f
Eeschema doesn't show highlight net until a screen redraw is made.
...
Fixes: lp:1796989
https://bugs.launchpad.net/kicad/+bug/1796989
2018-10-11 14:19:29 +02:00