411bcc58c5
Use the right path for recursing in text var resolution
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14720
(cherry picked from commit 3686c5b371
2023-05-14 23:12:30 +00:00
a4525bf88c
Test for schematic type when changing
...
The schematic editor undo list may hold page layout types as well
(cherry picked from commit 2ffb58a7e2
2023-05-12 08:44:22 -07:00
6c423be36f
Don't consider saving SCH_MARKERs
...
These are ephemeral, view-only elements, so don't include them in our
save map
Fixes https://gitlab.com/kicad/code/kicad/issues/11405
(cherry picked from commit 7eb728ca12
2023-05-11 16:27:15 -07:00
db5aacf984
sim: fix diode model default breakdown voltage
...
(Cherry-picked from 2970d97bf2
2023-05-11 13:15:37 +01:00
111a56dd8a
sim: fixup some diode parameter units
...
(cherry picked from commit df3560ab8e
2023-05-11 01:15:52 +00:00
a42ef9de77
Navlib: Ensure a pointer is initialized.
2023-05-10 09:36:51 +02:00
57f0150a23
Ensure _changed_ netlist is propagated
...
The propagation is currently (maybe not needed) limited to the global
name that is the source of the change. We also need to propagate the
global name that is changed in case the global is set in a tree leaf and
not the root
Fixes https://gitlab.com/kicad/code/kicad/issues/14657
(cherry picked from commit 6e4de18e15
2023-05-09 12:13:30 -07:00
8fa46a1f9e
Simplify previous fix to not include new strings.
2023-05-09 18:20:42 +01:00
d805f5ceff
De Morgan conversions are equivalences, not additional items to simulate.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14230
(cherry picked from commit fdcc97e604
2023-05-09 18:12:02 +01:00
8c3eeb5201
Support for De Morgan variants in symbol plotting CLI.
...
(cherry picked from commit 8cd1f8d905
2023-05-09 13:11:06 +01:00
5998fabadd
Formatting.
...
(cherry picked from commit 4e420f3cf6
2023-05-09 13:10:31 +01:00
6f0505f19c
Field bounding boxes no longer contain interline spacing.
...
That's entirely done through FIELD_PADDING now.
Fixes https://gitlab.com/kicad/code/kicad/issues/14127
2023-05-07 22:30:01 +01:00
5a3dfe598f
Handle Eagle user-defined attributes.
...
(We map these to text variables.)
Fixes https://gitlab.com/kicad/code/kicad/issues/13798
(cherry picked from commit 8fe02ee83c
2023-05-06 21:11:16 +01:00
d0c132ccd4
Defense in depth for "mouse stuck in canvas".
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12653
(cherry picked from commit 49655ae742
2023-05-06 11:29:05 +01:00
826541548c
Make sure mouse isn't captured when dialog is raised.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14685
(cherry picked from commit c016bea020
2023-05-06 11:29:01 +01:00
2ae2d7ee1a
Verify parent symbol shared pointer is still valid in symbol editor.
...
(cherry picked from commit 51fd7ca5ed
2023-05-05 13:50:06 -04:00
e28b50e8d6
Fix a bunch more issues with sheetpaths and allowExtraText.
...
A sheetpath is required to correctly resolve text variables.
Depending on currentSheet is rife with bugs.
There are many places where we do *not* want to be prepending
field names to the field values, such as netlisting,
building PDF hypertext menus, etc.
Also, Find/Replace needs to work on unresolved text, as
that's what we're going to display (and if replace nuked
your variable references you wouldn't be happy).
(cherry picked from commit b41d446f58
2023-05-05 18:02:59 +01:00
9c78d86f58
Don't include power symbol pin when exporting netlist.
...
The netlist exporter was never updated to exclude symbols that are
tagged as power symbols. Only the legacy power symbol name prefix
('#') was used as the power symbol check. Power symbols no longer
require the '#' name prefix.
(cherry picked from commit fb6b8eaeea
2023-05-05 11:36:39 -04:00
34d5f1f9fe
Fix a28d590b9b
...
Needs to be static, so keep the reference from the associated symbol and
not the SCH_SYMBOL instance. Both will likely have the same prefix,
which is all we care about here
(cherry picked from commit 2cac992801
2023-05-04 15:53:15 -04:00
43ad15dc0e
Force not-on-board symbols to NONE priority
...
Symbols that are not on the board should not affect the arbitrary names
assigned to unlabeled nets.
(cherry picked from commit a28d590b9b
2023-05-04 15:52:57 -04:00
d20147c79f
Use correct sheetpath when exporting netlist.
...
(cherry picked from commit c20ef06f56
2023-05-04 14:28:40 +01:00
7cc014cf9e
Be careful of infobar outliving symbol.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14680
2023-05-04 11:52:02 +01:00
349dbb98a6
bom_csv_grouped_by_value_with_fp.py: fix compatibility with python < 3.9
...
From master branch
2023-05-04 08:54:55 +02:00
f4fa5bb0fc
Don't store resolved values in symbol fields table editor dataStore.
...
We're going to use the dataStore to update the symbol, so
if we store resolved values it will nuke any text variables
even if the field wasn't edited.
Not sure if the BOM generator has a separate resolve-variables
step or not. But it will need one as the code removed here
only worked for Values and Footprint fields anyway.
2023-05-04 00:08:18 +01:00
4cdf75dc72
Remove matching parents/neighbors in subgraphs
...
This ensures that when bus elements or labels matching bus elements are
removed that the stale neighbor/parent references are similarly removed
2023-05-03 13:35:51 -07:00
57ae43890c
Update 5 files
...
- /eeschema/CMakeLists.txt
- /eeschema/eeschema.cpp
- /pcbnew/pcbnew.cpp
- /qa/qa_utils/pcb_test_frame.cpp
- /qa/unittests/eeschema/test_module.cpp
2023-05-03 17:32:55 +00:00
4258738b89
Remove extraneous symbol editor settings
...
(cherry picked from commit 2cd861dbd5
2023-05-03 17:26:26 +00:00
594864e117
Remove extraneous includes
...
(cherry picked from commit 892e4536b0
2023-05-03 17:26:13 +00:00
a5698ce480
Remove locks from settings
...
Settings should be initialized on start-up. This removes the option of
lazily loading the settings from file and instead requires all settings
needed to be loaded on KiFACE start before requesting data from the
settings object
(cherry picked from commit e6ab9a88ce
2023-05-03 17:25:17 +00:00
6931252ed9
Pull back more sheetPath fixes from master.
2023-05-03 12:04:46 +01:00
0fb2f35b10
Fix sheetPath handling in SPICE model generation.
...
(cherry picked from commit d5cb100f72
2023-04-28 16:20:03 +01:00
d3311ee231
Implement better sheet-path awareness for label text var resolution.
...
(cherry picked from commit 4b0027a5d7
2023-04-28 01:02:58 +01:00
a11fd7a792
Set currentSheet when exporting netlist.
...
Patch courtesy of Fernando Gomez.
(cherry picked from commit 5e21e94478
2023-04-26 18:20:34 +01:00
cd9196ddb9
Use fileds from flattened lib symbol when updating.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14577
(cherry picked from commit d816fb071f
2023-04-26 13:04:05 +01:00
105f8a1720
Do not close ERC dialog when first error is on a different sheet.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14538
2023-04-26 07:51:32 -04:00
050f47daf1
Bug Fixes for new incremental connectivity
...
- Ensure that critical paths (ERC/netlister) are fully-rechecked
- Handle symbol/pin distinction in change markers
- Fully connect hierarchical pins in one pass descending
(cherry picked from commit 6e8a5acc66
2023-04-25 11:32:59 -07:00
683abd2029
Add ability to update subgraphs based on changeset
...
Previously, almost all connectivity updates were full updates, meaning
that the entire connectivity graph would be rebuilt each time a change
was made to the schematic. This update modifies the update to only
correct the subgraphs that are directly affected by the change.
It uses the existing connection graph to find all affected subgraphs as
well as connections to the changes based on the visible schematic.
These elements are removed from the existing connectivity graph and
marked dirty. They then have a new connectivity graph built only around
their changes. The resulting graph is merged into the original.
Currently, this ability is behind an advanced config flag
`IncrementalConnectivity` while testing.
Fixes https://gitlab.com/kicad/code/kicad/issues/10846
Fixes https://gitlab.com/kicad/code/kicad/issues/1794
(cherry picked from commit a154571438
2023-04-25 11:32:04 -07:00
d08f937932
Move Spacemouse to advanced config
...
The spacemouse driver, particularly on Mac, is extremely unstable and
causes crashes even when not being used. This places the interface
behind an advanced config flag to ensure that users can affirmatively
opt-in to the potential for crashes
(cherry picked from commit 2cd854af14
2023-04-25 11:30:36 -07:00
2f51742311
netlist exporter: export only the field value, even if field name is shown.
...
Previously, when the field name was visible, the exported field value was
prefixed by the field name, and this is incorrect.
From master branch
Fixes #14611
https://gitlab.com/kicad/code/kicad/issues/14611
2023-04-25 15:17:05 +02:00
999cd8cd11
Simulator fixes.
...
1) Don't read libraries multiple times
2) VDMOS default is nchan if not specified
3) In the absence of a workbook default to LTSpice compatability
4) Don't attempt to write out a model line for a subckt; it never has
a baseModel
2023-04-24 13:55:34 +01:00
fd8b281731
Formatting.
2023-04-24 13:55:15 +01:00
d8481b4528
More robust file reading for simulator files.
2023-04-24 13:53:22 +01:00
b74af71312
* Eeschema: save worksheet filename in project file.
...
The call to saveProjectSettings() was missing.
From master branch, commit b96f3d085cFixes #14219
https://gitlab.com/kicad/code/kicad/issues/14219
Fix also a minor compil warning
2023-04-20 09:22:33 +02:00
44640422f2
Copy RC_ITEM fix to ERC_ITEM (where it's actually needed).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14569
2023-04-19 14:08:55 +01:00
bdca18cc9f
Ensure item is gridded if there was no motion between clicks.
...
(cherry picked from commit f7a552a2b3
2023-04-18 23:56:17 +01:00
4f9e754a51
Ignore empty field-name-templates.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14552
2023-04-18 13:46:08 +01:00
e8a9485d5e
Markup fixes.
...
1) allow escape sequences inside markup sequences
2) keep overbar when inside nested markup
3) always place overbar at full height, not sub/superscript height
Fixes https://gitlab.com/kicad/code/kicad/issues/14553
Fixes https://gitlab.com/kicad/code/kicad/issues/13449
2023-04-17 17:52:11 +01:00
204549f55b
Fix merge error.
2023-04-16 23:22:49 +01:00
7a4650a1a9
Double double-add items to the view.
...
(cherry picked from commit a540c01c61
2023-04-16 23:05:24 +01:00
5cc1e2e42d
The symbol viewer handles its own message panel.
...
(cherry picked from commit 6fb8916798
2023-04-16 18:49:53 +01:00
3217372720
Tighten up the lifecycle management of VIEW_ITEMs in
...
general, and the SYMBOL_VIEWER_FRAME's m_previewItem in
particular.
(Attempted fix for Sentry KICAD-G1.)
(cherry picked from commit 6f59740953
2023-04-16 15:38:15 +01:00
9893921d76
Handle legacy libraries with escaped symbol names.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14057
(cherry picked from commit b74d964bff
2023-04-15 22:31:49 +01:00
5574f35473
Apply symbol attributes from base symbol, not derived symbol.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13740
(cherry picked from commit d4b4abd001
2023-04-15 22:31:49 +01:00
1707436cad
Retire the lib-tree scoring algorithm.
...
It appears to cause more confusion than help.
Fixes https://gitlab.com/kicad/code/kicad/issues/13905
(cherry picked from commit d01c023d5a
2023-04-15 00:09:34 +01:00
f67a477f65
Pull some fixes from master.
2023-04-14 19:55:31 +01:00
3573b97bfc
Save library when it's selected in lib tree.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14220
(cherry picked from commit 05185ec81a
2023-04-14 17:36:10 +01:00
37a42a3fb7
ERC: set default setting ERCE_SIMULATION_MODEL to ignore
...
Most of projects do not manage spice settings.
From master branch
2023-04-14 17:29:42 +02:00
a51475a094
Performance improvement for GetShownColumns.
...
(This needs to be fast as it's called from OnUpdateUI events.)
(cherry picked from commit 8e29a054f3
2023-04-13 13:47:21 +01:00
f25e2d48bd
Search in label fields.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14075
(cherry picked from commit a24a63e416
2023-04-13 10:59:39 +01:00
70b4503187
Fix cherry-pick errors
2023-04-13 02:11:39 +02:00
912bd4458f
Don't trip over a uniquified-name in the schematic library-symbol cache.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14160
2023-04-12 18:35:27 +01:00
68dfcddbe9
Allow bus elements to connect
...
Previously, bus elements that were not instantiated as individual nets
could not connect to each other. This caused issues for complex
schematics where busses needed to connect to other busses with elements
that resolved to the same net names. Functionally, this means mixing
bus elements, which we will replace with first-class elements in version
8 but currently can only be accomplished either by using bus aliases and
this patch or by individually instantiating each bus element as a
local label
Fixes https://gitlab.com/kicad/code/kicad/issues/14300
(cherry picked from commit 16b4ec3c7e
2023-04-12 16:10:50 +02:00
907761f14e
SCH_LABEL_BASE::SetPosition(): ensure field positions are also handled.
...
Fixes #14520
https://gitlab.com/kicad/code/kicad/issues/14520
2023-04-12 11:20:41 +02:00
ea95d8604a
Ensure we do not use a non existing pin in SIM_MODEL::MigrateSimModel()
...
From master branch
Fixes #14522
https://gitlab.com/kicad/code/kicad/issues/14522
2023-04-12 09:41:07 +02:00
1f34883a27
Make symbol/footprint trees sensitive to language change.
...
(cherry picked from commit eef3492fc0
2023-04-12 00:01:58 +01:00
372e7b6312
fix 2 issues related to SCH_GLOBALLABEL items:
...
- Ensure the first field in m_fields has id = 0 to be seen has hypertext
(it was not the case after reading a .kicad_sch file)
- when converting this item to another label/text, remove this special Field
from the copied field list to the converted label.
From master branch.
2023-04-10 10:02:50 +02:00
cbff011e3c
Don't delete default intersheetrefs field from global labels.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14493
(cherry picked from commit a226f7fc14
2023-04-09 19:04:33 +01:00
e991ae504b
DIALOG_IMAGE_PROPERTIES: fix some issues:
...
- add missing panel_image_properties_base.fpb file
- fix not displayed image.
From master branch
2023-04-08 17:04:02 +02:00
39dcd0a352
Handle nested netclass assignments
...
Netclass directives should not be overriden, instead hold our error
checking for actually missing nets
Fixes https://gitlab.com/kicad/code/kicad/issues/14494
(cherry picked from commit 012737593b
2023-04-06 17:38:42 -07:00
dce2247925
Improve scoping control of connetion members.
...
(The real bug here is that CONNECTION_GRAPH::assignNetCodesToBus() was
growing the bus aliases members list because it used a non-const
reference to it as a local storage list. The const scoping of it will
prevent this type of error in future.)
Fixes https://gitlab.com/kicad/code/kicad/issues/14269
2023-04-04 11:35:06 +01:00
9a57c11348
Possible protection from acessing deleted window data.
...
(Long shot for Sentry KICAD-MM.)
(cherry picked from commit bd60f38569
2023-04-03 23:47:09 +01:00
a21e7a5eee
Don't pass a FRAME-based UNITS_PROVIDER to a modeless dialog.
...
(The dialog may outlive said frame.)
Should fix Sentry KICAD-3A.
(cherry picked from commit 9b4627e782
2023-04-03 17:20:06 +01:00
927b5ae707
Use enums for column ids.
...
(The nickname, in particular, is no longer column 1.)
Fixes https://gitlab.com/kicad/code/kicad/issues/14291
2023-04-02 15:28:11 +01:00
b22ff229db
DbLib: Get rid of some GCC warnings
...
(cherry picked from commit c35cefe1d5
2023-03-26 19:48:58 -04:00
97c018118d
CADSTAR Sch: TERMATTR may have more than one attribute subnode
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13526
(cherry picked from commit fc04f5135f
2023-03-26 14:55:06 +00:00
7931f315b1
Manually cherry-pick some fixes back from master.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14424
2023-03-26 11:00:23 +01:00
f2ce9cf857
Plot symbol graphic texts: fix incorrect position of texts in some rotations.
...
The plot code is now similar to the one for symbol fields
From master branch.
Fixes #14327
https://gitlab.com/kicad/code/kicad/issues/14327
2023-03-25 18:27:35 +01:00
d4a312d6cb
Move separation of model name from params earlier in the process.
...
We need just the model name when we look for a match in the library file.
(cherry picked from commit 60aadfee40
2023-03-25 15:37:57 +00:00
434161687e
Fix cli crash due to dialogs buried in the pcb parser...
...
Fixes sentry KICAD-Q2
(cherry picked from commit 8a8589b9db
2023-03-24 23:53:15 +00:00
b0b9e66fad
Move to requiring explicit action to save project settings
...
(cherry picked from commit 610e787adahttps://gitlab.com/kicad/code/kicad/issues/14414
2023-03-24 11:49:50 -07:00
89488a43b9
Pins are case-sensitive
...
Cleanup should remove mis-matched cases
Fixes https://gitlab.com/kicad/code/kicad/issues/14415
(cherry picked from commit 0984599624
2023-03-24 11:35:20 -07:00
2ada171806
Be more flexible about extracting booleans from database
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14376
(cherry picked from commit dd8b52af93
2023-03-23 01:25:09 +00:00
7026cfe140
Split name from additional params only when model is a library reference.
...
(cherry picked from commit b8cf7cc080
2023-03-22 14:12:42 +00:00
b7cd1dd764
Handle single-token flag parameters.
...
Also fixes a bug where all VDMOS instance parameters weren't marked as
instance parameters.
Also fixes a bug where VDMOS thermal models weren't supported (they
have two extra pins: Tj and Tcase).
(cherry picked from commit 5bda3b99f9
2023-03-22 14:12:42 +00:00
09bb8fc4f4
Don't include non-overridden parameters in Sim.Params.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14369
(cherry picked from commit 9dc16eb014
2023-03-22 14:12:42 +00:00
1614dc975a
Separate legacy model name from parameters.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13988
(cherry picked from commit 39a801423e
2023-03-21 13:31:20 +00:00
a713ee852c
Ignore extraneous LTSpice parameters for VDMOS models.
...
Also adds special case handling of VDMOS syntax to allow parens (or extra
spaces, linebreaks, etc.) between "VDMOS" and "NCHAN"/"PCHAN".
Fixes https://gitlab.com/kicad/code/kicad/issues/14299
2023-03-20 16:16:13 +00:00
1dc9583e06
Don't attempt to load unknown plot types.
2023-03-20 10:24:22 +00:00
3afe02ac1f
Make sure legend reflects gain/phase for AC small signal analyses.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14301
(cherry picked from commit ec6d709929
2023-03-20 10:24:22 +00:00
9d457dc0ab
Less nagging. (If we need a field name, then create one.)
...
Also cleans up empty fields when exiting the dialog.
2023-03-19 19:15:28 +00:00
044c301d64
Remove accelerator keys from schematic find/replace dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14304
(cherry picked from commit afe813cae5
2023-03-18 23:38:09 +00:00
fb02e55424
Don't pass a REPORTER when checking for overrides.
...
It fails the unit tests (as it generates a message whenever no override
is found).
2023-03-17 15:30:24 +00:00
70e86434ef
Manual cherry-pick of much of 6d296038f3
2023-03-17 14:12:58 +00:00
64641c28ef
Handle underscore in parameter names.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14308
(cherry picked from commit 222cd4d009
2023-03-16 23:51:56 +00:00
69e9f4ada2
DIALOG_LABEL_PROPERTIES, add global label: better filtering of candidates.
...
The list of candidates (names) must be restricted to existing global labels
and symbols creating a global net name: power symbols having only one power
input pin (a power output does not create net name).
Fixes #14319
https://gitlab.com/kicad/code/kicad/issues/14319
2023-03-16 16:01:18 +01:00
d28cf632e4
Coverity fixes and code cleaning.
...
(cherry picked from commit a1fb8e1b1d
2023-03-16 10:59:05 -04:00
25f40566ed
Symbol editor: fix incorrect position of fields when loading a symbol from schematic.
...
In symbol editor, symbols are always shown not mirrored, not rotated.
So if the loaded symbol from schematic was rotated/mirrored, the position
of fields must be recalculated for the rotation 0, no mirror.
From master branch
2023-03-15 18:03:11 +01:00
94057886a3
Support SHEET_PATH when printing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14233
(cherry picked from commit dc78797274
2023-03-14 11:56:33 +00:00
b2679b7648
Swap pins for undo.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14100
(cherry picked from commit c266913ec7
2023-03-14 11:56:33 +00:00
c5a69f073c
Added PSPICE/LTSPICE JFET model parameters.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12425
(cherry picked from commit 3bc5e3dd8a
2023-03-12 21:05:06 +00:00
Jon Evans
Seth Hillbrand
Graham Keeth
jean-pierre charras
Jeff Young
Wayne Stambaugh
Mark Roszko
Roberto Fernandez Bautista