haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
14,116 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

14116 Commits

Author SHA1 Message Date
Seth Hillbrand 92758ea4ef eeschema: Fix minor compile warning 2018-10-11 15:31:10 -07:00
Seth Hillbrand 4f672f0d39 Fixing a number of dynamic_casts 
Dynamic casts should only be used when we explicitly check for the
resulting pointer to be NULL.  Where we know the class is castable we
can use static_cast, save on overhead and ensure our resulting pointer
is non-null.
 2018-10-11 15:24:12 -07:00
Seth Hillbrand ddea4e11d1 3d-viewer: Fix intersection bug 
Bounding box check always returned false, leading to incorrect BBox
checks when one bbox is interior to the other
 2018-10-11 14:47:06 -07:00
Seth Hillbrand dff92f915c eeschema: Formatting grid table 
Missing breaks could cause grid table to return odd text for bad values.
With the breaks, odd values are flagged for fixing
 2018-10-11 14:45:23 -07:00
Seth Hillbrand d03b08a03f gerbview: Prevent NULL dereference 
There was a possible NULL dereference when executing tool_up even
though we should never hit it, we protect against bad files.

Also converts a couple untranslated error strings.
 2018-10-11 14:23:07 -07:00
Seth Hillbrand a16e21665a view_layers: Initialize variables 
Fixes a couple spots where uninitialized variables cause unknown results.
 2018-10-11 14:08:35 -07:00
Seth Hillbrand bfa7f16b44 Wrap printfs in DBG defines 
This places the remaining printf statements behind DBG() macros to
suppress their output on release builds.  We should remove these prior
to 5.1
 2018-10-11 13:32:20 -07:00
Jeff Young a69635f539 Adjustment to net selector list sizing for GTK. 
Thanks to John Beard.
 2018-10-11 18:53:00 +01:00
Jeff Young 9f7bc6a9f9 A bit of a hack to keep OpenGL from puking. 2018-10-11 18:53:00 +01:00
Jeff Young 732e0b0bf8 Remove extra rebuild of toolbar. 
It's called from CommmonSettingsChanged() anyway.
 2018-10-11 18:53:00 +01:00
Jeff Young d9bf1550e4 Improve slightly confusing error message. 2018-10-11 18:53:00 +01:00
jean-pierre charras 4904ece0b5 eeschema gal: keep grid visibility setting when switching between back-ends 2018-10-11 18:45:18 +02:00
Seth Hillbrand 4d8534a7a6 libedit: Prevent segfault when deleting part 
emptyScreen() sets the current part to NULL.  This gracefully handles
the case by allowing a cleared screen when no part is currently
selected.
 2018-10-11 09:22:54 -07:00
jean-pierre charras 5c8c1cdb8f Eeschema doesn't show highlight net until a screen redraw is made. 
Fixes: lp:1796989
https://bugs.launchpad.net/kicad/+bug/1796989
 2018-10-11 14:19:29 +02:00
Jeff Young 94cc1efbcc Clear filter when poping up net selector. 
Even when useful it's unexpected, and GTK has issues with focus
and selection inside the control, making it hard to clear.
 2018-10-11 11:58:39 +01:00
Jeff Young ff85798918 Increase list-item padding for GTK net selector. 2018-10-11 11:58:39 +01:00
jean-pierre charras bea75753dd Eeschema fix: highlight component from pcbnew doesn't switch sheets 
Fixes: lp:1797249
https://bugs.launchpad.net/kicad/+bug/1797249
 2018-10-11 11:28:07 +02:00
jean-pierre charras 0dfd0c5f52 Minot cosmetic enhancement 2018-10-11 11:26:59 +02:00
Ronnie Gaensli ab1f016132 Fix assert freeze of eeschema when ToHSV, h is Nan 
Fixes: lp:1797006
* https://bugs.launchpad.net/kicad/+bug/1797006
 2018-10-10 21:22:26 +02:00
Jeff Young a0b8755f47 Filter <space> out of net filter box. 2018-10-10 19:49:06 +01:00
Jeff Young 01843290fc Exclude space from net filter. 2018-10-10 19:49:06 +01:00
Jeff Young 609d497870 Remember settings in Global Track & Via Properties dialog. 2018-10-10 19:49:06 +01:00
Tomasz Włostowski 0090bea24e eeschema-gal: cache & update bboxes of EDA_ITEMS on each redraw 2018-10-10 17:27:21 +02:00
Tomasz Włostowski 576b918351 BOX2: added compare operators 2018-10-10 17:26:32 +02:00
jean-pierre charras 9b027628ef Symbol editor: Fix usability issues of mirror and rotation commands 
Fix also mirrorX and mirrorY command to have the same behavior as the schematic editor

Fixes: lp:1797090
https://bugs.launchpad.net/kicad/+bug/1797090
 2018-10-10 16:42:58 +02:00
Jeff Young 06dccf715d Code cleanup. 2018-10-10 14:28:03 +01:00
Jeff Young 14721829d7 Hook up keyboard events to parent combobox of net selector. 2018-10-10 14:02:25 +01:00
Jeff Young a02e83ebdb Remove deleted footprints from selection. 
Fixes: lp:1797001
* https://bugs.launchpad.net/kicad/+bug/1797001
 2018-10-10 10:59:50 +01:00
Jeff Young ab67d2f81a Another go at fixing units changes for rulers. 
The previous fix only worked for hot-key changes.  This should
include using the toolbar, menu, etc.
 2018-10-10 10:59:50 +01:00
Jeff Young e79e2f0175 Remove properties flag from via placer so single-click mode works. 
Fixes: lp:1796769
* https://bugs.launchpad.net/kicad/+bug/1796769
 2018-10-10 10:59:50 +01:00
Seth Hillbrand abdb91203f pcbnew: Position relative using pad 
Positioning a pad relative to an item in the board edit should move the
footprint not the pad.

Fixes: lp:1796995
* https://bugs.launchpad.net/kicad/+bug/1796995
 2018-10-09 22:05:41 -07:00
Seth Hillbrand 9a86b26b82 pcbnew: Distribute footprints not pads 
When using the board edit, align tool automatically moved footprints
instead of pads but distribute tool did not.  This standardizes the
behavior.

Fixes: lp:1796997
* https://bugs.launchpad.net/kicad/+bug/1796997
 2018-10-09 22:01:23 -07:00
Seth Hillbrand 13997f0050 Revert "pcbnew: Adding copy constructors to PNS items" 
This reverts commit 41e4bc4d9f.

This commit requires additional testing before recommitting as it causes
issues with FindJoint().
 2018-10-09 14:50:20 -07:00
Jeff Young 779ef044b7 Fix wxGrid column dragging bugs. 
Close an open editor when dragging (as wxWidgets won't move it).

Make sure native column headers aren't in use where we need dragging:
their interaction with wxWidgets' dragging is buggy.

Fixes: lp:1796398
* https://bugs.launchpad.net/kicad/+bug/1796398

Fixes: lp:1796396
* https://bugs.launchpad.net/kicad/+bug/1796396
 2018-10-09 21:33:43 +01:00
Jeff Young 5f0ffe8490 Copy isDangling flag when changing label type. 
Fixes: lp:1796775
* https://bugs.launchpad.net/kicad/+bug/1796775
 2018-10-09 21:33:43 +01:00
Jeff Young c5499a6b19 Use ChangeValue() so design rules popup doesn't get cleared. 
Fixes: lp:1796780
* https://bugs.launchpad.net/kicad/+bug/1796780
 2018-10-09 21:33:43 +01:00
Seth Hillbrand 808a7d9483 pcbnew: Fix crash when GAL fallback fails in some cases 2018-10-09 09:05:14 -07:00
jean-pierre charras 37c2743fec Fix a minor compil warning. 2018-10-09 17:03:43 +02:00
Jeff Young 55c1ca1191 Handle pin sorting properly for values. 
The pin number sorter doesn't handle units at all, and seems to
stumble on negative numbers.

Fixes: lp:1796869
* https://bugs.launchpad.net/kicad/+bug/1796869
 2018-10-09 14:56:29 +01:00
Jeff Young bc69330fe0 Make sure filter text goes at the end. 
Some platforms select-all on focus, meaning each character would
replace the pre-existing string.
 2018-10-09 14:56:29 +01:00
Seth Hillbrand 246f49b8cb pcbnew: Fix Footprint selection to only footprint area 
Fixes: lp:1796866
* https://bugs.launchpad.net/kicad/+bug/1796866
 2018-10-09 05:53:31 -07:00
Seth Hillbrand 4e06494105 pcbnew: Fix minor bug in tracks cleaner 
Allow rebuild of track connection info when modified is true.
 2018-10-09 05:43:26 -07:00
Seth Hillbrand 1a6f039bb5 pcbnew: Fix minor miscalculation in dp length 
The commonParallellProjection had an odd ordering of parameters that was
not followed by callers.  This corrects the ordering to standard for
each.
 2018-10-09 05:37:48 -07:00
Seth Hillbrand 81483a9670 ARC_ASSIST: Fix return type in bool check 
The return for special angle check is boolean.
 2018-10-09 05:37:48 -07:00
Seth Hillbrand 41e4bc4d9f pcbnew: Adding copy constructors to PNS items 
Adding safe copy constructors to PNS items including assignment check
and copy operations
 2018-10-09 05:37:48 -07:00
Seth Hillbrand e1fe3c7ed4 GRID_HELPER: Remove double-check condition 
We only need to check nearest once.
 2018-10-09 05:37:48 -07:00
Seth Hillbrand 8189fbe85c pcbnew: Fix issue suppressing Creation Date 
Typo in file could lead to creation date being suppressed if timezone
could not be determined.

Also fixed a few wide chars in comments
 2018-10-09 05:37:48 -07:00
Seth Hillbrand 10d348999e pcbnew: Fix minor counting issue 
The evaluation of count_if resulted in a 0 or 1, leading to segment zone
fills always running on single processor and the progress bar showing
incorrect status.  Likely infrequently hit as only affected segment
fills.
 2018-10-09 05:37:48 -07:00
Seth Hillbrand 03813b3751 3d: Fix double-clear in oce loadmodel 2018-10-09 05:37:48 -07:00
Maciej Suminski cbf74d6939 Fix off-grid block paste 
Center point of a block may not always be located on a grid point,
therefore it needs to be rounded to the grid size to prevent off grid
component placement.
 2018-10-09 11:08:56 +01:00