Seth Hillbrand
be86e9f57f
Prevent UI events during footprint dialog ctor
...
Errors may get thrown when the 3d models are loaded for missing search
paths. This triggers the idle event that makes assumptions about the
state of the dialog. We halt event handling until the ctor finishes.
Fixes https://gitlab.com/kicad/code/kicad/issues/12944
2022-11-29 19:38:48 -08:00
Jeff Young
f891c4641b
We were saving the old board pointer, but not updating the current one.
...
This also makes a few other adjustments to order and to where we look
for the enabled layers which should make it more robust.
Fixes https://gitlab.com/kicad/code/kicad/issues/10925
(cherry picked from commit 631980b0ab
)
2022-10-19 18:17:40 +01:00
Jeff Young
914e396e2e
Implement annular ring checking for pads.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12109
(cherry picked from commit 9a4136de00
)
2022-10-19 13:49:40 +01:00
Seth Hillbrand
bf0b80d676
Remove errant new string
2022-10-07 11:37:28 -07:00
Jeff Young
cf6fd64758
Remove wxFloatingPointValidator which causes issues in some locales.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12176
2022-10-02 13:00:20 +01:00
Jeff Young
7dfa715a45
Bug fixes for layer expression processing.
...
1) Push a VAR onto the stack, not a resolved value
2) Don't collapse a PCB_LAYER_VALUE to a VALUE during processing
3) Make sure we run overloaded operators from the correct side
Fixes https://gitlab.com/kicad/code/kicad/issues/12437
(cherry picked from commit cf1565a16a
)
2022-09-28 14:00:25 +01:00
jean-pierre charras
83f135315c
3D models list in footprint properties: fix issue when a lot of 3D models is added
...
From master branch
2022-09-06 17:33:09 +02:00
Jeff Young
36a0c2a9cc
Fix issue with caches not being initialized when printing msg bar.
...
(cherry picked from commit 43df863df2
)
2022-08-04 13:04:21 +01:00
Seth Hillbrand
57de5a6b65
Net Inspector: Handle via layers
...
Rather than measuring the total via height, measure from the entry to
exit track height to get a more accurate distance
2022-08-01 20:22:13 -07:00
jean-pierre charras
06e612661c
Kicad2step: fix STEP export from Pcbnew, broken by changes in commit 8456d6c
...
also: DIALOG_EXPORT_STEP: remember tolerance option during a session.
From Master branch.
Fixes #12119
https://gitlab.com/kicad/code/kicad/issues/12119
2022-07-29 19:46:34 +02:00
Jeff Young
5214290000
Get rid of error-prone reverse logic.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12049
(cherry picked from commit 012d861aab
)
2022-07-28 10:45:56 +01:00
Jeff Young
7bd073b5cb
Make sure there are no translation changes for 6.0.x.
2022-07-28 01:08:42 +01:00
Jeff Young
af40ddd0e1
Make sure strings are either 6.0.7 values or 5.1 values.
2022-07-28 00:25:45 +01:00
Jeff Young
38b75db12c
Fix merge breakage.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12088
2022-07-26 14:42:36 +01:00
Jeff Young
d9fef3da72
Don't allow 0 line-width for unfilled shapes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12010
(cherry picked from commit d0547cbde7
)
2022-07-25 21:46:27 +01:00
Jeff Young
58451335cb
Apply DRC fixes to ERC.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11844
(cherry picked from commit 83a2f43661
)
2022-07-25 19:23:57 +01:00
Jeff Young
e7dd9f9337
Don't reset Footprint Tests Run if the board didn't change.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11844
(cherry picked from commit 048f277b1e
)
2022-07-25 18:41:48 +01:00
Jeff Young
7bf66be2ac
Don't clear marker counts when closing DRC dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11844
(cherry picked from commit 801a98a302
)
2022-07-25 18:41:21 +01:00
Seth Hillbrand
ef2bb0b621
Avoid documentation in dialogs
...
If the nomenclature is unclear, we should rework the dialog rather than
adding documentation strings to a crowded dialog.
This also prevents new strings from appearing in v6
(cherry picked from commit 0c796697b4
)
2022-06-30 10:58:13 -07:00
jean-pierre charras
20bebeb543
Gen Drill map: Re-add Gerber option but only using X2 format.
...
Only the X2 format allows the TF.FileFunction option, mandatory to
avoid mistakes about this file that is not a standard Gerber file.
2022-06-23 14:20:32 +02:00
jean-pierre charras
1f4b288664
gen drill maps: remove unusable format (HPGL and GERBER) for map files.
...
Especially, on a regular basis, map files in gerber format create problems
for board house.
From Master branch.
2022-06-22 11:29:27 +02:00
Jeff Young
00226cb0f2
Make sure Type regex doesn't match before Pad_Type or Pin_Type.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11423
(cherry picked from commit 7cb7a68b0e
)
2022-06-13 10:59:33 -07:00
Jon Evans
7053981835
Don't wipe out visibility state when changing layer count
2022-06-07 23:00:32 -04:00
Jeff Young
71ea56dea4
Remove special-case processing of ${REFERENCE} and ${VALUE}.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11476
(cherry picked from commit 6b557d8631
)
2022-05-09 12:05:51 +01:00
Jeff Young
110663d214
Fix crash bug when selecting marker.
2022-04-15 13:40:19 +01:00
Jeff Young
529048dac1
Better error reporting for DP uncoupled length.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10087
(cherry picked from commit 722b2588f4
)
2022-04-09 23:09:10 +01:00
Jeff Young
e98e9f72df
Only write Allow DRC Violations if enabled.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11177
(cherry picked from commit b78a260326
)
2022-04-03 18:13:04 +01:00
Jeff Young
6de8b99cf2
Don't default to Annotate All just because the selection is empty.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11181
(cherry picked from commit 6fa8cab188
)
2022-04-03 15:51:33 +01:00
Seth Hillbrand
c23679d9bd
Consistently handle env/prj variables
...
User-defined variables cannot be used for internally-reserved variables
Fixes https://gitlab.com/kicad/code/kicad/issues/11232
2022-03-31 17:05:25 -07:00
Seth Hillbrand
4e98ce87c7
All triangular trapezoid pads
...
A triangular trapezoid will have the deltaX/deltaY of the same size as
the length of that axis. This creates a three-point polygon, which is
perfectly valid for our use
2022-03-22 13:38:36 -07:00
Jeff Young
790b810621
A little bit of nullptr safety.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11077
(cherry picked from commit b3ae0fdca5
)
2022-03-21 20:54:28 +00:00
Seth Hillbrand
c44d31fcfb
Fix expand variables for built-in
...
Allow falling back to the alternate variable definitions if the built-in
text block variables are not set.
Also push the project into variable resolution when plotting
Fixes https://gitlab.com/kicad/code/kicad/issues/11168
2022-03-18 16:46:36 -07:00
Jeff Young
d34faf30cc
Save pointer to markers provider.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11136
(cherry picked from commit a81c8d4922
)
2022-03-16 16:23:10 +00:00
jean-pierre charras
dd154c155f
pcbnew: Fix Bezier "Add Primitive" in Pad Creation Dialog (From master branch)
2022-03-08 14:44:05 +01:00
Seth Hillbrand
0b98acfe12
Freeze TEDIT in place
...
Avoids updating the TEDIT field, preventing merge conflicts and unneeded
VCS cruft
2022-03-01 15:53:07 -08:00
Jeff Young
a8175f49a6
Repair tab order in Footprint Properties dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10978
(cherry picked from commit 2c6a2c3479
)
2022-02-26 17:42:02 +00:00
jean-pierre charras
05110b7bdc
DIALOG_BOARD_STATISTICS: Reset the drill count list before recalculations.
...
Fixes #10984
https://gitlab.com/kicad/code/kicad/issues/10984
2022-02-26 17:11:45 +01:00
Jeff Young
96bd27ef0f
Initial focus for Get and Place Footprint.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10230
(cherry picked from commit 714c65275c
)
2022-02-25 22:02:43 +00:00
Jeff Young
d56e488f2d
Remove unnecessary validations.
...
Not sure if this will fix the bug or not as I can't reproduce it, but
I'd say odds are pretty good.
Fixes https://gitlab.com/kicad/code/kicad/issues/10467
2022-02-20 20:52:39 +00:00
jean-pierre charras
d5ca09dffc
Optimize DIALOG_GLOBAL_EDIT_TRACKS_AND_VIAS: a time consuming call (OnModify())
...
was made for each item change.
It is now made only once.
Fixes #10905
https://gitlab.com/kicad/code/kicad/issues/10905
2022-02-20 20:12:36 +01:00
Jeff Young
7f40cac4b0
Fix collapsing name column in Net Inspector.
...
(cherry picked from commit 4966e2ebc2
)
2022-02-20 01:03:08 +00:00
Jeff Young
7978c8c291
Allow Rule Areas on all physical layers.
...
Required to do things like modify silk_clearance rules.
(cherry picked from commit 8f670552a6
)
2022-02-20 01:03:08 +00:00
Mikolaj Wielgus
46f7223dd9
Fix sizing of the two last columns in drill statistics table
2022-02-17 14:16:31 +01:00
Mikolaj Wielgus
75bba51b0b
Fix board statistics drill grid column sizing
...
And remove the horizontal scrollbar.
2022-02-17 14:16:31 +01:00
Seth Hillbrand
6147e997ff
Format string for translation
2022-02-14 09:17:53 -08:00
jean-pierre charras
54a3ca06c0
Pcbnew, DIALOG_GRAPHIC_ITEM_PROPERTIES: fix incorrect test for arcs.
...
It was due to mixing decidegrees and degrees, and seen for 180 deg arcs
Fixes #10841
https://gitlab.com/kicad/code/kicad/issues/10841
2022-02-14 09:46:57 +01:00
jean-pierre charras
0cb82a0985
Import netlist: fix issues: do not read netlist before it is selected.
...
Now the netlist must be explicitly selected and read instead of beeing
read during dialog creation.
It also avoid a useless netlist read when closing the dialog or trying
to change the netlist filename.
From master branch
2022-02-14 08:37:53 +01:00
Graham Keeth
30276fb5f7
update custom rule syntax help to make diff pair rule examples clearer
...
(cherry picked from commit 4442f76add
)
2022-02-13 20:15:47 +00:00
Seth Hillbrand
861589d837
Use wxEmptyString instead of wxT( "" )
...
Also fixes places where ternaries did autopromotion instead of returning
an empty wxString
2022-02-09 10:33:52 -08:00
Seth Hillbrand
8fc831cbc2
Validate arc output when editing
...
Handles checking output of the arc to ensure we don't end up generating
an invalid arc. Also keeps the limit of the arc angle to be (360,360)
excluding 0.
Fixes https://gitlab.com/kicad/code/kicad/issues/10070
2022-02-06 17:18:04 -08:00