haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
19,475 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

5352 Commits

Author SHA1 Message Date
Jeff Young f27661fa39 Be more flexible with user input; more multibyte safety. 2020-08-06 19:38:06 +01:00
Jeff Young dd0f33bcbb Get rid of extraneous char conversion. 2020-08-05 22:23:53 +01:00
jean-pierre charras ea71d9db81 Fix incorrect (and useless) conversion of a wxString to and from std::string. 
This useless conversion breaks non ASCII8 strings.
 2020-08-05 18:34:49 +02:00
jean-pierre charras a8028e57ee File history (recent opened files): fix incorrect behavior when a filename 
contains non ascii8 code (utf16 value)
 2020-08-05 15:48:03 +02:00
Jeff Young ff3d5f0de6 Generate grid event when pasting into cell. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4599
 2020-08-05 01:22:29 +01:00
Jon Evans b3b567e591 A better approach to clearing color overrides 2020-08-04 19:50:26 -04:00
Jeff Young 0e9714fdba Simplify fp-info-cache escaping mechanism. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4969
 2020-08-04 23:54:12 +01:00
Jeff Young 3cf5db3ce5 Allow cancelling of zone fills. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5035
 2020-08-04 19:53:35 +01:00
Jeff Young 6075112ea0 Fix typo in resetting selection after rebuilding colour theme popup. 2020-08-04 14:45:09 +01:00
Jeff Young f67ba62c11 Don't stop when current item is reached: there might be more. 
In particular, the two sub-items also count as "current" and need
to be deleted.

Fixes https://gitlab.com/kicad/code/kicad/issues/5057
 2020-08-04 13:28:16 +01:00
Jeff Young 9c9fdb2569 More performant (and more correct) deletion of DRC markers. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5057
 2020-08-04 11:45:07 +01:00
Jeff Young 7e63376266 Fix typo in DRC rule error reporting that causes crash. 2020-08-03 22:21:35 +01:00
jean-pierre charras a146cd9e2e JSON_SETTINGS: add more wxLogTrace() calls. 2020-08-03 08:44:34 +02:00
Jeff Young c56599ab07 Allow ERC/DRC markers to be deleted without deleting exclusions. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4953
 2020-08-02 22:45:48 +01:00
jean-pierre charras df4226f896 Settings management: try to fix full filename issues when using non ASCII7 chars. 
The fix convert all std::string storing a path to wxString (unicode support)
wxString were already used at many place to store paths, but not all.
For internal calculations mixing char strings and wide char strings is a recipe
for bug: any missing conversion between UTF8 and wxString breaks paths.
 2020-08-02 21:31:03 +02:00
Jeff Young 07ab97a58b Read and update colour settings when changed in prefs. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5046
 2020-08-02 18:43:18 +01:00
Jon Evans aae40148dc Switch to ordered_json and enable ignore_comments parser option 2020-08-02 13:11:16 +00:00
Jeff Young a58a75366e Give up on a cross-platform solution to non-ascii filenames. 
Sometime it might be worth giving another go at it, but for now I
just put conditional compilation in.

Fixes https://gitlab.com/kicad/code/kicad/issues/5024
 2020-08-01 19:47:29 +01:00
jean-pierre charras 1bcc819eed PANEL_COLOR_SETTINGS: avoid crash if the selected theme is no longer existing. 
If a previously selected color theme is no longer existing, switch to the default
theme to build the panel.

Fixes #5032
https://gitlab.com/kicad/code/kicad/issues/5032
 2020-08-01 20:23:18 +02:00
Jeff Young c8170d9430 Restore selection after rebuilding DRC/ERC tree. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5042
 2020-08-01 18:19:58 +01:00
Jeff Young 689910ab0a Add missing include. 2020-08-01 15:57:44 +01:00
Jeff Young d586495c0a Preview fp edges & text while dragging in router. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5037
 2020-08-01 15:40:34 +01:00
jean-pierre charras 91e00e14a9 JSON_SETTINGS: partial fix of non ascii7 filenames on Windows. 
It should work with ASCII8 filenames, but the member
m_filename is probably not always correctly initialized in all cases.
 2020-08-01 16:08:39 +02:00
Jeff Young e86fc64e7d Check envvars as well before flagging as un-resolved. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4644
 2020-08-01 00:24:26 +01:00
Jeff Young 625eca8170 Save language changes to file so they're picked up by other apps. 
Fixes https://gitlab.com/kicad/code/kicad/issues/1939
 2020-07-31 22:29:05 +01:00
Jeff Young 61c817377f Support for wchar_t Windows filenames in JSON settings. 2020-07-31 21:01:13 +01:00
Jeff Young 0e3d9dd2f1 Use ChangeValue() during init so we don't fire events. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5030
 2020-07-31 18:44:54 +01:00
Jeff Young 6e4d4401ae Make sure to translate UTF8 std::string to wchars for wxString. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5024
 2020-07-31 14:48:45 +01:00
jean-pierre charras 2d9b0b255b Better fix for OPENGL_GAL::DrawSegment() than initial commit 294dab. 
segments having a length <= 1 internal unit are not drawn  in opengl gal.
So these segments are drawn as circle.
 2020-07-31 15:41:21 +02:00
Ian McInerney 268dec5c19 Cleanup some build and Coverity warnings 2020-07-31 02:46:05 +01:00
Seth Hillbrand 294dabf640 GAL: Fix issue with small tracks being hidden 
When drawing segments that are smaller than the segment width, OpenGL
did not use realistic values, leading to hidden, small tracks.  Instead,
we set the track to only draw a segment when the length is at least 1
radius long (so that we can see the full semi-circle at the track end)

Fixes https://gitlab.com/kicad/code/kicad/issues/5009
 2020-07-30 15:11:39 -07:00
Jeff Young 577c1be391 Report all DRC rule errors, not just the first. 2020-07-30 14:27:42 +01:00
Jeff Young ebef7c03db Add simplified HTML reporter window. 2020-07-30 14:27:42 +01:00
Jeff Young 5a1b1c544a Add layer to rule grammar. 2020-07-30 14:27:42 +01:00
Seth Hillbrand b650e4568b Mirror hidden text in SVG plotter 
We output a 0 opacity text in the SVG plotter to allow searching.  When
this text is changed to 100 opacity, it can show up on the user screen
and so needs to be mirrored to match the stroke font output

Fixes https://gitlab.com/kicad/code/kicad/issues/5001
 2020-07-30 06:17:37 -07:00
Jon Evans a5fbbaa548 Don't hide sheet swatches in theme editor 
Even if the override is turned off, the theme colors
will be used for sheets that don't have colors explicitly set.
 2020-07-29 21:29:51 -04:00
Seth Hillbrand 0a4ce183a4 ADDED: polygon newlines every point 
By default KiCad will now print each polygon point on its own line.
This adds to the vertical distance for large polygons but makes revision
control much cleaner as single point addition to a polygon does not
propagate to a diff over the full polygon.

Users/developers who want to save the files using the 4-points per line
have the ADVANCED_CONFIG setting 'CompactSave' which will provide the
original save method
 2020-07-30 01:18:44 +00:00
Jon Evans b0c6a0f9ef Allow sheet colors to remain unspecified if not manually set 
This way, when the user changes their color theme, any sheets
that did not have a specific color set will change with the theme.

Also add a button to clear color overrides from a sheet, because
any schematics that have been saved before this change will have
the colors set to something other than UNSPECIFIED.
 2020-07-29 21:16:07 -04:00
Tomasz Wlostowski 64766d9754 common: build Lemon grammar for libeval_compiler only when Lemon is installed 2020-07-30 02:13:19 +02:00
Tomasz Wlostowski fe4695719d libeval_compiler: post-rebase fixes 2020-07-29 23:14:34 +02:00
Tomasz Wlostowski 3c80b98d1c libeval_compiler: CONTEXT runs the UCODE now (thread-safe solution), fixed some memory leaks 2020-07-29 23:14:03 +02:00
Tomasz Wlostowski 7dbd8ef802 EDA_TEXT: implement GetEffectiveShape() 2020-07-29 23:14:03 +02:00
Tomasz Wlostowski abe6ccf97e common: re-enable libeval_compiler and DRC proto test (fixed missing file issues) 2020-07-29 23:14:03 +02:00
jean-pierre charras 98b1f55e29 Eeschema: minor fixes: fix incorrect label in DIALOG_LIB_EDIT_PIN, electrical pin list. 
Gives also to functions GetText() and GetBitmap() a more significant name.

Fixes #5007
https://gitlab.com/kicad/code/kicad/issues/5007
 2020-07-29 17:04:52 +02:00
Jeff Young 9f6098321f Cleanup of extraneous calls for string conversion. 
We're already in wx-land, so we don't need the GetData() calls.
 2020-07-28 20:44:40 +01:00
PJM a1b79298a4 GerbView #2124 : Alternative drill file extension .txt 
'.txt' is a common file extension for drill files.  This Merge
Request adds it to the list of extensions used in the File Open dialog
for Excellon Drill files.

Fixes issue https://gitlab.com/kicad/code/kicad/-/issues/2124
 2020-07-28 04:59:50 +00:00
Jeff Young b74e125264 Read/write schematic netclass properties. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4990
 2020-07-27 23:10:46 +01:00
Jeff Young 2ea5528cd0 Start compiling identifiers. 
We'll need this if we support the "L == foobar" syntax, and besides
it should really be up to the parser client whether or not they use
identifiers with no function call or property reference.

It also allows us to generate error messages for unknown identifers.
 2020-07-27 19:53:42 +01:00
Jeff Young 8a010bc23e Null safety for expression variables. 2020-07-27 19:53:42 +01:00
jean-pierre charras 0103164571 Simulator: optimize a plot function, to support large amount of points. 
Redundant points are not plotted.

Fixes #4737
https://gitlab.com/kicad/code/kicad/issues/4737
 2020-07-27 10:47:52 +02:00
Mark Roszko 8324cb30b7 Save the wxDisplay index to set the position of windows correctly 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4338
 2020-07-27 02:53:56 +00:00
Mark Roszko 7bdb98f961 libedit: Make context menu follow context 2020-07-26 20:16:38 +00:00
jean-pierre charras ed79ef8feb PDF plotter: better handling of non ASCII7 (unicode 16) chars. 
Note also the PS plotter handle poorly these non ASCII chars.

Fixes #4957
https://gitlab.com/kicad/code/kicad/issues/4957
 2020-07-26 17:59:02 +02:00
Seth Hillbrand 6900f04ee0 Change Zone extra clearance magic number to AC 
Rather than keeping a magic number in the code, we set the default in
the advanced config setting and allow users/developers to modify it.
 2020-07-26 07:20:24 -07:00
Jeff Young 552dde8976 Fix return value going out of scope. 
(From Coverity report.)
 2020-07-26 13:41:43 +01:00
Simon Richter 95c2b261e8 Don't mandate ownership semantics in API 
This API doesn't transfer ownership, so no smart pointers are required --
this just needlessly tightens requirements on the user of the interface.

(Fixes five instances of MSVC C26410 warning)
 2020-07-26 02:45:27 +00:00
Jeff Young bf445c1a95 Performance enhancements. 
1) cache pad polygon outlines
   huge improvement in connectivity performance and a decent
   improvement in DRC performance
2) don't pre-allocate CONTEXT stack
   significant improvement in DRC rule performance
2) don't keep re-encoding strings
   decent improvement in DRC rule performance
 2020-07-25 13:03:33 +01:00
Jeff Young f97c50bfde Give excluded DRC items their own layer. 
(And fix a bug with the new mulit-layer zones and rule-based keepouts
at the same time which prevented me from testing it.)

Fixes https://gitlab.com/kicad/code/kicad/issues/4954
 2020-07-24 01:28:25 +01:00
Jeff Young 6529e339a9 Don't store context in the uCode. (It's not thread-safe.) 
Although it does give some pretty funny results when filling zones.
 2020-07-23 22:21:13 +01:00
Jeff Young f2812773d4 Better handling of undefined values in Rule expressions. 
This is particularly important to keep the user from having to
enter overly verbose statements such as:
A.Type == 'via' && A.Via_Type == 'buried'
when:
A.Via_Type == 'buried'
is perfectly clear.
 2020-07-23 16:41:58 +01:00
Jeff Young 84085df82a Fix tokenizer to allow '_' in tokens. 2020-07-23 16:41:58 +01:00
jean-pierre charras c254b331f3 Pcbnew: Activate pad fabrication property in pad properties dialog. 
It was previously an option of advanced config since 6 months.
It is now not optional.
 2020-07-23 14:33:24 +02:00
Jeff Young 86c9adbcba Add auto-completion for DRC rule function calls. 2020-07-22 21:28:02 +01:00
Jeff Young 637571e0be Assume mm if units not given in DRC rules. 
This keeps us from internalizing them as nm which appear to have
no effect (at least visually).
 2020-07-22 15:11:23 +01:00
Jeff Young 150c781f27 Fixup formatting and coding style. 2020-07-22 14:33:32 +01:00
Jeff Young a6b6084a60 Add preflighting for DRC rule function calls. 2020-07-22 14:33:32 +01:00
Ian McInerney 21e199f675 Allow all common settings panels to be reset 2020-07-22 00:18:30 +01:00
Ian McInerney 9997c46ee4 Make Coverity use the main KiCad version string 
Also create a kicad_build_version.txt file in the build directory
that only contains the version string.
 2020-07-22 00:18:29 +01:00
Fabien Corona a1437f4a95 Eeschema : Add A5 sheet size 2020-07-21 00:00:36 +00:00
Jon Evans a107f7ce5b Fix a few issues with legacy project loading 
- Prevent crash on project tree for "Empty project" item
- Correctly handle loading of legacy projects in tree view
- Fix an issue where legacy projects would not get saved

Fixes https://gitlab.com/kicad/code/kicad/-/issues/4944
 2020-07-20 19:39:59 -04:00
Jeff Young 095937563b Hook libeval compiler up to rule parser 
- convert expression string tokens to single-quote-delimited
- fix bug where netclass assignments weren't getting updated after
  board setup dialog
- move property manager rebuild to lazy evaluation
- improve performance with wider use of const&
- retire DRC_SELECTOR stuff
- use wxString for GUI stuff (particularly translated stuff)
- fix EqualTo() to return false instead of asserting when op types
  don't match
- fix buffer overruns with fixed-size string buffers
- make expression function calls case-insensitive
- integrate expression errors into rule parser
- produce more and better error messages
- keep BOARD_ITEM ptrs const as long as possible
- fix a couple of uninitialized variables
 2020-07-20 22:11:53 +01:00
jean-pierre charras 6d8fb94d86 Fix a few Coverity warnings. 2020-07-20 16:19:19 +02:00
Mark Roszko 3b727b5d16 Make preference groups not selectable 2020-07-20 13:45:46 +00:00
Seth Hillbrand aa788b452e Adding Fabmaster extensions 2020-07-19 20:46:14 -07:00
Ian McInerney 50b2271f84 Fix missing variable initialization 2020-07-18 23:56:39 +01:00
Seth Hillbrand a253c53fe7 Fix buffer overflow in dumpNode 
The formatted string buffer doesn't need to be used, so we bypass it
with string concat
 2020-07-18 13:33:23 -07:00
Ian McInerney 7b705af038 Refactor common QA components to create a single common library 
This moves the program-specific code (e.g. BIU files) into
the program tests.

Also, create title_block.cpp to break a dependency that pulled
in eda_text.cpp when using the TITLE_BLOCK object.
 2020-07-18 16:21:15 +01:00
Jeff Young bcb29b6bf8 Fix security issue (buffer overrun). 2020-07-18 11:44:12 +01:00
Jeff Young 49d242944d Don't treat new netclass as changing a netclass name. 
In particular, since it goes from empty string to non-empty, the
oldName comparison will cause it to pick up all unassigned nets.

Fixes https://gitlab.com/kicad/code/kicad/issues/4922
 2020-07-18 11:44:12 +01:00
Ian McInerney cc688a3e1d Initialize variables properly 
Fixes https://gitlab.com/kicad/code/kicad/issues/4919
 2020-07-18 00:36:47 +01:00
Urja Rannikko aa7ab46a06 GAL: Round the incoming mode parameter in fragment shader 
This fixes some letters being randomly boxes and some circles
being randomly triangles on the Mali T760.
 2020-07-17 20:24:18 +00:00
Urja Rannikko 65ceeebc71 GAL: Remove dead code regarding SHADER_LINE_B in the fragment shader 
The only test for it was only called from a function
that's called if the mode is SHADER_LINE_A, not B.
 2020-07-17 20:24:18 +00:00
Jeff Young 3fd0a3f842 Update text variables even when they're changed from other binary. 
For instance, you might have PCBNew open but change the variable
value through EEschema > Schematic Setup.

Fixes https://gitlab.com/kicad/code/kicad/issues/4918
 2020-07-17 21:05:11 +01:00
Jeff Young 33480ecad1 Show all symbol libraries by default. 
Also fixes an issue where the plugin wasn't getting reset if the
library type was changed.
 2020-07-17 18:33:14 +01:00
Jon Evans 5401f06fce Don't nag when we can't save project settings 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4164
 2020-07-16 22:56:02 -04:00
Jeff Young 20ca836ab3 Use consistent naming for project manager. 2020-07-16 01:39:29 +01:00
Ian McInerney af729d578f Unify settings reset buttons into one location 2020-07-16 00:08:16 +01:00
Ian McInerney 4ee8ea1318 Initialize variable in hash computation 2020-07-15 22:58:05 +01:00
jean-pierre charras 9f20c61fa7 Remove creation on the fly of a wxPaintEvent instance (fix previous commit). 2020-07-15 14:56:35 +02:00
Jeff Young 7d07e6719f Make sure eeschema default grid is 50mils. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4835
 2020-07-15 13:51:12 +01:00
jean-pierre charras 6366aa3ede Remove creation on the fly of a wxPaintEvent instance (final step). 
This is not allowed in 3.1.4 wxWidgets.
 2020-07-15 12:58:43 +02:00
Jeff Young e9da02e2d5 Only reserve hotkeys for focused textCtrls that are editabled. 
Otherwise just send Ctrl-C to the disabled control, and everything
else to the tool framework.

Fixes https://gitlab.com/kicad/code/kicad/issues/4801
 2020-07-14 13:30:43 +01:00
Jon Evans 97c360aa9b Fix saving of default netclass 
This was broken as a side-effect of 3939b31
Default netclass doesn't get the "nets" member
but still needs to be added to the array of classes

Fixes https://gitlab.com/kicad/code/kicad/-/issues/4860
 2020-07-13 19:53:03 -04:00
Jeff Young 940570e9ec Catch exception so that we at least throw up an error message. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4677
 2020-07-13 22:41:56 +01:00
jean-pierre charras d34f8fd4b5 Prepare removing creation of a wxPaintEvent instance, not allowed in 3.1.4 wxWidgets 2020-07-13 19:53:07 +02:00
Jeff Young 1cd2a51db2 Make undo/redo lists protected. 2020-07-13 15:53:36 +01:00
Jeff Young 7340c97ef9 Undo for schematic-wide operations. 
Editing value/footprint fields of multi-unit components.
Find/Change.
Annotation.
Back annotation.

Fixes https://gitlab.com/kicad/code/kicad/issues/2122

Fixes https://gitlab.com/kicad/code/kicad/issues/4869

Fixes https://gitlab.com/kicad/code/kicad/issues/3933

Fixes https://gitlab.com/kicad/code/kicad/issues/4871

Fixes https://gitlab.com/kicad/code/kicad/issues/3899
 2020-07-13 12:32:17 +01:00
Seth Hillbrand 9f09c3872f Ensure file reads always use the C-locale variant 
Str2Double assumes current locale.  We usually switch the locale when
reading files but we should be using the function that explicitly gets
the C-locale conversion.
 2020-07-12 20:03:50 -07:00
Jon Evans a94a81b9a8 GAL: Handle text opacity in OpenGL 
Vertex alpha was being dropped in the font shader
 2020-07-12 11:16:28 -04:00
Jon Evans 5d118b0700 More visibility settings infrastructure 
ADDED: Three-state high contrast mode action
ADDED: Save contrast mode in local settings

Also some initial infrastructure for layer presets
 2020-07-11 21:59:07 -04:00