599a33a9c6
Make PLEditor greedy selections of rectangles sparse.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6278
2020-12-02 23:18:33 +00:00
64f555079a
Code cleanup related to zoom:
...
- remove outdated code or comment coming from old drawing code using wxDC
- move zoom values lists to zoom_defines.h
- fix incorrect zoom max and min values (gal scaling factor limits).
2020-12-02 18:35:28 +01:00
71ab42e60a
Minor fixes and cleanup related to zoom definitions.
...
Mainly move 2 define relative to Zoom from convert_to_biu.h to zoom_defines.h.
Will make some changes/fixes in zoom code more easy.
2020-12-02 10:14:35 +01:00
4b2d9a5054
Don't draw ruler ticks outside the viewport.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6518
2020-12-02 00:29:00 +00:00
df262eaa06
Make prev/next marker work reliably on all platforms.
...
Requires us to move from arrow-keys to our own commands (the only
way that the OSX wxWidgets impl doesn't eat the keys when the dataVIew
has focus).
While there we might as well add a command to exlucde markers.
ADDED Prev Marker, Next Marker, Exclude Marker
Fixes https://gitlab.com/kicad/code/kicad/issues/6575
Fixes https://gitlab.com/kicad/code/kicad/issues/5501
2020-12-01 22:37:07 +00:00
3c521942ed
Smarten isEmpty checks to include nothing-but-whitespace.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6567
2020-12-01 16:39:06 +00:00
7f8faffa3a
Trim down ever-expanding context menu.
2020-12-01 14:04:01 +00:00
308ab8cafa
Properly scale the ticks for all imperial units on the preview ruler
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6564
2020-12-01 01:20:28 +00:00
de9d1eb93e
Don't write local settings of imported project into current settings.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6552
2020-11-30 23:10:21 +00:00
3a9a6e22bc
Fix issues in reporting netclasses.
...
1) make sure we get the default netclass when we want it
2) escape for HTML (particularly important for "<invalid>", but also
for reporting user rule names, netclass names, etc.)
2020-11-30 14:38:06 +00:00
e09271ca0e
Fixes for hole clearance and hole-to-hole tests.
...
1) Separate out CONSTRAINT types
2) Filter both source and dest pads/vias for drilled holes when doing
hole-to-hole checks. We were checking the items being put into the
DRC RTree, but not the items we were scanning.
3) Add hole clearance to Board Setup Constraints panel.
Fixes https://gitlab.com/kicad/code/kicad/issues/6546
Fixes https://gitlab.com/kicad/code/kicad/issues/4683
2020-11-29 23:35:23 +00:00
d3d26f2892
Update the zoom level as soon as it is modified by the mouse wheel
...
The zoom level displayed on the bottom of the canvas was not immediately
displayed, only after a mouse move.
Fixes #6542
https://gitlab.com/kicad/code/kicad/issues/6542
2020-11-29 17:46:24 +01:00
3b18fa84bf
Null pointer safety (from Coverity).
2020-11-29 10:57:45 +00:00
056ff36b4b
Fix indentation in migrate settings dialog.
2020-11-29 10:57:45 +00:00
b8303a3484
Fix migrate settings dialog ui bug
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6258
2020-11-29 08:41:15 +00:00
f2ba9f7ac3
CADSTAR PCB Archive Importer: Correctly load the pad numbers as per the original design
...
To load the pad numbers correctly we need to also check the PART DEFINITION for each component
2020-11-28 17:18:17 +00:00
005c3b84ad
Better fix for incorrect page preview in Page Settings when the worksheet contains a bitmap
...
The actual size of pixels was incorrectly set.
Fix also bad names for a few vars and methods in BITMAP_BASE.
2020-11-28 10:53:26 +01:00
896ad4a749
Rewrite PCBNew selection disambiguation based on shapes.
...
The new shape architecture gives us the opportunity to make text
selection much more intuitive by actually looking at the glyph
shapes. Before text would be selected when you clicked in the
descenders area (which was usually blank given uppercase letters
and digits).
Fixes https://gitlab.com/kicad/code/kicad/issues/6525
2020-11-27 22:03:14 +00:00
4f651901aa
Fix incorrect page preview in Page Settings dialog when the worksheet contains a bitmap
2020-11-27 15:42:27 +01:00
ef75ce9035
Fix: refusal of creation of non-existent directory tree on plotting
...
Fixed https://gitlab.com/kicad/code/kicad/-/issues/6394
wxWidgets uses wxFileName::Mkdir to create a directory tree like `mkdir
-p`.
2020-11-27 07:24:14 +00:00
fc2bdc49de
Once more into the depths of hell... er, I mean fix a focus issue.
...
So the new steals-focus protection stuff works well when there's a
focused control, but not as well when there's a modal dialog up which
happens not to have a focused control (or worse, a focusable control).
This adds a second mechanism for also checking to see if a modal dialog
is up (something that wxWidgets, true to form, makes very difficult).
Fixes https://gitlab.com/kicad/code/kicad/issues/6520
2020-11-26 16:47:40 +00:00
2a87980d45
Remove overly verbose messaging.
2020-11-26 16:47:40 +00:00
94de8ada97
Formatting and naming conventions.
2020-11-26 16:47:40 +00:00
b8414174af
Duplicate Eeschema's select-ref-number strategy in PCBNew.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6504
2020-11-25 17:13:00 +00:00
f436360196
Consistency in capitalization and plurality.
2020-11-25 17:13:00 +00:00
d50d728d19
Cleanup compiler warnings
2020-11-25 00:08:09 +00:00
9c7c05c161
Mostly formatting cleanup but a few type-casting cleanups too.
2020-11-24 22:16:41 +00:00
696fc7e46e
Fix a minor issue in PANEL_SETUP_NETCLASSES, when resizing it. Second attempt.
...
If a class name choice widget is selected, resizing the panel does not
move the opened widgets, until it is closed.
Fixes #6474
https://gitlab.com/kicad/code/kicad/issues/6474
2020-11-24 17:03:48 +01:00
dbc7831d0c
Potential fix for recursive error crash.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6471
2020-11-24 13:48:33 +00:00
1b7bfa2424
Revert "Fix a minor issue in PANEL_SETUP_NETCLASSES, when resizing it."
...
This reverts commit 52d8b70d3a
2020-11-24 14:36:12 +01:00
52d8b70d3a
Fix a minor issue in PANEL_SETUP_NETCLASSES, when resizing it.
...
If a class name choice widget is selected, resizing the panel does not
move the opened widgets, until it is closed.
Fixes #6474
https://gitlab.com/kicad/code/kicad/issues/6474
2020-11-24 11:29:37 +01:00
78b505f36a
Count head and tail lists as well.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6461
2020-11-23 23:54:54 +00:00
298bc13f5d
Delay deletion of the RC_ITEM tree nodes
...
The wxWidgets call "ItemDeleted" still requires access to the item in
memory, so we delay deletion by storing removed items to the end of the
call
Fixes https://gitlab.com/kicad/code/kicad/issues/6301
2020-11-23 09:52:46 -08:00
064ebd4dc8
Minor fix for include files.
2020-11-23 11:43:22 +01:00
b32c2a6c90
Refactor EDA_TEXT::TransformToSegmentList() to return a vector of points
...
This allows reading text object as it is rendered through python API.
2020-11-23 07:50:54 +00:00
e761df17f5
Netnames are case sensitive.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6460
2020-11-23 01:10:08 +00:00
c1b94f9ebf
Handle escaped netnames better.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6404
2020-11-22 18:20:13 +00:00
3a4bd6fb8b
Fix uninitialized variable.
2020-11-21 20:57:36 +00:00
1391774f64
Re-factor boundary/courtyard checker error handling.
...
ADDED Footprint Checker dialog to display the results in.
Fixes https://gitlab.com/kicad/code/kicad/issues/6446
2020-11-21 20:57:35 +00:00
64636601b8
Eeschema: fix a Unicode/UTF8 management when pasting items from Clipboard.
...
Copy to clipboard save items (using S expr description) using wide strings
(not UTF8 encoding).
But Paste from clipboard was not converting the wide string to UTF8 string
when getting the stored data to send it as std::string to the S expr reader.
Fixes #6449
https://gitlab.com/kicad/code/kicad/issues/6449
2020-11-21 10:59:25 +01:00
0a7ef25453
Replace STROKE_FONT performance fix, this time with correct type.
...
Also this time with a fixed Cairo implementation and an implemented
BASIC_GAL implementation.
Fixes https://gitlab.com/kicad/code/kicad/issues/6447
2020-11-20 11:24:52 +00:00
1db882ed1b
Partially revert 876b87b64e
...
This broke all text objects (for me on Windows at least)
2020-11-19 19:34:54 -05:00
9e9946628a
Go back to arrow cursor on a cancel (or finish).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6421
2020-11-19 20:09:28 +00:00
876b87b64e
Minor performance fixes for PCBNew selections.
2020-11-19 17:23:02 +00:00
9512b1c5c3
Formatting.
2020-11-19 13:35:26 +00:00
048715ab91
Gerber output: fix incorrect creation of trapezoid apertures.
...
When creating 4 corners (trapezoid) apertures, the rotation parameter was
not tested, therefore shapes actually used could have incorrect rotation.
Fixes #6432
https://gitlab.com/kicad/code/kicad/issues/6432
2020-11-19 09:16:56 +01:00
99da663e82
Remove unused variables plus some more fixes from CppCheck
...
Remove unused variables plus a few more fixes from CppCheck
Remove unused variables plus a few more fixes from CppCheck
2020-11-19 02:28:47 +00:00
bdc41f7365
Don't search hardcoded (and never valid on non-english) Windows paths
2020-11-18 19:22:00 -05:00
0e44f5128c
Add const specifiers
2020-11-18 19:50:36 +00:00
c1d1c12b41
Simplify message panel code.
...
We've had the colours turned off for two releases now without any
screaming or gnashing of teeth, so it's time to clean up the code.
2020-11-18 17:32:40 +00:00
cb5ec8bce1
Make Eeschema cursors update without waiting for mouse movement.
2020-11-18 17:32:40 +00:00
04a3619428
Fix opening symbol documentation field paths with spaces on GTK.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6422
2020-11-18 11:54:12 -05:00
16e3e59495
Split out arrayDim and MIRROR templates from macros.h
...
These were not macros
2020-11-17 20:21:04 -05:00
54427fd594
Make sure deleted text items are removed from view and selection.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6407
2020-11-17 20:48:15 +00:00
94a358c592
fix 2 compil issues
2020-11-17 19:32:20 +01:00
a207bd97bb
Naming conventions.
2020-11-17 16:05:49 +00:00
7d1a4a4224
Add version information to footprint sexpr files and clipboard
...
This allows the parser to properly interpret the sexpr version
of the footprint so that it can throw future format errors or
do version specific parsing properly.
2020-11-16 23:19:09 +00:00
577e99d49d
Minor hotkey list panel layout improvement.
...
Use wxCOL_WIDTH_AUTOSIZE instead of fixed column sizes. This doesn't fix
the initial sizer layout issue on wxWidgets 3.0 but at least resizing the
dialog has better column width behavior.
2020-11-16 17:46:39 -05:00
7933935b4a
Naming conventions.
2020-11-16 00:04:55 +00:00
b31e97cfed
Fix FP/PCB_SHAPE fill sexpr syntax to be backwards compatible
...
Previously the fill for shapes inside a footprint was not being
properly imported from older versions becase the default of no
flag changed from representing filled to representing no fill.
Introduce explicit filling information, and continue to treat no
flag on a polygon as meaning it is filled (which is the legacy
behavior).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6393
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6390
2020-11-15 21:28:27 +00:00
1ce1e493d6
A rule zone is not really a BOARD_CONNECTED_ITEM.
...
Or at least it shouldn't always be treated as one.
Fixes https://gitlab.com/kicad/code/kicad/issues/6382
2020-11-15 20:23:15 +00:00
3f1a58bd06
Replace "module" with "footprint" in PCB sexpr.
2020-11-15 20:23:15 +00:00
7bd31d5237
Naming conventions.
2020-11-14 18:26:03 +00:00
5100f720ef
Don't hard crash on a failed kiway player due to null reference
...
This is possible if a kiface fails loading due to missing dlls, etc
2020-11-13 21:42:32 -05:00
ec020dd19f
First-class support for filled shapes.
2020-11-14 01:40:32 +00:00
47e86d76fb
Cleanup prior to adding filled flag.
2020-11-13 21:07:36 +00:00
1aaa690eb5
Remove errant extra include.
2020-11-13 18:10:41 +00:00
bfe750f88a
Temp hack for square looking buttons on OSX.
2020-11-13 17:55:54 +00:00
bdbb68f813
MODULE -> FOOTPRINT.
2020-11-13 16:04:03 +00:00
3451ac3088
PCB_MODULE_T -> PCB_FOOTPRINT_T
2020-11-13 15:16:24 +00:00
63a54d003e
More module -> footprint.
2020-11-13 15:16:24 +00:00
522d64968e
Yet more module -> footprint.
2020-11-13 15:16:24 +00:00
f5443de7f9
D_PAD -> PAD.
2020-11-13 15:16:24 +00:00
f0d0e17aab
Prepare for MODULE -> FOOTPRINT.
2020-11-13 15:16:24 +00:00
84dd5108ba
Remove some "class_" prefixes from files.
2020-11-13 15:16:23 +00:00
f7333ad64a
Update some classnames including archaic zone names.
2020-11-12 10:31:25 +00:00
d7ad315826
Minor paged dialog layout fixes.
2020-11-11 09:24:53 -05:00
e7bf2b6256
Update comment
2020-11-11 13:45:46 +00:00
2a3e6ee1b5
Nix another easily triggered infinite event loop on Windows
...
This infinite loop was triggered on any dynamic scaling change with KiCad open.
Either local display scale change OR Remote Desktop.
2020-11-10 19:59:29 -05:00
c207a90999
Use new upstream IsCheckable function in UI update event handling
...
This function is introduced in wxWidgets 3.1.5 and allows you to
query the event with if it should be checked or not instead of
having to figure it out based on the item type.
2020-11-11 00:41:02 +00:00
05595da235
Cosmetic fixes to the toolbar palettes
...
* Align the top of the buttons in the palette with the toolbar button
* Don't check the button in the palette, since the toolbar button will
show as checked.
2020-11-11 00:41:02 +00:00
d88eaaf477
Fix various compiler and Coverity warnings
2020-11-11 00:41:02 +00:00
11e6cac42b
Introduce EGL backend support for the OpenGL canvas
...
wxWidgets 3.1.5+ on Linux will compile with the Wayland EGL
canvas as the backend instead of the X11 backend. This requires a
version of GLEW compiled with the proper EGL defines and a different
header/code for certain parts that are X11 GLEW specific.
This introduces an in-tree version of GLEW that will be built with the
GLEW_EGL flag then statically linked into the KiCad executables when
EGL support is needed.
2020-11-11 00:41:02 +00:00
7e556ed91d
Pcbnew: minor page properties dialog layout fixes.
2020-11-10 17:29:46 -05:00
13e939ffa0
More Module -> Footprint.
2020-11-10 21:20:03 +00:00
812b714ccd
More Module -> Footprint and a bit of formatting cleanup.
2020-11-10 20:53:12 +00:00
4ea3914d4e
Coverity fixes.
...
CIDs: 312996, 305508, 305509, 305510, 312992, 312997, 312994, 312995,
312968, and 306650.
2020-11-10 08:50:16 -05:00
1f5213946e
Restore accidentally-removed allowsSpaces architecture.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6252
2020-11-08 00:34:04 +00:00
ad1e8ebda8
Cleanup formatting.
2020-11-07 21:40:56 +00:00
17c9f7c61f
Cleanup formatting.
2020-11-07 21:21:56 +00:00
bfd8a62852
Formatting and naming conventions.
2020-11-07 18:50:30 +00:00
2d33b23530
Fix formatting
2020-11-07 09:51:09 -05:00
df49e0bb0d
Don't leave dangling pointers
2020-11-07 09:48:59 -05:00
69c1171320
Add PDFWriter debug mode (ie: uncompressed output).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5593
2020-11-06 10:56:45 +00:00
05b5d2de00
Cleanup/downscope variable
2020-11-06 00:38:53 -05:00
9ed1ad06f7
The canvas should get the focus on clicks not the window
...
Fix #6308
2020-11-06 00:37:05 -05:00
08ca80a2d8
Smooth out redrawing of toolbars by not letting wx pointlessly calculate both orientations
...
Monkey patch
Fix #5705
2020-11-05 20:56:14 -05:00
b78e2c8c28
Add missing <algorithm>
2020-11-06 00:37:57 +00:00
262bb06d91
Avoid stealing focus from text controls when hovering over canvas
...
Fix #4879
Fix #4888
2020-11-04 22:22:45 -05:00
1899209e9b
Support unicode text on the clipboard.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6294
Fixes https://gitlab.com/kicad/code/kicad/issues/1802
2020-11-04 23:14:44 +00:00
Jeff Young
jean-pierre charras
Ian McInerney
Michael Kavanagh
Roberto Fernandez Bautista
RigoLigoRLC
Seth Hillbrand
qu1ck
Marek Roszko
Dominik Wernberger
Wayne Stambaugh
Simon Richter