2798035f85
eeschema: Catch parameter errors in SPICE sim
...
Any errors in the dialog should be handled and, at worst, allowed to
redo. SPICE_VALUE throws KI_PARAM_ERROR, so we catch that explicitly.
Fixes: lp:1776051
* https://bugs.launchpad.net/kicad/+bug/1776051
2018-06-11 18:02:20 -07:00
5c65881fde
Allow Global Fields Editor to Cancel with no changes.
2018-06-11 12:10:19 +01:00
da61285a29
field editor: Save checkbox states
...
This refactors the symbol field editor's checkbox state-saving code to
deal with multiple projects with disjoint field sets more consistently.
For instance, imagine I have a two projects
* Proj1 has fields A, B, C
* Proj2 has fields A, B, D
Under the old scheme, when I switch from one project to the other the
state of fields C and D will be forgotten. With the new approach,
however, they are retained.
Not to mention, the implementation is considerably simpler. Fixes
2018-06-11 12:08:59 +01:00
3f783d2318
field editor: Find components when reference field is clicked
...
This makes it significantly easier to find a particular component when
using the field editor, as I often do for part selection.
Fixes: lp:1772169
* https://bugs.launchpad.net/kicad/+bug/1772169
2018-06-11 10:27:49 +02:00
b9874da3a6
Remove background fp loading from Choose Symbol dlg.
...
There are a bunch of problems with event processing and closing
documents, etc., when enabled. See the bug report for more
info.
Fixes: lp:1774777
* https://bugs.launchpad.net/kicad/+bug/1774777
2018-06-09 00:51:39 +01:00
a5c213c23d
Set footprint splitter window canvas to transient
...
The splitter window can not be the parent to any additional windows.
If it acquires a child that persists past the lifetime of the splitter
window, we get a segfault.
2018-06-06 10:03:00 -07:00
5263558eaa
Fix crash when delete button of footprint filter is clicked and no footprint is selected
...
Fixes: lp:1775296
* https://bugs.launchpad.net/kicad/+bug/1775296
2018-06-06 00:01:47 +01:00
aaf47bbe71
Replace "unsaved changes" dialog to Global Fields Editor.
2018-06-06 00:01:47 +01:00
7343e78347
Fix some Coverity uninitialized field warnings.
...
Fixes Coverity CIDs:
- 175824
- 169337
- 163191
- 175827
- 175440
- 175438
- 157136
2018-06-04 13:48:57 -04:00
d03e92a3a2
Field Name Template (aka Default Fields) fixes.
...
Move from a "default" fields model to a "seed" fields model. See
discussion on devlist:
https://lists.launchpad.net/kicad-developers/msg35823.html .
2018-05-30 09:46:52 +01:00
8c63dac0c3
Component Chooser: do not create FP list when the FP preview is disabled
2018-05-30 09:53:58 +02:00
2cb65f9c19
Make the Simulator error strings translatable
2018-05-28 14:51:10 +02:00
8f5cb32598
Don't write empty fields from Global Edit Fields dialog.
2018-05-23 21:35:23 +01:00
3893c43eb0
Fix compil issues.
2018-05-23 11:31:13 +02:00
8c5037a48b
Optionally sort reporter messages
...
It can be useful to have similar class messages grouped together so that
error messages in a larger report don't get lost among the
warning/info/action messages.
This patch allows sorting of messages for dialogs that benefit from
organization. Default behavior of reporter messages remains
unchanged by this patch.
Fixes: lp:1772090
* https://bugs.launchpad.net/kicad/+bug/1772090
2018-05-22 13:55:02 -07:00
c4b447f3f9
Initialize field visibility checkboxes in Fields Editor.
2018-05-22 19:24:37 +01:00
e3c4a96f5c
Default field bug fixes.
...
1) Commit in-progress edits before closing preferences.
2) Handle default fields in Symbol Fields Editor.
3) Save state of checkboxes in Symbol Fields Editor.
2018-05-22 12:55:39 +01:00
d62b4f36a6
Save hotkeys to combined app-based file
...
Unifies the different sections of hotkeys so that we are not storing two
[eeschema] or [pcbnew] sections in two different files.
Previous hotkey definitions are loaded at start if they exist but are
overwritten by the new format, if it exists. Changes to hotkeys save
only in the combined format.
Hotkey editor for each application only shows the hotkeys relevant to
that application.
Fixes: lp:1741757
* https://bugs.launchpad.net/kicad/+bug/1741757
Fixes: lp:1668799
* https://bugs.launchpad.net/kicad/+bug/1668799
2018-05-18 12:57:38 -07:00
df495b1d65
Fix typo in loading of preferences Reference ID Notation menu.
...
Fixes: lp:1771898
* https://bugs.launchpad.net/kicad/+bug/1771898
2018-05-17 23:46:32 +01:00
afc28ef5db
fix a minor compil warning
2018-05-16 18:14:06 +02:00
1a6e8d4713
Fix typo.
2018-05-13 21:48:13 +01:00
c30dd24cc1
Fixup sorting for expanded component groups.
...
Also adds shorthand notation for groups with adjacent components.
2018-05-13 12:21:55 +01:00
54766bac40
fix minor compil warning (signed/unsigned compar)
2018-05-13 08:56:17 +02:00
9311393016
Add expand/collapse to grouped rows in Fields Editor.
...
Fixes: lp:1767746
* https://bugs.launchpad.net/kicad/+bug/1767746
2018-05-12 23:05:04 +01:00
e91e88bfa1
Make sure read-only attr sticks when grid table rebuilt.
2018-05-11 12:33:53 +01:00
6e83f99c72
Relax fully-annotated constraint for BOM editor.
...
Also fixes a bug where unannotated components would get references
of the form R-1 (because their reference number was -1).
Fixes: lp:1768814
* https://bugs.launchpad.net/kicad/+bug/1768814
2018-05-11 12:33:44 +01:00
aa7da5dfcd
Treat ${...} and $(...) envvar references uniformly.
...
Fixes: lp:1769282
* https://bugs.launchpad.net/kicad/+bug/1769282
2018-05-05 23:40:40 +01:00
c23b263e39
Fix display issues in Layers list in Keepout Zone Properties.
2018-05-04 23:55:03 +01:00
8411ef04d0
Size fields list correctly in symbol properties editor
...
This patch prevents fields with long text values from unreasonable
dialog resizing. It is basically commit f4eb63f8
2018-05-03 12:20:40 +02:00
70cd27314b
Autocompletion for Spice model selector
2018-05-03 11:58:13 +02:00
af739f5b00
Check for duplicates when adding libraries.
...
This is particularly important when bulk adding (by director, etc.)
as otherwise the user might end up having to click OK to many
many error dialogs.
Fixes: lp:1764057
* https://bugs.launchpad.net/kicad/+bug/1764057
2018-05-02 21:49:57 +01:00
b636aaddf6
Eeschema: fix incorrect UI messages in dialogs due to using UTF8 strings instead of wxStrings (unicode) to build them.
...
(Added a explicit to build a Unicode string in UI messages to avoid mistakes)
2018-04-30 11:46:23 +02:00
7b734551d3
Make sure pin-caches are up-to-date before testing dangling ends.
...
Fixes: lp:1767745
* https://bugs.launchpad.net/kicad/+bug/1767745
2018-04-29 16:55:24 +01:00
5a051358b7
Removed an obsolete comment
2018-04-28 01:19:42 +02:00
9960416e32
Spice simulator: plot currents in DC sweep simulation
...
Fixes: lp:1767457
* https://bugs.launchpad.net/kicad/+bug/1767457
2018-04-28 01:14:00 +02:00
4d6947b56a
Spice simulator: do not display V(0) in the signals list
2018-04-28 01:14:00 +02:00
539d12b08f
Spice simulator: more elegant approach to generating Spice device names
...
Code fixing Spice device names (prefixing reference with a character
corresponding to the assigned device model type) that was duplicated in
a few places has been moved to a function (NETLIST_EXPORTER_PSPICE::GetSpiceDevice()).
2018-04-28 01:14:00 +02:00
095112a902
Spice simulator: add device prefix only when necessary for DC sweep (missing in bc67d1ad)
2018-04-27 23:09:58 +02:00
5e5e80d392
Don't allow panel to overwrite values set in Spice Model editor.
...
Fixes: lp:1766920
* https://bugs.launchpad.net/kicad/+bug/1766920
2018-04-26 19:13:19 +01:00
6ccc8577ad
Hand-code calculation of field names column width.
...
Fixes: lp:1737361
* https://bugs.launchpad.net/kicad/+bug/1737361
2018-04-26 19:13:19 +01:00
888c434776
Treat Mac as special case rather than GTK.
...
(Windows also needs the padding we use for GTK.)
2018-04-26 15:51:34 +01:00
dcf02f5f67
Use a single calc-column-width-impl for Fields Editor.
...
Also adds calculation of the initial splitter position based on
the widths of the fields in the list.
Fixes: lp:1737361
* https://bugs.launchpad.net/kicad/+bug/1737361
2018-04-26 11:10:58 +01:00
528a67b27c
Fix incorrect sizing of 2 columns in dialog, on GTK (issue perhaps depending on GTK/wxWidget version)
2018-04-25 12:07:43 +02:00
4b3772cf07
Update value field when changing power symbol reference.
...
Fixes: lp:1765932
* https://bugs.launchpad.net/kicad/+bug/1765932
2018-04-25 00:36:08 +01:00
7e29ff0bc4
Conditional compilation for global fields editor listbox.
2018-04-24 23:45:44 +01:00
2694a76785
Standardize colons in symbol library dialog
2018-04-23 12:33:21 -07:00
3e652f2d40
Standardize colons and units in spice model dialog
2018-04-23 12:31:23 -07:00
2baca1d650
Standardize colons and units in spice sim settings dialog
2018-04-23 12:31:17 -07:00
445c0e66fb
Align search field
2018-04-23 11:55:28 -07:00
722886c9c7
Standardize colons in schematic plot dialog
2018-04-23 11:53:18 -07:00
805c38ffc5
Standardize colons in new component dialog
2018-04-23 11:53:18 -07:00
60abff1c02
Standardize colons in library text dialog
2018-04-23 11:53:18 -07:00
424fe8acd4
Standardize colons in libedit pin dialog
2018-04-23 11:53:18 -07:00
2c1f14fce5
Standardize colons in draw item dialog
2018-04-23 11:53:18 -07:00
c55cb8c557
Standardize colons in ERC dialog
2018-04-23 11:53:18 -07:00
f451ffb877
Standardize colons in schematic editor options dialog
2018-04-23 11:53:18 -07:00
83319f74c3
Standardize colons in line style dialog
2018-04-23 11:53:18 -07:00
2da575d539
Standardize wording and colons in libentry fields dialog
2018-04-23 11:53:18 -07:00
617d9288ab
Standardize colons in edit label dialog
2018-04-23 11:53:18 -07:00
32bb6064d7
Standardize colons in edit schematic component dialog
2018-04-23 11:53:18 -07:00
07281d78ad
Standardize colons in edit component dialog
2018-04-23 11:53:18 -07:00
8c2a7138d1
Standardize colons in BOM dialog
2018-04-23 11:53:18 -07:00
4640a656a2
Standardize colons in annotate dialog
2018-04-23 11:53:18 -07:00
aa71d41a59
Calculate column widths based on actual text & fontsize.
...
Fixes: lp:1737361
* https://bugs.launchpad.net/kicad/+bug/1737361
2018-04-23 18:24:10 +01:00
cfa9916836
Prevent issuing a print command before the previous one is finished
...
Fixes: lp:1765965
* https://bugs.launchpad.net/kicad/+bug/1765965
2018-04-23 11:25:28 +02:00
4202bb6af6
DIALOG_EDIT_COMPONENTS_LIBID: fix the minimal size (previous code to fix this size was not working)
2018-04-21 17:53:54 +02:00
d776eaca83
Fix button sizer padding on symbol field edit dialog.
2018-04-20 19:19:13 -04:00
4302394990
Consistency between dialog titles and menu items.
...
... and between eeschema and pcbnew.
Also moved the Symbol & Footprint library table tabs to the top
so it's more clear what "by Scope" means.
Fixes: lp:1765359
* https://bugs.launchpad.net/kicad/+bug/1765359
Fixes: lp:1765516
* https://bugs.launchpad.net/kicad/+bug/1765516
2018-04-20 15:33:46 +01:00
5506efaee5
Add a SaveAndContinue button to the Fields Editor.
2018-04-19 23:13:19 +01:00
b9239d8728
Add defensive coding for column widths in Fields Editor.
2018-04-19 21:39:25 +01:00
9201417c06
Handle new fields in global field editor.
...
Fixes: lp:1765443
* https://bugs.launchpad.net/kicad/+bug/1765443
2018-04-19 20:33:03 +01:00
442d1169a8
Adjust min sizes of Global Fields editor for Windows.
...
Also gets rid of a slew of unnecessary sizers in the dialog.
2018-04-18 20:37:20 +01:00
7e47ef7471
Fix warnings for unreferenced local variables
2018-04-18 15:08:37 -04:00
db2cda7271
Fix some merge issues.
2018-04-17 20:26:50 +01:00
854cb70052
Fix compil issue with gcc 4.8 on Ubuntu
2018-04-17 19:35:26 +02:00
0294e41cbc
fix minor compil warnings (about signed/unsigned comparison)
2018-04-17 16:08:12 +02:00
000457db7c
Move Fields Editor to wxGrid.
...
Makes in-place editing much easier and fixes some other issues
(see bug reports).
Fixed sorting bugs in References and added better sorting for
Values.
Removed Description column as it wasn't editable and caused more
confusion than value.
Removed auto-column-width after initial render.
Re-implemented undo/redo.
Fixes: lp:1749287
* https://bugs.launchpad.net/kicad/+bug/1749287
Fixes: lp:1737361
* https://bugs.launchpad.net/kicad/+bug/1737361
Fixes: lp:1759756
* https://bugs.launchpad.net/kicad/+bug/1759756
Fixes: lp:1763223
* https://bugs.launchpad.net/kicad/+bug/1763223
Fixes: lp:1761378
* https://bugs.launchpad.net/kicad/+bug/1761378
2018-04-17 11:39:44 +01:00
12ec56bc15
Prevent reentrancy in footprint loading.
...
Also removes parallel implementation in favour of using the
normal one (with a new wxGauge-backed PROGRESS_REPORTER).
Fixes: lp:1764196
* https://bugs.launchpad.net/kicad/+bug/1764196
2018-04-16 23:19:08 +01:00
0e151687e3
Fixed a typo
2018-04-13 14:24:57 +02:00
a41b2d6803
Fix names of added aliases
2018-04-13 14:24:57 +02:00
b907fb856d
Fix names of libraries added to symbol/footprint library tables
2018-04-13 14:24:57 +02:00
3f734eb1b5
Improved validation of library and entry names
...
Symbol/footprint library and entry have the same set of forbidden
characters with a single exception, space character. To accommodate for
this difference, LIB_ID validation and fix methods have been extended to
specify the LIB_ID type that is checked (schematic/board).
LIB_ID::HasIllegalChars() and LIB_ID::FixIllegalChars() had two different
sets of characters treated as invalid in LIB_IDs. The set has been
factored out to another function to avoid duplication.
2018-04-13 14:24:57 +02:00
862fb430e7
eeschema: Fixed setting unit condition in the component properties dialog
2018-04-13 14:24:57 +02:00
a11714b1a4
fix misspelled 'an other' -> 'another'
2018-04-08 13:24:37 -04:00
1f32f7c55b
fix misspelled 'allows to' -> 'allows one to'
2018-04-08 13:24:18 -04:00
591a303777
Make ERC options dialog clearer.
...
Fixes: lp:1667600
* https://bugs.launchpad.net/kicad/+bug/1667600
2018-04-06 14:51:09 +01:00
dd56f16776
Fix symbol editor crash when modifying fields while a field is selected
...
Field Editor dialog calls LIB_EDIT::SetFields() that deletes the old
LIB_FIELD objects and creates new ones. If any of the old LIB_FIELD
objects had been selected before invoking the dialog, then one of the
update UI event handlers will crash trying to access the object.
2018-04-02 17:51:11 +02:00
ba49bd0386
Allow XLS netlist exporters to specify a file extension.
...
Fixes: lp:1591779
* https://bugs.launchpad.net/kicad/+bug/1591779
2018-03-26 00:51:54 +01:00
f4ce8766e3
Implement shared FOOTPRINT_LIST.
...
While we already cache the loaded footprint files, parsing said files
into the list is also time-intensive. Since the FOOTPRINT_LIST is
already hash-stamped against the current timestamps of the files that
make up the list, sharing a single copy of the list is quite
straight-forward.
2018-03-25 19:21:28 +01:00
bfe9eff878
Don't use wxTE_RICH in label editing dialog
...
Fixes: lp:1742296
* https://bugs.launchpad.net/kicad/+bug/1742296
2018-03-24 22:31:34 -04:00
d2d0660647
Open viewer even when FPID is invalid.
...
Just show an empty viewer.
2018-03-23 12:46:17 +00:00
a0364a1137
Don't make user click twice to toggle checkbox in wxGrid.
2018-03-23 12:46:17 +00:00
97f8a3361e
Renamed ERC rule: "Test unique global labels" to "Test single instances of global labels"
2018-03-22 18:20:02 +01:00
e1c8822b9e
Component Properties dialog: catch IO_ERRORs when showing footprint viewer
2018-03-22 11:44:13 +01:00
79fe134495
Init Footprint Viewer with current FPID.
...
Fixes: lp:1757421
* https://bugs.launchpad.net/kicad/+bug/1757421
2018-03-21 23:11:55 +00:00
1a845bc4ad
Safer way to commit in-progress changes in wxGrid.
...
In some cases the wxGrid would attempt to close the editor in
the middle of the d'tor, resulting in segfaults.
2018-03-19 12:13:28 +00:00
df924a5e68
Follow standard FBP naming conventions.
2018-03-18 22:17:27 +00:00
0a81782b5d
Add ERC check that a pin appears in only one net
...
Fixes: lp:1680638
* https://bugs.launchpad.net/kicad/+bug/1680638
2018-03-15 11:11:43 -04:00
935a5cada8
Fix typo in conditional check
...
Fixes: lp:1755265
* https://bugs.launchpad.net/kicad/+bug/1755265
2018-03-12 22:15:27 -04:00
f32f14dc8f
Add WX_TEXT_ENTRY_DIALOG which inherits from DIALOG_SHIM.
...
Fixes: lp:1754977
* https://bugs.launchpad.net/kicad/+bug/1754977
2018-03-12 22:45:51 +00:00
Seth Hillbrand
Jeff Young
Ben Gamari
Damien Espitallier
Wayne Stambaugh
Maciej Suminski
Marco Ciampa
jean-pierre charras
Simon Richter
Carsten Schoenert
Jon Evans