d295014a8c
DIALOG_ERC: fix crash when set to ignore a an ERC violation.
...
If a ERC violation is set to ignore, all corresponding markers are deleted.
But if one of these markers is selected, a crash happens.
Now all selected objects are deselected before deleting markers.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17375
2024-03-11 14:30:08 +01:00
1b5e18d95f
schematic: legacy kicad schematic files don't have a default description field
...
Without this, we would parse a legacy schematic symbol field at the same
index as the new description field's index into description, instead of into
a user field.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/17202
2024-03-06 11:03:00 -05:00
31ae825b9d
Prevent use-after-free of symbol screens
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17204
(cherry picked from commit 1600d8bead
2024-03-06 03:54:14 +00:00
98d26e77c9
Update a few more list/tree views for macOS
...
(cherry picked from commit 1988aac2b3
2024-03-05 13:39:39 +00:00
742529da26
Update net navigator when cross probing from board editor net highlight.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16838
(cherry picked from commit 66925ec2a2
2024-03-03 08:57:54 -05:00
1664e02fa6
Don't draw the selection if it's not from the current screen.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17132
2024-03-02 18:56:57 +00:00
f7ddd211d9
kicad_cli: Allow upgrade of legacy and non-kicad symbol libraries
2024-03-02 18:22:18 +01:00
655cee523b
Eeschema: fix crash when editing a old legacy schematic with missing libs,
...
and trying to edit a dummy symbol. (crash due to a null pointer due to missing lib)
From master branch
Fixes #17232
https://gitlab.com/kicad/code/kicad/-/issues/17232
2024-03-02 15:32:37 +01:00
fa4d759fcb
First alt-pin menu item must be fetched from the LIB_PIN.
...
(The SCH_PIN will return any alt function already assigned.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17221
2024-03-02 12:16:33 +00:00
41f9baf9dc
Cleanup.
2024-02-29 17:38:18 +00:00
1cd5827078
_() -> _HKI() for group names.
...
(cherry picked from commit d08e0e9eaa
2024-02-29 17:38:18 +00:00
b07d43a24a
Expose text size for SCH_FIELDs.
...
(cherry picked from commit 2dce618f9f
2024-02-29 17:38:18 +00:00
978fa63490
Allow .kicad_sym in Import Symbol filters.
...
(cherry picked from commit cd27f801f6
2024-02-29 14:36:57 +00:00
0dab086f0c
EasyEDA Std import: support multiline text on PCB.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17171
2024-02-29 03:54:01 +03:00
9508b79cc3
Fix sheet pin align to grid issue.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16920
(cherry picked from commit 141d03c266
2024-02-28 12:00:01 -05:00
bec068324e
Keep schematic text upright (especially when opening v6 schematic).
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17082
2024-02-28 18:25:08 +03:00
fce4ec6a9b
Eeschema, DIALOG_CHANGE_SYMBOLS: fix incorrect initial lib link name when
...
changing symbols: the "old" displayed link was in fact the new link because
the link was updated before the report is created.
Fixes #17162
https://gitlab.com/kicad/code/kicad/-/issues/17162
2024-02-28 11:23:35 +01:00
a9e6031ae6
Remove unnecessary assert
...
GetModifyHash can be called before a row is loaded
(cherry picked from commit 31fab831ad
2024-02-28 00:03:37 +00:00
1fc79b9a46
Fix typo.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16991
(cherry picked from commit a5fda819eb
2024-02-27 17:16:53 +00:00
d94b0771ca
Only change pin assignments from user interaction.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16349
2024-02-26 19:01:07 +00:00
2f8f7c11f1
Handle single-source DC analyses correctly.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17119
2024-02-26 18:10:10 +00:00
c1755835eb
Symbol editor: add option (view menu+toolbar) to show/hide invisible pins and fields
...
From master branch
Fixes #8020
https://gitlab.com/kicad/code/kicad/-/issues/8020
2024-02-25 17:40:40 +01:00
46555ab975
Fix use-after-free in Altium importer
...
If the library already contains a symbol with the same name,
SaveSymbol will replace the existing symbol,
which will invalidate a cached pointer.
(cherry picked from commit d939004bbd
2024-02-25 13:47:30 +00:00
74339e9a9f
Support pin count and footprint filters in symbol editor.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17105
2024-02-25 13:13:54 +00:00
2b09653abb
Don't import invalid polygons.
...
If we *do* get a 2-point polygon in SVG, import it as a segment.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17091
(cherry picked from commit dba2fdb6d3
2024-02-25 12:29:02 +00:00
87944e06ac
Fix missing unit initialization.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17076
2024-02-24 22:35:05 +00:00
97ff48b426
Add bottom panel to have correct background in fp/sym chooser frames.
...
See https://gitlab.com/kicad/code/kicad/-/issues/15810
2024-02-24 15:17:28 +00:00
badc4e7411
Hide unused message panel in footprint/symbol chooser frames.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15810
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15889
2024-02-24 15:17:28 +00:00
14d71c8ca6
Fix collecting of signals for S-Parameters analysis
...
(cherry picked from commit 006f93773c
2024-02-23 20:35:36 +00:00
7d5583f687
Performance UpdateDanglingState
...
Avoid O(N^2) by spatial sorting, don't run checks if the bounding boxes
don't overlap.
A second copy is ordered by type to help classes that only want to check
a few types having to walk the whole list.
(cherry picked from commit b7b64d959f
2024-02-23 14:36:50 -05:00
ffd470d94d
Performance SCH_EDIT_FRAME::SchematicCleanUp
...
Avoid O(N^2) comparisonis by spatial presorting. If bounding boxes don't
overlap there's no need to run expensive checks.
(cherry picked from commit f3c2083018
2024-02-23 14:36:36 -05:00
e68df8e1d1
Performance optimizations for database libraries.
2024-02-23 17:22:20 +00:00
3e26e7b646
Normalize SCH_PIN BBox to fix assert.
2024-02-23 17:22:20 +00:00
a13e4e7d9f
Eeschema: select graphical shapes based on effective shapes.
2024-02-23 17:22:20 +00:00
c8495d81bb
Update VDMOS models to ngspice-41 (and later) defaults.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17073
2024-02-23 16:06:55 +00:00
3f47e03317
Thread safety: replace ++m_modHash by IncrementModifyHash()
...
(cherry picked from commit d464d7995b
2024-02-23 16:49:35 +01:00
9004f92689
Add cache to SCH_IO_DATABASE to improve loading performance
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17031
(cherry picked from commit 991ddfe6be
2024-02-23 16:49:35 +01:00
a928299ae0
Legacy libraries: De-duplicate field names on load
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16902
(cherry picked from commit 07ab18a1e6
2024-02-23 16:49:35 +01:00
1a7237f38b
Altium: Don't create duplicate fields
...
(cherry picked from commit 420413969e
2024-02-23 16:49:35 +01:00
b3b6637b44
Altium: Don't load library parameters with an owner for now
...
In Altium many objects can have parameters (including pins). For now
we will drop library parameters belonging to any sub-components of a
symbol.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17048
(cherry picked from commit 1a6e6a06eb
2024-02-23 16:49:35 +01:00
adae4de438
Don't use EQUALITY flag when doing a symbol diff with library.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16944
2024-02-22 23:37:50 +00:00
51848a0b43
Code cleanup and compiler warnings.
2024-02-22 23:37:45 +00:00
2d7f4faf72
Set up default netclass wire & bus widths.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17024
2024-02-22 23:37:42 +00:00
c75bb5d01a
Formatting.
2024-02-22 23:37:39 +00:00
df8f043c16
Improve layout of schematic colors preview.
...
Also, set pin name/number sizes. Don't use defaults (which
will get plucked out of the Symbol Editor's settings).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17043
2024-02-22 23:37:30 +00:00
b6036f368e
When updating RefDes only update the prefix.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16991
2024-02-22 23:37:18 +00:00
25291d6e3a
Check known m_Desc field before m_Fields.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16971
2024-02-22 23:37:15 +00:00
f4a085575a
Show friendly name in toolbar button tooltips.
...
(Don't require the same text to be put into the tooltip.
It's error-prone and also disallows us from having a separate
tooltip for toolbar buttons.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17009
2024-02-22 23:37:13 +00:00
a34b242f4e
Delete empty Netclass fields only if there are others.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16997
2024-02-22 23:37:08 +00:00
a610542a19
Various string issues held over from 8.0 string freeze.
2024-02-22 23:36:37 +00:00
2ab492474e
Improve alignment tooltips.
2024-02-22 23:36:34 +00:00
3caede3799
Ignore duplicate/repeat when drawing an existing item.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16885
2024-02-22 23:36:30 +00:00
9d40374baf
Don't capture references to local variables for CallAfter.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16934
2024-02-22 23:36:27 +00:00
27911d9b5a
Fix crash when changing sheet file name that contains a highlighted net.
...
Performing a full connectivity rebuild after changing a sheet file name
ensures that there are no stale connectivity object pointers laying around.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17011
2024-02-17 08:50:22 -05:00
206a631135
Ensure stream is valid before checking for Eagle XML tag
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16989
Fixes KICAD-7QQ
2024-02-16 11:14:10 +00:00
f894a41dc2
LIB_SYMBOL::IsMulti() seems to be wrong, use the iterate conditional as the multi-unit check instead
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16932
2024-02-16 00:18:05 -05:00
9e08e6e4f1
USe setactive in cli in the LoadSchematic helper too
2024-02-16 00:08:10 -05:00
7b0bb59b37
Remove hard-coded versioned env vars in most places
2024-02-15 15:31:08 +00:00
0775d1364a
Add bezier icon
...
Fixes https://gitlab.com/kicad/code/kicad/issues/16830
2024-02-14 02:01:01 +01:00
f73d45b0cf
Add $schema prop to drc/erc
2024-02-13 19:08:55 -05:00
c92728715d
Schematic: import schematic sheet content, allow move and undo
...
Otherwise, the schematic is just plopped on the screen, causing
connections and junctions to be missing that should be present.
2024-02-13 12:18:46 -05:00
12c8f5b14d
Update compatibility mode and save flags in ngspice.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16955
2024-02-13 14:50:15 +00:00
2afe4db945
Add some missing newlines in cli output without changing strings
2024-02-11 21:12:21 -05:00
6a37f99e94
Fix crash if we exit lib table setup
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16917
2024-02-11 21:05:23 -05:00
d694bb5960
Use file name rather than path for erc/drc json and text reports
2024-02-11 20:16:22 -05:00
b5982f7319
EasyEDA import: force close some line chains.
2024-02-11 23:52:56 +03:00
bf9d085c15
EasyEDA schematic import: fix nan center for elliptic arcs.
2024-02-11 23:52:56 +03:00
22669bcc4d
Unselect saved image when reverting a commit if modified item is unselected
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16938
2024-02-11 11:55:02 -05:00
ec2cd99405
Guard actions that change project against running in non-standalone mode
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16942
2024-02-11 09:36:17 -05:00
ef0204a44b
Remove debug output
2024-02-11 09:04:10 -05:00
4eba781013
Try harder to remove stale pins from connectivity
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16846
2024-02-10 23:26:37 -05:00
24cf0c0c62
use new align-to-grid icon
2024-02-11 01:30:47 +00:00
e302261067
More issue #16846 invalid pointer checks.
...
This has now pushed the issue down to a broken RTree issue. Skipping the
asserts in debug builds will still crash but now it's pushed down to the
RTree.
2024-02-10 15:41:10 -05:00
b409aee28a
Force schematic symbol pin update when reverting a commit.
...
Apparently somewhere in our schematic code base we are allowing pins
to be added to symbols without correct setting the parent symbol object.
This causes all kinds of issues when the pin's parent object need to be
accessed.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16846
2024-02-10 08:49:41 -05:00
ae9175927b
Fix broken schematic pin selection caused by commit 1ac5666164.
2024-02-10 08:26:52 -05:00
ff17a22e31
Internationalize Image Properties dialogs.
2024-02-10 08:34:19 +03:00
d3ca82b0b5
Fix another build error
2024-02-09 20:18:13 -05:00
cd548e392a
Add document type icons
...
Update Macos script to use doctype icons for icns builds
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14754
2024-02-09 15:55:57 -08:00
f303996f9c
Add new icons for tools
...
Align elements to grid
Cleanup graphics
Cleanup tracks/vias
Drag
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16206
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16205
2024-02-09 15:55:57 -08:00
04ccf7e885
Explicitly create wxStrings for assignment to make MSVC builds happy.
2024-02-09 17:37:36 -05:00
9e9ee96181
Explicitly create wxString for return value.
2024-02-09 17:11:49 -05:00
dc48af3e5c
EDA_ITEM::SwapData() must not swap the parent pointer.
...
The image's parent pointer might have gone out of scope.
2024-02-09 20:10:12 +00:00
302038fbfd
Do not assume schematic child objects have a valid parent.
2024-02-09 13:16:07 -05:00
1ac5666164
Do not de-reference null library pin object pointers in SCH_PIN object.
2024-02-09 11:07:04 -05:00
3d690da305
Fix schematic editor crash when dragging symbols.
...
Do not set view items or update connectivity until after commit changes
are updated in the SCH_SREEN. Updating the screen can force LIB_SYMBOL
changes which and lead to stale LIB_PIN object pointers stored in SCH_PIN
objects.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16846
2024-02-09 10:38:29 -05:00
aef6b2a66e
nullptr safety and a bit of wxT'ing.
2024-02-09 13:56:01 +00:00
334b414826
Make sure SCH_PIN->LIB_PIN pointers get cleared
2024-02-09 08:09:19 -05:00
3c45145401
Set move flags at beginning of move.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16891
2024-02-09 10:19:39 +00:00
ca6b40ef1c
Make sure to create power axis when restoring state
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16912
2024-02-08 17:48:12 -05:00
f8b8bc78bd
Make m_originalColWidths impervious to init-order issues.
2024-02-08 15:09:07 +00:00
b4c361f5cc
Order matters in PEGTL grammar.
...
(Because a flagParam will also match "param", but not the
other way around.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16900
2024-02-08 14:54:54 +00:00
1a91bb369c
SCH<->PCB: fix pin cross probing
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/16910
2024-02-08 09:02:03 -05:00
8efd90e6e8
Allow reading of 0 text sizes.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16902
2024-02-07 16:46:42 +00:00
bce372c8a3
Don't clear the undo/redo list when we're just trimming it.
...
We only allow a certain number of commands on the lists
and trim them when they overflow. PCB_BASE_EDIT_FRAME and
PL_EDITOR_FRAME implemented this correctly; SCH_EDIT_FRAME
and SYMBOL_EDIT_FRAME did not.
2024-02-07 14:52:10 +00:00
e55a803572
Altium schematic import: do not overwrite sheet name.
2024-02-07 05:06:49 +03:00
a32d5174a1
Altium schematic import: clear harness port list after parsing Additional.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16894
2024-02-07 05:06:49 +03:00
65c0a0a629
ConvertImageToPolygons: fix images with no alpha.
...
Fixes KICAD-714
2024-02-06 21:38:00 +03:00
08b02f2a1a
Add junction color property
2024-02-05 19:12:09 -05:00
899ed59f7b
Add missing pin numbers/names properties
2024-02-05 19:08:56 -05:00
0778a7d46d
Fix Windows build.
2024-02-06 00:38:21 +03:00
jean-pierre charras
Mike Williams
Jon Evans
Wayne Stambaugh
Jeff Young
Roberto Fernandez Bautista
Alex Shvartzkop
Andrej Krpic
Yon Uriarte
Ian McInerney
Marek Roszko
Seth Hillbrand
Graham Keeth