Commit Graph

23342 Commits

Author SHA1 Message Date
Marek Roszko 4d6e4bd622 Remove common.h from env_vars.cpp 2020-10-23 21:49:41 -04:00
Jon Evans 50cff57b9a Explicit bools for MS
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6146
2020-10-23 21:35:23 -04:00
Jeff Young 59f3fefd17 When polygonizing arcs don't use synthesized center and angle.
Start, mid and end are the "real" properties and come with less
error.

Also collapses two arc polygonization routines into one.

Also fixes DRC checks to be cognizant of arc approximation error.

Fixes https://gitlab.com/kicad/code/kicad/issues/6039
2020-10-23 23:55:45 +01:00
Jeff Young b683871d93 Commit file missing from earlier commit. 2020-10-23 23:55:45 +01:00
Jeff Young 1cb7fbaab1 Fix errors in arc polygonization and test case.
1) Tests can't expect accuracies around 1 to work.  PCBNew defaults
to 5000.
2) Tests shouldn't artifically expand tolerance just to match the
results.
3) Tests should guarantee that end point is on arc, not just close
to it.
4) Standard polygonization of a circle is inside so splitting the
error needs to increase radius, not decrease.
5) Special-case first and last points so that they're exact.
2020-10-23 23:55:45 +01:00
Jeff Young c5a86126d2 Be more clever about making sheet names unique.
Fixes https://gitlab.com/kicad/code/kicad/issues/6123
2020-10-23 23:55:45 +01:00
Seth Hillbrand cce11e40a1 Remove errant printf 2020-10-23 12:36:53 -07:00
Seth Hillbrand 19bf594aa0 Remove unused point in polygon test
There can be only one.
2020-10-23 12:13:09 -07:00
jean-pierre charras fdf6547f5f Pcbnew: Select/Expand connection (U) does not propagate with fillet tracks
Fixes #6136
https://gitlab.com/kicad/code/kicad/issues/6136
2020-10-23 18:51:05 +02:00
Jeff Young 01ce881340 Honour NOT_IN_SCHEMATIC setting.
Fixes https://gitlab.com/kicad/code/kicad/issues/6137
2020-10-23 17:27:18 +01:00
Marco Ciampa 713515907a Fixed single language translation update 2020-10-23 16:02:48 +00:00
jean-pierre charras db66e16f71 SymbolEditor: Ask to save local edits in schematic on symbol editor window closure
Previously, Asking for save, cancel... was made for a symbol coming from lib
but not when the symbol come from the schematic editor.

Fixes #6132
https://gitlab.com/kicad/code/kicad/issues/6132
2020-10-23 17:56:15 +02:00
Thomas Pointhuber b7c2d64333 altium: Correctly parse multiunit symbols
Followup to https://gitlab.com/kicad/code/kicad/-/issues/6055
2020-10-23 17:20:07 +02:00
Thomas Pointhuber adfc74f93a altium: Add initial support for multiunit symbols
Fix: https://gitlab.com/kicad/code/kicad/-/issues/6055
2020-10-23 17:04:59 +02:00
Thomas Pointhuber 0d3d3e0d7c altium: parse symbol description, remove dependency on legacy plugin 2020-10-23 17:04:59 +02:00
Jeff Young 1cdb8b5584 Make sure local zone clearances are factored into worstClearance.
Fixes https://gitlab.com/kicad/code/kicad/issues/6128
2020-10-23 14:27:36 +01:00
Jeff Young 58c006bc45 Register properties for ARC elements so we can get their netclass.
Also improves GAL arc drawing and polygonization.

Fixes https://gitlab.com/kicad/code/kicad/issues/6039
2020-10-23 14:27:36 +01:00
Thomas Pointhuber 47786fa976 altium: Correctly handle symbol names containing invalid chars
Fix: https://gitlab.com/kicad/code/kicad/-/issues/6082
2020-10-23 14:30:29 +02:00
jean-pierre charras 51be98428d fix a few issues in ConvertOutlineToPolygon().
Fixes #6130
https://gitlab.com/kicad/code/kicad/issues/6130
Fixes #6129
https://gitlab.com/kicad/code/kicad/issues/6129
2020-10-23 11:23:45 +02:00
jean-pierre charras 15369915cc Minor code cleanup: move "extern" declarations to convert_drawsegment_list_to_polygon.h 2020-10-23 08:48:52 +02:00
Wayne Stambaugh d8ffea881e Improve dialog static sizer box consistency.
Remove colons from the end of static sizer box labels from a few dialogs so
they are consistent with all dialogs.
2020-10-22 22:00:04 -04:00
Jon Evans 922304f980 Guard against missing theme in DIALOG_PLOT_SCHEMATIC
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6124
2020-10-22 21:21:27 -04:00
Jon Evans 7fcef7268b Handle read-only settings files better
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5688
2020-10-22 20:31:04 -04:00
Tomasz Wlostowski 30830d9127 qa/kimath: trivial test case for POLY_GRID_PARTITION 2020-10-23 01:18:07 +02:00
Tomasz Wlostowski 5b4f463c38 kimath: SHAPE_POLY_SET::Format() outputs C++-like code now, like other shapes 2020-10-23 01:18:01 +02:00
Tomasz Wlostowski a8074ed37d kimath: POLY_GRID_PARTITION now uses safer degeneracy (overlapping edges/'slits') handling mechanism. Also added some explanation of the algorithm used. 2020-10-23 01:17:54 +02:00
Jeff Young 82ede1d767 Fix a couple more instances of "auxilary origin".
Fixes https://gitlab.com/kicad/code/kicad/issues/5394
2020-10-22 22:31:07 +01:00
Jeff Young d75f97161f Focus on center of board for board-related DRC markers.
Fixes https://gitlab.com/kicad/code/kicad/issues/6119
2020-10-22 21:50:46 +01:00
Jeff Young 27e156917e Fix tooltip. 2020-10-22 21:47:23 +01:00
Jeff Young cce557b9ad Redo the board-edge-building logic to return better error reports.
Fixes https://gitlab.com/kicad/code/kicad/issues/6119
2020-10-22 21:29:04 +01:00
Jeff Young 41fd8293e8 Don't apply clearance to keepout zones.
Also improves the clearance and keepout reporting.

Fixes https://gitlab.com/kicad/code/kicad/issues/6118
2020-10-22 21:29:04 +01:00
Thomas Pointhuber 412bc2ba8a altium: detect polygons with less than 2 unique points 2020-10-22 17:23:12 +02:00
Wayne Stambaugh 8185a416b9 Fix broken build on Linux with gcc. 2020-10-22 08:36:28 -04:00
Wayne Stambaugh ed03ca7ad0 Symbol editor: improve save all behavior for read only libraries.
Instead of forcing the user to save modified read only libraries to a
different file name, an info bar is displayed warning the user that read
only libraries need to be saved as a different library.  All modified
non-read only libraries are saved as normal.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/4668
2020-10-22 07:49:00 -04:00
Thomas Pointhuber 06e9a21791 altium: fix coding style, remove useless check 2020-10-22 13:44:55 +02:00
Thomas Pointhuber a6f6d44026 altium: correctly handle arcs in polygon and zone outlines 2020-10-22 13:37:29 +02:00
Jeff Young 883c9e14f3 Don't draw 0-clearance clearance lines.
Fixes https://gitlab.com/kicad/code/kicad/issues/6108
2020-10-22 11:56:47 +01:00
Jeff Young af184e58b5 Make sure newly-added footprint's pads get Default net.
Fixes https://gitlab.com/kicad/code/kicad/issues/6108
2020-10-22 11:49:15 +01:00
Jeff Young d785dae88b DIALOG_EDIT_COMPONENT_IN_LIB -> DIALOG_LIB_SYMBOL_PROPERTIES. 2020-10-22 10:41:21 +01:00
Jeff Young 9ff49277e1 Add implicit rule generation for keepout areas.
Also implements collision detection for SHAPE_POLY_SET.

Fixes https://gitlab.com/kicad/code/kicad/issues/6105
2020-10-22 10:41:21 +01:00
Jon Evans 7d09681f9e Improve reporting on NC and global label ERCs 2020-10-21 22:14:04 -04:00
Jon Evans 601a63b63a Better prioritization for non-driven pin ERC
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1881
2020-10-21 21:47:00 -04:00
Jon Evans af28634df1 Bring Pin Not Driven ERC to the new system
Also reword the error title to be a bit more clear

Fixes https://gitlab.com/kicad/code/kicad/-/issues/5681
2020-10-21 21:35:09 -04:00
Jon Evans 2153a7655b Try harder not to give a read-only path to save dialog
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5937
2020-10-21 20:55:43 -04:00
Jon Evans 35c7ba0a8a Fix hover/highlight of line edit points
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6104
2020-10-21 20:37:15 -04:00
Simon Richter 3f48aca721 Add missing <algorithm> 2020-10-21 22:51:22 +00:00
Seth Hillbrand 75c2d1a0bf Be diligent in our search for color information
Just because we find a label reference does not mean that is where the
color is stored.  We do an exhaustive search through the hierarchy for
the correct color data

Fixes https://gitlab.com/kicad/code/kicad/issues/6107
2020-10-21 15:40:19 -07:00
Seth Hillbrand b39fb3374d Fix fat fingered error 2020-10-21 14:41:14 -07:00
Seth Hillbrand ae1004776f Correct Cairo GAL dot rendering
This matches the OpenGL dot rendering.  Patch from dsa-t with minor
changes

Fixes https://gitlab.com/kicad/code/kicad/issues/5832
2020-10-21 12:31:21 -07:00
Seth Hillbrand 69d47c90ea Unify sentences in translation 2020-10-21 12:31:21 -07:00