67bdf61682
Fix extra include.
2019-04-13 20:20:02 +01:00
94a948fdd1
Move grid selection for both Eeschema and Pcbnew to COMMON_TOOLS.
2019-04-13 18:43:35 +01:00
fc7f5630c7
Move eeschema zoom operations to modern toolset.
2019-04-13 18:43:26 +01:00
734e61d4c2
Properly initialize sheets when loading them from ERC dialog
...
When displaying a sheet from this path, it's possible the sheet will
not have been initialized yet. Call DisplayCurrentSheet() to make sure
it is initialized, and then call RedrawScreen to update the zoom level.
Fixes: lp:1824362
* https://bugs.launchpad.net/kicad/+bug/1824362
(cherry picked from commit 1c235a5c89
2019-04-13 12:30:24 -04:00
68c2f06074
Eeschema: fix crash when exporting a netlist, if the schematic netlist cannot be built.
...
It happens when a symbol is not annotated, and if the user closes the opened annotate dialog without making the annotation
2019-04-13 17:54:33 +02:00
dec5d80180
Veto mouse warping from DRC dialog
...
Fixes: lp:1824630
* https://bugs.launchpad.net/kicad/+bug/1824630
2019-04-13 11:23:57 -04:00
9ea7fe5338
eeschema: Finish moving Advanced Config bus
...
Missed a definition for unfolding bus
Fixes: lp:1824628
* https://bugs.launchpad.net/kicad/+bug/1824628
2019-04-13 07:29:33 -07:00
3e7969ab8d
eeschema: Place bus unfold on the stack
...
When activating a bus unfold, the results should be placed with the new
line generation to allow proper undo ordering.
2019-04-13 07:28:22 -07:00
3bdd69ad6b
eeschema: Fix undo stacking for break wire
...
The break wire command is actually two commands: modify the existing
wire and add a new wire. This means that the command must append to the
previous commit to avoid breaking the undo stack
Fixes: lp:1824251
* https://bugs.launchpad.net/kicad/+bug/1824251
2019-04-13 07:11:24 -07:00
822cd9c6ef
eeschema: Remove UR_WIRE_IMAGE
...
The wire image undo/redo option required special handling and was only
used in a single location. Replacing with single change handling
reduces the code complexity
2019-04-13 07:11:24 -07:00
94470f7da6
eeschema: Avoid modifying the schematic in undo
...
OnModify() is called when staging the undo/redo modifications. This
requires that it not create changes that themselves need to be placed
in the undo/redo stack
2019-04-13 07:11:24 -07:00
2529346940
Some fixes for I18N. Mainly do not translate debug messages or strings giving only a print format (like "%d").
2019-04-13 10:12:24 +02:00
203019d959
Fix GAL option spin button layout
...
These need to not be wxEXPAND and to be vertically centred
to match the adjacent text controls.
Fixes: lp:1804461
* https://bugs.launchpad.net/kicad/+bug/1804461
2019-04-12 23:35:54 +01:00
dae41b7460
Remove legacy segment-based zones.
...
Give the user the option of cancelling a file open if there are
segment zones; otherwise they're converted to polygon fills.
Fixes: lp:1823087
* https://bugs.launchpad.net/kicad/+bug/1823087
2019-04-12 20:19:23 +01:00
2d7ef9813f
Fix backward logic in REALTIME
2019-04-12 09:38:12 -07:00
d70ae19cb8
eeschema: Move realtime connectivity to adv config
...
This allows realtime connectivity testing by modifying the
kicad_advanced setting rather than recompiling
2019-04-12 08:37:44 -07:00
ab2281d26f
GAL opts: move config reading into GAL_DISPLAY_OPTIONS
...
Move repeated GAL config reading routines into GAL_DISPLAY_OPTIONS.
THe app-level config is in here already, do the same for the
common config.
This means that the configs are loaded consistently, which fixes
the symbol-chooser preview window, which previously didn't use the
same config routine as other GAL canvases.
Future work could move these functions to free functions that
act on the public interface of GAL_DISPLAY_OPTIONS to avoid
GAL_DISPLAY_OPTIONS having to know about wxConfig and wxWindow.
Fixes: lp:1824524
* https://bugs.launchpad.net/kicad/+bug/1824524
2019-04-12 16:08:11 +01:00
3d9b5daf9c
Improve selection behavior of DRC markers in DRC dialog list
...
Fixes: lp:1813373
* https://bugs.launchpad.net/kicad/+bug/1813373
2019-04-12 11:01:38 -04:00
c1ee395303
Don't propagate secondary connections with the same name
2019-04-12 09:26:07 -04:00
c162ff9076
Curved airwires: set the default to straight lines (i.e. the legacy behavior)
...
Add also missing comments.
2019-04-12 14:17:55 +02:00
6ff1919ae0
Fix subgraph neighbor calculation
...
Subgraphs are not in any particular order so the entire set must be
scanned, not starting at subgraph_it + 1
2019-04-12 00:23:52 -04:00
49d8c29608
Fix a few issues with global buses
2019-04-11 23:38:32 -04:00
69a66fc826
Fix polarity of curved ratlines button
2019-04-11 21:49:45 -04:00
df600fc1a2
Fix a few ERC issues with no-connects and power pins
...
Fixes: lp:1824359
* https://bugs.launchpad.net/kicad/+bug/1824359
2019-04-11 21:24:39 -04:00
0021ecf51e
Don't double-escape netnames.
...
Netnames in wxChoice or wxListBox are already in internal format
and don't need escaping again.
Fixes: lp:1823863
* https://bugs.launchpad.net/kicad/+bug/1823863
2019-04-12 00:28:58 +01:00
76e0622222
Redraw and Position Relative can't share the same hotkey.
2019-04-12 00:28:58 +01:00
8ae0579436
Reorder global edit dialogs for better comprehension.
...
Fixes: lp:1818087
* https://bugs.launchpad.net/kicad/+bug/1818087
2019-04-12 00:28:58 +01:00
e7d32c54b9
pcbnew: Draw Ratsnest with arcs to avoid overlap
...
Adds a toggle button that allows switching between straight lines and
curves for the ratsnest lines.
Fixes: lp:1766597
* https://bugs.launchpad.net/kicad/+bug/1766597
2019-04-12 00:28:58 +01:00
ca7aec2d4e
Fix crash in gerbview when legacy disabled
...
Fixes: lp:1822877
* https://bugs.launchpad.net/kicad/+bug/1822877
2019-04-11 14:25:11 -07:00
4020b5689b
Refocus control after doing our little raise/raise dance.
...
Fixes: lp:1821451
* https://bugs.launchpad.net/kicad/+bug/1821451
2019-04-11 19:45:10 +01:00
3c11b89e4c
Hook up refresh buttons to library tree synchronisation.
...
Fixes: lp:1820057
* https://bugs.launchpad.net/kicad/+bug/1820057
2019-04-11 19:45:10 +01:00
63db3f7c17
Disable escaping special chars in netnames because it creates much more issues than it fixes.
...
Especially the netnames shown on screen are not those living in netlists,
breaking net info in Spice, Gerber X2 and IPC356 for instance
2019-04-11 18:36:21 +02:00
17e88d0944
Pcbnew: FOOTPRINT_PREVIEW_PANEL passes reference to local
...
Previously, the GAL_DISPLAY_OPTIONS object in FOOTPRINT_PREVIEW_PANEL::New
was passed by reference in the ctor, down to EDA_DRAW_PANEL_GAL, which stored
it as a reference. The object in New() then goes out of scope, so the
referencing panel outlives the options.
Fix this by making a copy in a std::unique_ptr of the options, and giving
ownership to the panel.
There is another issue here: when the Pcbnew options are copies, the
OBSERVABLE subscriber list is copied too. This means if the panel called
NotifyChanged() on the options, Pcbnew would get updates, even though a copy
of the options changed. However, the panel doesn't change the options or
notify, so it's OK for now.
2019-04-11 17:01:23 +01:00
0fae86b1ba
Pcbnew: suppress incorrect wx alert when opening the plot dialog from File/Plot menu
2019-04-11 17:36:51 +02:00
232b1c799f
Add a workaround for bus unfolding without real-time connectivity
...
Fixes: lp:1822728
* https://bugs.launchpad.net/kicad/+bug/1822728
2019-04-11 00:17:22 -04:00
3b46253056
Add profiling to SchematicCleanUp portion of connectivity calculations
2019-04-10 23:29:17 -04:00
8c9244e677
Revert "eeschema: Connectivity threading"
...
This reverts commit 1a031e771f
2019-04-10 20:08:42 -07:00
e28c937a5c
Limit number of subgraph checks
...
Candidate subgraphs only need to be checked once, so start the iteration
from the next element in the driver vector
2019-04-10 16:40:24 -07:00
1c93b122f1
SCH_PIN: Guard the calculated map
...
Pins are used in threaded application so we need to keep the
precalculation map guarded
2019-04-10 15:29:00 -07:00
1a031e771f
eeschema: Connectivity threading
...
This threads the first step (update item) in the connectivity routine.
Also eliminates the duplicate call for multiple copies of the same
sheet.
2019-04-10 15:04:22 -07:00
e90452d0e2
When checking for duplicate aliases look in the dialog not the symbol.
...
Fixes: lp:1821543
* https://bugs.launchpad.net/kicad/+bug/1821543
2019-04-10 21:21:00 +01:00
b7c12b238f
Increase GervView layers to 51.
...
This also makes its use of LSET consistent with PCBNew.
Fixes: lp:1809019
* https://bugs.launchpad.net/kicad/+bug/1809019
2019-04-10 21:21:00 +01:00
2144c6c97d
Save a bit of space in the copper zone dialog.
2019-04-10 18:12:14 +01:00
aa53b5508e
Zone filler: fix missing calculation of filled polygons when fill mode is ZFM::SEGMENTS
2019-04-10 17:49:40 +02:00
105520b235
Fix neighbor detection candidate logic
2019-04-10 00:45:41 -04:00
a0981d06a7
Remove std:: aliasing
2019-04-09 21:16:05 -07:00
9ef442b3a3
eeschema connectivity - Adjust performance in init
...
This allow single init for map structures, improving first-run
performance.
2019-04-09 21:00:11 -07:00
2048114512
Reduce chance for wxPoint hash collision
...
Hash collisions reduce the speed of unordered maps by increasing the
comparison time of underlying values. This implements the inverse
golden ration offset into the x value to ensure that consecutive points
are far from each other in the map.
2019-04-09 20:40:04 -07:00
541c2fdb29
Performance: Move vector inside SCH_SHEET_PATH so hash can be cached
2019-04-09 21:09:48 -04:00
86d32fa34d
CONNECTION_GRAPH: Performance mods
...
Reduce loop count and pre-set the needed vectors. Also thread the
dangling ends calculation on a per-sheet basis.
2019-04-09 21:09:48 -04:00
Jeff Young
Jon Evans
jean-pierre charras
Seth Hillbrand
John Beard
MaPePeR
bobo87