b13559c926
Add envVar and text variable resolution to plot directory paths.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/3808
2020-04-05 23:56:24 +01:00
cc9ac37a0e
Add text variable support to envVar processing.
2020-04-05 20:52:26 +01:00
a2102d87c5
Fix typo.
2020-04-05 20:52:26 +01:00
c663965498
Fix some issues with sheet border color handling.
2020-04-05 16:17:04 +01:00
591428b0d9
Remove some problematic global variables.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4121
2020-04-05 16:17:04 +01:00
4a6c03e7fe
Minor string abbreviation and capitalization fix.
2020-04-05 09:39:08 -04:00
c16a453e53
fix minor wxWidgets alerts and a minor Coverity warning
2020-04-05 10:36:55 +02:00
3b39a14fa9
Eeschema, fields_grid_table.cpp: sheet filename selector: use right wildcard syntax.
2020-04-05 09:56:40 +02:00
caf4a64877
Eeschema, DIALOG_SCH_SHEET_PROPS: try to fix a very serious issue:
...
When editing a sheet properties, the dialog always thinks the sheet filename is changed.
It creates serious issues, like duplicating all items in sheet, because the code try to
again import the existing sheet file content.
The temporary fix does not import the existing sheet file content if the
filename is not modified.
This is a very partial fix, because there are many other issues in this dialog
2020-04-04 19:38:53 +02:00
0dac0c9a47
Cleanup some dynamic casts
...
From Coverity scan
2020-04-04 12:41:45 +01:00
b707c84b62
Use Record handling for parsing
...
Now, we know how big a record is, and should be able to parse all boards without missing bytes?
2020-04-03 23:22:24 +00:00
082944ad06
Minor build warning fixes.
2020-04-03 13:03:23 -04:00
a546851d64
eeschema: Check connections on current unit
...
This is an expansion of dac12a6d9
2020-04-03 08:40:59 -07:00
dac12a6d99
Eeschema: SCH_COMPONENT::Visit(): do not select LIB_PIN* pins not related to the
...
current selected unit and convert.
Fixes #4152
https://gitlab.com/kicad/code/kicad/issues/4152
2020-04-03 16:34:37 +02:00
b1b8a32078
fix a few Coverity warnings and compil minor warnings.
2020-04-03 09:54:47 +02:00
f6d7ef367d
Eeschema: fix symbol cache library look up bug.
...
Use an underscore character instead of a semicolon between the library
ID library nickname and symbol name in library ID search strings when
looking up symbols in the cache library since that is how they are saved
when creating the cache library. This fixes rescuing missing symbols
from the cache when they have been removed from the original library and
preventing a broken symbol link indicator from being shown when a symbol
is removed from the library.
Add some defensive testing to make sure the library passed to function
SchGetLibPart() is actually the cache library.
2020-04-02 15:24:28 -04:00
b59da3e4dc
Overridden versions of GetShownText() still need to call EDA_TEXT version.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4151
2020-04-02 18:27:54 +01:00
20c00cbb21
Finish off "busses" -> "buses".
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4144
2020-04-02 18:27:05 +01:00
9ab2fcda77
One more "busses" fix.
2020-04-02 14:58:35 +01:00
ae02835fef
Fix spelling error.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4144
2020-04-02 14:34:52 +01:00
a76ddb52a0
Add sheet borders and backgrounds to Edit Text & Graphics.
...
Also moves sheet border and sheet background colours to preferences
so it's clearer they're just for newly-created items.
Fixes https://gitlab.com/kicad/code/kicad/issues/4144
2020-04-02 14:01:30 +01:00
25fb2595c8
Fix fully broken selection of items of the same sheet, in pcbnew and from eeschema.
...
Previously, the full UUID path used to select footprints was full broken.
2020-04-02 14:21:09 +02:00
e91f1f57dd
Eeschema: fix rescue multiple unit symbol bug.
...
The code that checked for pin conflicts to determine if a symbol needed
rescued did not check either the pin convert setting so it was possible
for a pin from the other convert on symbols that do not have identical
units to appear to not have a pin conflict. Add tests for pin unit and
convert setting to prevent that from breaking the comparison. This must
have always been broken.
Fix the symbol preview widget to prevent drawing all symbols on top of
each other (if we need to do this the code will have to be revised) and
also show the convert if valid.
Fix broken symbol cache library when saving alias symbols.
Fixes https://gitlab.com/kicad/code/kicad/issues/3879
2020-04-01 20:19:53 -04:00
6730313ab7
eeschema: minor fixes in DIALOG_SCH_SHEET_PROPS:
...
- test for empty fileName
- ensure the new filename has the right extension.
2020-04-01 18:30:48 +02:00
9a67dc56f9
Clean up assumption that field_id < MANDATORY means its mandatory.
...
It looks good, but non-mandatory fields have an ID of -1, so it
doesn't actually work. Some places got around this by converting
the ID to unsigned, but this just hides the real issue from
unsuspecting coders.
Fixes https://gitlab.com/kicad/code/kicad/issues/4140
2020-04-01 15:59:52 +01:00
029b1b0b22
Eeschema: void CollectOtherUnits(): do not try to collect others units
...
of a not annotated component.
Fixes #4142
https://gitlab.com/kicad/code/kicad/issues/4142
2020-04-01 16:03:22 +02:00
e811101567
fix a few Coverity warnings.
2020-04-01 09:34:44 +02:00
13d3f57fce
Implement a different solution to refreshing lib trees.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4110
2020-03-31 02:09:31 +01:00
add4c3d4ea
Only append number to name if it already exists.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4130
2020-03-30 17:30:26 +01:00
cbef95256b
Share multi-unit updating code between Sym Props and Edit Field.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4103
2020-03-30 14:15:59 +01:00
7f8f17bd82
Remove empty file.
2020-03-30 14:15:59 +01:00
132d4d3ffa
Clean up compiler warning.
2020-03-30 14:15:59 +01:00
41b5872f12
Add ERC & DRC checks for unresolved variables.
2020-03-30 14:15:59 +01:00
4990d1e7b2
Variable substitution framework.
...
This implements editing of variables and moving SCH_FIELDs,
TEXTE_MODULEs, TEXTE_PCB and worksheet items over to the new
framework.
2020-03-30 14:15:59 +01:00
9c2a260a27
Eeschema: Fix SCH_FIELD::SetPosition() bug
...
Fixes #4129
https://gitlab.com/kicad/code/kicad/issues/4129
Fixes #4062
https://gitlab.com/kicad/code/kicad/issues/4062
2020-03-30 13:26:14 +02:00
6e47f147aa
A few Coverity fixes.
2020-03-30 09:50:26 +02:00
9d2712a824
Fix a few Coverity warnings.
...
It also fix:
Fixes #4082
https://gitlab.com/kicad/code/kicad/issues/4082
2020-03-29 18:42:24 +02:00
5134856f18
Rationalise 3D settings data-structure.
...
Move the camera out to its own so that everything else is board-
related, and then rename BOARD_ADAPTER.
At some point the flags should probably be moved out too, and they
can have the EDA_3D_SETTINGS name.
2020-03-28 16:09:40 +00:00
615deb40f3
Eeschema: move, mirror and rotate block: fix some issues.
...
Fixes #4111
https://gitlab.com/kicad/code/kicad/issues/4111
2020-03-28 13:17:59 +01:00
6e27904791
More code hygiene.
2020-03-25 18:06:18 +00:00
ba36fc0009
Fix some Coverity issues.
2020-03-25 14:38:43 +00:00
d69ebfae49
Push tool framework base down into TOOL_HOLDER.
...
This allows us to use it outside of EDA_BASE_FRAMEs (in this case, in
PANEL_PREVIEW_3D.)
2020-03-24 19:00:25 +00:00
c4aed3a8de
Add user-configurability of the LibEdit axes color.
2020-03-24 19:00:25 +00:00
cf25975876
EEschema: Fix back annotation
...
Repairs back annotation after some schematic code modifications
2020-03-24 10:53:00 +00:00
c7daca1e78
Eeschema: Adding new source types in SPICE model
...
NEW: Adds support in eeschema for three new source types
used in .TRAN simulation: single frequency FM, AM, and random.
2020-03-23 16:49:21 +00:00
cc47062b17
Fix a few Coverity issues
2020-03-23 16:17:22 +01:00
4d9d1a5380
Fix a few compil minor warnings and Coverity minor issues
2020-03-22 09:45:51 +01:00
d25a63cd02
Don't allow selection flags to leak in to the libmanager cache.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4021
2020-03-21 23:25:08 +00:00
66382db7dd
Add some defensive code for selection anomalies.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4021
2020-03-21 20:55:50 +00:00
93b7eacfb2
Fixup some Coverity issues.
2020-03-21 16:32:22 +00:00
Jeff Young
Wayne Stambaugh
jean-pierre charras
Ian McInerney
Thomas Pointhuber
Seth Hillbrand
Alexander
Sylwester Kocjan