Seth Hillbrand
4b91c0c8ee
Handle multiple holes in footprints
...
Our basic logic for whether we have a hole or an outline in a footprint
checks if there is copper pads outside of the closed edge. This misses
the case where the footprint is used to align multiple holes but has no
copper. Since we do not support multiple outlines in a board, we can
safely assume that multiple, closed edges in a footprint represent holes
and not outlines
Fixes https://gitlab.com/kicad/code/kicad/issues/14468
2023-04-20 14:56:36 -07:00
Seth Hillbrand
b56db30019
Ensure that even open paths with fills are filled
...
SVG paths that are "open" can still have a fill internally, so avoid
dropping fills for these non-standard polygons
Fixes https://gitlab.com/kicad/code/kicad/issues/14518
2023-04-20 12:31:04 -07:00
Marek Roszko
3dc308464c
Replace the exception handler in another spot
2023-04-19 21:21:18 -04:00
Marek Roszko
2f23df8f5f
Move 3 more blocks to the common ex handler
2023-04-19 21:17:31 -04:00
Marek Roszko
26f250faa8
Handle OnKifaceStart exceptions without crashing
2023-04-19 20:38:25 -04:00
Marek Roszko
c5d5450f55
Create a central exception handler we can also use to generate sentry events
2023-04-19 20:38:25 -04:00
Seth Hillbrand
7eb728ca12
Don't consider saving SCH_MARKERs
...
These are ephemeral, view-only elements, so don't include them in our
save map
Fixes https://gitlab.com/kicad/code/kicad/issues/11405
2023-04-19 17:00:50 -07:00
Seth Hillbrand
a154571438
Add ability to update subgraphs based on changeset
...
Previously, almost all connectivity updates were full updates, meaning
that the entire connectivity graph would be rebuilt each time a change
was made to the schematic. This update modifies the update to only
correct the subgraphs that are directly affected by the change.
It uses the existing connection graph to find all affected subgraphs as
well as connections to the changes based on the visible schematic.
These elements are removed from the existing connectivity graph and
marked dirty. They then have a new connectivity graph built only around
their changes. The resulting graph is merged into the original.
Currently, this ability is behind an advanced config flag
`IncrementalConnectivity` while testing.
Fixes https://gitlab.com/kicad/code/kicad/issues/10846
Fixes https://gitlab.com/kicad/code/kicad/issues/1794
2023-04-19 16:14:35 -07:00
jean-pierre charras
d4cf063e40
Fix a few more doxygen errors (no actual code change)
2023-04-19 20:24:42 +02:00
jean-pierre charras
a20f757d8c
undo a change (it was only a test) committed by mistake.
2023-04-19 16:57:35 +02:00
jean-pierre charras
1406341d2d
Fix a few doxygen errors (no actual code change)
2023-04-19 16:20:24 +02:00
Mike Williams
09d7e24b6d
Symbol Fields Editor: drop some settings dynamic_casts
...
Not needed, and confusing.
2023-04-19 09:52:31 -04:00
Jeff Young
cc6fc4790d
Copy RC_ITEM fix to ERC_ITEM (where it's actually needed).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14569
2023-04-19 14:09:33 +01:00
Jeff Young
3521add640
Suppress newlines in RC_ITEM messages.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14569
2023-04-19 14:09:21 +01:00
Marek Roszko
6022979bfe
Undo accidental commit change to kiway.cpp
2023-04-18 23:04:51 -04:00
Marek Roszko
ea077bc34d
Banish ignore.h to core
2023-04-18 22:44:04 -04:00
Seth Hillbrand
82ba67db82
Initialize settings for SINGLE_TOP
2023-04-18 19:27:32 -07:00
Seth Hillbrand
32d17547e5
Fixup settings loading
...
Settings loading needs to account for potential chaining, so each
instance should be created before being Load()ed. Additionally, add the
settings loading to QA
2023-04-18 16:00:31 -07:00
Jeff Young
51b6ec0dce
Don't exit KiCad when simulator window is closed.
2023-04-18 23:55:56 +01:00
Jeff Young
f7a552a2b3
Ensure item is gridded if there was no motion between clicks.
2023-04-18 23:55:56 +01:00
Seth Hillbrand
2cd861dbd5
Remove extraneous symbol editor settings
2023-04-18 13:46:33 -07:00
Seth Hillbrand
892e4536b0
Remove extraneous includes
2023-04-18 13:45:32 -07:00
Seth Hillbrand
e6ab9a88ce
Remove locks from settings
...
Settings should be initialized on start-up. This removes the option of
lazily loading the settings from file and instead requires all settings
needed to be loaded on KiFACE start before requesting data from the
settings object
2023-04-18 13:40:25 -07:00
Jeff Young
c682d11fa0
Trim VRML export layers to board outline.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14557
2023-04-18 17:31:29 +01:00
Jeff Young
2c34a08bf1
Ignore empty field-name-templates.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14552
2023-04-18 17:31:25 +01:00
Jeff Young
f72cc6dd51
Amend overly aggressive assert.
2023-04-18 17:31:22 +01:00
Jeff Young
2533141583
Revert "Update pybind11 to version 2.10.4" for now.
...
This reverts commits 9d077c9ba5
and
b4938f5198
.
They cause a crash-on-startup on Mac ARM machines, failing to get the
locale encoding (nl_langinfo(CODESET) failed).
2023-04-18 17:28:10 +01:00
jean-pierre charras
ba12f00c15
Pcbnew: re-add draw umbilical line for texts in footprints.
...
It was lost after removing FP_TEXT in code.
2023-04-18 09:48:46 +02:00
Ian McInerney
e9a93bc711
Try to get the coverity scan results back under the size limit
...
Apparently our Coverity Scan file we try to upload is too large for the
server to handle, so it isn't working. Try switching to a release build
with debug symbols to see if that reduces the size.
2023-04-18 00:19:19 +01:00
Jeff Young
7e5fedef6a
Markup fixes.
...
1) allow escape sequences inside markup sequences
2) keep overbar when inside nested markup
3) always place overbar at full height, not sub/superscript height
Fixes https://gitlab.com/kicad/code/kicad/issues/14553
Fixes https://gitlab.com/kicad/code/kicad/issues/13449
2023-04-17 17:56:54 +01:00
qu1ck
9b58f50c68
Add usable PCB_GROUP::GetItems() swig wrapper
2023-04-17 15:41:49 +00:00
Nimish Telang
51e55dd750
Convert sprintf to snprintf in most files
2023-04-17 15:39:34 +00:00
jean-pierre charras
d0676118c1
BOARD_NETLIST_UPDATER: better warning message (I hope...) in Report.
...
Fixes #14548
https://gitlab.com/kicad/code/kicad/issues/14548
2023-04-17 14:30:47 +02:00
Lucas Dumont
469fe76994
pcbnew: Fix crash with differential routing
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14537
2023-04-17 14:17:14 +12:00
Marek Roszko
460b08c6ca
Nix a dialog in kicad_cli.cpp that shouldn't ever fire
2023-04-16 20:09:57 -04:00
Jeff Young
02c5a31b99
Fix close button on simulator frame.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14551
2023-04-16 23:45:18 +01:00
Alex
b4938f5198
Patch pybind11 version 2.10.4 for MSVC
...
Based on commits c483c582
and 8f1b2acd
2023-04-16 22:34:22 +00:00
Alex
9d077c9ba5
Update pybind11 to version 2.10.4
2023-04-16 22:34:22 +00:00
Jeff Young
86ca90aa2d
Fixes to allow copy/paste of pin data.
...
1) allow paste even if initial cell isn't writeable
2) allow paste to add rows if there's an addHandler defined
Fixes https://gitlab.com/kicad/code/kicad/issues/14508
2023-04-16 23:04:47 +01:00
Jeff Young
a540c01c61
Double double-add items to the view.
2023-04-16 23:04:47 +01:00
Jeff Young
c6d593a47b
Formatting.
2023-04-16 23:04:47 +01:00
Marek Roszko
d18102fff6
Add a hack to try and capture more crash data
2023-04-16 13:49:21 -04:00
Jeff Young
cc4a8dcc89
Small improvements to lifecycle safety.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14521
Fixes https://gitlab.com/kicad/code/kicad/issues/14315
2023-04-16 18:47:04 +01:00
Jeff Young
6fb8916798
The symbol viewer handles its own message panel.
2023-04-16 18:47:04 +01:00
jean-pierre charras
725c2fd661
footprint wizards: fix for my previous commit 50502c4
2023-04-16 17:16:54 +02:00
jean-pierre charras
50502c450f
footprint wizards: fixes and enhancements
2023-04-16 17:03:32 +02:00
Jeff Young
b76ef8c7e2
Multi-threading safety.
...
(Possible fix for KICAD-74.)
2023-04-16 15:36:21 +01:00
Jeff Young
2793bb1d68
Performance.
2023-04-16 15:36:21 +01:00
Jeff Young
26c14271f2
Formatting and warnings cleanup. (No functional changes.)
2023-04-16 15:36:21 +01:00
jean-pierre charras
7545097d7f
Fix a compil issue on msys2/gcc12.2, due to changes in commit dd1c58dc
2023-04-16 15:28:34 +02:00