20ea299742
Cleanup.
2024-02-28 22:18:26 +00:00
d16b5fb810
Handle single-source DC analyses correctly.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17119
2024-02-26 19:02:00 +00:00
caa83ec9bd
Fix missing unit initialization.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17076
2024-02-24 22:34:41 +00:00
9a02712c4f
Update VDMOS models to ngspice-41 (and later) defaults.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17073
2024-02-24 20:05:51 +00:00
006f93773c
Fix collecting of signals for S-Parameters analysis
2024-02-23 18:34:21 +00:00
cb25c8620e
Performance optimizations for database libraries.
...
(cherry picked from commit e68df8e1d1
2024-02-23 20:29:18 +03:00
12c8f5b14d
Update compatibility mode and save flags in ngspice.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16955
2024-02-13 14:50:15 +00:00
ca6b40ef1c
Make sure to create power axis when restoring state
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16912
2024-02-08 17:48:12 -05:00
b4c361f5cc
Order matters in PEGTL grammar.
...
(Because a flagParam will also match "param", but not the
other way around.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16900
2024-02-08 14:54:54 +00:00
ff3288dab6
Add quotes around paths when KIBIS generates waveforms via ngspice
...
Fixes #16655
2024-02-01 17:20:16 +00:00
a2b204572d
Don't assert when a sim returns no results.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16749
2024-01-25 15:40:12 +00:00
70bca8bc4e
Provide popups for inductor references.
...
Also fixes a long-standing bug deleting the last field of
a symbol in the Symbol Editor.
2024-01-25 15:30:25 +00:00
340d1b7fad
Guard against nullptr access.
2024-01-25 15:30:25 +00:00
a263b6d343
Mutual inductance statements have no model.
2024-01-23 15:14:09 +00:00
1bd8da41a7
Mutual Inductor isn't an inductor.
...
It's a statement about two other inductors.
2024-01-23 15:07:29 +00:00
4b1fc9c129
Update AM and SFFM source parameters to ngspice-43.
...
Note: there's no migration strategy because they didn't
work at all prior to ngspice-43.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16529
2024-01-10 20:27:52 +00:00
e7746d3bc8
Fix spelling mistakes
2024-01-10 16:17:07 +00:00
84d161a4b7
Don't use referential values as defaults.
2024-01-06 22:01:23 +00:00
7c5eaed69e
Un-comment and repair TRRANDOM sources.
...
Also adds new parameters to AM sources for ngspice-43.
Also fixes a bug in the spice parameter parser (which would
puke on any parameter name starting with one of the flag
parameter strings).
Also fixes a bug where the skipped source parameters would
get set to "0" instead of their default values.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16393
2024-01-06 20:34:36 +00:00
bbdefa05eb
Un-comment and repair AM and SFFM sources.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16529
2024-01-06 14:49:05 +00:00
e438fc2569
Remove dead code. (Coverity)
...
Also fixes a (small) memory leak.
2024-01-04 15:57:30 +00:00
cdb99de862
Use HasSymbol() instead of a null logger.
2023-12-28 21:52:26 +00:00
e59612d56c
Add realloc locking calls for ngspice42.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15941
2023-12-28 19:36:18 +00:00
9a890cdba9
Kick the wildcards and file exts into a static class, export it from kicommon
2023-12-27 21:10:01 -05:00
47e07f507e
nullptr safety
...
(Can't actually happen as the 4 base fields are mandatory,
but it'll keep Coverity happy.)
2023-12-18 17:01:55 +00:00
fd91f8933e
Fix a SPICE simulator crash on run of a second OP command.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16341
2023-12-18 09:43:40 -05:00
343828c552
Fix invalid string compare in IBIS parser
...
strcmp returns 0 if strings are the same but compareIbisWord returns
True (1).
Adds an IBIS simulation QA test case to catch this in the future
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16223
(cherry picked from commit ef8b6bf9e1
2023-11-30 09:16:38 -08:00
08e6e0258f
IBIS: add stub for Model Spec; support empty strings in line with keywords.
2023-11-29 00:24:34 +03:00
196e05bc51
Borrow parts of simulator's separator-detection algorithm.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15248
2023-11-20 13:47:24 +00:00
32806a3b8b
Make sure plot tab gets its SpicePlotName updated.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16013
2023-11-04 15:45:08 +00:00
1c746f0134
Correctly parse fft commands with linearize in them.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16011
2023-11-04 15:45:08 +00:00
6b29c346b9
When presented with empty text we don't want to Normalize() the SIM_VALUE.
...
But we *do* need to update NUMERICAL_EVALUATOR::m_originalText by
calling NUMERICAL_EVALUATOR::Process().
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15871
2023-10-27 16:59:28 +01:00
1290cf6241
Fix missing random sim command
...
(cherry picked from commit 3ce4a5bf7f
2023-10-26 09:47:43 -07:00
71fb1afe4c
Add ngspice lib paths for when running from build dir.
2023-10-22 19:58:17 +03:00
68e46ecad5
Don't set modified flag when updating measurement format internally.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15909
2023-10-21 14:26:31 +01:00
eff4e2cc9c
Convert windows file paths to unix notation.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15888
2023-10-21 13:33:22 +01:00
12118b6246
Make sure measurements are updated from grid before saving workbook.
...
Also fixes a typo when loading measurements.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15909
2023-10-20 17:36:17 +01:00
62eaa7e1c7
Signals already have gain/phase broken out; user-defined signals don't.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15903
2023-10-20 14:09:46 +01:00
bee6e6be01
AddMenuLanguageList should live in EDA_BASE_FRAME, its only user
2023-10-16 19:49:52 -04:00
b5eee9dd7e
Coverity warning fixes.
2023-10-16 17:04:14 -04:00
0b06a1376b
Don't turn an empty string into a '0'.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15871
2023-10-13 19:07:45 +01:00
0fe2e06949
Fix ambiguous cast compiler errors on MSVC
2023-10-12 19:07:12 -04:00
e9bdfe7210
Save trace colors during session.
...
My first thought was to move the color out of the TRACE, which is
really a view object. However we can't make signals a first-class
citizen either, because they change depending on what the current
simulation tab is and so (for instance) we can only load in the
workbook signals for the current tab. Hours later I backed it all
out and arrived at this simpler, less "correct" solution.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14231
2023-10-04 17:13:08 +01:00
ed4d66e76b
Remove dead code.
2023-10-04 17:13:08 +01:00
0c055e15b7
Keep user-defined signals separate.
...
They can't be plotted till the end of the sim.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15803
2023-10-03 12:59:49 +01:00
827942c560
Clarity.
2023-10-03 12:59:49 +01:00
2dfdf0682f
Don't ask for empty data.
2023-10-03 12:59:49 +01:00
a475b01a90
Remove ic parameter from voltage-controlled sources.
...
It was never supported by ngspice (or LTspice or pspice).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15787
2023-10-01 12:16:25 +01:00
aab0696bb6
Zoom undo/redo for simulator.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14580
2023-09-26 13:19:41 +01:00
463e7c3b30
Improve performance & responsiveness of sim updates.
...
The x-axis only needs to be fetched once per update. Same for
redrawing the screen. And there's no reason to fetch more y data
than we have x data for (which happens to subsequent traces as
the sim is still running as we're updating).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15673
2023-09-22 21:40:52 +01:00
2f475d99dd
Don't update signals and measurements for each refresh.
...
We only need to do them on the final refresh.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15673
2023-09-20 17:34:34 +01:00
1ff279bf72
Don't auto-adjust time axis while sim is running.
...
Just use start and end time.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15673
2023-09-20 17:34:34 +01:00
8672cdb3bd
Handle power operating points.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15689
2023-09-19 17:37:51 +01:00
ff88ed76f0
Hack to prevent timer event starvation on MSW.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15673
2023-09-19 17:04:05 +01:00
1decd31baf
Vertically center wxGrid cells by default.
2023-09-18 17:15:34 +03:00
e5bce16e31
Don't reset cursor x position during a sim refresh.
...
The sim may not be complete yet. And even if it is, the user
didn't ask us to move their cursor. Just leave it where it is
with an undefined y value.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15672
2023-09-17 19:23:46 +01:00
be4c89011c
Don't confuse "significant digits" with "decimal places".
...
Also raises the default significant digits for cursors to 3.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15669
2023-09-17 12:42:06 +01:00
ede542f911
Collect comment lines into following spice unit.
...
This can't distinguish a header block comment in front of a file
with multiple spice units, and so will include that into the first
unit only.
Also fixes the pin assignments reference textbox to use a
fixed-width font as many .subckt's contain ASCII graphics for
pin definitions (not that it helps any with the test case from
the given bug).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15660
2023-09-15 20:08:45 +01:00
4a59f0de43
Apply DC voltage source exception to current sources.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15626
2023-09-12 13:45:28 +01:00
11de95778b
Unwrap the FROM_UTF8 macro in favor of direct function
...
The extern just gets annoying to try to export the func later. We also yeet TO_UTF8 to string_utils.h for parity.
2023-09-09 00:10:57 -04:00
7a2a2e2df0
Remove error-prone SetReporter() API.
2023-09-06 11:37:50 +01:00
30a6d33177
Better fix for primary param in value field with other params in params field.
...
(Replaces 2c8178829982c6e15e443b5a7868b8c953d5126f.)
2023-08-30 00:53:01 +01:00
2c81788299
HasAutofill should not preclude a primary parameter in the value field
2023-08-28 17:44:45 +01:00
7f14b70ac3
Formatting.
2023-08-26 22:43:00 +01:00
2d630a3c75
Remove useless assert.
2023-08-26 22:43:00 +01:00
85240d590b
Remove relative current measurements.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15429
2023-08-18 13:40:52 +01:00
684344c45c
GUI-created measurements of AC gain signals should be gain, not abs
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15429
2023-08-17 17:42:17 +01:00
981089bbd3
Show correct description and units for AC/SP measurements.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15429
2023-08-17 13:32:46 +01:00
da031792af
Add current signals to AC analyses.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15427
2023-08-16 17:24:59 +01:00
a6bceb8182
Don't set modified when loading workbook.
...
Also keep a shadow variable of the legend position so we can notice
when the mpWindow's OnMouseMove() handler changes it.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15363
2023-08-09 12:09:29 +01:00
1b080ed02f
Get rid of SIM_NOTEBOOK. It's completely unnecessary.
2023-08-09 12:09:29 +01:00
bdecdce1b4
Exclude from Sim: move from field to attribute
2023-08-08 12:36:36 -04:00
a3a701a95e
Move preferences to an action instead of a wx event
2023-08-08 00:51:22 +01:00
ddbefe13cd
Improve default margins.
2023-08-06 20:57:42 +01:00
cfa49b5250
Move units labels from ticks to axis label.
2023-08-04 22:41:50 +00:00
8ac49d0bab
General cleanup, coding standards, removal of dead code, etc.
2023-08-02 16:56:56 +01:00
f897b4bac1
Remove cover routines for std::vector.
...
They just make it harder to see if we're following std::vector's
contract.
2023-08-02 16:56:56 +01:00
502b91ba6f
Capitalize type names.
2023-08-02 16:56:56 +01:00
f332dba095
Try harder to prevent duplicate axis labels.
2023-08-02 16:56:56 +01:00
485b768da7
Fix issue with stripping non-trailing '9's from tick labels.
2023-08-02 16:56:56 +01:00
094a80ce31
Stop adding a new return to a sim command every time we read it.
...
Also stop moving the legend down 40 pixels every time it's read.
2023-08-02 16:56:56 +01:00
fcc770cad6
Fix bugs in .meas cmd syntax for AC small-signal analyses.
2023-08-02 16:56:56 +01:00
e8ae3533d1
Set format on all matching signals.
2023-08-02 16:56:56 +01:00
3a82374719
sim/sim_model: fix an annoying issue when adding new fields: their ID was
...
set in undefined, that create an issue (the canonical name was returned as
"Field-1", breaking the schematic file).
Now, new field IDs are not set to -1, and the saved file uses the field name
(if exist) when saving fields with undefined ID.
2023-08-01 13:37:53 +02:00
530af96da2
Prevent null dereference
2023-07-25 10:53:05 -07:00
e9f6ff4366
Simulator frame: removes * indicator for unsaved workbook after saving it.
...
Fixes #15236
https://gitlab.com/kicad/code/kicad/-/issues/15236
2023-07-24 08:55:34 +02:00
e4b262d6e1
Fixed-y-scale bug fixes.
...
Default dialog to SPICE command.
Any of the three axis locks must lock the plotWindow Y axis (otherwise
locking Y2 but not Y1 doesn't preclude zooming).
2023-07-20 17:41:23 +01:00
06f19aa761
Implement y axis locking for secondary y axes.
...
Still a bit of a work-in-progress.
Also fixes some bugs with formatting of measurements and cursor values.
2023-07-20 17:21:19 +01:00
9c08d4febe
ADDED support for simulation plot margins and GUI for Y axis locking.
2023-07-19 23:40:10 +01:00
65f66755ee
Reduce overhead for unused code.
2023-07-19 23:25:05 +01:00
764913207c
Read legend position from workbook.
2023-07-19 23:25:04 +01:00
3a4f3cb0b8
Minor Coverity and compil warnings fixes.
2023-07-17 16:19:22 +02:00
24e9cf4fd8
Improve self-documentation of sim workbook.
2023-07-14 21:02:51 +01:00
041bd2a54f
JSON bools can be read straight up; no need to compare to "true".
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15197
2023-07-14 20:58:12 +01:00
054252ccbe
Move sim workbook to json.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15197
2023-07-14 17:46:06 +01:00
ff044cd0cf
Mostly a terminology update...
...
... but also makes DIALOG_SIM_COMMAND and SIMULATOR_REPORTER a bit
more simulator-agnostic.
2023-07-14 17:46:06 +01:00
8d2c744349
More error messages for reading workbook files.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15197
2023-07-13 23:54:00 +01:00
964e42a611
ADDED text-based pole-zero analyses.
2023-07-13 16:18:25 +01:00
841b693c91
Add pole-zero command parsing and printing.
2023-07-13 16:04:29 +01:00
2e89c735c0
Fix buffer overrun.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15187
2023-07-13 16:04:29 +01:00
Jeff Young
Andrej Krpic
Alex Shvartzkop
Jon Evans
ecorm
Ian McInerney
Marek Roszko
Wayne Stambaugh
Seth Hillbrand
Mike Williams
Josue Huaroto
jean-pierre charras