507a25f150
Don't call BuildInitialTrace() for entry gateways.
...
We're going to call it to connect the entry and target gateways
anyway, so all we need are gateways at 22.5 degrees to setup entry
at +/- 45 degrees from the current direction.
Fixes https://gitlab.com/kicad/code/kicad/issues/14324
Fixes https://gitlab.com/kicad/code/kicad/issues/12459
2023-04-11 15:34:55 +01:00
11995c1350
Improve readability.
2023-04-11 15:26:39 +01:00
1d19672054
Handle more pad shapes when building diffpair gateways.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/1883
2023-04-09 22:05:17 +00:00
e522e73e0e
Improve readability.
2023-04-08 15:06:49 +01:00
e7555aa45f
PNS Router: arcs are directional, too
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10391
2023-03-08 12:01:29 -05:00
b291d6c810
Fix success conditions in DP placer
...
The placer can sometimes generate segments that are not quite parallel.
Use a different tolerance for ApproxParallel to account for this.
Also set a minimum score for placement judging so that any placement
that doesn't violate DRC can be placed.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9948
2021-12-12 13:05:38 -05:00
8a0f8c329f
PNS: Fix DP gateway generation when pad distance < gap
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9306
2021-11-27 14:03:19 -05:00
cf00319c85
More NULL expunging.
2021-07-20 07:27:18 -04:00
1d9ca181a2
PNS: Use existing seg direction if both DP segs are parallel
2021-04-12 22:34:13 -04:00
2aa5e568e8
Refactoring
2021-04-12 20:40:05 -04:00
73fb85a352
PNS: Calculate diff pair primitive orientation using anchors only
...
The previous method fails if the primitive is an expanding or
contracting pair (diagonals going inward or outward) resulting in
incorrect orientation, which then leads to incorrect candidate
gateways being generated and no solution found.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8185
2021-04-12 20:34:44 -04:00
8be213e36f
Trim includes (and use consistent terminology in error messages).
2021-03-21 20:15:47 +00:00
9c7c05c161
Mostly formatting cleanup but a few type-casting cleanups too.
2020-11-24 22:16:41 +00:00
8c19b4b6ae
pcbnew: Adding arcs to PNS
...
This is allows ARCs in tracks to be synchronized with
the PNS router. Note this does not yet include the UI components
to route curved traces
2020-02-21 16:11:41 -08:00
eb3d32f967
SHAPE_LINE_CHAIN: Unify constructors
...
Keeps the multi element SHAPE_LINE_CHAIN constructors in a single
routine using std::vector and implicit construction.
2019-12-12 13:54:48 +00:00
c4d853c1e8
SHAPE_LINE_CHAIN: Remove element access
...
This is the first step to allowing non-segments in the line chain.
External routines cannot be allowed to change the line chain without
going through the internal routines. To accomplish this, we remove the
Vertex() and Point() access routines and only leave the const versions.
Transformations are given for both points as well as the chain itself.
2019-12-12 13:54:48 +00:00
b5f021ff9f
Cleanup: Replace push_back with emplace_back
...
In cases where we create a new item and immediately push into a
container, the emplace idiom is faster and more efficient.
2019-12-05 13:41:21 -08:00
bdc64ff0b3
router: DP_GATEWAYS::FilterByOrientation() should have exactly opposite filtering condition!
...
Fixes: lp:1797914
* https://bugs.launchpad.net/kicad/+bug/1797914
2018-10-18 14:29:19 +02:00
1a6f039bb5
pcbnew: Fix minor miscalculation in dp length
...
The commonParallellProjection had an odd ordering of parameters that was
not followed by callers. This corrects the ordering to standard for
each.
2018-10-09 05:37:48 -07:00
77eeda4191
pcbnew: fix pad distance calc in gateways
...
The pad distance was fixed to 0, making the gateway priority set
artificially to 1
2018-10-08 09:53:47 -07:00
b3db6572e8
pcbnew: diff pair filter bugfix
...
Added required action on the std::remove_if construct to erase elements
matching the filter
2018-06-29 13:05:44 -07:00
f5f7ba4746
Fix loop variable copy in for-range loop, use const reference instead
2018-01-09 19:18:44 -05:00
9ff66a5274
Fix unnecessary value parameter detected by clang-tidy. - Replace value parameter by const reference parameter or move-assignement in some cases
2018-01-09 18:55:51 -05:00
9932ff32ae
refactoring: wrapped boost::optional in OPT<> class for the purpose of easier transition to C++17 in the future
2017-11-03 23:59:02 +01:00
885a4c1bc5
Avoid an infinite loop in PNS
...
Fixes: lp:1702485
* https://bugs.launchpad.net/kicad/+bug/1702485
2017-07-06 16:44:33 +02:00
1fd503bf58
Move DIRECTION45 to common/geometry
...
This class is useful for generic geometric layout of 45-deg constrained
line chains, not only in the PNS router.
2017-03-22 15:23:09 +01:00
0a55d8e053
Fixed differential pair gap clearance error when gap equaled minimum clearance.
...
Fixes: lp:1533551
* https://bugs.launchpad.net/kicad/+bug/1533551
2017-03-11 20:57:59 +01:00
6c749e0ba8
Remove PNS_ prefix from most types inside namespace PNS
2016-09-06 16:06:06 +02:00
4cf44d9725
Rename pns item kind constants in preparation for renaming pns classes
2016-09-06 16:06:06 +02:00
de6281e977
Move PNS router code into namespace PNS
...
update copyright messages
2016-09-06 16:06:06 +02:00
0ef866ee74
Code formatting
2016-08-15 17:16:53 +02:00
a2ac1cd087
P&S: cleaner placement of DP segments/vias. Speed improvements too.
2016-08-15 17:16:49 +02:00
1b2fd6a382
Replace BOOST_FOREACH with C++11 range based for.
2016-06-29 16:07:55 -04:00
96ec9db5d6
Add missing C++ stdlib headers
...
The GCC standard library headers often include other headers, which makes
some code compile that forgets to include several headers.
2016-05-28 12:46:29 -04:00
2607497b37
Code formatting.
2015-10-05 18:28:41 +02:00
9da18f6db6
router: fix ortho snap mode for diff pairs
2015-08-20 09:46:19 +02:00
7650b0e8ad
Minor code cleaning (PNS).
2015-07-24 09:42:46 +02:00
49fac351ab
Fix a few coverity warnings.
2015-06-15 16:01:43 +02:00
721949b50e
Fix memory leak in pns_node and pns_line_placer. Fix coverity uninitialized warnings.
2015-03-10 15:38:27 +01:00
e6a10faab7
FIxed a few clang warnings.
2015-03-09 11:06:54 +01:00
5f1c9060ac
P&S router: fix unguarded boost optional derefernce. (fixes lp:1427880)
2015-03-03 20:16:14 -05:00
a6bd3314e4
Fixed warnings.
2015-03-03 12:59:26 +01:00
385d3648d6
router: removed some printfs()
2015-03-03 10:36:44 +01:00
3f015705ac
working on shove fix for DPs
2015-02-26 16:34:10 +01:00
4fb9bce354
Code formatting.
2015-02-18 17:53:46 +01:00
112adccbcb
router: differential pairs & length tuning support
2015-02-18 01:29:54 +01:00
Jeff Young
Mike Williams
Jon Evans
Wayne Stambaugh
Seth Hillbrand
Tomasz Włostowski
Seth Hillbrand
Camille
Jean-Samuel Reynaud
John Beard
decimad
Maciej Suminski
Simon Richter
jean-pierre charras