Jeff Young
2bc273f8bc
Don't fire event-parameter asserts when looking for a click event.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/KICAD-2CK
2023-10-13 20:31:01 +01:00
Jeff Young
8d3047d6eb
Clear selection before deleting board layers.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15866
2023-10-13 18:20:33 +01:00
Jeff Young
a69869f72a
Simplify undo/redo for pad edit mode.
...
Also simplifies high-contrast-mode handling to fix a bug when exiting
pad edit mode via an undo.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15845
2023-10-13 13:59:31 +01:00
Jeff Young
62d959ed0e
Don't assume an error location for PAD::GetEffectivePolygon().
...
While ERROR_INSIDE was good for plotting, 3D generation, etc., it's
not good for generating router hulls.
Also reverts part of the change to always use polygons for PNS::SOLIDs. A single shape in a SHAPE_COMPOUND will be faster (and
more accurate).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14898
2023-10-13 13:59:26 +01:00
jean-pierre charras
38c7fa6db9
Pcbnew: do not display the outlines of a very special zone used by DRC
...
to show layer mask bridges created by DRC to show these bridges.
This is not a real ZONE, just a container to displays these filled areas.
2023-10-13 14:25:49 +02:00
jean-pierre charras
57efde1bbb
Pcbnew: rename ZONE* m_SolderMask to m_SolderMaskBridges
...
(It is a container to build bridges on solder mask layers by DRC, not real zone)
Disable also this special zone selection by adding it in
PCB_SELECTION_TOOL::itemPassesFilter
2023-10-13 09:57:21 +02:00
Jon Evans
96f9f2c658
PNS: Allow for approximation error in hull clearance
...
Also revert to using exact hulls for non-compound shapes
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14898
2023-10-12 22:55:34 -04:00
Jon Evans
660c407095
ADDED: Control of multi-layer plot order from plot dialog
...
Enabled by 0b136ae0
2023-10-12 21:52:37 -04:00
Thomas Pointhuber
7cb198e021
fix SEGV in pcb_generator_meanders
2023-10-12 21:47:34 +02:00
jean-pierre charras
79a45c4803
TestBoardOutlinesGraphicItems(): handle small arcs.
2023-10-12 19:59:11 +02:00
Jeff Young
af020f4f9a
Fixes for diff-pair meander rectangle & edit points.
2023-10-12 17:54:34 +01:00
Jeff Young
78ee6f2e42
Fix a couple of undo bugs.
...
The first caused items coming back from undo to be hidden.
The second caused them to be ungrouped from the parent meander.
2023-10-12 17:54:34 +01:00
Jeff Young
cdc9c2e409
Fix undo bug where items come back hidden.
2023-10-12 17:54:34 +01:00
Jeff Young
16d904d47e
Add support for diff-pair meanders.
2023-10-12 17:54:34 +01:00
Jeff Young
d4b8b550f3
Go back to using VIEW::Hide() instead of ForcedTransparency().
...
(The issue was that the selection VIEW_GROUP drawing ignores the
HIDDEN flag so we need to make sure the PCB_GENERATOR_MEANDERS isn't
in the selection VIEW_GROUP while we're editing it.)
2023-10-12 17:54:34 +01:00
Jeff Young
1b676985f6
Retire length tuning tool in favour of first-class meanders.
2023-10-12 17:54:34 +01:00
Jeff Young
1ca477aeee
Unroll from PICKER_TOOL so we can handle amplitude/spacing events.
...
Also fixes a bug where we didn't clear the router on an <ESC>.
2023-10-12 17:54:34 +01:00
Jeff Young
d6c2ad7503
Unroll from PICKER_TOOL so we can handle amplitude/spacing events.
...
Also fixes a bug where we didn't clear the router on an <ESC>.
2023-10-12 17:54:34 +01:00
Jeff Young
1aeccc5895
Unroll from PICKER_TOOL so we can handle amplitude/spacing events.
2023-10-12 17:54:34 +01:00
Jeff Young
a57c9967f3
Draw meander borders while placing.
2023-10-12 17:54:34 +01:00
Jeff Young
4da3e0ff93
Make meander dashed-line borders constant size.
2023-10-12 17:54:34 +01:00
Jeff Young
d04641c868
ADDED: support for editing target length in Meander Properties dialog.
...
Also supports overriding the custom rules.
2023-10-12 17:54:34 +01:00
Wayne Stambaugh
e3c491424b
Coding policy, Doxygen comment, and spelling fixes.
2023-10-12 12:27:30 -04:00
jean-pierre charras
a7d540ce94
TestBoardOutlinesGraphicItems(): add missing case.
...
DRC_TEST_PROVIDER_MISC::testOutline(): use a smaller size to dectedt small items.
2023-10-12 15:53:21 +02:00
jean-pierre charras
499f3ca95b
DRC_TEST_PROVIDER_MISC::testOutline(): add test to detect questionable items.
...
Graphic items (segments, rects, circles) on Edge.Cuts can create issues when
building board outlines, when they are very small (a few nm in size), because
they are not easily handled when trying to search connected graphics.
Also protect RC_ITEM::SetItems() against null pointer.
Fixes #15865
https://gitlab.com/kicad/code/kicad/-/issues/15865
2023-10-12 14:48:24 +02:00
Alex Shvartzkop
0ea85ec9f5
Restore fill polygons on proper layers when flipping zones.
2023-10-12 02:21:47 +03:00
Jon Evans
0b136ae0df
CLI: Allow controlling layer order for multilayer plots
2023-10-11 00:18:58 +00:00
Jeff Young
d8f35633d4
Modify interactive delete tool to respect groups & selection filter.
2023-10-10 16:04:54 +01:00
Jeff Young
8c017be24a
Clearer naming.
2023-10-10 15:43:45 +01:00
Jeff Young
0683313ecb
Fix ghosted image while moving meander.
...
Also cleans up some undo description strings. (They go in the menu
so they should be title-caps.)
2023-10-10 15:24:58 +01:00
Jeff Young
d3b50f0607
Cleanup (no functional changes).
2023-10-10 13:42:42 +01:00
Jeff Young
04e23bf5e3
Fix build.
2023-10-10 12:58:12 +01:00
Jeff Young
d916e650f1
Tuning status popup for point editor.
2023-10-10 11:55:57 +01:00
Jeff Young
bb74445dda
Code clarity.
2023-10-10 11:14:47 +01:00
Jeff Young
4226839586
Switch to diff-pair mode if startItem is a diff-pair member.
2023-10-10 11:08:53 +01:00
Jeff Young
099e5dd9e7
More undo bugs.
2023-10-09 22:32:32 +01:00
Jeff Young
994f9f8823
Cleanup & compiler warnings.
2023-10-09 22:32:32 +01:00
Jeff Young
642938455e
Add status popup for meander placer.
2023-10-09 22:32:32 +01:00
Jeff Young
1afa6ddbd5
Rename getLineBetweenPoints() to getLine().
...
While it uses the first point to find the line, it in fact returns
the entire connection, not just the part between the two points.
2023-10-09 22:32:32 +01:00
Jeff Young
44e0821e13
Fix some issues with undo.
...
Also fixes the baseline being visible while placing the meander.
2023-10-09 22:32:32 +01:00
Jeff Young
d10b0b053e
Move meander placer picker tool from item highlighting to net highlighting.
2023-10-09 22:32:32 +01:00
Jeff Young
b662ff4956
Improve graphical feedback while placing a meander.
2023-10-09 15:22:41 +01:00
Jeff Young
60a2439a53
Better spacing in the meander properties dialog.
2023-10-09 15:22:41 +01:00
Jeff Young
35d8635a6b
Default skew tuning lenght to diff between N/P, but allow override.
2023-10-09 15:22:41 +01:00
Alex Shvartzkop
21adc0aac5
ADDED: Import vector graphics into Schematic editor (SVG, DXF).
2023-10-09 07:04:50 +03:00
Alex Shvartzkop
60d069757a
ADDED: Import vector graphics into Symbol editor (SVG, DXF).
2023-10-09 07:04:50 +03:00
Alex Shvartzkop
f4f8523c59
Rename pcbnew DIALOG_IMPORT_GFX -> DIALOG_IMPORT_GFX_PCB
2023-10-09 07:04:50 +03:00
jean-pierre charras
c9d6e79d2d
Fix minor compil warnings.
2023-10-08 15:04:45 +02:00
Alex Shvartzkop
b77df1eea4
Use advanced_config key EnableGenerators to enable menu entries for generators.
2023-10-08 02:41:17 +00:00
Alex Shvartzkop
f11339f1f5
Add actions for generators to Tools menu.
2023-10-08 02:41:17 +00:00
Alex Shvartzkop
af3bd15469
Avoid crash when length tuning+closing window.
2023-10-08 02:41:17 +00:00
Alex Shvartzkop
08e0d8d98a
ADDED: Manager dialog for generative objects.
2023-10-08 02:41:17 +00:00
Alex Shvartzkop
a4832dd3c8
ADDED: Interactive meander objects for length tuning.
2023-10-08 02:41:17 +00:00
Alex Shvartzkop
455268f45e
Allow to specify meander initial side via meander settings.
2023-10-08 02:41:17 +00:00
Alex Shvartzkop
ce8849f8bc
Skip move in meander placers if points match.
2023-10-08 02:41:17 +00:00
Alex Shvartzkop
8b21a260c9
Refactor MEANDER_PLACER_BASE::cutTunedLine to SHAPE_LINE_CHAIN::Split.
2023-10-08 02:41:17 +00:00
Alex Shvartzkop
6cfb05b4a3
Save/load generative objects in PCB file.
2023-10-08 02:41:17 +00:00
Alex Shvartzkop
7b645aa541
Introduce GENERATORS_MGR.
2023-10-08 02:41:17 +00:00
Alex Shvartzkop
546c7ed218
Introduce GENERATOR_TOOL.
2023-10-08 02:41:17 +00:00
Alex Shvartzkop
be72e07e61
Introduce PCB_GENERATOR.
2023-10-08 02:41:17 +00:00
Alex Shvartzkop
0fcb36bc2e
Add reselectItem action.
2023-10-08 02:41:17 +00:00
Jeff Young
b4986030da
Include solder mask in STEP export stackup height.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15632
2023-10-07 10:28:38 +01:00
Alex Shvartzkop
36853b0df4
Allow translation of "Open cancelled by user." in pcb_parser.cpp
2023-10-07 09:09:30 +03:00
Alex Shvartzkop
280fe976c4
Add a re-entrancy guard to PCB_POINT_EDITOR.
2023-10-07 03:51:52 +03:00
Alex Shvartzkop
74075fe4d6
Fix target skew not working properly in meander skew placer.
2023-10-07 03:51:26 +03:00
Alex Shvartzkop
e4e769493c
Skip very short segments in MEANDER_SHAPE::forward.
2023-10-07 03:51:18 +03:00
Jeff Young
da5f5536c8
Honour custom layer names for Layer_Top and Layer_Bottom.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15835
2023-10-06 21:55:57 +01:00
Jeff Young
3f0067cbaa
Adjust colours in appropriate direction depending on background.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15841
2023-10-06 21:27:02 +01:00
Jeff Young
83d896951a
Apply epsilon more uniformly to footprint checks.
...
Rotation can cause round-off errors even in ints.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15838
2023-10-06 21:04:23 +01:00
Jeff Young
420cadab34
Separate meander settings from target length/skew.
...
Settings move to Board Setup, while target length is sourced from
the custom rules (or a text-entry dialog if no rules are active for
the track).
Target skew is sourced from the coupled-trace-length minus the
trace-to-be-tuned length.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12075
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15826
2023-10-06 19:46:55 +01:00
Jeff Young
b9e1908ffe
Try to find a happier medium for text entry box widths.
...
Most dialogs have units outside the text entry, and the likelihood
of 14 significant digits & units is low enough to allow scrolling
in that case.
2023-10-06 19:46:55 +01:00
Alex Shvartzkop
d7863b09c5
Move CORNER_STRATEGY out of SHAPE_POLY_SET.
2023-10-06 15:42:50 +03:00
Alex Shvartzkop
bf29b25190
EAGLE PCB: fix a regression causing polygons not being imported.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15829
2023-10-06 01:13:58 +03:00
Ian McInerney
0876fb0985
Re-implement direct layer switching in the router tool
...
Also add a new framework to allow grouping actions that are similar into
a single context that can then be used for mass comparisons.
2023-10-05 13:34:25 +01:00
Jeff Young
31c488bc23
NETINFO_ITEMs are owned by BOARD.
...
Lifecylce management must go through BOARD_COMMIT (or at least
the frame's undo/redo lists).
2023-10-04 21:01:33 +01:00
Mike Williams
c2d7b26ebd
PCBNew: don't grab the wrong parameter type when placing vias
2023-10-04 12:17:15 -04:00
Hasan Jaafar
c45ebfcccd
Add hot key column on layer select dialog
2023-10-04 12:17:15 -04:00
jean-pierre charras
37df47a3e7
genDrillMapFile: reduce the pen width used to plot oval shapes (better look)
2023-10-04 15:47:47 +02:00
Jeff Young
9f5e583ced
Readability.
2023-10-03 17:14:03 +01:00
Jeff Young
9b60e99660
Use wxSTAY_ON_TOP instead of wxFRAME_FLOAT_ON_PARENT for choosers.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15808
2023-10-03 14:49:50 +01:00
Jeff Young
a3d83cdb6d
Pass symbol netlist from Field Properties dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15806
2023-10-02 23:41:06 +01:00
Jeff Young
987e382f96
Add missing member variable initialization.
2023-10-02 22:18:31 +01:00
Jeff Young
e242f54816
Fix crash trying to create a new board.
2023-10-02 22:12:07 +01:00
Jeff Young
8760bd8c80
Reconcile "apply defaults to new footprints" with DRC lib checks.
...
Moves apply defaults settings to Board Setup (where they were
duplicated anyway due to an earlier botched merge).
Modifies the apply-to-graphics algorithm to skip copper shapes.
Modifies DRC library check to skip STROKE_PARAMS for non-copper
shapes.
2023-10-02 22:10:13 +01:00
Jeff Young
2d3a8ee4c9
Readability and comments.
2023-10-02 20:56:16 +01:00
Jeff Young
9d678e96cd
Improve spacing.
2023-10-02 16:33:26 +01:00
Jeff Young
06446bb80e
Only expand lib tree when filtering.
2023-10-02 16:24:53 +01:00
Mike Williams
7c8e74c156
Fields: fix redundant update messages
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15801
2023-10-02 11:02:10 -04:00
Marek Roszko
6d3b846eb5
Add more missing destructor event cleanups
2023-10-02 07:22:00 -04:00
Jeff Young
eaa3ee43e9
Tighten terminology consistency in clearance & constraint reports.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15800
2023-10-02 11:12:18 +01:00
Jeff Young
609dedda3c
Insert lazily-created-rows at right position in grid sizer.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15652
2023-10-02 11:12:18 +01:00
Jeff Young
cf02bb171f
Expose exclusion flags in search pane.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15776
2023-10-01 22:46:34 +01:00
Jeff Young
904bdc3c66
Use netclass values when reaching netclass entry.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15774
2023-10-01 21:01:46 +01:00
Jeff Young
9214e47367
Only allow switching to enabled layers.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15779
2023-10-01 15:27:55 +01:00
Marek Roszko
bfbba632df
Guard GetModificationTime with IsValid otherwise it'll return based on INT64_MIN.
...
Fixes KICAD-3Z0
2023-10-01 09:43:09 -04:00
Marek Roszko
f1c5581802
Don't continue with a null board in board import
...
Some plugin is failing and returning a null-board when the usual convention was exceptions
Fixes KICAD-3ZJ
2023-10-01 09:38:44 -04:00
Alex Shvartzkop
25cca5adfe
EasyEDA Std: fix polygon pad orientation.
2023-10-01 16:21:26 +03:00
Alex Shvartzkop
9cca8e5970
EasyEDA Std: assign nets to PCB circles and rects.
2023-10-01 16:21:17 +03:00
Thomas Pointhuber
7005dd7c48
altium: make special string parsing on pcb a bit more generic
...
Only special strings starting with a dot are supported. Parsing of concatenated special strings using quotes needs to be implemented, but at least a few test-cases are already there now.
2023-10-01 15:10:50 +02:00
Thomas Pointhuber
3b3e4fd34a
Move duplicated code of plugin.cpp and sch_plugin.cpp into a new plugin_utils located in commons
2023-10-01 13:58:38 +02:00