Jeff Young
3217372720
Tighten up the lifecycle management of VIEW_ITEMs in
...
general, and the SYMBOL_VIEWER_FRAME's m_previewItem in
particular.
(Attempted fix for Sentry KICAD-G1.)
(cherry picked from commit 6f59740953
)
2023-04-16 15:38:15 +01:00
Jeff Young
9893921d76
Handle legacy libraries with escaped symbol names.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14057
(cherry picked from commit b74d964bff
)
2023-04-15 22:31:49 +01:00
Jeff Young
5574f35473
Apply symbol attributes from base symbol, not derived symbol.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13740
(cherry picked from commit d4b4abd001
)
2023-04-15 22:31:49 +01:00
Jeff Young
1707436cad
Retire the lib-tree scoring algorithm.
...
It appears to cause more confusion than help.
Fixes https://gitlab.com/kicad/code/kicad/issues/13905
(cherry picked from commit d01c023d5a
)
2023-04-15 00:09:34 +01:00
Jeff Young
f67a477f65
Pull some fixes from master.
2023-04-14 19:55:31 +01:00
Jeff Young
3573b97bfc
Save library when it's selected in lib tree.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14220
(cherry picked from commit 05185ec81a
)
2023-04-14 17:36:10 +01:00
jean-pierre charras
37a42a3fb7
ERC: set default setting ERCE_SIMULATION_MODEL to ignore
...
Most of projects do not manage spice settings.
From master branch
2023-04-14 17:29:42 +02:00
Jeff Young
a51475a094
Performance improvement for GetShownColumns.
...
(This needs to be fast as it's called from OnUpdateUI events.)
(cherry picked from commit 8e29a054f3
)
2023-04-13 13:47:21 +01:00
Jeff Young
f25e2d48bd
Search in label fields.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14075
(cherry picked from commit a24a63e416
)
2023-04-13 10:59:39 +01:00
Seth Hillbrand
70b4503187
Fix cherry-pick errors
2023-04-13 02:11:39 +02:00
Jeff Young
912bd4458f
Don't trip over a uniquified-name in the schematic library-symbol cache.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14160
2023-04-12 18:35:27 +01:00
Seth Hillbrand
68dfcddbe9
Allow bus elements to connect
...
Previously, bus elements that were not instantiated as individual nets
could not connect to each other. This caused issues for complex
schematics where busses needed to connect to other busses with elements
that resolved to the same net names. Functionally, this means mixing
bus elements, which we will replace with first-class elements in version
8 but currently can only be accomplished either by using bus aliases and
this patch or by individually instantiating each bus element as a
local label
Fixes https://gitlab.com/kicad/code/kicad/issues/14300
(cherry picked from commit 16b4ec3c7e
)
2023-04-12 16:10:50 +02:00
jean-pierre charras
907761f14e
SCH_LABEL_BASE::SetPosition(): ensure field positions are also handled.
...
Fixes #14520
https://gitlab.com/kicad/code/kicad/issues/14520
2023-04-12 11:20:41 +02:00
jean-pierre charras
ea95d8604a
Ensure we do not use a non existing pin in SIM_MODEL::MigrateSimModel()
...
From master branch
Fixes #14522
https://gitlab.com/kicad/code/kicad/issues/14522
2023-04-12 09:41:07 +02:00
Jeff Young
1f34883a27
Make symbol/footprint trees sensitive to language change.
...
(cherry picked from commit eef3492fc0
)
2023-04-12 00:01:58 +01:00
jean-pierre charras
372e7b6312
fix 2 issues related to SCH_GLOBALLABEL items:
...
- Ensure the first field in m_fields has id = 0 to be seen has hypertext
(it was not the case after reading a .kicad_sch file)
- when converting this item to another label/text, remove this special Field
from the copied field list to the converted label.
From master branch.
2023-04-10 10:02:50 +02:00
Jeff Young
cbff011e3c
Don't delete default intersheetrefs field from global labels.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14493
(cherry picked from commit a226f7fc14
)
2023-04-09 19:04:33 +01:00
jean-pierre charras
e991ae504b
DIALOG_IMAGE_PROPERTIES: fix some issues:
...
- add missing panel_image_properties_base.fpb file
- fix not displayed image.
From master branch
2023-04-08 17:04:02 +02:00
Seth Hillbrand
39dcd0a352
Handle nested netclass assignments
...
Netclass directives should not be overriden, instead hold our error
checking for actually missing nets
Fixes https://gitlab.com/kicad/code/kicad/issues/14494
(cherry picked from commit 012737593b
)
2023-04-06 17:38:42 -07:00
Jeff Young
dce2247925
Improve scoping control of connetion members.
...
(The real bug here is that CONNECTION_GRAPH::assignNetCodesToBus() was
growing the bus aliases members list because it used a non-const
reference to it as a local storage list. The const scoping of it will
prevent this type of error in future.)
Fixes https://gitlab.com/kicad/code/kicad/issues/14269
2023-04-04 11:35:06 +01:00
Jeff Young
9a57c11348
Possible protection from acessing deleted window data.
...
(Long shot for Sentry KICAD-MM.)
(cherry picked from commit bd60f38569
)
2023-04-03 23:47:09 +01:00
Jeff Young
a21e7a5eee
Don't pass a FRAME-based UNITS_PROVIDER to a modeless dialog.
...
(The dialog may outlive said frame.)
Should fix Sentry KICAD-3A.
(cherry picked from commit 9b4627e782
)
2023-04-03 17:20:06 +01:00
Jeff Young
927b5ae707
Use enums for column ids.
...
(The nickname, in particular, is no longer column 1.)
Fixes https://gitlab.com/kicad/code/kicad/issues/14291
2023-04-02 15:28:11 +01:00
Jon Evans
b22ff229db
DbLib: Get rid of some GCC warnings
...
(cherry picked from commit c35cefe1d5
)
2023-03-26 19:48:58 -04:00
Roberto Fernandez Bautista
97c018118d
CADSTAR Sch: TERMATTR may have more than one attribute subnode
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13526
(cherry picked from commit fc04f5135f
)
2023-03-26 14:55:06 +00:00
Jeff Young
7931f315b1
Manually cherry-pick some fixes back from master.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14424
2023-03-26 11:00:23 +01:00
jean-pierre charras
f2ce9cf857
Plot symbol graphic texts: fix incorrect position of texts in some rotations.
...
The plot code is now similar to the one for symbol fields
From master branch.
Fixes #14327
https://gitlab.com/kicad/code/kicad/issues/14327
2023-03-25 18:27:35 +01:00
Jeff Young
d4a312d6cb
Move separation of model name from params earlier in the process.
...
We need just the model name when we look for a match in the library file.
(cherry picked from commit 60aadfee40
)
2023-03-25 15:37:57 +00:00
Marek Roszko
434161687e
Fix cli crash due to dialogs buried in the pcb parser...
...
Fixes sentry KICAD-Q2
(cherry picked from commit 8a8589b9db
)
2023-03-24 23:53:15 +00:00
Jon Evans
b0b9e66fad
Move to requiring explicit action to save project settings
...
(cherry picked from commit 610e787ada
)
Fixes https://gitlab.com/kicad/code/kicad/issues/14414
2023-03-24 11:49:50 -07:00
Seth Hillbrand
89488a43b9
Pins are case-sensitive
...
Cleanup should remove mis-matched cases
Fixes https://gitlab.com/kicad/code/kicad/issues/14415
(cherry picked from commit 0984599624
)
2023-03-24 11:35:20 -07:00
Jon Evans
2ada171806
Be more flexible about extracting booleans from database
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14376
(cherry picked from commit dd8b52af93
)
2023-03-23 01:25:09 +00:00
Jeff Young
7026cfe140
Split name from additional params only when model is a library reference.
...
(cherry picked from commit b8cf7cc080
)
2023-03-22 14:12:42 +00:00
Jeff Young
b7cd1dd764
Handle single-token flag parameters.
...
Also fixes a bug where all VDMOS instance parameters weren't marked as
instance parameters.
Also fixes a bug where VDMOS thermal models weren't supported (they
have two extra pins: Tj and Tcase).
(cherry picked from commit 5bda3b99f9
)
2023-03-22 14:12:42 +00:00
Jeff Young
09bb8fc4f4
Don't include non-overridden parameters in Sim.Params.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14369
(cherry picked from commit 9dc16eb014
)
2023-03-22 14:12:42 +00:00
Jeff Young
1614dc975a
Separate legacy model name from parameters.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13988
(cherry picked from commit 39a801423e
)
2023-03-21 13:31:20 +00:00
Jeff Young
a713ee852c
Ignore extraneous LTSpice parameters for VDMOS models.
...
Also adds special case handling of VDMOS syntax to allow parens (or extra
spaces, linebreaks, etc.) between "VDMOS" and "NCHAN"/"PCHAN".
Fixes https://gitlab.com/kicad/code/kicad/issues/14299
2023-03-20 16:16:13 +00:00
Jeff Young
1dc9583e06
Don't attempt to load unknown plot types.
2023-03-20 10:24:22 +00:00
Jeff Young
3afe02ac1f
Make sure legend reflects gain/phase for AC small signal analyses.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14301
(cherry picked from commit ec6d709929
)
2023-03-20 10:24:22 +00:00
Jeff Young
9d457dc0ab
Less nagging. (If we need a field name, then create one.)
...
Also cleans up empty fields when exiting the dialog.
2023-03-19 19:15:28 +00:00
Jeff Young
044c301d64
Remove accelerator keys from schematic find/replace dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14304
(cherry picked from commit afe813cae5
)
2023-03-18 23:38:09 +00:00
Jeff Young
fb02e55424
Don't pass a REPORTER when checking for overrides.
...
It fails the unit tests (as it generates a message whenever no override
is found).
2023-03-17 15:30:24 +00:00
Jeff Young
70e86434ef
Manual cherry-pick of much of 6d296038f3
2023-03-17 14:12:58 +00:00
Jeff Young
64641c28ef
Handle underscore in parameter names.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14308
(cherry picked from commit 222cd4d009
)
2023-03-16 23:51:56 +00:00
jean-pierre charras
69e9f4ada2
DIALOG_LABEL_PROPERTIES, add global label: better filtering of candidates.
...
The list of candidates (names) must be restricted to existing global labels
and symbols creating a global net name: power symbols having only one power
input pin (a power output does not create net name).
Fixes #14319
https://gitlab.com/kicad/code/kicad/issues/14319
2023-03-16 16:01:18 +01:00
Wayne Stambaugh
d28cf632e4
Coverity fixes and code cleaning.
...
(cherry picked from commit a1fb8e1b1d
)
2023-03-16 10:59:05 -04:00
jean-pierre charras
25f40566ed
Symbol editor: fix incorrect position of fields when loading a symbol from schematic.
...
In symbol editor, symbols are always shown not mirrored, not rotated.
So if the loaded symbol from schematic was rotated/mirrored, the position
of fields must be recalculated for the rotation 0, no mirror.
From master branch
2023-03-15 18:03:11 +01:00
Jeff Young
94057886a3
Support SHEET_PATH when printing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14233
(cherry picked from commit dc78797274
)
2023-03-14 11:56:33 +00:00
Jeff Young
b2679b7648
Swap pins for undo.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14100
(cherry picked from commit c266913ec7
)
2023-03-14 11:56:33 +00:00
Jeff Young
c5a69f073c
Added PSPICE/LTSPICE JFET model parameters.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12425
(cherry picked from commit 3bc5e3dd8a
)
2023-03-12 21:05:06 +00:00