haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
35,220 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

118 Commits

Author SHA1 Message Date
Alex 3dea146488 router: Clear rule resolver caches on routing/dragging start. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12907
 2022-11-17 02:10:21 +05:00
Alex 3f790d9dae Revert "router: Disable writing clearance cache for items in local variables." 
This reverts commit 6d71f27500.

Caused a performance drop in walkaround mode.
 2022-11-17 02:10:20 +05:00
Alex 6d71f27500 router: Disable writing clearance cache for items in local variables. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12907
 2022-11-16 21:19:56 +05:00
Seth Hillbrand 17fdb7c6a8 Prevent drag index from exceeding full line count 
Simplification removes segments, so we might lose our valid index.
Ideally, we would simplify during the assembly or pass the input index
to the simplify routine to maintain the proper value.

Fixes https://gitlab.com/kicad/code/kicad/issues/12137

(cherry picked from commit 6c617d84ca)
 2022-08-01 08:58:28 -07:00
Tomasz Wlostowski e558893851 router: use actual snap point position for routability checks of a segment instead of the segment endpoint(s). 
Explanation:
- place a long segment A with something violating the rules close to its endpoint
- try to start routing in the 2/3 of the length of A (on the obstacle side)
- bummer - the router picks the nearest endpoint of A for the collision check (even though we don't care about this collision since we want to route far away from it)
 2022-07-21 16:30:28 +02:00
Jeff Young 833dc70bff Add edge-exclusions to router (for castellated pads). 
Fixes https://gitlab.com/kicad/code/kicad/issues/1790
 2022-06-27 15:16:37 -06:00
Tomasz Wlostowski 990281a897 router: use either copper or hole clearance, whichever is larger, when checking track -> hole collisions 2022-06-09 00:31:47 +02:00
Jon Evans 30fb298ed3 PNS: Re-enable hole clearance for non-flashed pads/vias 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11098
 2022-06-07 19:49:38 -04:00
Jon Evans 9a2950cca1 PNS: Use exact hulls for walkaround path generation 
When we generate hulls, by default we subtract the clearance epsilon
to prevent false collisions in the router that wouldn't be flagged
by DRC.  However, we need to use the actual hull with no epsilon
when generating hulls for pathfinding in the walkaround system.

Without this change, it is possible for the walkaround to generate
a valid-seeming path that results in a DRC violation, for example
when dragging a drag against a board edge.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/10536
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11365
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10710

(cherry picked from commit 2a91ba35c1)
 2022-06-04 00:04:03 -04:00
Tomasz Wlostowski 54f4f765b9 router: NODE|ITEM::QueryColliding() now can override clearance 
Needed for clustering algorithm (to be committed later... ;-)
 2022-06-03 23:28:41 +02:00
Tomasz Wlostowski b08280d00c router: enable Hole Clearance rule only in Mark Obstacles mode 
(it will be brought back to Walk/Shove modes as soon as all the underlying issues are fixed)
 2022-06-03 23:28:40 +02:00
Jeff Young b2e3f03222 More wide-string declarations. 2022-02-05 22:03:04 +00:00
Jon Evans 7de9e48b57 PNS: Fix tuning calculations through locked segments 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9727
 2021-12-05 13:35:28 -05:00
Jon Evans cf53b053a1 Improve handling of dragging around locked segments 
Locked segments now are not modified if they weren't the start item.
If a locked segment is the start item, it is automatically unlocked.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/9145
 2021-09-21 22:38:53 -04:00
Roberto Fernandez Bautista aa67abb681 PNS::NODE Use PointCount instead of calculating segment index manually 
There is no need to manually calculate the segment index - we know
that the last point that was added is the start point of the segment.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8945
 2021-08-13 19:09:33 +01:00
Jon Evans e61b1f03b8 PNS: Discard duplicate tracks in FixRoute 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8737
 2021-07-13 21:13:40 -04:00
Seth Hillbrand ff2e470a6e Remove virtual items from clearance calculations 
Extends 3ea970f8c9 to ensure that virtual items do not interfere with
DRC calculations while routing

Fixes https://gitlab.com/kicad/code/kicad/issues/8788
 2021-07-13 16:10:36 -07:00
Wayne Stambaugh 65c7958293 Coverity issue fixes. 
Issues #331869, #331875, #332203, #332159, #332171, #332180, and #332648.
 2021-07-08 08:33:08 -04:00
Roberto Fernandez Bautista c3051ba48a Refactor SHAPE_LINE_CHAIN to allow two shapes per point 
m_shapes now has two possible indices. The first one is populated if
the point is associated with an arc and the second index is populated
if the point is shared between two arcs.
 2021-07-03 19:37:50 +00:00
Marek Roszko 8377ebb0e1 Fix msvc warnings 2021-06-06 15:30:31 -04:00
Tomasz Wlostowski 63fc7a1908 router: support for drag/walkaround/shove for joints between lines of different widths. 
fixes: https://gitlab.com/kicad/code/kicad/-/issues/1773
 2021-06-03 22:44:53 +02:00
Marek Roszko cf2bb5692a Remove the wxLog calls from math/util.h for now 
This was leaking windows headers and partial wx headers to 1084 compilation units......
This also means math/util.h is leaking to 1084 compilation units which seems a bit high too.
 2021-06-01 18:44:22 -04:00
Tomasz Wlostowski ebd957b08e router: rework router's debugging infrastructure to be more compatibile with the 'qa/pns/pns-log-viewer' tool. 
The log viewer tool lets you inspect all the intermediate stages of the routing algorithms. This patch:
- Adds source location tracking of the debug calls (need to use the PNS_DBG macro, sorry)
- Moves some wxLogTrace calls to DEBUG_DECORATOR::Message() so that messages can be displayed alongside the corresponding geometric shapes
 2021-05-29 00:13:24 +02:00
Tomasz Wlostowski b3caa3c4d4 router: fix ordering of colliding hulls in NODE::NearestObstacle() 
Replaced the generic SHAPE_LINE_CHAIN::Intersect() with PNS::HullIntersection() which correctly rejects
'non-penetrating' intersections.
 2021-05-29 00:13:24 +02:00
Jonathan Haas 075bd788eb Remove unused OBSTACLE_VISITOR::m_extraClearance 2021-04-23 01:53:09 +00:00
Jon Evans 49a91414d7 PNS: Apply co-linear seg merging to drag operations 2021-04-11 22:32:11 -04:00
Jon Evans 1c431d9929 PNS: Fix some off-by-one errors with arc dragging 2021-04-11 22:12:53 -04:00
Jon Evans a26fc6d65d PNS: Fix several issues with arc dragging 
Do not merge vertices that belong to different arcs
Fix start segment identification after arcs
Fix free-angle drag after arc

Fixes https://gitlab.com/kicad/code/kicad/-/issues/8173
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8150
 2021-04-11 17:56:40 -04:00
Jon Evans d878cbddbc PNS: a few forgotten cleanup items 2021-04-07 23:34:45 -04:00
Jon Evans c9040a5c53 PNS: fix some weirdness identified by PVS 2021-04-07 23:16:56 -04:00
Jon Evans 9432484394 PNS: Find origin segment correctly when arcs are present 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8139
 2021-04-07 20:28:30 -04:00
Tomasz Wlostowski 61e75a838b router: replace large stack variables with std::array 2021-02-25 17:18:23 +01:00
Marek Roszko c12666ec43 Fix arg type of NODE::followLine 2021-02-20 11:58:55 -05:00
Wayne Stambaugh 6a39b81647 Fix the last of broken Doxygen comment specifiers. 2021-01-27 17:39:44 -05:00
Jeff Young e41c06304b Don't show a leading ratline to a NPTH. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6960
 2021-01-07 12:25:04 +00:00
Jeff Young f702b64b8d Minor improvements to formatting & SNR. 2021-01-07 12:25:04 +00:00
Jon Evans e7b047660c PNS: Correctly assemble lines with reversed arcs 2021-01-05 17:57:21 -05:00
Jon Evans feda03f69b PNS: Fix arc orientation when assembling lines with backwards arcs 2021-01-05 17:57:21 -05:00
Jon Evans 8619086cf2 PNS: re-enable optimization of colinear segs in lines with arcs 2021-01-05 17:57:21 -05:00
Jon Evans 8901e71fc8 PNS: Fix loop removal, make walkaround less broken for arcs 2021-01-05 17:57:21 -05:00
Jeff Young 8b849b1c49 Fix several bugs in hull push-back with vias. 
1) take hole plating thickness into account
2) build hulls specifically for via so pushing back to the hull doesn't
have to try and figure out how much extra to push back for the via
and/or hole
3) clear MK_HOLE flags when colliding with the pad itself so that we
don't get stuck in HOLE mode
4) move flag setting/clearing to updateNearest() so that it will keep
track of the state of the nearest collision

Fixes https://gitlab.com/kicad/code/kicad/issues/6913
 2021-01-02 19:14:44 +00:00
Jeff Young fc1b0ec11f Improve feedback when routing in highlight collisions mode. 
In particular, when Allow DRC violations is NOT turned on and we
bump in to an obstacle.
 2021-01-01 17:25:37 +00:00
Jeff Young 3ba17e0a16 Formatting. 2021-01-01 01:02:06 +00:00
Jeff Young ecc0e861d3 Implement hole clearance and hole-to-hole clearance in router. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6882
 2021-01-01 00:31:36 +00:00
Jeff Young 5d8e6020d1 Improve clarity. 2021-01-01 00:31:36 +00:00
Jon Evans 9a0f685a75 PNS: Consider arcs when searching for lines between joints 2020-12-31 13:05:43 -05:00
Jon Evans 912657dd23 Component dragger: make relaxed segment pickup work for PTH pads 2020-12-22 22:43:44 -05:00
Jon Evans 70c6314c67 Component dragger: be more generous about picking up tracks 
We now pick up tracks that end anywhere in the pad, not just
at the pad anchor.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/5945
 2020-12-22 22:28:24 -05:00
Jeff Young 9c7c05c161 Mostly formatting cleanup but a few type-casting cleanups too. 2020-11-24 22:16:41 +00:00
Werni 0e44f5128c Add const specifiers 2020-11-18 19:50:36 +00:00