Alex Shvartzkop
b7460f29b4
Altium schematic: fix properties parsing in old formats.
...
Leading "|" can be missing before "RECORD=28" in old formats.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16513
2024-01-14 13:12:47 +03:00
Seth Hillbrand
4e3d2a148d
Fix typo
2024-01-12 14:51:32 -08:00
jean-pierre charras
c18bfe0c61
DIALOG_DRC & DIALOG_ERC: re-enable button "Run ERC" and "Run DRC" after running tests.
...
Fixes #16583
https://gitlab.com/kicad/code/kicad/-/issues/16583
2024-01-12 15:38:25 +01:00
Seth Hillbrand
2aab24ef29
Prevent multiple reloads when saving
...
Avoid potential issues with Mac libedit crashes (hopefully)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14865
2024-01-11 19:01:31 -08:00
Wayne Stambaugh
0df8d5c2d6
Do not assert when pruning orphaned sheet and/or symbol instances.
...
Running the schematic editor in the stand alone mode can result in an
empty project name. Rather than assert when the project name is empty,
just don't run the pruning algorithm. The pruning will just have to
happen on the next load of the schematic when it has a proper project
name.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16577
2024-01-11 15:47:21 -05:00
Mike Williams
382fe3de09
Symbol Fields Table: fix regroup button using schematic values
...
Should use the datastore where possible since users are using this to
regroup before applying the data.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/16574
2024-01-11 12:01:12 -05:00
Jeff Young
4b1fc9c129
Update AM and SFFM source parameters to ngspice-43.
...
Note: there's no migration strategy because they didn't
work at all prior to ngspice-43.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16529
2024-01-10 20:27:52 +00:00
Jeff Young
94a7d1647f
Fix typo.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16542
2024-01-10 18:32:47 +00:00
Jeff Young
9038f80543
Switch button focus to Close after running ERC or DRC.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16541
2024-01-10 17:36:31 +00:00
Ian McInerney
e7746d3bc8
Fix spelling mistakes
2024-01-10 16:17:07 +00:00
Wayne Stambaugh
4f3fb5c23f
Second attempt at fixing ERC dialog reference update issue.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16519
2024-01-09 13:14:13 -05:00
Wayne Stambaugh
92c58f2564
Fix sheet path dependent ERC dialog selection issues.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16519
2024-01-08 11:16:55 -05:00
Jeff Young
120937b6b0
Honour forced transparency for strokes and fills.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16542
2024-01-07 17:40:50 +00:00
Jeff Young
392242b9a4
Make sure OK button has focus when re-displaying ERC window.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16541
2024-01-07 17:23:45 +00:00
jean-pierre charras
c5bb939cc9
LIB_TEXTBOX: fix incorrect line style in plot function for LINE_STYLE::DEFAULT.
...
LINE_STYLE::DEFAULT is fixed as SOLID in all plot functions, but not for this item.
Fixes #16543
https://gitlab.com/kicad/code/kicad/-/issues/16543
2024-01-07 16:14:15 +01:00
Jeff Young
84d161a4b7
Don't use referential values as defaults.
2024-01-06 22:01:23 +00:00
Jeff Young
7c5eaed69e
Un-comment and repair TRRANDOM sources.
...
Also adds new parameters to AM sources for ngspice-43.
Also fixes a bug in the spice parameter parser (which would
puke on any parameter name starting with one of the flag
parameter strings).
Also fixes a bug where the skipped source parameters would
get set to "0" instead of their default values.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16393
2024-01-06 20:34:36 +00:00
Wayne Stambaugh
50cad558cf
Do not update tree to selected sheet in schematic hierarchy navigator.
...
This was causing unwanted tree expansions when descending a sheet hierarchy
in editor.
Also fixed an issue with the tree highlighting when changing sheets in the
schematic editor.
2024-01-06 12:25:39 -05:00
Jeff Young
bbdefa05eb
Un-comment and repair AM and SFFM sources.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16529
2024-01-06 14:49:05 +00:00
Wayne Stambaugh
a310c0a05a
Do not expand the entire schematic hierarchy navigator tree by default.
...
The new behavior is to only expand to the first child of the root sheet
level. On very complex hierarchies, this makes the navigator far more
useful.
Do not update schematic hierarchy navigator on every edit. Now only
sheet changes will trigger a rebuild of the tree.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16371
2024-01-06 07:56:16 -05:00
Jeff Young
f5aa2ea8cf
Fix copy/pasta in arc plotting.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16531
2024-01-05 16:42:57 +00:00
Fabian Pflug
a1f796ffa0
Respect exclude from bom in all python files
...
Two scripts were missing the excludeBOM=True selector.
2024-01-05 16:11:20 +00:00
Wayne Stambaugh
f07d797ab3
Don't show ERCs for every sheet path when using shared schematics.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16434
2024-01-04 13:53:16 -05:00
Wayne Stambaugh
38562db023
Coding policy fixes.
2024-01-04 13:30:02 -05:00
Jeff Young
e438fc2569
Remove dead code. (Coverity)
...
Also fixes a (small) memory leak.
2024-01-04 15:57:30 +00:00
Jeff Young
ffa3b27a4e
Fix uninitialized variable. (Coverity)
2024-01-04 14:58:59 +00:00
Mike Williams
2a04e6ac63
Schematic: don't allow setting footprint for power symbols
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/16505
2024-01-03 08:52:08 -05:00
Ian McInerney
d0a3c04835
Handle rotating individual no connects
...
Fixes KICAD-4A9
2024-01-02 22:03:10 +00:00
Jeff Young
ab34ce295f
SCH_LINE_WIRE_BUS_TOOL must use GRID_GRAPHICS for lines.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16492
2024-01-02 17:31:08 +00:00
Jeff Young
2a0486845d
Restore legacy spin-style processing for text items.
...
Post-V5 we only use it on labels, but earlier versions also
used it for text.
Also process spinStyle for CADSTAR imports.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16488
2023-12-31 17:22:58 +00:00
Alex Shvartzkop
aa6fd88082
Default graphical line style in v6 and older was Dashed.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16479
2023-12-31 19:28:55 +05:00
Jon Evans
ea0673e7a0
Do not merge buses of distinct types
...
Previously, this code would merge a vector bus
with a group bus containing the vector as a member.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16439
2023-12-30 10:54:24 -05:00
Jeff Young
2e9f0679fc
Fix i18n mixup.
...
Tab names and column names are translated on the fly, but
that means they need _HKI macros to make sure they get into
the translation database.
2023-12-30 11:24:35 +00:00
Jeff Young
4551880e40
Fix a typo and some i18n issues.
...
(Also flags some i18n issues for 9.0.)
2023-12-29 17:12:10 +00:00
Ian McInerney
4eaa0242ca
Collapse schematic/symbol graphics import to single action
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16463
2023-12-29 02:57:21 +00:00
Ian McInerney
f2702b223c
Introduce base IO_MGR class and unify RELEASER objects
...
The IO_RELEASER is a thin-wrapper around a std::unique_ptr, but done
this way to allow easier addition of a custom deleter in the future if
something needs to call back into the IO_MGR.
2023-12-29 00:37:38 +00:00
Wayne Stambaugh
04d15026c5
Rename SCH_SYMBOL::GetInstanceReferences() to GetInstances().
2023-12-28 18:25:56 -05:00
Jeff Young
cdb99de862
Use HasSymbol() instead of a null logger.
2023-12-28 21:52:26 +00:00
Jon Evans
c9d31c4429
Add explicit copy ctor for SCH_CONNECTION
2023-12-28 15:30:25 -05:00
Jeff Young
e59612d56c
Add realloc locking calls for ngspice42.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15941
2023-12-28 19:36:18 +00:00
Wayne Stambaugh
482aff3f0b
Prune orphaned schematic sheet instances.
...
Pasting from the clipboard when copying from another project can leave
sheet instance information that is not valid for the current project.
This change prunes all sheet instance information that is not relevant
to the current project. It also prunes invalid paths created by pasting
sheets from different paths in the same project.
2023-12-28 12:19:19 -05:00
Jeff Young
a452213546
Reduce menu nesting for attribute setters/clearers.
...
Also fixes some issues with menus being owned by the wrong
tool.
Also removes "no xxx selected" warnings in submenus which
aren't show unless xxx is selected to start with.
Also fixes some un-translated strings (which happily
already exist elsewhere in the UI)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16454
2023-12-28 14:19:13 +00:00
Jan Wichmann
bddadd1f42
eeschema:
...
CHANGED: Simplifying the context menu and moving all removed items to main menu.
2023-12-28 13:58:05 +00:00
Marek Roszko
9a890cdba9
Kick the wildcards and file exts into a static class, export it from kicommon
2023-12-27 21:10:01 -05:00
Ian McInerney
4a67761d29
Push library reading check to IO_BASE
2023-12-27 16:44:45 +00:00
Ian McInerney
f8688a922d
Unify IO library descriptors
2023-12-27 16:34:59 +00:00
Jeff Young
49d6439ae0
Formatting.
2023-12-27 13:52:02 +00:00
Ian McInerney
743e9d669a
Push library management into IO_BASE
2023-12-27 01:21:53 +00:00
Ian McInerney
cad91312aa
Introduce main base class for all IO loaders
2023-12-26 23:27:11 +00:00
Wayne Stambaugh
20ee45edbe
Fix schematic editor crash when exporting symbols to missing library.
...
UI string was reused from the symbol library manager. No new translatable
strings were used.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16446
2023-12-26 12:49:34 -05:00
Alex Shvartzkop
5bbe01b570
EasyEDA Pro: support .elibz format (device libraries)
2023-12-25 07:00:24 +03:00
Ian McInerney
85f62c1fde
Rename all schematic IO plugins
2023-12-24 01:22:21 +00:00
Ian McInerney
d8b47d18d3
Initial rename of file plugin infrastructure components to IO
2023-12-24 01:22:21 +00:00
Jon Evans
63454d6da9
Prevent crash when opening properties of missing symbol
2023-12-23 17:30:29 -05:00
Jon Evans
0db46caeaf
Revert "Remove unused variable"
...
This reverts commit 745afb7246
.
Guess it isn't actually
2023-12-23 17:23:43 -05:00
Jon Evans
745afb7246
Remove unused variable
2023-12-23 16:55:32 -05:00
Jeff Young
af158715e5
Honour alternates when getting SCH_PIN description.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16407
2023-12-23 13:30:15 +00:00
Jeff Young
4bdd5e172c
Code cleanup.
2023-12-23 13:30:15 +00:00
Jon Evans
dad842d3f0
Allow no-connects on standalone hierarchical pins/ports
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16397
2023-12-22 19:08:14 -05:00
Jon Evans
7470ec80e4
Fix some issues with Font property
...
Prevent out-of-bounds access
Make sure list is initialized in symbol editor frame
Don't re-init the list more frequently than necessary
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16399
2023-12-22 18:34:48 -05:00
Jeff Young
a77ce59487
Don't clear selection on undo/redo.
...
It's annoying to the user.
2023-12-22 17:41:43 +00:00
Jeff Young
df115dbcbd
Keep selected flags on undo/redo items.
...
Also fixes a memory leak in Symbol Editor undo/redo.
Also moves a few more things to SCH_COMMIT.
Also fixes a couple of LIB_ITEM::Clone() methods that were
failing to return the same uuid.
2023-12-22 17:30:14 +00:00
Jeff Young
eca22b05b3
Restore pin selection after PlacePin().
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16401
2023-12-22 14:59:53 +00:00
Jeff Young
9910c670d2
Ignore reference and value when computing "allChecked".
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16408
2023-12-22 13:58:02 +00:00
Jeff Young
1ca82035ae
Update SCH_SHAPE::Plot() to handle all fill styles.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16429
2023-12-21 22:06:59 +00:00
Mike Williams
1700cad83b
Symbol/Footprint Chooser: remember open libraries
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/16383
2023-12-21 09:57:54 -05:00
Alex Shvartzkop
2de8991752
LTspice: bugfixes.
2023-12-21 13:56:29 +03:00
Jeff Young
7e72a53876
Check added fields only if all fields were checked before.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16408
2023-12-20 13:15:33 +00:00
Wayne Stambaugh
922aee1532
Coding policy fixes.
2023-12-20 07:17:23 -05:00
Mike Williams
bf6e6d0e11
Symbol Chooser Panel: save settings
2023-12-19 14:03:31 -05:00
Jeff Young
33a56c530d
cleanup
2023-12-19 16:48:01 +00:00
Ian McInerney
c7592758cc
Ensure some variables are initialized to known values
2023-12-19 14:32:31 +00:00
Jeff Young
cfa55d958a
performance efficiencies
2023-12-18 18:45:02 +00:00
Jeff Young
e4baf877c8
performance efficiencies
2023-12-18 18:36:02 +00:00
Jeff Young
68cbb820a7
performance efficiencies
2023-12-18 17:20:34 +00:00
Jeff Young
11805d6696
performance efficiencies
2023-12-18 17:01:55 +00:00
Jeff Young
47e07f507e
nullptr safety
...
(Can't actually happen as the 4 base fields are mandatory,
but it'll keep Coverity happy.)
2023-12-18 17:01:55 +00:00
Mike Williams
fc903592ed
Hotkeys: fix multiple assignment of N key
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/16376
2023-12-18 11:13:47 -05:00
Christian Weickhmann
2ee75b1aec
BOM Generation: Unifying reference concatenation using more pythonic string join to avoid trailing comma.
2023-12-18 14:44:12 +00:00
Wayne Stambaugh
fd91f8933e
Fix a SPICE simulator crash on run of a second OP command.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16341
2023-12-18 09:43:40 -05:00
Mike Williams
9e1ceba5d8
Symbol Fields Table: save modified presets without changes to schematic
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/16381
2023-12-18 09:28:59 -05:00
Marek Roszko
83f4597f05
Remove a unused var
2023-12-17 21:19:07 -05:00
Jeff Young
a944310f7b
Move sheet navigation commands below active tool commands.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16367
2023-12-17 22:06:47 +00:00
Alex Shvartzkop
c16db03321
Reserve strings.
2023-12-16 12:25:32 +03:00
Jeff Young
bcc823e8ff
Always leave library browse button active.
...
It's a bit of a hack, but it makes it easy for users to
switch from inferred models to specific library models.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16261
2023-12-15 13:31:09 +00:00
Mike Williams
5704b3f422
Symbol Chooser Dialog: forward chars to panel
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/16350#note_1694513334
2023-12-14 10:04:15 -05:00
Jeff Young
5709d57824
Copy 2 bug fixes from OnSizeFieldsGrid() to OnSizePinsGrid()
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16332
2023-12-14 14:45:55 +00:00
Wayne Stambaugh
8687d5092f
String and dialog layout fixes.
2023-12-13 11:49:34 -05:00
Mike Williams
6f25399469
Symbol Chooser: sort Already Placed
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/16272
2023-12-13 09:29:56 -05:00
Jeff Young
b9daa073d4
Work around wxWidgets CHAR_HOOK issue.
2023-12-13 13:16:51 +00:00
Wayne Stambaugh
9d6e9b14eb
Fix action tool friendly name string capitalization.
2023-12-13 08:15:19 -05:00
Jeff Young
035725cd5d
Fallback to normal undo when wire-drawing not in progress.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16216
2023-12-12 16:08:05 +00:00
Ian McInerney
3c0566d318
Don't allow copying markers
...
Fixes KICAD-5FQ
2023-12-11 22:22:19 +00:00
Wayne Stambaugh
484491aaea
Fix crash on save after pasting symbols in schematic editor.
...
This was caused by pasting zero length instance paths which are not valid.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16300
2023-12-11 08:29:10 -05:00
Jeff Young
518be57516
Implement ESC processing for choose symbol dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16271
2023-12-10 18:13:42 +00:00
Jeff Young
9885b7a4ef
Don't require more clicks than necessary to communicate intent.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16261
2023-12-09 17:55:59 +00:00
Jeff Young
88760f5c0e
Update pin selection flags from SCH_SYMBOL::UpdatePins().
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16281
2023-12-09 16:43:56 +00:00
Wayne Stambaugh
b7dc7e90ac
Minor string fixes.
2023-12-08 13:09:16 -05:00
Mike Williams
d8c04e4ef2
Finish Action: fix context menu for buses
2023-12-07 08:40:29 -05:00
Ian McInerney
be9c3b08b5
Fix library table file filters
...
The schematic librayr table was missing the Kicad Sexpr filter, and also
the filter inside the grid editor was never updated when the library
plugin type was changed in the grid, so a library of the new type could
not be selected.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16278
2023-12-07 11:16:02 +00:00