Roberto Fernandez Bautista
54f401c72c
Fix import of legacy stroked zone fill + add parsing of segments fills
2023-07-30 20:56:28 +02:00
Roberto Fernandez Bautista
f00a68576e
Add qa test for legacy (< v5) zone fills
...
Disable tests for .brd (legacy file format) fill for now.
2023-07-30 20:56:27 +02:00
John Beard
478df24f36
Fix fillets and chamfers when the original lines become zero-length
...
This needs the ITEM_MODIFICATION_ROUTINE to learn to delete items.
Condense the item change handlers into a single injected object
(ITEM_MODIFICATION_ROUTINE::CHANGE_HANDLER) and provide the basic
implementation that just takes some callables.
This simplifies the construction of the routines and also would make
a CHANGE_HANDLER object possible that can be reused between different
tools.
2023-07-30 15:12:28 +01:00
John Beard
da0daffa89
Remove more special-casing for fp-edit commit handling
...
In the EDIT_TOOL::ModifyLines method, there was some
remaining special-casing for FP childen commits.
One bit was put back by mistake (in
0b32ae3f4b
) because I thought I'd
left it out of the refactor. In fact it was removed slightly later in
1218f61d0a
.
THe other bit is omitting Modify commits in the FP-editor (what the
reinstatement of the above code was trying to cause). This shouldn't
be needed any more.
However, something is still incomplete here as the tools still don't
work correctly in the footprint editor. However, I don't think it's
substantially _more_ broken with the special casing removed and at
least it's less confusing.
Related to: https://gitlab.com/kicad/code/kicad/-/issues/15253
2023-07-30 15:10:30 +01:00
jean-pierre charras
d1caadeb4f
symbol editor: fix small issues:
...
* save visibility of the properties panel
* fix correct size of the properties panel after hide/show it.
2023-07-30 11:04:49 +02:00
jean-pierre charras
1548b14f84
DIALOG_LIB_SYMBOL_PROPERTIES: fix incorrect state of two wxCheckboxes.
...
When opening the dialog, m_excludeFromBomCheckBox and m_excludeFromBoardCheckBox
states were the opposite of the actual symbol property.
Fixes #15269
https://gitlab.com/kicad/code/kicad/-/issues/15269
2023-07-30 08:42:33 +02:00
jean-pierre charras
abcd753bd3
PANEL_SETUP_BOARD_STACKUP: do not try to init params managed by PANEL_SETUP_BOARD_FINISH
...
Fixes #15288
https://gitlab.com/kicad/code/kicad/-/issues/15288
2023-07-29 09:43:32 +02:00
Seth Hillbrand
018d60eb40
Fix-up for previous commit
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15217
2023-07-28 09:47:18 -07:00
Seth Hillbrand
7bd3992350
Change stale_bus_members to work around MSVC issue
...
Somehow, MSVC vector gets corrupted in certain cases. While the
mechanism is unclear, using an unordered_set avoids this problem
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15217
2023-07-28 09:35:39 -07:00
jean-pierre charras
60806edac0
Gerber export X3: fix an incorrect keyword ("route" must be "rout")
2023-07-27 20:11:04 +02:00
Mike Williams
1e66129218
Schematic: Align Elements to Grid needs to respect grid overrides
2023-07-27 10:45:27 -04:00
Mike Williams
c0a9cf2cfa
Schematic Point Editor: fix cancel of point drag
2023-07-27 10:45:27 -04:00
jean-pierre charras
db382f8782
Eeschema: Export symbols to New Library: Fix Cancel button not working
...
This bug can crash Eeschema.
Fixes #15278
https://gitlab.com/kicad/code/kicad/-/issues/15278
2023-07-27 15:14:49 +02:00
Jon Evans
d2ec4834d9
Fix macOS impl of Valid3DConnexionDriverVersion
2023-07-27 08:30:08 -04:00
Jon Evans
148e111579
Refactor pin orientation to be an enum class
...
Add various LIB_PIN properties
2023-07-26 23:46:15 -04:00
Jon Evans
000fa28ffc
Properties: initial infrastructure for symbol editor
2023-07-26 18:32:14 -04:00
Roberto Fernandez Bautista
d5fc2b757d
qa_cli: increase to 1200dpi + use 1 pixel erosion in comparisons to golden sample
2023-07-27 00:21:48 +02:00
Seth Hillbrand
96a34e5b57
Consolidate Maximum clearance calculation
...
We were calculating the same thing in three locations and we missed
adding the clearance from the footprints in, resulting in bad fills and
missed drc errors (see QA addition)
2023-07-26 12:55:48 -07:00
jean-pierre charras
5ea170baab
Symbol editor: fix crash when trying to "drag" an item.
...
Drag or move is an option of the schematic editor, and not in symbol editor.
So it cannot be tested in code for the symbol editor.
Fixes #15264
https://gitlab.com/kicad/code/kicad/-/issues/15264
2023-07-26 08:58:22 +02:00
Seth Hillbrand
812c56bdc7
Clarify NeighboringSegmentFilter
...
This doesn't affect behavior but makes the code more readable
2023-07-25 11:05:56 -07:00
Seth Hillbrand
530af96da2
Prevent null dereference
2023-07-25 10:53:05 -07:00
Seth Hillbrand
8546d417df
Prevent dereferencing end iterator
2023-07-25 10:49:35 -07:00
Kuba Sunderland-Ober
589030d672
Add the fraction numeric form glyphs.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14398
2023-07-25 16:58:16 +00:00
Mike Williams
132a0ada73
Grid Overrides: support grids-per-type that override the current grid.
...
Schematic only at this point while we test and refine.
PCB support is a future addition.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14756
2023-07-25 10:17:57 -04:00
jean-pierre charras
bd503647c6
Add fix in QA, missing in commit a16ab0aa
2023-07-25 11:05:02 +02:00
jean-pierre charras
a16ab0aae1
Replace SHAPE_T::RECT by SHAPE_T::RECTANGLE: RECT creates a collision name
...
issue with a Windows header on msys2.
Change very similar to the commit 9a47b344
about class PAD_SHAPE.
No actual code change
2023-07-25 09:11:55 +02:00
Kuba Sunderland-Ober
b8fc45b14d
Implement fontconv in Python.
...
This fixes metrics of U+1F98 (ᾘ)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14398
2023-07-24 22:23:11 +00:00
Seth Hillbrand
000998ccae
When routing, check for board-level clearances
...
If the board-level clearance exceeds the max pad/track clearance, we end
up missing collisions in the router.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15162
2023-07-24 15:19:21 -07:00
Roberto Fernandez Bautista
dadcc70a3d
Partially revert 6cb80422
...
We don't need to touch cmake for anything (avoid confusion for future Devs)
2023-07-24 21:40:06 +00:00
Alex Shvartzkop
b784b44ed0
UTF16ToWstring: stop at NUL input terminator.
2023-07-25 00:21:55 +03:00
Roberto Fernandez Bautista
6cb804228b
Fix windows build
...
core needs to be linked after wxWidgets + use wide string literals
2023-07-24 22:59:41 +02:00
Seth Hillbrand
9902250f5d
Fix a couple of issues with NAVLIB version checker
...
Need to include core lib in kiplatform for the version functions. Need
to link kiplatform into the navlib library in eeschema to load
2023-07-24 13:55:12 -07:00
Roberto Fernandez Bautista
b32f712721
Use actual KiCad "Ki" logo on splash screen
2023-07-24 22:33:05 +02:00
Seth Hillbrand
32ad42a435
Add 3dconnexion driver version check
...
Re-enable 3dconnexion driver by default as we are able to gate the
driver versions
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13362
2023-07-24 18:09:52 +00:00
Josue Huaroto
eeb74dbae9
Sort SCH_ITEM by name on paste
2023-07-24 16:37:25 +00:00
jean-pierre charras
e9f6ff4366
Simulator frame: removes * indicator for unsaved workbook after saving it.
...
Fixes #15236
https://gitlab.com/kicad/code/kicad/-/issues/15236
2023-07-24 08:55:34 +02:00
Mike Williams
7d9f791518
kicad-cli: sch bom export: fix inability to disable grouping
...
Just set --group-by default to "" (No default grouping), and drop the
additional --group option. Also fix the exclude DNP option.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/15246
2023-07-23 13:59:28 -04:00
aris-kimi
ce58208d77
Add missing licence lines in iec60664 and naming update
2023-07-23 14:12:03 +00:00
jean-pierre charras
9c5aa82d2c
QA test: disable a DRC test that generate a wxWidgets exception,
...
and is useless in this QA test
2023-07-23 16:02:50 +02:00
John Beard
0b32ae3f4b
Reinstate fp-editor-specific commit handling in fillet/chamfer tools
...
This check was omitted in the refactor of the fillet tool, and
resulted in a bug when undoing the action: the modified lines would
not be un-modified.
2023-07-23 14:48:31 +01:00
jean-pierre charras
a343cd0a24
Try to fix a QA issue (disable useless DRC tests for 2 boards)
2023-07-23 13:08:59 +02:00
jean-pierre charras
dda9d6c86c
BOARD_NETLIST_UPDATER: Minor fix
2023-07-23 13:06:31 +02:00
Alex Shvartzkop
d40e34aebe
CompoundFileReader: fix build error
2023-07-23 15:13:08 +05:00
Alex Shvartzkop
c39dfb9f05
CompoundFileReader: fix UTF16~wstring conversion on 16b wchar compilers
2023-07-23 14:55:15 +05:00
Alex Shvartzkop
430da67222
Altium PCB import: support dashed outlines (Region kind 2)
2023-07-22 22:38:05 +05:00
Josue Huaroto
8a407756c1
Change min and max zoom values
2023-07-22 14:52:54 +00:00
jean-pierre charras
8425e5a0b7
footprint.cpp::GetBoundingBox( bool aIncludeText, bool aIncludeInvisibleText ):
...
Do not include invisible fields when aIncludeInvisibleText is false.
2023-07-22 11:48:17 +02:00
jean-pierre charras
878a67ca65
BOARD_NETLIST_UPDATER: fix incorrect handling of new fields added to a Fp
...
- the new field position/rotation is now the same as its footprint parent.
- it is added to the view.
2023-07-22 10:52:49 +02:00
Alex Shvartzkop
24452f41ad
Improvements to Altium PCB/footprint importer:
...
- Support unicode footprint names
- Set default footprint text size and thickness to match KLC
- Position Reference at the top, Value at the bottom of fp bounding box
2023-07-22 08:55:53 +05:00
John Beard
a61b9f4459
Pad dialog: respect IPC maximum pad radius
...
The IPC-7351C rule (which may be IPC 7352 now), is 25%, or
0.25mm, whichever is smaller. Currently the default ratio is 25%, which
is incorrect for pads with shortest edges over 1mm.
This also means that the "25%" default is applied in one place:
previously sometimes the value came from the default set in PAD,
rather than the value set by this dialog. While the PAD default isn't
changed here, this dialog no longer relies on that value for its
behaviour.
2023-07-22 00:45:36 +01:00