haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
42,728 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

156 Commits

Author SHA1 Message Date
Alex Shvartzkop 16e3692e71 Build time optimizations. 2024-04-27 23:49:13 +03:00
Yon Uriarte b7b64d959f Performance UpdateDanglingState 
Avoid O(N^2) by spatial sorting, don't run checks if the bounding boxes
don't overlap.
A second copy is ordered by type to help classes that only want to check
a few types having to walk the whole list.
 2024-02-23 19:21:44 +00:00
Jeff Young ab34ce295f SCH_LINE_WIRE_BUS_TOOL must use GRID_GRAPHICS for lines. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16492
 2024-01-02 17:31:08 +00:00
Jeff Young a944310f7b Move sheet navigation commands below active tool commands. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16367
 2023-12-17 22:06:47 +00:00
Jeff Young 035725cd5d Fallback to normal undo when wire-drawing not in progress. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16216
 2023-12-12 16:08:05 +00:00
Mike Williams d8c04e4ef2 Finish Action: fix context menu for buses 2023-12-07 08:40:29 -05:00
Mike Williams 2795fa9ca3 EE/PCB_Actions: convert to generic Finish 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/16079
 2023-12-06 10:33:17 -05:00
Marek Roszko 22b733209d Fail GAL on its header leaking audit 
Maybe we should rethink directly accessing GAL so much, but at least 600 files didn't need GAL leaked into them due to view_overlay.h
 2023-09-18 19:52:27 -04:00
Jeff Young 0310973e3f Push TEXT_SPIN_STYLE from SCH_TEXT out to SCH_LABEL_BASE. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15444
 2023-09-07 17:42:51 +01:00
Jeff Young c981c3668a Better handling of dangling markers during bus unfold. 2023-08-05 19:30:13 +01:00
Mike Williams 132a0ada73 Grid Overrides: support grids-per-type that override the current grid. 
Schematic only at this point while we test and refine.

PCB support is a future addition.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14756
 2023-07-25 10:17:57 -04:00
Jeff Young 89780d353a Pick up snapped item's line properties. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/15192
 2023-07-15 20:22:34 +01:00
Ian McInerney 2fb6f19a84 Separate immediate and delayed action dispatch 
Using a boolean argument just leads to a lot of trailing booleans in the
function calls and is not user friendly. Instead, introduce PostAction()
to send an action that runs after the coroutine (equivalent to passing
false or the default argument), and leave RunAction as the immediate
execution function.
 2023-06-27 00:57:59 +01:00
Jeff Young 237cc7eee1 Move TestDanglingEnds() to SCH_COMMIT. 
Also fixes a bug where Convert Symbol wasn't undoable.

Also cleans up some SetModified() call no longer needed with SCH_COMMIT.

Also fixes bug where revert of a modification didn't update the screen's
RTree.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/15030
 2023-06-23 19:59:46 +01:00
Ian McInerney 19f5c16708 Ensure const-ness matches across draw wire event parameters 2023-06-21 14:06:25 +01:00
Jeff Young 30336b2fe3 Unify go-back-one-step processing for drawing tools (and router). 
Also warps mouse on all go-back-one-step operations for better feedback.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/14981

Fixes https://gitlab.com/kicad/code/kicad/-/issues/9985
 2023-06-19 17:14:32 +01:00
Jeff Young ef6866757e Treat undo as backspace and/or escape when drawing. Ignore redo. 
Undo == backspace when drawing a polygon or chained lines.  Otherwise
it's an escape.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/14961
 2023-06-16 22:08:21 +01:00
Seth Hillbrand 62f24aca1e Fix Connectivity Asserts in new COMMIT structure 
The connection graph should only be updated within the commit structure
because this is the only time the connectivity should be changed.  We
want any connectivity changes to be included in the commit as well, so
this should be stored prior to the undo/redo list mods
 2023-06-12 13:35:06 -07:00
Jeff Young 8f1b9119bf Upgrade some symbol editor stuff to SCHEMATIC_COMMIT. 
Also renames SCHEMATIC_COMMIT to SCH_COMMIT since it's not schematic-specifc.
 2023-06-09 22:41:47 +01:00
Jeff Young e698156975 Upgrade many editing actions to SCHEMATIC_COMMIT. 2023-06-09 22:41:47 +01:00
Wayne Stambaugh 831a6d55fc Fix potential stale pointer bug in schematic highlight connection code. 
SCH_CONNECTION objects are temporary and can become stale any time the
connectivity is updated.  Keeping them around to reference later is a
bad idea.  Even if the object pointer is still valid in an SCH_ITEM in
the undo/redo buffers, comparing the pointer against another pointer as
a test to see if they are the same connection is not valid.  Saving the
connection name is safe and ensures the connection is the same even if
the pointers differ.
 2023-05-16 20:06:21 -04:00
Ian McInerney 18e573d5e9 Remove stray wx include 
There is no reason to include the actual string implementation header
here.
 2023-04-12 18:57:12 +01:00
Marek Roszko aacc9746e3 Yeet the last of wxSize/wxPoint to stop leaking gdicmn everywhere 2023-02-18 22:57:18 -05:00
Seth Hillbrand e6dbca051c Force realtime connectivity on 
The pressure relief valve was not useful for common work patterns as it
forced the recalculation on many common actions such as bus expansion.
This caused it to actually feel slower than with the pressure relief
valve off.

For most schematics, realtime is now fast enough to not need the valve
and for those that are extremely complex, removing the valve helps this
run more predictably
 2023-01-20 15:17:57 -08:00
Roberto Fernandez Bautista c7f33e21f8 Extract SCH_SCREEN::GetNeededJunctions from AddJunctionsIfNeeded 2023-01-15 19:17:39 +01:00
Roberto Fernandez Bautista 22cc861c9b Remove dead code in AddJunctionsIfNeeded 2023-01-15 19:17:39 +01:00
Roberto Fernandez Bautista 7332c0c54d Move SCH_EDIT_FRAME::GetSchematicConnections into SCH_SCREEN::GetConnections 2023-01-15 19:17:38 +01:00
Jeff Young 8dc7baad3d Cleanup actions should not activate tools. It causes all manner of side-effects. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13331
 2023-01-06 22:15:20 +00:00
Jeff Young 933a5d45e1 Be more aggressive about clearing edit flags after operations. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13173

Fixes https://gitlab.com/kicad/code/kicad/issues/13385
 2023-01-05 18:08:22 +00:00
Mike Williams 389f0655cd Schematic: re-enable old break wire functionality, add slice 
Also fix break/slice wires for multiple wires. The shortcut and code
always allowed it, the context menu just didn't appear.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13163
 2022-12-19 15:55:59 -05:00
Jeff Young 5aa8f9880e Honour aQuitOnDraw flag when cancelling a segment. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12832
 2022-11-05 10:23:12 +00:00
Mike Williams 9304607624 TOOL_EVENT: make command string non-optional 
We're getting segfaults in places where this isn't checked. Also, add
some asserts so we can catch bad tool push/pop.

Removes all uses of GetCommandStr() and makes it private.
 2022-09-19 10:23:09 -04:00
Jeff Young b2a29e08a4 Improve repeat-last-item to handle unfold-from-bus. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12018
 2022-09-09 18:09:09 +01:00
Jeff Young c30a557810 ADDED netclass assignment from PCB canvas. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5975
 2022-09-03 19:29:59 +01:00
Jeff Young 5679b9dbdc Remove a few EDA_RECT instances. 2022-08-31 01:22:49 +01:00
Jeff Young 0c8787cbb9 Some more wxPoint/EDA_RECT yeeting. 2022-08-31 00:44:33 +01:00
Seth Hillbrand b736460e71 Move optional access from value() to *operator 
`value()` throws.  Where we check for existence, we don't need to use
the throwing version and should just use the unprotected variant
 2022-08-30 13:59:39 -07:00
Seth Hillbrand f1261e71d4 Replace boost::optional with std::optional 2022-08-25 15:50:47 -07:00
Jeff Young aa2ad3b44c Move KICAD_T[] to std::initializer_list<KICAD_T>. 2022-08-20 10:28:11 +01:00
Jeff Young e122dc38bd Add context menu item for clearing net highlighting. 
In selection tools, drawing tools, router tool, line_wire_bus tool.

Fixes https://gitlab.com/kicad/code/kicad/issues/11920
 2022-07-10 17:15:20 -06:00
Jeff Young bce1fd337b Second tool hotkey accepts action (ie: acts as click). 
Fixes https://gitlab.com/kicad/code/kicad/issues/11729
 2022-06-09 16:54:04 +01:00
Mike Williams 8d51b6b6d3 Schematic: Add icons for Any/90/45 angle modes 
Also add a dark mode icon for existing 45hv icon.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/11332
 2022-06-03 15:04:52 +00:00
Jeff Young 67f352717e Fix dodgy type-cast and init line-widths to "inherit". 
Fixes https://gitlab.com/kicad/code/kicad/issues/11535
 2022-05-03 13:39:14 +01:00
jean-pierre charras be6379a8f6 Fix minor Coverity and compil warnings. 2022-04-01 20:43:21 +02:00
Mike Williams 2a726a882f Schematic: new feature, force 45 degree lines 
* New modes to force 45 deg angle at beginning or end of line

* Backspace will undo most recent segment added

* / will toggle posture of 90 and 45 degree lines

* Added alg::signbit for convenience

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10869
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9175
 2022-03-28 16:07:23 -04:00
Jeff Young 05bca282f7 Re-entrancy blocker for line/wire/bus tool. 
Also clear infobar messages after a cancelInteractive.

Fixes https://gitlab.com/kicad/code/kicad/issues/11155
 2022-03-17 15:27:33 +00:00
jean-pierre charras dbfdd3fb56 Fix some Coverity warnings. 2022-03-06 09:48:33 +01:00
Mike Williams e35c3f2b99 Schematic: handle switching h/v mode better while drawing lines 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10859
 2022-02-21 17:03:43 +00:00
Jeff Young a2772b3363 Don't crash on highight net during drag. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10866
 2022-02-21 13:30:15 +00:00
Seth Hillbrand d1a4daefbb wxPoint->VECTOR2I correction for master 2022-02-19 19:14:41 -08:00