Mikolaj Wielgus
7cf5138c63
Sim: Bugfixes, mostly for MS Windows compilation errors
...
Unfortunately, Windows headers define a lot of macros for common words,
so we had to rename some enums to not collide.
We also fix some of the many bugs related to the new simulation
architecture and the Spice Model Editor dialog.
2022-07-30 02:25:34 +00:00
Marek Roszko
a8505d9c76
SEARCH_RESULT -> INSPECT_RESULT
...
To fix the name squatting it's doing for future functionality
2022-07-29 20:01:10 -04:00
jean-pierre charras
490875e222
Fix a missing call to aEvent.Skip() in commit 753f2f3
.
...
Any wxSizeEvent handler must call Skip() to propagate the event.
2022-07-29 16:46:35 +02:00
jean-pierre charras
905df71977
Fix an issue when printing bitmaps when not on wxWidgets 3.1.6 and 3.1.7
...
Commit 6e35d5473
added a hack to fix an issue on wxWidgets 3.1.6. But this hack
must by applied to 3.1.6 and 3.1.7, not to other versions.
Modify commit 048cf6df
that applied the fix to 3.1.6 only
2022-07-29 13:09:20 +02:00
jean-pierre charras
048cf6df7a
Fix an issue when printing bitmaps when not on wxWidgets 3.1.6
...
Commit 6e35d5473
added a hack to fix an issue on wxWidgets 3.1.6. But this hack
must by applied only to 3.1.6, not to other versions.
Fixes #12108
https://gitlab.com/kicad/code/kicad/issues/12108
2022-07-29 10:26:45 +02:00
Jeff Young
753f2f3e4c
Display descriptions in second column of library trees.
...
Also fixes some bugs in how the columns are sized.
Fixes https://gitlab.com/kicad/code/kicad/issues/12090
2022-07-28 14:51:47 +01:00
Seth Hillbrand
ee8116e55f
Protect against double-refresh
...
The wxtimer can fire multiple times and there exists the possiblity for
this to happen before the flags are properly set to prevent it. This
creates a concurrency mutex to skip the EDA_DRAW_PANEL_GAL refresh if
one is already underway.
Fixes https://gitlab.com/kicad/code/kicad/issues/12094
(cherry picked from commit 39dd51490d
)
2022-07-27 20:28:48 -07:00
Jeff Young
bb43d923af
Save preferences immediately (in case of future crash).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11162
2022-07-27 18:57:45 +01:00
Jeff Young
4a40d94b5a
More hotkey label cleanup.
2022-07-27 12:29:01 +01:00
Jeff Young
6e0d31b812
Improve grid tooltip.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9841
2022-07-27 12:29:01 +01:00
Jeff Young
d9d579c895
Clean strings before displaying in hotkeys list.
...
Also make sure the description column is wide enough.
Fixes https://gitlab.com/kicad/code/kicad/issues/11994
2022-07-27 12:29:01 +01:00
Mike Williams
ece9a782ac
Gerbview: unexceptional exception cleanups
2022-07-26 18:42:55 +00:00
Mike Williams
be7104c24c
Gerber Viewer: gerbview -> Gerber Viewer in Settings
2022-07-26 18:42:55 +00:00
Seth Hillbrand
2245e99a89
Apply Wayne's suggestion for better error recov
...
No need to exit the draw routine on a bad layer, we can skip that layer
and continue processing the valid elements
2022-07-26 11:06:29 -07:00
Jeff Young
c3a5947fe6
Make Scintilla paste a separate undo operation.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11756
2022-07-26 18:45:02 +01:00
Seth Hillbrand
008b4f583b
Fix typo in lib_text layer id
...
Also adds CHECK_RET to catch similar errors in the future
Fixes https://gitlab.com/kicad/code/kicad/issues/12078
2022-07-25 17:08:16 -07:00
jean-pierre charras
993c446fdf
Fix some warnings detected by PVS-STUDIO (most are not used vars)
2022-07-25 18:23:52 +02:00
Jeff Young
e10158ff10
ADDED show pin names on footprint pads when assigning to symbol.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4576
2022-07-24 23:41:41 +01:00
Jeff Young
582c133835
CSV escaping.
2022-07-24 23:41:41 +01:00
Jeff Young
6eada34f41
Use "Cancel" for cancel semantics, even when affirmitave to question.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11983
2022-07-24 08:47:01 +01:00
Jeff Young
74b9ff5865
Don't specify a severity when traversing the filtered list.
2022-07-24 08:41:02 +01:00
Jeff Young
def87c969e
Redo the pinned-libraries storage architecture.
...
1) always use preferences directly
2) allow nicknames from either preferences or project
3) store-after-modify
Fixes https://gitlab.com/kicad/code/kicad/issues/12000
Fixes https://gitlab.com/kicad/code/kicad/issues/11892
2022-07-22 09:31:10 +01:00
Marek Roszko
47fe8ff8eb
bitmaps and template are resources.
2022-07-21 20:14:10 -04:00
luz paz
79fa911e0e
Fix various typos
...
Found via `codespell -q 3 -S *.po,./thirdparty,./Documentation/changelogs -L aactual,acount,aline,alocation,alog,anormal,anumber,aother,apoints,aparent,aray,ba,busses,dout,einstance,leaded,modul,ontext,ot,overide,serie,te,,tesselate,tesselator,tht`
2022-07-21 16:31:41 +00:00
Jeff Young
7386e64923
Attempt to work-around wxWidgets bug with Serbian & Russian locales.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12002
Fixes https://gitlab.com/kicad/code/kicad/issues/11963
2022-07-20 17:52:48 +01:00
Jeff Young
e5a664c6b3
Try a slightly different tack for cancelling net highlighting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12029
2022-07-19 10:31:49 +01:00
Seth Hillbrand
0335df77fa
Ensure global tooltip is created for each app
2022-07-18 17:08:48 -07:00
dsa-t
e2e574c84d
Fix a mistake in EDA_RECT::Intersects.
2022-07-18 18:51:52 +00:00
Jeff Young
b727bfc16d
Performance: avoid sqrt at all costs.
2022-07-16 18:42:32 +01:00
Alex
ebbfc25420
Don't evaluate arguments passed to KI_TRACE if tracing is disabled.
2022-07-16 17:35:22 +00:00
Jeff Young
d0547cbde7
Don't allow 0 line-width for unfilled shapes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12010
2022-07-16 16:26:05 +01:00
Seth Hillbrand
db4f2d9dd8
Catch some crashes on shutdown
...
These can happen when a tool is active that sends signals when exiting
(e.g. deselectEvent). These may be caught by the active loop in another
tool which might try to update the UI after it has been freed. By
marking all tools as "shutdown", the only event returned to them should
be null. As an extra precaution, we flag the shutdown globally within
the tool manager and check this flag before launching either events or
new tools
Fixes https://gitlab.com/kicad/code/kicad/issues/10698
2022-07-15 16:56:01 -07:00
Seth Hillbrand
b792a3f3f5
Add angle display to line drawing
...
Helpful to see what angle you are at when setting graphic lines
2022-07-15 12:03:11 -07:00
Seth Hillbrand
bed38d2fc8
Stroke, don't fill fonts in preview
...
Fixed new vector-style font display to avoid the non-closed polyline
fills that make it hard to read the proper text
Fixes https://gitlab.com/kicad/code/kicad/issues/11781
2022-07-15 11:58:33 -07:00
Seth Hillbrand
595e5cb3f2
Add sort feature to pre-defined list
...
Board setup rows should be sortable when inserting new elements. They
get sorted when saving, this keeps that representation while editing
Fixes https://gitlab.com/kicad/code/kicad/issues/12015
2022-07-15 11:16:15 -07:00
Seth Hillbrand
9faff78258
Keep the reset text correct
...
Ensures that after setting the initial dialog page, we also set the
proper text in the reset button as the event does not get fired
Fixes https://gitlab.com/kicad/code/kicad/issues/11856
2022-07-14 14:19:09 -07:00
Seth Hillbrand
93fb00d815
Protect the Kiway dereference
...
Also find a few more places where we are reaching into a new frame to
perform actions that need to have dialogs closed.
Running actions should also wait for the next cycle rather than being
immediately executed when we are calling into a new frame. This allow
for the cleanup actions onClose() to happen prior to the next action
starting
Fixes https://gitlab.com/kicad/code/kicad/issues/11891
2022-07-14 11:37:45 -07:00
Mike Williams
d44e34d513
Images: Add full properties editor
...
Converts dialog_image_editor to panel_image_editor. Embeds this panel in
a new properties dialog for the schematic and PCB editors that allows
editing position, layer, locked status, etc. like other items.
2022-07-14 11:23:23 +00:00
Mike Williams
99f8b21ed1
PCB: Add bitmap layer per board layer
2022-07-14 11:23:23 +00:00
Mike Williams
3669cb4673
PCB Editor: Add User Background Images
2022-07-14 11:23:23 +00:00
Mike Williams
cbc3bfbf08
GAL: Re-enable OpenGL bitmap cache
...
Might still have issues, re-enabling for wider test.
2022-07-14 11:23:23 +00:00
Mike Williams
3e80963482
GAL: Delete no-effect target changes
2022-07-14 11:23:23 +00:00
Seth Hillbrand
b5bf1da251
Keep track of blocking windows
...
Allows the calling KiWAY player to send messages to the blocking window
before signaling a separate call
Fixes https://gitlab.com/kicad/code/kicad/issues/11891
Fixes https://gitlab.com/kicad/code/kicad/issues/11772
2022-07-13 19:25:24 -07:00
Seth Hillbrand
86ac77258f
Don't clear our mutex when drawing
...
The (lite) mutex protects DoRePaint() from reentry but this breaks if it
is cleared by a timer.
Fixes https://gitlab.com/kicad/code/kicad/issues/12003
2022-07-12 20:10:46 -07:00
jean-pierre charras
1a5b0d7e39
Rework on bitmap_info.cpp cmake build process.
...
on gcc 12.1 / msys2 the large initialized list in bitmap_info.cpp breaks
the compiler (perhaps a bug in the compiler).
So, as workaround, the initialization sequence is modified.
2022-07-12 16:48:48 +02:00
Jeff Young
57acce9e55
Share more code between selection tools.
2022-07-11 19:04:08 -06:00
Seth Hillbrand
3081023b5e
ADDED: Minimum copper connection width DRC check
...
Checks all copper connections in each net/layer for minimum width
setting.
Fixes https://gitlab.com/kicad/code/kicad/issues/9870
2022-07-11 19:26:56 +00:00
Jeff Young
e122dc38bd
Add context menu item for clearing net highlighting.
...
In selection tools, drawing tools, router tool, line_wire_bus tool.
Fixes https://gitlab.com/kicad/code/kicad/issues/11920
2022-07-10 17:15:20 -06:00
Jeff Young
eb27a3f8b9
Added pinning support to various EDA_LIST_DIALOGs.
...
Footprint Save As, Symbol Save As, etc.
2022-07-09 20:44:49 -06:00
Jeff Young
05219e4d9a
Add pinned library support to Choose Symbol and Choose Footprint.
2022-07-09 20:06:31 -06:00
Jeff Young
190fb23e88
Add pinned library support to Footprint and Symbol Viewers.
...
Also includes adding libraray and symbol filters to Symbol Viewer.
2022-07-09 17:41:10 -06:00
Jeff Young
120c5b9ac1
Reimplement pinning now that we're no longer sorting on score.
2022-07-09 12:26:44 -06:00
Jeff Young
0953395c87
LIB_SHAPE slightly abuses SHAPE_POLY_SET by using it for line chains.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11956
2022-07-08 21:35:40 -06:00
Jeff Young
62cef3d830
Add LAYER_PRIVATE_NOTES for private text & graphics in symbol editor.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11957
2022-07-08 17:27:05 -06:00
jean-pierre charras
d90a2cc6b5
tread_pool: create it on the heap, because creating it static generate a DTOR issue on mingw.
...
When built with mingw, the tread_pool DTOR is probably called too late, and treads are
not cleaned correctly, and the application hangs on exit.
2022-07-08 19:07:21 +02:00
Marek Roszko
7473528cf4
Ensure user paths are created early
...
Fix #11962
2022-07-05 20:47:53 -04:00
Mike Williams
193248e202
Hotkeys: show user config for unloaded KiFACEs
...
Otherwise, only the default hotkeys will be listed.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10687
2022-07-05 13:37:45 +00:00
jean-pierre charras
16667717a2
Pcbnew, printing in B&W: never draw the background color.
...
Otherwise a black background is printed.
Fixes #11625
https://gitlab.com/kicad/code/kicad/issues/11625
2022-07-04 12:00:44 +02:00
Seth Hillbrand
907d8fc018
Revert "Fix Swatch sizes"
...
This reverts commit 25c3a4681f
.
Windows default sizes are too big when they are the correct size on
Linux. We need the DU scaling for swatches
2022-07-01 11:37:55 -07:00
Seth Hillbrand
25c3a4681f
Fix Swatch sizes
...
The swatches are surrounded by non-scaling icons. We should not scale
the swatches unless we also scale the icons. This patch makes all
elements in the appearance panel equally non-scaling
This relates to https://gitlab.com/kicad/code/kicad/-/issues/11880
2022-07-01 10:56:13 -07:00
jean-pierre charras
1598ce762b
bitmap_info.h: move g_BitmapInfo initialization to bitmap_info.cpp.
...
The main purpose is to make changes in g_BitmapInfo more easy.
Although it is automatically generated, it is sometime more easy to modify
it by hand (the recreation of bitmaps stuff is time consumming), especially
during testing.
2022-06-30 13:00:37 +02:00
Jeff Young
b512d64148
Naming conventions.
2022-06-29 07:34:46 -06:00
Jeff Young
dbbdc9d2e6
Don't rely on the penWidth already being set when setting the dash style.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11908
2022-06-29 07:34:45 -06:00
Mike Williams
64b89639cf
PCB Editor: Make Ctrl-Click net highlighting configurable
...
Defaults to ctrl-click is exclusive or selection like other
applications. Footprint editor can only be exclusive or.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10810
2022-06-28 16:29:14 +00:00
Seth Hillbrand
89eeba3312
Correct WX check for DPI handler calls
2022-06-27 13:34:39 -07:00
jean-pierre charras
4be4c5f4a1
Avoid compil warning (when possible) about deprecated GetArchName() in wx >=3.1.5.
...
Use GetArchName() in wx >= 3.1.6.
2022-06-25 11:25:45 +02:00
Seth Hillbrand
03c279ffd4
ADDED: Threadpool
...
Thread pools are long-lasting executors that have close to zero overhead
when launching new jobs. This is advantageous over creating new threads
as we can use this for threading smalling jobs and smaller quanta. It
also avoids the heuristics needed to determine the optimal number of
threads to spawn
2022-06-24 22:59:24 +00:00
Seth Hillbrand
a118f20464
Hide cursor while warping on Wayland
...
Based on https://gitlab.freedesktop.org/xorg/xserver/-/issues/734 we
hide the window cursor prior to warping, which allows XWayland to
reposition the cursor. This is only performed when Wayland is detected;
all other configurations call the standard warp routine
Fixes https://gitlab.com/kicad/code/kicad/issues/9785
2022-06-24 09:56:43 -07:00
Seth Hillbrand
7b9dc1b9f0
Fix Eeschema Arc plotting
...
The start/end point plotting is not reliable for eeschema. We need to
preconvert to angles to get the correct winding as the default plotter
conversion in the PLOTTER class makes pcbnew-based assumptions
Fixes https://gitlab.com/kicad/code/kicad/issues/11885
2022-06-22 16:46:28 -07:00
Seth Hillbrand
a852286eb5
Cleanup compile warnings
2022-06-21 17:04:56 -07:00
Fabien Corona
976670e987
Move 3D controls to a new class
2022-06-21 23:38:22 +00:00
Miklós Márton
f2382a7bd1
Add Make selected active/inactive actions to the symbol libraries
...
context menu
Fixes #11372
2022-06-21 23:32:02 +00:00
Seth Hillbrand
67d9729311
Treat all units equally when converting to string
...
Excessive trucation in mils can lead to data loss when round-tripping
values. Better to keep decimal count consistent between units
Fixes https://gitlab.com/kicad/code/kicad/issues/11878
2022-06-21 15:21:57 -07:00
Zoltan Puskas
1c04eb6d0e
Fix -Wuninitialized warning in tool manager
...
Fixes #11866
https://gitlab.com/kicad/code/kicad/-/issues/11866
2022-06-20 22:40:42 +00:00
Jeff Young
231ac567b8
Bug fixes for printing vias.
...
Blind/buried and microvias didn't get their layers trimmed properly,
nor did through vias with dropped pads.
Fixes https://gitlab.com/kicad/code/kicad/issues/11851
2022-06-19 11:58:21 +01:00
jean-pierre charras
6f05bb9a83
EDA_TEXT::printOneLineOfText(): fix incorrect line thickness calculation.
...
(It was not the same as the one used to draw texts)
Fixes #11849
https://gitlab.com/kicad/code/kicad/issues/11849
2022-06-18 09:31:14 +02:00
Jeff Young
97b0005780
More caching for DRC.
...
Also fixes a bug where some physical clearance tests would be run even
if the clearance was 0 (or if the rule was set to IGNORE).
2022-06-17 23:58:31 +01:00
jean-pierre charras
f20cb0fda8
Activate teardrops: remove advanced config option and add teardrop keywords in files. (the ability to read teardrop keywords was added some time ago)
2022-06-17 19:42:27 +02:00
jean-pierre charras
c2707e0c8d
Add some missing icons.
2022-06-17 17:51:19 +02:00
Jeff Young
a7cb985b80
Don't allow PCBNew netclass cols in Eesceham and vice versa.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11804
2022-06-13 21:28:35 +01:00
jean-pierre charras
fa5150b05f
Add bitmaps paste_special to context menu.
2022-06-13 14:40:21 +02:00
Jeff Young
52bc2511cd
Add a radioButton mode to IMAGE_BUTTON.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11797
2022-06-12 20:09:46 +01:00
Jeff Young
f22cf1cc3a
Fill in missing bits of LAYER variable for printing/plotting.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11788
2022-06-10 22:38:01 +01:00
Seth Hillbrand
4790257616
Don't break alphabetical sorting on search
...
When using the "Filter" search for footprints/symbols, the least
surprising outcome is that the window filters the existing
(alphabetically sorted) list but does not change the display order based
on scoring.
This also needs to adjust the fix for
https://gitlab.com/kicad/code/kicad/-/issues/259 as that assumed the
selected element would be the first below the group (not the case if we
are sorting alphabetically)
Fixes https://gitlab.com/kicad/code/kicad/issues/11746
2022-06-10 11:48:47 -07:00
dsa-t
3a76435eda
OpenGL: Use glGetProgramiv instead of the extension function.
2022-06-09 19:37:42 +00:00
Jeff Young
bf71cada4e
ADDED: User viewports for 3D viewer.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5724
2022-06-06 22:24:02 +01:00
Jeff Young
244042ce51
Keep footprint selection in Symbol Chooser history list.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/1841
2022-06-06 22:24:02 +01:00
jean-pierre charras
9f38fa43cd
Fix some minor compil and Coverity warnings.
2022-06-05 11:44:49 +02:00
Jeff Young
dd2e12bdf1
Formatting.
2022-06-04 22:22:55 +01:00
jean-pierre charras
bb2fc2860a
Pcbnew, physical layer names: never translate them (they are proper noun)
...
physical layer names are not translated in files, but they were translated
in UI. Using these translated names can create issues and misunderstanding for users.
Now physical layer names are seen as proper nouns and are never translated.
Fixes #11715
https://gitlab.com/kicad/code/kicad/issues/11715
2022-06-04 11:02:23 +02:00
Jeff Young
d0023add81
Code clarity.
2022-06-03 23:27:10 +01:00
Roberto Fernandez Bautista
41bf397d24
CADSTAR Schematic: Fix parsing of ATTRCOLORS.
...
Apparently there can be a `INVISIBLE` token. Unclear what it means,
but lets read it anyway
2022-06-03 23:07:12 +02:00
Jeff Young
7ede2c70bd
Performance enhancements for hotkeys.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11592
2022-06-03 00:36:33 +01:00
Mike Williams
857990a883
Hierarchy: turn into a left side pane
...
Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
Jon Evans
f4372a2de9
UNIT_BINDER should support long long ints
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10870
(cherry picked from commit eb1164fc93
)
2022-05-31 21:54:51 -04:00
Jeff Young
abba1b04bd
Add "Enter Sheet" to Sheet tool (context menu & double-click).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11531
2022-05-30 14:08:26 +01:00
Jeff Young
5cae4cf918
Give zoom tool its own menu.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/11702
2022-05-30 11:44:02 +01:00
Jeff Young
5c3b6980a5
Tooltip for bounding boxes.
2022-05-29 21:30:14 +01:00
Mike Williams
dabd42bbc4
Schematic: Automatic Symbol Annotation
2022-05-27 15:54:00 +00:00
Seth Hillbrand
c0a9a02591
Handle settings sequencing
...
Avoids crash when window close ordering places 3d viewer after the
common settings are closed
2022-05-25 16:56:54 -07:00