Wayne Stambaugh
5d028b82ed
Eeschema: tool tip improvements.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6708
2020-12-11 13:42:50 -05:00
Wayne Stambaugh
dd4298bb94
Coverity fixes: 280374, 313611, 313648, 313649, and 314720.
2020-12-11 13:29:52 -05:00
Jeff Young
224697d0b3
Sheet navigator tooltip.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6680
2020-12-11 16:43:55 +00:00
Jeff Young
73b7b104cd
Fix some issues with Infobar sizing.
...
This also commits to the new strategy as it wasn't really compatible
with if-def-ing anymore.
2020-12-11 12:39:40 +00:00
Jeff Young
ee6f37bdc7
Headings and groupings for ERC severities.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6673
2020-12-09 22:19:06 +00:00
Wayne Stambaugh
e61f768fbc
Eeschema: add defensive code to symbol library cache I/O.
2020-12-09 11:46:10 -05:00
Marek Roszko
ad1aae40ec
Unify the saved file strings
2020-12-08 19:49:47 -05:00
Jeff Young
f29f052aa7
Update an outlier from the component -> symbol rename.
2020-12-08 18:30:14 +00:00
Jeff Young
b26a5972c5
LIB_TREE's SetFocus() override no longer getting called.
...
The KIPLATFORM stuff forces focus, but not through the SetFocus()
call.
Fixes https://gitlab.com/kicad/code/kicad/issues/6657
2020-12-08 17:46:10 +00:00
Jeff Young
c611f62ade
Get rid of annoying double-draw when choosing a new symbol.
2020-12-08 15:27:50 +00:00
Jeff Young
34be4b4666
Cleanup.
2020-12-08 15:27:43 +00:00
Jeff Young
d1a9efa5fc
Try out an animating, obscuring infobar.
2020-12-08 15:05:35 +00:00
Marek Roszko
cbda1d7bf1
Remove more vestiges of old colored msg panel messages
2020-12-08 00:50:25 -05:00
Marek Roszko
b45eb56ddf
Cleanup some msg panel usage using the no longer support colors
...
The color was being passed to the aPadding param now.....
2020-12-08 00:34:36 -05:00
Marek Roszko
abb5cb8310
Fix up msg panel status on save slightly
...
- pcbnew should use status bar on success like eeschema
- Add a helper to clear msgpanel and set it in one go to avoid redraw delays due to doing processing in between
2020-12-08 00:28:07 -05:00
Wayne Stambaugh
ac32d6a4b6
Symbol editor: add tool tip to clarify interchangeable symbol units.
2020-12-07 17:52:01 -05:00
Jeff Young
893f1bb4c1
Clear view before deleting part.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6658
2020-12-07 15:49:57 +00:00
Jeff Young
78129aabeb
Fix another case of 413ff4525b
.
2020-12-07 14:25:55 +00:00
Jeff Young
59527dff2a
Add infobar for derived symbol editing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6439
2020-12-06 22:44:30 +00:00
Jeff Young
ad281f7538
Remove duplicated TestDanglingEnds routines.
...
Also adds a changedItemHandler so that the single remaining version
can update the view.
Fixes https://gitlab.com/kicad/code/kicad/issues/6581
2020-12-06 21:24:16 +00:00
Jeff Young
4f90c03c7d
Allow snapItem to be re-activated.
...
Don't clear until another snapPoint is chosen. This allows line
snapping to re-appear when they move back in range.
Fixes https://gitlab.com/kicad/code/kicad/issues/5973
2020-12-05 23:57:33 +00:00
Jeff Young
a3406e7514
Make snapping more predictable.
...
In particular, allow grid positions to override line snapping if
they're a better match (and do this independently on x and y axes).
We already allow a nearer anchor to override, but that should be
based on a cartesian distance rather than independent axes.
Fixes https://gitlab.com/kicad/code/kicad/issues/6626
2020-12-04 22:50:30 +00:00
Jeff Young
9ece90a541
Fix off-by-one error in exporting netlist, and update testcases.
...
The golden file update entails the change to no-connects as well as
the introduction of natural number ordering.
2020-12-04 19:37:55 +00:00
Jeff Young
7b347d793b
Change gears on no-connect net generation. See bug rpt.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6534
Fixes https://gitlab.com/kicad/code/kicad/issues/6615
2020-12-04 18:25:48 +00:00
Jeff Young
2050e05944
Formatting.
2020-12-04 14:48:48 +00:00
Franck Jullien
8d72a768e0
eeschema/intersheet: add print and plot functions
2020-12-04 14:46:42 +00:00
jean-pierre charras
c47871e775
EDA_BASE_FRAME::ShowInfoBarMsg: add option to show a close button.
...
Same for EDA_BASE_FRAME::ShowInfoBarError and EDA_BASE_FRAME::ShowInfoBarWarning
2020-12-04 14:45:14 +01:00
Peter Montgomery
821128cb8e
Eeschema: Make auto-decrementing net labels stop at zero
...
CHANGED: If you set the auto-increment value to a negative number,
created a net label and hit the insert key, when the name got below zero,
the net labels tried to go negative but created bad labels instead.
Now the code caps decrementing at zero, warns users when it has
happened, and explains why.
Fixes https://gitlab.com/kicad/code/kicad/issues/6537
2020-12-04 12:48:32 +00:00
Jeff Young
e882753ebf
Grid snapping fixes.
...
1) Uniformly honour the GAL grid snap settings
2) Make more uniform use of GRID_HELPERs
3) Smarten EDIT_LINE for mid-point snapping
Fixes https://gitlab.com/kicad/code/kicad/issues/6558
2020-12-03 19:55:58 +00:00
Jeff Young
a19028a396
Hook up EE_GRID_HELPER to some more tools.
...
Also implements EE_GRID_HELPER layers so that connectable things
snap to connectable things and graphics snap to graphics.
Fixes https://gitlab.com/kicad/code/kicad/issues/5641
2020-12-03 15:16:34 +00:00
Jeff Young
e79df4a3ed
Formatting.
2020-12-03 15:16:34 +00:00
Wayne Stambaugh
fd3348690d
Symbol editor: enable save command when only libraries are modified.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6445
2020-12-03 08:17:09 -05:00
jean-pierre charras
cf6620f8fa
eeschema: DIALOG_SYMBOL_PROPERTIES: fix crash when working on a old .sch file
...
Old .sch files do not store the symbol part description (stored in a cache lib)
So when using a .sch file, the part description can be not existing.
The fix tests for non existing part description.
Fixes #6580
https://gitlab.com/kicad/code/kicad/issues/6580
2020-12-03 10:45:47 +01:00
Marek Roszko
e5f340d176
Use monospace (teletype) font in show simulator netlist
...
May need fixing again for gtk (see #6587 )
2020-12-02 19:27:10 -05:00
Jeff Young
43fe228367
Hook up a bit more of the EE_GRID_HELPER.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5985
2020-12-02 23:18:33 +00:00
jean-pierre charras
64f555079a
Code cleanup related to zoom:
...
- remove outdated code or comment coming from old drawing code using wxDC
- move zoom values lists to zoom_defines.h
- fix incorrect zoom max and min values (gal scaling factor limits).
2020-12-02 18:35:28 +01:00
jean-pierre charras
fcce62f0a4
cleanup related to zoom definitions
2020-12-02 18:35:27 +01:00
Jon Evans
b7564f6f05
Don't modify RTree while iterating over it
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6582
2020-12-02 12:33:08 -05:00
Jeff Young
8d3d648975
Update Change Symbols dialog to Update/reset terminology...
...
... as used in the Change Footprints dialog.
2020-12-02 14:27:43 +00:00
Jeff Young
3d7c26b6bd
Get fields out of SYMBOL, not LIB_PART.
...
Also make sure the match-mode is initialised before we try and fetch
all the field names.
Fixes https://gitlab.com/kicad/code/kicad/issues/6589
2020-12-02 14:27:43 +00:00
Jeff Young
d8fa37d5c2
Remove old root-schematic hacks. They don't work anymore anyway.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6583
2020-12-02 14:27:43 +00:00
jean-pierre charras
71ab42e60a
Minor fixes and cleanup related to zoom definitions.
...
Mainly move 2 define relative to Zoom from convert_to_biu.h to zoom_defines.h.
Will make some changes/fixes in zoom code more easy.
2020-12-02 10:14:35 +01:00
Jon Evans
05609dbc1d
Update screen r-tree after mirror operation
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6549
2020-12-01 19:19:12 -05:00
Jeff Young
df262eaa06
Make prev/next marker work reliably on all platforms.
...
Requires us to move from arrow-keys to our own commands (the only
way that the OSX wxWidgets impl doesn't eat the keys when the dataVIew
has focus).
While there we might as well add a command to exlucde markers.
ADDED Prev Marker, Next Marker, Exclude Marker
Fixes https://gitlab.com/kicad/code/kicad/issues/6575
Fixes https://gitlab.com/kicad/code/kicad/issues/5501
2020-12-01 22:37:07 +00:00
Jeff Young
3c521942ed
Smarten isEmpty checks to include nothing-but-whitespace.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6567
2020-12-01 16:39:06 +00:00
Ian McInerney
aa09418a14
Fixup memory lifespan of GAL options for the settings preview canvas
...
The canvas keeps a reference to the settings object, so we
can't pass one from the stack because it runs into lifetime
issues.
Also cleanup some loop-iterator problems.
Fixes https://gitlab.com/kicad/code/kicad/issues/6338
2020-12-01 01:12:07 +00:00
Seth Hillbrand
56fa5a23c3
SPICE export full precision data
...
Saving csv files loses precision when time/data steps are smaller than
10^-6. This switches to engineering notation when dealing with higher
precision.
Ref KiCad Services ticket 281
(cherry picked from commit 938859f10a
)
2020-11-30 13:27:38 -08:00
Jeff Young
3ad5bce67f
Rewrite connected-lines dragger to not use EDA_ITEM flags.
...
We had some spurious bugs where both ends would get dragged to a
single point (making them disappear). While I never caught it
in the debugger, I'm guessing that the flags weren't getting
cleared properly or were getting overwritten or something. Anyway,
it now uses std::pair instead.
Fixes https://gitlab.com/kicad/code/kicad/issues/6550
Fixes https://gitlab.com/kicad/code/kicad/issues/6431
2020-11-30 19:30:03 +00:00
Roberto Fernandez Bautista
b1270bc9ab
eeschema page numbers: match print and plotting ordering to page number ordering
...
- new function SCH_SHEET_LIST::SortByPageNumbers() which uses SCH_SHEET::ComparePageNum for the sorting algorithm
- SortByPageNumbers() is called after every call to BuildSheetList()
2020-11-30 16:49:33 +00:00
Roberto Fernandez Bautista
9380d6f533
eeschema page numbers: match ordering in hierarchy navigator to sheet page number ordering
...
- update hierarchy navigator after any modifications to the SCH_EDIT_FRAME
- do not generate ghost selection events after updating hierarchy tree
- use Human Readable path in SCH_EDIT_TOOL::EditPageNumber
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5760
2020-11-30 16:49:33 +00:00
Roberto Fernandez Bautista
afcaa60faa
Remove "Order" field hack (partly reverts da1a89fc
)
2020-11-30 16:49:33 +00:00
Jeff Young
3a9a6e22bc
Fix issues in reporting netclasses.
...
1) make sure we get the default netclass when we want it
2) escape for HTML (particularly important for "<invalid>", but also
for reporting user rule names, netclass names, etc.)
2020-11-30 14:38:06 +00:00
Jeff Young
3da0ab1a9a
Fix a couple of bugs in intersheet references.
...
1) init reference pages before trying to draw the SCH_FIELDs when
turning intersheet references on
2) don't double redraw because we accidentally cleared the last
hover item on a non-mouse-moved event.
3) make sure the root sheet gets a name for the hypertext menu.
2020-11-29 16:53:18 +00:00
jean-pierre charras
56bb91b042
French translation update
2020-11-29 13:40:48 +01:00
jean-pierre charras
09a1137f11
Fix a minor compil warning
2020-11-29 13:06:44 +01:00
Jeff Young
9922b7b738
Redraw canvas after preferences. (Needed for grid changes, etc.)
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6433
2020-11-29 10:57:45 +00:00
Michael Kavanagh
becc811775
Make path substitutions grid read only in lib table dialog
...
Fixes https://gitlab.com/kicad/code/kicad/issues/5624
2020-11-29 09:51:53 +00:00
jean-pierre charras
ebf0cb3612
symbol viewer: fix closing issue when opened in modal mode
...
Fixes #6509
https://gitlab.com/kicad/code/kicad/issues/6509
2020-11-29 09:38:42 +01:00
Sylwester Kocjan
095102614f
Eeschema: Fix non-visible source types in SPICE model dialog
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6540
2020-11-29 07:39:37 +00:00
Roberto Fernandez Bautista
6a28d6af27
CADSTAR Schematic Archive Importer: Fix loading of Schematic Sheet Pins and Orientation of Labels
...
- Find the intersection between the wire and the sheet and place the sheet pin there
- Fix orientation of hierarchical labels and global labels by applying opposite orientation to the connecting wire
2020-11-28 17:18:17 +00:00
Roberto Fernandez Bautista
ba77bf662c
CADSTAR Schematic Importer: Fix loading of buses
...
Place bus labels and correctly group nets for the bus in a BUS_ALIAS
2020-11-28 17:18:17 +00:00
Roberto Fernandez Bautista
0691e942f4
CADSTAR Archive Importer: Fix duplicate KIID for loaded elements
...
Don't use clone to copy an EDA_ITEM. Use Duplicate().
Even if you give the clone a new KIID, all its children will still be clones.
Create Duplicate() in LIB_PART
2020-11-28 17:18:17 +00:00
Roberto Fernandez Bautista
d2fbe12cfd
CADSTAR Schematic Archive Importer: Parse SCALE token in Symbol and warn user this is not supported
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6463
2020-11-28 17:18:17 +00:00
Roberto Fernandez Bautista
a058e26ddc
CADSTAR Schematic Archive Importer: Fix Loading of page numbers
...
Need to keep track of the hierarchy path in order to assign the page number
2020-11-28 17:18:17 +00:00
Roberto Fernandez Bautista
cba45ea257
CADSTAR Schematic Archive Importer: Fix orientation of components
...
- Fix the logic for the orientation of mirrored components
- Fix loading of angles/orientations from earlier versions of CADSTAR
2020-11-28 17:18:17 +00:00
Roberto Fernandez Bautista
49a2926a34
CADSTAR Schematic Archive Importer: Fix loading of graphical arc segments
...
Load the arc segments as piece-wise straight segments
2020-11-28 17:18:17 +00:00
Roberto Fernandez Bautista
71f9847601
CADSTAR Archive Importer: Only load the Master variant
2020-11-28 17:18:17 +00:00
Roberto Fernandez Bautista
f2ba9f7ac3
CADSTAR PCB Archive Importer: Correctly load the pad numbers as per the original design
...
To load the pad numbers correctly we need to also check the PART DEFINITION for each component
2020-11-28 17:18:17 +00:00
Roberto Fernandez Bautista
73ad503db3
CADSTAR Schematic Archive Importer: Parse missing TERMATTR node
2020-11-28 17:18:17 +00:00
Jeff Young
13c63e3a50
Clearer warning about not back-annotating footprint deletes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6521
2020-11-26 19:30:16 +00:00
Jeff Young
fc2bdc49de
Once more into the depths of hell... er, I mean fix a focus issue.
...
So the new steals-focus protection stuff works well when there's a
focused control, but not as well when there's a modal dialog up which
happens not to have a focused control (or worse, a focusable control).
This adds a second mechanism for also checking to see if a modal dialog
is up (something that wxWidgets, true to form, makes very difficult).
Fixes https://gitlab.com/kicad/code/kicad/issues/6520
2020-11-26 16:47:40 +00:00
Jeff Young
c85ef8eb69
Make updating netnames in backannotate more discrete.
...
Trying to be too smart was producing unexpected results.
Fixes https://gitlab.com/kicad/code/kicad/issues/6480
2020-11-25 22:16:56 +00:00
Ian McInerney
d50d728d19
Cleanup compiler warnings
2020-11-25 00:08:09 +00:00
Jeff Young
71ce00c5ce
Allow rotation of a single graphic line.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6487
2020-11-24 23:40:53 +00:00
Jeff Young
9c7c05c161
Mostly formatting cleanup but a few type-casting cleanups too.
2020-11-24 22:16:41 +00:00
Jeff Young
050d9e37ec
Fix rotation bugs in Eeschema.
...
Rotate text using the Rotate90() function which gets the orientation
right.
Also, when calculating the center point for rotation, don't include
labels if the selection contains other stuff. It just makes the
rotation odd, and tends to cause walking when continuing to rotate
(due to keep-upright being non-symmetrical).
Fixes https://gitlab.com/kicad/code/kicad/issues/git
2020-11-24 18:19:35 +00:00
Jeff Young
44850e9409
Fix nullptr crash.
2020-11-24 14:13:03 +00:00
Jeff Young
253f41c4f2
Fix minor dialog layout issue.
2020-11-23 23:57:26 +00:00
Jeff Young
78b505f36a
Count head and tail lists as well.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6461
2020-11-23 23:54:54 +00:00
Jeff Young
bf04fc3b72
Process all symbol instances as the ref, value, etc. may be different.
...
Also makes sure that the instance fields get set for reference, value
and footprint, and not just the base SCH_FIELD.
Also makes the translations easier.
Fixes https://gitlab.com/kicad/code/kicad/issues/6459
2020-11-23 22:09:15 +00:00
Wayne Stambaugh
e91a5b3f81
Symbol editor: prevent derived symbol elements from being moved.
2020-11-23 15:46:03 -05:00
Jeff Young
5f8a8c6850
Read/write "no net" (0) for pins with a no-connection marker.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2273
Fixes https://gitlab.com/kicad/code/kicad/issues/5587
2020-11-23 19:47:55 +00:00
Jeff Young
c94001839b
Minor performance improvements to connection graph.
2020-11-23 19:47:55 +00:00
jean-pierre charras
976c6262f4
French translation update (fix also trailing spaces in a few sentences)
2020-11-23 11:42:25 +01:00
Jeff Young
dd60fd47b2
Cleanup and formatting.
2020-11-23 01:10:08 +00:00
Jeff Young
baac9bfbf8
Don't try and rename lib entry when symbol is from board.
2020-11-22 15:40:44 +00:00
Jeff Young
1f5831185e
Fix rotation of multiple global labels with intersheet references.
2020-11-21 23:44:26 +00:00
Jeff Young
a9271e43cc
Read global fieldNameTemplates for project but don't write them.
...
Writing responsibility goes to the preferences dialog handler.
Fixes https://gitlab.com/kicad/code/kicad/issues/6450
2020-11-21 23:10:54 +00:00
Jeff Young
3a4bd6fb8b
Fix uninitialized variable.
2020-11-21 20:57:36 +00:00
Jeff Young
1391774f64
Re-factor boundary/courtyard checker error handling.
...
ADDED Footprint Checker dialog to display the results in.
Fixes https://gitlab.com/kicad/code/kicad/issues/6446
2020-11-21 20:57:35 +00:00
jean-pierre charras
01b6cd08b5
lib_edit_tool.cpp: fix a wxWidgets 3.0.4 compatibility.
2020-11-21 11:56:32 +01:00
jean-pierre charras
64636601b8
Eeschema: fix a Unicode/UTF8 management when pasting items from Clipboard.
...
Copy to clipboard save items (using S expr description) using wide strings
(not UTF8 encoding).
But Paste from clipboard was not converting the wide string to UTF8 string
when getting the stored data to send it as std::string to the S expr reader.
Fixes #6449
https://gitlab.com/kicad/code/kicad/issues/6449
2020-11-21 10:59:25 +01:00
Seth Hillbrand
3ff22fc882
Order symbols by unit/convert
...
This keeps the output symbol names in human-readable order
Fixes https://gitlab.com/kicad/code/kicad/issues/6376
2020-11-19 15:19:55 -08:00
Seth Hillbrand
c9fb595f64
Avoid assertion with invalid width
...
After adjusting col 0, the new width might be too large to handle. In
which case, allow the system to choose our best width
2020-11-19 15:19:55 -08:00
Jeff Young
9e9946628a
Go back to arrow cursor on a cancel (or finish).
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6421
2020-11-19 20:09:28 +00:00
Jeff Young
c2ba68cdfa
Make sure intersheet references are updated on file-open.
2020-11-19 19:21:15 +00:00
Jeff Young
826e47dde3
Hook up excluded ERC marker persistence.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6425
2020-11-19 18:22:52 +00:00
Jeff Young
99796d359f
Honour include-in-board flag when back-annotating.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6438
2020-11-19 15:29:53 +00:00
jean-pierre charras
801f385521
Eeschema: fix a UTF8 issue created by my commit 993a684
2020-11-19 14:37:51 +01:00
jean-pierre charras
754e8e912c
Eeschema: some fixes in grid list and zoom list from config.
...
- slightly modify the zoom list.
- Do not use the values read from config: the user cannot change them,
so any issue in config cannot be easily solved.
Moreover, the grid list cannot be changed.
However the lists are still written in config, just in case.
2020-11-19 11:42:21 +01:00