haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
33,169 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

13661 Commits

Author SHA1 Message Date
Seth Hillbrand e87ba10a5a Enforce group selection to abide by L/R behavior 
When selecting greedy (right to left), selecting any part of the group
will get the whole group.  When selecting left to right, we must select
all items in the group to get the grouped items unless we are in the
group itself

Fixes https://gitlab.com/kicad/code/kicad/issues/11902
 2022-07-12 11:01:34 -07:00
Jon Evans 664bf1382d PNS: Fix IsLineCorner logic 
Handle segment width test in the case of locked segs
Fix logic failure where vias on path cause crash

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11990


(cherry picked from commit 2512375988)
 2022-07-12 02:49:24 +00:00
Jeff Young 57acce9e55 Share more code between selection tools. 2022-07-11 19:04:08 -06:00
Alex aaf99eb0cc Performance optimizations. 2022-07-11 21:25:12 +00:00
Seth Hillbrand 3081023b5e ADDED: Minimum copper connection width DRC check 
Checks all copper connections in each net/layer for minimum width
setting.

Fixes https://gitlab.com/kicad/code/kicad/issues/9870
 2022-07-11 19:26:56 +00:00
Wayne Stambaugh 6a74ecbffd Pcbnew: fix minor white space issue in board file. 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11669
 2022-07-11 11:21:45 -04:00
Jeff Young 0a623bff9f Save fp browser list widths and apply known hack to work around wxWidgets bug. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11744

Fixes https://gitlab.com/kicad/code/kicad/issues/11745
 2022-07-10 23:07:04 -06:00
Jeff Young 43b82aeffc Fix another case of Edge_Cuts & Margins needing to be treated as all-physical-layers. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11843
 2022-07-10 20:32:28 -06:00
Jeff Young 19b4844102 Avoid OSX system shortcut. 
CHANGED toggle net highlight from ctrl-` to opt-`.

Fixes https://gitlab.com/kicad/code/kicad/issues/10160
 2022-07-10 20:20:22 -06:00
Jeff Young 1eb2a39eca Fix errant test in board items plotter. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11944
 2022-07-10 18:54:36 -06:00
Jeff Young e122dc38bd Add context menu item for clearing net highlighting. 
In selection tools, drawing tools, router tool, line_wire_bus tool.

Fixes https://gitlab.com/kicad/code/kicad/issues/11920
 2022-07-10 17:15:20 -06:00
Jeff Young eb27a3f8b9 Added pinning support to various EDA_LIST_DIALOGs. 
Footprint Save As, Symbol Save As, etc.
 2022-07-09 20:44:49 -06:00
Jeff Young 05219e4d9a Add pinned library support to Choose Symbol and Choose Footprint. 2022-07-09 20:06:31 -06:00
Jeff Young 190fb23e88 Add pinned library support to Footprint and Symbol Viewers. 
Also includes adding libraray and symbol filters to Symbol Viewer.
 2022-07-09 17:41:10 -06:00
Jeff Young b8479bf6f1 Handle severity ignore rules in router. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11609
 2022-07-09 11:24:47 -06:00
Seth Hillbrand 0cb5abd7f7 Fix highlight on route again 
Added a clarifying comment that will hopefully keep the required code
block in place
 2022-07-08 20:14:46 -07:00
Jeff Young c7746fa000 Fix copy pasta error. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11986
 2022-07-08 17:44:36 -06:00
Jeff Young ded611aed5 Patch annoying large checkbox cols in wxWidgets 3.1.x on OSX. 2022-07-08 17:27:05 -06:00
Jeff Young 521b231873 Don't zero out width of shapes on Margin, only Edge_Cuts. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11967
 2022-07-08 17:27:05 -06:00
Jeff Young 654740b90d Add newly-drawn objects to any entered group. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11912
 2022-07-08 17:27:05 -06:00
Jeff Young 8a9bf02b7e Smarten up silk clearance & tented item handling. 
The inspection tool will report whether or not the item is tented
(indicating in that case that any clearance will only be applied
to any hole).

The DRC test ignores tented items without a hole, and runs the
clearance test against the hole for items with a hole.

Fixes https://gitlab.com/kicad/code/kicad/issues/11954

Fixes https://gitlab.com/kicad/code/kicad/issues/11951
 2022-07-08 17:27:05 -06:00
Jeff Young f611f9f5d3 Allow zone connection rules to target footprints. 
If the pad is set to inherit and a rule targets its parent footprint,
then that rule should fire.
 2022-07-08 17:27:05 -06:00
Jeff Young fa2e43f696 Reduce noise in board <-> library footprint tests. 2022-07-08 17:27:04 -06:00
Seth Hillbrand 0c47a09517 Ensure rectangles are normalized 
Normalize on creation and fixup rectangles previously saved with
inverted coordinates

Fixes https://gitlab.com/kicad/code/kicad/issues/11965
 2022-07-07 10:40:18 -07:00
jean-pierre charras 7b28804f67 Fix a minor compil and Coverity warning 2022-07-06 13:54:17 +02:00
Seth Hillbrand 7f9f37e507 Avoid double-caching FP zones 
Leads to crashes/invalid data when multi-threading hits both at same
time
 2022-07-05 20:07:18 -07:00
jean-pierre charras f00de04336 FP editor: fix incorrect mirroring of zones in footprint. 
This is due to a call to Mirror() with incorrect parameter.
Unfortunately, depending on FP items, one Mirror parameter has the opposite
meaning about mirror axis.
Fixes #11952
https://gitlab.com/kicad/code/kicad/issues/11952
 2022-07-04 11:14:47 +02:00
Tomasz Wlostowski 3111b7679d router: bring back the snap-to-hull behaviour in Mark Obstacles mode 2022-07-03 23:59:27 +02:00
jean-pierre charras d41e47609c Pcbnew: fix plot issue for non filled polygons in footprints. 
Fixes #11959
https://gitlab.com/kicad/code/kicad/issues/11959
 2022-07-03 11:24:23 +02:00
Seth Hillbrand cde30d3dba Clarify cross-probing options 
Previous the cross-probing options were mixed between sending and
receiving cross-probe events.  This clarifies so that all of the pcbnew
cross-probe options deal with whether the cross-probe is seen in pcbnew
and all of the eeschema options deal with seeing the event in eeschema.

Also updates the wording in the options panels to be the same where
possible and adds tooltips

Fixes https://gitlab.com/kicad/code/kicad/issues/11454
 2022-07-01 16:47:09 -07:00
Seth Hillbrand 907d8fc018 Revert "Fix Swatch sizes" 
This reverts commit 25c3a4681f.

Windows default sizes are too big when they are the correct size on
Linux.  We need the DU scaling for swatches
 2022-07-01 11:37:55 -07:00
Seth Hillbrand 25c3a4681f Fix Swatch sizes 
The swatches are surrounded by non-scaling icons.  We should not scale
the swatches unless we also scale the icons.  This patch makes all
elements in the appearance panel equally non-scaling

This relates to https://gitlab.com/kicad/code/kicad/-/issues/11880
 2022-07-01 10:56:13 -07:00
jean-pierre charras 2ff2a6ffcd Kicad2step: fix STEP export from Pcbnew, broken by changes in commit 8456d6c 
also: DIALOG_EXPORT_STEP: remember tolerance option during a session.
 2022-07-01 09:56:15 +02:00
Seth Hillbrand 0c796697b4 Avoid documentation in dialogs 
If the nomenclature is unclear, we should rework the dialog rather than
adding documentation strings to a crowded dialog.

This also prevents new strings from appearing in v6
 2022-06-30 10:57:56 -07:00
luz paz af6ba1a16e Fix typos in pcbnew sub-directory 
Found via `codespell -q 3 -S *.po,./thirdparty,./Documentation/changelogs -L aactual,acount,aline,alocation,alog,anormal,anumber,aother,apoints,aparent,aray,ba,busses,dout,einstance,leaded,modul,ontext,ot,overide,serie,te,,tesselate,tesselator,tht`
 2022-06-30 09:39:45 -04:00
Jeff Young f48ed79039 Rely on DRC rules when items might overlap. 
Fixes https://gitlab.com/kicad/code/kicad/issues/1790
 2022-06-29 13:43:44 -06:00
Seth Hillbrand 802745398a Python add param to change UUIDs on fp load 
By default, we load all footprints with a new UUID set to allow them to
be added to the board as unique objects.  But when editing footprints,
we want to maintain the same UUID.

Fixes https://gitlab.com/kicad/code/kicad/issues/11870
 2022-06-29 12:10:24 -07:00
Seth Hillbrand f1a054e6af Correct SWIG call for board design settings 
Use the backend call rather than rely on the naming of internal
variables

Fixes https://gitlab.com/kicad/code/kicad/issues/11924

(cherry picked from commit 9cebea5f11)
 2022-06-28 14:03:43 -07:00
jean-pierre charras 7d8fe98d53 Pcbnew, exporter VRML: code refactor and remove unuded code. 
It should help later, to use EXPORTER_VRML in python scripting helpers.
Mainly, EXPORTER_VRML avoid to expose the actual exporter VRML internal code.
 2022-06-28 18:59:50 +02:00
Mike Williams 64b89639cf PCB Editor: Make Ctrl-Click net highlighting configurable 
Defaults to ctrl-click is exclusive or selection like other
applications. Footprint editor can only be exclusive or.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10810
 2022-06-28 16:29:14 +00:00
Jeff Young ab9c42d427 Fix a typo which leads to a bogus type-cast. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11886
 2022-06-27 23:07:06 -06:00
Jeff Young 833dc70bff Add edge-exclusions to router (for castellated pads). 
Fixes https://gitlab.com/kicad/code/kicad/issues/1790
 2022-06-27 15:16:37 -06:00
Ian McInerney 4e4b0962db Create python subdirectory in pcbnew build for the symlink 2022-06-25 01:10:20 +01:00
Seth Hillbrand 03c279ffd4 ADDED: Threadpool 
Thread pools are long-lasting executors that have close to zero overhead
when launching new jobs.  This is advantageous over creating new threads
as we can use this for threading smalling jobs and smaller quanta.  It
also avoids the heuristics needed to determine the optimal number of
threads to spawn
 2022-06-24 22:59:24 +00:00
Seth Hillbrand 8418fe12d8 Allow board saves without modifying project files 
Without the project files, certain settings will not be saved by this
python call.  This defaults to false (current behavior) but setting the
`aSkipSettings` to true will revert to v5 behavior

Fixes https://gitlab.com/kicad/code/kicad/issues/11323
 2022-06-24 15:28:56 -07:00
jean-pierre charras 35375a98c6 FP editor, dialog leader dimension: fix text frame setting not saved 
Fixes #11900
https://gitlab.com/kicad/code/kicad/issues/11900
 2022-06-24 17:45:51 +02:00
jean-pierre charras 3fcd959757 Gerbview: minor cosmetic enhancement: show if the file is X1 or X2 format. 2022-06-24 15:44:13 +02:00
Ian McInerney f303d78723 Fix install of _pcbnew.so to allow DESTDIR to be used with it 
We need to use the install directive to do an install so that the
install process uses all the variables correctly. So create a temporary
symlink in the build directory that points to nowhere and then install
that.
 2022-06-23 23:15:49 +01:00
jean-pierre charras c3f90d914b Gen Drill map: Re-add Gerber option but only using X2 format. 
Only the X2 format allows the TF.FileFunction option, mandatory to
avoid mistakes about this file that is not a standard Gerber file.
 2022-06-23 11:56:27 +02:00
Ian McInerney 44a8f1e6e6 Create the symlink for the python module in the build tree as well 
The unit tests need the python module to be loadable, so there needs to
also be a symlink to the kiface inside the build directory.
 2022-06-23 00:27:35 +01:00
Ian McInerney 9bb5beb264 Use symlink to pcbnew kiface for python module on Linux 
Instead of installing an identical shared library into the Python
folder, just use a link to the existing library instead.

Fixes https://gitlab.com/kicad/code/kicad/issues/9974
 2022-06-22 23:40:29 +01:00
Ian McInerney b51d8c9825 Introduce new CMake variable to store kiface install location 2022-06-22 23:40:25 +01:00
Seth Hillbrand 3ddd287004 Revert "Fixup python module install" 
This reverts commit 6fd60c5561.

Worked only for a single make.  Second run fails due to missing file
 2022-06-22 14:11:59 -07:00
Seth Hillbrand 6fd60c5561 Fixup python module install 
INSTALL(FILE) does not handle setting linux-specific attributes in the
same way that INSTALL(TARGET) does.  This patch is suggested by
StefanBruens

Fixes https://gitlab.com/kicad/code/kicad/issues/9974
 2022-06-22 13:29:08 -07:00
Seth Hillbrand a43fcd045f Hyperlynx arcs are always CW 
Previous test comparing start/end angles doesn't account for all cases.
This adds a more robust test to ensure all arcs are output in CW fashion

Fixes https://gitlab.com/kicad/code/kicad/issues/10782
 2022-06-22 09:59:37 -07:00
jean-pierre charras 32c5a4d1ea gen drill maps: remove unusable format (HPGL and GERBER) for map files. 
Especially, on a regular basis, map files in gerber format create problems
for board house.
 2022-06-22 11:13:06 +02:00
jean-pierre charras 82b2df67be Add 2 automatically generated files to the source tree. 
These files are needed by translators, so it is better to add them to the source
without need to build kicad.
 2022-06-22 08:51:04 +02:00
Seth Hillbrand a852286eb5 Cleanup compile warnings 2022-06-21 17:04:56 -07:00
Miklós Márton f2382a7bd1 Add Make selected active/inactive actions to the symbol libraries 
context menu

Fixes #11372
 2022-06-21 23:32:02 +00:00
jean-pierre charras b54bb90975 DIALOG_FOOTPRINT_WIZARD_LIST_BASE: use a monospaced font to show the wizard errors. 
A proportional font does not allow to correctly show the error message and the
marker showing the exact position of the error in the printed line.
 2022-06-21 09:42:21 +02:00
jean-pierre charras e73dd40f26 APPEARANCE_CONTROLS: fix incorrect behavior of Preset layers widget: 
In non English languages, the selection of a previous choice was broken
due to the fact fixed (read only) presets have a English name, but the
UI list uses translated names, so the actual selection was not correctly
displayed.
 2022-06-21 08:57:16 +02:00
Jeff Young aad85a83da Improvements to rotation/mirroring of dimensions inside footprints. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11861
 2022-06-20 22:25:39 +01:00
Jeff Young 23e8bafd9c Don't run courtyard conflicts in footprint editor. 2022-06-20 22:25:39 +01:00
Miklos Marton 426c46abb1 pcbnew: pad editor UI fixes 
When editing a pad with circular hole the Y dimension is hidden
and Diameter is shown instead of Size X when opening the properties
of an existing pad.
Adjusted Pad shape: label to be vertically aligned to the pad shape
combobox.
 2022-06-20 19:15:41 +00:00
jean-pierre charras 6679decc8d Fix syntax issues in footprint wizards 
Fixes #11867
https://gitlab.com/kicad/code/kicad/issues/11867
 2022-06-20 20:31:18 +02:00
Jeff Young 048f277b1e Don't reset Footprint Tests Run if the board didn't change. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11844
 2022-06-20 17:25:43 +01:00
Jeff Young d69e3fdb5e Specify a winding for Hyperlynx arcs. 
I can't test it, so it's a 50:50 guess.  We may need to flip the
test....
 2022-06-20 17:03:37 +01:00
Jeff Young 298edb09c3 Initialize TEXT_ATTRIBUTES justifications for text & textboxes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11805
 2022-06-20 17:03:37 +01:00
jean-pierre charras 9db907cc70 pcbnew, plot footprint: fix typo that prevent ploting dimensions 
Fixes #11860
https://gitlab.com/kicad/code/kicad/issues/11860
 2022-06-20 17:20:56 +02:00
jean-pierre charras d19705ac8c FOOTPRINT::Flip(): add missing handle of dimensions. 2022-06-20 11:37:25 +02:00
jean-pierre charras c8ce01ce8e pcb_parser: fix an incorrect CHECK_MSG when parsing a dimension in a footprint. 
this incorrect CHECK_MSG created a crash.
Fixes #11859
https://gitlab.com/kicad/code/kicad/issues/11859
 2022-06-20 10:42:19 +02:00
Jeff Young 73836b50fc Add proper collision test to via placer. 
Also moves DISALLOW constraint processing outside the loop as it
performs it's own loop over any objects referenced by the rules.

Fixes https://gitlab.com/kicad/code/kicad/issues/11832
 2022-06-19 21:57:49 +01:00
Jeff Young 801a98a302 Don't clear marker counts when closing DRC dialog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11844
 2022-06-19 20:51:45 +01:00
Jeff Young 231ac567b8 Bug fixes for printing vias. 
Blind/buried and microvias didn't get their layers trimmed properly,
nor did through vias with dropped pads.

Fixes https://gitlab.com/kicad/code/kicad/issues/11851
 2022-06-19 11:58:21 +01:00
Jeff Young 82ebc247b8 More performance enhancements for DRC. 2022-06-18 19:47:11 +01:00
Jeff Young 5da817649b Fix nullptr bug. 2022-06-18 13:04:06 +01:00
Jeff Young 97b0005780 More caching for DRC. 
Also fixes a bug where some physical clearance tests would be run even
if the clearance was 0 (or if the rule was set to IGNORE).
 2022-06-17 23:58:31 +01:00
jean-pierre charras f20cb0fda8 Activate teardrops: remove advanced config option and add teardrop keywords in files. (the ability to read teardrop keywords was added some time ago) 2022-06-17 19:42:27 +02:00
Miklós Márton b912bef2f6 pcbnew: Display Diameter when circular shape selected in pad editor 2022-06-16 20:26:42 +00:00
Fabien Corona bd8f0ae81a Ibis: Fix coverity issues 2022-06-16 20:09:50 +00:00
Seth Hillbrand 4043dca613 Push wxString allocation to smaller context 
Prevents creation of new wxString on stack for each clearance check
 2022-06-16 08:26:28 -07:00
Seth Hillbrand 359d66bc81 Protect against invalid pads 
Before dereferencing the front of the sequence, we have to ensure that
the pad exists on any layer.  If not, just return the default (probably
F_Cu) for the element
 2022-06-16 08:20:47 -07:00
Seth Hillbrand 5327b10064 Remove shared wxString instance in DRC 
Threaded DRC access will write to this string, re-allocating the memory
without any synchronization between threads using the string.  Comment
adding this listed performance as a reason for using shared strings.
Measured performance does not seem noticeably different in either case,
even with high-error count boards.  If there is a case where the
performance is limiting, we can replace these wxStrings with
std::wstring and utilize fmt

Fixes https://gitlab.com/kicad/code/kicad/issues/9888
 2022-06-15 16:46:03 -07:00
Jeff Young d40664d171 Handle double-click in dimension drawing tool. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11815
 2022-06-15 18:07:50 +01:00
Jeff Young 5e80e2a421 58f553a9ca requires that cache be layer-sensitive. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11814
 2022-06-15 00:30:11 +01:00
Fabien Corona bf62d6e9ee Ibis: Coverity issues 2022-06-13 19:31:57 +00:00
jean-pierre charras 9fd5ee5a2f paper min size set to 1 inch (previously 0.1 inch, very small indeed) 
Avoid using magic numbers in file pcb_parser.cpp.
Fixes #11807
https://gitlab.com/kicad/code/kicad/issues/11807
 2022-06-13 17:51:29 +02:00
Jeff Young 52bc2511cd Add a radioButton mode to IMAGE_BUTTON. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11797
 2022-06-12 20:09:46 +01:00
Marek Roszko 87f10ea206 Split off the netlist export content helper but it's advancedcfg 2022-06-11 23:09:47 -04:00
Marek Roszko cb44d97ed4 Update pcbnew to the new filedlg customize 2022-06-11 22:10:49 -04:00
Jon Evans e5ece4e460 ibis_parser: fixes to build on MSVC 
Use stringstream instead of C arrays for formatting std::string
std::isnan(int) is invalid

Also fix a few report severities that seemed inconsistent
 2022-06-11 18:09:17 -04:00
Jeff Young 9b70308f5c Nullptr defensive code. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11690
 2022-06-11 22:32:12 +01:00
Jeff Young 4f3cfdc92e Clang says nan and isnan aren't in std namespace.... 2022-06-11 22:14:14 +01:00
Jeff Young f22cf1cc3a Fill in missing bits of LAYER variable for printing/plotting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11788
 2022-06-10 22:38:01 +01:00
Seth Hillbrand 20f4e62176 Rename signalIntegrity to ibis 
We do not use camelCase in KiCad
 2022-06-10 13:35:48 -07:00
Tomasz Wlostowski f5fe1d5462 router: another attempt at improving 'kink' robustness of the hull generator 2022-06-09 20:51:21 +02:00
Fabien Corona 0d35d69f70 ADDED: Read IBIS files 2022-06-09 18:30:51 +00:00
Seth Hillbrand ac0f95683f Sort PCAD layers 
Better fix for 11750.  Instead of figeting with layer values, we sort
our map based on the layer numbers in the PCAD file.  F_Cu is always
layer 1 and B_Cu is always layer 2.

Fixes https://gitlab.com/kicad/code/kicad/issues/11750
 2022-06-09 11:10:34 -07:00
Seth Hillbrand e857622dd4 Handle B_Cu ordering 
Stopgap until we introduce multi-layer mapping widget

Fixes https://gitlab.com/kicad/code/kicad/issues/11750

(cherry picked from commit 32aabaf010)
 2022-06-08 17:19:37 -07:00
Seth Hillbrand 124bdb6673 Check for older tags in pcad import 
The pourOutline/planeOutline do not include support for fillets

Fixes https://gitlab.com/kicad/code/kicad/issues/11749

(cherry picked from commit 72b7f9fe10)
 2022-06-08 16:27:17 -07:00