1db799d841
Implement "disallow" rules and integrate with keepout settings.
2020-05-25 22:51:47 +01:00
c415130de9
Improve parse error messages.
2020-05-25 22:51:47 +01:00
160981ee71
Better error reporting for DRC rule parsing.
2020-05-25 22:51:47 +01:00
416d82727f
Redo DRC rules to get ready for new system.
2020-05-25 22:51:47 +01:00
9a08ee2778
Add a 1nm tolerance to prevent rotated pad roundoff errors.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4139
2020-05-22 18:04:29 +01:00
0a9adaef73
Don't use bboxes for non-cartesian-rotated pad collision testing.
2020-05-22 14:12:56 +01:00
69f121d907
Another attempt to get DRC and status bar to share message content.
2020-05-22 14:12:56 +01:00
4f14769ce1
Use both pads when calculating pad-to-pad clearance.
2020-05-21 21:26:36 +01:00
a5b53a623d
Update status bar with clearance & rule sources.
2020-05-21 21:26:30 +01:00
98be50883d
Fix bug in single-item layer matching.
2020-05-21 11:25:39 +01:00
89c46e6834
Fix typo in DRC check of rule-based track-width.
2020-05-19 21:17:49 +01:00
f4d7c323f5
Coverity fixes
2020-05-18 22:58:28 -04:00
7d537e83ea
Match layers only if both items are on the given layer.
2020-05-18 22:37:37 +01:00
ae9662c5cd
Fix some unitialized variables.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/4477
Fixes https://gitlab.com/kicad/code/kicad/issues/4473
2020-05-18 21:30:38 +01:00
d046f165de
Fix board outline issues.
...
1) Don't try and do board-edge clearance checking against a
synthetic polygon constructed because we didn't find any edges.
2) Check pads against board edge.
3) Don't report vias as "Track too close to board edge".
2020-05-18 21:11:01 +01:00
cec857c0f4
Complete hookup of zone filler to new clearance engine.
2020-05-18 19:20:46 +01:00
05855a5a1c
Performance enhancements for DRC.
2020-05-18 13:38:17 +01:00
8dc6f8e82b
Allow empty rules files.
2020-05-17 15:49:02 +01:00
75b139c7b4
Move hole testing to DRC client and improve performance.
2020-05-17 15:49:02 +01:00
3656297f99
Add a simple editor for DRC rules.
2020-05-16 23:30:30 +01:00
5b07889347
Better error messages for rule parsing.
2020-05-16 20:53:49 +01:00
d3f017d825
DRC rules parser and engine.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2182
Fixes https://gitlab.com/kicad/code/kicad/issues/2116
Fixes https://gitlab.com/kicad/code/kicad/issues/1958
Fixes https://gitlab.com/kicad/code/kicad/issues/1965
2020-05-16 15:53:05 +01:00
13493437d0
Add hole-inside-courtyard DRC checks.
...
One for NPTH and one for PTH; both default to "ignore".
Fixes https://gitlab.com/kicad/code/kicad/issues/3434
2020-05-14 22:02:47 +01:00
aedc624340
Add DRC checks for dangling vias and tracks.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/1999
2020-05-14 22:02:47 +01:00
74ee143d45
Add via annulus minimum.
2020-05-11 22:56:09 +01:00
2568c168a2
Silence Coverity warning.
2020-05-09 14:14:38 +01:00
8efa8af8cc
Add persistence of DRC error severities.
2020-05-07 17:51:27 +01:00
0f8c7ffd11
Add pad keepout and footprint keepout areas.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/2365
2020-05-07 17:51:27 +01:00
e0da677d4d
Add min clearance to DRC; rename Min Via Drill to Min Through Hole.
...
Also fixes a crash bug when ignoring a DRC violoation with multiple
markers.
Fixes https://gitlab.com/kicad/code/kicad/issues/2528
2020-05-04 22:08:36 +01:00
e39d145d72
Add DRC tests for minimum drill size (based on min via size).
2020-05-04 22:08:36 +01:00
fd991db0a9
Forgot last commit.
2020-05-01 21:10:36 +01:00
9954484dfd
Don't show source in violation "name".
2020-05-01 18:49:42 +01:00
058108dd6d
There are 3 courtyard DRC checks, not 2.
2020-05-01 18:49:42 +01:00
4a60b8a776
Improve DRC error reporting and fix some bugs.
2020-05-01 18:49:42 +01:00
068874a626
Add clearance source for zone-to-zone clearance violations.
2020-05-01 18:49:42 +01:00
bba2fa3028
Fix bug with doubling the pad corner radius twice.
2020-05-01 18:49:42 +01:00
dfe4a00d43
Add distance reporting for copper item DRC tests.
...
Also adds some performance improvements.
2020-05-01 18:49:42 +01:00
0c20c0b4af
Fix broken hole-to-track test.
2020-05-01 18:49:42 +01:00
874f13e29e
Fix some issues with rotated oval pads.
2020-05-01 18:49:42 +01:00
5c8d712a56
Fix some issues with rotated rectangular pads.
2020-05-01 18:49:42 +01:00
1280a4d2f3
Add pre-flighting to DRC checks for performance.
2020-05-01 18:49:42 +01:00
c955f45728
Fix compile error on gcc.
2020-05-01 18:49:42 +01:00
f7e518dbc6
Add clearance sources to some DRC violation reports.
2020-05-01 18:49:42 +01:00
a56191b658
Add distances to a bunch of DRC violation reports.
2020-05-01 18:49:42 +01:00
99dcadf7e6
Introduce new KI_FALLTHROUGH macro
...
Annotate purposeful fallthroughs in switch statements with the
KI_FALLTHROUGH macro.
2020-04-25 00:44:09 +01:00
32db9eb0f1
Add some distances to a few DRC errors.
2020-04-24 22:17:45 +01:00
3f9b3e505e
Add some virtual destructors
2020-04-24 18:24:39 +01:00
1535c83b88
Lay some groundwork for adding distances to DRC errors.
...
modified: eeschema/lib_rectangle.cpp
2020-04-24 14:46:22 +01:00
9c8941e040
Remove a bunch of globals.
2020-04-16 17:34:46 +01:00
6e800bddae
Rationalize penWidth processing as first step in removing some globals.
2020-04-13 20:58:13 +01:00
41b5872f12
Add ERC & DRC checks for unresolved variables.
2020-03-30 14:15:59 +01:00
64d217edda
drc.h: replace a list of #define by an enum.
...
Due to changes in code, the reason for using #define does not exist
since a long time.
2020-03-18 10:19:46 +01:00
cee973dc04
Move ERC error reporting over to the new framework.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/1989
2020-03-16 11:06:15 +00:00
61704cb508
Initialize missing variable
2020-03-11 15:24:08 -07:00
fbd01f2f7d
DRC_TREE_MODEL: Fix incorrect display of DRC errors on linux+wxGTK 3.0
...
Fixes #4038
https://gitlab.com/kicad/code/kicad/issues/4038
2020-03-11 10:46:08 +01:00
f079c41118
Prevent the board setup dialog from opening when DRC is open
...
The board setup dialog controls DRC error visibility, so the
two dialogs shouldn't be open at the same time to prevent
data contention.
Follow-up to https://gitlab.com/kicad/code/kicad/-/issues/4023
2020-03-08 15:55:14 +00:00
1e4ae5d526
Bug fix for DRC tree view on MSW.
2020-03-07 18:52:30 +00:00
44b8bb8f60
Fix a bug when deleting DRC markers from their child items.
2020-03-06 16:23:44 +00:00
d20f36511f
Fix issue with severities not get initialised in DRC_TREE_MODELs.
2020-03-04 21:52:30 +00:00
0894674869
Save severities settings in the DRC dialog.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/3978
2020-03-04 21:52:30 +00:00
b7cd0c54c2
Fix compil issues, especially on Windows:
...
Replace SEVERITY_ERROR by RPT_SEVERITY_ERROR to avoid collision with a system definition.
Replace other SEVERITY_XXX by RPT_SEVERITY_XX for consistency.
Fix compil warnings and some other compil issues.
2020-03-04 10:48:18 +01:00
85c2e0d23a
Add user-defined severities, exclusions and colors to DRC markers.
...
Exclusions are currently persisted in the project file.
Fixes https://gitlab.com/kicad/code/kicad/issues/1989
2020-03-04 00:39:28 +00:00
3860ab9f0c
Fix issue returning pointers to items inside std::vector.
...
(When the vector is re-allocated your pointers become bogus.)
2020-02-27 22:00:51 +00:00
82ae9db262
Another variation on the wxDataViewCtrl issue....
2020-02-26 17:56:47 +00:00
a2234b348d
Another attempt to work around wxDataViewCtrl bug on GTK.
2020-02-26 17:35:10 +00:00
4c563b541e
Another attempt to get GTK wxDataViewCtrl to reload properly.
2020-02-26 14:41:12 +00:00
7c6f7e6b01
Try some undocumented wxWidgets call to fix DRC.
2020-02-25 18:26:42 +00:00
0614bbc663
Silence a couple of compiler warnings.
2020-02-25 18:26:42 +00:00
4e0cb3c1ad
Another attempt at fixing Linux issue.
...
Note that I have no Linux machine, so this is shooting in the dark....
2020-02-25 13:51:59 +00:00
4b380f0dc3
Fix compile issue on Linux & crash issue on Windows.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/3937
2020-02-25 12:28:05 +00:00
a4837f7d32
Move DRC dialogs to wxDataView.
...
This allows for hierarchy and better selection handling.
2020-02-24 23:19:17 +00:00
c5077aeb97
Move weak-reference stuff to UUIDs.
2020-02-24 23:19:17 +00:00
625249322e
Pcbnew: regroup drc files to the already existing drc folder.
2020-02-19 10:31:32 +01:00
fbeb0709ef
Formatting cleanup.
2020-02-03 19:35:48 +00:00
7c28c3838a
Comment-only changes
...
Makes class comments conform to coding standards
2020-01-10 16:43:01 -08:00
11ff16be4e
Switch to scoped enums
2019-12-20 14:11:39 +00:00
c4d853c1e8
SHAPE_LINE_CHAIN: Remove element access
...
This is the first step to allowing non-segments in the line chain.
External routines cannot be allowed to change the line chain without
going through the internal routines. To accomplish this, we remove the
Vertex() and Point() access routines and only leave the const versions.
Transformations are given for both points as well as the chain itself.
2019-12-12 13:54:48 +00:00
fbfbb64387
A bit of cleanup of stale DRC code.
2019-06-04 13:56:54 +01:00
568c8c336b
Move DRC control to a tool; move assorted commands to ACTIONS.
2019-06-03 21:08:30 +01:00
d1877d7c1b
Moving modules from DLIST to std::deque
2019-06-01 09:53:23 -07:00
40309a17ef
pcbnew: Check exact overlapping polygons
...
Checks for polygon collisions in the outline when the polygon contains
two or more segments that exactly overlap. This also places the DRC
marker at the location where the collision happens.
Fixes: lp:1818163
* https://bugs.launchpad.net/kicad/+bug/1818163
Fixes: lp:1818218
* https://bugs.launchpad.net/kicad/+bug/1818218
2019-03-01 09:38:33 -08:00
8297ab24e4
DRC: Break out courtyard overlap function
...
Introduce the concept of a DRC_PROVIDER which allows
to separate the various DRC functions to their own
areas. This allows, amongst other things, a slimmer core
DRC class, and allows DRC functions to be separately testable.
The courtyard DRCs (overlap, missing and malformed)
are the first victims, so instrumentation can be added to this function.
Add some unit tests on this DRC function, as well a few re-usable PCB-based
utility functions in a library (qa_pcbnew_utils) that could be shared between
unit tests and other utilities.
2019-01-23 13:27:52 -05:00
e6edc1b670
DRC: Make the marker factory a separate class
...
This separates the "newMarker" functions from the DRC class. These
are moved to a new class, DRC_MARKER_FACTORY, which is now responsible for
constructing suitable markers from BOARD_ITEMS.
The reasons for this are:
1) Allow DRC related functions to access theese functions without having
to bake these functions into the main DRC class.
2) Thereby simplify the DRC class interface
3) As DRC_MARKER is now a small class with public interfaces, it's
possible to put unit tests on these functions.
The motivation here is to allow to start to split out pieces of DRC
into separate classes.
2019-01-23 13:27:52 -05:00
Jeff Young
Jon Evans
Ian McInerney
jean-pierre charras
Seth Hillbrand
Mark Roszko
Seth Hillbrand
John Beard