aris-kimi
ff6f658f9d
Simulator: Fix some cases with initial conditions
...
(cherry picked from commit 4a761179d0
)
2023-02-28 21:31:45 +00:00
jean-pierre charras
764ddd4773
Fix compil warnings.
2023-02-28 18:00:22 +01:00
Graham Keeth
f7d9f1f69d
Fix SPICE pins for BJTs and MESFETs
...
- MESFETs don't have a substrate/bulk pin
- BJTs have a substrate pin, and HICUM/VBIC have TJ
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13848
(cherry picked from commit 6af3dadaee
)
2023-02-28 14:21:12 +00:00
Jeff Young
42efd2d005
Make substrate and thermal junction nodes optional.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14083
(cherry picked from commit 1fdc81e68d
)
2023-02-28 14:21:12 +00:00
Jeff Young
d32e13daee
Clear model name when switching to internal model.
...
Also fixes a bug to ensure that a modelLine gets written when using
an internal model.
Fixes https://gitlab.com/kicad/code/kicad/issues/14083
(cherry picked from commit 2e5bf0210a
)
2023-02-28 14:21:12 +00:00
Jeff Young
e82c21e944
Get rid of m_sortedSymbolPinList in favour of a properly scoped variable.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14083
(cherry picked from commit 2a79a453ec
)
2023-02-28 14:21:12 +00:00
Jeff Young
59d8110801
Always highlight children when they're selected on their own.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13876
(cherry picked from commit a1ceb585c7
)
2023-02-28 14:21:11 +00:00
Jeff Young
d028b381fa
Make SIM_MODEL_SPICE_FALLBACK act more like the model it's a fallback for.
...
In particular, install/show the parameters, and keep the existing name
field.
Fixes https://gitlab.com/kicad/code/kicad/issues/14102
(cherry picked from commit 281fde71b9
)
2023-02-28 14:21:11 +00:00
Roberto Fernandez Bautista
c96f0f2396
Fix CADSTAR importer memory leaks
...
We were leaking the xml tree when throwing exceptions
(cherry picked from commit b03366c9e8
)
2023-02-27 22:58:41 +00:00
Fabien Corona
46c8985661
sim - switches: open <-> closed in description
2023-02-27 19:04:48 +01:00
Jeff Young
b3c6f559b2
Don't eval empty string.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13756
(cherry picked from commit 79f13ea9c7
)
2023-02-26 23:14:40 +00:00
Jeff Young
4aba595b2b
Add second instance of "don't mess up user formatting" fix.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13989
(cherry picked from commit 4b427b2d0c
)
2023-02-26 22:00:20 +00:00
Jeff Young
4ffe742b69
Log new undo record at the start of Change Symbols.
...
Also fixes a bug where the "screen" variable was used with stale
data.
Fixes https://gitlab.com/kicad/code/kicad/issues/14061
(cherry picked from commit 2b96161d0e
)
2023-02-26 21:58:57 +00:00
Roberto Fernandez Bautista
955bd5a6d1
CADSTAR Sch: Fix loading of graphical arc shapes
...
Correctly load arc shapes as real arcs instead of approximating now that
v7 supports graphical arcs in the schematic.
Also fix calculation of arc geometry for ccw arcs.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14101
(cherry picked from commit 698d0b7e92
)
2023-02-26 18:47:39 +00:00
Jon Evans
d08157f7db
Re-disable validator for VALUE and add comment explaining it
2023-02-25 08:05:42 -05:00
Jon Evans
981bf328ae
Value field needs to use the normal text control
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14056
2023-02-24 22:18:31 -05:00
Jeff Young
f604bcb557
Only write included models if they have overridden parameters.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13953
(cherry picked from commit 5a12e5ee76
)
2023-02-24 20:47:22 +00:00
Jeff Young
eccf9eb4a4
Change strategy for committing values from SIM_MODEL propGrid.
...
Note that the PCB editor's propGrid doesn't seem to need this workaround,
but I haven't yet figured out what's different between it and the sim model
propGrid.
Fixes https://gitlab.com/kicad/code/kicad/issues/13852
(cherry picked from commit c188318174
)
2023-02-24 20:47:22 +00:00
Jeff Young
39403fa885
Cleanup some dead code, and add a potentially needed fix for non-Mac.
...
(The Mac bug is fixed in 4e5b1da81fce7cd9ffedaec878ed07bfcfff4fe2 in
our wxWidgets fork.)
(cherry picked from commit 200a06a677
)
2023-02-24 20:47:22 +00:00
Jeff Young
5e7cc30564
Don't mess up user formatting if eval'ing didn't actually change value.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13989
(cherry picked from commit 8059edff0e
)
2023-02-24 20:47:22 +00:00
Jeff Young
f942b4c657
Don't allow extra text in Sim.* fields.
...
(In particular, the field name.)
Fixes https://gitlab.com/kicad/code/kicad/issues/13996
(cherry picked from commit 71df3f9edb
)
2023-02-24 20:47:22 +00:00
Jeff Young
f5aeb5b068
More dead code removal and a bit of formatting and const& for strings.
...
(cherry picked from commit a126d961d8
)
2023-02-24 20:47:22 +00:00
Jeff Young
7f6cb9b07b
Remove most of SIM_VALUE in favour of good old wxString.
...
This allows us to save the user's intent, including units, formatting,
and crucially variable references.
(cherry picked from commit 68fe146861
)
2023-02-24 20:47:22 +00:00
Jeff Young
db3657d411
Terminology and more dead code.
...
(cherry picked from commit 29f21cdde6
)
2023-02-24 20:47:22 +00:00
Jeff Young
38e5da724d
Remove dead and redundant code.
...
(cherry picked from commit 90adc26b73
)
2023-02-24 20:47:22 +00:00
Jeff Young
962b2d45ef
Implement default levels for JFETs, MOSFETs and MESFETs.
...
(cherry picked from commit fe2679d965
)
2023-02-22 18:04:23 +00:00
Jeff Young
7894b41277
Don't allow 0 field text size.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13987
(cherry picked from commit cb71ea872b
)
2023-02-22 18:04:23 +00:00
Jeff Young
51d0b8d2b5
Don't allow SCH_LABEL_LOCATE_ANY_T to steal SCH_LABEL_LOCATE_WIRE_T's items.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13936
(cherry picked from commit 5967ab9a4d
)
2023-02-22 18:04:23 +00:00
Jeff Young
7b992a1dc4
Correctly netlist a voltage source with both AC and DC values.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13912
(cherry picked from commit c618bb7046
)
2023-02-22 18:04:21 +00:00
Jeff Young
2f8615c6c4
Don't use the just-in-time model resolver when updating the dialog.
...
If it changes in the middle it will leave you in a world of hurt.
Also don't update the library after a loss-of-focus unless the path
really changed.
Fixes https://gitlab.com/kicad/code/kicad/issues/13869
Fixes https://gitlab.com/kicad/code/kicad/issues/13854
(cherry picked from commit 64f1808d60
)
2023-02-22 17:53:10 +00:00
Marek Roszko
fd4a0dbedf
Fix up handling of font names available in multiple names
...
ttf fonts can declare multiple language names. Many by default opt to just declare one and not tag it any particular language.
However, there are CJK languages that typically leverage this function the most. They'll tag both a "en" and a cjk lang family name in CJK characters.
To be as user friendly as possible, we need to display said fonts in the CJK languages if KiCad to set to such a locale.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14011
(cherry picked from commit 39e69a3d29
)
2023-02-22 01:27:09 +00:00
Fabien Corona
c00a98fed4
Revert "sim - Remember the option to save powers"
...
This reverts commit 74dcc1b9d5
.
2023-02-20 20:59:52 +01:00
Fabien Corona
74dcc1b9d5
sim - Remember the option to save powers
...
Fixes #13978
(cherry picked from commit 2a3b70b7eb
)
2023-02-20 19:38:19 +00:00
Fabien Corona
17241b3543
sim - missing assignment
2023-02-20 18:15:37 +01:00
Fabien Corona
a4a859f47b
sim - Check FindParam() results before using them
2023-02-20 18:14:48 +01:00
Fabien Corona
b66ed8bc41
sim - don't write dc parameter twice
2023-02-20 18:13:44 +01:00
Fabien Corona
754feff5e7
sim - allow sources that are both AC and TRAN
2023-02-20 18:12:36 +01:00
Fabien Corona
cd1b425a80
sim: VSIN - allow user to specify a phase
...
TD is not the same as PHASE.
TD is the delay before the source turns on.
PHASE is ... the phase
If only TD is set, the signal starts later, but the phase is still 0 when compared to the t=0 of the simulation.
(cherry picked from commit 39a1b14a0f
)
2023-02-20 08:45:09 +00:00
Marek Roszko
5d793193e0
Fix crash by using a shared_mutex to read/write lock the nickIndex
...
Fixes sentry kicad-ax
2023-02-18 13:02:25 -05:00
Alex
b63d0a3138
Keep image sizes when loading/saving 7.0- schematic file formats.
...
Previously, images were assumed to have 300 PPI density when loading from
schematic, but not after initial placement.
(cherry picked from commit bd4758e4df
)
2023-02-17 01:50:01 +00:00
Alex
7949c09183
Prevent ghost image after canceling bitmap placement.
...
(cherry picked from commit ecb28ddf1c
)
2023-02-17 01:49:47 +00:00
Jon Evans
9f44809164
Revert "Handle another case where schematic view was being cleared"
...
This reverts commit 245ce7259c
.
2023-02-16 16:44:30 -05:00
Jon Evans
f7ccb18af5
Revert "Symbol editor: stop removing overlay from view"
...
This reverts commit f36cd60fdb
.
2023-02-16 16:44:20 -05:00
Jon Evans
cca9945867
Revert "Fix handling of selection overlay in schematic editor"
...
This reverts commit e2711a6121
.
This ended up being too complex for 7.0
2023-02-16 16:43:57 -05:00
Jon Evans
245ce7259c
Handle another case where schematic view was being cleared
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13944
(cherry picked from commit ec2fc161e1
)
2023-02-16 13:25:44 +00:00
Jon Evans
f36cd60fdb
Symbol editor: stop removing overlay from view
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13944
(cherry picked from commit 955a5a13eb
)
2023-02-16 13:17:34 +00:00
Jon Evans
e2711a6121
Fix handling of selection overlay in schematic editor
...
We weren't actually using the overlay group at all
Fixes https://gitlab.com/kicad/code/kicad/-/issues/11142
(cherry picked from commit 0f18a36f8f
)
2023-02-16 02:17:36 +00:00
Jon Evans
08c6d9ce96
Set PPI properly in schematic bitmaps, too
...
(cherry picked from commit e8a88411ea
)
2023-02-15 02:37:22 +00:00
Jon Evans
37091df142
Symbol chooser: save UI settings even when canceled
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13903
(cherry picked from commit 29c4482bc8
)
2023-02-14 18:27:31 -05:00
Jon Evans
21081cf80f
Handle custom columns in symbol tree synchronizing adapter
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13907
(cherry picked from commit 0913552f84
)
2023-02-14 18:27:21 -05:00