kicad/common
Jeff Young 919a66a703 Remove side-effect from finishTool().
It belongs out in the calling loop so that if someone else uses
finishTool() later they won't get bit by it.

This also fixes a crash bug where we weren't deactivating all tools
because we couldn't back up at the beginning of the stack (and the
loop increment therefore went past the first element).

Fixes https://gitlab.com/kicad/code/kicad/issues/4206
2020-04-16 21:58:45 +01:00
..
dialog_about DIALOG_ABOUT_BASE: fix a minor wxWidgets alert 2020-03-28 11:00:54 +01:00
dialogs Remove a bunch of globals. 2020-04-16 17:34:46 +01:00
gal Show/hide sheet colors when flipping override flag. 2020-04-10 00:35:17 +01:00
kicad_curl Expose curl_easy_escape via KICAD_CURL_EASY 2020-02-20 22:07:17 -05:00
libeval Switch to scoped enums 2019-12-20 14:11:39 +00:00
page_layout Remove a bunch of globals. 2020-04-16 17:34:46 +01:00
plotters Remove a bunch of globals. 2020-04-16 17:34:46 +01:00
preview_items Fix a minor compil warning. Add a wxASSERT in hierarch.cpp. 2020-01-18 18:23:21 +01:00
settings NESTED_SETTINGS: allow to create/load without a parent settings object. Used for test/mocking 2020-04-15 13:00:48 +02:00
swig Implement a new settings framework across all of KiCad 2020-02-19 23:44:56 -05:00
tool Remove side-effect from finishTool(). 2020-04-16 21:58:45 +01:00
view Implement a new settings framework across all of KiCad 2020-02-19 23:44:56 -05:00
widgets Fix crash on OSX when page was changed before hack array was alloc'ed. 2020-04-10 22:49:56 +01:00
CMakeLists.txt Remove a bunch of globals. 2020-04-16 17:34:46 +01:00
advanced_config.cpp Fix some build warnings 2020-04-06 00:31:45 +01:00
array_axis.cpp Pcbnew: add a step field to the array tool 2019-05-16 11:20:52 +01:00
array_options.cpp Arrays: isolate axis code in a new class 2019-05-16 11:20:52 +01:00
base64.cpp Plot SVG embedded 2019-12-08 08:57:33 -08:00
base_screen.cpp Refactor all math into a new kimath library 2020-01-07 17:12:59 +00:00
base_struct.cpp Don't allow selection flags to leak in to the libmanager cache. 2020-03-21 23:25:08 +00:00
base_units.cpp Eeschema: implement new symbol library file s-expression formatter. 2020-03-03 08:06:22 -05:00
basic_gal.cpp Cleanup: Replace push_back with emplace_back 2019-12-05 13:41:21 -08:00
bin_mod.cpp Rework the file history menus to not need references to the file history 2020-02-25 16:18:10 +00:00
bitmap.cpp Push tool framework base down into TOOL_HOLDER. 2020-03-24 19:00:25 +00:00
bitmap_base.cpp Fix Eeschema BW printing 2020-01-11 09:55:30 -08:00
board_printout.cpp Implement a new settings framework across all of KiCad 2020-02-19 23:44:56 -05:00
build_version.cpp Expose more version strings from CMake 2020-03-07 18:43:24 +00:00
colors.cpp
commit.cpp keepout in footprint: fix some crashes and issues. Create a specific type (PCB_MODULE_ZONE_AREA_T) for zones in footprint. The new class (MODULE_ZONE_CONTAINER) is the same as ZONE_CONTAINER, but the type ID is PCB_MODULE_ZONE_AREA_T instead of PCB_ZONE_AREA_T. 2019-10-29 11:24:57 +01:00
common.cpp Add text variable support to envVar processing. 2020-04-05 20:52:26 +01:00
config_params.cpp Add user-defined severities, exclusions and colors to DRC markers. 2020-03-04 00:39:28 +00:00
confirm.cpp Fix library table panel path adding and cleanup duplicate dialog 2020-02-14 19:07:27 +00:00
cursor_store.cpp Fix preprocessor expression 2020-03-01 00:33:45 +00:00
dialog_shim.cpp Cleanup redundant type casting 2020-01-13 14:00:45 +00:00
displlst.cpp Fix some issues with the previous commit. 2019-12-02 23:35:19 +00:00
dpi_scaling.cpp Implement a new settings framework across all of KiCad 2020-02-19 23:44:56 -05:00
draw_panel_gal.cpp Fix a couple crashes with small canvases 2020-03-04 14:33:42 -06:00
dsnlexer.cpp Revert "Don't be pedantic about the file format." 2018-03-16 18:11:36 +00:00
eagle_parser.cpp Convert timestamps to UUIDs. 2020-02-20 21:29:52 +00:00
eda_base_frame.cpp Unwrap an unnecessary layer now that we have new config stuff. 2020-04-13 20:58:12 +01:00
eda_dde.cpp Push KIWAY_HOLDER down a level so we can move a bunch of stuff that doesn't belong there out. 2019-06-10 23:46:00 +01:00
eda_doc.cpp Add text variable support to envVar processing. 2020-04-05 20:52:26 +01:00
eda_draw_frame.cpp Remove a bunch of globals. 2020-04-16 17:34:46 +01:00
eda_pattern_match.cpp C++14: Remove unused make_unique.h 2019-08-07 09:27:31 -07:00
eda_size_ctrl.cpp Switch to scoped enums 2019-12-20 14:11:39 +00:00
eda_text.cpp Remove a bunch of globals. 2020-04-16 17:34:46 +01:00
env_paths.cpp Test every environment variable when doing substitution to remove more directories 2020-02-14 22:59:18 +00:00
env_vars.cpp Add configuration of Hi-DPI canvas scaling in OpenGL 2019-03-25 15:00:55 +00:00
exceptions.cpp Fix bugs in Eeschema paste. 2019-08-15 10:00:23 +01:00
executable_names.cpp Move executable name constants to own file 2017-03-23 09:23:45 -04:00
filehistory.cpp Rework the file history menus to not need references to the file history 2020-02-25 16:18:10 +00:00
filename_resolver.cpp Add text variable support to envVar processing. 2020-04-05 20:52:26 +01:00
filter_reader.cpp Cleanup: Replace C-only deprecated headers 2019-12-05 11:03:15 -08:00
footprint_filter.cpp Cleanup to make implementation names consistent with what they now do. 2019-09-03 19:29:30 +01:00
footprint_info.cpp Move remaining hard-coded segment counts 2019-05-16 08:49:55 -07:00
fp_lib_table.cpp Implement a new settings framework across all of KiCad 2020-02-19 23:44:56 -05:00
gbr_metadata.cpp Fix build error and cleanup overzealous refactor changes 2020-02-14 00:56:41 +00:00
gestfich.cpp Properly escape spaces when opening PDFs on windows 2020-01-03 19:06:49 +00:00
getrunningmicrosecs.cpp Cleanup: Replace C-only deprecated headers 2019-12-05 11:03:15 -08:00
gl_context_mgr.cpp Dealing with inconsistent wxGLCanvas::IsDisplaySupported() 2018-06-11 12:26:59 +02:00
gr_basic.cpp Refactor all math into a new kimath library 2020-01-07 17:12:59 +00:00
gr_text.cpp Remove a bunch of globals. 2020-04-16 17:34:46 +01:00
grid_tricks.cpp Allow space to toggle all selected entries in a grid 2020-02-14 19:28:18 +00:00
hash_eda.cpp Gencad export: fix an issue in hash_eda calculation, that can generate the same hash for 2 different footprints. 2019-10-10 20:18:48 +02:00
hotkey_store.cpp Code cleanup for readibility. 2020-01-11 21:30:48 +00:00
hotkeys_basic.cpp Implement a new settings framework across all of KiCad 2020-02-19 23:44:56 -05:00
html_messagebox.cpp Pcbnew: fix size of graphics import warning dialog. 2019-09-06 14:57:04 -04:00
kiface_i.cpp Implement a new settings framework across all of KiCad 2020-02-19 23:44:56 -05:00
kiway.cpp Clean up compile warnings 2019-12-05 20:05:21 -08:00
kiway_express.cpp Support synchronous messaging over KIWAY EXPRESS. 2019-04-08 13:26:09 +01:00
kiway_holder.cpp Replace EESchema DLIST 2020-01-10 06:37:08 -08:00
kiway_player.cpp Push KIWAY_HOLDER down a level so we can move a bunch of stuff that doesn't belong there out. 2019-06-10 23:46:00 +01:00
languages_menu.cpp Add checking to languages menu. 2019-06-16 20:26:43 +01:00
launch_ext.cpp Fix URL launching on MacOS 2020-02-22 09:47:51 -05:00
layer_id.cpp Add user-configurability of the LibEdit axes color. 2020-03-24 19:00:25 +00:00
lib_id.cpp Fix build issue exposed by commit b824051a. 2020-02-07 15:29:03 -05:00
lib_table.keywords Added "enabled" parameter for LIB_TABLE_ROW 2017-11-21 08:18:06 -05:00
lib_table_base.cpp Add text variable support to envVar processing. 2020-04-05 20:52:26 +01:00
lib_tree_model.cpp Pinning for library trees in FPEditor and SymbolEditor. 2020-02-14 00:10:40 +00:00
lib_tree_model.h Pinning for library trees in FPEditor and SymbolEditor. 2020-02-14 00:10:40 +00:00
lib_tree_model_adapter.cpp Implement a different solution to refreshing lib trees. 2020-03-31 02:09:31 +01:00
lib_tree_model_adapter.h Implement a different solution to refreshing lib trees. 2020-03-31 02:09:31 +01:00
lockfile.cpp Move file locking utilities to a separate file 2017-03-23 09:23:45 -04:00
lset.cpp Refactor all math into a new kimath library 2020-01-07 17:12:59 +00:00
marker_base.cpp Remove a bunch of globals. 2020-04-16 17:34:46 +01:00
msgpanel.cpp Remove colours from message text items. 2018-07-17 15:11:40 +01:00
netlist.keywords ADDED: Pcbnew, add "pin function" (pin name in eeschema) to pads. 2019-11-23 09:12:43 +01:00
newstroke_font.cpp Correct cyrillic 'f' in newstroke 2020-02-12 14:08:02 -08:00
observable.cpp Coverity fixes (mostly initializing variables) 2017-02-01 17:31:55 +01:00
origin_viewitem.cpp Fix invalid std::array constructor causing MSVC illegal indirection error 2020-01-20 01:30:26 +00:00
page_info.cpp Fix code after renaming files 2018-01-29 11:37:29 +01:00
painter.cpp Remove a bunch of globals. 2020-04-16 17:34:46 +01:00
pcb.keywords Adding Arcs to TRACKS 2020-02-21 23:51:58 +00:00
pcb_plot_params.keywords Add Gerber job file writer in Pcbnew, and a basic reader in Gerbview. Currently disabled 2017-08-30 11:04:33 +02:00
pgm_base.cpp Implement a new settings framework across all of KiCad 2020-02-19 23:44:56 -05:00
prependpath.cpp
printout.cpp Implement a new settings framework across all of KiCad 2020-02-19 23:44:56 -05:00
project.cpp Tidy up some Coverity issues. 2020-04-07 17:29:58 +01:00
properties.cpp
ptree.cpp Cleanup: Replace C-only deprecated headers 2019-12-05 11:03:15 -08:00
rc_item.cpp DRC dialog: fix a crash when clicking on a item in Footprint Warning panel: 2020-03-28 11:00:54 +01:00
rc_item.h Improve some comments. 2020-03-30 14:15:59 +01:00
refdes_utils.cpp Fix broken GetReferencePrefix function 2019-01-30 15:41:36 -08:00
render_settings.cpp Remove a bunch of globals. 2020-04-16 17:34:46 +01:00
reporter.cpp Fix compil issues, especially on Windows: 2020-03-04 10:48:18 +01:00
richio.cpp Uniformly quote strings which may have user content. 2019-04-07 00:24:10 +01:00
search_stack.cpp Replace log debugging output with tracing. 2018-10-17 15:03:33 -04:00
searchhelpfilefullpath.cpp Replace log debugging output with tracing. 2018-10-17 15:03:33 -04:00
settings.cpp Fix a bunch of un-caught boost::bad_pointer exceptions. 2020-01-12 19:55:00 +00:00
single_top.cpp Implement a new settings framework across all of KiCad 2020-02-19 23:44:56 -05:00
status_popup.cpp Grid rid of GetCanvas/GetGalCanvas distinction now that there's only gal. 2019-06-13 19:58:37 +01:00
streamwrapper.cpp Replace WIN32 preprocessor symbol by the official symbol _WIN32, used almost everywhere 2018-10-20 09:22:24 +02:00
string.cpp Use proper encoding in UnescapeString() to speed up processing 2020-01-20 10:51:20 +00:00
strtok_r.c
systemdirsappend.cpp
template_fieldnames.cpp Fix some Coverity issues. 2020-04-06 12:31:59 +01:00
template_fieldnames.h Fix some Coverity issues. 2020-04-06 12:31:59 +01:00
template_fieldnames.keywords Variable substitution framework. 2020-03-30 14:15:59 +01:00
tools_holder.cpp Push tool framework base down into TOOL_HOLDER. 2020-03-24 19:00:25 +00:00
trace_helpers.cpp Add log trace for tool handling 2019-07-31 21:56:53 -06:00
undo_redo_container.cpp eeschema: Remove UR_WIRE_IMAGE 2019-04-13 07:11:24 -07:00
utf8.cpp Many callers of uni_forward are not expecting an exception. 2020-01-13 15:40:32 +00:00
validators.cpp Fix event handler type casting 2020-01-09 18:08:49 +00:00
wildcards_and_files_ext.cpp Use Record handling for parsing 2020-04-03 23:22:24 +00:00
wxdataviewctrl_helpers.cpp Move wxDataViewCtrl manipulators out of dialog_choose_component.cpp 2017-03-30 21:47:14 -04:00
xnode.cpp Escape slashes in labels and netnames. 2019-04-07 00:24:10 +01:00