kicad/eeschema
Wayne Stambaugh 83d6a77617 Eeschema: fix symbol rescue bug.
Loading the schematic symbol preserves the invalid LIB_ID characters in
the symbol name.  Unfortunately, loading the library symbol automatically
fixes the invalid characters so this caused the symbol rescue to not find
library symbols with invalid characters.  Replacing the invalid characters
in the schematic symbol name during rescue fixed the issue.  This fix
isn't perfect because there is the off chance that replacing the invalid
characters could lead to a name clash in the library resulting in the
incorrect symbol to be rescued.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/2319

(cherry picked from commit d90d734166)
2020-10-28 09:45:27 -04:00
..
dialogs eeschema: Only warn user about off-grid pins if the position has changed 2020-07-03 03:02:03 +01:00
libedit Fully freeze tree GUI 2020-10-23 12:35:14 -07:00
netlist_exporters Recognize subckt blocks in spice 2020-01-17 18:58:27 -08:00
plugins bom2grouped_csv.xsl: Fix sorting of grouped references 2020-08-06 10:14:26 +01:00
sim Fix compile errors on CLang. 2020-08-10 20:06:06 +01:00
widgets Fixup the UI for the symbol preview widget 2020-08-10 00:52:48 +01:00
CMakeLists.txt Fix macos plist version string generation 2020-01-18 01:44:01 +00:00
annotate.cpp Annotate dialog: fix incorrect list of changes in complex hierarchies 2020-03-09 18:28:39 +01:00
autoplace_fields.cpp Replace DIM() macro 2019-01-06 08:43:12 -08:00
backanno.cpp Add view refresh calls for edit operations. 2018-10-18 12:12:48 +01:00
block.cpp Fix a few wxWidget asserts related to not existing block operations from mouse drag command. 2019-10-10 10:07:15 +02:00
bom_plugins.cpp DIALOG_BOM: fix a few issues. Mainly an annoying issue when a plugin file was not found 2019-01-14 13:14:13 +01:00
bom_plugins.h DIALOG_BOM: fix a few issues. Mainly an annoying issue when a plugin file was not found 2019-01-14 13:14:13 +01:00
bus-wire-junction.cpp eeschema: Fix list invalidation 2019-08-05 09:03:38 -07:00
busentry.cpp Add view refresh calls for edit operations. 2018-10-18 12:12:48 +01:00
class_libentry.cpp Eeschema: fix rescue multiple unit symbol bug. 2020-04-02 09:31:25 -04:00
class_libentry.h eeschema: fixes related to translated and not translated field names. 2020-02-17 12:26:51 +01:00
class_library.cpp Coverity fixes. 2018-03-21 23:11:55 +00:00
class_library.h Implement poor-man's RTTI for use over KiWAY. 2018-09-15 20:06:42 +01:00
cmp_library.keywords
cmp_library_lexer.cpp
component_references_lister.cpp Break out ref-des-centric functions to own header 2019-01-30 15:41:36 -08:00
controle.cpp Fix bugs in keyboard cursor movement. 2019-07-05 01:32:15 +01:00
cross-probing.cpp eeschema: Refresh canvas after clearing 2019-02-23 11:07:00 -08:00
dialog_erc_listbox.h Add FocusOnLocation for second items in ERC markers. 2020-05-12 22:58:15 +01:00
drc_erc_item.cpp Add FocusOnLocation for second items in ERC markers. 2020-05-12 22:58:15 +01:00
edit_bitmap.cpp eeschema: Recache bitmaps when changing 2019-02-12 08:16:23 -08:00
edit_component_in_schematic.cpp Eeschema: move EDIT_COMPONENT_IN_SCHEMATIC to own header 2019-02-21 10:04:29 +00:00
edit_label.cpp Fixes dangling ends and rotation when labels/texts are converted into each other 2020-02-01 16:08:34 +00:00
eeredraw.cpp eeschema-gal: initial GALified version. Lots of stuff still to do! 2018-10-09 11:08:52 +01:00
eeschema.cpp Fix 'hokey' -> 'hotkey' typo 2019-04-02 13:17:18 -04:00
eeschema.icns Update MacOS icons 2018-03-22 11:45:42 -04:00
eeschema.rc
eeschema_config.cpp Eeschema: fix multiple sheet file name bugs. 2019-12-27 12:05:59 -05:00
eeschema_config.h Implement primitive icon scaling for high DPI 2018-01-10 21:26:06 -07:00
eeschema_doc.icns Update MacOS icons 2018-03-22 11:45:42 -04:00
eeschema_id.h Grid settings for Eeschema GAL. 2018-10-09 11:08:55 +01:00
erc.cpp eeschema-gal: initial GALified version. Lots of stuff still to do! 2018-10-09 11:08:52 +01:00
erc.h Eradicate g_UserUnit from ERC/DRC. 2018-07-17 15:12:16 +01:00
events_called_functions_for_edit.cpp Add GAL refresh for some more commands and remove unused DC params. 2018-10-09 11:08:56 +01:00
fields_grid_table.cpp Entries typed into the text size field should be read as mils 2020-08-11 00:52:05 +01:00
fields_grid_table.h Eeschema: fix corrupted schematic and symbol library files. 2019-05-10 09:16:38 -04:00
files-io.cpp Eeschema: fix segfault when auto save file is detected. 2020-09-01 10:29:06 -04:00
find.cpp Cross probing: Trying to fix a crash, certainly due to a call to clear the HIGHLIGHTED flag of a structure that is not a EDA_ITEM. 2018-12-31 13:54:26 +01:00
general.h Separate default line and wire thicknesses. 2019-06-30 11:13:17 +01:00
generate_alias_info.cpp eeschema: fixes related to translated and not translated field names. 2020-02-17 12:26:51 +01:00
generate_alias_info.h Convert component chooser dialog over to use symbol library table. 2017-11-09 18:50:18 -05:00
getpart.cpp Pcbnew: use same null check as eeschema for recently used 2019-04-29 17:00:42 +01:00
help_common_strings.h Added help string to select buttons. 2018-12-05 20:13:03 -08:00
hierarch.cpp eeschema: end mouse capture before exiting sheet 2019-05-28 21:19:21 -07:00
highlight_connection.cpp eeschema: Do not clear highlights with NULL screen 2018-12-08 07:54:31 -08:00
hotkeys.cpp Add Ctrl+, hotkey to preferences dialog 2019-04-02 13:17:37 -04:00
hotkeys.h Fix 'hokey' -> 'hotkey' typo 2019-04-02 13:17:18 -04:00
invoke_sch_dialog.h Decouple SCH_EDIT_FRAME from symbol rescue and remap dialogs. 2019-02-05 12:43:46 -05:00
lib_arc.cpp eeschema: Fix plot line width for negative lines 2019-03-11 12:38:19 -07:00
lib_arc.h eeschema-gal: initial GALified version. Lots of stuff still to do! 2018-10-09 11:08:52 +01:00
lib_bezier.cpp eeschema: Fix plot line width for negative lines 2019-03-11 12:38:19 -07:00
lib_bezier.h eeschema: SCH_PAINTER should draw LIB_BEZIERs too! 2019-02-19 10:42:23 +01:00
lib_circle.cpp eeschema: Fix plot line width for negative lines 2019-03-11 12:38:19 -07:00
lib_circle.h eeschema-gal: initial GALified version. Lots of stuff still to do! 2018-10-09 11:08:52 +01:00
lib_collectors.cpp rename class_collector.h to collector.h 2018-02-04 10:49:37 +01:00
lib_collectors.h rename class_collector.h to collector.h 2018-02-04 10:49:37 +01:00
lib_draw_item.cpp eeschema: Prevent invalid '0' element in components 2019-04-15 12:32:29 -07:00
lib_draw_item.h eeschema: Prevent invalid '0' element in components 2019-04-15 12:32:29 -07:00
lib_field.cpp eeschema: fixes related to translated and not translated field names. 2020-02-17 12:26:51 +01:00
lib_field.h eeschema: fixes related to translated and not translated field names. 2020-02-17 12:26:51 +01:00
lib_pin.cpp Eeschema: fix issues with pin shapes related to clock input pin shapes. 2019-10-08 10:11:56 +02:00
lib_pin.h Handle hidden and dangling pins. 2018-10-09 11:08:55 +01:00
lib_polyline.cpp Apply relevant fixes from 51479c2042. 2019-06-29 21:17:22 +01:00
lib_polyline.h eeschema-gal: initial GALified version. Lots of stuff still to do! 2018-10-09 11:08:52 +01:00
lib_rectangle.cpp eeschema: Fix plot line width for negative lines 2019-03-11 12:38:19 -07:00
lib_rectangle.h eeschema-gal: initial GALified version. Lots of stuff still to do! 2018-10-09 11:08:52 +01:00
lib_text.cpp Adjust justified text for mirroring and rotation. 2020-02-05 22:20:16 +00:00
lib_text.h Adjust justified text for mirroring and rotation. 2020-02-05 22:20:16 +00:00
libarch.cpp Eeschema: fix rescue multiple unit symbol bug. 2020-04-02 09:31:25 -04:00
list_operations.h Update moved items so they get reinserted into the RTree. 2018-10-09 11:08:56 +01:00
menubar.cpp Add Ctrl+, hotkey to preferences dialog 2019-04-02 13:17:37 -04:00
netlist.h Fixed Spice netlist export options and added a few new flags 2016-08-11 14:41:20 +02:00
netlist_generator.cpp Output defined default fields to netlists & BOMs. 2018-05-24 18:24:59 +01:00
netlist_object.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
netlist_object.h fix misspelled 'an other' -> 'another' 2018-04-08 13:24:37 -04:00
netlist_object_list.cpp Remove not used ListNets() methods 2018-03-04 18:04:19 +01:00
onleftclick.cpp Revert eeschema highlighting changes 2020-02-05 11:51:46 +00:00
onrightclick.cpp eeschema: Don't warp before processing right-click 2019-10-17 13:49:49 -07:00
operations_on_items_lists.cpp Finish up remaining block operation inconsistencies. 2018-11-14 23:45:32 +00:00
pin_number.cpp Added an include to tell the compiler where to find wxIsdigit 2019-03-24 15:38:59 +01:00
pin_number.h
pin_shape.cpp Remove some extra semicolons 2017-11-09 19:52:18 +01:00
pin_shape.h
pin_type.cpp
pin_type.h
plot_schematic_DXF.cpp Eeschema: use worksheet color when plotting 2019-05-26 12:21:08 -04:00
plot_schematic_HPGL.cpp Eeschema: use worksheet color when plotting 2019-05-26 12:21:08 -04:00
plot_schematic_PDF.cpp Eeschema: use worksheet color when plotting 2019-05-26 12:21:08 -04:00
plot_schematic_PS.cpp Eeschema: use worksheet color when plotting 2019-05-26 12:21:08 -04:00
plot_schematic_SVG.cpp Eeschema: use worksheet color when plotting 2019-05-26 12:21:08 -04:00
project_rescue.cpp Eeschema: fix symbol rescue bug. 2020-10-28 09:45:27 -04:00
project_rescue.h Eeschema: fix rescue multiple unit symbol bug. 2020-04-02 09:31:25 -04:00
sch_base_frame.cpp Fix cherry pick error on previous commit. 2020-04-02 16:09:25 -04:00
sch_base_frame.h Symbol editor: fix issues related to axis not shown. 2019-02-24 12:56:17 +01:00
sch_bitmap.cpp Eeschema: Normalize layer ordering between plot and screen 2019-06-19 10:49:28 -07:00
sch_bitmap.h Eeschema gal: fix some redraw issues for bitmap images and worksheet. 2018-10-16 14:20:09 +02:00
sch_bus_entry.cpp Separate default line and wire thicknesses. 2019-06-30 11:13:17 +01:00
sch_bus_entry.h Implement proper dangling end handling for block moves. 2018-10-30 11:33:49 +00:00
sch_collectors.cpp Allow no-connects to be dragged. 2019-04-09 11:20:03 +01:00
sch_collectors.h Add hotkey for viewing symbol datasheet. 2018-09-24 15:46:45 +01:00
sch_component.cpp Annotate dialog: fix incorrect list of changes in complex hierarchies 2020-03-09 18:28:39 +01:00
sch_component.h Annotate dialog: fix incorrect list of changes in complex hierarchies 2020-03-09 18:28:39 +01:00
sch_draw_panel.cpp Eeschema: Check twice before using GAL 2019-12-10 16:01:59 -08:00
sch_draw_panel.h gal: pixel alignment hacks, works for Retina display too now. 2019-02-16 20:03:13 +01:00
sch_eagle_plugin.cpp Eeschema: fix sheet bug in schematic editor drawing tool. 2020-05-11 16:33:40 -04:00
sch_eagle_plugin.h Eagle SCH importer: fix slash characters when fixing symbol names 2018-09-12 10:13:13 +02:00
sch_edit_frame.cpp Eeschema: fix multiple sheet file name bugs. 2019-12-27 12:05:59 -05:00
sch_edit_frame.h Eeschema: fix multiple sheet file name bugs. 2019-12-27 12:05:59 -05:00
sch_field.cpp eeschema-gal: initial GALified version. Lots of stuff still to do! 2018-10-09 11:08:52 +01:00
sch_field.h Remove global units usage from GetSelectionText... 2018-07-17 15:11:09 +01:00
sch_io_mgr.cpp Fix quotes in UI messages 2017-12-15 07:33:07 -05:00
sch_io_mgr.h Eeschema: allow for partial schematic loading. 2017-12-06 19:11:09 -05:00
sch_item_struct.cpp units: Move common units and add tests 2019-01-08 09:29:32 -08:00
sch_item_struct.h units: Move common units and add tests 2019-01-08 09:29:32 -08:00
sch_junction.cpp Eeschema: fix large diffs when saving schematics. 2020-08-06 09:27:14 -04:00
sch_junction.h Eeschema: fix large diffs when saving schematics. 2020-08-06 09:27:14 -04:00
sch_legacy_plugin.cpp Eeschema: fix partial schematic load bug in the legacy plugin. 2020-05-11 16:45:11 -04:00
sch_legacy_plugin.h SCH_LEGACY_PLUGIN::loadHierarchy() uses a stack to maintain sheet paths 2018-05-09 11:30:23 +02:00
sch_line.cpp Performance enhancement. 2019-09-09 23:22:29 +01:00
sch_line.h eeschema: Find the closest line end to the mouse when grabbing 2019-09-06 14:16:56 -07:00
sch_marker.cpp classes MARKER rework: remove duplicate code. Better HitTest code (HitTest takes in account the actual shape) 2018-12-19 19:53:27 +01:00
sch_marker.h classes MARKER rework: remove duplicate code. Better HitTest code (HitTest takes in account the actual shape) 2018-12-19 19:53:27 +01:00
sch_no_connect.cpp Move no-connect symbols closer to the front for rendering. 2018-11-13 21:03:18 +00:00
sch_no_connect.h Move no-connect symbols closer to the front for rendering. 2018-11-13 21:03:18 +00:00
sch_painter.cpp Eeschema: fix issues with pin shapes related to clock input pin shapes. 2019-10-08 10:11:56 +02:00
sch_painter.h Eeschema: do not draw dangling symbol (circle) for PIN_NC pin types. These pins are never connected, so a dangling symbol makes no sense. 2019-03-17 20:52:42 +01:00
sch_plugin.cpp Fix quotes in UI messages 2017-12-15 07:33:07 -05:00
sch_preview_panel.cpp Hide the scrollbars on the symbol preview canvas 2020-08-09 23:13:03 +01:00
sch_preview_panel.h Move symbol chooser dialog preview to GAL. 2018-10-09 11:08:55 +01:00
sch_reference_list.h Performance optimization for Symbol Fields Editor. 2018-10-17 02:04:44 +01:00
sch_screen.cpp Eeschema: fix sheet file name case sensitivity test. 2019-12-27 12:08:13 -05:00
sch_screen.h Eeschema: fix multiple sheet file name bugs. 2019-12-27 12:05:59 -05:00
sch_sheet.cpp Eeschema: fix sheet bug in schematic editor drawing tool. 2020-05-11 16:33:40 -04:00
sch_sheet.h Eeschema: fix sheet bug in schematic editor drawing tool. 2020-05-11 16:33:40 -04:00
sch_sheet_path.cpp Eeschema: Add bit that was missing from commit 7ac83ac64 2020-01-27 09:43:07 -08:00
sch_sheet_path.h fix misspelled 'allows to' -> 'allows one to' 2018-07-11 10:35:03 -04:00
sch_sheet_pin.cpp eeschema-gal: initial GALified version. Lots of stuff still to do! 2018-10-09 11:08:52 +01:00
sch_text.cpp eeschema: Handle broken spin style value 2019-09-06 13:18:34 -07:00
sch_text.h Implement proper dangling end handling for block moves. 2018-10-30 11:33:49 +00:00
sch_validators.cpp Don't tie generic validators to a specific field 2020-01-15 16:12:39 +00:00
sch_validators.h Don't tie generic validators to a specific field 2020-01-15 16:12:39 +00:00
sch_view.cpp Cross probing: Trying to fix a crash, certainly due to a call to clear the HIGHLIGHTED flag of a structure that is not a EDA_ITEM. 2018-12-31 13:54:26 +01:00
sch_view.h Eeschema: Normalize layer ordering between plot and screen 2019-06-19 10:49:28 -07:00
schedit.cpp Initialize clear annotation variable to false so they aren't cleared by accident 2020-08-08 23:24:36 +01:00
schematic_undo_redo.cpp eeschema: Recache bitmaps when changing 2019-02-12 08:16:23 -08:00
selpart.cpp Handle separate parsing rules for ID_SCH and ID_PCB. 2018-07-26 15:43:53 +01:00
sheet.cpp Eeschema: fix broken new sheet path comparison on windows. 2020-09-03 14:26:31 -04:00
sheetlab.cpp Add GAL refresh for some more commands and remove unused DC params. 2018-10-09 11:08:56 +01:00
simulation_cursors.cpp Eeschema: construct simulator cursors on demand 2019-04-02 19:08:26 +01:00
simulation_cursors.h Eeschema: construct simulator cursors on demand 2019-04-02 19:08:26 +01:00
symbol_lib_table.cpp Do not use project path when searching for default library tables. 2019-01-26 16:19:02 -05:00
symbol_lib_table.h Implement poor-man's RTTI for use over KiWAY. 2018-09-15 20:06:42 +01:00
symbol_tree_model_adapter.cpp More performance enhancements. 2018-08-06 13:49:27 +01:00
symbol_tree_model_adapter.h Push component tree down into common. 2018-08-01 09:35:45 +01:00
symbol_tree_synchronizing_adapter.cpp Eeschema, symbol tree selector: make the selected lib and symbol readable. 2019-08-28 09:34:46 +02:00
symbol_tree_synchronizing_adapter.h LibEdit: fix library tree refresh issue when library is removed. 2019-06-13 08:59:26 -04:00
template_fieldnames.cpp Allow TemplateFieldNames to specify URL-behaviour. 2018-08-11 17:14:27 +01:00
template_fieldnames.h Allow TemplateFieldNames to specify URL-behaviour. 2018-08-11 17:14:27 +01:00
template_fieldnames.keywords Allow TemplateFieldNames to specify URL-behaviour. 2018-08-11 17:14:27 +01:00
tool_sch.cpp Fix 'hokey' -> 'hotkey' typo 2019-04-02 13:17:18 -04:00
tool_viewlib.cpp toolbars_lib_view.cpp and toolbars_libedit.cpp: do not 2020-05-30 15:57:18 +02:00
transform.cpp Fix code after renaming files 2018-01-29 11:37:29 +01:00
transform.h Remove unnecessary TRANSFORM::operator= 2017-02-19 22:13:50 -05:00
viewlib_frame.cpp toolbars_lib_view.cpp and toolbars_libedit.cpp: do not 2020-05-30 15:57:18 +02:00
viewlib_frame.h Add pre-select architecture to grid helper icon-text-buttons. 2019-01-31 01:09:03 +00:00
viewlibs.cpp eeschema: Prevent invalid '0' element in components 2019-04-15 12:32:29 -07:00