kicad/eeschema
John Beard edd94ce2d6 Eeschema: internal tidying of field editor ApplyData
Make a few things const (specficially the reference into
m_fieldStore - we should commit to not modifying that in this
function.

Also avoid a couple of needless string copies.

Also explicitly dereference the into a (non-const) reference at the outset.
For the whole if this function, comp is the same object and may not
be null (as it is used unchecked).
2019-03-27 10:22:21 +00:00
..
dialogs Eeschema: internal tidying of field editor ApplyData 2019-03-27 10:22:21 +00:00
libedit Move env var substitution into GetAssociatedDocument 2019-03-10 08:39:36 -07:00
netlist_exporters eeschema: Export coupling constants to netlist 2019-02-09 18:58:33 -08:00
plugins Sort reference by their numeric content. 2018-10-28 17:45:11 +00:00
sim Link eeschema with ngspice DLL 2018-10-30 08:32:38 +01:00
widgets Eeschema: avoid using a incorrect background color the first time a SCH_DRAW_PANEL is displayed 2019-01-25 20:32:46 +01:00
CMakeLists.txt Restore LINK_MAP linker options 2019-03-16 20:37:14 -07:00
Info.plist Fix for dark mode on macOS Mojave 2018-12-07 09:03:56 +01:00
annotate.cpp Add view refresh calls for edit operations. 2018-10-18 12:12:48 +01:00
autoplace_fields.cpp Replace DIM() macro 2019-01-06 08:43:12 -08:00
backanno.cpp Add view refresh calls for edit operations. 2018-10-18 12:12:48 +01:00
block.cpp Mark block for AppendUndo when a command is executed. 2019-02-17 10:38:06 +00:00
bom_plugins.cpp DIALOG_BOM: fix a few issues. Mainly an annoying issue when a plugin file was not found 2019-01-14 13:14:13 +01:00
bom_plugins.h DIALOG_BOM: fix a few issues. Mainly an annoying issue when a plugin file was not found 2019-01-14 13:14:13 +01:00
bus-wire-junction.cpp Don't trim entire wires. 2018-11-20 21:44:35 +00:00
busentry.cpp Add view refresh calls for edit operations. 2018-10-18 12:12:48 +01:00
class_libentry.cpp Ensure LIB_ALIAS elements are always drawn 2019-03-10 20:16:03 -07:00
class_libentry.h Ensure LIB_ALIAS elements are always drawn 2019-03-10 20:16:03 -07:00
class_library.cpp Coverity fixes. 2018-03-21 23:11:55 +00:00
class_library.h Implement poor-man's RTTI for use over KiWAY. 2018-09-15 20:06:42 +01:00
cmp_library.keywords 1) Add "rules" to base of tree for copying into BZR_HOME/rules. 2013-05-25 23:36:44 -05:00
cmp_library_lexer.cpp 1) Add "rules" to base of tree for copying into BZR_HOME/rules. 2013-05-25 23:36:44 -05:00
component_references_lister.cpp Break out ref-des-centric functions to own header 2019-01-30 15:41:36 -08:00
controle.cpp Eeschema: regression fix: re-enable hold down control+shift to disable grid snapping when moving the mouse. 2019-02-12 13:12:06 +01:00
cross-probing.cpp eeschema: Refresh canvas after clearing 2019-02-23 11:07:00 -08:00
dialog_erc_listbox.h eeschema-gal: initial GALified version. Lots of stuff still to do! 2018-10-09 11:08:52 +01:00
drc_erc_item.cpp Eeschema: fix grammar for text for ERCE_PIN_NOT_DRIVEN 2019-01-29 18:09:11 -05:00
edit_bitmap.cpp eeschema: Recache bitmaps when changing 2019-02-12 08:16:23 -08:00
edit_component_in_schematic.cpp Eeschema: move EDIT_COMPONENT_IN_SCHEMATIC to own header 2019-02-21 10:04:29 +00:00
edit_label.cpp Replace isdigit() with wxIsdigit() when testing wxString characters. 2019-03-14 09:47:14 -04:00
eeredraw.cpp eeschema-gal: initial GALified version. Lots of stuff still to do! 2018-10-09 11:08:52 +01:00
eeschema.cpp Replace DIM() macro 2019-01-06 08:43:12 -08:00
eeschema.icns Update MacOS icons 2018-03-22 11:45:42 -04:00
eeschema.rc Remove old xpm icons files 2012-04-07 13:09:57 +02:00
eeschema_config.cpp libtree: Remember pane width 2019-02-12 10:06:36 -08:00
eeschema_config.h Implement primitive icon scaling for high DPI 2018-01-10 21:26:06 -07:00
eeschema_doc.icns Update MacOS icons 2018-03-22 11:45:42 -04:00
eeschema_id.h Grid settings for Eeschema GAL. 2018-10-09 11:08:55 +01:00
erc.cpp eeschema-gal: initial GALified version. Lots of stuff still to do! 2018-10-09 11:08:52 +01:00
erc.h Eradicate g_UserUnit from ERC/DRC. 2018-07-17 15:12:16 +01:00
events_called_functions_for_edit.cpp Add GAL refresh for some more commands and remove unused DC params. 2018-10-09 11:08:56 +01:00
fields_grid_table.cpp Move env var substitution into GetAssociatedDocument 2019-03-10 08:39:36 -07:00
fields_grid_table.h Remove previous cell selection fixes in favour of slow-click hack. 2019-03-04 11:09:33 +00:00
files-io.cpp Unify and correct Autosave functions 2019-03-18 10:25:26 -07:00
find.cpp Cross probing: Trying to fix a crash, certainly due to a call to clear the HIGHLIGHTED flag of a structure that is not a EDA_ITEM. 2018-12-31 13:54:26 +01:00
general.h libtree: Remember pane width 2019-02-12 10:06:36 -08:00
generate_alias_info.cpp Improve document file handling. 2018-08-14 13:54:04 +01:00
generate_alias_info.h Convert component chooser dialog over to use symbol library table. 2017-11-09 18:50:18 -05:00
getpart.cpp eeschema: Update pin cache after conversion 2019-02-15 18:30:45 -08:00
help_common_strings.h Added help string to select buttons. 2018-12-05 20:13:03 -08:00
hierarch.cpp Eeschema: shows the opened sheet info in title bar. 2019-03-15 13:09:04 +01:00
highlight_connection.cpp eeschema: Do not clear highlights with NULL screen 2018-12-08 07:54:31 -08:00
hotkeys.cpp libedit: Fix missing canvas selection 2019-02-18 18:26:03 -08:00
hotkeys.h add option to switch between opengl and cairo in eeschema (step 1) 2018-10-09 11:08:56 +01:00
invoke_sch_dialog.h Decouple SCH_EDIT_FRAME from symbol rescue and remap dialogs. 2019-02-05 12:43:46 -05:00
lib_arc.cpp eeschema: Fix plot line width for negative lines 2019-03-11 12:08:16 -07:00
lib_arc.h eeschema-gal: initial GALified version. Lots of stuff still to do! 2018-10-09 11:08:52 +01:00
lib_bezier.cpp eeschema: Fix plot line width for negative lines 2019-03-11 12:08:16 -07:00
lib_bezier.h eeschema: SCH_PAINTER should draw LIB_BEZIERs too! 2019-02-19 10:42:23 +01:00
lib_circle.cpp eeschema: Fix plot line width for negative lines 2019-03-11 12:08:16 -07:00
lib_circle.h eeschema-gal: initial GALified version. Lots of stuff still to do! 2018-10-09 11:08:52 +01:00
lib_collectors.cpp rename class_collector.h to collector.h 2018-02-04 10:49:37 +01:00
lib_collectors.h rename class_collector.h to collector.h 2018-02-04 10:49:37 +01:00
lib_draw_item.cpp Remove AdvanceDepth() hacks in favour of proper layers. 2018-10-21 15:55:56 +01:00
lib_draw_item.h Remove AdvanceDepth() hacks in favour of proper layers. 2018-10-21 15:55:56 +01:00
lib_field.cpp libedit: Allow SPICE parameter editing 2019-01-09 21:43:23 -08:00
lib_field.h Minor fixes in code: remove dead code. 2019-01-24 18:23:57 +01:00
lib_pin.cpp libedit: Set initial pin properties when editing 2019-02-15 16:00:39 -08:00
lib_pin.h Handle hidden and dangling pins. 2018-10-09 11:08:55 +01:00
lib_polyline.cpp eeschema: Fix plot line width for negative lines 2019-03-11 12:08:16 -07:00
lib_polyline.h eeschema-gal: initial GALified version. Lots of stuff still to do! 2018-10-09 11:08:52 +01:00
lib_rectangle.cpp eeschema: Fix plot line width for negative lines 2019-03-11 12:08:16 -07:00
lib_rectangle.h eeschema-gal: initial GALified version. Lots of stuff still to do! 2018-10-09 11:08:52 +01:00
lib_text.cpp Move library text items to LAYER_DEVICE. Only sch text items belong on LAYER_NOTES. 2018-10-28 17:45:11 +00:00
lib_text.h Remove AdvanceDepth() hacks in favour of proper layers. 2018-10-21 15:55:56 +01:00
libarch.cpp Add more/better error messages for file i/o problems. 2018-08-14 13:54:04 +01:00
list_operations.h Update moved items so they get reinserted into the RTree. 2018-10-09 11:08:56 +01:00
menubar.cpp Unify library browser terminology. 2019-01-30 19:52:15 +00:00
netlist.h Fixed Spice netlist export options and added a few new flags 2016-08-11 14:41:20 +02:00
netlist_generator.cpp Output defined default fields to netlists & BOMs. 2018-05-24 18:24:59 +01:00
netlist_object.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
netlist_object.h fix misspelled 'an other' -> 'another' 2018-04-08 13:24:37 -04:00
netlist_object_list.cpp Remove not used ListNets() methods 2018-03-04 18:04:19 +01:00
onleftclick.cpp eeschema: Recache bitmaps when changing 2019-02-12 08:16:23 -08:00
onrightclick.cpp Eeschema highlight symbols (cross probing) fix a few issues. 2018-12-29 12:48:24 +01:00
operations_on_items_lists.cpp Finish up remaining block operation inconsistencies. 2018-11-14 23:45:32 +00:00
pin_number.cpp Added an include to tell the compiler where to find wxIsdigit 2019-03-14 09:28:24 -07:00
pin_number.h Add pin number summary 2016-01-13 14:17:54 -05:00
pin_shape.cpp Remove some extra semicolons 2017-11-09 19:52:18 +01:00
pin_shape.h Enum refactoring and shiny icons in dialog_lib_edit_pin_table 2016-02-28 18:33:29 +01:00
pin_type.cpp Enum refactoring and shiny icons in dialog_lib_edit_pin_table 2016-02-28 18:33:29 +01:00
pin_type.h Enum refactoring and shiny icons in dialog_lib_edit_pin_table 2016-02-28 18:33:29 +01:00
plot_schematic_DXF.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
plot_schematic_HPGL.cpp UNIT_BINDERize print and plot dialogs. 2018-07-17 15:12:29 +01:00
plot_schematic_PDF.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
plot_schematic_PS.cpp fix code after renamin files 2018-01-30 11:49:51 +01:00
plot_schematic_SVG.cpp eeschema-gal: initial GALified version. Lots of stuff still to do! 2018-10-09 11:08:52 +01:00
project_rescue.cpp Eeschema: fix broken modified flag handling. 2019-02-06 13:20:34 -05:00
project_rescue.h Decouple SCH_EDIT_FRAME from symbol rescue and remap dialogs. 2019-02-05 12:43:46 -05:00
sch_base_frame.cpp Pcbnew: avoid integer overflow when displaying local coordinates. 2019-02-14 10:57:22 +01:00
sch_base_frame.h Symbol editor: fix issues related to axis not shown. 2019-02-24 12:56:17 +01:00
sch_bitmap.cpp bitmaps: Handle mask colors 2019-02-07 21:27:43 -08:00
sch_bitmap.h Eeschema gal: fix some redraw issues for bitmap images and worksheet. 2018-10-16 14:20:09 +02:00
sch_bus_entry.cpp Implement proper dangling end handling for block moves. 2018-10-30 11:33:49 +00:00
sch_bus_entry.h Implement proper dangling end handling for block moves. 2018-10-30 11:33:49 +00:00
sch_collectors.cpp eeschema: Rotate bus wire entry components 2019-01-28 09:55:56 -08:00
sch_collectors.h Add hotkey for viewing symbol datasheet. 2018-09-24 15:46:45 +01:00
sch_component.cpp Replace isdigit() with wxIsdigit() when testing wxString characters. 2019-03-14 09:47:14 -04:00
sch_component.h eeschema: Add directly connected items to block 2019-01-10 17:28:29 -08:00
sch_draw_panel.cpp Eeschema: fix incorrect handling of Escape key. 2019-03-27 10:09:16 +01:00
sch_draw_panel.h gal: pixel alignment hacks, works for Retina display too now. 2019-02-16 20:03:13 +01:00
sch_eagle_plugin.cpp eagle: Set default pin type 2019-01-06 08:54:14 -08:00
sch_eagle_plugin.h Eagle SCH importer: fix slash characters when fixing symbol names 2018-09-12 10:13:13 +02:00
sch_edit_frame.cpp Unify and correct Autosave functions 2019-03-18 10:25:26 -07:00
sch_edit_frame.h eeschema: Recache bitmaps when changing 2019-02-12 08:16:23 -08:00
sch_field.cpp eeschema-gal: initial GALified version. Lots of stuff still to do! 2018-10-09 11:08:52 +01:00
sch_field.h Remove global units usage from GetSelectionText... 2018-07-17 15:11:09 +01:00
sch_io_mgr.cpp Fix quotes in UI messages 2017-12-15 07:33:07 -05:00
sch_io_mgr.h Eeschema: allow for partial schematic loading. 2017-12-06 19:11:09 -05:00
sch_item_struct.cpp units: Move common units and add tests 2019-01-08 09:29:32 -08:00
sch_item_struct.h units: Move common units and add tests 2019-01-08 09:29:32 -08:00
sch_junction.cpp Remove AdvanceDepth() hacks in favour of proper layers. 2018-10-21 15:55:56 +01:00
sch_junction.h eeschema: Add directly connected items to block 2019-01-10 17:28:29 -08:00
sch_legacy_plugin.cpp Force time stamp to 32 bits unsigned values, and make it tolerant to files using 64 bits values. 2019-03-26 14:28:14 +01:00
sch_legacy_plugin.h Fix coding policy violations of previous patch. 2019-03-15 09:09:42 -04:00
sch_line.cpp Don't show dangling symbols at ends of wires with no-connect flags. 2018-11-27 14:44:13 +00:00
sch_line.h Implement proper dangling end handling for block moves. 2018-10-30 11:33:49 +00:00
sch_marker.cpp classes MARKER rework: remove duplicate code. Better HitTest code (HitTest takes in account the actual shape) 2018-12-19 19:53:27 +01:00
sch_marker.h classes MARKER rework: remove duplicate code. Better HitTest code (HitTest takes in account the actual shape) 2018-12-19 19:53:27 +01:00
sch_no_connect.cpp Move no-connect symbols closer to the front for rendering. 2018-11-13 21:03:18 +00:00
sch_no_connect.h Move no-connect symbols closer to the front for rendering. 2018-11-13 21:03:18 +00:00
sch_painter.cpp Eeschema: do not draw dangling symbol (circle) for PIN_NC pin types. 2019-03-17 20:50:18 +01:00
sch_painter.h Eeschema: do not draw dangling symbol (circle) for PIN_NC pin types. 2019-03-17 20:50:18 +01:00
sch_plugin.cpp Fix quotes in UI messages 2017-12-15 07:33:07 -05:00
sch_preview_panel.cpp Worksheet display in GAL mode: fix missing filename and (in Eeschema) sheet full name. 2018-11-19 10:21:28 +01:00
sch_preview_panel.h Move symbol chooser dialog preview to GAL. 2018-10-09 11:08:55 +01:00
sch_reference_list.h Performance optimization for Symbol Fields Editor. 2018-10-17 02:04:44 +01:00
sch_screen.cpp Libedit: transfer current screen settings on part load 2019-02-08 22:56:05 +00:00
sch_screen.h Handle GAL view refresh for breaking wires. 2018-10-09 11:08:55 +01:00
sch_sheet.cpp Move sheet pins in front of sheetedge & move them in by ½ line width 2018-12-15 20:15:19 +00:00
sch_sheet.h Implement proper dangling end handling for block moves. 2018-10-30 11:33:49 +00:00
sch_sheet_path.cpp Fix -Wshadow warning in sch_sheet_path.cpp 2018-06-28 10:04:43 -04:00
sch_sheet_path.h fix misspelled 'allows to' -> 'allows one to' 2018-07-11 10:35:03 -04:00
sch_sheet_pin.cpp eeschema-gal: initial GALified version. Lots of stuff still to do! 2018-10-09 11:08:52 +01:00
sch_text.cpp eeschema: Take stroke thickness into account 2019-01-25 14:22:19 -08:00
sch_text.h Implement proper dangling end handling for block moves. 2018-10-30 11:33:49 +00:00
sch_validators.cpp Improve validation of symbol fields editor. 2018-07-21 21:28:13 +01:00
sch_validators.h Improve validation of symbol fields editor. 2018-07-21 21:28:13 +01:00
sch_view.cpp Cross probing: Trying to fix a crash, certainly due to a call to clear the HIGHLIGHTED flag of a structure that is not a EDA_ITEM. 2018-12-31 13:54:26 +01:00
sch_view.h Eeschema highlight symbols (cross probing) fix a few issues. 2018-12-29 12:48:24 +01:00
schedit.cpp Move env var substitution into GetAssociatedDocument 2019-03-10 08:39:36 -07:00
schematic_undo_redo.cpp eeschema: Recache bitmaps when changing 2019-02-12 08:16:23 -08:00
selpart.cpp Handle separate parsing rules for ID_SCH and ID_PCB. 2018-07-26 15:43:53 +01:00
sheet.cpp Update dangling ends when resizing sheet. 2018-11-30 21:34:18 +00:00
sheetlab.cpp Add GAL refresh for some more commands and remove unused DC params. 2018-10-09 11:08:56 +01:00
symbol_lib_table.cpp Do not use project path when searching for default library tables. 2019-01-26 16:19:02 -05:00
symbol_lib_table.h Implement poor-man's RTTI for use over KiWAY. 2018-09-15 20:06:42 +01:00
symbol_tree_model_adapter.cpp More performance enhancements. 2018-08-06 13:49:27 +01:00
symbol_tree_model_adapter.h Push component tree down into common. 2018-08-01 09:35:45 +01:00
symbol_tree_synchronizing_adapter.cpp Minor performance enhancements to symbol loading. 2018-08-07 17:01:44 +01:00
symbol_tree_synchronizing_adapter.h Push component tree down into common. 2018-08-01 09:35:45 +01:00
template_fieldnames.cpp Allow TemplateFieldNames to specify URL-behaviour. 2018-08-11 17:14:27 +01:00
template_fieldnames.h Allow TemplateFieldNames to specify URL-behaviour. 2018-08-11 17:14:27 +01:00
template_fieldnames.keywords Allow TemplateFieldNames to specify URL-behaviour. 2018-08-11 17:14:27 +01:00
tool_sch.cpp Added help string to select buttons. 2018-12-05 20:13:03 -08:00
tool_viewlib.cpp Fix up GAL version of Symbol Viewer. 2018-10-09 11:08:55 +01:00
transform.cpp Fix code after renaming files 2018-01-29 11:37:29 +01:00
transform.h Remove unnecessary TRANSFORM::operator= 2017-02-19 22:13:50 -05:00
viewlib_frame.cpp libtree: Remember pane width 2019-02-12 10:06:36 -08:00
viewlib_frame.h Add pre-select architecture to grid helper icon-text-buttons. 2019-01-31 01:09:03 +00:00
viewlibs.cpp Load currently selected alias when browsing. 2019-01-30 19:43:52 +00:00