haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
kicad/common/dialogs
History
Wayne Stambaugh 66f6168163 Fix mode-less dialog issues. 
Don't assume the dialog is mode-less and call Destroy() from within a
dialog method.  This will most assuredly crash if the dialog is shown
modally or quasi-modally.

Don't leak memory for mode-less dialogs created on the stack.  Make sure
when the parent frame window is closed that all mode-less dialog memory
is cleaned up.  Dialogs are not child windows like controls and toolbars
so their memory does not automatically get cleaned up when the parent
window is destroyed.

Do not directly access frame parent window's pointer in dialog destructors.
Apparently the tear down order when destroying mode-less dialogs is not
guaranteed so the parent window may get deleted before the dialog causing
a crash when accessing the parent window pointer from the dialog dtor.

Do not close mode-less dialogs in the parent frame's destructor.  This
doesn't guarantee that the dialog(s) will be destroyed before the parent
but it may reduce some careless mode-less dialog event handling in the
future.
 		2023-03-13 12:04:01 -04:00
..
dialog_HTML_reporter_base.cpp Make OK default in inspectors (and hook up to close window). 2021-03-22 21:20:54 +00:00
dialog_HTML_reporter_base.fbp Make OK default in inspectors (and hook up to close window). 2021-03-22 21:20:54 +00:00
dialog_HTML_reporter_base.h Fix various typos 2022-07-21 16:31:41 +00:00
dialog_assign_netclass.cpp Cache for netclass pattern assignments. 2023-03-06 13:56:04 +00:00
dialog_assign_netclass_base.cpp Remove standard dialog button static line separators. 2023-01-08 13:15:33 -05:00
dialog_assign_netclass_base.fbp Remove standard dialog button static line separators. 2023-01-08 13:15:33 -05:00
dialog_assign_netclass_base.h Remove standard dialog button static line separators. 2023-01-08 13:15:33 -05:00
dialog_book_reporter.cpp Fix mode-less dialog issues. 2023-03-13 12:04:01 -04:00
dialog_book_reporter_base.cpp Fix mode-less dialog issues. 2023-03-13 12:04:01 -04:00
dialog_book_reporter_base.fbp Fix mode-less dialog issues. 2023-03-13 12:04:01 -04:00
dialog_book_reporter_base.h Fix mode-less dialog issues. 2023-03-13 12:04:01 -04:00
dialog_color_picker.cpp DIALOG_COLOR_PICKER: fix an issue in DC.SetDeviceOrigin() due to changes in wxWidgets. 2022-08-11 10:15:50 +02:00
dialog_color_picker_base.cpp Remove standard dialog button static line separators. 2023-01-08 13:15:33 -05:00
dialog_color_picker_base.fbp Remove standard dialog button static line separators. 2023-01-08 13:15:33 -05:00
dialog_color_picker_base.h Remove standard dialog button static line separators. 2023-01-08 13:15:33 -05:00
dialog_configure_paths.cpp Don't show error when added new paths 2023-01-20 16:43:16 -08:00
dialog_configure_paths_base.cpp Ensure good fonts in grid headers. 2023-01-16 02:47:14 +00:00
dialog_configure_paths_base.fbp Simplify Remove Unused Pads dialog. 2023-02-11 21:11:07 +00:00
dialog_configure_paths_base.h Get rid of bloated bitmap buttons on wxWidgets 3.2. 2022-12-13 20:48:02 +00:00
dialog_display_html_text_base.cpp Substitute all wxHtmlWindow with HTML_WINDOW 2021-10-12 07:07:15 +00:00
dialog_display_html_text_base.fbp Use a standard HTML reporter for Symbol Checker. 2022-03-26 14:22:31 +00:00
dialog_display_html_text_base.h Substitute all wxHtmlWindow with HTML_WINDOW 2021-10-12 07:07:15 +00:00
dialog_edit_library_tables.cpp Make sure standard OK/Cancel buttons respond to current language. 2021-12-24 18:13:11 +00:00
dialog_global_lib_table_config.cpp fix compil warnings 2023-01-27 18:25:09 +01:00
dialog_global_lib_table_config_base.cpp Remove standard dialog button static line separators. 2023-01-08 13:15:33 -05:00
dialog_global_lib_table_config_base.fbp Remove standard dialog button static line separators. 2023-01-08 13:15:33 -05:00
dialog_global_lib_table_config_base.h Remove standard dialog button static line separators. 2023-01-08 13:15:33 -05:00
dialog_grid_settings.cpp Yeet the last of wxSize/wxPoint to stop leaking gdicmn everywhere 2023-02-18 22:57:18 -05:00
dialog_grid_settings_base.cpp Fix vertical centering of buttons in button row. 2023-01-27 12:34:50 +00:00
dialog_grid_settings_base.fbp Fix vertical centering of buttons in button row. 2023-01-27 12:34:50 +00:00
dialog_grid_settings_base.h Remove standard dialog button static line separators. 2023-01-08 13:15:33 -05:00
dialog_hotkey_list.cpp Hotkeys: show user config for unloaded KiFACEs 2022-07-05 13:37:45 +00:00
dialog_locked_items_query.cpp Make sure standard OK/Cancel buttons respond to current language. 2021-12-24 18:13:11 +00:00
dialog_locked_items_query_base.cpp Stop using wxDialog::EndModal() from inside dialogs. 2021-07-21 17:38:14 -04:00
dialog_locked_items_query_base.fbp Stop using wxDialog::EndModal() from inside dialogs. 2021-07-21 17:38:14 -04:00
dialog_locked_items_query_base.h Fix various typos 2022-07-21 16:31:41 +00:00
dialog_migrate_settings.cpp Get rid of bloated bitmap buttons on wxWidgets 3.2. 2022-12-13 20:48:02 +00:00
dialog_migrate_settings_base.cpp Remove standard dialog button static line separators. 2023-01-08 13:15:33 -05:00
dialog_migrate_settings_base.fbp Remove standard dialog button static line separators. 2023-01-08 13:15:33 -05:00
dialog_migrate_settings_base.h Remove standard dialog button static line separators. 2023-01-08 13:15:33 -05:00
dialog_page_settings.cpp Support SHEET_PATH when printing. 2023-03-12 22:24:06 +00:00
dialog_page_settings_base.cpp Remove standard dialog button static line separators. 2023-01-08 13:15:33 -05:00
dialog_page_settings_base.fbp Remove standard dialog button static line separators. 2023-01-08 13:15:33 -05:00
dialog_page_settings_base.h Remove standard dialog button static line separators. 2023-01-08 13:15:33 -05:00
dialog_paste_special.cpp DIALOG_PASTE_SPECIAL: Set focus on OK button 2022-08-25 20:25:23 +01:00
dialog_paste_special_base.cpp Remove standard dialog button static line separators. 2023-01-08 13:15:33 -05:00
dialog_paste_special_base.fbp Remove standard dialog button static line separators. 2023-01-08 13:15:33 -05:00
dialog_paste_special_base.h Remove standard dialog button static line separators. 2023-01-08 13:15:33 -05:00
dialog_print_generic.cpp Pcbnew, Print preview frame: remember last size & pos during a session. 2022-10-17 16:57:19 +02:00
dialog_print_generic_base.cpp Standardize print/plot terms 2023-01-11 12:30:02 -08:00
dialog_print_generic_base.fbp Standardize print/plot terms 2023-01-11 12:30:02 -08:00
dialog_print_generic_base.h Standardize print/plot terms 2023-01-11 12:30:02 -08:00
dialog_text_entry.cpp Make sure standard OK/Cancel buttons respond to current language. 2021-12-24 18:13:11 +00:00
dialog_text_entry_base.cpp Minor dialog layout improvements. 2021-10-29 15:29:49 -04:00
dialog_text_entry_base.fbp Minor dialog layout improvements. 2021-10-29 15:29:49 -04:00
dialog_text_entry_base.h Minor dialog layout improvements. 2021-10-29 15:29:49 -04:00
dialog_unit_entry.cpp Make sure standard OK/Cancel buttons respond to current language. 2021-12-24 18:13:11 +00:00
dialog_unit_entry_base.cpp ADDED: Fillet Tracks tool in pcbnew 2020-10-20 21:23:05 +00:00
dialog_unit_entry_base.fbp ADDED: Fillet Tracks tool in pcbnew 2020-10-20 21:23:05 +00:00
dialog_unit_entry_base.h ADDED: Fillet Tracks tool in pcbnew 2020-10-20 21:23:05 +00:00
eda_list_dialog.cpp Size columns after we've restored saved size of dialog. 2023-01-06 14:33:44 +00:00
eda_list_dialog_base.cpp Scale list columns with dialog width. 2022-12-27 01:04:47 +00:00
eda_list_dialog_base.fbp Scale list columns with dialog width. 2022-12-27 01:04:47 +00:00
eda_list_dialog_base.h Scale list columns with dialog width. 2022-12-27 01:04:47 +00:00
eda_reorderable_list_dialog.cpp ADDED: Column selection and reordering in symbol chooser 2022-09-25 22:49:49 -04:00
eda_reorderable_list_dialog_base.cpp ADDED: Column selection and reordering in symbol chooser 2022-09-25 22:49:49 -04:00
eda_reorderable_list_dialog_base.fbp ADDED: Column selection and reordering in symbol chooser 2022-09-25 22:49:49 -04:00
eda_reorderable_list_dialog_base.h ADDED: Column selection and reordering in symbol chooser 2022-09-25 22:49:49 -04:00
eda_view_switcher.cpp Viewport switcher keys are platform-specific. 2022-10-27 14:28:11 +01:00
eda_view_switcher_base.cpp Add layer presets switcher. 2020-08-19 11:56:28 +01:00
eda_view_switcher_base.fbp Add layer presets switcher. 2020-08-19 11:56:28 +01:00
eda_view_switcher_base.h Make via cleaning options clearer. 2020-08-19 11:56:28 +01:00
html_message_box.cpp Add doc link to custom rules syntax help. 2023-02-12 21:34:35 +00:00
panel_color_settings.cpp PANEL_COLOR_SETTINGS: swap swatches and texts to avoid annoying truncation. 2023-02-27 08:35:35 +01:00
panel_color_settings_base.cpp Flat(er) look for paged dialogs. 2023-01-11 01:11:25 +00:00
panel_color_settings_base.fbp Flat(er) look for paged dialogs. 2023-01-11 01:11:25 +00:00
panel_color_settings_base.h Flat(er) look for paged dialogs. 2023-01-11 01:11:25 +00:00
panel_common_settings.cpp Preferences dialog: try to reduce its width, in non English languages. 2023-02-04 17:45:39 +01:00
panel_common_settings_base.cpp Fix "wxEXPAND overrides alignment flags in box sizers" assert. 2023-02-11 02:15:44 +03:00
panel_common_settings_base.fbp Fix "wxEXPAND overrides alignment flags in box sizers" assert. 2023-02-11 02:15:44 +03:00
panel_common_settings_base.h Fix "wxEXPAND overrides alignment flags in box sizers" assert. 2023-02-11 02:15:44 +03:00
panel_data_collection.cpp Display the sentry uid in preferences 2022-09-27 19:31:32 -04:00
panel_data_collection_base.cpp Display the sentry uid in preferences 2022-09-27 19:31:32 -04:00
panel_data_collection_base.fbp Display the sentry uid in preferences 2022-09-27 19:31:32 -04:00
panel_data_collection_base.h Display the sentry uid in preferences 2022-09-27 19:31:32 -04:00
panel_gal_display_options.cpp All the preferences, all the time. 2021-12-24 13:08:44 +00:00
panel_hotkeys_editor.cpp Flat(er) look for paged dialogs. 2023-01-11 01:11:25 +00:00
panel_image_editor.cpp Yeet the last of wxSize/wxPoint to stop leaking gdicmn everywhere 2023-02-18 22:57:18 -05:00
panel_image_editor_base.cpp Images: Add full properties editor 2022-07-14 11:23:23 +00:00
panel_image_editor_base.h Images: Add full properties editor 2022-07-14 11:23:23 +00:00
panel_mouse_settings.cpp Finalize modifier update 2021-09-09 10:47:43 -07:00
panel_mouse_settings_base.cpp Fix "wxEXPAND overrides alignment flags in box sizers" assert. 2023-02-11 02:15:44 +03:00
panel_mouse_settings_base.fbp Fix "wxEXPAND overrides alignment flags in box sizers" assert. 2023-02-11 02:15:44 +03:00
panel_mouse_settings_base.h Fix "wxEXPAND overrides alignment flags in box sizers" assert. 2023-02-11 02:15:44 +03:00
panel_setup_netclasses.cpp Fix mode-less dialog issues. 2023-03-13 12:04:01 -04:00
panel_setup_netclasses_base.cpp Minor dialog layout improvements. 2023-02-02 16:54:52 -05:00
panel_setup_netclasses_base.fbp Minor dialog layout improvements. 2023-02-02 16:54:52 -05:00
panel_setup_netclasses_base.h Flat(er) look for paged dialogs. 2023-01-11 01:11:25 +00:00
panel_setup_severities.cpp Flat(er) look for paged dialogs. 2023-01-11 01:11:25 +00:00
panel_text_variables.cpp Get rid of bloated bitmap buttons on wxWidgets 3.2. 2022-12-13 20:48:02 +00:00
panel_text_variables_base.cpp Minor dialog layout improvements. 2023-02-02 16:54:52 -05:00
panel_text_variables_base.fbp Minor dialog layout improvements. 2023-02-02 16:54:52 -05:00
panel_text_variables_base.h Get rid of bloated bitmap buttons on wxWidgets 3.2. 2022-12-13 20:48:02 +00:00