Commit Graph

18 Commits

Author SHA1 Message Date
Mitchell Hashimoto 1a6ae81aa9 Require what to be notified for with block and Subprocess.execute
There was an issue before where the stdin buffer would always have space
so it would always yield that block and Ruby would spin at 100%. Now we
require all callers to say what they want to listen for. This drops
CPU down to almost nothing.

See GH-832
2012-06-01 17:02:12 +02:00
Mitchell Hashimoto 7ddee76c00 Passing acceptance tests again 2012-01-11 23:21:07 -08:00
Mitchell Hashimoto 18cdcb4330 Acceptance tests for chef solo, fixed a bug it found. 2012-01-10 21:08:43 -08:00
Mitchell Hashimoto 919f7adaa3 Port collision with SSH test. 2011-12-24 22:25:02 -08:00
Mitchell Hashimoto f7275f5113 Test port forwarding basics 2011-12-24 17:59:10 -08:00
Mitchell Hashimoto 963bdff9fd Use Vagrant::Util::Subprocess for acceptance tests 2011-12-22 21:46:43 -08:00
Mitchell Hashimoto 42a5e02db4 Clean up test load paths 2011-12-11 15:53:11 -08:00
Mitchell Hashimoto 99982fb26e VM-specific configuration now works. 2011-12-03 19:05:50 -08:00
Mitchell Hashimoto 27c4d61e67 Upgrade to childprocess 0.2.3 and remove our hacky with_env_changes 2011-11-27 16:11:07 -07:00
Mitchell Hashimoto 2dc9bad97d Fix missing variable in tests 2011-11-24 14:15:36 -07:00
Mitchell Hashimoto 87767e24d0 Fix test harness where blocking could occur on IO read.
We had issues with the CI where some tests would sometimes hang
on cleanup when it would call VBoxManage, even with a timeout.
My only assumption is that this is happening as it waits on `readline`,
so we do a `read_nonblock` which will help immensely.
2011-11-24 14:13:22 -07:00
Mitchell Hashimoto 5e4dffb7e1 Test: Don't worry if VBoxManage failed. 2011-11-22 19:28:21 -08:00
Mitchell Hashimoto 315733703a Tempfile no longer needed in isolated env 2011-11-21 21:18:15 -08:00
Mitchell Hashimoto 203056a0db Switch posix-spawn to childprocess for better cross-OS support 2011-11-21 21:16:51 -08:00
Mitchell Hashimoto cebd66d8e6 Test: Add a timeout to cleaning up the VM environment 2011-11-20 10:44:09 -08:00
Mitchell Hashimoto 224c981846 Test: Add "timeout" parameter to execute in tests 2011-11-20 10:38:41 -08:00
Mitchell Hashimoto 60a350f9c7 Test that `vagrant up` works if Vagrantfile is in a parent directory 2011-11-11 00:19:46 -08:00
Mitchell Hashimoto 87bc6ec63f RSpec is coming in for acceptance tests. More details follow...
RSpec was chosen to be used for acceptance tests for many reasons:

* The tests are actually much cleaner now. It is clearer to see what
  is being tested, and what is being used for setup.
* Matcher transition will be coming soon. This will really clean up
  a lot of the "assert" boilerplate all over. There was a lot of repetition
  in this area.
* Shared examples will help greatly for testing common error cases
  for many commands.
* The test runner for RSpec is simply much better. Being able to specify
  the exact test to run by line, for example, is a great help.
2011-11-06 23:47:23 -08:00
Renamed from test/acceptance/helpers/isolated_environment.rb (Browse further)