meow #1

haskal · 2021-06-28T19:20:03Z

haskal commented

2021-06-28 19:20:03 +00:00

this is a more mergable version of haskal/personal which has the following changes

refactor

moved relevant CMSIS DAP files directly into this repository rather than requiring CMSIS as a submodule. this was done because the CMSIS repo is huge and we only need a small part of it. additionally, this allows making local changes to the CMSIS files if necessary

formatting

DOS endings have been converted to UNIX
tabs converted to spaces with expand -t4 -i
.clang-format introduced (but not yet applied to any files)

license

added GPL license with additional file containing information about upstream licensing exceptions (this satisfies the upstream MIT license by providing the license text as required)
(individual files not yet modified with any license header)

minor

README typos corrected
dmctl.py: fixed type error
introduced scripts and cmake changes that make it easier to develop with libclang-based IDE tooling

this is a more mergable version of haskal/personal which has the following changes refactor - moved relevant CMSIS DAP files directly into this repository rather than requiring CMSIS as a submodule. this was done because the CMSIS repo is huge and we only need a small part of it. additionally, this allows making local changes to the CMSIS files if necessary formatting - DOS endings have been converted to UNIX - tabs converted to spaces with expand -t4 -i - .clang-format introduced (but not yet applied to any files) license - added GPL license with additional file containing information about upstream licensing exceptions (this satisfies the upstream MIT license by providing the license text as required) - (individual files not yet modified with any license header) minor - README typos corrected - dmctl.py: fixed type error - introduced scripts and cmake changes that make it easier to develop with libclang-based IDE tooling

haskal force-pushed haskal/mechanical-fixes from 6af4294b24 to 01e30c8e59

2021-06-28 19:22:23 +00:00

Compare

sys64738 commented

2021-06-28 20:21:11 +00:00

oh god this is incredibly ill-timed because i just started doing random stuff as well

whoops

EDIT: to elaborate a bit more:

ive fixed the line endings stuff already
cherry-picked the license commit
also cherry-picked the misc minor fixes
im somewhat on the fence about using 4 spaces, sorry :p
ive also removed the stm32f support on main
i updated the cmsis_5 subrepo to the latest release (5.0.8) for now, instead of applying your patch directly. making it lighter is definitely not a bad idea, but idk if being stuck on one version (that wasnt even a proper release before i updated it) feels a bit wrong to me? so yeah,

oh god this is incredibly ill-timed because i *just* started doing random stuff as well whoops EDIT: to elaborate a bit more: * ive fixed the line endings stuff already * cherry-picked the license commit * also cherry-picked the misc minor fixes * im somewhat on the fence about using 4 spaces, sorry :p * ive also removed the stm32f support on `main` * i updated the cmsis_5 subrepo to the latest release (5.0.8) for now, instead of applying your patch directly. making it lighter is definitely not a bad idea, but idk if being stuck on one version (that wasnt even a proper release before i updated it) feels a bit wrong to me? so yeah,

haskal closed this pull request

2021-06-28 23:58:25 +00:00

haskal deleted branch haskal/mechanical-fixes

2021-06-28 23:58:46 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sys64738/DragonProbe#1