2020-07-27 13:33:06 +00:00
|
|
|
/*
|
|
|
|
* This program source code file is part of KiCad, a free EDA CAD application.
|
|
|
|
*
|
2022-03-11 21:16:52 +00:00
|
|
|
* Copyright (C) 2004-2022 KiCad Developers.
|
2020-07-27 13:33:06 +00:00
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU General Public License
|
|
|
|
* as published by the Free Software Foundation; either version 2
|
|
|
|
* of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program; if not, you may find one here:
|
|
|
|
* http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
|
|
|
|
* or you may search the http://www.gnu.org website for the version 2 license,
|
|
|
|
* or you may write to the Free Software Foundation, Inc.,
|
|
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
|
|
|
|
*/
|
|
|
|
|
2020-06-19 21:34:19 +00:00
|
|
|
#include <common.h>
|
2021-06-06 19:03:10 +00:00
|
|
|
#include <board_design_settings.h>
|
2021-06-03 18:05:43 +00:00
|
|
|
#include <footprint.h>
|
2020-11-12 20:19:22 +00:00
|
|
|
#include <pad.h>
|
2021-06-11 21:07:02 +00:00
|
|
|
#include <pcb_track.h>
|
2020-07-22 23:05:37 +00:00
|
|
|
#include <geometry/shape_segment.h>
|
2020-10-27 20:15:54 +00:00
|
|
|
#include <geometry/shape_circle.h>
|
2021-06-06 19:03:10 +00:00
|
|
|
#include <drc/drc_engine.h>
|
2020-09-11 15:04:11 +00:00
|
|
|
#include <drc/drc_item.h>
|
|
|
|
#include <drc/drc_rule.h>
|
2020-09-11 16:24:27 +00:00
|
|
|
#include <drc/drc_test_provider_clearance_base.h>
|
2020-10-27 17:09:27 +00:00
|
|
|
#include "drc_rtree.h"
|
2020-06-19 21:34:19 +00:00
|
|
|
|
2020-07-27 13:33:06 +00:00
|
|
|
/*
|
|
|
|
Holes clearance test. Checks pad and via holes for their mechanical clearances.
|
|
|
|
Generated errors:
|
2020-11-29 22:01:40 +00:00
|
|
|
- DRCE_DRILLED_HOLES_TOO_CLOSE
|
2021-05-20 09:35:31 +00:00
|
|
|
- DRCE_DRILLED_HOLES_COLOCATED
|
2020-07-27 13:33:06 +00:00
|
|
|
*/
|
|
|
|
|
2021-05-20 09:35:31 +00:00
|
|
|
class DRC_TEST_PROVIDER_HOLE_TO_HOLE : public DRC_TEST_PROVIDER_CLEARANCE_BASE
|
2020-06-19 21:34:19 +00:00
|
|
|
{
|
|
|
|
public:
|
2021-05-20 09:35:31 +00:00
|
|
|
DRC_TEST_PROVIDER_HOLE_TO_HOLE () :
|
2022-06-17 21:50:59 +00:00
|
|
|
DRC_TEST_PROVIDER_CLEARANCE_BASE(),
|
|
|
|
m_board( nullptr ),
|
|
|
|
m_largestHoleToHoleClearance( 0 )
|
2020-10-27 17:09:27 +00:00
|
|
|
{
|
|
|
|
}
|
2020-06-19 21:34:19 +00:00
|
|
|
|
2021-05-20 09:35:31 +00:00
|
|
|
virtual ~DRC_TEST_PROVIDER_HOLE_TO_HOLE()
|
2020-06-19 21:34:19 +00:00
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
virtual bool Run() override;
|
|
|
|
|
2020-07-31 01:46:05 +00:00
|
|
|
virtual const wxString GetName() const override
|
2020-06-19 21:34:19 +00:00
|
|
|
{
|
2022-03-11 21:16:52 +00:00
|
|
|
return wxT( "hole_to_hole_clearance" );
|
2020-06-19 21:34:19 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
virtual const wxString GetDescription() const override
|
|
|
|
{
|
2022-03-11 21:16:52 +00:00
|
|
|
return wxT( "Tests hole to hole spacing" );
|
2020-06-19 21:34:19 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
private:
|
2020-10-28 12:24:10 +00:00
|
|
|
bool testHoleAgainstHole( BOARD_ITEM* aItem, SHAPE_CIRCLE* aHole, BOARD_ITEM* aOther );
|
2020-07-15 16:23:56 +00:00
|
|
|
|
2020-10-27 17:09:27 +00:00
|
|
|
BOARD* m_board;
|
|
|
|
DRC_RTREE m_holeTree;
|
2022-06-17 21:50:59 +00:00
|
|
|
int m_largestHoleToHoleClearance;
|
2020-06-19 21:34:19 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
|
2020-10-27 17:09:27 +00:00
|
|
|
static std::shared_ptr<SHAPE_CIRCLE> getDrilledHoleShape( BOARD_ITEM* aItem )
|
|
|
|
{
|
|
|
|
if( aItem->Type() == PCB_VIA_T )
|
|
|
|
{
|
2021-06-11 21:07:02 +00:00
|
|
|
PCB_VIA* via = static_cast<PCB_VIA*>( aItem );
|
2020-10-27 17:09:27 +00:00
|
|
|
return std::make_shared<SHAPE_CIRCLE>( via->GetCenter(), via->GetDrillValue() / 2 );
|
|
|
|
}
|
|
|
|
else if( aItem->Type() == PCB_PAD_T )
|
|
|
|
{
|
2020-11-12 22:30:02 +00:00
|
|
|
PAD* pad = static_cast<PAD*>( aItem );
|
2020-10-27 17:09:27 +00:00
|
|
|
return std::make_shared<SHAPE_CIRCLE>( pad->GetPosition(), pad->GetDrillSize().x / 2 );
|
|
|
|
}
|
|
|
|
|
|
|
|
return std::make_shared<SHAPE_CIRCLE>( VECTOR2I( 0, 0 ), 0 );
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2021-05-20 09:35:31 +00:00
|
|
|
bool DRC_TEST_PROVIDER_HOLE_TO_HOLE::Run()
|
2020-06-19 21:34:19 +00:00
|
|
|
{
|
2021-05-20 09:35:31 +00:00
|
|
|
if( m_drcEngine->IsErrorLimitExceeded( DRCE_DRILLED_HOLES_TOO_CLOSE )
|
|
|
|
&& m_drcEngine->IsErrorLimitExceeded( DRCE_DRILLED_HOLES_COLOCATED ) )
|
2021-02-27 13:43:41 +00:00
|
|
|
{
|
2022-03-11 21:16:52 +00:00
|
|
|
reportAux( wxT( "Hole to hole violations ignored. Tests not run." ) );
|
2021-02-27 13:43:41 +00:00
|
|
|
return true; // continue with other tests
|
|
|
|
}
|
|
|
|
|
2020-06-19 21:34:19 +00:00
|
|
|
m_board = m_drcEngine->GetBoard();
|
2020-06-30 08:42:43 +00:00
|
|
|
|
2020-08-11 22:17:43 +00:00
|
|
|
DRC_CONSTRAINT worstClearanceConstraint;
|
|
|
|
|
2020-11-29 22:01:40 +00:00
|
|
|
if( m_drcEngine->QueryWorstConstraint( HOLE_TO_HOLE_CONSTRAINT, worstClearanceConstraint ) )
|
2020-06-30 08:42:43 +00:00
|
|
|
{
|
2022-06-17 21:50:59 +00:00
|
|
|
m_largestHoleToHoleClearance = worstClearanceConstraint.GetValue().Min();
|
|
|
|
reportAux( wxT( "Worst hole to hole : %d nm" ), m_largestHoleToHoleClearance );
|
2020-06-30 08:42:43 +00:00
|
|
|
}
|
2020-08-11 22:17:43 +00:00
|
|
|
else
|
|
|
|
{
|
2022-03-11 21:16:52 +00:00
|
|
|
reportAux( wxT( "No hole to hole constraints found. Skipping check." ) );
|
2021-02-27 13:43:41 +00:00
|
|
|
return true; // continue with other tests
|
2020-08-11 22:17:43 +00:00
|
|
|
}
|
|
|
|
|
2021-02-27 13:43:41 +00:00
|
|
|
if( !reportPhase( _( "Checking hole to hole clearances..." ) ) )
|
|
|
|
return false; // DRC cancelled
|
|
|
|
|
2022-08-03 09:10:23 +00:00
|
|
|
const size_t progressDelta = 200;
|
2020-10-27 17:09:27 +00:00
|
|
|
size_t count = 0;
|
|
|
|
size_t ii = 0;
|
2020-07-27 13:33:06 +00:00
|
|
|
|
2020-10-29 13:18:15 +00:00
|
|
|
m_holeTree.clear();
|
|
|
|
|
2022-03-09 00:47:37 +00:00
|
|
|
forEachGeometryItem( { PCB_PAD_T, PCB_VIA_T }, LSET::AllLayersMask(),
|
2020-10-27 17:09:27 +00:00
|
|
|
[&]( BOARD_ITEM* item ) -> bool
|
|
|
|
{
|
2022-03-12 13:34:25 +00:00
|
|
|
++count;
|
2020-10-27 17:09:27 +00:00
|
|
|
return true;
|
2022-03-09 00:47:37 +00:00
|
|
|
} );
|
2020-06-19 21:34:19 +00:00
|
|
|
|
2022-03-09 00:47:37 +00:00
|
|
|
count *= 2; // One for adding to the rtree; one for checking
|
|
|
|
|
|
|
|
forEachGeometryItem( { PCB_PAD_T, PCB_VIA_T }, LSET::AllLayersMask(),
|
2020-10-27 17:09:27 +00:00
|
|
|
[&]( BOARD_ITEM* item ) -> bool
|
|
|
|
{
|
2022-08-03 09:10:23 +00:00
|
|
|
if( !reportProgress( ii++, count, progressDelta ) )
|
2020-10-27 17:09:27 +00:00
|
|
|
return false;
|
2020-06-19 21:34:19 +00:00
|
|
|
|
2020-10-27 17:09:27 +00:00
|
|
|
if( item->Type() == PCB_PAD_T )
|
|
|
|
{
|
2020-11-12 22:30:02 +00:00
|
|
|
PAD* pad = static_cast<PAD*>( item );
|
2020-06-19 21:34:19 +00:00
|
|
|
|
2023-01-23 14:24:12 +00:00
|
|
|
// Slots are generally milled _after_ drilling, so we ignore them.
|
2020-10-27 17:09:27 +00:00
|
|
|
if( pad->GetDrillSize().x && pad->GetDrillSize().x == pad->GetDrillSize().y )
|
2022-08-29 11:33:31 +00:00
|
|
|
m_holeTree.Insert( item, Edge_Cuts, m_largestHoleToHoleClearance );
|
2020-10-27 17:09:27 +00:00
|
|
|
}
|
|
|
|
else if( item->Type() == PCB_VIA_T )
|
|
|
|
{
|
2023-01-23 14:24:12 +00:00
|
|
|
// Blind/buried/microvias will be drilled/burned _prior_ to lamination, so
|
|
|
|
// subsequently drilled holes need to avoid them.
|
|
|
|
m_holeTree.Insert( item, Edge_Cuts, m_largestHoleToHoleClearance );
|
2020-10-27 17:09:27 +00:00
|
|
|
}
|
2020-09-11 16:24:27 +00:00
|
|
|
|
2020-10-27 17:09:27 +00:00
|
|
|
return true;
|
2022-03-09 00:47:37 +00:00
|
|
|
} );
|
2020-06-19 21:34:19 +00:00
|
|
|
|
2022-08-03 09:10:23 +00:00
|
|
|
std::unordered_map<PTR_PTR_CACHE_KEY, int> checkedPairs;
|
2020-11-17 16:58:14 +00:00
|
|
|
|
2021-06-11 21:07:02 +00:00
|
|
|
for( PCB_TRACK* track : m_board->Tracks() )
|
2020-06-19 21:34:19 +00:00
|
|
|
{
|
2020-10-27 17:09:27 +00:00
|
|
|
if( track->Type() != PCB_VIA_T )
|
2020-06-19 21:34:19 +00:00
|
|
|
continue;
|
|
|
|
|
2021-06-11 21:07:02 +00:00
|
|
|
PCB_VIA* via = static_cast<PCB_VIA*>( track );
|
2020-07-31 01:46:05 +00:00
|
|
|
|
2022-08-03 09:10:23 +00:00
|
|
|
if( !reportProgress( ii++, count, progressDelta ) )
|
2021-02-27 13:43:41 +00:00
|
|
|
return false; // DRC cancelled
|
2020-06-19 21:34:19 +00:00
|
|
|
|
2023-01-23 14:24:12 +00:00
|
|
|
// We only care about mechanically drilled (ie: non-laser) holes. These include both
|
|
|
|
// blind/buried via holes (drilled prior to lamination) and through-via and drilled pad
|
|
|
|
// holes (which are generally drilled post laminataion).
|
|
|
|
if( via->GetViaType() != VIATYPE::MICROVIA )
|
2020-10-13 15:31:36 +00:00
|
|
|
{
|
2020-11-29 22:01:40 +00:00
|
|
|
std::shared_ptr<SHAPE_CIRCLE> holeShape = getDrilledHoleShape( via );
|
2020-09-11 16:24:27 +00:00
|
|
|
|
2022-08-29 11:33:31 +00:00
|
|
|
m_holeTree.QueryColliding( via, Edge_Cuts, Edge_Cuts,
|
2020-11-02 16:20:00 +00:00
|
|
|
// Filter:
|
2020-10-27 17:09:27 +00:00
|
|
|
[&]( BOARD_ITEM* other ) -> bool
|
|
|
|
{
|
2020-11-29 22:01:40 +00:00
|
|
|
BOARD_ITEM* a = via;
|
2020-11-17 16:58:14 +00:00
|
|
|
BOARD_ITEM* b = other;
|
|
|
|
|
|
|
|
// store canonical order so we don't collide in both directions
|
|
|
|
// (a:b and b:a)
|
|
|
|
if( static_cast<void*>( a ) > static_cast<void*>( b ) )
|
|
|
|
std::swap( a, b );
|
|
|
|
|
2022-08-25 14:03:44 +00:00
|
|
|
if( checkedPairs.find( { a, b } ) != checkedPairs.end() )
|
2020-11-17 16:58:14 +00:00
|
|
|
{
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
checkedPairs[ { a, b } ] = 1;
|
|
|
|
return true;
|
|
|
|
}
|
2020-10-27 17:09:27 +00:00
|
|
|
},
|
2020-11-02 16:20:00 +00:00
|
|
|
// Visitor:
|
2020-10-28 13:52:30 +00:00
|
|
|
[&]( BOARD_ITEM* other ) -> bool
|
2020-10-27 17:09:27 +00:00
|
|
|
{
|
2020-11-29 22:01:40 +00:00
|
|
|
return testHoleAgainstHole( via, holeShape.get(), other );
|
2020-10-27 17:09:27 +00:00
|
|
|
},
|
2022-06-17 21:50:59 +00:00
|
|
|
m_largestHoleToHoleClearance );
|
2020-11-29 22:01:40 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
checkedPairs.clear();
|
|
|
|
|
|
|
|
for( FOOTPRINT* footprint : m_board->Footprints() )
|
|
|
|
{
|
|
|
|
for( PAD* pad : footprint->Pads() )
|
|
|
|
{
|
2022-08-03 09:10:23 +00:00
|
|
|
if( !reportProgress( ii++, count, progressDelta ) )
|
2021-02-27 13:43:41 +00:00
|
|
|
return false; // DRC cancelled
|
2020-06-19 21:34:19 +00:00
|
|
|
|
2020-11-29 22:01:40 +00:00
|
|
|
// We only care about drilled (ie: round) holes
|
|
|
|
if( pad->GetDrillSize().x && pad->GetDrillSize().x == pad->GetDrillSize().y )
|
|
|
|
{
|
|
|
|
std::shared_ptr<SHAPE_CIRCLE> holeShape = getDrilledHoleShape( pad );
|
|
|
|
|
2022-08-29 11:33:31 +00:00
|
|
|
m_holeTree.QueryColliding( pad, Edge_Cuts, Edge_Cuts,
|
2020-11-29 22:01:40 +00:00
|
|
|
// Filter:
|
|
|
|
[&]( BOARD_ITEM* other ) -> bool
|
|
|
|
{
|
|
|
|
BOARD_ITEM* a = pad;
|
|
|
|
BOARD_ITEM* b = other;
|
|
|
|
|
|
|
|
// store canonical order so we don't collide in both directions
|
|
|
|
// (a:b and b:a)
|
|
|
|
if( static_cast<void*>( a ) > static_cast<void*>( b ) )
|
|
|
|
std::swap( a, b );
|
|
|
|
|
2022-08-25 14:03:44 +00:00
|
|
|
if( checkedPairs.find( { a, b } ) != checkedPairs.end() )
|
2020-11-29 22:01:40 +00:00
|
|
|
{
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
checkedPairs[ { a, b } ] = 1;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
},
|
|
|
|
// Visitor:
|
|
|
|
[&]( BOARD_ITEM* other ) -> bool
|
|
|
|
{
|
|
|
|
return testHoleAgainstHole( pad, holeShape.get(), other );
|
|
|
|
},
|
2022-06-17 21:50:59 +00:00
|
|
|
m_largestHoleToHoleClearance );
|
2020-11-29 22:01:40 +00:00
|
|
|
}
|
2020-06-19 21:34:19 +00:00
|
|
|
}
|
2022-03-11 20:13:47 +00:00
|
|
|
|
|
|
|
if( m_drcEngine->IsCancelled() )
|
|
|
|
return false;
|
2020-06-19 21:34:19 +00:00
|
|
|
}
|
|
|
|
|
2020-10-27 17:09:27 +00:00
|
|
|
reportRuleStatistics();
|
2020-07-27 13:33:06 +00:00
|
|
|
|
2022-03-11 20:13:47 +00:00
|
|
|
return !m_drcEngine->IsCancelled();
|
2020-07-27 13:33:06 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2021-05-20 09:35:31 +00:00
|
|
|
bool DRC_TEST_PROVIDER_HOLE_TO_HOLE::testHoleAgainstHole( BOARD_ITEM* aItem, SHAPE_CIRCLE* aHole,
|
|
|
|
BOARD_ITEM* aOther )
|
2020-07-27 13:33:06 +00:00
|
|
|
{
|
2021-05-20 09:35:31 +00:00
|
|
|
bool reportCoLocation = !m_drcEngine->IsErrorLimitExceeded( DRCE_DRILLED_HOLES_COLOCATED );
|
|
|
|
bool reportHole2Hole = !m_drcEngine->IsErrorLimitExceeded( DRCE_DRILLED_HOLES_TOO_CLOSE );
|
|
|
|
|
|
|
|
if( !reportCoLocation && !reportHole2Hole )
|
2020-10-27 17:09:27 +00:00
|
|
|
return false;
|
2020-09-12 19:28:22 +00:00
|
|
|
|
2020-12-24 19:11:12 +00:00
|
|
|
std::shared_ptr<SHAPE_CIRCLE> otherHole = getDrilledHoleShape( aOther );
|
2021-05-20 09:35:31 +00:00
|
|
|
int epsilon = m_board->GetDesignSettings().GetDRCEpsilon();
|
|
|
|
SEG::ecoord epsilon_sq = SEG::Square( epsilon );
|
2020-07-27 13:33:06 +00:00
|
|
|
|
2021-05-20 09:35:31 +00:00
|
|
|
// Holes at same location generate a separate violation
|
|
|
|
if( ( aHole->GetCenter() - otherHole->GetCenter() ).SquaredEuclideanNorm() < epsilon_sq )
|
|
|
|
{
|
|
|
|
if( reportCoLocation )
|
|
|
|
{
|
|
|
|
std::shared_ptr<DRC_ITEM> drce = DRC_ITEM::Create( DRCE_DRILLED_HOLES_COLOCATED );
|
|
|
|
drce->SetItems( aItem, aOther );
|
2022-01-02 02:06:40 +00:00
|
|
|
reportViolation( drce, aHole->GetCenter(), UNDEFINED_LAYER );
|
2021-05-20 09:35:31 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
else if( reportHole2Hole )
|
|
|
|
{
|
|
|
|
int actual = ( aHole->GetCenter() - otherHole->GetCenter() ).EuclideanNorm();
|
|
|
|
actual = std::max( 0, actual - aHole->GetRadius() - otherHole->GetRadius() );
|
2020-07-27 13:33:06 +00:00
|
|
|
|
2021-05-20 09:35:31 +00:00
|
|
|
auto constraint = m_drcEngine->EvalRules( HOLE_TO_HOLE_CONSTRAINT, aItem, aOther,
|
|
|
|
UNDEFINED_LAYER /* holes pierce all layers */ );
|
|
|
|
int minClearance = constraint.GetValue().Min() - epsilon;
|
2020-07-27 13:33:06 +00:00
|
|
|
|
2021-09-05 15:06:12 +00:00
|
|
|
if( constraint.GetSeverity() != RPT_SEVERITY_IGNORE
|
|
|
|
&& minClearance >= 0
|
|
|
|
&& actual < minClearance )
|
2021-05-20 09:35:31 +00:00
|
|
|
{
|
|
|
|
std::shared_ptr<DRC_ITEM> drce = DRC_ITEM::Create( DRCE_DRILLED_HOLES_TOO_CLOSE );
|
2022-10-06 20:52:17 +00:00
|
|
|
wxString msg = formatMsg( _( "(%s min %s; actual %s)" ),
|
|
|
|
constraint.GetName(),
|
|
|
|
minClearance,
|
|
|
|
actual );
|
2020-07-27 13:33:06 +00:00
|
|
|
|
2022-06-15 23:42:34 +00:00
|
|
|
drce->SetErrorMessage( drce->GetErrorText() + wxS( " " ) + msg );
|
2021-05-20 09:35:31 +00:00
|
|
|
drce->SetItems( aItem, aOther );
|
|
|
|
drce->SetViolatingRule( constraint.GetParentRule() );
|
2020-07-27 13:33:06 +00:00
|
|
|
|
2022-01-02 02:06:40 +00:00
|
|
|
reportViolation( drce, aHole->GetCenter(), UNDEFINED_LAYER );
|
2021-05-20 09:35:31 +00:00
|
|
|
}
|
2020-07-27 13:33:06 +00:00
|
|
|
}
|
2020-10-27 17:09:27 +00:00
|
|
|
|
2022-03-11 20:13:47 +00:00
|
|
|
return !m_drcEngine->IsCancelled();
|
2020-07-27 13:33:06 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2020-06-19 21:34:19 +00:00
|
|
|
namespace detail
|
|
|
|
{
|
2021-05-20 09:35:31 +00:00
|
|
|
static DRC_REGISTER_TEST_PROVIDER<DRC_TEST_PROVIDER_HOLE_TO_HOLE> dummy;
|
2020-07-31 01:46:05 +00:00
|
|
|
}
|