haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
kicad/pcbnew/tools/pcb_point_editor.cpp

2432 lines
79 KiB
C++
Raw Normal View History

Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
/*
* This program source code file is part of KiCad, a free EDA CAD application.
*
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
* Copyright (C) 2013-2021 CERN
Move pads to EDA_ANGLE.
2022-01-13 13:45:48 +00:00
* Copyright (C) 2018-2022 KiCad Developers, see AUTHORS.txt for contributors.
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
* @author Maciej Suminski <maciej.suminski@cern.ch>
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, you may find one here:
* http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
* or you may search the http://www.gnu.org website for the version 2 license,
* or you may write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
*/
Replace boost::function and boost::bind with their std:: counterparts
2016-06-29 10:23:11 +00:00
#include <functional>
Unified update to C++14 std::make_unique This update replaces the existing uses of unique pointer creation with the C++14 std::make_unique call that provides proper memory release in event of an exception.
2019-12-05 13:43:55 +00:00
#include <memory>
Revert "Use less-sophisticated arc editing math." This reverts commit 3b424d3868be6534ca3dea426eb8411ee46176fc. And fixes issue with rouding causing arc errors
2021-01-18 17:39:13 +00:00
Replace boost::function and boost::bind with their std:: counterparts
2016-06-29 10:23:11 +00:00
using namespace std::placeholders;
Revert "Use less-sophisticated arc editing math." This reverts commit 3b424d3868be6534ca3dea426eb8411ee46176fc. And fixes issue with rouding causing arc errors
2021-01-18 17:39:13 +00:00
#include <advanced_config.h>
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
#include <tool/tool_manager.h>
#include <view/view_controls.h>
Breaking outlines for zones using POINT_EDITOR.
2014-03-18 13:52:22 +00:00
#include <geometry/seg.h>
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
#include <confirm.h>
TextBoxes for PCBNew.
2022-01-30 10:52:52 +00:00
#include <tools/pcb_actions.h>
#include <tools/pcb_selection_tool.h>
#include <tools/pcb_point_editor.h>
#include <tools/pcb_grid_helper.h>
Modified tools to use BOARD_COMMIT.
2016-06-21 15:06:28 +00:00
#include <board_commit.h>
Point Editor: prevent creation of self-intersecting polygons
2018-02-22 11:28:01 +00:00
#include <status_popup.h>
fix code after renaming files
2018-01-29 20:58:58 +00:00
#include <pcb_edit_frame.h>
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
#include <fp_shape.h>
Dirty text caches in pcb point editor. Fixes https://gitlab.com/kicad/code/kicad/issues/11319
2022-04-04 16:39:33 +00:00
#include <fp_textbox.h>
PCB Editor: Add User Background Images
2022-02-08 19:29:54 +00:00
#include <pcb_bitmap.h>
Prefix DIMENSION types.
2021-06-11 16:59:28 +00:00
#include <pcb_dimension.h>
Dirty text caches in pcb point editor. Fixes https://gitlab.com/kicad/code/kicad/issues/11319
2022-04-04 16:39:33 +00:00
#include <pcb_textbox.h>
Clean up including of board_design_settings.h
2021-06-06 19:03:10 +00:00
#include <pad.h>
Update some classnames including archaic zone names.
2020-11-11 23:05:59 +00:00
#include <zone.h>
pcbnew: Separating connectivity to subdir
2018-10-12 06:17:15 +00:00
#include <connectivity/connectivity_data.h>
Decouple PROGRESS_REPORTER interface from implementations.
2021-08-14 20:05:21 +00:00
#include <progress_reporter.h>
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
More NULL expunging.
2021-07-19 23:56:05 +00:00
Refactoring EDIT_POINTS, part 2: replaced index numbers with constants.
2014-04-01 15:41:24 +00:00
// Few constants to avoid using bare numbers for point indices
enum SEG_POINTS
{
SEG_START, SEG_END
};
More NULL expunging.
2021-07-19 23:56:05 +00:00
Finish implementation of DRAWSEGMENT::C_RECT. It's currently only supported in the Footprint Editor. It could be easily added to the board editor (all the code is there), but the board editor is a little short on room in the drawing tools toolbar.
2020-06-15 19:50:20 +00:00
enum RECT_POINTS
{
RECT_TOP_LEFT, RECT_TOP_RIGHT, RECT_BOT_RIGHT, RECT_BOT_LEFT
};
More NULL expunging.
2021-07-19 23:56:05 +00:00
Add center handles to rectangle edits Allows changing a single dimension at a time. Matching the polygon edit tool. Fixes https://gitlab.com/kicad/code/kicad/issues/7085
2021-01-13 22:03:31 +00:00
enum RECT_LINES
{
RECT_TOP, RECT_RIGHT, RECT_BOT, RECT_LEFT
};
More NULL expunging.
2021-07-19 23:56:05 +00:00
Refactoring EDIT_POINTS, part 2: replaced index numbers with constants.
2014-04-01 15:41:24 +00:00
enum ARC_POINTS
{
pcbnew: Allow arc editing via midpoint This permits changing the radius of the arc by adjusting the center point of the arc. The arc end points are fixed in this operation.
2018-12-08 15:26:47 +00:00
ARC_CENTER, ARC_START, ARC_MID, ARC_END
Refactoring EDIT_POINTS, part 2: replaced index numbers with constants.
2014-04-01 15:41:24 +00:00
};
More NULL expunging.
2021-07-19 23:56:05 +00:00
Refactoring EDIT_POINTS, part 2: replaced index numbers with constants.
2014-04-01 15:41:24 +00:00
enum CIRCLE_POINTS
{
CIRC_CENTER, CIRC_END
};
More NULL expunging.
2021-07-19 23:56:05 +00:00
Add Bezier curve (S_CURVE shape) support in DIALOG_GRAPHIC_ITEM_PROPERTIES. Fix some issues related to S_CURVE shape support.
2018-07-22 12:50:35 +00:00
enum BEZIER_CURVE_POINTS
{
BEZIER_CURVE_START,
BEZIER_CURVE_CONTROL_POINT1,
BEZIER_CURVE_CONTROL_POINT2,
BEZIER_CURVE_END
};
More NULL expunging.
2021-07-19 23:56:05 +00:00
Refactoring EDIT_POINTS, part 2: replaced index numbers with constants.
2014-04-01 15:41:24 +00:00
enum DIMENSION_POINTS
{
Refactor DIMENSION to hide internal details; add some new properties This is a board file format change to account for the new properties. Also, we now only store the critical information about the dimension's geometry in the board, rather than storing every drawn line. The DIMENSION object is now an abstract base, and ALIGNED_DIMENSION is the implementation that exists today (we will add more dimension types in the future)
2020-09-09 03:17:08 +00:00
DIM_START,
DIM_END,
ADDED: Leader dimension object Fixes https://gitlab.com/kicad/code/kicad/-/issues/5555
2020-09-12 20:09:40 +00:00
DIM_TEXT,
DIM_CROSSBARSTART,
DIM_CROSSBAREND,
Radial dimensions. ADDED radial type dimensions. Fixes https://gitlab.com/kicad/code/kicad/issues/2056
2021-07-13 18:46:33 +00:00
DIM_KNEE = DIM_CROSSBARSTART
Refactoring EDIT_POINTS, part 2: replaced index numbers with constants.
2014-04-01 15:41:24 +00:00
};
More NULL expunging.
2021-07-19 23:56:05 +00:00
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
PCB_POINT_EDITOR::PCB_POINT_EDITOR() :
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
PCB_TOOL_BASE( "pcbnew.PointEditor" ),
m_selectionTool( nullptr ),
m_editedPoint( nullptr ),
m_hoveredPoint( nullptr ),
m_original( VECTOR2I( 0, 0 ) ),
m_refill( false ),
m_altEditMethod( false ),
m_altConstrainer( VECTOR2I( 0, 0 ) )
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
{
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
}
pcbnew: added graphical polygon drawing & editing tools
2017-10-19 21:14:01 +00:00
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
void PCB_POINT_EDITOR::Reset( RESET_REASON aReason )
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
{
m_refill = false;
m_editPoints.reset();
m_altConstraint.reset();
getViewControls()->SetAutoPan( false );
}
pcbnew: added graphical polygon drawing & editing tools
2017-10-19 21:14:01 +00:00
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
bool PCB_POINT_EDITOR::Init()
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
{
// Find the selection tool, so they can cooperate
m_selectionTool = m_toolMgr->GetTool<PCB_SELECTION_TOOL>();
pcbnew: added graphical polygon drawing & editing tools
2017-10-19 21:14:01 +00:00
More wide-string declarations.
2022-02-05 13:25:43 +00:00
wxASSERT_MSG( m_selectionTool, wxT( "pcbnew.InteractiveSelection tool is not available" ) );
pcbnew: added graphical polygon drawing & editing tools
2017-10-19 21:14:01 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
auto& menu = m_selectionTool->GetToolMenu().GetMenu();
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
menu.AddItem( PCB_ACTIONS::pointEditorAddCorner, PCB_POINT_EDITOR::addCornerCondition );
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
menu.AddItem( PCB_ACTIONS::pointEditorRemoveCorner,
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
std::bind( &PCB_POINT_EDITOR::removeCornerCondition, this, _1 ) );
pcbnew: added graphical polygon drawing & editing tools
2017-10-19 21:14:01 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
return true;
}
pcbnew: added graphical polygon drawing & editing tools
2017-10-19 21:14:01 +00:00
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
void PCB_POINT_EDITOR::buildForPolyOutline( std::shared_ptr<EDIT_POINTS> points,
const SHAPE_POLY_SET* aOutline )
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
{
int cornersCount = aOutline->TotalVertices();
More data validity checks in POINT_EDITOR Fixes: lp:1690658 * https://bugs.launchpad.net/kicad/+bug/1690658
2017-05-16 09:38:00 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
for( auto iterator = aOutline->CIterateWithHoles(); iterator; iterator++ )
{
points->AddPoint( *iterator );
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
if( iterator.IsEndContour() )
points->AddBreak();
}
Finish implementation of DRAWSEGMENT::C_RECT. It's currently only supported in the Footprint Editor. It could be easily added to the board editor (all the code is there), but the board editor is a little short on room in the drawing tools toolbar.
2020-06-15 19:50:20 +00:00
TextBoxes for PCBNew.
2022-01-30 10:52:52 +00:00
// Lines have to be added after creating edit points, as they use EDIT_POINT references
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
for( int i = 0; i < cornersCount - 1; ++i )
{
if( points->IsContourEnd( i ) )
points->AddLine( points->Point( i ), points->Point( points->GetContourStartIdx( i ) ) );
else
points->AddLine( points->Point( i ), points->Point( i + 1 ) );
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
points->Line( i ).SetConstraint( new EC_PERPLINE( points->Line( i ) ) );
}
pcbnew: Allow arc editing via midpoint This permits changing the radius of the arc by adjusting the center point of the arc. The arc end points are fixed in this operation.
2018-12-08 15:26:47 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
// The last missing line, connecting the last and the first polygon point
points->AddLine( points->Point( cornersCount - 1 ),
points->Point( points->GetContourStartIdx( cornersCount - 1 ) ) );
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
points->Line( points->LinesSize() - 1 )
.SetConstraint( new EC_PERPLINE( points->Line( points->LinesSize() - 1 ) ) );
}
Fix fly-off arc handles and move Arc Properties to start/end/angle. Fixes https://gitlab.com/kicad/code/kicad/issues/5791
2020-10-08 09:59:17 +00:00
Circles are supported by POINT_EDITOR.
2014-02-28 17:24:13 +00:00
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
std::shared_ptr<EDIT_POINTS> PCB_POINT_EDITOR::makePoints( EDA_ITEM* aItem )
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
{
std::shared_ptr<EDIT_POINTS> points = std::make_shared<EDIT_POINTS>( aItem );
Add Bezier curve (S_CURVE shape) support in DIALOG_GRAPHIC_ITEM_PROPERTIES. Fix some issues related to S_CURVE shape support.
2018-07-22 12:50:35 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
if( !aItem )
return points;
pcbnew: added graphical polygon drawing & editing tools
2017-10-19 21:14:01 +00:00
TextBoxes for PCBNew.
2022-01-30 10:52:52 +00:00
if( aItem->Type() == PCB_TEXTBOX_T || aItem->Type() == PCB_FP_TEXTBOX_T )
{
const PCB_SHAPE* shape = static_cast<const PCB_SHAPE*>( aItem );
// We can't currently handle TEXTBOXes that have been turned into SHAPE_T::POLYs due
// to non-cardinal rotations
if( shape->GetShape() != SHAPE_T::RECT )
return points;
}
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
// Generate list of edit points basing on the item type
switch( aItem->Type() )
{
PCB Editor: Add User Background Images
2022-02-08 19:29:54 +00:00
case PCB_BITMAP_T:
{
PCB_BITMAP* bitmap = (PCB_BITMAP*) aItem;
VECTOR2I topLeft = bitmap->GetPosition() - bitmap->GetSize() / 2;
VECTOR2I botRight = bitmap->GetPosition() + bitmap->GetSize() / 2;
points->AddPoint( topLeft );
points->AddPoint( VECTOR2I( botRight.x, topLeft.y ) );
points->AddPoint( botRight );
points->AddPoint( VECTOR2I( topLeft.x, botRight.y ) );
break;
}
TextBoxes for PCBNew.
2022-01-30 10:52:52 +00:00
case PCB_TEXTBOX_T:
case PCB_FP_TEXTBOX_T:
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
case PCB_SHAPE_T:
case PCB_FP_SHAPE_T:
{
const PCB_SHAPE* shape = static_cast<const PCB_SHAPE*>( aItem );
Zones are supported by POINT_EDITOR.
2014-02-28 17:24:29 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
switch( shape->GetShape() )
{
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
case SHAPE_T::SEGMENT:
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
points->AddPoint( shape->GetStart() );
points->AddPoint( shape->GetEnd() );
break;
Zones are supported by POINT_EDITOR.
2014-02-28 17:24:29 +00:00
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
case SHAPE_T::RECT:
Repair point editing of rotated text boxes. Fixes https://gitlab.com/kicad/code/kicad/issues/11432
2022-06-02 09:42:13 +00:00
points->AddPoint( shape->GetTopLeft() );
points->AddPoint( VECTOR2I( shape->GetBotRight().x, shape->GetTopLeft().y ) );
points->AddPoint( shape->GetBotRight() );
points->AddPoint( VECTOR2I( shape->GetTopLeft().x, shape->GetBotRight().y ) );
Add center handles to rectangle edits Allows changing a single dimension at a time. Matching the polygon edit tool. Fixes https://gitlab.com/kicad/code/kicad/issues/7085
2021-01-13 22:03:31 +00:00
points->AddLine( points->Point( RECT_TOP_LEFT ), points->Point( RECT_TOP_RIGHT ) );
points->Line( RECT_TOP ).SetConstraint( new EC_PERPLINE( points->Line( RECT_TOP ) ) );
points->AddLine( points->Point( RECT_TOP_RIGHT ), points->Point( RECT_BOT_RIGHT ) );
points->Line( RECT_RIGHT ).SetConstraint( new EC_PERPLINE( points->Line( RECT_RIGHT ) ) );
points->AddLine( points->Point( RECT_BOT_RIGHT ), points->Point( RECT_BOT_LEFT ) );
points->Line( RECT_BOT ).SetConstraint( new EC_PERPLINE( points->Line( RECT_BOT ) ) );
points->AddLine( points->Point( RECT_BOT_LEFT ), points->Point( RECT_TOP_LEFT ) );
points->Line( RECT_LEFT ).SetConstraint( new EC_PERPLINE( points->Line( RECT_LEFT ) ) );
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
break;
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
case SHAPE_T::ARC:
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
points->AddPoint( shape->GetCenter() );
Overhaul arc internal model to not over-specify information.
2021-07-17 19:56:18 +00:00
points->AddPoint( shape->GetStart() );
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
points->AddPoint( shape->GetArcMid() );
Overhaul arc internal model to not over-specify information.
2021-07-17 19:56:18 +00:00
points->AddPoint( shape->GetEnd() );
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
points->Point( ARC_MID ).SetGridConstraint( IGNORE_GRID );
Snap arc center *by* the grid, not *to* the grid. Also fixes a bug with editing an arc endpoint because the cursor pos was being forced before the arc constraints stuff had been run (in updateItem()).
2021-01-18 22:31:48 +00:00
points->Point( ARC_START ).SetGridConstraint( SNAP_TO_GRID );
points->Point( ARC_CENTER ).SetGridConstraint( SNAP_BY_GRID );
points->Point( ARC_END ).SetGridConstraint( SNAP_TO_GRID );
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
break;
Added new constraint for EDIT_POINTs (EPC_LINE). Dimensions have EDIT_POINTs. Different handling of 45 degree mode in POINT_EDITOR.
2014-03-12 09:46:11 +00:00
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
case SHAPE_T::CIRCLE:
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
points->AddPoint( shape->GetCenter() );
points->AddPoint( shape->GetEnd() );
break;
Added new constraint for EDIT_POINTs (EPC_LINE). Dimensions have EDIT_POINTs. Different handling of 45 degree mode in POINT_EDITOR.
2014-03-12 09:46:11 +00:00
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
case SHAPE_T::POLY:
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
buildForPolyOutline( points, &shape->GetPolyShape() );
break;
Zones are supported by POINT_EDITOR.
2014-02-28 17:24:29 +00:00
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
case SHAPE_T::BEZIER:
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
points->AddPoint( shape->GetStart() );
Naming conventions and a bug fix on arc points.
2021-07-18 12:31:56 +00:00
points->AddPoint( shape->GetBezierC1() );
points->AddPoint( shape->GetBezierC2() );
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
points->AddPoint( shape->GetEnd() );
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
break;
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
default: // suppress warnings
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
break;
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
}
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
break;
}
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
case PCB_PAD_T:
{
const PAD* pad = static_cast<const PAD*>( aItem );
Neurotically update position wxPoint usages
2022-01-01 06:04:08 +00:00
VECTOR2I shapePos = pad->ShapePos();
VECTOR2I halfSize( pad->GetSize().x / 2, pad->GetSize().y / 2 );
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
Move pad locking from footprint to pads. Fixes https://gitlab.com/kicad/code/kicad/issues/6997
2021-01-08 16:32:28 +00:00
if( !m_isFootprintEditor || pad->IsLocked() )
ADDED: Center marker dimension type
2020-09-17 00:54:58 +00:00
break;
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
switch( pad->GetShape() )
ADDED: Center marker dimension type
2020-09-17 00:54:58 +00:00
{
enum class PAD_SHAPE_T
2021-05-01 12:22:35 +00:00
case PAD_SHAPE::CIRCLE:
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
points->AddPoint( VECTOR2I( shapePos.x + halfSize.x, shapePos.y ) );
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
break;
enum class PAD_SHAPE_T
2021-05-01 12:22:35 +00:00
case PAD_SHAPE::OVAL:
case PAD_SHAPE::TRAPEZOID:
case PAD_SHAPE::RECT:
case PAD_SHAPE::ROUNDRECT:
case PAD_SHAPE::CHAMFERED_RECT:
ADDED: Leader dimension object Fixes https://gitlab.com/kicad/code/kicad/-/issues/5555
2020-09-12 20:09:40 +00:00
{
Move pads to EDA_ANGLE.
2022-01-13 13:45:48 +00:00
if( !pad->GetOrientation().IsCardinal() )
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
break;
ADDED: Leader dimension object Fixes https://gitlab.com/kicad/code/kicad/-/issues/5555
2020-09-12 20:09:40 +00:00
Move pads to EDA_ANGLE.
2022-01-13 13:45:48 +00:00
if( pad->GetOrientation() == ANGLE_90 || pad->GetOrientation() == ANGLE_270 )
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
std::swap( halfSize.x, halfSize.y );
ADDED: Leader dimension object Fixes https://gitlab.com/kicad/code/kicad/-/issues/5555
2020-09-12 20:09:40 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
points->AddPoint( shapePos - halfSize );
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
points->AddPoint( VECTOR2I( shapePos.x + halfSize.x, shapePos.y - halfSize.y ) );
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
points->AddPoint( shapePos + halfSize );
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
points->AddPoint( VECTOR2I( shapePos.x - halfSize.x, shapePos.y + halfSize.y ) );
ADDED: Leader dimension object Fixes https://gitlab.com/kicad/code/kicad/-/issues/5555
2020-09-12 20:09:40 +00:00
}
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
break;
ADDED: Leader dimension object Fixes https://gitlab.com/kicad/code/kicad/-/issues/5555
2020-09-12 20:09:40 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
default: // suppress warnings
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
break;
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
}
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
}
break;
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
case PCB_FP_ZONE_T:
case PCB_ZONE_T:
{
const ZONE* zone = static_cast<const ZONE*>( aItem );
buildForPolyOutline( points, zone->Outline() );
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
}
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
break;
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
case PCB_DIM_ALIGNED_T:
case PCB_DIM_ORTHOGONAL_T:
Dimensions for footprints. Fixes https://gitlab.com/kicad/code/kicad/issues/8441
2021-12-04 23:52:00 +00:00
case PCB_FP_DIM_ALIGNED_T:
case PCB_FP_DIM_ORTHOGONAL_T:
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
{
Prefix DIMENSION types.
2021-06-11 16:59:28 +00:00
const PCB_DIM_ALIGNED* dimension = static_cast<const PCB_DIM_ALIGNED*>( aItem );
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
points->AddPoint( dimension->GetStart() );
points->AddPoint( dimension->GetEnd() );
points->AddPoint( dimension->Text().GetPosition() );
points->AddPoint( dimension->GetCrossbarStart() );
points->AddPoint( dimension->GetCrossbarEnd() );
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
Partially integrate grid snapping with constraints. Fixes https://gitlab.com/kicad/code/kicad/issues/10941
2022-02-22 21:00:48 +00:00
points->Point( DIM_START ).SetSnapConstraint( ALL_LAYERS );
points->Point( DIM_END ).SetSnapConstraint( ALL_LAYERS );
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
if( aItem->Type() == PCB_DIM_ALIGNED_T )
{
// Dimension height setting - edit points should move only along the feature lines
points->Point( DIM_CROSSBARSTART )
.SetConstraint( new EC_LINE( points->Point( DIM_CROSSBARSTART ),
points->Point( DIM_START ) ) );
points->Point( DIM_CROSSBAREND )
.SetConstraint( new EC_LINE( points->Point( DIM_CROSSBAREND ),
points->Point( DIM_END ) ) );
}
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
break;
}
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
case PCB_DIM_CENTER_T:
Dimensions for footprints. Fixes https://gitlab.com/kicad/code/kicad/issues/8441
2021-12-04 23:52:00 +00:00
case PCB_FP_DIM_CENTER_T:
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
{
Prefix DIMENSION types.
2021-06-11 16:59:28 +00:00
const PCB_DIM_CENTER* dimension = static_cast<const PCB_DIM_CENTER*>( aItem );
Allow drawing self-intersecting polygons, just display a warning Fixes: lp:1751654 * https://bugs.launchpad.net/kicad/+bug/1751654
2018-03-02 09:55:59 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
points->AddPoint( dimension->GetStart() );
points->AddPoint( dimension->GetEnd() );
Fixed POINT_EDITOR crash on GAL change / board reload.
2014-02-28 16:20:10 +00:00
Partially integrate grid snapping with constraints. Fixes https://gitlab.com/kicad/code/kicad/issues/10941
2022-02-22 21:00:48 +00:00
points->Point( DIM_START ).SetSnapConstraint( ALL_LAYERS );
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
points->Point( DIM_END ).SetConstraint( new EC_45DEGREE( points->Point( DIM_END ),
points->Point( DIM_START ) ) );
Partially integrate grid snapping with constraints. Fixes https://gitlab.com/kicad/code/kicad/issues/10941
2022-02-22 21:00:48 +00:00
points->Point( DIM_END ).SetSnapConstraint( IGNORE_SNAPS );
Fixed POINT_EDITOR crash on GAL change / board reload.
2014-02-28 16:20:10 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
break;
}
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
Radial dimensions. ADDED radial type dimensions. Fixes https://gitlab.com/kicad/code/kicad/issues/2056
2021-07-13 18:46:33 +00:00
case PCB_DIM_RADIAL_T:
Dimensions for footprints. Fixes https://gitlab.com/kicad/code/kicad/issues/8441
2021-12-04 23:52:00 +00:00
case PCB_FP_DIM_RADIAL_T:
Radial dimensions. ADDED radial type dimensions. Fixes https://gitlab.com/kicad/code/kicad/issues/2056
2021-07-13 18:46:33 +00:00
{
const PCB_DIM_RADIAL* dimension = static_cast<const PCB_DIM_RADIAL*>( aItem );
points->AddPoint( dimension->GetStart() );
points->AddPoint( dimension->GetEnd() );
points->AddPoint( dimension->Text().GetPosition() );
points->AddPoint( dimension->GetKnee() );
Partially integrate grid snapping with constraints. Fixes https://gitlab.com/kicad/code/kicad/issues/10941
2022-02-22 21:00:48 +00:00
points->Point( DIM_START ).SetSnapConstraint( ALL_LAYERS );
points->Point( DIM_END ).SetSnapConstraint( ALL_LAYERS );
Radial dimensions. ADDED radial type dimensions. Fixes https://gitlab.com/kicad/code/kicad/issues/2056
2021-07-13 18:46:33 +00:00
points->Point( DIM_KNEE ).SetConstraint( new EC_LINE( points->Point( DIM_START ),
points->Point( DIM_END ) ) );
Partially integrate grid snapping with constraints. Fixes https://gitlab.com/kicad/code/kicad/issues/10941
2022-02-22 21:00:48 +00:00
points->Point( DIM_KNEE ).SetSnapConstraint( IGNORE_SNAPS );
Radial dimensions. ADDED radial type dimensions. Fixes https://gitlab.com/kicad/code/kicad/issues/2056
2021-07-13 18:46:33 +00:00
points->Point( DIM_TEXT ).SetConstraint( new EC_45DEGREE( points->Point( DIM_TEXT ),
points->Point( DIM_KNEE ) ) );
Partially integrate grid snapping with constraints. Fixes https://gitlab.com/kicad/code/kicad/issues/10941
2022-02-22 21:00:48 +00:00
points->Point( DIM_TEXT ).SetSnapConstraint( IGNORE_SNAPS );
Radial dimensions. ADDED radial type dimensions. Fixes https://gitlab.com/kicad/code/kicad/issues/2056
2021-07-13 18:46:33 +00:00
break;
}
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
case PCB_DIM_LEADER_T:
Dimensions for footprints. Fixes https://gitlab.com/kicad/code/kicad/issues/8441
2021-12-04 23:52:00 +00:00
case PCB_FP_DIM_LEADER_T:
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
{
Prefix DIMENSION types.
2021-06-11 16:59:28 +00:00
const PCB_DIM_LEADER* dimension = static_cast<const PCB_DIM_LEADER*>( aItem );
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
points->AddPoint( dimension->GetStart() );
points->AddPoint( dimension->GetEnd() );
points->AddPoint( dimension->Text().GetPosition() );
"Create corner" context menu entry for draw segments and zone outlines (GAL).
2014-07-09 14:50:31 +00:00
Partially integrate grid snapping with constraints. Fixes https://gitlab.com/kicad/code/kicad/issues/10941
2022-02-22 21:00:48 +00:00
points->Point( DIM_START ).SetSnapConstraint( ALL_LAYERS );
points->Point( DIM_END ).SetSnapConstraint( ALL_LAYERS );
Back-port some fixes from 7.0 branch.
2021-07-13 15:10:18 +00:00
points->Point( DIM_TEXT ).SetConstraint( new EC_45DEGREE( points->Point( DIM_TEXT ),
points->Point( DIM_END ) ) );
Partially integrate grid snapping with constraints. Fixes https://gitlab.com/kicad/code/kicad/issues/10941
2022-02-22 21:00:48 +00:00
points->Point( DIM_TEXT ).SetSnapConstraint( IGNORE_SNAPS );
Back-port some fixes from 7.0 branch.
2021-07-13 15:10:18 +00:00
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
break;
}
default:
points.reset();
break;
}
return points;
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
}
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
void PCB_POINT_EDITOR::updateEditedPoint( const TOOL_EVENT& aEvent )
Improved code for handling zone corner dragging (GAL).
2015-08-12 08:15:45 +00:00
{
Overhaul cursor code for new tool/action framework. Includes the addition of an onSetCursor() handler which must be called from both the GAL canvas AND the GAL backend (at least on OSX) to prevent cursor flickering between (for instance) pencil and arrow. Also includes new architecture for point editors which allows them to coordiate cursors with the editing tools (so we can switch to an arrow when over a point).
2019-06-27 21:33:48 +00:00
EDIT_POINT* point;
Improve edit point legibility with a hover state
2020-09-24 01:27:23 +00:00
EDIT_POINT* hovered = nullptr;
Improved code for handling zone corner dragging (GAL).
2015-08-12 08:15:45 +00:00
if( aEvent.IsMotion() )
{
Refactoring of VIEW/VIEW_ITEM classes: - Remove dependency of EDA_ITEM on VIEW - VIEW_ITEM is now a pure virtual interface
2016-12-02 17:58:12 +00:00
point = m_editPoints->FindPoint( aEvent.Position(), getView() );
Improve edit point legibility with a hover state
2020-09-24 01:27:23 +00:00
hovered = point;
Improved code for handling zone corner dragging (GAL).
2015-08-12 08:15:45 +00:00
}
else if( aEvent.IsDrag( BUT_LEFT ) )
{
Refactoring of VIEW/VIEW_ITEM classes: - Remove dependency of EDA_ITEM on VIEW - VIEW_ITEM is now a pure virtual interface
2016-12-02 17:58:12 +00:00
point = m_editPoints->FindPoint( aEvent.DragOrigin(), getView() );
Improved code for handling zone corner dragging (GAL).
2015-08-12 08:15:45 +00:00
}
Overhaul cursor code for new tool/action framework. Includes the addition of an onSetCursor() handler which must be called from both the GAL canvas AND the GAL backend (at least on OSX) to prevent cursor flickering between (for instance) pencil and arrow. Also includes new architecture for point editors which allows them to coordiate cursors with the editing tools (so we can switch to an arrow when over a point).
2019-06-27 21:33:48 +00:00
else
{
point = m_editPoints->FindPoint( getViewControls()->GetCursorPosition(), getView() );
}
Improved code for handling zone corner dragging (GAL).
2015-08-12 08:15:45 +00:00
Improve edit point legibility with a hover state
2020-09-24 01:27:23 +00:00
if( hovered )
{
if( m_hoveredPoint != hovered )
{
if( m_hoveredPoint )
m_hoveredPoint->SetHover( false );
m_hoveredPoint = hovered;
m_hoveredPoint->SetHover();
}
}
else if( m_hoveredPoint )
{
m_hoveredPoint->SetHover( false );
m_hoveredPoint = nullptr;
}
Improved code for handling zone corner dragging (GAL).
2015-08-12 08:15:45 +00:00
if( m_editedPoint != point )
setEditedPoint( point );
}
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
int PCB_POINT_EDITOR::OnSelectionChange( const TOOL_EVENT& aEvent )
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
{
Inhibit point editor while drag-selecting Fixes https://gitlab.com/kicad/code/kicad/-/issues/6155
2020-10-25 16:13:25 +00:00
if( !m_selectionTool || aEvent.Matches( EVENTS::InhibitSelectionEditing ) )
Added safety for POINT_EDITOR. Fixes: lp:1786349 * https://bugs.launchpad.net/kicad/+bug/1786349
2018-09-17 11:31:57 +00:00
return 0;
Make PCB_POINT_EDITOR honour locked flag. Fixes https://gitlab.com/kicad/code/kicad/issues/8254
2021-05-25 17:12:49 +00:00
PCB_BASE_EDIT_FRAME* editFrame = getEditFrame<PCB_BASE_EDIT_FRAME>();
Make distinction between PCBNew-wide tools and Board-specific tools. The old names were really hard to keep straight (even for me, who named many of them).
2020-12-16 13:31:32 +00:00
const PCB_SELECTION& selection = m_selectionTool->GetSelection();
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
Don't let point editor interrupt other operations. Fixes: lp:1832416 * https://bugs.launchpad.net/kicad/+bug/1832416
2019-06-12 16:14:55 +00:00
if( selection.Size() != 1 || selection.Front()->GetEditFlags() )
Removed code resetting VIEW_CONTROLS settings As the VIEW_CONTROLS settings are managed for each tool, there is no need to restore the settings to initial state when a tool is finished.
2017-03-06 09:55:32 +00:00
return 0;
pcbnew: Ensure that dimension tool snaps to anything The dimension tool is used to measure physical dimensions on the board therefore it should be able to snap to any other object, not just those on its own layer set as is the case for other items. This also deals with a corner snap case for constraints by first snapping, then constraining, then aligning to grid. This ensures OoO for alignment from least to most constraining.
2018-10-07 02:55:20 +00:00
BOARD_ITEM* item = static_cast<BOARD_ITEM*>( selection.Front() );
45 degrees mode for POINT_EDITOR.
2014-03-06 13:41:25 +00:00
Make PCB_POINT_EDITOR honour locked flag. Fixes https://gitlab.com/kicad/code/kicad/issues/8254
2021-05-25 17:12:49 +00:00
if( !item || item->IsLocked() )
PcbNew: prevent crash in point editor if selection gets invalidated
2019-05-30 00:51:22 +00:00
return 0;
Make PCB_POINT_EDITOR honour locked flag. Fixes https://gitlab.com/kicad/code/kicad/issues/8254
2021-05-25 17:12:49 +00:00
Activate();
Don't push view control settings to the previous active tool. See further comments in bug report. Fixes https://gitlab.com/kicad/code/kicad/issues/9147
2021-09-13 12:23:10 +00:00
// Must be done after Activate() so that it gets set into the correct context
Make PCB_POINT_EDITOR honour locked flag. Fixes https://gitlab.com/kicad/code/kicad/issues/8254
2021-05-25 17:12:49 +00:00
getViewControls()->ShowCursor( true );
PCB_GRID_HELPER grid( m_toolMgr, editFrame->GetMagneticItemsSettings() );
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
m_editPoints = makePoints( item );
setTransitions() are called automatically for tools.
2015-04-30 08:46:03 +00:00
Removed code resetting VIEW_CONTROLS settings As the VIEW_CONTROLS settings are managed for each tool, there is no need to restore the settings to initial state when a tool is finished.
2017-03-06 09:55:32 +00:00
if( !m_editPoints )
return 0;
45 degrees mode for POINT_EDITOR.
2014-03-06 13:41:25 +00:00
Make PCB_POINT_EDITOR honour locked flag. Fixes https://gitlab.com/kicad/code/kicad/issues/8254
2021-05-25 17:12:49 +00:00
getView()->Add( m_editPoints.get() );
Fix cursor freezes in GAL Launching right click context menu overrides the cursor position, so all actions executed by the tools will be performed in the right click position. It created an issue, as the overridden cursor settings were saved into wrong context if there was another tool activated in the meantime. Current implementation saves cursor settings for all tools and restores them once the right click context menu disappears. Fixes: lp:1745981 * https://bugs.launchpad.net/kicad/+bug/1745981 Fixes: lp:1746507 * https://bugs.launchpad.net/kicad/+bug/1746507
2018-02-02 15:20:14 +00:00
setEditedPoint( nullptr );
Overhaul cursor code for new tool/action framework. Includes the addition of an onSetCursor() handler which must be called from both the GAL canvas AND the GAL backend (at least on OSX) to prevent cursor flickering between (for instance) pencil and arrow. Also includes new architecture for point editors which allows them to coordiate cursors with the editing tools (so we can switch to an arrow when over a point).
2019-06-27 21:33:48 +00:00
updateEditedPoint( aEvent );
Refill zones only when required Previous implementation refilled zones every time they have been unselected. This patch adds a flag that tracks whether the zone has been actually modified, so it will be refilled only when necessary. Fixes: lp:1760903 * https://bugs.launchpad.net/kicad/+bug/1760903
2018-04-03 20:26:01 +00:00
m_refill = false;
Beware of copying events and losing the m_passEvent flag. Fixes: lp:1833031 * https://bugs.launchpad.net/kicad/+bug/1833031
2019-06-17 13:43:22 +00:00
bool inDrag = false;
Change persistent 45° state to only drawing Move/edit points have a lossy state that holds only for the time in which the tool is active. It reverts back to non-constrained after completion of the move/point edit Fixes https://gitlab.com/kicad/code/kicad/issues/9574
2021-11-17 23:36:39 +00:00
bool lock45 = false;
Undo/redo support for POINT_EDITOR.
2014-03-06 11:36:20 +00:00
Removed code resetting VIEW_CONTROLS settings As the VIEW_CONTROLS settings are managed for each tool, there is no need to restore the settings to initial state when a tool is finished.
2017-03-06 09:55:32 +00:00
BOARD_COMMIT commit( editFrame );
Modified tools to use BOARD_COMMIT.
2016-06-21 15:06:28 +00:00
Removed code resetting VIEW_CONTROLS settings As the VIEW_CONTROLS settings are managed for each tool, there is no need to restore the settings to initial state when a tool is finished.
2017-03-06 09:55:32 +00:00
// Main loop: keep receiving events
Beware of copying events and losing the m_passEvent flag. Fixes: lp:1833031 * https://bugs.launchpad.net/kicad/+bug/1833031
2019-06-17 13:43:22 +00:00
while( TOOL_EVENT* evt = Wait() )
Removed code resetting VIEW_CONTROLS settings As the VIEW_CONTROLS settings are managed for each tool, there is no need to restore the settings to initial state when a tool is finished.
2017-03-06 09:55:32 +00:00
{
pcbnew: Implement consistent graphical snapping This creates a standard snapping framework in the GRID_HELPER class that allows snapping to items on the same layer as the object being created/moved as well as consistent toggling of this using the Shift key modifier. Fixes: lp:806260 * https://bugs.launchpad.net/kicad/+bug/806260 Fixes: lp:1604616 * https://bugs.launchpad.net/kicad/+bug/1604616
2018-10-04 00:15:54 +00:00
grid.SetSnap( !evt->Modifier( MD_SHIFT ) );
Make PCB_POINT_EDITOR honour locked flag. Fixes https://gitlab.com/kicad/code/kicad/issues/8254
2021-05-25 17:12:49 +00:00
grid.SetUseGrid( getView()->GetGAL()->GetGridSnapping() && !evt->DisableGridSnapping() );
pcbnew: Implement consistent graphical snapping This creates a standard snapping framework in the GRID_HELPER class that allows snapping to items on the same layer as the object being created/moved as well as consistent toggling of this using the Shift key modifier. Fixes: lp:806260 * https://bugs.launchpad.net/kicad/+bug/806260 Fixes: lp:1604616 * https://bugs.launchpad.net/kicad/+bug/1604616
2018-10-04 00:15:54 +00:00
Inhibit point editor while drag-selecting Fixes https://gitlab.com/kicad/code/kicad/-/issues/6155
2020-10-25 16:13:25 +00:00
if( !m_editPoints || evt->IsSelectionEvent() ||
evt->Matches( EVENTS::InhibitSelectionEditing ) )
Grid snapping fixes. 1) Uniformly honour the GAL grid snap settings 2) Make more uniform use of GRID_HELPERs 3) Smarten EDIT_LINE for mid-point snapping Fixes https://gitlab.com/kicad/code/kicad/issues/6558
2020-12-03 19:53:39 +00:00
{
Removed code resetting VIEW_CONTROLS settings As the VIEW_CONTROLS settings are managed for each tool, there is no need to restore the settings to initial state when a tool is finished.
2017-03-06 09:55:32 +00:00
break;
Grid snapping fixes. 1) Uniformly honour the GAL grid snap settings 2) Make more uniform use of GRID_HELPERs 3) Smarten EDIT_LINE for mid-point snapping Fixes https://gitlab.com/kicad/code/kicad/issues/6558
2020-12-03 19:53:39 +00:00
}
Coding policy fixes: remove trailing white space.
2015-12-14 21:20:54 +00:00
Improve edit point legibility with a hover state
2020-09-24 01:27:23 +00:00
EDIT_POINT* prevHover = m_hoveredPoint;
if( !inDrag )
Removed code resetting VIEW_CONTROLS settings As the VIEW_CONTROLS settings are managed for each tool, there is no need to restore the settings to initial state when a tool is finished.
2017-03-06 09:55:32 +00:00
updateEditedPoint( *evt );
Fixed POINT_EDITOR crash on GAL change / board reload.
2014-02-28 16:20:10 +00:00
Improve edit point legibility with a hover state
2020-09-24 01:27:23 +00:00
if( prevHover != m_hoveredPoint )
getView()->Update( m_editPoints.get() );
Removed code resetting VIEW_CONTROLS settings As the VIEW_CONTROLS settings are managed for each tool, there is no need to restore the settings to initial state when a tool is finished.
2017-03-06 09:55:32 +00:00
if( evt->IsDrag( BUT_LEFT ) && m_editedPoint )
{
Beware of copying events and losing the m_passEvent flag. Fixes: lp:1833031 * https://bugs.launchpad.net/kicad/+bug/1833031
2019-06-17 13:43:22 +00:00
if( !inDrag )
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
{
Fix fly-off arc handles and move Arc Properties to start/end/angle. Fixes https://gitlab.com/kicad/code/kicad/issues/5791
2020-10-08 09:59:17 +00:00
frame()->UndoRedoBlock( true );
Removed code resetting VIEW_CONTROLS settings As the VIEW_CONTROLS settings are managed for each tool, there is no need to restore the settings to initial state when a tool is finished.
2017-03-06 09:55:32 +00:00
commit.StageItems( selection, CHT_MODIFY );
Removed a number 'if(m_editModules)' sections from pcbnew tools.
2016-06-08 09:24:46 +00:00
Make PCB_POINT_EDITOR honour locked flag. Fixes https://gitlab.com/kicad/code/kicad/issues/8254
2021-05-25 17:12:49 +00:00
getViewControls()->ForceCursorPosition( false );
Removed code resetting VIEW_CONTROLS settings As the VIEW_CONTROLS settings are managed for each tool, there is no need to restore the settings to initial state when a tool is finished.
2017-03-06 09:55:32 +00:00
m_original = *m_editedPoint; // Save the original position
Make PCB_POINT_EDITOR honour locked flag. Fixes https://gitlab.com/kicad/code/kicad/issues/8254
2021-05-25 17:12:49 +00:00
getViewControls()->SetAutoPan( true );
Beware of copying events and losing the m_passEvent flag. Fixes: lp:1833031 * https://bugs.launchpad.net/kicad/+bug/1833031
2019-06-17 13:43:22 +00:00
inDrag = true;
Snap arc center *by* the grid, not *to* the grid. Also fixes a bug with editing an arc endpoint because the cursor pos was being forced before the arc constraints stuff had been run (in updateItem()).
2021-01-18 22:31:48 +00:00
if( m_editedPoint->GetGridConstraint() != SNAP_BY_GRID )
grid.SetAuxAxes( true, m_original.GetPosition() );
ADDED: Improved center point dragging The center point on polygons now maintains the axis of the dragged line and, optionally with Ctrl pressed, maintains the slope of the adjacent segments as well. This also fixes a longstanding issue that prevented the ctrl-snapping from using the original point rather than the last updated point when constraining. Fixes https://gitlab.com/kicad/code/kicad/issues/2465
2020-08-27 17:31:53 +00:00
setAltConstraint( true );
Point editor: show dragged points with a highlight Take points editor colors from color theme Also fix an issue where the edited object sometimes didn't update when a point is dragged. Fixes https://gitlab.com/kicad/code/kicad/-/issues/4600
2020-06-21 18:43:33 +00:00
m_editedPoint->SetActive();
One active point at a time.
2021-11-01 16:17:33 +00:00
for( size_t ii = 0; ii < m_editPoints->PointsSize(); ++ii )
{
EDIT_POINT& point = m_editPoints->Point( ii );
if( &point != m_editedPoint )
point.SetActive( false );
}
Removed code resetting VIEW_CONTROLS settings As the VIEW_CONTROLS settings are managed for each tool, there is no need to restore the settings to initial state when a tool is finished.
2017-03-06 09:55:32 +00:00
}
Modified tools to use BOARD_COMMIT.
2016-06-21 15:06:28 +00:00
Snap arc center *by* the grid, not *to* the grid. Also fixes a bug with editing an arc endpoint because the cursor pos was being forced before the arc constraints stuff had been run (in updateItem()).
2021-01-18 22:31:48 +00:00
VECTOR2I pos = evt->Position();
Partially integrate grid snapping with constraints. Fixes https://gitlab.com/kicad/code/kicad/issues/10941
2022-02-22 21:00:48 +00:00
LSET snapLayers;
Snap arc center *by* the grid, not *to* the grid. Also fixes a bug with editing an arc endpoint because the cursor pos was being forced before the arc constraints stuff had been run (in updateItem()).
2021-01-18 22:31:48 +00:00
Partially integrate grid snapping with constraints. Fixes https://gitlab.com/kicad/code/kicad/issues/10941
2022-02-22 21:00:48 +00:00
switch( m_editedPoint->GetSnapConstraint() )
Fix fly-off arc handles and move Arc Properties to start/end/angle. Fixes https://gitlab.com/kicad/code/kicad/issues/5791
2020-10-08 09:59:17 +00:00
{
Partially integrate grid snapping with constraints. Fixes https://gitlab.com/kicad/code/kicad/issues/10941
2022-02-22 21:00:48 +00:00
case IGNORE_SNAPS: break;
case OBJECT_LAYERS: snapLayers = item->GetLayerSet(); break;
case ALL_LAYERS: snapLayers = LSET::AllLayersMask(); break;
}
Grid snapping fixes. 1) Uniformly honour the GAL grid snap settings 2) Make more uniform use of GRID_HELPERs 3) Smarten EDIT_LINE for mid-point snapping Fixes https://gitlab.com/kicad/code/kicad/issues/6558
2020-12-03 19:53:39 +00:00
Partially integrate grid snapping with constraints. Fixes https://gitlab.com/kicad/code/kicad/issues/10941
2022-02-22 21:00:48 +00:00
if( m_editedPoint->GetGridConstraint() == SNAP_BY_GRID )
Grid snapping fixes. 1) Uniformly honour the GAL grid snap settings 2) Make more uniform use of GRID_HELPERs 3) Smarten EDIT_LINE for mid-point snapping Fixes https://gitlab.com/kicad/code/kicad/issues/6558
2020-12-03 19:53:39 +00:00
{
Snap arc center *by* the grid, not *to* the grid. Also fixes a bug with editing an arc endpoint because the cursor pos was being forced before the arc constraints stuff had been run (in updateItem()).
2021-01-18 22:31:48 +00:00
if( grid.GetUseGrid() )
Grid snapping fixes. 1) Uniformly honour the GAL grid snap settings 2) Make more uniform use of GRID_HELPERs 3) Smarten EDIT_LINE for mid-point snapping Fixes https://gitlab.com/kicad/code/kicad/issues/6558
2020-12-03 19:53:39 +00:00
{
Repair algorithm to avoid slow movement issue. This goes back to the previous code for this one part. Fixes https://gitlab.com/kicad/code/kicad/issues/10976
2022-02-26 15:55:21 +00:00
VECTOR2I gridPt = grid.BestSnapAnchor( pos, {}, { item } );
Grid snapping fixes. 1) Uniformly honour the GAL grid snap settings 2) Make more uniform use of GRID_HELPERs 3) Smarten EDIT_LINE for mid-point snapping Fixes https://gitlab.com/kicad/code/kicad/issues/6558
2020-12-03 19:53:39 +00:00
Snap arc center *by* the grid, not *to* the grid. Also fixes a bug with editing an arc endpoint because the cursor pos was being forced before the arc constraints stuff had been run (in updateItem()).
2021-01-18 22:31:48 +00:00
VECTOR2I last = m_editedPoint->GetPosition();
VECTOR2I delta = pos - last;
Repair algorithm to avoid slow movement issue. This goes back to the previous code for this one part. Fixes https://gitlab.com/kicad/code/kicad/issues/10976
2022-02-26 15:55:21 +00:00
VECTOR2I deltaGrid = gridPt - grid.BestSnapAnchor( last, {}, { item } );
Snap arc center *by* the grid, not *to* the grid. Also fixes a bug with editing an arc endpoint because the cursor pos was being forced before the arc constraints stuff had been run (in updateItem()).
2021-01-18 22:31:48 +00:00
if( abs( delta.x ) > grid.GetGrid().x / 2 )
Repair algorithm to avoid slow movement issue. This goes back to the previous code for this one part. Fixes https://gitlab.com/kicad/code/kicad/issues/10976
2022-02-26 15:55:21 +00:00
pos.x = last.x + deltaGrid.x;
Snap arc center *by* the grid, not *to* the grid. Also fixes a bug with editing an arc endpoint because the cursor pos was being forced before the arc constraints stuff had been run (in updateItem()).
2021-01-18 22:31:48 +00:00
else
pos.x = last.x;
Grid snapping fixes. 1) Uniformly honour the GAL grid snap settings 2) Make more uniform use of GRID_HELPERs 3) Smarten EDIT_LINE for mid-point snapping Fixes https://gitlab.com/kicad/code/kicad/issues/6558
2020-12-03 19:53:39 +00:00
Fix Coverity-discovered typo.
2021-01-19 10:56:43 +00:00
if( abs( delta.y ) > grid.GetGrid().y / 2 )
Repair algorithm to avoid slow movement issue. This goes back to the previous code for this one part. Fixes https://gitlab.com/kicad/code/kicad/issues/10976
2022-02-26 15:55:21 +00:00
pos.y = last.y + deltaGrid.y;
Snap arc center *by* the grid, not *to* the grid. Also fixes a bug with editing an arc endpoint because the cursor pos was being forced before the arc constraints stuff had been run (in updateItem()).
2021-01-18 22:31:48 +00:00
else
pos.y = last.y;
Grid snapping fixes. 1) Uniformly honour the GAL grid snap settings 2) Make more uniform use of GRID_HELPERs 3) Smarten EDIT_LINE for mid-point snapping Fixes https://gitlab.com/kicad/code/kicad/issues/6558
2020-12-03 19:53:39 +00:00
}
More NULL expunging.
2021-07-19 23:56:05 +00:00
}
pcbnew: Retain 45° constraint This also finishes the polygon with 45° lines when chosen as a create option. Fixes: lp:1833673 * https://bugs.launchpad.net/kicad/+bug/1833673 (cherry picked from commit fccce265aa959f5f234d32dcd29e01c1f25bd9a5)
2019-08-26 13:30:03 +00:00
Partially integrate grid snapping with constraints. Fixes https://gitlab.com/kicad/code/kicad/issues/10941
2022-02-22 21:00:48 +00:00
m_editedPoint->SetPosition( pos );
Removes 3 other instances of a potential encoding problem Signed-off-by: hoijui <hoijui.quaero@gmail.com>
2021-01-05 07:42:52 +00:00
// The alternative constraint limits to 45 degrees
Change persistent 45° state to only drawing Move/edit points have a lossy state that holds only for the time in which the tool is active. It reverts back to non-constrained after completion of the move/point edit Fixes https://gitlab.com/kicad/code/kicad/issues/9574
2021-11-17 23:36:39 +00:00
if( lock45 )
Partially integrate grid snapping with constraints. Fixes https://gitlab.com/kicad/code/kicad/issues/10941
2022-02-22 21:00:48 +00:00
{
m_altConstraint->Apply( grid );
}
else if( m_editedPoint->IsConstrained() )
{
m_editedPoint->ApplyConstraint( grid );
}
else if( m_editedPoint->GetGridConstraint() == SNAP_TO_GRID )
Back-port some fixes from 7.0 branch.
2021-07-13 15:10:18 +00:00
{
m_editedPoint->SetPosition( grid.BestSnapAnchor( m_editedPoint->GetPosition(),
snapLayers, { item } ) );
}
pcbnew: Implement consistent graphical snapping This creates a standard snapping framework in the GRID_HELPER class that allows snapping to items on the same layer as the object being created/moved as well as consistent toggling of this using the Shift key modifier. Fixes: lp:806260 * https://bugs.launchpad.net/kicad/+bug/806260 Fixes: lp:1604616 * https://bugs.launchpad.net/kicad/+bug/1604616
2018-10-04 00:15:54 +00:00
Removed code resetting VIEW_CONTROLS settings As the VIEW_CONTROLS settings are managed for each tool, there is no need to restore the settings to initial state when a tool is finished.
2017-03-06 09:55:32 +00:00
updateItem();
Make PCB_POINT_EDITOR honour locked flag. Fixes https://gitlab.com/kicad/code/kicad/issues/8254
2021-05-25 17:12:49 +00:00
getViewControls()->ForceCursorPosition( true, m_editedPoint->GetPosition() );
Removed code resetting VIEW_CONTROLS settings As the VIEW_CONTROLS settings are managed for each tool, there is no need to restore the settings to initial state when a tool is finished.
2017-03-06 09:55:32 +00:00
updatePoints();
}
Improve edit point legibility with a hover state
2020-09-24 01:27:23 +00:00
else if( m_editedPoint && evt->Action() == TA_MOUSE_DOWN && evt->Buttons() == BUT_LEFT )
{
m_editedPoint->SetActive();
One active point at a time.
2021-11-01 16:17:33 +00:00
for( size_t ii = 0; ii < m_editPoints->PointsSize(); ++ii )
{
EDIT_POINT& point = m_editPoints->Point( ii );
if( &point != m_editedPoint )
point.SetActive( false );
}
Improve edit point legibility with a hover state
2020-09-24 01:27:23 +00:00
getView()->Update( m_editPoints.get() );
}
Beware of copying events and losing the m_passEvent flag. Fixes: lp:1833031 * https://bugs.launchpad.net/kicad/+bug/1833031
2019-06-17 13:43:22 +00:00
else if( inDrag && evt->IsMouseUp( BUT_LEFT ) )
Removed code resetting VIEW_CONTROLS settings As the VIEW_CONTROLS settings are managed for each tool, there is no need to restore the settings to initial state when a tool is finished.
2017-03-06 09:55:32 +00:00
{
Point editor: show dragged points with a highlight Take points editor colors from color theme Also fix an issue where the edited object sometimes didn't update when a point is dragged. Fixes https://gitlab.com/kicad/code/kicad/-/issues/4600
2020-06-21 18:43:33 +00:00
if( m_editedPoint )
{
m_editedPoint->SetActive( false );
getView()->Update( m_editPoints.get() );
}
Make PCB_POINT_EDITOR honour locked flag. Fixes https://gitlab.com/kicad/code/kicad/issues/8254
2021-05-25 17:12:49 +00:00
getViewControls()->SetAutoPan( false );
Removed code resetting VIEW_CONTROLS settings As the VIEW_CONTROLS settings are managed for each tool, there is no need to restore the settings to initial state when a tool is finished.
2017-03-06 09:55:32 +00:00
setAltConstraint( false );
Undo/redo support for POINT_EDITOR.
2014-03-06 11:36:20 +00:00
Beware of copying events and losing the m_passEvent flag. Fixes: lp:1833031 * https://bugs.launchpad.net/kicad/+bug/1833031
2019-06-17 13:43:22 +00:00
commit.Push( _( "Drag a corner" ) );
inDrag = false;
Fix fly-off arc handles and move Arc Properties to start/end/angle. Fixes https://gitlab.com/kicad/code/kicad/issues/5791
2020-10-08 09:59:17 +00:00
frame()->UndoRedoBlock( false );
Beware of copying events and losing the m_passEvent flag. Fixes: lp:1833031 * https://bugs.launchpad.net/kicad/+bug/1833031
2019-06-17 13:43:22 +00:00
m_refill = true;
Removed code resetting VIEW_CONTROLS settings As the VIEW_CONTROLS settings are managed for each tool, there is no need to restore the settings to initial state when a tool is finished.
2017-03-06 09:55:32 +00:00
}
Prepare for a more uniform implementation of H/V/45 mode.
2022-05-29 13:16:13 +00:00
else if( evt->IsAction( &PCB_ACTIONS::toggleHV45Mode ) )
Change persistent 45° state to only drawing Move/edit points have a lossy state that holds only for the time in which the tool is active. It reverts back to non-constrained after completion of the move/point edit Fixes https://gitlab.com/kicad/code/kicad/issues/9574
2021-11-17 23:36:39 +00:00
{
lock45 = !lock45;
evt->SetPassEvent( false );
}
Allow move tool to run on top of other tools. Fixes: lp:1784480 * https://bugs.launchpad.net/kicad/+bug/1784480
2019-07-01 21:01:33 +00:00
else if( evt->IsCancelInteractive() || evt->IsActivate() )
Removed code resetting VIEW_CONTROLS settings As the VIEW_CONTROLS settings are managed for each tool, there is no need to restore the settings to initial state when a tool is finished.
2017-03-06 09:55:32 +00:00
{
Beware of copying events and losing the m_passEvent flag. Fixes: lp:1833031 * https://bugs.launchpad.net/kicad/+bug/1833031
2019-06-17 13:43:22 +00:00
if( inDrag ) // Restore the last change
Fix fly-off arc handles and move Arc Properties to start/end/angle. Fixes https://gitlab.com/kicad/code/kicad/issues/5791
2020-10-08 09:59:17 +00:00
{
Tighten down the POINT_EDITORs a bit more.
2019-06-16 00:06:43 +00:00
commit.Revert();
Fix fly-off arc handles and move Arc Properties to start/end/angle. Fixes https://gitlab.com/kicad/code/kicad/issues/5791
2020-10-08 09:59:17 +00:00
inDrag = false;
frame()->UndoRedoBlock( false );
}
Removed code resetting VIEW_CONTROLS settings As the VIEW_CONTROLS settings are managed for each tool, there is no need to restore the settings to initial state when a tool is finished.
2017-03-06 09:55:32 +00:00
Allow point editor to persist After drawing a graphic, allow the control points to persist when exiting the tool. The effect of this is to make the first "Esc" press a "return-to-select-tool" event without modifying the selection or control points from within the drawing tools. The section "Esc" press, when in the selection tool will clear the selection and the control points
2021-05-25 23:45:57 +00:00
// Only cancel point editor when activating a new tool
// Otherwise, allow the points to persist when moving up the
// tool stack
Allow move tool to run on top of other tools. Fixes: lp:1784480 * https://bugs.launchpad.net/kicad/+bug/1784480
2019-07-01 21:01:33 +00:00
if( evt->IsActivate() && !evt->IsMoveTool() )
break;
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
}
Clear point editor on undo/redo. Fixes https://gitlab.com/kicad/code/kicad/issues/6224
2020-10-29 22:38:16 +00:00
else if( evt->Action() == TA_UNDO_REDO_POST )
{
break;
}
Removed code resetting VIEW_CONTROLS settings As the VIEW_CONTROLS settings are managed for each tool, there is no need to restore the settings to initial state when a tool is finished.
2017-03-06 09:55:32 +00:00
else
Clear point editor on undo/redo. Fixes https://gitlab.com/kicad/code/kicad/issues/6224
2020-10-29 22:38:16 +00:00
{
Make m_passEvent event-specific rather than global. If a tool called something like clearSelection while processing a MOUSE_CLICK, the SELECTION_TOOL will pass the clearSelection COMMAND_EVENT because it handles it as a transition, not as an event. Because m_passEvent is effectively global, the tool manager would then interpret that as passing the MOUSE_CLICK and we'd end up processing the click by multiple tools.
2019-06-16 11:06:49 +00:00
evt->SetPassEvent();
Clear point editor on undo/redo. Fixes https://gitlab.com/kicad/code/kicad/issues/6224
2020-10-29 22:38:16 +00:00
}
Removed code resetting VIEW_CONTROLS settings As the VIEW_CONTROLS settings are managed for each tool, there is no need to restore the settings to initial state when a tool is finished.
2017-03-06 09:55:32 +00:00
}
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
Removed code resetting VIEW_CONTROLS settings As the VIEW_CONTROLS settings are managed for each tool, there is no need to restore the settings to initial state when a tool is finished.
2017-03-06 09:55:32 +00:00
if( m_editPoints )
{
Make PCB_POINT_EDITOR honour locked flag. Fixes https://gitlab.com/kicad/code/kicad/issues/8254
2021-05-25 17:12:49 +00:00
getView()->Remove( m_editPoints.get() );
Removed code resetting VIEW_CONTROLS settings As the VIEW_CONTROLS settings are managed for each tool, there is no need to restore the settings to initial state when a tool is finished.
2017-03-06 09:55:32 +00:00
m_editPoints.reset();
45 degrees mode for POINT_EDITOR.
2014-03-06 13:41:25 +00:00
}
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
Clear edited point when exiting point editor Failing to clear this will prevent selection where tools check for edited points before processing mouse button down events Fixes https://gitlab.com/kicad/code/kicad/issues/9357
2021-10-10 15:24:45 +00:00
m_editedPoint = nullptr;
Don't display all the footprint info when an edge is selected. Fixes: lp:1800556 * https://bugs.launchpad.net/kicad/+bug/1800556
2018-10-30 11:32:42 +00:00
frame()->UpdateMsgPanel();
pcbnew: refresh message panel while drawing & editing graphical lines, arcs, circles and texts Fixes: lp:1763052 * https://bugs.launchpad.net/kicad/+bug/1763052
2018-04-12 16:08:45 +00:00
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
return 0;
}
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
void PCB_POINT_EDITOR::editArcEndpointKeepTangent( PCB_SHAPE* aArc, const VECTOR2I& aCenter,
const VECTOR2I& aStart, const VECTOR2I& aMid,
const VECTOR2I& aEnd,
const VECTOR2I& aCursor ) const
Revert "Use less-sophisticated arc editing math." This reverts commit 3b424d3868be6534ca3dea426eb8411ee46176fc. And fixes issue with rouding causing arc errors
2021-01-18 17:39:13 +00:00
{
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
VECTOR2I start = aStart;
VECTOR2I end = aEnd;
VECTOR2I center = aCenter;
Finish arc rework and push out to file formats.
2021-10-14 23:39:31 +00:00
bool movingStart;
bool arcValid = true;
Revert "Use less-sophisticated arc editing math." This reverts commit 3b424d3868be6534ca3dea426eb8411ee46176fc. And fixes issue with rouding causing arc errors
2021-01-18 17:39:13 +00:00
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
VECTOR2I p1, p2, p3;
Revert "Use less-sophisticated arc editing math." This reverts commit 3b424d3868be6534ca3dea426eb8411ee46176fc. And fixes issue with rouding causing arc errors
2021-01-18 17:39:13 +00:00
// p1 does not move, p2 does.
Overhaul arc internal model to not over-specify information.
2021-07-17 19:56:18 +00:00
if( aStart != aArc->GetStart() )
Revert "Use less-sophisticated arc editing math." This reverts commit 3b424d3868be6534ca3dea426eb8411ee46176fc. And fixes issue with rouding causing arc errors
2021-01-18 17:39:13 +00:00
{
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
start = aCursor;
p1 = aEnd;
p2 = aStart;
p3 = aMid;
Revert "Use less-sophisticated arc editing math." This reverts commit 3b424d3868be6534ca3dea426eb8411ee46176fc. And fixes issue with rouding causing arc errors
2021-01-18 17:39:13 +00:00
movingStart = true;
}
Overhaul arc internal model to not over-specify information.
2021-07-17 19:56:18 +00:00
else if( aEnd != aArc->GetEnd() )
Revert "Use less-sophisticated arc editing math." This reverts commit 3b424d3868be6534ca3dea426eb8411ee46176fc. And fixes issue with rouding causing arc errors
2021-01-18 17:39:13 +00:00
{
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
end = aCursor;
p1 = aStart;
p2 = aEnd;
p3 = aMid;
Revert "Use less-sophisticated arc editing math." This reverts commit 3b424d3868be6534ca3dea426eb8411ee46176fc. And fixes issue with rouding causing arc errors
2021-01-18 17:39:13 +00:00
movingStart = false;
}
Careful that we don't move the wrong end of the arc. Fixes https://gitlab.com/kicad/code/kicad/issues/7409
2021-02-03 23:50:46 +00:00
else
{
return;
}
Revert "Use less-sophisticated arc editing math." This reverts commit 3b424d3868be6534ca3dea426eb8411ee46176fc. And fixes issue with rouding causing arc errors
2021-01-18 17:39:13 +00:00
VECTOR2D v1, v2, v3, v4;
// Move the coordinate system
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
v1 = p1 - aCenter;
v2 = p2 - aCenter;
v3 = p3 - aCenter;
Revert "Use less-sophisticated arc editing math." This reverts commit 3b424d3868be6534ca3dea426eb8411ee46176fc. And fixes issue with rouding causing arc errors
2021-01-18 17:39:13 +00:00
VECTOR2D u1, u2, u3;
// A point cannot be both the center and on the arc.
if( ( v1.EuclideanNorm() == 0 ) || ( v2.EuclideanNorm() == 0 ) )
return;
u1 = v1 / v1.EuclideanNorm();
u2 = v3 - ( u1.x * v3.x + u1.y * v3.y ) * u1;
u2 = u2 / u2.EuclideanNorm();
// [ u1, u3 ] is a base centered on the circle with:
// u1 : unit vector toward the point that does not move
// u2 : unit vector toward the mid point.
// Get vectors v1, and v2 in that coordinate system.
double det = u1.x * u2.y - u2.x * u1.y;
// u1 and u2 are unit vectors, and perpendicular.
// det should not be 0. In case it is, do not change the arc.
if( det == 0 )
return;
double tmpx = v1.x * u2.y - v1.y * u2.x;
double tmpy = -v1.x * u1.y + v1.y * u1.x;
v1.x = tmpx;
v1.y = tmpy;
v1 = v1 / det;
tmpx = v2.x * u2.y - v2.y * u2.x;
tmpy = -v2.x * u1.y + v2.y * u1.x;
v2.x = tmpx;
v2.y = tmpy;
v2 = v2 / det;
double R = v1.EuclideanNorm();
bool transformCircle = false;
More NULL expunging.
2021-07-19 23:56:05 +00:00
/* p2
* X***
* ** <---- This is the arc
* y ^ **
* | R *
* | <-----------> *
* x------x------>--------x p1
* C' <----> C x
* delta
*
* p1 does not move, and the tangent at p1 remains the same.
* => The new center, C', will be on the C-p1 axis.
* p2 moves
*
* The radius of the new circle is delta + R
*
* || C' p2 || = || C' P1 ||
* is the same as :
* ( delta + p2.x ) ^ 2 + p2.y ^ 2 = ( R + delta ) ^ 2
*
* delta = ( R^2 - p2.x ^ 2 - p2.y ^2 ) / ( 2 * p2.x - 2 * R )
*
* We can use this equation for any point p2 with p2.x < R
*/
Revert "Use less-sophisticated arc editing math." This reverts commit 3b424d3868be6534ca3dea426eb8411ee46176fc. And fixes issue with rouding causing arc errors
2021-01-18 17:39:13 +00:00
if( v2.x == R )
{
// Straight line, do nothing
}
else
{
if( v2.x > R )
{
// If we need to invert the curvature.
// We modify the input so we can use the same equation
transformCircle = true;
v2.x = 2 * R - v2.x;
}
More NULL expunging.
2021-07-19 23:56:05 +00:00
Revert "Use less-sophisticated arc editing math." This reverts commit 3b424d3868be6534ca3dea426eb8411ee46176fc. And fixes issue with rouding causing arc errors
2021-01-18 17:39:13 +00:00
// We can keep the tangent constraint.
double delta = ( R * R - v2.x * v2.x - v2.y * v2.y ) / ( 2 * v2.x - 2 * R );
// This is just to limit the radius, so nothing overflows later when drawing.
if( abs( v2.y / ( R - v2.x ) ) > ADVANCED_CFG::GetCfg().m_DrawArcCenterMaxAngle )
arcValid = false;
More NULL expunging.
2021-07-19 23:56:05 +00:00
Revert "Use less-sophisticated arc editing math." This reverts commit 3b424d3868be6534ca3dea426eb8411ee46176fc. And fixes issue with rouding causing arc errors
2021-01-18 17:39:13 +00:00
// Never recorded a problem, but still checking.
if( !std::isfinite( delta ) )
arcValid = false;
More NULL expunging.
2021-07-19 23:56:05 +00:00
Revert "Use less-sophisticated arc editing math." This reverts commit 3b424d3868be6534ca3dea426eb8411ee46176fc. And fixes issue with rouding causing arc errors
2021-01-18 17:39:13 +00:00
// v4 is the new center
v4 = ( !transformCircle ) ? VECTOR2D( -delta, 0 ) : VECTOR2D( 2 * R + delta, 0 );
tmpx = v4.x * u1.x + v4.y * u2.x;
tmpy = v4.x * u1.y + v4.y * u2.y;
v4.x = tmpx;
v4.y = tmpy;
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
center = v4 + aCenter;
Revert "Use less-sophisticated arc editing math." This reverts commit 3b424d3868be6534ca3dea426eb8411ee46176fc. And fixes issue with rouding causing arc errors
2021-01-18 17:39:13 +00:00
if( arcValid )
{
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
aArc->SetCenter( center );
Revert "Use less-sophisticated arc editing math." This reverts commit 3b424d3868be6534ca3dea426eb8411ee46176fc. And fixes issue with rouding causing arc errors
2021-01-18 17:39:13 +00:00
if( movingStart )
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
aArc->SetStart( start );
Revert "Use less-sophisticated arc editing math." This reverts commit 3b424d3868be6534ca3dea426eb8411ee46176fc. And fixes issue with rouding causing arc errors
2021-01-18 17:39:13 +00:00
else
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
aArc->SetEnd( end );
Revert "Use less-sophisticated arc editing math." This reverts commit 3b424d3868be6534ca3dea426eb8411ee46176fc. And fixes issue with rouding causing arc errors
2021-01-18 17:39:13 +00:00
}
}
}
Don't allow point editor inversion when editing pad shapes. Fixes https://gitlab.com/kicad/code/kicad/issues/5272
2020-08-19 22:26:36 +00:00
/**
Pin dragged pad edges to hole (if it has one). Fixes https://gitlab.com/kicad/code/kicad/issues/5317
2020-08-22 19:27:17 +00:00
* Update the coordinates of 4 corners of a rectangle, according to pad constraints and the
* moved corner
* @param aTopLeft [in/out] is the RECT_TOPLEFT to constraint
* @param aTopRight [in/out] is the RECT_TOPRIGHT to constraint
* @param aBotLeft [in/out] is the RECT_BOTLEFT to constraint
* @param aBotRight [in/out] is the RECT_BOTRIGHT to constraint
* @param aHole the location of the pad's hole
* @param aHoleSize the pad's hole size (or {0,0} if it has no hole)
Don't allow point editor inversion when editing pad shapes. Fixes https://gitlab.com/kicad/code/kicad/issues/5272
2020-08-19 22:26:36 +00:00
*/
Run pinning on sides as well as corners. Also fixes a bug in LIB_SHAPE's Normalize() which wasn't handling the upside-down coordinate system. Fixes https://gitlab.com/kicad/code/kicad/issues/11339
2022-04-07 10:51:00 +00:00
void PCB_POINT_EDITOR::pinEditedCorner( VECTOR2I& aTopLeft, VECTOR2I& aTopRight,
VECTOR2I& aBotLeft, VECTOR2I& aBotRight,
const VECTOR2I& aHole, const VECTOR2I& aHoleSize ) const
Don't allow point editor inversion when editing pad shapes. Fixes https://gitlab.com/kicad/code/kicad/issues/5272
2020-08-19 22:26:36 +00:00
{
Run pinning on sides as well as corners. Also fixes a bug in LIB_SHAPE's Normalize() which wasn't handling the upside-down coordinate system. Fixes https://gitlab.com/kicad/code/kicad/issues/11339
2022-04-07 10:51:00 +00:00
int minWidth = Mils2iu( 1 );
int minHeight = Mils2iu( 1 );
if( isModified( m_editPoints->Point( RECT_TOP_LEFT ) ) )
Don't allow point editor inversion when editing pad shapes. Fixes https://gitlab.com/kicad/code/kicad/issues/5272
2020-08-19 22:26:36 +00:00
{
Pin dragged pad edges to hole (if it has one). Fixes https://gitlab.com/kicad/code/kicad/issues/5317
2020-08-22 19:27:17 +00:00
if( aHoleSize.x )
{
// pin edited point to the top/left of the hole
Run pinning on sides as well as corners. Also fixes a bug in LIB_SHAPE's Normalize() which wasn't handling the upside-down coordinate system. Fixes https://gitlab.com/kicad/code/kicad/issues/11339
2022-04-07 10:51:00 +00:00
aTopLeft.x = std::min( aTopLeft.x, aHole.x - aHoleSize.x / 2 - minWidth );
aTopLeft.y = std::min( aTopLeft.y, aHole.y - aHoleSize.y / 2 - minHeight );
Pin dragged pad edges to hole (if it has one). Fixes https://gitlab.com/kicad/code/kicad/issues/5317
2020-08-22 19:27:17 +00:00
}
else
Don't allow point editor inversion when editing pad shapes. Fixes https://gitlab.com/kicad/code/kicad/issues/5272
2020-08-19 22:26:36 +00:00
{
Pin dragged pad edges to hole (if it has one). Fixes https://gitlab.com/kicad/code/kicad/issues/5317
2020-08-22 19:27:17 +00:00
// pin edited point within opposite corner
Run pinning on sides as well as corners. Also fixes a bug in LIB_SHAPE's Normalize() which wasn't handling the upside-down coordinate system. Fixes https://gitlab.com/kicad/code/kicad/issues/11339
2022-04-07 10:51:00 +00:00
aTopLeft.x = std::min( aTopLeft.x, aBotRight.x - minWidth );
aTopLeft.y = std::min( aTopLeft.y, aBotRight.y - minHeight );
Don't allow point editor inversion when editing pad shapes. Fixes https://gitlab.com/kicad/code/kicad/issues/5272
2020-08-19 22:26:36 +00:00
}
// push edited point edges to adjacent corners
Pin dragged pad edges to hole (if it has one). Fixes https://gitlab.com/kicad/code/kicad/issues/5317
2020-08-22 19:27:17 +00:00
aTopRight.y = aTopLeft.y;
aBotLeft.x = aTopLeft.x;
Run pinning on sides as well as corners. Also fixes a bug in LIB_SHAPE's Normalize() which wasn't handling the upside-down coordinate system. Fixes https://gitlab.com/kicad/code/kicad/issues/11339
2022-04-07 10:51:00 +00:00
}
else if( isModified( m_editPoints->Point( RECT_TOP_RIGHT ) ) )
{
Pin dragged pad edges to hole (if it has one). Fixes https://gitlab.com/kicad/code/kicad/issues/5317
2020-08-22 19:27:17 +00:00
if( aHoleSize.x )
{
// pin edited point to the top/right of the hole
Run pinning on sides as well as corners. Also fixes a bug in LIB_SHAPE's Normalize() which wasn't handling the upside-down coordinate system. Fixes https://gitlab.com/kicad/code/kicad/issues/11339
2022-04-07 10:51:00 +00:00
aTopRight.x = std::max( aTopRight.x, aHole.x + aHoleSize.x / 2 + minWidth );
aTopRight.y = std::min( aTopRight.y, aHole.y - aHoleSize.y / 2 - minHeight );
Pin dragged pad edges to hole (if it has one). Fixes https://gitlab.com/kicad/code/kicad/issues/5317
2020-08-22 19:27:17 +00:00
}
else
Don't allow point editor inversion when editing pad shapes. Fixes https://gitlab.com/kicad/code/kicad/issues/5272
2020-08-19 22:26:36 +00:00
{
Pin dragged pad edges to hole (if it has one). Fixes https://gitlab.com/kicad/code/kicad/issues/5317
2020-08-22 19:27:17 +00:00
// pin edited point within opposite corner
Run pinning on sides as well as corners. Also fixes a bug in LIB_SHAPE's Normalize() which wasn't handling the upside-down coordinate system. Fixes https://gitlab.com/kicad/code/kicad/issues/11339
2022-04-07 10:51:00 +00:00
aTopRight.x = std::max( aTopRight.x, aBotLeft.x + minWidth );
aTopRight.y = std::min( aTopRight.y, aBotLeft.y - minHeight );
Don't allow point editor inversion when editing pad shapes. Fixes https://gitlab.com/kicad/code/kicad/issues/5272
2020-08-19 22:26:36 +00:00
}
// push edited point edges to adjacent corners
Pin dragged pad edges to hole (if it has one). Fixes https://gitlab.com/kicad/code/kicad/issues/5317
2020-08-22 19:27:17 +00:00
aTopLeft.y = aTopRight.y;
aBotRight.x = aTopRight.x;
Run pinning on sides as well as corners. Also fixes a bug in LIB_SHAPE's Normalize() which wasn't handling the upside-down coordinate system. Fixes https://gitlab.com/kicad/code/kicad/issues/11339
2022-04-07 10:51:00 +00:00
}
else if( isModified( m_editPoints->Point( RECT_BOT_LEFT ) ) )
{
Pin dragged pad edges to hole (if it has one). Fixes https://gitlab.com/kicad/code/kicad/issues/5317
2020-08-22 19:27:17 +00:00
if( aHoleSize.x )
{
// pin edited point to the bottom/left of the hole
Run pinning on sides as well as corners. Also fixes a bug in LIB_SHAPE's Normalize() which wasn't handling the upside-down coordinate system. Fixes https://gitlab.com/kicad/code/kicad/issues/11339
2022-04-07 10:51:00 +00:00
aBotLeft.x = std::min( aBotLeft.x, aHole.x - aHoleSize.x / 2 - minWidth );
aBotLeft.y = std::max( aBotLeft.y, aHole.y + aHoleSize.y / 2 + minHeight );
Pin dragged pad edges to hole (if it has one). Fixes https://gitlab.com/kicad/code/kicad/issues/5317
2020-08-22 19:27:17 +00:00
}
else
Don't allow point editor inversion when editing pad shapes. Fixes https://gitlab.com/kicad/code/kicad/issues/5272
2020-08-19 22:26:36 +00:00
{
Pin dragged pad edges to hole (if it has one). Fixes https://gitlab.com/kicad/code/kicad/issues/5317
2020-08-22 19:27:17 +00:00
// pin edited point within opposite corner
Run pinning on sides as well as corners. Also fixes a bug in LIB_SHAPE's Normalize() which wasn't handling the upside-down coordinate system. Fixes https://gitlab.com/kicad/code/kicad/issues/11339
2022-04-07 10:51:00 +00:00
aBotLeft.x = std::min( aBotLeft.x, aTopRight.x - minWidth );
aBotLeft.y = std::max( aBotLeft.y, aTopRight.y + minHeight );
Don't allow point editor inversion when editing pad shapes. Fixes https://gitlab.com/kicad/code/kicad/issues/5272
2020-08-19 22:26:36 +00:00
}
// push edited point edges to adjacent corners
Pin dragged pad edges to hole (if it has one). Fixes https://gitlab.com/kicad/code/kicad/issues/5317
2020-08-22 19:27:17 +00:00
aBotRight.y = aBotLeft.y;
aTopLeft.x = aBotLeft.x;
Run pinning on sides as well as corners. Also fixes a bug in LIB_SHAPE's Normalize() which wasn't handling the upside-down coordinate system. Fixes https://gitlab.com/kicad/code/kicad/issues/11339
2022-04-07 10:51:00 +00:00
}
else if( isModified( m_editPoints->Point( RECT_BOT_RIGHT ) ) )
{
Pin dragged pad edges to hole (if it has one). Fixes https://gitlab.com/kicad/code/kicad/issues/5317
2020-08-22 19:27:17 +00:00
if( aHoleSize.x )
{
// pin edited point to the bottom/right of the hole
Run pinning on sides as well as corners. Also fixes a bug in LIB_SHAPE's Normalize() which wasn't handling the upside-down coordinate system. Fixes https://gitlab.com/kicad/code/kicad/issues/11339
2022-04-07 10:51:00 +00:00
aBotRight.x = std::max( aBotRight.x, aHole.x + aHoleSize.x / 2 + minWidth );
aBotRight.y = std::max( aBotRight.y, aHole.y + aHoleSize.y / 2 + minHeight );
Pin dragged pad edges to hole (if it has one). Fixes https://gitlab.com/kicad/code/kicad/issues/5317
2020-08-22 19:27:17 +00:00
}
else
Don't allow point editor inversion when editing pad shapes. Fixes https://gitlab.com/kicad/code/kicad/issues/5272
2020-08-19 22:26:36 +00:00
{
Pin dragged pad edges to hole (if it has one). Fixes https://gitlab.com/kicad/code/kicad/issues/5317
2020-08-22 19:27:17 +00:00
// pin edited point within opposite corner
Run pinning on sides as well as corners. Also fixes a bug in LIB_SHAPE's Normalize() which wasn't handling the upside-down coordinate system. Fixes https://gitlab.com/kicad/code/kicad/issues/11339
2022-04-07 10:51:00 +00:00
aBotRight.x = std::max( aBotRight.x, aTopLeft.x + minWidth );
aBotRight.y = std::max( aBotRight.y, aTopLeft.y + minHeight );
Don't allow point editor inversion when editing pad shapes. Fixes https://gitlab.com/kicad/code/kicad/issues/5272
2020-08-19 22:26:36 +00:00
}
// push edited point edges to adjacent corners
Pin dragged pad edges to hole (if it has one). Fixes https://gitlab.com/kicad/code/kicad/issues/5317
2020-08-22 19:27:17 +00:00
aBotLeft.y = aBotRight.y;
aTopRight.x = aBotRight.x;
Run pinning on sides as well as corners. Also fixes a bug in LIB_SHAPE's Normalize() which wasn't handling the upside-down coordinate system. Fixes https://gitlab.com/kicad/code/kicad/issues/11339
2022-04-07 10:51:00 +00:00
}
else if( isModified( m_editPoints->Line( RECT_TOP ) ) )
{
aTopLeft.y = std::min( aTopLeft.y, aBotRight.y - minHeight );
}
else if( isModified( m_editPoints->Line( RECT_LEFT ) ) )
{
aTopLeft.x = std::min( aTopLeft.x, aBotRight.x - minWidth );
}
else if( isModified( m_editPoints->Line( RECT_BOT ) ) )
{
aBotRight.y = std::max( aBotRight.y, aTopLeft.y + minHeight );
}
else if( isModified( m_editPoints->Line( RECT_RIGHT ) ) )
{
aBotRight.x = std::max( aBotRight.x, aTopLeft.x + minWidth );
Don't allow point editor inversion when editing pad shapes. Fixes https://gitlab.com/kicad/code/kicad/issues/5272
2020-08-19 22:26:36 +00:00
}
}
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
void PCB_POINT_EDITOR::editArcEndpointKeepCenter( PCB_SHAPE* aArc, const VECTOR2I& aCenter,
const VECTOR2I& aStart, const VECTOR2I& aMid,
const VECTOR2I& aEnd,
const VECTOR2I& aCursor ) const
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
{
bool movingStart;
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
VECTOR2I p1, p2;
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
VECTOR2I target;
// p1 does not move, p2 does.
Overhaul arc internal model to not over-specify information.
2021-07-17 19:56:18 +00:00
if( aStart != aArc->GetStart() )
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
{
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
p1 = aEnd;
p2 = aStart;
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
movingStart = true;
}
else
{
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
p1 = aStart;
p2 = aEnd;
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
movingStart = false;
}
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
target = p2 - aCenter;
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
double sqRadius = ( p1 - aCenter ).SquaredEuclideanNorm();
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
p1 = p1 - aCenter;
p2 = p2 - aCenter;
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
// Circle : x^2 + y^2 = R ^ 2
// In this coordinate system, the angular position of the cursor is (r, theta)
// The line coming from the center of the circle is y = start.y / start.x * x
// The intersection fulfills : x^2 = R^2 / ( 1 + ( start.y / start.x ) ^ 2 )
if( target.x == 0 )
{
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
p2.x = 0;
p2.y = ( target.y > 0 ) ? sqrt( sqRadius ) : -sqrt( sqRadius );
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
}
else
{
double tan = target.y / static_cast<double>( target.x );
More NULL expunging.
2021-07-19 23:56:05 +00:00
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
// The divider is always greater than 1 ( cannot be 0 )
double tmp = sqrt( sqRadius / ( 1.0 + tan * tan ) );
More NULL expunging.
2021-07-19 23:56:05 +00:00
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
// Move to the correct quadrant
tmp = target.x > 0 ? tmp : -tmp;
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
p2.y = target.y / static_cast<double>( target.x ) * tmp;
p2.x = tmp;
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
}
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
p1 = p1 + aCenter;
p2 = p2 + aCenter;
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
aArc->SetCenter( aCenter );
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
if( movingStart )
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
aArc->SetStart( aStart );
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
else
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
aArc->SetEnd( aEnd );
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
}
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
void PCB_POINT_EDITOR::editArcMidKeepCenter( PCB_SHAPE* aArc, const VECTOR2I& aCenter,
const VECTOR2I& aStart, const VECTOR2I& aMid,
const VECTOR2I& aEnd, const VECTOR2I& aCursor ) const
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
{
// Now, update the edit point position
More NULL expunging.
2021-07-19 23:56:05 +00:00
// Express the point in a circle-centered coordinate system.
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
VECTOR2I start = aStart - aCenter;
VECTOR2I end = aEnd - aCenter;
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
double sqRadius = ( aCursor - aCenter ).SquaredEuclideanNorm();
// Special case, because the tangent would lead to +/- infinity
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
if( start.x == 0 )
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
{
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
start.y = aCursor.y > 0 ? sqrt( sqRadius ) : -sqrt( sqRadius );
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
}
else
{
// Circle : x^2 + y^2 = R ^ 2
// In this coordinate system, the angular position of the cursor is (r, theta)
// The line coming from the center of the circle is y = start.y / start.x * x
// The intersection fulfills : x^2 = R^2 / ( 1 + ( start.y / start.x ) ^ 2 )
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
double tan = aStart.y / static_cast<double>( start.x );
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
double tmp = sqrt( sqRadius / ( 1.0 + tan * tan ) );
More NULL expunging.
2021-07-19 23:56:05 +00:00
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
// Move to the correct quadrant
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
tmp = start.x > 0 ? tmp : -tmp;
start.y = start.y / static_cast<double>( start.x ) * tmp;
start.x = tmp;
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
}
// Special case, because the tangent would lead to +/- infinity
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
if( end.x == 0 )
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
{
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
end.y = aMid.y > 0 ? sqrt( sqRadius ) : -sqrt( sqRadius );
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
}
else
{
// Circle : x^2 + y^2 = R ^ 2
// In this coordinate system, the angular position of the cursor is (r, theta)
// The line coming from the center of the circle is y = start.y / start.x * x
// The intersection fulfills : x^2 = R^2 / ( 1 + ( start.y / start.x ) ^ 2 )
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
double tan = end.y / static_cast<double>( end.x );
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
double tmp = sqrt( sqRadius / ( 1.0 + tan * tan ) );
More NULL expunging.
2021-07-19 23:56:05 +00:00
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
// Move to the correct quadrant
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
tmp = end.x > 0 ? tmp : -tmp;
end.y = end.y / static_cast<double>( end.x ) * tmp;
end.x = tmp;
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
}
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
start = start + aCenter;
end = end + aCenter;
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
aArc->SetStart( start );
aArc->SetEnd( end );
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
}
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
void PCB_POINT_EDITOR::editArcMidKeepEndpoints( PCB_SHAPE* aArc, const VECTOR2I& aStart,
const VECTOR2I& aEnd,
const VECTOR2I& aCursor ) const
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
{
Go back to previous arc midpoint editing routine. It avoids erratic behaviour near the chord or end-points. Fixes https://gitlab.com/kicad/code/kicad/issues/7135
2021-01-19 23:07:31 +00:00
// Let 'm' be the middle point of the chord between the start and end points
VECTOR2I m = ( aStart + aEnd ) / 2;
Revert "Use less-sophisticated arc editing math." This reverts commit 3b424d3868be6534ca3dea426eb8411ee46176fc. And fixes issue with rouding causing arc errors
2021-01-18 17:39:13 +00:00
Go back to previous arc midpoint editing routine. It avoids erratic behaviour near the chord or end-points. Fixes https://gitlab.com/kicad/code/kicad/issues/7135
2021-01-19 23:07:31 +00:00
// Legal midpoints lie on a vector starting just off the chord midpoint and extending out
// past the existing midpoint. We do not allow arc inflection while point editing.
const int JUST_OFF = ( aStart - aEnd ).EuclideanNorm() / 100;
VECTOR2I v = (VECTOR2I) aArc->GetArcMid() - m;
SEG legal( m + v.Resize( JUST_OFF ), m + v.Resize( INT_MAX / 2 ) );
VECTOR2I mid = legal.NearestPoint( aCursor );
Revert "Use less-sophisticated arc editing math." This reverts commit 3b424d3868be6534ca3dea426eb8411ee46176fc. And fixes issue with rouding causing arc errors
2021-01-18 17:39:13 +00:00
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
aArc->SetArcGeometry( aStart, mid, aEnd );
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
}
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
void PCB_POINT_EDITOR::updateItem() const
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
{
Added TOOL_ACTION for updating EDIT_POINTS. EDIT_POINTs show up when there is only one item selected (now after deselection as well).
2014-02-28 15:53:28 +00:00
EDA_ITEM* item = m_editPoints->GetParent();
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
More data validity checks in POINT_EDITOR Fixes: lp:1690658 * https://bugs.launchpad.net/kicad/+bug/1690658
2017-05-16 09:38:00 +00:00
if( !item )
return;
Added TOOL_ACTION for updating EDIT_POINTS. EDIT_POINTs show up when there is only one item selected (now after deselection as well).
2014-02-28 15:53:28 +00:00
switch( item->Type() )
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
{
PCB Editor: Add User Background Images
2022-02-08 19:29:54 +00:00
case PCB_BITMAP_T:
{
PCB_BITMAP* bitmap = (PCB_BITMAP*) item;
VECTOR2I topLeft = m_editPoints->Point( RECT_TOP_LEFT ).GetPosition();
VECTOR2I topRight = m_editPoints->Point( RECT_TOP_RIGHT ).GetPosition();
VECTOR2I botLeft = m_editPoints->Point( RECT_BOT_LEFT ).GetPosition();
VECTOR2I botRight = m_editPoints->Point( RECT_BOT_RIGHT ).GetPosition();
pinEditedCorner( topLeft, topRight, botLeft, botRight );
double oldWidth = bitmap->GetSize().x;
double newWidth = std::max( topRight.x - topLeft.x, Mils2iu( 50 ) );
double widthRatio = newWidth / oldWidth;
double oldHeight = bitmap->GetSize().y;
double newHeight = std::max( botLeft.y - topLeft.y, Mils2iu( 50 ) );
double heightRatio = newHeight / oldHeight;
bitmap->SetImageScale( bitmap->GetImageScale() * std::min( widthRatio, heightRatio ) );
break;
}
TextBoxes for PCBNew.
2022-01-30 10:52:52 +00:00
case PCB_TEXTBOX_T:
case PCB_FP_TEXTBOX_T:
PCB_LINE_T -> PCB_SHAPE_T and PCB_MODULE_EDGE_T -> PCB_FP_SHAPE_T Also updated footprint text and zone types for consistencey.
2020-10-04 14:19:33 +00:00
case PCB_SHAPE_T:
case PCB_FP_SHAPE_T:
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
{
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
PCB_SHAPE* shape = static_cast<PCB_SHAPE*>( item );
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
switch( shape->GetShape() )
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
{
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
case SHAPE_T::SEGMENT:
Refactoring EDIT_POINTS, part 2: replaced index numbers with constants.
2014-04-01 15:41:24 +00:00
if( isModified( m_editPoints->Point( SEG_START ) ) )
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
shape->SetStart( m_editPoints->Point( SEG_START ).GetPosition() );
Refactoring EDIT_POINTS, part 2: replaced index numbers with constants.
2014-04-01 15:41:24 +00:00
else if( isModified( m_editPoints->Point( SEG_END ) ) )
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
shape->SetEnd( m_editPoints->Point( SEG_END ).GetPosition() );
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
break;
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
case SHAPE_T::RECT:
Finish implementation of DRAWSEGMENT::C_RECT. It's currently only supported in the Footprint Editor. It could be easily added to the board editor (all the code is there), but the board editor is a little short on room in the drawing tools toolbar.
2020-06-15 19:50:20 +00:00
{
Run pinning on sides as well as corners. Also fixes a bug in LIB_SHAPE's Normalize() which wasn't handling the upside-down coordinate system. Fixes https://gitlab.com/kicad/code/kicad/issues/11339
2022-04-07 10:51:00 +00:00
VECTOR2I topLeft = m_editPoints->Point( RECT_TOP_LEFT ).GetPosition();
VECTOR2I topRight = m_editPoints->Point( RECT_TOP_RIGHT ).GetPosition();
VECTOR2I botLeft = m_editPoints->Point( RECT_BOT_LEFT ).GetPosition();
VECTOR2I botRight = m_editPoints->Point( RECT_BOT_RIGHT ).GetPosition();
pinEditedCorner( topLeft, topRight, botLeft, botRight );
if( isModified( m_editPoints->Point( RECT_TOP_LEFT ) )
|| isModified( m_editPoints->Point( RECT_TOP_RIGHT ) )
|| isModified( m_editPoints->Point( RECT_BOT_RIGHT ) )
|| isModified( m_editPoints->Point( RECT_BOT_LEFT ) ) )
Finish implementation of DRAWSEGMENT::C_RECT. It's currently only supported in the Footprint Editor. It could be easily added to the board editor (all the code is there), but the board editor is a little short on room in the drawing tools toolbar.
2020-06-15 19:50:20 +00:00
{
Repair point editing of rotated text boxes. Fixes https://gitlab.com/kicad/code/kicad/issues/11432
2022-06-02 09:42:13 +00:00
shape->SetLeft( topLeft.x );
shape->SetTop( topLeft.y );
shape->SetRight( botRight.x );
shape->SetBottom( botRight.y );
Finish implementation of DRAWSEGMENT::C_RECT. It's currently only supported in the Footprint Editor. It could be easily added to the board editor (all the code is there), but the board editor is a little short on room in the drawing tools toolbar.
2020-06-15 19:50:20 +00:00
}
Add center handles to rectangle edits Allows changing a single dimension at a time. Matching the polygon edit tool. Fixes https://gitlab.com/kicad/code/kicad/issues/7085
2021-01-13 22:03:31 +00:00
else if( isModified( m_editPoints->Line( RECT_TOP ) ) )
{
Repair point editing of rotated text boxes. Fixes https://gitlab.com/kicad/code/kicad/issues/11432
2022-06-02 09:42:13 +00:00
shape->SetTop( topLeft.y );
Add center handles to rectangle edits Allows changing a single dimension at a time. Matching the polygon edit tool. Fixes https://gitlab.com/kicad/code/kicad/issues/7085
2021-01-13 22:03:31 +00:00
}
else if( isModified( m_editPoints->Line( RECT_LEFT ) ) )
{
Repair point editing of rotated text boxes. Fixes https://gitlab.com/kicad/code/kicad/issues/11432
2022-06-02 09:42:13 +00:00
shape->SetLeft( topLeft.x );
Add center handles to rectangle edits Allows changing a single dimension at a time. Matching the polygon edit tool. Fixes https://gitlab.com/kicad/code/kicad/issues/7085
2021-01-13 22:03:31 +00:00
}
else if( isModified( m_editPoints->Line( RECT_BOT ) ) )
{
Repair point editing of rotated text boxes. Fixes https://gitlab.com/kicad/code/kicad/issues/11432
2022-06-02 09:42:13 +00:00
shape->SetBottom( botRight.y );
Add center handles to rectangle edits Allows changing a single dimension at a time. Matching the polygon edit tool. Fixes https://gitlab.com/kicad/code/kicad/issues/7085
2021-01-13 22:03:31 +00:00
}
else if( isModified( m_editPoints->Line( RECT_RIGHT ) ) )
{
Repair point editing of rotated text boxes. Fixes https://gitlab.com/kicad/code/kicad/issues/11432
2022-06-02 09:42:13 +00:00
shape->SetRight( botRight.x );
Add center handles to rectangle edits Allows changing a single dimension at a time. Matching the polygon edit tool. Fixes https://gitlab.com/kicad/code/kicad/issues/7085
2021-01-13 22:03:31 +00:00
}
for( unsigned i = 0; i < m_editPoints->LinesSize(); ++i )
{
if( !isModified( m_editPoints->Line( i ) ) )
TextBoxes for PCBNew.
2022-01-30 10:52:52 +00:00
{
More NULL expunging.
2021-07-19 23:56:05 +00:00
m_editPoints->Line( i ).SetConstraint(
new EC_PERPLINE( m_editPoints->Line( i ) ) );
TextBoxes for PCBNew.
2022-01-30 10:52:52 +00:00
}
Add center handles to rectangle edits Allows changing a single dimension at a time. Matching the polygon edit tool. Fixes https://gitlab.com/kicad/code/kicad/issues/7085
2021-01-13 22:03:31 +00:00
}
TextBoxes for PCBNew.
2022-01-30 10:52:52 +00:00
Finish implementation of DRAWSEGMENT::C_RECT. It's currently only supported in the Footprint Editor. It could be easily added to the board editor (all the code is there), but the board editor is a little short on room in the drawing tools toolbar.
2020-06-15 19:50:20 +00:00
break;
TextBoxes for PCBNew.
2022-01-30 10:52:52 +00:00
}
Finish implementation of DRAWSEGMENT::C_RECT. It's currently only supported in the Footprint Editor. It could be easily added to the board editor (all the code is there), but the board editor is a little short on room in the drawing tools toolbar.
2020-06-15 19:50:20 +00:00
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
case SHAPE_T::ARC:
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
{
pcbnew: Allow arc editing via midpoint This permits changing the radius of the arc by adjusting the center point of the arc. The arc end points are fixed in this operation.
2018-12-08 15:26:47 +00:00
VECTOR2I center = m_editPoints->Point( ARC_CENTER ).GetPosition();
VECTOR2I mid = m_editPoints->Point( ARC_MID ).GetPosition();
VECTOR2I start = m_editPoints->Point( ARC_START ).GetPosition();
VECTOR2I end = m_editPoints->Point( ARC_END ).GetPosition();
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
if( isModified( m_editPoints->Point( ARC_CENTER ) ) )
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
{
Neurotically update position wxPoint usages
2022-01-01 06:04:08 +00:00
VECTOR2I moveVector = VECTOR2I( center.x, center.y ) - shape->GetCenter();
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
shape->Move( moveVector );
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
}
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
else if( isModified( m_editPoints->Point( ARC_MID ) ) )
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
{
Fix fly-off arc handles and move Arc Properties to start/end/angle. Fixes https://gitlab.com/kicad/code/kicad/issues/5791
2020-10-08 09:59:17 +00:00
const VECTOR2I& cursorPos = getViewControls()->GetCursorPosition( false );
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
if( m_altEditMethod )
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
editArcMidKeepCenter( shape, center, start, mid, end, cursorPos );
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
else
Go back to previous arc midpoint editing routine. It avoids erratic behaviour near the chord or end-points. Fixes https://gitlab.com/kicad/code/kicad/issues/7135
2021-01-19 23:07:31 +00:00
editArcMidKeepEndpoints( shape, start, end, cursorPos );
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
}
else if( isModified( m_editPoints->Point( ARC_START ) )
|| isModified( m_editPoints->Point( ARC_END ) ) )
{
Fix fly-off arc handles and move Arc Properties to start/end/angle. Fixes https://gitlab.com/kicad/code/kicad/issues/5791
2020-10-08 09:59:17 +00:00
const VECTOR2I& cursorPos = getViewControls()->GetCursorPosition();
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
if( m_altEditMethod )
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
editArcEndpointKeepCenter( shape, center, start, mid, end, cursorPos );
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
else
Revert "Use less-sophisticated arc editing math." This reverts commit 3b424d3868be6534ca3dea426eb8411ee46176fc. And fixes issue with rouding causing arc errors
2021-01-18 17:39:13 +00:00
editArcEndpointKeepTangent( shape, center, start, mid, end, cursorPos );
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
}
TextBoxes for PCBNew.
2022-01-30 10:52:52 +00:00
Finish implementation of DRAWSEGMENT::C_RECT. It's currently only supported in the Footprint Editor. It could be easily added to the board editor (all the code is there), but the board editor is a little short on room in the drawing tools toolbar.
2020-06-15 19:50:20 +00:00
break;
TextBoxes for PCBNew.
2022-01-30 10:52:52 +00:00
}
Circles are supported by POINT_EDITOR.
2014-02-28 17:24:13 +00:00
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
case SHAPE_T::CIRCLE:
Circles are supported by POINT_EDITOR.
2014-02-28 17:24:13 +00:00
{
Refactoring EDIT_POINTS, part 2: replaced index numbers with constants.
2014-04-01 15:41:24 +00:00
const VECTOR2I& center = m_editPoints->Point( CIRC_CENTER ).GetPosition();
const VECTOR2I& end = m_editPoints->Point( CIRC_END ).GetPosition();
Circles are supported by POINT_EDITOR.
2014-02-28 17:24:13 +00:00
Refactoring EDIT_POINTS, part 2: replaced index numbers with constants.
2014-04-01 15:41:24 +00:00
if( isModified( m_editPoints->Point( CIRC_CENTER ) ) )
Circles are supported by POINT_EDITOR.
2014-02-28 17:24:13 +00:00
{
Neurotically update position wxPoint usages
2022-01-01 06:04:08 +00:00
VECTOR2I moveVector = VECTOR2I( center.x, center.y ) - shape->GetCenter();
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
shape->Move( moveVector );
Circles are supported by POINT_EDITOR.
2014-02-28 17:24:13 +00:00
}
else
{
Neurotically update position wxPoint usages
2022-01-01 06:04:08 +00:00
shape->SetEnd( VECTOR2I( end.x, end.y ) );
Circles are supported by POINT_EDITOR.
2014-02-28 17:24:13 +00:00
}
TextBoxes for PCBNew.
2022-01-30 10:52:52 +00:00
Finish implementation of DRAWSEGMENT::C_RECT. It's currently only supported in the Footprint Editor. It could be easily added to the board editor (all the code is there), but the board editor is a little short on room in the drawing tools toolbar.
2020-06-15 19:50:20 +00:00
break;
TextBoxes for PCBNew.
2022-01-30 10:52:52 +00:00
}
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
case SHAPE_T::POLY:
pcbnew: added graphical polygon drawing & editing tools
2017-10-19 21:14:01 +00:00
{
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
SHAPE_POLY_SET& outline = shape->GetPolyShape();
pcbnew: added graphical polygon drawing & editing tools
2017-10-19 21:14:01 +00:00
Point Editor: prevent creation of self-intersecting polygons
2018-02-22 11:28:01 +00:00
for( int i = 0; i < outline.TotalVertices(); ++i )
SHAPE_LINE_CHAIN: Remove element access This is the first step to allowing non-segments in the line chain. External routines cannot be allowed to change the line chain without going through the internal routines. To accomplish this, we remove the Vertex() and Point() access routines and only leave the const versions. Transformations are given for both points as well as the chain itself.
2019-03-23 18:26:44 +00:00
outline.SetVertex( i, m_editPoints->Point( i ).GetPosition() );
Point Editor: prevent creation of self-intersecting polygons
2018-02-22 11:28:01 +00:00
ADDED: Improved center point dragging The center point on polygons now maintains the axis of the dragged line and, optionally with Ctrl pressed, maintains the slope of the adjacent segments as well. This also fixes a longstanding issue that prevented the ctrl-snapping from using the original point rather than the last updated point when constraining. Fixes https://gitlab.com/kicad/code/kicad/issues/2465
2020-08-27 17:31:53 +00:00
for( unsigned i = 0; i < m_editPoints->LinesSize(); ++i )
{
if( !isModified( m_editPoints->Line( i ) ) )
More NULL expunging.
2021-07-19 23:56:05 +00:00
m_editPoints->Line( i ).SetConstraint(
new EC_PERPLINE( m_editPoints->Line( i ) ) );
ADDED: Improved center point dragging The center point on polygons now maintains the axis of the dragged line and, optionally with Ctrl pressed, maintains the slope of the adjacent segments as well. This also fixes a longstanding issue that prevented the ctrl-snapping from using the original point rather than the last updated point when constraining. Fixes https://gitlab.com/kicad/code/kicad/issues/2465
2020-08-27 17:31:53 +00:00
}
Allow drawing self-intersecting polygons, just display a warning Fixes: lp:1751654 * https://bugs.launchpad.net/kicad/+bug/1751654
2018-03-02 09:55:59 +00:00
validatePolygon( outline );
Finish implementation of DRAWSEGMENT::C_RECT. It's currently only supported in the Footprint Editor. It could be easily added to the board editor (all the code is there), but the board editor is a little short on room in the drawing tools toolbar.
2020-06-15 19:50:20 +00:00
break;
TextBoxes for PCBNew.
2022-01-30 10:52:52 +00:00
}
pcbnew: added graphical polygon drawing & editing tools
2017-10-19 21:14:01 +00:00
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
case SHAPE_T::BEZIER:
Add Bezier curve (S_CURVE shape) support in DIALOG_GRAPHIC_ITEM_PROPERTIES. Fix some issues related to S_CURVE shape support.
2018-07-22 12:50:35 +00:00
if( isModified( m_editPoints->Point( BEZIER_CURVE_START ) ) )
Formatting.
2022-06-01 22:55:59 +00:00
shape->SetStart( m_editPoints->Point( BEZIER_CURVE_START ).GetPosition() );
Add Bezier curve (S_CURVE shape) support in DIALOG_GRAPHIC_ITEM_PROPERTIES. Fix some issues related to S_CURVE shape support.
2018-07-22 12:50:35 +00:00
else if( isModified( m_editPoints->Point( BEZIER_CURVE_CONTROL_POINT1 ) ) )
Formatting.
2022-06-01 22:55:59 +00:00
shape->SetBezierC1( m_editPoints->Point( BEZIER_CURVE_CONTROL_POINT1 ).GetPosition() );
Add Bezier curve (S_CURVE shape) support in DIALOG_GRAPHIC_ITEM_PROPERTIES. Fix some issues related to S_CURVE shape support.
2018-07-22 12:50:35 +00:00
else if( isModified( m_editPoints->Point( BEZIER_CURVE_CONTROL_POINT2 ) ) )
Formatting.
2022-06-01 22:55:59 +00:00
shape->SetBezierC2( m_editPoints->Point( BEZIER_CURVE_CONTROL_POINT2 ).GetPosition() );
Add Bezier curve (S_CURVE shape) support in DIALOG_GRAPHIC_ITEM_PROPERTIES. Fix some issues related to S_CURVE shape support.
2018-07-22 12:50:35 +00:00
else if( isModified( m_editPoints->Point( BEZIER_CURVE_END ) ) )
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
shape->SetEnd( m_editPoints->Point( BEZIER_CURVE_END ).GetPosition() );
Add Bezier curve (S_CURVE shape) support in DIALOG_GRAPHIC_ITEM_PROPERTIES. Fix some issues related to S_CURVE shape support.
2018-07-22 12:50:35 +00:00
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
shape->RebuildBezierToSegmentsPointsList( shape->GetWidth() );
Add Bezier curve (S_CURVE shape) support in DIALOG_GRAPHIC_ITEM_PROPERTIES. Fix some issues related to S_CURVE shape support.
2018-07-22 12:50:35 +00:00
break;
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
default: // suppress warnings
break;
}
Zones are supported by POINT_EDITOR.
2014-02-28 17:24:29 +00:00
Finish module cleanup (except for xpms).
2020-11-14 22:00:12 +00:00
// Update relative coordinates for footprint shapes
Dirty text caches in pcb point editor. Fixes https://gitlab.com/kicad/code/kicad/issues/11319
2022-04-04 16:39:33 +00:00
if( FP_SHAPE* fpShape = dynamic_cast<FP_SHAPE*>( item ) )
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
fpShape->SetLocalCoord();
Updated POINT_EDITOR to handle module edges.
2014-07-09 11:50:27 +00:00
Dirty text caches in pcb point editor. Fixes https://gitlab.com/kicad/code/kicad/issues/11319
2022-04-04 16:39:33 +00:00
// Nuke outline font render caches
if( PCB_TEXTBOX* textBox = dynamic_cast<PCB_TEXTBOX*>( item ) )
textBox->ClearRenderCache();
else if( FP_TEXTBOX* fpTextBox = dynamic_cast<FP_TEXTBOX*>( item ) )
fpTextBox->ClearRenderCache();
Zones are supported by POINT_EDITOR.
2014-02-28 17:24:29 +00:00
break;
}
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
case PCB_PAD_T:
{
D_PAD -> PAD.
2020-11-12 22:30:02 +00:00
PAD* pad = static_cast<PAD*>( item );
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
switch( pad->GetShape() )
{
enum class PAD_SHAPE_T
2021-05-01 12:22:35 +00:00
case PAD_SHAPE::CIRCLE:
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
{
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
VECTOR2I end = m_editPoints->Point( 0 ).GetPosition();
Formatting.
2022-06-01 22:55:59 +00:00
int diameter = (int) EuclideanNorm( end - pad->GetPosition() ) * 2;
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
Don't allow offset for circular pads. Fixes https://gitlab.com/kicad/code/kicad/issues/9266
2021-09-29 12:53:54 +00:00
pad->SetSize( wxSize( diameter, diameter ) );
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
break;
TextBoxes for PCBNew.
2022-01-30 10:52:52 +00:00
}
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
enum class PAD_SHAPE_T
2021-05-01 12:22:35 +00:00
case PAD_SHAPE::OVAL:
case PAD_SHAPE::TRAPEZOID:
case PAD_SHAPE::RECT:
case PAD_SHAPE::ROUNDRECT:
case PAD_SHAPE::CHAMFERED_RECT:
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
{
Don't allow point editor inversion when editing pad shapes. Fixes https://gitlab.com/kicad/code/kicad/issues/5272
2020-08-19 22:26:36 +00:00
VECTOR2I topLeft = m_editPoints->Point( RECT_TOP_LEFT ).GetPosition();
VECTOR2I topRight = m_editPoints->Point( RECT_TOP_RIGHT ).GetPosition();
VECTOR2I botLeft = m_editPoints->Point( RECT_BOT_LEFT ).GetPosition();
VECTOR2I botRight = m_editPoints->Point( RECT_BOT_RIGHT ).GetPosition();
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
VECTOR2I holeCenter = pad->GetPosition();
VECTOR2I holeSize = pad->GetDrillSize();
Don't allow point editor inversion when editing pad shapes. Fixes https://gitlab.com/kicad/code/kicad/issues/5272
2020-08-19 22:26:36 +00:00
Run pinning on sides as well as corners. Also fixes a bug in LIB_SHAPE's Normalize() which wasn't handling the upside-down coordinate system. Fixes https://gitlab.com/kicad/code/kicad/issues/11339
2022-04-07 10:51:00 +00:00
pinEditedCorner( topLeft, topRight, botLeft, botRight, holeCenter, holeSize );
Don't allow point editor inversion when editing pad shapes. Fixes https://gitlab.com/kicad/code/kicad/issues/5272
2020-08-19 22:26:36 +00:00
Adjustments to point-editing of pads. 1) Don't offset pad with no hole and no offset: move them instead. 2) Don't allow editing of locked pads in board editor. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-29 18:14:51 +00:00
if( ( pad->GetOffset().x || pad->GetOffset().y )
|| ( pad->GetDrillSize().x && pad->GetDrillSize().y ) )
{
Separate the two offset strategies for PointEditor Pad editing. This doesn't indicate what I think we should do with them; it will just make whatever we decide easier to do.
2020-06-29 22:25:13 +00:00
// Keep hole pinned at the current location; adjust the pad around the hole
Neurotically update position wxPoint usages
2022-01-01 06:04:08 +00:00
VECTOR2I center = pad->GetPosition();
int dist[4];
Separate the two offset strategies for PointEditor Pad editing. This doesn't indicate what I think we should do with them; it will just make whatever we decide easier to do.
2020-06-29 22:25:13 +00:00
if( isModified( m_editPoints->Point( RECT_TOP_LEFT ) )
|| isModified( m_editPoints->Point( RECT_BOT_RIGHT ) ) )
{
Remove breakage of corner pinning in point editor. For some reason the post-pinned local variable references were replaced with calls to the points themselves (which are the pre-pinned values). Fixes https://gitlab.com/kicad/code/kicad/issues/7291
2021-02-01 00:33:00 +00:00
dist[0] = center.x - topLeft.x;
dist[1] = center.y - topLeft.y;
dist[2] = botRight.x - center.x;
dist[3] = botRight.y - center.y;
Separate the two offset strategies for PointEditor Pad editing. This doesn't indicate what I think we should do with them; it will just make whatever we decide easier to do.
2020-06-29 22:25:13 +00:00
}
else
{
Remove breakage of corner pinning in point editor. For some reason the post-pinned local variable references were replaced with calls to the points themselves (which are the pre-pinned values). Fixes https://gitlab.com/kicad/code/kicad/issues/7291
2021-02-01 00:33:00 +00:00
dist[0] = center.x - botLeft.x;
dist[1] = center.y - topRight.y;
dist[2] = topRight.x - center.x;
dist[3] = botLeft.y - center.y;
Separate the two offset strategies for PointEditor Pad editing. This doesn't indicate what I think we should do with them; it will just make whatever we decide easier to do.
2020-06-29 22:25:13 +00:00
}
Formatting.
2022-06-01 22:55:59 +00:00
wxSize padSize( dist[0] + dist[2], dist[1] + dist[3] );
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
VECTOR2I deltaOffset( padSize.x / 2 - dist[2], padSize.y / 2 - dist[3] );
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
Move pads to EDA_ANGLE.
2022-01-13 13:45:48 +00:00
if( pad->GetOrientation() == ANGLE_90 || pad->GetOrientation() == ANGLE_270 )
Adjustments to point-editing of pads. 1) Don't offset pad with no hole and no offset: move them instead. 2) Don't allow editing of locked pads in board editor. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-29 18:14:51 +00:00
std::swap( padSize.x, padSize.y );
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
RotatePoint( deltaOffset, -pad->GetOrientation() );
Adjustments to point-editing of pads. 1) Don't offset pad with no hole and no offset: move them instead. 2) Don't allow editing of locked pads in board editor. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-29 18:14:51 +00:00
pad->SetSize( padSize );
pad->SetOffset( -deltaOffset );
}
else
{
Separate the two offset strategies for PointEditor Pad editing. This doesn't indicate what I think we should do with them; it will just make whatever we decide easier to do.
2020-06-29 22:25:13 +00:00
// Keep pad position at the center of the pad shape
int left, top, right, bottom;
if( isModified( m_editPoints->Point( RECT_TOP_LEFT ) )
|| isModified( m_editPoints->Point( RECT_BOT_RIGHT ) ) )
{
Remove breakage of corner pinning in point editor. For some reason the post-pinned local variable references were replaced with calls to the points themselves (which are the pre-pinned values). Fixes https://gitlab.com/kicad/code/kicad/issues/7291
2021-02-01 00:33:00 +00:00
left = topLeft.x;
top = topLeft.y;
right = botRight.x;
bottom = botRight.y;
Separate the two offset strategies for PointEditor Pad editing. This doesn't indicate what I think we should do with them; it will just make whatever we decide easier to do.
2020-06-29 22:25:13 +00:00
}
else
{
Remove breakage of corner pinning in point editor. For some reason the post-pinned local variable references were replaced with calls to the points themselves (which are the pre-pinned values). Fixes https://gitlab.com/kicad/code/kicad/issues/7291
2021-02-01 00:33:00 +00:00
left = botLeft.x;
top = topRight.y;
right = topRight.x;
bottom = botLeft.y;
Separate the two offset strategies for PointEditor Pad editing. This doesn't indicate what I think we should do with them; it will just make whatever we decide easier to do.
2020-06-29 22:25:13 +00:00
}
wxSize padSize( abs( right - left ), abs( bottom - top ) );
Move pads to EDA_ANGLE.
2022-01-13 13:45:48 +00:00
if( pad->GetOrientation() == ANGLE_90 || pad->GetOrientation() == ANGLE_270 )
Adjustments to point-editing of pads. 1) Don't offset pad with no hole and no offset: move them instead. 2) Don't allow editing of locked pads in board editor. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-29 18:14:51 +00:00
std::swap( padSize.x, padSize.y );
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
Adjustments to point-editing of pads. 1) Don't offset pad with no hole and no offset: move them instead. 2) Don't allow editing of locked pads in board editor. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-29 18:14:51 +00:00
pad->SetSize( padSize );
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
pad->SetPosition( VECTOR2I( ( left + right ) / 2, ( top + bottom ) / 2 ) );
PCB_POINT_EDITOR: fix missing init of PAD pos0 after changing the PAD draw pos. Fixes #10558 https://gitlab.com/kicad/code/kicad/issues/10558
2022-01-22 09:23:55 +00:00
pad->SetLocalCoord();
Adjustments to point-editing of pads. 1) Don't offset pad with no hole and no offset: move them instead. 2) Don't allow editing of locked pads in board editor. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-29 18:14:51 +00:00
}
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
break;
TextBoxes for PCBNew.
2022-01-30 10:52:52 +00:00
}
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
default: // suppress warnings
break;
}
More NULL expunging.
2021-07-19 23:56:05 +00:00
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
break;
More NULL expunging.
2021-07-19 23:56:05 +00:00
}
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
Update some classnames including archaic zone names.
2020-11-11 23:05:59 +00:00
case PCB_FP_ZONE_T:
case PCB_ZONE_T:
Zones are supported by POINT_EDITOR.
2014-02-28 17:24:29 +00:00
{
Update some classnames including archaic zone names.
2020-11-11 23:05:59 +00:00
ZONE* zone = static_cast<ZONE*>( item );
Remove ZONE::ClearFilledPolysList() and fix ZONE::Unfill() ClearFilledPolysList is redundant and Unfill() was missing the clearing of m_insulatedIslands This fixes potential latent bugs in zone unfilling.
2021-03-19 19:32:44 +00:00
zone->UnFill();
Point Editor: prevent creation of self-intersecting polygons
2018-02-22 11:28:01 +00:00
SHAPE_POLY_SET& outline = *zone->Outline();
Zones are supported by POINT_EDITOR.
2014-02-28 17:24:29 +00:00
Point Editor: prevent creation of self-intersecting polygons
2018-02-22 11:28:01 +00:00
for( int i = 0; i < outline.TotalVertices(); ++i )
Pcbnew, Zone refill: avoid useless refilling, when zone parameters are not modified. Previously, in many cases the selected zone was refilled on exit selection, even if the zone was not modified. This is annoying, because the zone fill can be really time consuming, and cannot be called without a good reason. Now the refilling is made only if a zone parameter is actually modified.
2019-03-14 13:35:55 +00:00
{
SHAPE_LINE_CHAIN: Remove element access This is the first step to allowing non-segments in the line chain. External routines cannot be allowed to change the line chain without going through the internal routines. To accomplish this, we remove the Vertex() and Point() access routines and only leave the const versions. Transformations are given for both points as well as the chain itself.
2019-03-23 18:26:44 +00:00
if( outline.CVertex( i ) != m_editPoints->Point( i ).GetPosition() )
Pcbnew, Zone refill: avoid useless refilling, when zone parameters are not modified. Previously, in many cases the selected zone was refilled on exit selection, even if the zone was not modified. This is annoying, because the zone fill can be really time consuming, and cannot be called without a good reason. Now the refilling is made only if a zone parameter is actually modified.
2019-03-14 13:35:55 +00:00
zone->SetNeedRefill( true );
SHAPE_LINE_CHAIN: Remove element access This is the first step to allowing non-segments in the line chain. External routines cannot be allowed to change the line chain without going through the internal routines. To accomplish this, we remove the Vertex() and Point() access routines and only leave the const versions. Transformations are given for both points as well as the chain itself.
2019-03-23 18:26:44 +00:00
outline.SetVertex( i, m_editPoints->Point( i ).GetPosition() );
Adjust constraints after editing other points. Fixes https://gitlab.com/kicad/code/kicad/issues/7103
2021-03-19 11:34:14 +00:00
}
for( unsigned i = 0; i < m_editPoints->LinesSize(); ++i )
{
if( !isModified( m_editPoints->Line( i ) ) )
m_editPoints->Line( i ).SetConstraint( new EC_PERPLINE( m_editPoints->Line( i ) ) );
Pcbnew, Zone refill: avoid useless refilling, when zone parameters are not modified. Previously, in many cases the selected zone was refilled on exit selection, even if the zone was not modified. This is annoying, because the zone fill can be really time consuming, and cannot be called without a good reason. Now the refilling is made only if a zone parameter is actually modified.
2019-03-14 13:35:55 +00:00
}
Zones are supported by POINT_EDITOR.
2014-02-28 17:24:29 +00:00
Allow drawing self-intersecting polygons, just display a warning Fixes: lp:1751654 * https://bugs.launchpad.net/kicad/+bug/1751654
2018-03-02 09:55:59 +00:00
validatePolygon( outline );
Implement pad & via aprons for hatched zones. Fixes https://gitlab.com/kicad/code/kicad/issues/2519
2020-08-07 14:04:34 +00:00
zone->HatchBorder();
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
Do not auto-refill zones when added or edited The only exception is when using the Zone Properties Dialog and user preference is enabled
2021-03-19 19:07:16 +00:00
// TODO Refill zone when KiCad supports auto re-fill
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
break;
}
ADDED: Leader dimension object Fixes https://gitlab.com/kicad/code/kicad/-/issues/5555
2020-09-12 20:09:40 +00:00
case PCB_DIM_ALIGNED_T:
Dimensions for footprints. Fixes https://gitlab.com/kicad/code/kicad/issues/8441
2021-12-04 23:52:00 +00:00
case PCB_FP_DIM_ALIGNED_T:
Added new constraint for EDIT_POINTs (EPC_LINE). Dimensions have EDIT_POINTs. Different handling of 45 degree mode in POINT_EDITOR.
2014-03-12 09:46:11 +00:00
{
Prefix DIMENSION types.
2021-06-11 16:59:28 +00:00
PCB_DIM_ALIGNED* dimension = static_cast<PCB_DIM_ALIGNED*>( item );
Added new constraint for EDIT_POINTs (EPC_LINE). Dimensions have EDIT_POINTs. Different handling of 45 degree mode in POINT_EDITOR.
2014-03-12 09:46:11 +00:00
// Check which point is currently modified and updated dimension's points respectively
Refactor DIMENSION to hide internal details; add some new properties This is a board file format change to account for the new properties. Also, we now only store the critical information about the dimension's geometry in the board, rather than storing every drawn line. The DIMENSION object is now an abstract base, and ALIGNED_DIMENSION is the implementation that exists today (we will add more dimension types in the future)
2020-09-09 03:17:08 +00:00
if( isModified( m_editPoints->Point( DIM_CROSSBARSTART ) ) )
Added new constraint for EDIT_POINTs (EPC_LINE). Dimensions have EDIT_POINTs. Different handling of 45 degree mode in POINT_EDITOR.
2014-03-12 09:46:11 +00:00
{
Refactor DIMENSION to hide internal details; add some new properties This is a board file format change to account for the new properties. Also, we now only store the critical information about the dimension's geometry in the board, rather than storing every drawn line. The DIMENSION object is now an abstract base, and ALIGNED_DIMENSION is the implementation that exists today (we will add more dimension types in the future)
2020-09-09 03:17:08 +00:00
VECTOR2D featureLine( m_editedPoint->GetPosition() - dimension->GetStart() );
VECTOR2D crossBar( dimension->GetEnd() - dimension->GetStart() );
Added new constraint for EDIT_POINTs (EPC_LINE). Dimensions have EDIT_POINTs. Different handling of 45 degree mode in POINT_EDITOR.
2014-03-12 09:46:11 +00:00
if( featureLine.Cross( crossBar ) > 0 )
Refactor DIMENSION to hide internal details; add some new properties This is a board file format change to account for the new properties. Also, we now only store the critical information about the dimension's geometry in the board, rather than storing every drawn line. The DIMENSION object is now an abstract base, and ALIGNED_DIMENSION is the implementation that exists today (we will add more dimension types in the future)
2020-09-09 03:17:08 +00:00
dimension->SetHeight( -featureLine.EuclideanNorm() );
Added new constraint for EDIT_POINTs (EPC_LINE). Dimensions have EDIT_POINTs. Different handling of 45 degree mode in POINT_EDITOR.
2014-03-12 09:46:11 +00:00
else
Refactor DIMENSION to hide internal details; add some new properties This is a board file format change to account for the new properties. Also, we now only store the critical information about the dimension's geometry in the board, rather than storing every drawn line. The DIMENSION object is now an abstract base, and ALIGNED_DIMENSION is the implementation that exists today (we will add more dimension types in the future)
2020-09-09 03:17:08 +00:00
dimension->SetHeight( featureLine.EuclideanNorm() );
Switched order of EDIT_POINTs for DIMENSION, so in case when feature lines are of 0 length, then still can be stretched.
2014-03-12 09:53:42 +00:00
Don't run dimension updates while parsing files. They mess up the geometry when only partial values are provided. Fixes https://gitlab.com/kicad/code/kicad/issues/7177
2021-01-19 16:08:37 +00:00
dimension->Update();
}
Refactor DIMENSION to hide internal details; add some new properties This is a board file format change to account for the new properties. Also, we now only store the critical information about the dimension's geometry in the board, rather than storing every drawn line. The DIMENSION object is now an abstract base, and ALIGNED_DIMENSION is the implementation that exists today (we will add more dimension types in the future)
2020-09-09 03:17:08 +00:00
else if( isModified( m_editPoints->Point( DIM_CROSSBAREND ) ) )
Added new constraint for EDIT_POINTs (EPC_LINE). Dimensions have EDIT_POINTs. Different handling of 45 degree mode in POINT_EDITOR.
2014-03-12 09:46:11 +00:00
{
Remove a corner from zone outline function (GAL).
2015-06-19 15:32:33 +00:00
VECTOR2D featureLine( m_editedPoint->GetPosition() - dimension->GetEnd() );
Refactor DIMENSION to hide internal details; add some new properties This is a board file format change to account for the new properties. Also, we now only store the critical information about the dimension's geometry in the board, rather than storing every drawn line. The DIMENSION object is now an abstract base, and ALIGNED_DIMENSION is the implementation that exists today (we will add more dimension types in the future)
2020-09-09 03:17:08 +00:00
VECTOR2D crossBar( dimension->GetEnd() - dimension->GetStart() );
Added new constraint for EDIT_POINTs (EPC_LINE). Dimensions have EDIT_POINTs. Different handling of 45 degree mode in POINT_EDITOR.
2014-03-12 09:46:11 +00:00
if( featureLine.Cross( crossBar ) > 0 )
Refactor DIMENSION to hide internal details; add some new properties This is a board file format change to account for the new properties. Also, we now only store the critical information about the dimension's geometry in the board, rather than storing every drawn line. The DIMENSION object is now an abstract base, and ALIGNED_DIMENSION is the implementation that exists today (we will add more dimension types in the future)
2020-09-09 03:17:08 +00:00
dimension->SetHeight( -featureLine.EuclideanNorm() );
Added new constraint for EDIT_POINTs (EPC_LINE). Dimensions have EDIT_POINTs. Different handling of 45 degree mode in POINT_EDITOR.
2014-03-12 09:46:11 +00:00
else
Refactor DIMENSION to hide internal details; add some new properties This is a board file format change to account for the new properties. Also, we now only store the critical information about the dimension's geometry in the board, rather than storing every drawn line. The DIMENSION object is now an abstract base, and ALIGNED_DIMENSION is the implementation that exists today (we will add more dimension types in the future)
2020-09-09 03:17:08 +00:00
dimension->SetHeight( featureLine.EuclideanNorm() );
Added new constraint for EDIT_POINTs (EPC_LINE). Dimensions have EDIT_POINTs. Different handling of 45 degree mode in POINT_EDITOR.
2014-03-12 09:46:11 +00:00
Don't run dimension updates while parsing files. They mess up the geometry when only partial values are provided. Fixes https://gitlab.com/kicad/code/kicad/issues/7177
2021-01-19 16:08:37 +00:00
dimension->Update();
}
Refactor DIMENSION to hide internal details; add some new properties This is a board file format change to account for the new properties. Also, we now only store the critical information about the dimension's geometry in the board, rather than storing every drawn line. The DIMENSION object is now an abstract base, and ALIGNED_DIMENSION is the implementation that exists today (we will add more dimension types in the future)
2020-09-09 03:17:08 +00:00
else if( isModified( m_editPoints->Point( DIM_START ) ) )
Switched order of EDIT_POINTs for DIMENSION, so in case when feature lines are of 0 length, then still can be stretched.
2014-03-12 09:53:42 +00:00
{
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
dimension->SetStart( m_editedPoint->GetPosition() );
Don't run dimension updates while parsing files. They mess up the geometry when only partial values are provided. Fixes https://gitlab.com/kicad/code/kicad/issues/7177
2021-01-19 16:08:37 +00:00
dimension->Update();
More NULL expunging.
2021-07-19 23:56:05 +00:00
m_editPoints->Point( DIM_CROSSBARSTART ).
SetConstraint( new EC_LINE( m_editPoints->Point( DIM_CROSSBARSTART ),
m_editPoints->Point( DIM_START ) ) );
m_editPoints->Point( DIM_CROSSBAREND ).
SetConstraint( new EC_LINE( m_editPoints->Point( DIM_CROSSBAREND ),
m_editPoints->Point( DIM_END ) ) );
Switched order of EDIT_POINTs for DIMENSION, so in case when feature lines are of 0 length, then still can be stretched.
2014-03-12 09:53:42 +00:00
}
Refactor DIMENSION to hide internal details; add some new properties This is a board file format change to account for the new properties. Also, we now only store the critical information about the dimension's geometry in the board, rather than storing every drawn line. The DIMENSION object is now an abstract base, and ALIGNED_DIMENSION is the implementation that exists today (we will add more dimension types in the future)
2020-09-09 03:17:08 +00:00
else if( isModified( m_editPoints->Point( DIM_END ) ) )
Switched order of EDIT_POINTs for DIMENSION, so in case when feature lines are of 0 length, then still can be stretched.
2014-03-12 09:53:42 +00:00
{
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
dimension->SetEnd( m_editedPoint->GetPosition() );
Don't run dimension updates while parsing files. They mess up the geometry when only partial values are provided. Fixes https://gitlab.com/kicad/code/kicad/issues/7177
2021-01-19 16:08:37 +00:00
dimension->Update();
More NULL expunging.
2021-07-19 23:56:05 +00:00
m_editPoints->Point( DIM_CROSSBARSTART ).
SetConstraint( new EC_LINE( m_editPoints->Point( DIM_CROSSBARSTART ),
m_editPoints->Point( DIM_START ) ) );
m_editPoints->Point( DIM_CROSSBAREND ).
SetConstraint( new EC_LINE( m_editPoints->Point( DIM_CROSSBAREND ),
m_editPoints->Point( DIM_END ) ) );
Switched order of EDIT_POINTs for DIMENSION, so in case when feature lines are of 0 length, then still can be stretched.
2014-03-12 09:53:42 +00:00
}
Implement new dimension properties - Automatic units mode (follow UI units) - New text and number formatting options - Automatic/manual text orientation control - New text positioning options (inline and manual) Fixes https://gitlab.com/kicad/code/kicad/-/issues/4280 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4497
2020-09-11 23:52:45 +00:00
else if( isModified( m_editPoints->Point(DIM_TEXT ) ) )
{
// Force manual mode if we weren't already in it
dimension->SetTextPositionMode( DIM_TEXT_POSITION::MANUAL );
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
dimension->Text().SetPosition( m_editedPoint->GetPosition() );
Implement new dimension properties - Automatic units mode (follow UI units) - New text and number formatting options - Automatic/manual text orientation control - New text positioning options (inline and manual) Fixes https://gitlab.com/kicad/code/kicad/-/issues/4280 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4497
2020-09-11 23:52:45 +00:00
dimension->Update();
}
Added new constraint for EDIT_POINTs (EPC_LINE). Dimensions have EDIT_POINTs. Different handling of 45 degree mode in POINT_EDITOR.
2014-03-12 09:46:11 +00:00
break;
}
ADDED: Orthogonal dimension object
2020-09-22 02:32:40 +00:00
case PCB_DIM_ORTHOGONAL_T:
Dimensions for footprints. Fixes https://gitlab.com/kicad/code/kicad/issues/8441
2021-12-04 23:52:00 +00:00
case PCB_FP_DIM_ORTHOGONAL_T:
ADDED: Orthogonal dimension object
2020-09-22 02:32:40 +00:00
{
Prefix DIMENSION types.
2021-06-11 16:59:28 +00:00
PCB_DIM_ORTHOGONAL* dimension = static_cast<PCB_DIM_ORTHOGONAL*>( item );
ADDED: Orthogonal dimension object
2020-09-22 02:32:40 +00:00
if( isModified( m_editPoints->Point( DIM_CROSSBARSTART ) ) ||
isModified( m_editPoints->Point( DIM_CROSSBAREND ) ) )
{
Fix orientation of orthogonal dimensions When drawing and editing orthogonal dimensions, take distance and relative position to the end points into account. Fixes https://gitlab.com/kicad/code/kicad/issues/7243 Fixes https://gitlab.com/kicad/code/kicad/issues/7189
2021-03-05 14:40:02 +00:00
BOX2I bounds( dimension->GetStart(), dimension->GetEnd() - dimension->GetStart() );
const VECTOR2I& cursorPos = m_editedPoint->GetPosition();
// Find vector from nearest dimension point to edit position
VECTOR2I directionA( cursorPos - dimension->GetStart() );
VECTOR2I directionB( cursorPos - dimension->GetEnd() );
VECTOR2I direction = ( directionA < directionB ) ? directionA : directionB;
bool vert;
VECTOR2D featureLine( cursorPos - dimension->GetStart() );
ADDED: Orthogonal dimension object
2020-09-22 02:32:40 +00:00
// Only change the orientation when we move outside the bounds
Fix orientation of orthogonal dimensions When drawing and editing orthogonal dimensions, take distance and relative position to the end points into account. Fixes https://gitlab.com/kicad/code/kicad/issues/7243 Fixes https://gitlab.com/kicad/code/kicad/issues/7189
2021-03-05 14:40:02 +00:00
if( !bounds.Contains( cursorPos ) )
ADDED: Orthogonal dimension object
2020-09-22 02:32:40 +00:00
{
Fix orientation of orthogonal dimensions When drawing and editing orthogonal dimensions, take distance and relative position to the end points into account. Fixes https://gitlab.com/kicad/code/kicad/issues/7243 Fixes https://gitlab.com/kicad/code/kicad/issues/7189
2021-03-05 14:40:02 +00:00
// If the dimension is horizontal or vertical, set correct orientation
// otherwise, test if we're left/right of the bounding box or above/below it
if( bounds.GetWidth() == 0 )
vert = true;
else if( bounds.GetHeight() == 0 )
vert = false;
else if( cursorPos.x > bounds.GetLeft() && cursorPos.x < bounds.GetRight() )
vert = false;
else if( cursorPos.y > bounds.GetTop() && cursorPos.y < bounds.GetBottom() )
vert = true;
else
vert = std::abs( direction.y ) < std::abs( direction.x );
Back-port some fixes from 7.0 branch.
2021-07-13 15:10:18 +00:00
Prefix DIMENSION types.
2021-06-11 16:59:28 +00:00
dimension->SetOrientation( vert ? PCB_DIM_ORTHOGONAL::DIR::VERTICAL
: PCB_DIM_ORTHOGONAL::DIR::HORIZONTAL );
Fix orientation of orthogonal dimensions When drawing and editing orthogonal dimensions, take distance and relative position to the end points into account. Fixes https://gitlab.com/kicad/code/kicad/issues/7243 Fixes https://gitlab.com/kicad/code/kicad/issues/7189
2021-03-05 14:40:02 +00:00
}
else
{
Prefix DIMENSION types.
2021-06-11 16:59:28 +00:00
vert = dimension->GetOrientation() == PCB_DIM_ORTHOGONAL::DIR::VERTICAL;
ADDED: Orthogonal dimension object
2020-09-22 02:32:40 +00:00
}
dimension->SetHeight( vert ? featureLine.x : featureLine.y );
}
else if( isModified( m_editPoints->Point( DIM_START ) ) )
{
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
dimension->SetStart( m_editedPoint->GetPosition() );
ADDED: Orthogonal dimension object
2020-09-22 02:32:40 +00:00
}
else if( isModified( m_editPoints->Point( DIM_END ) ) )
{
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
dimension->SetEnd( m_editedPoint->GetPosition() );
ADDED: Orthogonal dimension object
2020-09-22 02:32:40 +00:00
}
else if( isModified( m_editPoints->Point(DIM_TEXT ) ) )
{
// Force manual mode if we weren't already in it
dimension->SetTextPositionMode( DIM_TEXT_POSITION::MANUAL );
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
dimension->Text().SetPosition( VECTOR2I( m_editedPoint->GetPosition() ) );
ADDED: Orthogonal dimension object
2020-09-22 02:32:40 +00:00
}
Don't run dimension updates while parsing files. They mess up the geometry when only partial values are provided. Fixes https://gitlab.com/kicad/code/kicad/issues/7177
2021-01-19 16:08:37 +00:00
dimension->Update();
ADDED: Orthogonal dimension object
2020-09-22 02:32:40 +00:00
break;
}
ADDED: Center marker dimension type
2020-09-17 00:54:58 +00:00
case PCB_DIM_CENTER_T:
Dimensions for footprints. Fixes https://gitlab.com/kicad/code/kicad/issues/8441
2021-12-04 23:52:00 +00:00
case PCB_FP_DIM_CENTER_T:
ADDED: Center marker dimension type
2020-09-17 00:54:58 +00:00
{
Prefix DIMENSION types.
2021-06-11 16:59:28 +00:00
PCB_DIM_CENTER* dimension = static_cast<PCB_DIM_CENTER*>( item );
ADDED: Center marker dimension type
2020-09-17 00:54:58 +00:00
if( isModified( m_editPoints->Point( DIM_START ) ) )
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
dimension->SetStart( m_editedPoint->GetPosition() );
ADDED: Center marker dimension type
2020-09-17 00:54:58 +00:00
else if( isModified( m_editPoints->Point( DIM_END ) ) )
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
dimension->SetEnd( m_editedPoint->GetPosition() );
ADDED: Center marker dimension type
2020-09-17 00:54:58 +00:00
dimension->Update();
break;
}
Radial dimensions. ADDED radial type dimensions. Fixes https://gitlab.com/kicad/code/kicad/issues/2056
2021-07-13 18:46:33 +00:00
case PCB_DIM_RADIAL_T:
Dimensions for footprints. Fixes https://gitlab.com/kicad/code/kicad/issues/8441
2021-12-04 23:52:00 +00:00
case PCB_FP_DIM_RADIAL_T:
Radial dimensions. ADDED radial type dimensions. Fixes https://gitlab.com/kicad/code/kicad/issues/2056
2021-07-13 18:46:33 +00:00
{
PCB_DIM_RADIAL* dimension = static_cast<PCB_DIM_RADIAL*>( item );
if( isModified( m_editPoints->Point( DIM_START ) ) )
{
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
dimension->SetStart( m_editedPoint->GetPosition() );
Radial dimensions. ADDED radial type dimensions. Fixes https://gitlab.com/kicad/code/kicad/issues/2056
2021-07-13 18:46:33 +00:00
dimension->Update();
m_editPoints->Point( DIM_KNEE ).SetConstraint( new EC_LINE( m_editPoints->Point( DIM_START ),
m_editPoints->Point( DIM_END ) ) );
}
else if( isModified( m_editPoints->Point( DIM_END ) ) )
{
Neurotically update position wxPoint usages
2022-01-01 06:04:08 +00:00
VECTOR2I oldKnee = dimension->GetKnee();
Radial dimensions. ADDED radial type dimensions. Fixes https://gitlab.com/kicad/code/kicad/issues/2056
2021-07-13 18:46:33 +00:00
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
dimension->SetEnd( m_editedPoint->GetPosition() );
Radial dimensions. ADDED radial type dimensions. Fixes https://gitlab.com/kicad/code/kicad/issues/2056
2021-07-13 18:46:33 +00:00
dimension->Update();
Neurotically update position wxPoint usages
2022-01-01 06:04:08 +00:00
VECTOR2I kneeDelta = dimension->GetKnee() - oldKnee;
Radial dimensions. ADDED radial type dimensions. Fixes https://gitlab.com/kicad/code/kicad/issues/2056
2021-07-13 18:46:33 +00:00
dimension->Text().SetPosition( dimension->Text().GetPosition() + kneeDelta );
dimension->Update();
m_editPoints->Point( DIM_KNEE ).SetConstraint( new EC_LINE( m_editPoints->Point( DIM_START ),
m_editPoints->Point( DIM_END ) ) );
}
else if( isModified( m_editPoints->Point( DIM_KNEE ) ) )
{
Neurotically update position wxPoint usages
2022-01-01 06:04:08 +00:00
VECTOR2I oldKnee = dimension->GetKnee();
Radial dimensions. ADDED radial type dimensions. Fixes https://gitlab.com/kicad/code/kicad/issues/2056
2021-07-13 18:46:33 +00:00
VECTOR2I arrowVec = m_editPoints->Point( DIM_KNEE ).GetPosition()
- m_editPoints->Point( DIM_END ).GetPosition();
dimension->SetLeaderLength( arrowVec.EuclideanNorm() );
dimension->Update();
Neurotically update position wxPoint usages
2022-01-01 06:04:08 +00:00
VECTOR2I kneeDelta = dimension->GetKnee() - oldKnee;
Radial dimensions. ADDED radial type dimensions. Fixes https://gitlab.com/kicad/code/kicad/issues/2056
2021-07-13 18:46:33 +00:00
dimension->Text().SetPosition( dimension->Text().GetPosition() + kneeDelta );
dimension->Update();
}
else if( isModified( m_editPoints->Point( DIM_TEXT ) ) )
{
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
dimension->Text().SetPosition( m_editedPoint->GetPosition() );
Radial dimensions. ADDED radial type dimensions. Fixes https://gitlab.com/kicad/code/kicad/issues/2056
2021-07-13 18:46:33 +00:00
dimension->Update();
}
break;
}
ADDED: Leader dimension object Fixes https://gitlab.com/kicad/code/kicad/-/issues/5555
2020-09-12 20:09:40 +00:00
case PCB_DIM_LEADER_T:
Dimensions for footprints. Fixes https://gitlab.com/kicad/code/kicad/issues/8441
2021-12-04 23:52:00 +00:00
case PCB_FP_DIM_LEADER_T:
ADDED: Leader dimension object Fixes https://gitlab.com/kicad/code/kicad/-/issues/5555
2020-09-12 20:09:40 +00:00
{
Prefix DIMENSION types.
2021-06-11 16:59:28 +00:00
PCB_DIM_LEADER* dimension = static_cast<PCB_DIM_LEADER*>( item );
ADDED: Leader dimension object Fixes https://gitlab.com/kicad/code/kicad/-/issues/5555
2020-09-12 20:09:40 +00:00
if( isModified( m_editPoints->Point( DIM_START ) ) )
{
Neurotically update position wxPoint usages
2022-01-01 06:04:08 +00:00
dimension->SetStart( (VECTOR2I) m_editedPoint->GetPosition() );
ADDED: Leader dimension object Fixes https://gitlab.com/kicad/code/kicad/-/issues/5555
2020-09-12 20:09:40 +00:00
}
else if( isModified( m_editPoints->Point( DIM_END ) ) )
{
Neurotically update position wxPoint usages
2022-01-01 06:04:08 +00:00
VECTOR2I newPoint( m_editedPoint->GetPosition() );
VECTOR2I delta = newPoint - dimension->GetEnd();
ADDED: Leader dimension object Fixes https://gitlab.com/kicad/code/kicad/-/issues/5555
2020-09-12 20:09:40 +00:00
dimension->SetEnd( newPoint );
dimension->Text().SetPosition( dimension->Text().GetPosition() + delta );
}
else if( isModified( m_editPoints->Point( DIM_TEXT ) ) )
{
Neurotically update position wxPoint usages
2022-01-01 06:04:08 +00:00
dimension->Text().SetPosition( (VECTOR2I) m_editedPoint->GetPosition() );
ADDED: Leader dimension object Fixes https://gitlab.com/kicad/code/kicad/-/issues/5555
2020-09-12 20:09:40 +00:00
}
dimension->Update();
break;
}
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
default:
break;
}
pcbnew: refresh message panel while drawing & editing graphical lines, arcs, circles and texts Fixes: lp:1763052 * https://bugs.launchpad.net/kicad/+bug/1763052
2018-04-12 16:08:45 +00:00
Point editor: show dragged points with a highlight Take points editor colors from color theme Also fix an issue where the edited object sometimes didn't update when a point is dragged. Fixes https://gitlab.com/kicad/code/kicad/-/issues/4600
2020-06-21 18:43:33 +00:00
getView()->Update( item );
More data validity checks in POINT_EDITOR Fixes: lp:1690658 * https://bugs.launchpad.net/kicad/+bug/1690658
2017-05-16 09:38:00 +00:00
Update message panel from PCB point editor and SCH drawing tools. Fixes https://gitlab.com/kicad/code/kicad/issues/11186
2022-03-20 15:57:18 +00:00
frame()->SetMsgPanel( item );
Auto zone refilling after using the POINT_EDITOR. Minor code cleaning.
2014-03-06 10:49:08 +00:00
}
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
bool PCB_POINT_EDITOR::validatePolygon( SHAPE_POLY_SET& aPoly ) const
Point Editor: prevent creation of self-intersecting polygons
2018-02-22 11:28:01 +00:00
{
Allow edits to self-intersecting polygons. 1) Intermediate states might be self-intersecting, and we shouldn't be policing our users on what order to do things in 2) The polygon might already be self-intersecting, at which point we're preventing the user from fixing it. Also includes better const management for SHAPE_POLY_SET API. Fixes: lp:1833831 * https://bugs.launchpad.net/kicad/+bug/1833831
2019-07-14 12:46:59 +00:00
bool valid = !aPoly.IsSelfIntersecting();
Point Editor: prevent creation of self-intersecting polygons
2018-02-22 11:28:01 +00:00
Performance optimizations.
2022-07-09 22:30:52 +00:00
if( !m_statusPopup )
Point Editor: prevent creation of self-intersecting polygons
2018-02-22 11:28:01 +00:00
{
Performance optimizations.
2022-07-09 22:30:52 +00:00
m_statusPopup.reset( new STATUS_TEXT_POPUP( getEditFrame<PCB_BASE_EDIT_FRAME>() ) );
m_statusPopup->SetTextColor( wxColour( 255, 0, 0 ) );
m_statusPopup->SetText( _( "Self-intersecting polygons are not allowed." ) );
}
if( valid )
{
m_statusPopup->Hide();
}
else
{
wxPoint p = wxGetMousePosition() + wxPoint( 20, 20 );
m_statusPopup->Move( p );
m_statusPopup->PopupFor( 1500 );
Point Editor: prevent creation of self-intersecting polygons
2018-02-22 11:28:01 +00:00
}
Allow edits to self-intersecting polygons. 1) Intermediate states might be self-intersecting, and we shouldn't be policing our users on what order to do things in 2) The polygon might already be self-intersecting, at which point we're preventing the user from fixing it. Also includes better const management for SHAPE_POLY_SET API. Fixes: lp:1833831 * https://bugs.launchpad.net/kicad/+bug/1833831
2019-07-14 12:46:59 +00:00
return valid;
Point Editor: prevent creation of self-intersecting polygons
2018-02-22 11:28:01 +00:00
}
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
void PCB_POINT_EDITOR::updatePoints()
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
{
TOOL_ACTIONs are handled with transitions, no handlers needed in the event loops There used to be a number of TOOL_ACTIONs that had entries both in SetTransitions() and the event loop, which seemed redundant and troublesome. Now it is not necessary anymore, transitions setup is enough to execute associated actions.
2017-01-18 08:04:11 +00:00
if( !m_editPoints )
return;
Added TOOL_ACTION for updating EDIT_POINTS. EDIT_POINTs show up when there is only one item selected (now after deselection as well).
2014-02-28 15:53:28 +00:00
EDA_ITEM* item = m_editPoints->GetParent();
More data validity checks in POINT_EDITOR Fixes: lp:1690658 * https://bugs.launchpad.net/kicad/+bug/1690658
2017-05-16 09:38:00 +00:00
if( !item )
return;
Handle textboxes moving back to RECT shape (ie: cardinal rotation).
2022-04-01 15:11:42 +00:00
switch( item->Type() )
{
PCB Editor: Add User Background Images
2022-02-08 19:29:54 +00:00
case PCB_BITMAP_T:
{
PCB_BITMAP* bitmap = (PCB_BITMAP*) item;
VECTOR2I topLeft = bitmap->GetPosition() - bitmap->GetSize() / 2;
VECTOR2I botRight = bitmap->GetPosition() + bitmap->GetSize() / 2;
m_editPoints->Point( RECT_TOP_LEFT ).SetPosition( topLeft );
m_editPoints->Point( RECT_TOP_RIGHT ).SetPosition( botRight.x, topLeft.y );
m_editPoints->Point( RECT_BOT_LEFT ).SetPosition( topLeft.x, botRight.y );
m_editPoints->Point( RECT_BOT_RIGHT ).SetPosition( botRight );
break;
}
Handle textboxes moving back to RECT shape (ie: cardinal rotation).
2022-04-01 15:11:42 +00:00
case PCB_TEXTBOX_T:
case PCB_FP_TEXTBOX_T:
TextBoxes for PCBNew.
2022-01-30 10:52:52 +00:00
{
const PCB_SHAPE* shape = static_cast<const PCB_SHAPE*>( item );
Handle textboxes moving back to RECT shape (ie: cardinal rotation).
2022-04-01 15:11:42 +00:00
int target = shape->GetShape() == SHAPE_T::RECT ? 4 : 0;
TextBoxes for PCBNew.
2022-01-30 10:52:52 +00:00
Handle textboxes moving back to RECT shape (ie: cardinal rotation).
2022-04-01 15:11:42 +00:00
// Careful; textbox shape is mutable between cardinal and non-cardinal rotations...
if( int( m_editPoints->PointsSize() ) != target )
{
getView()->Remove( m_editPoints.get() );
m_editedPoint = nullptr;
m_editPoints = makePoints( item );
if( m_editPoints )
getView()->Add( m_editPoints.get() );
break;
}
if( shape->GetShape() == SHAPE_T::RECT )
TextBoxes for PCBNew.
2022-01-30 10:52:52 +00:00
{
Repair point editing of rotated text boxes. Fixes https://gitlab.com/kicad/code/kicad/issues/11432
2022-06-02 09:42:13 +00:00
m_editPoints->Point( RECT_TOP_LEFT ).SetPosition( shape->GetTopLeft() );
m_editPoints->Point( RECT_TOP_RIGHT ).SetPosition( shape->GetBotRight().x,
shape->GetTopLeft().y );
m_editPoints->Point( RECT_BOT_RIGHT ).SetPosition( shape->GetBotRight() );
m_editPoints->Point( RECT_BOT_LEFT ).SetPosition( shape->GetTopLeft().x,
shape->GetBotRight().y );
TextBoxes for PCBNew.
2022-01-30 10:52:52 +00:00
}
Handle textboxes moving back to RECT shape (ie: cardinal rotation).
2022-04-01 15:11:42 +00:00
else if( shape->GetShape() == SHAPE_T::POLY )
{
// Not currently editable while rotated.
}
break;
TextBoxes for PCBNew.
2022-01-30 10:52:52 +00:00
}
PCB_LINE_T -> PCB_SHAPE_T and PCB_MODULE_EDGE_T -> PCB_FP_SHAPE_T Also updated footprint text and zone types for consistencey.
2020-10-04 14:19:33 +00:00
case PCB_SHAPE_T:
case PCB_FP_SHAPE_T:
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
{
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
const PCB_SHAPE* shape = static_cast<const PCB_SHAPE*>( item );
Fix minor compil warnings (some are for old compilers).
2017-12-18 13:07:17 +00:00
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
switch( shape->GetShape() )
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
{
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
case SHAPE_T::SEGMENT:
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
m_editPoints->Point( SEG_START ).SetPosition( shape->GetStart() );
m_editPoints->Point( SEG_END ).SetPosition( shape->GetEnd() );
Fix minor compil warnings (some are for old compilers).
2017-12-18 13:07:17 +00:00
break;
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
case SHAPE_T::RECT:
Repair point editing of rotated text boxes. Fixes https://gitlab.com/kicad/code/kicad/issues/11432
2022-06-02 09:42:13 +00:00
m_editPoints->Point( RECT_TOP_LEFT ).SetPosition( shape->GetTopLeft() );
m_editPoints->Point( RECT_TOP_RIGHT ).SetPosition( shape->GetBotRight().x,
shape->GetTopLeft().y );
m_editPoints->Point( RECT_BOT_RIGHT ).SetPosition( shape->GetBotRight() );
m_editPoints->Point( RECT_BOT_LEFT ).SetPosition( shape->GetTopLeft().x,
shape->GetBotRight().y );
Finish implementation of DRAWSEGMENT::C_RECT. It's currently only supported in the Footprint Editor. It could be easily added to the board editor (all the code is there), but the board editor is a little short on room in the drawing tools toolbar.
2020-06-15 19:50:20 +00:00
break;
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
case SHAPE_T::ARC:
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
m_editPoints->Point( ARC_CENTER ).SetPosition( shape->GetCenter() );
Overhaul arc internal model to not over-specify information.
2021-07-17 19:56:18 +00:00
m_editPoints->Point( ARC_START ).SetPosition( shape->GetStart() );
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
m_editPoints->Point( ARC_MID ).SetPosition( shape->GetArcMid() );
Overhaul arc internal model to not over-specify information.
2021-07-17 19:56:18 +00:00
m_editPoints->Point( ARC_END ).SetPosition( shape->GetEnd() );
Fix minor compil warnings (some are for old compilers).
2017-12-18 13:07:17 +00:00
break;
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
case SHAPE_T::CIRCLE:
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
m_editPoints->Point( CIRC_CENTER ).SetPosition( shape->GetCenter() );
m_editPoints->Point( CIRC_END ).SetPosition( shape->GetEnd() );
Fix minor compil warnings (some are for old compilers).
2017-12-18 13:07:17 +00:00
break;
Circles are supported by POINT_EDITOR.
2014-02-28 17:24:13 +00:00
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
case SHAPE_T::POLY:
Fix minor compil warnings (some are for old compilers).
2017-12-18 13:07:17 +00:00
{
Neurotically update position wxPoint usages
2022-01-01 06:04:08 +00:00
std::vector<VECTOR2I> points;
Rename BuildPolyPointsList() to DupPolyPointsList() and optimize code to avoid multiple useless copies of the list of polygon corners in code.
2021-09-11 12:21:36 +00:00
shape->DupPolyPointsList( points );
pcbnew: Add corners in polygons Allow corner adding to polygons in both module editor and board editor. The board editor was already allowed but only through special types. The module editor is now sychronized to the same process and both recognize standard context menus Fixes: lp:1782966 * https://bugs.launchpad.net/kicad/+bug/1782966 ( cherry-picked from 06ac172c2 )
2018-09-15 16:51:35 +00:00
if( m_editPoints->PointsSize() != (unsigned) points.size() )
{
getView()->Remove( m_editPoints.get() );
m_editedPoint = nullptr;
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
m_editPoints = makePoints( item );
if( m_editPoints )
getView()->Add( m_editPoints.get() );
pcbnew: Add corners in polygons Allow corner adding to polygons in both module editor and board editor. The board editor was already allowed but only through special types. The module editor is now sychronized to the same process and both recognize standard context menus Fixes: lp:1782966 * https://bugs.launchpad.net/kicad/+bug/1782966 ( cherry-picked from 06ac172c2 )
2018-09-15 16:51:35 +00:00
}
else
pcbnew: fix graphical polygon movement, rotation, flipping and edit points synchronization. Fixes: lp:1738449 * https://bugs.launchpad.net/kicad/+bug/1738449 Fixes: lp:1738032 * https://bugs.launchpad.net/kicad/+bug/1738032
2017-12-18 17:24:25 +00:00
{
pcbnew: Add corners in polygons Allow corner adding to polygons in both module editor and board editor. The board editor was already allowed but only through special types. The module editor is now sychronized to the same process and both recognize standard context menus Fixes: lp:1782966 * https://bugs.launchpad.net/kicad/+bug/1782966 ( cherry-picked from 06ac172c2 )
2018-09-15 16:51:35 +00:00
for( unsigned i = 0; i < points.size(); i++ )
m_editPoints->Point( i ).SetPosition( points[i] );
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
}
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
Fix minor compil warnings (some are for old compilers).
2017-12-18 13:07:17 +00:00
break;
}
Zones are supported by POINT_EDITOR.
2014-02-28 17:24:29 +00:00
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
case SHAPE_T::BEZIER:
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
m_editPoints->Point( BEZIER_CURVE_START ).SetPosition( shape->GetStart() );
Naming conventions and a bug fix on arc points.
2021-07-18 12:31:56 +00:00
m_editPoints->Point( BEZIER_CURVE_CONTROL_POINT1 ).SetPosition( shape->GetBezierC1() );
m_editPoints->Point( BEZIER_CURVE_CONTROL_POINT2 ).SetPosition( shape->GetBezierC2() );
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
m_editPoints->Point( BEZIER_CURVE_END ).SetPosition( shape->GetEnd() );
Add Bezier curve (S_CURVE shape) support in DIALOG_GRAPHIC_ITEM_PROPERTIES. Fix some issues related to S_CURVE shape support.
2018-07-22 12:50:35 +00:00
break;
Fix minor compil warnings (some are for old compilers).
2017-12-18 13:07:17 +00:00
default: // suppress warnings
Zones are supported by POINT_EDITOR.
2014-02-28 17:24:29 +00:00
break;
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
}
Fix minor compil warnings (some are for old compilers).
2017-12-18 13:07:17 +00:00
break;
Zones are supported by POINT_EDITOR.
2014-02-28 17:24:29 +00:00
}
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
case PCB_PAD_T:
{
D_PAD -> PAD.
2020-11-12 22:30:02 +00:00
const PAD* pad = static_cast<const PAD*>( item );
Move pad locking from footprint to pads. Fixes https://gitlab.com/kicad/code/kicad/issues/6997
2021-01-08 16:32:28 +00:00
bool locked = pad->GetParent() && pad->IsLocked();
Neurotically update position wxPoint usages
2022-01-01 06:04:08 +00:00
VECTOR2I shapePos = pad->ShapePos();
VECTOR2I halfSize( pad->GetSize().x / 2, pad->GetSize().y / 2 );
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
switch( pad->GetShape() )
{
enum class PAD_SHAPE_T
2021-05-01 12:22:35 +00:00
case PAD_SHAPE::CIRCLE:
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
{
Don't allow offset for circular pads. Fixes https://gitlab.com/kicad/code/kicad/issues/9266
2021-09-29 12:53:54 +00:00
int target = locked ? 0 : 1;
Adjustments to point-editing of pads. 1) Don't offset pad with no hole and no offset: move them instead. 2) Don't allow editing of locked pads in board editor. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-29 18:14:51 +00:00
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
// Careful; pad shape is mutable...
fix a minor compil warning
2020-07-01 16:41:50 +00:00
if( int( m_editPoints->PointsSize() ) != target )
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
{
getView()->Remove( m_editPoints.get() );
m_editedPoint = nullptr;
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
m_editPoints = makePoints( item );
if( m_editPoints )
getView()->Add( m_editPoints.get() );
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
}
Don't allow offset for circular pads. Fixes https://gitlab.com/kicad/code/kicad/issues/9266
2021-09-29 12:53:54 +00:00
else if( target == 1 )
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
{
Fix logic bug when updating circular pad points. Fixes https://gitlab.com/kicad/code/kicad/issues/9576
2021-11-09 13:09:06 +00:00
shapePos.x += halfSize.x;
m_editPoints->Point( 0 ).SetPosition( shapePos );
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
}
}
break;
enum class PAD_SHAPE_T
2021-05-01 12:22:35 +00:00
case PAD_SHAPE::OVAL:
case PAD_SHAPE::TRAPEZOID:
case PAD_SHAPE::RECT:
case PAD_SHAPE::ROUNDRECT:
case PAD_SHAPE::CHAMFERED_RECT:
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
{
// Careful; pad shape and orientation are mutable...
Move pads to EDA_ANGLE.
2022-01-13 13:45:48 +00:00
int target = locked || !pad->GetOrientation().IsCardinal() ? 0 : 4;
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
fix a minor compil warning
2020-07-01 16:41:50 +00:00
if( int( m_editPoints->PointsSize() ) != target )
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
{
getView()->Remove( m_editPoints.get() );
m_editedPoint = nullptr;
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
m_editPoints = makePoints( item );
if( m_editPoints )
getView()->Add( m_editPoints.get() );
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
}
else if( target == 4 )
{
Move pads to EDA_ANGLE.
2022-01-13 13:45:48 +00:00
if( pad->GetOrientation() == ANGLE_90 || pad->GetOrientation() == ANGLE_270 )
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
std::swap( halfSize.x, halfSize.y );
m_editPoints->Point( RECT_TOP_LEFT ).SetPosition( shapePos - halfSize );
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
m_editPoints->Point( RECT_TOP_RIGHT )
.SetPosition(
VECTOR2I( shapePos.x + halfSize.x, shapePos.y - halfSize.y ) );
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
m_editPoints->Point( RECT_BOT_RIGHT ).SetPosition( shapePos + halfSize );
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
m_editPoints->Point( RECT_BOT_LEFT )
.SetPosition(
VECTOR2I( shapePos.x - halfSize.x, shapePos.y + halfSize.y ) );
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
}
More NULL expunging.
2021-07-19 23:56:05 +00:00
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
break;
More NULL expunging.
2021-07-19 23:56:05 +00:00
}
Point editor hookup for non-custom-shaped pads. Fixes https://gitlab.com/kicad/code/kicad/issues/2153
2020-06-28 22:34:10 +00:00
default: // suppress warnings
break;
}
}
break;
Update some classnames including archaic zone names.
2020-11-11 23:05:59 +00:00
case PCB_FP_ZONE_T:
case PCB_ZONE_T:
Zones are supported by POINT_EDITOR.
2014-02-28 17:24:29 +00:00
{
Update some classnames including archaic zone names.
2020-11-11 23:05:59 +00:00
ZONE* zone = static_cast<ZONE*>( item );
CPolyLine -> SHAPE_POLY_SET refactor. Removes the need of using the legacy code in polygon/PolyLine.{h,cpp}, refactoring all CPolyLine instances with SHAPE_POLY_SET instances. The remaining legacy methods have been ported to SHAPE_POLY_SET; mainly: Chamfer, Fillet, {,Un}Hatch. The iteration over the polygon vertices have been simplified using the family of ITERATOR classes.
2017-03-07 12:06:00 +00:00
const SHAPE_POLY_SET* outline = zone->Outline();
Zones are supported by POINT_EDITOR.
2014-02-28 17:24:29 +00:00
CPolyLine -> SHAPE_POLY_SET refactor. Removes the need of using the legacy code in polygon/PolyLine.{h,cpp}, refactoring all CPolyLine instances with SHAPE_POLY_SET instances. The remaining legacy methods have been ported to SHAPE_POLY_SET; mainly: Chamfer, Fillet, {,Un}Hatch. The iteration over the polygon vertices have been simplified using the family of ITERATOR classes.
2017-03-07 12:06:00 +00:00
if( m_editPoints->PointsSize() != (unsigned) outline->TotalVertices() )
"Create corner" context menu entry for draw segments and zone outlines (GAL).
2014-07-09 14:50:31 +00:00
{
getView()->Remove( m_editPoints.get() );
Point Editor: reset the pointer to the modified point as it becomes invalid Fixes: lp:1759024 * https://bugs.launchpad.net/kicad/+bug/1759024
2018-03-26 21:30:56 +00:00
m_editedPoint = nullptr;
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
m_editPoints = makePoints( item );
if( m_editPoints )
getView()->Add( m_editPoints.get() );
"Create corner" context menu entry for draw segments and zone outlines (GAL).
2014-07-09 14:50:31 +00:00
}
else
{
CPolyLine -> SHAPE_POLY_SET refactor. Removes the need of using the legacy code in polygon/PolyLine.{h,cpp}, refactoring all CPolyLine instances with SHAPE_POLY_SET instances. The remaining legacy methods have been ported to SHAPE_POLY_SET; mainly: Chamfer, Fillet, {,Un}Hatch. The iteration over the polygon vertices have been simplified using the family of ITERATOR classes.
2017-03-07 12:06:00 +00:00
for( int i = 0; i < outline->TotalVertices(); ++i )
m_editPoints->Point( i ).SetPosition( outline->CVertex( i ) );
"Create corner" context menu entry for draw segments and zone outlines (GAL).
2014-07-09 14:50:31 +00:00
}
Zones are supported by POINT_EDITOR.
2014-02-28 17:24:29 +00:00
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
break;
}
ADDED: Leader dimension object Fixes https://gitlab.com/kicad/code/kicad/-/issues/5555
2020-09-12 20:09:40 +00:00
case PCB_DIM_ALIGNED_T:
ADDED: Orthogonal dimension object
2020-09-22 02:32:40 +00:00
case PCB_DIM_ORTHOGONAL_T:
Dimensions for footprints. Fixes https://gitlab.com/kicad/code/kicad/issues/8441
2021-12-04 23:52:00 +00:00
case PCB_FP_DIM_ALIGNED_T:
case PCB_FP_DIM_ORTHOGONAL_T:
Added new constraint for EDIT_POINTs (EPC_LINE). Dimensions have EDIT_POINTs. Different handling of 45 degree mode in POINT_EDITOR.
2014-03-12 09:46:11 +00:00
{
Prefix DIMENSION types.
2021-06-11 16:59:28 +00:00
const PCB_DIM_ALIGNED* dimension = static_cast<const PCB_DIM_ALIGNED*>( item );
Added new constraint for EDIT_POINTs (EPC_LINE). Dimensions have EDIT_POINTs. Different handling of 45 degree mode in POINT_EDITOR.
2014-03-12 09:46:11 +00:00
ADDED: Leader dimension object Fixes https://gitlab.com/kicad/code/kicad/-/issues/5555
2020-09-12 20:09:40 +00:00
m_editPoints->Point( DIM_START ).SetPosition( dimension->GetStart() );
m_editPoints->Point( DIM_END ).SetPosition( dimension->GetEnd() );
m_editPoints->Point( DIM_TEXT ).SetPosition( dimension->Text().GetPosition() );
Refactor DIMENSION to hide internal details; add some new properties This is a board file format change to account for the new properties. Also, we now only store the critical information about the dimension's geometry in the board, rather than storing every drawn line. The DIMENSION object is now an abstract base, and ALIGNED_DIMENSION is the implementation that exists today (we will add more dimension types in the future)
2020-09-09 03:17:08 +00:00
m_editPoints->Point( DIM_CROSSBARSTART ).SetPosition( dimension->GetCrossbarStart() );
m_editPoints->Point( DIM_CROSSBAREND ).SetPosition( dimension->GetCrossbarEnd() );
ADDED: Leader dimension object Fixes https://gitlab.com/kicad/code/kicad/-/issues/5555
2020-09-12 20:09:40 +00:00
break;
}
ADDED: Center marker dimension type
2020-09-17 00:54:58 +00:00
case PCB_DIM_CENTER_T:
Dimensions for footprints. Fixes https://gitlab.com/kicad/code/kicad/issues/8441
2021-12-04 23:52:00 +00:00
case PCB_FP_DIM_CENTER_T:
ADDED: Center marker dimension type
2020-09-17 00:54:58 +00:00
{
Prefix DIMENSION types.
2021-06-11 16:59:28 +00:00
const PCB_DIM_CENTER* dimension = static_cast<const PCB_DIM_CENTER*>( item );
ADDED: Center marker dimension type
2020-09-17 00:54:58 +00:00
m_editPoints->Point( DIM_START ).SetPosition( dimension->GetStart() );
m_editPoints->Point( DIM_END ).SetPosition( dimension->GetEnd() );
break;
}
Radial dimensions. ADDED radial type dimensions. Fixes https://gitlab.com/kicad/code/kicad/issues/2056
2021-07-13 18:46:33 +00:00
case PCB_DIM_RADIAL_T:
Dimensions for footprints. Fixes https://gitlab.com/kicad/code/kicad/issues/8441
2021-12-04 23:52:00 +00:00
case PCB_FP_DIM_RADIAL_T:
Radial dimensions. ADDED radial type dimensions. Fixes https://gitlab.com/kicad/code/kicad/issues/2056
2021-07-13 18:46:33 +00:00
{
const PCB_DIM_RADIAL* dimension = static_cast<const PCB_DIM_RADIAL*>( item );
m_editPoints->Point( DIM_START ).SetPosition( dimension->GetStart() );
m_editPoints->Point( DIM_END ).SetPosition( dimension->GetEnd() );
m_editPoints->Point( DIM_TEXT ).SetPosition( dimension->Text().GetPosition() );
m_editPoints->Point( DIM_KNEE ).SetPosition( dimension->GetKnee() );
break;
}
ADDED: Leader dimension object Fixes https://gitlab.com/kicad/code/kicad/-/issues/5555
2020-09-12 20:09:40 +00:00
case PCB_DIM_LEADER_T:
Dimensions for footprints. Fixes https://gitlab.com/kicad/code/kicad/issues/8441
2021-12-04 23:52:00 +00:00
case PCB_FP_DIM_LEADER_T:
ADDED: Leader dimension object Fixes https://gitlab.com/kicad/code/kicad/-/issues/5555
2020-09-12 20:09:40 +00:00
{
Prefix DIMENSION types.
2021-06-11 16:59:28 +00:00
const PCB_DIM_LEADER* dimension = static_cast<const PCB_DIM_LEADER*>( item );
ADDED: Leader dimension object Fixes https://gitlab.com/kicad/code/kicad/-/issues/5555
2020-09-12 20:09:40 +00:00
Refactor DIMENSION to hide internal details; add some new properties This is a board file format change to account for the new properties. Also, we now only store the critical information about the dimension's geometry in the board, rather than storing every drawn line. The DIMENSION object is now an abstract base, and ALIGNED_DIMENSION is the implementation that exists today (we will add more dimension types in the future)
2020-09-09 03:17:08 +00:00
m_editPoints->Point( DIM_START ).SetPosition( dimension->GetStart() );
m_editPoints->Point( DIM_END ).SetPosition( dimension->GetEnd() );
Implement new dimension properties - Automatic units mode (follow UI units) - New text and number formatting options - Automatic/manual text orientation control - New text positioning options (inline and manual) Fixes https://gitlab.com/kicad/code/kicad/-/issues/4280 Fixes https://gitlab.com/kicad/code/kicad/-/issues/4497
2020-09-11 23:52:45 +00:00
m_editPoints->Point( DIM_TEXT ).SetPosition( dimension->Text().GetPosition() );
Added new constraint for EDIT_POINTs (EPC_LINE). Dimensions have EDIT_POINTs. Different handling of 45 degree mode in POINT_EDITOR.
2014-03-12 09:46:11 +00:00
break;
}
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
default:
break;
}
Modified tools to use BOARD_COMMIT.
2016-06-21 15:06:28 +00:00
Refactoring of VIEW/VIEW_ITEM classes: - Remove dependency of EDA_ITEM on VIEW - VIEW_ITEM is now a pure virtual interface
2016-12-02 17:58:12 +00:00
getView()->Update( m_editPoints.get() );
Initial version of POINT_EDITOR.
2014-02-27 16:29:08 +00:00
}
Added EDIT_LINEs for dragging zone outlines.
2014-03-06 16:34:04 +00:00
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
void PCB_POINT_EDITOR::setEditedPoint( EDIT_POINT* aPoint )
Remove a corner from zone outline function (GAL).
2015-06-19 15:32:33 +00:00
{
KIGFX::VIEW_CONTROLS* controls = getViewControls();
if( aPoint )
{
Implement more context specific cursors using both stock and custom cursors.
2020-10-08 00:50:28 +00:00
frame()->GetCanvas()->SetCurrentCursor( KICURSOR::ARROW );
Remove a corner from zone outline function (GAL).
2015-06-19 15:32:33 +00:00
controls->ForceCursorPosition( true, aPoint->GetPosition() );
controls->ShowCursor( true );
}
else
{
Try out a new arc-editing paradigm for LibEdit. This is based on the notion that in Kicad the start and end-points are far more important (as they usually connect to other segments) than the center is.
2019-06-29 13:39:46 +00:00
if( frame()->ToolStackIsEmpty() )
controls->ShowCursor( false );
Remove a corner from zone outline function (GAL).
2015-06-19 15:32:33 +00:00
controls->ForceCursorPosition( false );
}
m_editedPoint = aPoint;
}
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
void PCB_POINT_EDITOR::setAltConstraint( bool aEnabled )
Added EC_CONVERGING for zone areas modification.
2014-03-14 14:37:55 +00:00
{
if( aEnabled )
{
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
EDA_ITEM* parent = m_editPoints->GetParent();
Remove a corner from zone outline function (GAL).
2015-06-19 15:32:33 +00:00
EDIT_LINE* line = dynamic_cast<EDIT_LINE*>( m_editedPoint );
Fix some cases where PCB_FP_ZONE_T was left out. Fixes https://gitlab.com/kicad/code/kicad/issues/7615
2021-03-08 12:57:33 +00:00
bool isPoly;
ADDED: Improved center point dragging The center point on polygons now maintains the axis of the dragged line and, optionally with Ctrl pressed, maintains the slope of the adjacent segments as well. This also fixes a longstanding issue that prevented the ctrl-snapping from using the original point rather than the last updated point when constraining. Fixes https://gitlab.com/kicad/code/kicad/issues/2465
2020-08-27 17:31:53 +00:00
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
switch( parent->Type() )
PCB_LINE_T -> PCB_SHAPE_T and PCB_MODULE_EDGE_T -> PCB_FP_SHAPE_T Also updated footprint text and zone types for consistencey.
2020-10-04 14:19:33 +00:00
{
Fix some cases where PCB_FP_ZONE_T was left out. Fixes https://gitlab.com/kicad/code/kicad/issues/7615
2021-03-08 12:57:33 +00:00
case PCB_ZONE_T:
case PCB_FP_ZONE_T:
ADDED: Improved center point dragging The center point on polygons now maintains the axis of the dragged line and, optionally with Ctrl pressed, maintains the slope of the adjacent segments as well. This also fixes a longstanding issue that prevented the ctrl-snapping from using the original point rather than the last updated point when constraining. Fixes https://gitlab.com/kicad/code/kicad/issues/2465
2020-08-27 17:31:53 +00:00
isPoly = true;
Fix some cases where PCB_FP_ZONE_T was left out. Fixes https://gitlab.com/kicad/code/kicad/issues/7615
2021-03-08 12:57:33 +00:00
break;
ADDED: Improved center point dragging The center point on polygons now maintains the axis of the dragged line and, optionally with Ctrl pressed, maintains the slope of the adjacent segments as well. This also fixes a longstanding issue that prevented the ctrl-snapping from using the original point rather than the last updated point when constraining. Fixes https://gitlab.com/kicad/code/kicad/issues/2465
2020-08-27 17:31:53 +00:00
Fix some cases where PCB_FP_ZONE_T was left out. Fixes https://gitlab.com/kicad/code/kicad/issues/7615
2021-03-08 12:57:33 +00:00
case PCB_SHAPE_T:
case PCB_FP_SHAPE_T:
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
isPoly = static_cast<PCB_SHAPE*>( parent )->GetShape() == SHAPE_T::POLY;
Fix some cases where PCB_FP_ZONE_T was left out. Fixes https://gitlab.com/kicad/code/kicad/issues/7615
2021-03-08 12:57:33 +00:00
break;
default:
isPoly = false;
break;
ADDED: Improved center point dragging The center point on polygons now maintains the axis of the dragged line and, optionally with Ctrl pressed, maintains the slope of the adjacent segments as well. This also fixes a longstanding issue that prevented the ctrl-snapping from using the original point rather than the last updated point when constraining. Fixes https://gitlab.com/kicad/code/kicad/issues/2465
2020-08-27 17:31:53 +00:00
}
Refactoring EDIT_POINTS, part 3: constraints split to EDIT_POINTs and EDIT_LINEs.
2014-04-02 07:31:35 +00:00
ADDED: Improved center point dragging The center point on polygons now maintains the axis of the dragged line and, optionally with Ctrl pressed, maintains the slope of the adjacent segments as well. This also fixes a longstanding issue that prevented the ctrl-snapping from using the original point rather than the last updated point when constraining. Fixes https://gitlab.com/kicad/code/kicad/issues/2465
2020-08-27 17:31:53 +00:00
if( line && isPoly )
Added EC_CONVERGING for zone areas modification.
2014-03-14 14:37:55 +00:00
{
Don't offer point-based pad editing in PCBNew.
2020-12-19 15:16:14 +00:00
EC_CONVERGING* altConstraint = new EC_CONVERGING( *line, *m_editPoints );
m_altConstraint.reset( (EDIT_CONSTRAINT<EDIT_POINT>*) altConstraint );
Added EC_CONVERGING for zone areas modification.
2014-03-14 14:37:55 +00:00
}
else
{
// Find a proper constraining point for 45 degrees mode
m_altConstrainer = get45DegConstrainer();
Remove a corner from zone outline function (GAL).
2015-06-19 15:32:33 +00:00
m_altConstraint.reset( new EC_45DEGREE( *m_editedPoint, m_altConstrainer ) );
Added EC_CONVERGING for zone areas modification.
2014-03-14 14:37:55 +00:00
}
}
else
{
m_altConstraint.reset();
}
}
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
EDIT_POINT PCB_POINT_EDITOR::get45DegConstrainer() const
Added EDIT_LINEs for dragging zone outlines.
2014-03-06 16:34:04 +00:00
{
EDA_ITEM* item = m_editPoints->GetParent();
Yet another approach to 45 degree constraints.
2014-03-13 10:48:19 +00:00
switch( item->Type() )
{
PCB_LINE_T -> PCB_SHAPE_T and PCB_MODULE_EDGE_T -> PCB_FP_SHAPE_T Also updated footprint text and zone types for consistencey.
2020-10-04 14:19:33 +00:00
case PCB_SHAPE_T:
case PCB_FP_SHAPE_T:
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
switch( static_cast<const PCB_SHAPE*>( item )->GetShape() )
Added EDIT_LINEs for dragging zone outlines.
2014-03-06 16:34:04 +00:00
{
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
case SHAPE_T::SEGMENT:
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
return *( m_editPoints->Next( *m_editedPoint ) ); // select the other end of line
Added EDIT_LINEs for dragging zone outlines.
2014-03-06 16:34:04 +00:00
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
case SHAPE_T::ARC:
case SHAPE_T::CIRCLE:
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
return m_editPoints->Point( CIRC_CENTER );
Added EDIT_LINEs for dragging zone outlines.
2014-03-06 16:34:04 +00:00
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
default: // suppress warnings
break;
Added EDIT_LINEs for dragging zone outlines.
2014-03-06 16:34:04 +00:00
}
Yet another approach to 45 degree constraints.
2014-03-13 10:48:19 +00:00
break;
ADDED: Leader dimension object Fixes https://gitlab.com/kicad/code/kicad/-/issues/5555
2020-09-12 20:09:40 +00:00
case PCB_DIM_ALIGNED_T:
Dimensions for footprints. Fixes https://gitlab.com/kicad/code/kicad/issues/8441
2021-12-04 23:52:00 +00:00
case PCB_FP_DIM_ALIGNED_T:
Added new constraint for EDIT_POINTs (EPC_LINE). Dimensions have EDIT_POINTs. Different handling of 45 degree mode in POINT_EDITOR.
2014-03-12 09:46:11 +00:00
{
// Constraint for crossbar
Refactor DIMENSION to hide internal details; add some new properties This is a board file format change to account for the new properties. Also, we now only store the critical information about the dimension's geometry in the board, rather than storing every drawn line. The DIMENSION object is now an abstract base, and ALIGNED_DIMENSION is the implementation that exists today (we will add more dimension types in the future)
2020-09-09 03:17:08 +00:00
if( isModified( m_editPoints->Point( DIM_START ) ) )
return m_editPoints->Point( DIM_END );
Switched order of EDIT_POINTs for DIMENSION, so in case when feature lines are of 0 length, then still can be stretched.
2014-03-12 09:53:42 +00:00
Refactor DIMENSION to hide internal details; add some new properties This is a board file format change to account for the new properties. Also, we now only store the critical information about the dimension's geometry in the board, rather than storing every drawn line. The DIMENSION object is now an abstract base, and ALIGNED_DIMENSION is the implementation that exists today (we will add more dimension types in the future)
2020-09-09 03:17:08 +00:00
else if( isModified( m_editPoints->Point( DIM_END ) ) )
return m_editPoints->Point( DIM_START );
Yet another approach to 45 degree constraints.
2014-03-13 10:48:19 +00:00
else
Remove a corner from zone outline function (GAL).
2015-06-19 15:32:33 +00:00
return EDIT_POINT( m_editedPoint->GetPosition() ); // no constraint
Yet another approach to 45 degree constraints.
2014-03-13 10:48:19 +00:00
break;
}
ADDED: Center marker dimension type
2020-09-17 00:54:58 +00:00
case PCB_DIM_CENTER_T:
Dimensions for footprints. Fixes https://gitlab.com/kicad/code/kicad/issues/8441
2021-12-04 23:52:00 +00:00
case PCB_FP_DIM_CENTER_T:
ADDED: Center marker dimension type
2020-09-17 00:54:58 +00:00
{
if( isModified( m_editPoints->Point( DIM_END ) ) )
return m_editPoints->Point( DIM_START );
break;
}
Radial dimensions. ADDED radial type dimensions. Fixes https://gitlab.com/kicad/code/kicad/issues/2056
2021-07-13 18:46:33 +00:00
case PCB_DIM_RADIAL_T:
Dimensions for footprints. Fixes https://gitlab.com/kicad/code/kicad/issues/8441
2021-12-04 23:52:00 +00:00
case PCB_FP_DIM_RADIAL_T:
Radial dimensions. ADDED radial type dimensions. Fixes https://gitlab.com/kicad/code/kicad/issues/2056
2021-07-13 18:46:33 +00:00
{
if( isModified( m_editPoints->Point( DIM_TEXT ) ) )
return m_editPoints->Point( DIM_KNEE );
break;
}
Yet another approach to 45 degree constraints.
2014-03-13 10:48:19 +00:00
default:
break;
Added new constraint for EDIT_POINTs (EPC_LINE). Dimensions have EDIT_POINTs. Different handling of 45 degree mode in POINT_EDITOR.
2014-03-12 09:46:11 +00:00
}
Added EDIT_LINEs for dragging zone outlines.
2014-03-06 16:34:04 +00:00
Templated EDIT_POINT_CONSTRAINT. Removed EDIT_CONSTRAINT::Update() - replaced with resetting constraints. EDIT_CONSTRAINT is stored in EDIT_POIN using boost::shared_ptr instead of pointer. Added EDIT_LINE::GetEnd() & GetOrigin(). Overridden ApplyConstraint() for EDIT_LINE. Side EDIT_POINTS for zones are drawn as circles.
2014-03-14 14:15:38 +00:00
// In any other case we may align item to its original position
Yet another approach to 45 degree constraints.
2014-03-13 10:48:19 +00:00
return m_original;
Added EDIT_LINEs for dragging zone outlines.
2014-03-06 16:34:04 +00:00
}
Breaking outlines for zones using POINT_EDITOR.
2014-03-18 13:52:22 +00:00
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
bool PCB_POINT_EDITOR::canAddCorner( const EDA_ITEM& aItem )
Add hotkey (Insert) for zone create corner Adds a hotkey to the TOOL_ACTION, and also checks for action validity prior to running the actions (previously implicitly gated by the enablement of the menu item).
2018-07-24 15:15:05 +00:00
{
const auto type = aItem.Type();
// Works only for zones and line segments
Update some classnames including archaic zone names.
2020-11-11 23:05:59 +00:00
if( type == PCB_ZONE_T || type == PCB_FP_ZONE_T )
PCB_LINE_T -> PCB_SHAPE_T and PCB_MODULE_EDGE_T -> PCB_FP_SHAPE_T Also updated footprint text and zone types for consistencey.
2020-10-04 14:19:33 +00:00
return true;
if( type == PCB_SHAPE_T || type == PCB_FP_SHAPE_T )
{
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
const PCB_SHAPE& shape = static_cast<const PCB_SHAPE&>( aItem );
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
return shape.GetShape() == SHAPE_T::SEGMENT || shape.GetShape() == SHAPE_T::POLY;
PCB_LINE_T -> PCB_SHAPE_T and PCB_MODULE_EDGE_T -> PCB_FP_SHAPE_T Also updated footprint text and zone types for consistencey.
2020-10-04 14:19:33 +00:00
}
return false;
Add hotkey (Insert) for zone create corner Adds a hotkey to the TOOL_ACTION, and also checks for action validity prior to running the actions (previously implicitly gated by the enablement of the menu item).
2018-07-24 15:15:05 +00:00
}
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
bool PCB_POINT_EDITOR::addCornerCondition( const SELECTION& aSelection )
TOOL_ACTIONs are handled with transitions, no handlers needed in the event loops There used to be a number of TOOL_ACTIONs that had entries both in SetTransitions() and the event loop, which seemed redundant and troublesome. Now it is not necessary anymore, transitions setup is enough to execute associated actions.
2017-01-18 08:04:11 +00:00
{
if( aSelection.Size() != 1 )
return false;
Add hotkey (Insert) for zone create corner Adds a hotkey to the TOOL_ACTION, and also checks for action validity prior to running the actions (previously implicitly gated by the enablement of the menu item).
2018-07-24 15:15:05 +00:00
const EDA_ITEM* item = aSelection.Front();
TOOL_ACTIONs are handled with transitions, no handlers needed in the event loops There used to be a number of TOOL_ACTIONs that had entries both in SetTransitions() and the event loop, which seemed redundant and troublesome. Now it is not necessary anymore, transitions setup is enough to execute associated actions.
2017-01-18 08:04:11 +00:00
Add hotkey (Insert) for zone create corner Adds a hotkey to the TOOL_ACTION, and also checks for action validity prior to running the actions (previously implicitly gated by the enablement of the menu item).
2018-07-24 15:15:05 +00:00
return ( item != nullptr ) && canAddCorner( *item );
TOOL_ACTIONs are handled with transitions, no handlers needed in the event loops There used to be a number of TOOL_ACTIONs that had entries both in SetTransitions() and the event loop, which seemed redundant and troublesome. Now it is not necessary anymore, transitions setup is enough to execute associated actions.
2017-01-18 08:04:11 +00:00
}
Fix segfault when removing the last corner of a cutout Fixes: lp:1736147 * https://bugs.launchpad.net/kicad/+bug/1736147
2017-12-06 14:51:47 +00:00
// Finds a corresponding vertex in a polygon set
static std::pair<bool, SHAPE_POLY_SET::VERTEX_INDEX>
findVertex( SHAPE_POLY_SET& aPolySet, const EDIT_POINT& aPoint )
{
for( auto it = aPolySet.IterateWithHoles(); it; ++it )
{
auto vertexIdx = it.GetIndex();
SHAPE_LINE_CHAIN: Remove element access This is the first step to allowing non-segments in the line chain. External routines cannot be allowed to change the line chain without going through the internal routines. To accomplish this, we remove the Vertex() and Point() access routines and only leave the const versions. Transformations are given for both points as well as the chain itself.
2019-03-23 18:26:44 +00:00
if( aPolySet.CVertex( vertexIdx ) == aPoint.GetPosition() )
Fix segfault when removing the last corner of a cutout Fixes: lp:1736147 * https://bugs.launchpad.net/kicad/+bug/1736147
2017-12-06 14:51:47 +00:00
return std::make_pair( true, vertexIdx );
}
return std::make_pair( false, SHAPE_POLY_SET::VERTEX_INDEX() );
}
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
bool PCB_POINT_EDITOR::removeCornerCondition( const SELECTION& )
TOOL_ACTIONs are handled with transitions, no handlers needed in the event loops There used to be a number of TOOL_ACTIONs that had entries both in SetTransitions() and the event loop, which seemed redundant and troublesome. Now it is not necessary anymore, transitions setup is enough to execute associated actions.
2017-01-18 08:04:11 +00:00
{
Fix segfault when removing the last corner of a cutout Fixes: lp:1736147 * https://bugs.launchpad.net/kicad/+bug/1736147
2017-12-06 14:51:47 +00:00
if( !m_editPoints || !m_editedPoint )
TOOL_ACTIONs are handled with transitions, no handlers needed in the event loops There used to be a number of TOOL_ACTIONs that had entries both in SetTransitions() and the event loop, which seemed redundant and troublesome. Now it is not necessary anymore, transitions setup is enough to execute associated actions.
2017-01-18 08:04:11 +00:00
return false;
Fix some cases where PCB_FP_ZONE_T was left out. Fixes https://gitlab.com/kicad/code/kicad/issues/7615
2021-03-08 12:57:33 +00:00
EDA_ITEM* item = m_editPoints->GetParent();
SHAPE_POLY_SET* polyset = nullptr;
TOOL_ACTIONs are handled with transitions, no handlers needed in the event loops There used to be a number of TOOL_ACTIONs that had entries both in SetTransitions() and the event loop, which seemed redundant and troublesome. Now it is not necessary anymore, transitions setup is enough to execute associated actions.
2017-01-18 08:04:11 +00:00
PCB_LINE_T -> PCB_SHAPE_T and PCB_MODULE_EDGE_T -> PCB_FP_SHAPE_T Also updated footprint text and zone types for consistencey.
2020-10-04 14:19:33 +00:00
if( !item )
return false;
Fix some cases where PCB_FP_ZONE_T was left out. Fixes https://gitlab.com/kicad/code/kicad/issues/7615
2021-03-08 12:57:33 +00:00
switch( item->Type() )
Go back to previous arc midpoint editing routine. It avoids erratic behaviour near the chord or end-points. Fixes https://gitlab.com/kicad/code/kicad/issues/7135
2021-01-19 23:07:31 +00:00
{
Fix some cases where PCB_FP_ZONE_T was left out. Fixes https://gitlab.com/kicad/code/kicad/issues/7615
2021-03-08 12:57:33 +00:00
case PCB_ZONE_T:
case PCB_FP_ZONE_T:
polyset = static_cast<ZONE*>( item )->Outline();
break;
TOOL_ACTIONs are handled with transitions, no handlers needed in the event loops There used to be a number of TOOL_ACTIONs that had entries both in SetTransitions() and the event loop, which seemed redundant and troublesome. Now it is not necessary anymore, transitions setup is enough to execute associated actions.
2017-01-18 08:04:11 +00:00
Fix some cases where PCB_FP_ZONE_T was left out. Fixes https://gitlab.com/kicad/code/kicad/issues/7615
2021-03-08 12:57:33 +00:00
case PCB_SHAPE_T:
case PCB_FP_SHAPE_T:
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
if( static_cast<PCB_SHAPE*>( item )->GetShape() == SHAPE_T::POLY )
Fix some cases where PCB_FP_ZONE_T was left out. Fixes https://gitlab.com/kicad/code/kicad/issues/7615
2021-03-08 12:57:33 +00:00
polyset = &static_cast<PCB_SHAPE*>( item )->GetPolyShape();
else
return false;
pcbnew: Allow removing corners from graphical polygons ( cherry-picked from 22df4e301 ) Fixes: lp:1792712 * https://bugs.launchpad.net/kicad/+bug/1792712
2018-09-16 17:20:53 +00:00
Fix some cases where PCB_FP_ZONE_T was left out. Fixes https://gitlab.com/kicad/code/kicad/issues/7615
2021-03-08 12:57:33 +00:00
break;
default:
return false;
}
pcbnew: Allow removing corners from graphical polygons ( cherry-picked from 22df4e301 ) Fixes: lp:1792712 * https://bugs.launchpad.net/kicad/+bug/1792712
2018-09-16 17:20:53 +00:00
Formatting.
2022-06-01 22:55:59 +00:00
std::pair<bool, SHAPE_POLY_SET::VERTEX_INDEX> vertex = findVertex( *polyset, *m_editedPoint );
Fix segfault when removing the last corner of a cutout Fixes: lp:1736147 * https://bugs.launchpad.net/kicad/+bug/1736147
2017-12-06 14:51:47 +00:00
if( !vertex.first )
return false;
Formatting.
2022-06-01 22:55:59 +00:00
const SHAPE_POLY_SET::VERTEX_INDEX& vertexIdx = vertex.second;
TOOL_ACTIONs are handled with transitions, no handlers needed in the event loops There used to be a number of TOOL_ACTIONs that had entries both in SetTransitions() and the event loop, which seemed redundant and troublesome. Now it is not necessary anymore, transitions setup is enough to execute associated actions.
2017-01-18 08:04:11 +00:00
Fix segfault when removing the last corner of a cutout Fixes: lp:1736147 * https://bugs.launchpad.net/kicad/+bug/1736147
2017-12-06 14:51:47 +00:00
// Check if there are enough vertices so one can be removed without
// degenerating the polygon.
fix misspelled 'allows to' -> 'allows one to' Fixup small grammar issues around used 'allows to ...' almost in code comments.
2018-07-08 12:12:38 +00:00
// The first condition allows one to remove all corners from holes (when
// there are only 2 vertices left, a hole is removed).
More NULL expunging.
2021-07-19 23:56:05 +00:00
if( vertexIdx.m_contour == 0 &&
polyset->Polygon( vertexIdx.m_polygon )[vertexIdx.m_contour].PointCount() <= 3 )
Formatting.
2022-06-01 22:55:59 +00:00
{
TOOL_ACTIONs are handled with transitions, no handlers needed in the event loops There used to be a number of TOOL_ACTIONs that had entries both in SetTransitions() and the event loop, which seemed redundant and troublesome. Now it is not necessary anymore, transitions setup is enough to execute associated actions.
2017-01-18 08:04:11 +00:00
return false;
Formatting.
2022-06-01 22:55:59 +00:00
}
TOOL_ACTIONs are handled with transitions, no handlers needed in the event loops There used to be a number of TOOL_ACTIONs that had entries both in SetTransitions() and the event loop, which seemed redundant and troublesome. Now it is not necessary anymore, transitions setup is enough to execute associated actions.
2017-01-18 08:04:11 +00:00
// Remove corner does not work with lines
if( dynamic_cast<EDIT_LINE*>( m_editedPoint ) )
return false;
More NULL expunging.
2021-07-19 23:56:05 +00:00
return m_editedPoint != nullptr;
TOOL_ACTIONs are handled with transitions, no handlers needed in the event loops There used to be a number of TOOL_ACTIONs that had entries both in SetTransitions() and the event loop, which seemed redundant and troublesome. Now it is not necessary anymore, transitions setup is enough to execute associated actions.
2017-01-18 08:04:11 +00:00
}
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
int PCB_POINT_EDITOR::addCorner( const TOOL_EVENT& aEvent )
Breaking outlines for zones using POINT_EDITOR.
2014-03-18 13:52:22 +00:00
{
Add hotkey (Insert) for zone create corner Adds a hotkey to the TOOL_ACTION, and also checks for action validity prior to running the actions (previously implicitly gated by the enablement of the menu item).
2018-07-24 15:15:05 +00:00
if( !m_editPoints )
return 0;
Formatting.
2022-06-01 22:55:59 +00:00
EDA_ITEM* item = m_editPoints->GetParent();
Removed a number 'if(m_editModules)' sections from pcbnew tools.
2016-06-08 09:24:46 +00:00
PCB_BASE_EDIT_FRAME* frame = getEditFrame<PCB_BASE_EDIT_FRAME>();
Formatting.
2022-06-01 22:55:59 +00:00
const VECTOR2I& cursorPos = getViewControls()->GetCursorPosition();
Add hotkey (Insert) for zone create corner Adds a hotkey to the TOOL_ACTION, and also checks for action validity prior to running the actions (previously implicitly gated by the enablement of the menu item).
2018-07-24 15:15:05 +00:00
// called without an active edited polygon
if( !item || !canAddCorner( *item ) )
return 0;
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
PCB_SHAPE* graphicItem = dynamic_cast<PCB_SHAPE*>( item );
Modified tools to use BOARD_COMMIT.
2016-06-21 15:06:28 +00:00
BOARD_COMMIT commit( frame );
Breaking outlines for zones using POINT_EDITOR.
2014-03-18 13:52:22 +00:00
Update some classnames including archaic zone names.
2020-11-11 23:05:59 +00:00
if( item->Type() == PCB_ZONE_T || item->Type() == PCB_FP_ZONE_T
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
|| ( graphicItem && graphicItem->GetShape() == SHAPE_T::POLY ) )
pcbnew: Add corners in polygons Allow corner adding to polygons in both module editor and board editor. The board editor was already allowed but only through special types. The module editor is now sychronized to the same process and both recognize standard context menus Fixes: lp:1782966 * https://bugs.launchpad.net/kicad/+bug/1782966 ( cherry-picked from 06ac172c2 )
2018-09-15 16:51:35 +00:00
{
Temporary fix of broken command add corner to zone in GAL mode. Fixes: lp:1680339 https://bugs.launchpad.net/kicad/+bug/1680339
2017-04-06 17:04:47 +00:00
unsigned int nearestIdx = 0;
unsigned int nextNearestIdx = 0;
unsigned int nearestDist = INT_MAX;
finishing work started in commit ba37d6fca35b67fc04a21aa111aba97c80c3a1b0: Command add corner to zone in GAL mode: fix corner cases (existing when a zone has holes). (Well, "corner case" is the right word: I can't resist)
2017-04-14 12:38:59 +00:00
unsigned int firstPointInContour = 0;
pcbnew: Add corners in polygons Allow corner adding to polygons in both module editor and board editor. The board editor was already allowed but only through special types. The module editor is now sychronized to the same process and both recognize standard context menus Fixes: lp:1782966 * https://bugs.launchpad.net/kicad/+bug/1782966 ( cherry-picked from 06ac172c2 )
2018-09-15 16:51:35 +00:00
SHAPE_POLY_SET* zoneOutline;
Update some classnames including archaic zone names.
2020-11-11 23:05:59 +00:00
if( item->Type() == PCB_ZONE_T || item->Type() == PCB_FP_ZONE_T )
Pcbnew, Zone refill: avoid useless refilling, when zone parameters are not modified. Previously, in many cases the selected zone was refilled on exit selection, even if the zone was not modified. This is annoying, because the zone fill can be really time consuming, and cannot be called without a good reason. Now the refilling is made only if a zone parameter is actually modified.
2019-03-14 13:35:55 +00:00
{
Update some classnames including archaic zone names.
2020-11-11 23:05:59 +00:00
ZONE* zone = static_cast<ZONE*>( item );
Pcbnew, Zone refill: avoid useless refilling, when zone parameters are not modified. Previously, in many cases the selected zone was refilled on exit selection, even if the zone was not modified. This is annoying, because the zone fill can be really time consuming, and cannot be called without a good reason. Now the refilling is made only if a zone parameter is actually modified.
2019-03-14 13:35:55 +00:00
zoneOutline = zone->Outline();
zone->SetNeedRefill( true );
}
pcbnew: Fix polygon corner adding in board editor Polygon corners were enabled in the footprint editor but the logic didn't extend to the board editor. This revises the logic to look for DRAWSEGMENTs and only reference the PCB_MODULE_EDGE_T where needed to create a new segment in the footprint. Fixes: lp:1782966 * https://bugs.launchpad.net/kicad/+bug/1782966
2018-10-01 11:15:12 +00:00
else
Formatting.
2022-06-01 22:55:59 +00:00
{
pcbnew: Fix polygon corner adding in board editor Polygon corners were enabled in the footprint editor but the logic didn't extend to the board editor. This revises the logic to look for DRAWSEGMENTs and only reference the PCB_MODULE_EDGE_T where needed to create a new segment in the footprint. Fixes: lp:1782966 * https://bugs.launchpad.net/kicad/+bug/1782966
2018-10-01 11:15:12 +00:00
zoneOutline = &( graphicItem->GetPolyShape() );
Formatting.
2022-06-01 22:55:59 +00:00
}
pcbnew: Add corners in polygons Allow corner adding to polygons in both module editor and board editor. The board editor was already allowed but only through special types. The module editor is now sychronized to the same process and both recognize standard context menus Fixes: lp:1782966 * https://bugs.launchpad.net/kicad/+bug/1782966 ( cherry-picked from 06ac172c2 )
2018-09-15 16:51:35 +00:00
commit.Modify( item );
Breaking outlines for zones using POINT_EDITOR.
2014-03-18 13:52:22 +00:00
finishing work started in commit ba37d6fca35b67fc04a21aa111aba97c80c3a1b0: Command add corner to zone in GAL mode: fix corner cases (existing when a zone has holes). (Well, "corner case" is the right word: I can't resist)
2017-04-14 12:38:59 +00:00
// Search the best outline segment to add a new corner
// and therefore break this segment into two segments
// Object to iterate through the corners of the outlines (main contour and its holes)
Go back to previous arc midpoint editing routine. It avoids erratic behaviour near the chord or end-points. Fixes https://gitlab.com/kicad/code/kicad/issues/7135
2021-01-19 23:07:31 +00:00
SHAPE_POLY_SET::ITERATOR iterator = zoneOutline->Iterate( 0, zoneOutline->OutlineCount()-1,
/* IterateHoles */ true );
finishing work started in commit ba37d6fca35b67fc04a21aa111aba97c80c3a1b0: Command add corner to zone in GAL mode: fix corner cases (existing when a zone has holes). (Well, "corner case" is the right word: I can't resist)
2017-04-14 12:38:59 +00:00
int curr_idx = 0;
// Iterate through all the corners of the outlines and search the best segment
for( ; iterator; iterator++, curr_idx++ )
Breaking outlines for zones using POINT_EDITOR.
2014-03-18 13:52:22 +00:00
{
finishing work started in commit ba37d6fca35b67fc04a21aa111aba97c80c3a1b0: Command add corner to zone in GAL mode: fix corner cases (existing when a zone has holes). (Well, "corner case" is the right word: I can't resist)
2017-04-14 12:38:59 +00:00
int jj = curr_idx+1;
Temporary fix of broken command add corner to zone in GAL mode. Fixes: lp:1680339 https://bugs.launchpad.net/kicad/+bug/1680339
2017-04-06 17:04:47 +00:00
finishing work started in commit ba37d6fca35b67fc04a21aa111aba97c80c3a1b0: Command add corner to zone in GAL mode: fix corner cases (existing when a zone has holes). (Well, "corner case" is the right word: I can't resist)
2017-04-14 12:38:59 +00:00
if( iterator.IsEndContour() )
{ // We reach the last point of the current contour (main or hole)
jj = firstPointInContour;
firstPointInContour = curr_idx+1; // Prepare next contour analysis
}
Temporary fix of broken command add corner to zone in GAL mode. Fixes: lp:1680339 https://bugs.launchpad.net/kicad/+bug/1680339
2017-04-06 17:04:47 +00:00
SHAPE_LINE_CHAIN: Remove element access This is the first step to allowing non-segments in the line chain. External routines cannot be allowed to change the line chain without going through the internal routines. To accomplish this, we remove the Vertex() and Point() access routines and only leave the const versions. Transformations are given for both points as well as the chain itself.
2019-03-23 18:26:44 +00:00
SEG curr_segment( zoneOutline->CVertex( curr_idx ), zoneOutline->CVertex( jj ) );
Breaking outlines for zones using POINT_EDITOR.
2014-03-18 13:52:22 +00:00
finishing work started in commit ba37d6fca35b67fc04a21aa111aba97c80c3a1b0: Command add corner to zone in GAL mode: fix corner cases (existing when a zone has holes). (Well, "corner case" is the right word: I can't resist)
2017-04-14 12:38:59 +00:00
unsigned int distance = curr_segment.Distance( cursorPos );
Temporary fix of broken command add corner to zone in GAL mode. Fixes: lp:1680339 https://bugs.launchpad.net/kicad/+bug/1680339
2017-04-06 17:04:47 +00:00
Breaking outlines for zones using POINT_EDITOR.
2014-03-18 13:52:22 +00:00
if( distance < nearestDist )
{
nearestDist = distance;
finishing work started in commit ba37d6fca35b67fc04a21aa111aba97c80c3a1b0: Command add corner to zone in GAL mode: fix corner cases (existing when a zone has holes). (Well, "corner case" is the right word: I can't resist)
2017-04-14 12:38:59 +00:00
nearestIdx = curr_idx;
nextNearestIdx = jj;
Breaking outlines for zones using POINT_EDITOR.
2014-03-18 13:52:22 +00:00
}
}
// Find the point on the closest segment
Formatting.
2022-06-01 22:55:59 +00:00
const VECTOR2I& sideOrigin = zoneOutline->CVertex( nearestIdx );
const VECTOR2I& sideEnd = zoneOutline->CVertex( nextNearestIdx );
SEG nearestSide( sideOrigin, sideEnd );
VECTOR2I nearestPoint = nearestSide.NearestPoint( cursorPos );
Breaking outlines for zones using POINT_EDITOR.
2014-03-18 13:52:22 +00:00
Break points for zones are not added in the same place as existing points.
2014-03-18 16:02:10 +00:00
// Do not add points that have the same coordinates as ones that already belong to polygon
// instead, add a point in the middle of the side
if( nearestPoint == sideOrigin || nearestPoint == sideEnd )
nearestPoint = ( sideOrigin + sideEnd ) / 2;
finishing work started in commit ba37d6fca35b67fc04a21aa111aba97c80c3a1b0: Command add corner to zone in GAL mode: fix corner cases (existing when a zone has holes). (Well, "corner case" is the right word: I can't resist)
2017-04-14 12:38:59 +00:00
zoneOutline->InsertVertex( nextNearestIdx, nearestPoint );
pcbnew: Add corners in polygons Allow corner adding to polygons in both module editor and board editor. The board editor was already allowed but only through special types. The module editor is now sychronized to the same process and both recognize standard context menus Fixes: lp:1782966 * https://bugs.launchpad.net/kicad/+bug/1782966 ( cherry-picked from 06ac172c2 )
2018-09-15 16:51:35 +00:00
pcbnew: Fix polygon corner adding in board editor Polygon corners were enabled in the footprint editor but the logic didn't extend to the board editor. This revises the logic to look for DRAWSEGMENTs and only reference the PCB_MODULE_EDGE_T where needed to create a new segment in the footprint. Fixes: lp:1782966 * https://bugs.launchpad.net/kicad/+bug/1782966
2018-10-01 11:15:12 +00:00
// We re-hatch the filled zones but not polygons
Update some classnames including archaic zone names.
2020-11-11 23:05:59 +00:00
if( item->Type() == PCB_ZONE_T || item->Type() == PCB_FP_ZONE_T )
static_cast<ZONE*>( item )->HatchBorder();
pcbnew: Add corners in polygons Allow corner adding to polygons in both module editor and board editor. The board editor was already allowed but only through special types. The module editor is now sychronized to the same process and both recognize standard context menus Fixes: lp:1782966 * https://bugs.launchpad.net/kicad/+bug/1782966 ( cherry-picked from 06ac172c2 )
2018-09-15 16:51:35 +00:00
Modified tools to use BOARD_COMMIT.
2016-06-21 15:06:28 +00:00
commit.Push( _( "Add a zone corner" ) );
Breaking outlines for zones using POINT_EDITOR.
2014-03-18 13:52:22 +00:00
}
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
else if( graphicItem && graphicItem->GetShape() == SHAPE_T::SEGMENT )
Splitting DRAWSEGMENTs with POINT_EDITOR.
2014-03-18 14:46:38 +00:00
{
pcbnew: Fix polygon corner adding in board editor Polygon corners were enabled in the footprint editor but the logic didn't extend to the board editor. This revises the logic to look for DRAWSEGMENTs and only reference the PCB_MODULE_EDGE_T where needed to create a new segment in the footprint. Fixes: lp:1782966 * https://bugs.launchpad.net/kicad/+bug/1782966
2018-10-01 11:15:12 +00:00
commit.Modify( graphicItem );
Splitting DRAWSEGMENTs with POINT_EDITOR.
2014-03-18 14:46:38 +00:00
Formatting.
2022-06-01 22:55:59 +00:00
SEG seg( graphicItem->GetStart(), graphicItem->GetEnd() );
pcbnew: Fix polygon corner adding in board editor Polygon corners were enabled in the footprint editor but the logic didn't extend to the board editor. This revises the logic to look for DRAWSEGMENTs and only reference the PCB_MODULE_EDGE_T where needed to create a new segment in the footprint. Fixes: lp:1782966 * https://bugs.launchpad.net/kicad/+bug/1782966
2018-10-01 11:15:12 +00:00
VECTOR2I nearestPoint = seg.NearestPoint( cursorPos );
Splitting DRAWSEGMENTs with POINT_EDITOR.
2014-03-18 14:46:38 +00:00
pcbnew: Fix polygon corner adding in board editor Polygon corners were enabled in the footprint editor but the logic didn't extend to the board editor. This revises the logic to look for DRAWSEGMENTs and only reference the PCB_MODULE_EDGE_T where needed to create a new segment in the footprint. Fixes: lp:1782966 * https://bugs.launchpad.net/kicad/+bug/1782966
2018-10-01 11:15:12 +00:00
// Move the end of the line to the break point..
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
graphicItem->SetEnd( VECTOR2I( nearestPoint.x, nearestPoint.y ) );
Splitting DRAWSEGMENTs with POINT_EDITOR.
2014-03-18 14:46:38 +00:00
PCB_LINE_T -> PCB_SHAPE_T and PCB_MODULE_EDGE_T -> PCB_FP_SHAPE_T Also updated footprint text and zone types for consistencey.
2020-10-04 14:19:33 +00:00
if( graphicItem->Type() == PCB_FP_SHAPE_T )
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
static_cast<FP_SHAPE*>( graphicItem )->SetLocalCoord();
Update local coords when editing EDGE_MODULEs. Fixes: lp:1853726 * https://bugs.launchpad.net/kicad/+bug/1853726
2019-12-02 14:55:00 +00:00
pcbnew: Fix polygon corner adding in board editor Polygon corners were enabled in the footprint editor but the logic didn't extend to the board editor. This revises the logic to look for DRAWSEGMENTs and only reference the PCB_MODULE_EDGE_T where needed to create a new segment in the footprint. Fixes: lp:1782966 * https://bugs.launchpad.net/kicad/+bug/1782966
2018-10-01 11:15:12 +00:00
// and add another one starting from the break point
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
PCB_SHAPE* newSegment;
Added support for module edge splitting with double click.
2014-07-09 13:02:56 +00:00
PCB_LINE_T -> PCB_SHAPE_T and PCB_MODULE_EDGE_T -> PCB_FP_SHAPE_T Also updated footprint text and zone types for consistencey.
2020-10-04 14:19:33 +00:00
if( item->Type() == PCB_FP_SHAPE_T )
pcbnew: Fix polygon corner adding in board editor Polygon corners were enabled in the footprint editor but the logic didn't extend to the board editor. This revises the logic to look for DRAWSEGMENTs and only reference the PCB_MODULE_EDGE_T where needed to create a new segment in the footprint. Fixes: lp:1782966 * https://bugs.launchpad.net/kicad/+bug/1782966
2018-10-01 11:15:12 +00:00
{
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
FP_SHAPE* edge = static_cast<FP_SHAPE*>( graphicItem );
PCB_MODULE_T -> PCB_FOOTPRINT_T
2020-11-13 12:21:02 +00:00
assert( edge->GetParent()->Type() == PCB_FOOTPRINT_T );
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
newSegment = new FP_SHAPE( *edge );
pcbnew: Fix polygon corner adding in board editor Polygon corners were enabled in the footprint editor but the logic didn't extend to the board editor. This revises the logic to look for DRAWSEGMENTs and only reference the PCB_MODULE_EDGE_T where needed to create a new segment in the footprint. Fixes: lp:1782966 * https://bugs.launchpad.net/kicad/+bug/1782966
2018-10-01 11:15:12 +00:00
}
else
{
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
newSegment = new PCB_SHAPE( *graphicItem );
pcbnew: Fix polygon corner adding in board editor Polygon corners were enabled in the footprint editor but the logic didn't extend to the board editor. This revises the logic to look for DRAWSEGMENTs and only reference the PCB_MODULE_EDGE_T where needed to create a new segment in the footprint. Fixes: lp:1782966 * https://bugs.launchpad.net/kicad/+bug/1782966
2018-10-01 11:15:12 +00:00
}
Added support for module edge splitting with double click.
2014-07-09 13:02:56 +00:00
pcbnew: Fix polygon corner adding in board editor Polygon corners were enabled in the footprint editor but the logic didn't extend to the board editor. This revises the logic to look for DRAWSEGMENTs and only reference the PCB_MODULE_EDGE_T where needed to create a new segment in the footprint. Fixes: lp:1782966 * https://bugs.launchpad.net/kicad/+bug/1782966
2018-10-01 11:15:12 +00:00
newSegment->ClearSelected();
Some more wxPoint removal
2022-01-01 17:11:21 +00:00
newSegment->SetStart( VECTOR2I( nearestPoint.x, nearestPoint.y ) );
newSegment->SetEnd( VECTOR2I( seg.B.x, seg.B.y ) );
Splitting DRAWSEGMENTs with POINT_EDITOR.
2014-03-18 14:46:38 +00:00
PCB_LINE_T -> PCB_SHAPE_T and PCB_MODULE_EDGE_T -> PCB_FP_SHAPE_T Also updated footprint text and zone types for consistencey.
2020-10-04 14:19:33 +00:00
if( newSegment->Type() == PCB_FP_SHAPE_T )
Class renaming. DRAWSEGMENT -> PCB_SHAPE EDGE_MODULE -> FP_SHAPE TEXTE_PCB -> PCB_TEXT TEXTE_MODULE -> FP_TEXT
2020-10-04 23:34:59 +00:00
static_cast<FP_SHAPE*>( newSegment )->SetLocalCoord();
Update local coords when editing EDGE_MODULEs. Fixes: lp:1853726 * https://bugs.launchpad.net/kicad/+bug/1853726
2019-12-02 14:55:00 +00:00
pcbnew: Fix polygon corner adding in board editor Polygon corners were enabled in the footprint editor but the logic didn't extend to the board editor. This revises the logic to look for DRAWSEGMENTs and only reference the PCB_MODULE_EDGE_T where needed to create a new segment in the footprint. Fixes: lp:1782966 * https://bugs.launchpad.net/kicad/+bug/1782966
2018-10-01 11:15:12 +00:00
commit.Add( newSegment );
commit.Push( _( "Split segment" ) );
Splitting DRAWSEGMENTs with POINT_EDITOR.
2014-03-18 14:46:38 +00:00
}
Temporary fix of broken command add corner to zone in GAL mode. Fixes: lp:1680339 https://bugs.launchpad.net/kicad/+bug/1680339
2017-04-06 17:04:47 +00:00
TOOL_ACTIONs are handled with transitions, no handlers needed in the event loops There used to be a number of TOOL_ACTIONs that had entries both in SetTransitions() and the event loop, which seemed redundant and troublesome. Now it is not necessary anymore, transitions setup is enough to execute associated actions.
2017-01-18 08:04:11 +00:00
updatePoints();
return 0;
Breaking outlines for zones using POINT_EDITOR.
2014-03-18 13:52:22 +00:00
}
"Create corner" context menu entry for draw segments and zone outlines (GAL).
2014-07-09 14:50:31 +00:00
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
int PCB_POINT_EDITOR::removeCorner( const TOOL_EVENT& aEvent )
Remove a corner from zone outline function (GAL).
2015-06-19 15:32:33 +00:00
{
Added safety for POINT_EDITOR. Fixes: lp:1786349 * https://bugs.launchpad.net/kicad/+bug/1786349
2018-09-17 11:31:57 +00:00
if( !m_editPoints || !m_editedPoint )
TOOL_ACTIONs are handled with transitions, no handlers needed in the event loops There used to be a number of TOOL_ACTIONs that had entries both in SetTransitions() and the event loop, which seemed redundant and troublesome. Now it is not necessary anymore, transitions setup is enough to execute associated actions.
2017-01-18 08:04:11 +00:00
return 0;
Remove a corner from zone outline function (GAL).
2015-06-19 15:32:33 +00:00
EDA_ITEM* item = m_editPoints->GetParent();
More data validity checks in POINT_EDITOR Fixes: lp:1690658 * https://bugs.launchpad.net/kicad/+bug/1690658
2017-05-16 09:38:00 +00:00
if( !item )
return 0;
Fix segfault when removing the last corner of a cutout Fixes: lp:1736147 * https://bugs.launchpad.net/kicad/+bug/1736147
2017-12-06 14:51:47 +00:00
SHAPE_POLY_SET* polygon = nullptr;
pcbnew: added graphical polygon drawing & editing tools
2017-10-19 21:14:01 +00:00
Update some classnames including archaic zone names.
2020-11-11 23:05:59 +00:00
if( item->Type() == PCB_ZONE_T || item->Type() == PCB_FP_ZONE_T )
Remove a corner from zone outline function (GAL).
2015-06-19 15:32:33 +00:00
{
Update some classnames including archaic zone names.
2020-11-11 23:05:59 +00:00
ZONE* zone = static_cast<ZONE*>( item );
Fix segfault when removing the last corner of a cutout Fixes: lp:1736147 * https://bugs.launchpad.net/kicad/+bug/1736147
2017-12-06 14:51:47 +00:00
polygon = zone->Outline();
Pcbnew, Zone refill: avoid useless refilling, when zone parameters are not modified. Previously, in many cases the selected zone was refilled on exit selection, even if the zone was not modified. This is annoying, because the zone fill can be really time consuming, and cannot be called without a good reason. Now the refilling is made only if a zone parameter is actually modified.
2019-03-14 13:35:55 +00:00
zone->SetNeedRefill( true );
pcbnew: added graphical polygon drawing & editing tools
2017-10-19 21:14:01 +00:00
}
PCB_LINE_T -> PCB_SHAPE_T and PCB_MODULE_EDGE_T -> PCB_FP_SHAPE_T Also updated footprint text and zone types for consistencey.
2020-10-04 14:19:33 +00:00
else if( item->Type() == PCB_FP_SHAPE_T || item->Type() == PCB_SHAPE_T )
pcbnew: added graphical polygon drawing & editing tools
2017-10-19 21:14:01 +00:00
{
Go back to previous arc midpoint editing routine. It avoids erratic behaviour near the chord or end-points. Fixes https://gitlab.com/kicad/code/kicad/issues/7135
2021-01-19 23:07:31 +00:00
PCB_SHAPE* shape = static_cast<PCB_SHAPE*>( item );
Fix segfault when removing the last corner of a cutout Fixes: lp:1736147 * https://bugs.launchpad.net/kicad/+bug/1736147
2017-12-06 14:51:47 +00:00
Pull some name changes back from 7.0 to ease merging.
2021-07-21 18:31:25 +00:00
if( shape->GetShape() == SHAPE_T::POLY )
Go back to previous arc midpoint editing routine. It avoids erratic behaviour near the chord or end-points. Fixes https://gitlab.com/kicad/code/kicad/issues/7135
2021-01-19 23:07:31 +00:00
polygon = &shape->GetPolyShape();
pcbnew: added graphical polygon drawing & editing tools
2017-10-19 21:14:01 +00:00
}
Remove a corner from zone outline function (GAL).
2015-06-19 15:32:33 +00:00
Fix segfault when removing the last corner of a cutout Fixes: lp:1736147 * https://bugs.launchpad.net/kicad/+bug/1736147
2017-12-06 14:51:47 +00:00
if( !polygon )
pcbnew: added graphical polygon drawing & editing tools
2017-10-19 21:14:01 +00:00
return 0;
Remove a corner from zone outline function (GAL).
2015-06-19 15:32:33 +00:00
pcbnew: added graphical polygon drawing & editing tools
2017-10-19 21:14:01 +00:00
PCB_BASE_FRAME* frame = getEditFrame<PCB_BASE_FRAME>();
BOARD_COMMIT commit( frame );
Fix segfault when removing the last corner of a cutout Fixes: lp:1736147 * https://bugs.launchpad.net/kicad/+bug/1736147
2017-12-06 14:51:47 +00:00
auto vertex = findVertex( *polygon, *m_editedPoint );
pcbnew: added graphical polygon drawing & editing tools
2017-10-19 21:14:01 +00:00
Fix segfault when removing the last corner of a cutout Fixes: lp:1736147 * https://bugs.launchpad.net/kicad/+bug/1736147
2017-12-06 14:51:47 +00:00
if( vertex.first )
pcbnew: added graphical polygon drawing & editing tools
2017-10-19 21:14:01 +00:00
{
Fix segfault when removing the last corner of a cutout Fixes: lp:1736147 * https://bugs.launchpad.net/kicad/+bug/1736147
2017-12-06 14:51:47 +00:00
const auto& vertexIdx = vertex.second;
auto& outline = polygon->Polygon( vertexIdx.m_polygon )[vertexIdx.m_contour];
if( outline.PointCount() > 3 )
Remove a corner from zone outline function (GAL).
2015-06-19 15:32:33 +00:00
{
Fix segfault when removing the last corner of a cutout Fixes: lp:1736147 * https://bugs.launchpad.net/kicad/+bug/1736147
2017-12-06 14:51:47 +00:00
// the usual case: remove just the corner when there are >3 vertices
commit.Modify( item );
polygon->RemoveVertex( vertexIdx );
Allow edits to self-intersecting polygons. 1) Intermediate states might be self-intersecting, and we shouldn't be policing our users on what order to do things in 2) The polygon might already be self-intersecting, at which point we're preventing the user from fixing it. Also includes better const management for SHAPE_POLY_SET API. Fixes: lp:1833831 * https://bugs.launchpad.net/kicad/+bug/1833831
2019-07-14 12:46:59 +00:00
validatePolygon( *polygon );
Fix segfault when removing the last corner of a cutout Fixes: lp:1736147 * https://bugs.launchpad.net/kicad/+bug/1736147
2017-12-06 14:51:47 +00:00
}
else
{
// either remove a hole or the polygon when there are <= 3 corners
if( vertexIdx.m_contour > 0 )
{
// remove hole
commit.Modify( item );
polygon->RemoveContour( vertexIdx.m_contour );
}
else
{
m_toolMgr->RunAction( PCB_ACTIONS::selectionClear, true );
commit.Remove( item );
}
Remove a corner from zone outline function (GAL).
2015-06-19 15:32:33 +00:00
}
pcbnew: added graphical polygon drawing & editing tools
2017-10-19 21:14:01 +00:00
Fix segfault when removing the last corner of a cutout Fixes: lp:1736147 * https://bugs.launchpad.net/kicad/+bug/1736147
2017-12-06 14:51:47 +00:00
setEditedPoint( nullptr );
Point Editor: prevent creation of self-intersecting polygons
2018-02-22 11:28:01 +00:00
Allow edits to self-intersecting polygons. 1) Intermediate states might be self-intersecting, and we shouldn't be policing our users on what order to do things in 2) The polygon might already be self-intersecting, at which point we're preventing the user from fixing it. Also includes better const management for SHAPE_POLY_SET API. Fixes: lp:1833831 * https://bugs.launchpad.net/kicad/+bug/1833831
2019-07-14 12:46:59 +00:00
commit.Push( _( "Remove a zone/polygon corner" ) );
Point Editor: prevent creation of self-intersecting polygons
2018-02-22 11:28:01 +00:00
Allow edits to self-intersecting polygons. 1) Intermediate states might be self-intersecting, and we shouldn't be policing our users on what order to do things in 2) The polygon might already be self-intersecting, at which point we're preventing the user from fixing it. Also includes better const management for SHAPE_POLY_SET API. Fixes: lp:1833831 * https://bugs.launchpad.net/kicad/+bug/1833831
2019-07-14 12:46:59 +00:00
// Refresh zone hatching
Update some classnames including archaic zone names.
2020-11-11 23:05:59 +00:00
if( item->Type() == PCB_ZONE_T || item->Type() == PCB_FP_ZONE_T )
static_cast<ZONE*>( item )->HatchBorder();
Point Editor: prevent creation of self-intersecting polygons
2018-02-22 11:28:01 +00:00
Allow edits to self-intersecting polygons. 1) Intermediate states might be self-intersecting, and we shouldn't be policing our users on what order to do things in 2) The polygon might already be self-intersecting, at which point we're preventing the user from fixing it. Also includes better const management for SHAPE_POLY_SET API. Fixes: lp:1833831 * https://bugs.launchpad.net/kicad/+bug/1833831
2019-07-14 12:46:59 +00:00
updatePoints();
Fix segfault when removing the last corner of a cutout Fixes: lp:1736147 * https://bugs.launchpad.net/kicad/+bug/1736147
2017-12-06 14:51:47 +00:00
}
pcbnew: added graphical polygon drawing & editing tools
2017-10-19 21:14:01 +00:00
TOOL_ACTIONs are handled with transitions, no handlers needed in the event loops There used to be a number of TOOL_ACTIONs that had entries both in SetTransitions() and the event loop, which seemed redundant and troublesome. Now it is not necessary anymore, transitions setup is enough to execute associated actions.
2017-01-18 08:04:11 +00:00
return 0;
"Create corner" context menu entry for draw segments and zone outlines (GAL).
2014-07-09 14:50:31 +00:00
}
Remove a corner from zone outline function (GAL).
2015-06-19 15:32:33 +00:00
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
int PCB_POINT_EDITOR::modifiedSelection( const TOOL_EVENT& aEvent )
Remove a corner from zone outline function (GAL).
2015-06-19 15:32:33 +00:00
{
TOOL_ACTIONs are handled with transitions, no handlers needed in the event loops There used to be a number of TOOL_ACTIONs that had entries both in SetTransitions() and the event loop, which seemed redundant and troublesome. Now it is not necessary anymore, transitions setup is enough to execute associated actions.
2017-01-18 08:04:11 +00:00
updatePoints();
return 0;
Remove a corner from zone outline function (GAL).
2015-06-19 15:32:33 +00:00
}
Add point-editor activation for immediate-mode drawing.
2019-05-24 11:39:30 +00:00
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
int PCB_POINT_EDITOR::changeEditMethod( const TOOL_EVENT& aEvent )
pcbnew: Add an alternate edit method for arcs The alternate edit methods keeps the radius constant Fixes https://gitlab.com/kicad/code/kicad/-/issues/5369
2020-08-29 22:59:11 +00:00
{
m_altEditMethod = !m_altEditMethod;
return 0;
}
Add point-editor activation for immediate-mode drawing.
2019-05-24 11:39:30 +00:00
Pass VECTOR2I objects by reference instead of on the stack.
2021-07-26 23:47:26 +00:00
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
void PCB_POINT_EDITOR::setTransitions()
Add point-editor activation for immediate-mode drawing.
2019-05-24 11:39:30 +00:00
{
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
Go( &PCB_POINT_EDITOR::OnSelectionChange, ACTIONS::activatePointEditor.MakeEvent() );
Fix logic bug when updating circular pad points. Fixes https://gitlab.com/kicad/code/kicad/issues/9576
2021-11-09 13:09:06 +00:00
Go( &PCB_POINT_EDITOR::addCorner, PCB_ACTIONS::pointEditorAddCorner.MakeEvent() );
Go( &PCB_POINT_EDITOR::removeCorner, PCB_ACTIONS::pointEditorRemoveCorner.MakeEvent() );
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
Go( &PCB_POINT_EDITOR::modifiedSelection, EVENTS::SelectedItemsModified );
Go( &PCB_POINT_EDITOR::OnSelectionChange, EVENTS::SelectedEvent );
Go( &PCB_POINT_EDITOR::OnSelectionChange, EVENTS::UnselectedEvent );
Fix logic bug when updating circular pad points. Fixes https://gitlab.com/kicad/code/kicad/issues/9576
2021-11-09 13:09:06 +00:00
Go( &PCB_POINT_EDITOR::changeEditMethod, ACTIONS::changeEditMethod.MakeEvent() );
Push shared parts of GRID_HELPERs into common.
2021-01-16 23:17:32 +00:00
Go( &PCB_POINT_EDITOR::OnSelectionChange, EVENTS::InhibitSelectionEditing );
Go( &PCB_POINT_EDITOR::OnSelectionChange, EVENTS::UninhibitSelectionEditing );
Add point-editor activation for immediate-mode drawing.
2019-05-24 11:39:30 +00:00
}