haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
kicad/eeschema/sch_edit_frame.cpp

2568 lines
86 KiB
C++
Raw Normal View History

More auto save improvements. * Factor test for auto save file into base frame class. * Added auto save feature to Eeschema for saving schematics, addresses launchpad question 173631. * Add auto save interval control to Eeschema options dialog. * Fix problem with subsequent auto saves in last commit.
2011-10-15 13:25:57 +00:00
/*
* This program source code file is part of KiCad, a free EDA CAD application.
*
filter useless autosave tests, and optimization of autosave test in Eechema
2017-07-26 10:03:24 +00:00
* Copyright (C) 2017 Jean-Pierre Charras, jp.charras at wanadoo.fr
Do not expand the entire schematic hierarchy navigator tree by default. The new behavior is to only expand to the first child of the root sheet level. On very complex hierarchies, this makes the navigator far more useful. Do not update schematic hierarchy navigator on every edit. Now only sheet changes will trigger a rebuild of the tree. Fixes https://gitlab.com/kicad/code/kicad/-/issues/16371
2024-01-06 12:56:16 +00:00
* Copyright (C) 1992-2024 KiCad Developers, see AUTHORS.txt for contributors.
More auto save improvements. * Factor test for auto save file into base frame class. * Added auto save feature to Eeschema for saving schematics, addresses launchpad question 173631. * Add auto save interval control to Eeschema options dialog. * Fix problem with subsequent auto saves in last commit.
2011-10-15 13:25:57 +00:00
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, you may find one here:
* http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
* or you may search the http://www.gnu.org website for the version 2 license,
* or you may write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
*/
Add SCH_RULE_AREA shapes to eeschema Includes: - Fix GAL to draw closed polygons in eeschema - Add functionality to eeschema to draw arbitary polygons - Update polygon item previews to have customisable edge colour - Add new SCH_RULE_AREA class, derived from a poly SCH_SHAPE - Add SCH_RULE_AREA to paint and plot methods - Add new rule area color preference to themes
2024-04-25 14:24:46 +00:00
#include <algorithm>
Add QA tests and expand serialization for API
2024-01-20 23:35:29 +00:00
#include <api/api_handler_sch.h>
#include <api/api_server.h>
Update exit strategy to match UI guidelines In singletop mode, all frames show the "Quit" option in the file menu and will quit on Ctrl-Q. When launched from the main KiCad interface, sub-programs show the "Close" option instead and will close with Ctrl-W. In this mode, Ctrl-Q will instruct the main program to exit. Fixes: lp:1779938 * https://bugs.launchpad.net/kicad/+bug/1779938
2019-06-25 04:44:34 +00:00
#include <base_units.h>
Remove transitive inclusion of bitmaps.h
2021-03-07 20:31:19 +00:00
#include <bitmaps.h>
Rename class_library.[h|cpp] to symbol_library.[h|cpp].
2021-06-15 13:24:55 +00:00
#include <symbol_library.h>
Update exit strategy to match UI guidelines In singletop mode, all frames show the "Quit" option in the file menu and will quit on Ctrl-Q. When launched from the main KiCad interface, sub-programs show the "Close" option instead and will close with Ctrl-W. In this mode, Ctrl-Q will instruct the main program to exit. Fixes: lp:1779938 * https://bugs.launchpad.net/kicad/+bug/1779938
2019-06-25 04:44:34 +00:00
#include <confirm.h>
eeschema: Allow hierarchy navigator to stay open ADD: User can now decide to keep the hierarchy navigator open while working on a schematic. This behavior can be configured in eeschema->preferences->eeschema->Editing options.
2019-10-24 17:07:01 +00:00
#include <connection_graph.h>
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
#include <dialogs/dialog_erc.h>
eeschema: Allow hierarchy navigator to stay open ADD: User can now decide to keep the hierarchy navigator open while working on a schematic. This behavior can be configured in eeschema->preferences->eeschema->Editing options.
2019-10-24 17:07:01 +00:00
#include <dialogs/dialog_schematic_find.h>
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
#include <dialogs/dialog_book_reporter.h>
Symbol Fields Table: make non-modal Fixes: https://gitlab.com/kicad/code/kicad/-/issues/2141
2023-08-14 14:41:28 +00:00
#include <dialogs/dialog_symbol_fields_table.h>
eeschema: Allow hierarchy navigator to stay open ADD: User can now decide to keep the hierarchy navigator open while working on a schematic. This behavior can be configured in eeschema->preferences->eeschema->Editing options.
2019-10-24 17:07:01 +00:00
#include <eeschema_id.h>
Update exit strategy to match UI guidelines In singletop mode, all frames show the "Quit" option in the file menu and will quit on Ctrl-Q. When launched from the main KiCad interface, sub-programs show the "Close" option instead and will close with Ctrl-W. In this mode, Ctrl-Q will instruct the main program to exit. Fixes: lp:1779938 * https://bugs.launchpad.net/kicad/+bug/1779938
2019-06-25 04:44:34 +00:00
#include <executable_names.h>
Fail GAL on its header leaking audit Maybe we should rethink directly accessing GAL so much, but at least 600 files didn't need GAL leaked into them due to view_overlay.h
2023-09-18 23:52:27 +00:00
#include <gal/graphics_abstraction_layer.h>
Add SCH_RULE_AREA shapes to eeschema Includes: - Fix GAL to draw closed polygons in eeschema - Add functionality to eeschema to draw arbitary polygons - Update polygon item previews to have customisable edge colour - Add new SCH_RULE_AREA class, derived from a poly SCH_SHAPE - Add SCH_RULE_AREA to paint and plot methods - Add new rule area color preference to themes
2024-04-25 14:24:46 +00:00
#include <geometry/shape_segment.h>
switch to <> for includes from "" per conversation with Jean-Pierre and Wayne, adjust search paths
2012-01-23 04:33:36 +00:00
#include <gestfich.h>
Dark mode for a bunch of HTML dialogs. WX_HTML_REPORT_BOX WX_HTML_REPORT_PANEL HTML_MESSAGEBOX DIALOG_DISPLAY_HTML_TEXT Fixes https://gitlab.com/kicad/code/kicad/issues/9157 Fixes https://gitlab.com/kicad/code/kicad/issues/9156
2021-09-14 18:26:03 +00:00
#include <dialogs/html_message_box.h>
Banish ignore.h to core
2023-04-19 02:44:04 +00:00
#include <core/ignore.h>
eeschema: Allow hierarchy navigator to stay open ADD: User can now decide to keep the hierarchy navigator open while working on a schematic. This behavior can be configured in eeschema->preferences->eeschema->Editing options.
2019-10-24 17:07:01 +00:00
#include <invoke_sch_dialog.h>
Fix kicad_string.h / string.cpp mismatch. They don't define a KiCad string class, so the header file name was somewhat misleading. But the fact that they didn't match definitely made coding more difficult.
2021-07-29 09:56:22 +00:00
#include <string_utils.h>
KIFACE_I -> KIFACE_BASE.
2021-09-14 22:45:14 +00:00
#include <kiface_base.h>
Move shutdown blocker to kiplatform
2020-09-01 10:14:51 +00:00
#include <kiplatform/app.h>
Update exit strategy to match UI guidelines In singletop mode, all frames show the "Quit" option in the file menu and will quit on Ctrl-Q. When launched from the main KiCad interface, sub-programs show the "Close" option instead and will close with Ctrl-W. In this mode, Ctrl-Q will instruct the main program to exit. Fixes: lp:1779938 * https://bugs.launchpad.net/kicad/+bug/1779938
2019-06-25 04:44:34 +00:00
#include <kiway.h>
LibEdit -> SymbolEditor
2020-10-31 01:27:16 +00:00
#include <symbol_edit_frame.h>
Update naming.
2020-12-25 23:37:01 +00:00
#include <symbol_viewer_frame.h>
Update exit strategy to match UI guidelines In singletop mode, all frames show the "Quit" option in the file menu and will quit on Ctrl-Q. When launched from the main KiCad interface, sub-programs show the "Close" option instead and will close with Ctrl-W. In this mode, Ctrl-Q will instruct the main program to exit. Fixes: lp:1779938 * https://bugs.launchpad.net/kicad/+bug/1779938
2019-06-25 04:44:34 +00:00
#include <pgm_base.h>
Profile can live in core
2023-09-07 11:22:10 +00:00
#include <core/profile.h>
Project settings fixes from review - Fix file extension for new project - Fixes for exceptions on MSW - Fix some ASAN issues - Allow SETTINGS_MANAGER to run headless - Don't flag schematic as modified after schematic setup is closed - Don't automatically unload projects when LoadProject is called - Don't unload project if it's the same as the current one - Make sure to properly init/de-init template field names
2020-06-20 14:36:16 +00:00
#include <project/project_file.h>
Finish moving eeschema assigned netclasses to sheet-path-relative. Also adds code for the case where a new label is created on a net with an existing netclass assignment. Fixes https://gitlab.com/kicad/code/kicad/issues/5886
2020-10-07 14:40:12 +00:00
#include <project/net_settings.h>
Fix python console toggle to work across pcbnew/eeschema
2021-07-02 19:05:16 +00:00
#include <python_scripting.h>
eeschema: Allow hierarchy navigator to stay open ADD: User can now decide to keep the hierarchy navigator open while working on a schematic. This behavior can be configured in eeschema->preferences->eeschema->Editing options.
2019-10-24 17:07:01 +00:00
#include <sch_edit_frame.h>
Push most of DIALOG_CHOOSE_SYMBOL down into PANEL_SYMBOL_CHOOSER. Includes a dialog wrapper (DIALOG_SYMBOL_CHOOSER) and a frame wrapper (SYMBOL_CHOOSER_FRAME).
2023-09-28 13:09:45 +00:00
#include <symbol_chooser_frame.h>
eeschema: Allow hierarchy navigator to stay open ADD: User can now decide to keep the hierarchy navigator open while working on a schematic. This behavior can be configured in eeschema->preferences->eeschema->Editing options.
2019-10-24 17:07:01 +00:00
#include <sch_painter.h>
switch to <> for includes from "" per conversation with Jean-Pierre and Wayne, adjust search paths
2012-01-23 04:33:36 +00:00
#include <sch_sheet.h>
Start of impl for persisting ERC exclusions.
2020-11-18 22:55:38 +00:00
#include <sch_marker.h>
Incremental schematic connectivity fixes.
2024-01-21 16:53:05 +00:00
#include <sch_sheet_pin.h>
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
#include <schematic.h>
Upgrade some symbol editor stuff to SCHEMATIC_COMMIT. Also renames SCHEMATIC_COMMIT to SCH_COMMIT since it's not schematic-specifc.
2023-06-09 21:41:33 +00:00
#include <sch_commit.h>
Add SCH_RULE_AREA shapes to eeschema Includes: - Fix GAL to draw closed polygons in eeschema - Add functionality to eeschema to draw arbitary polygons - Update polygon item previews to have customisable edge colour - Add new SCH_RULE_AREA class, derived from a poly SCH_SHAPE - Add SCH_RULE_AREA to paint and plot methods - Add new rule area color preference to themes
2024-04-25 14:24:46 +00:00
#include <sch_rule_area.h>
Project settings fixes from review - Fix file extension for new project - Fixes for exceptions on MSW - Fix some ASAN issues - Allow SETTINGS_MANAGER to run headless - Don't flag schematic as modified after schematic setup is closed - Don't automatically unload projects when LoadProject is called - Don't unload project if it's the same as the current one - Make sure to properly init/de-init template field names
2020-06-20 14:36:16 +00:00
#include <settings/settings_manager.h>
Implement a new settings framework across all of KiCad CHANGED: Settings are now stored in versioned sub-directories ADDED: First-run dialog for migrating settings from a previous version CHANGED: Settings are now stored as JSON files instead of wxConfig-style INI files CHANGED: Color settings are now all stored in a separate settings file CHANGED: The symbol editor and footprint editor now have their own settings files CHANGED: Color settings are no longer exposed through BOARD object CHANGED: Page layout editor now uses Eeschema's color scheme Settings are now managed through a central SETTINGS_MANAGER held by PGM_BASE. Existing settings will be migrated from the wxConfig format on first run of each application. Per-application settings are now stored in one class for each application.
2020-01-13 01:44:19 +00:00
#include <advanced_config.h>
Naming conventions and commenting. No functional changes.
2023-03-03 22:36:07 +00:00
#include <sim/simulator_frame.h>
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
#include <tool/action_manager.h>
Move hotkeys to ACTION architecture.
2019-06-09 21:57:23 +00:00
#include <tool/action_toolbar.h>
#include <tool/common_control.h>
Move to direct tool registration. It was confusing that the primary frames registered their tools differently than the other frames. In addition, since the other frames also added their own tools, foo_actions::RegisterAllTools() didn't really register all tool but rather those used by the principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
2019-05-04 11:23:04 +00:00
#include <tool/common_tools.h>
Push Eeschema & PLEditor PICKER_TOOLs down into common. Also implements a more robust push/pop tool strategy for pickers.
2019-07-15 23:44:01 +00:00
#include <tool/picker_tool.h>
ADDED: Properties panel for schematic editor Initial infrastructure work; follow-ons will add more properties for schematic items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/6351 Fixes https://gitlab.com/kicad/code/kicad/-/issues/14105
2023-06-21 01:57:20 +00:00
#include <tool/properties_tool.h>
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
#include <tool/selection.h>
eeschema: Allow hierarchy navigator to stay open ADD: User can now decide to keep the hierarchy navigator open while working on a schematic. This behavior can be configured in eeschema->preferences->eeschema->Editing options.
2019-10-24 17:07:01 +00:00
#include <tool/tool_dispatcher.h>
#include <tool/tool_manager.h>
Move to direct tool registration. It was confusing that the primary frames registered their tools differently than the other frames. In addition, since the other frames also added their own tools, foo_actions::RegisterAllTools() didn't really register all tool but rather those used by the principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
2019-05-04 11:23:04 +00:00
#include <tool/zoom_tool.h>
Naming changes to reflect sharing between SchEdit and LibEdit.
2019-05-10 17:19:48 +00:00
#include <tools/ee_actions.h>
eeschema: Allow hierarchy navigator to stay open ADD: User can now decide to keep the hierarchy navigator open while working on a schematic. This behavior can be configured in eeschema->preferences->eeschema->Editing options.
2019-10-24 17:07:01 +00:00
#include <tools/ee_inspection_tool.h>
Naming changes to reflect sharing between SchEdit and LibEdit.
2019-05-10 17:19:48 +00:00
#include <tools/ee_point_editor.h>
eeschema: Allow hierarchy navigator to stay open ADD: User can now decide to keep the hierarchy navigator open while working on a schematic. This behavior can be configured in eeschema->preferences->eeschema->Editing options.
2019-10-24 17:07:01 +00:00
#include <tools/ee_selection_tool.h>
Move Pin, Symbol Text and Symbol Anchor to modern toolset.
2019-05-07 18:49:53 +00:00
#include <tools/sch_drawing_tools.h>
Move to direct tool registration. It was confusing that the primary frames registered their tools differently than the other frames. In addition, since the other frames also added their own tools, foo_actions::RegisterAllTools() didn't really register all tool but rather those used by the principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
2019-05-04 11:23:04 +00:00
#include <tools/sch_edit_tool.h>
ADDED: schematic tables. Fixes https://gitlab.com/kicad/code/kicad/-/issues/6806
2023-11-25 12:38:24 +00:00
#include <tools/sch_edit_table_tool.h>
Schematic: new feature, force 45 degree lines * New modes to force 45 deg angle at beginning or end of line * Backspace will undo most recent segment added * / will toggle posture of 90 and 45 degree lines * Added alg::signbit for convenience Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10869 Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9175
2022-03-22 16:49:38 +00:00
#include <tools/sch_editor_conditions.h>
Move to direct tool registration. It was confusing that the primary frames registered their tools differently than the other frames. In addition, since the other frames also added their own tools, foo_actions::RegisterAllTools() didn't really register all tool but rather those used by the principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
2019-05-04 11:23:04 +00:00
#include <tools/sch_editor_control.h>
eeschema: Allow hierarchy navigator to stay open ADD: User can now decide to keep the hierarchy navigator open while working on a schematic. This behavior can be configured in eeschema->preferences->eeschema->Editing options.
2019-10-24 17:07:01 +00:00
#include <tools/sch_line_wire_bus_tool.h>
#include <tools/sch_move_tool.h>
Implement hypertext links for intersheet references.
2020-10-02 20:18:07 +00:00
#include <tools/sch_navigate_tool.h>
Move find/replace to own tool so it doesn't rob events from cross-probing.
2023-01-11 14:17:36 +00:00
#include <tools/sch_find_replace_tool.h>
Add SCH_RULE_AREA shapes to eeschema Includes: - Fix GAL to draw closed polygons in eeschema - Add functionality to eeschema to draw arbitary polygons - Update polygon item previews to have customisable edge colour - Add new SCH_RULE_AREA class, derived from a poly SCH_SHAPE - Add SCH_RULE_AREA to paint and plot methods - Add new rule area color preference to themes
2024-04-25 14:24:46 +00:00
#include <unordered_set>
Refactor GetDocumentExtents() CHANGED: GetDocumentExtents() in 'eda_draw_frame.h' now has a bool parameter "aIncludeAllVisible" with a default value "true" which makes it behave as it did before adding parameter. If "aIncludeAllVisible" is false, the returned bbox ignores some items depending on which program it is running in. CHANGED: Made "Zoom to Objects" use only PCB edge in Pcbnew. This allows text, notes, etc outside the PCB edge to be excluded in the zoom calculation. CHANGED: Added "Zoom to Objects" to Pcbnew main menu, and to RMB context menus for Eeschema and Pcbnew. Fixes https://gitlab.com/kicad/code/kicad/issues/5787
2020-09-25 07:31:56 +00:00
#include <view/view_controls.h>
Class name <-> file name sync.
2022-12-28 22:03:03 +00:00
#include <widgets/wx_infobar.h>
Use consistent naming.
2022-12-12 11:46:20 +00:00
#include <widgets/hierarchy_pane.h>
ADDED: Properties panel for schematic editor Initial infrastructure work; follow-ons will add more properties for schematic items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/6351 Fixes https://gitlab.com/kicad/code/kicad/-/issues/14105
2023-06-21 01:57:20 +00:00
#include <widgets/sch_properties_panel.h>
Initial schematic search pane
2023-05-15 01:35:39 +00:00
#include <widgets/sch_search_pane.h>
Kicad project manager: add .cmp, .drl .pos and .rpt files management. Code cleaning and other minor fixes.
2012-02-16 20:03:33 +00:00
#include <wildcards_and_files_ext.h>
Add command-line option to generate netlist and exit
2020-04-19 18:28:36 +00:00
#include <wx/cmdline.h>
Remove useless wx/wx.h include, that create sometimes compil warnings on msys. wx/wx.h includes all wxWidgets .h files, and sometimes creates collision names in #define between kicad and windows headers Moreover, blindly including a lot of useless files is compil time consuming
2021-05-01 07:50:29 +00:00
#include <wx/app.h>
#include <wx/filedlg.h>
Remove the universal sockets include
2021-06-03 21:57:41 +00:00
#include <wx/socket.h>
ADDED: Selection filter for schematic editor Fixes https://gitlab.com/kicad/code/kicad/-/issues/14988
2024-02-25 22:39:14 +00:00
#include <widgets/panel_sch_selection_filter.h>
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
#include <widgets/wx_aui_utils.h>
Round 2 of Worksheet -> Drawing Sheet.
2021-02-22 23:47:17 +00:00
#include <drawing_sheet/ds_proxy_view_item.h>
eeschema-gal: initial GALified version. Lots of stuff still to do!
2018-08-03 12:18:26 +00:00
Add QA tests and expand serialization for API
2024-01-20 23:35:29 +00:00
#ifdef KICAD_IPC_API
#include <api/api_plugin_manager.h>
#endif
Initial import of KiCad.
2007-05-06 16:03:28 +00:00
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
#define DIFF_SYMBOLS_DIALOG_NAME wxT( "DiffSymbolsDialog" )
Fix static event table derived object definitions.
2023-01-28 19:08:38 +00:00
BEGIN_EVENT_TABLE( SCH_EDIT_FRAME, SCH_BASE_FRAME )
EESchema code refactoring and coding policy naming fixes. * Move schematic wire and bus break code into schematic screen object. * Move schematic test for dangling ends into schematic screen object. * Remove left over debugging output in schematic screen object. * Remove unused file eeschema/cleanup.cpp. * Fix bug in schematic line object hit test algorithm. * Fix a string concatenation compile error added in r2752. * Rename class WinEDA_BasicFrame to EDA_BASE_FRAME. * Rename class WinEDA_DrawFrame to EDA_DRAW_FRAME. * Rename class WinEDA_DrawPanel to EDA_DRAW_PANEL.
2011-01-21 19:30:59 +00:00
EVT_SOCKET( ID_EDA_SOCKET_EVENT_SERV, EDA_DRAW_FRAME::OnSockRequestServer )
EVT_SOCKET( ID_EDA_SOCKET_EVENT, EDA_DRAW_FRAME::OnSockRequest )
More zoom clean ups and code cleaning.
2009-01-07 15:59:49 +00:00
Minor fixes and lots of coding policy changes.
2010-12-08 20:12:46 +00:00
EVT_SIZE( SCH_EDIT_FRAME::OnSize )
More zoom clean ups and code cleaning.
2009-01-07 15:59:49 +00:00
Allow updating of file history size on the fly. Also updates the file menu IDs so that we can actually handle more than 9 items in the file history. Also adds configurable file history length to the other gerber files (zip, drill and job). Fixes: lp:1745729 * https://bugs.launchpad.net/kicad/+bug/1745729
2018-08-20 13:46:38 +00:00
EVT_MENU_RANGE( ID_FILE1, ID_FILEMAX, SCH_EDIT_FRAME::OnLoadFile )
Rework the file history menus to not need references to the file history Keeping a pointer to the actual file history inside a special file history menu led to many cases of use after free crashes, so instead rework the actual file history to add the menu items. Fixes https://gitlab.com/kicad/code/kicad/issues/3741
2020-02-25 15:46:56 +00:00
EVT_MENU( ID_FILE_LIST_CLEAR, SCH_EDIT_FRAME::OnClearFileHistory )
More zoom clean ups and code cleaning.
2009-01-07 15:59:49 +00:00
Eeschema: Add "append schematic" feature. Fix bug 1101718 <Empty plot filename>
2013-01-24 17:46:37 +00:00
EVT_MENU( ID_APPEND_PROJECT, SCH_EDIT_FRAME::OnAppendProject )
Added 'Import Non-KiCad Schematic'
2017-09-20 14:20:38 +00:00
EVT_MENU( ID_IMPORT_NON_KICAD_SCH, SCH_EDIT_FRAME::OnImportProject )
Eeschema: Add "append schematic" feature. Fix bug 1101718 <Empty plot filename>
2013-01-24 17:46:37 +00:00
Move quit back to wxIDs. wxWidgets like to muck around with the location on OSX.
2019-05-26 22:22:03 +00:00
EVT_MENU( wxID_EXIT, SCH_EDIT_FRAME::OnExit )
Update exit strategy to match UI guidelines In singletop mode, all frames show the "Quit" option in the file menu and will quit on Ctrl-Q. When launched from the main KiCad interface, sub-programs show the "Close" option instead and will close with Ctrl-W. In this mode, Ctrl-Q will instruct the main program to exit. Fixes: lp:1779938 * https://bugs.launchpad.net/kicad/+bug/1779938
2019-06-25 04:44:34 +00:00
EVT_MENU( wxID_CLOSE, SCH_EDIT_FRAME::OnExit )
More zoom clean ups and code cleaning.
2009-01-07 15:59:49 +00:00
ADDED: Implement Drag and Drop dropping files to Kicad manager : *.kicad_pro, *.pro -> open project; gerber and job files -> open in Gerbview editor; Eagle and Cadstar files -> open project. dropping file to schematic editor -> append schematic; dropping library file to Symbol editor -> add library; dropping board file to PCB editor -> append board; dropping library or footprint file to Footprint editor -> add library or import footprint; dropping ZIP file or gerber files to Gerbview editor -> open files; dropping sheet file to Drawing Sheet editor -> open sheet. Fixes https://gitlab.com/kicad/code/kicad/-/issues/11638
2022-09-14 22:28:09 +00:00
// Drop files event
EVT_DROP_FILES( SCH_EDIT_FRAME::OnDropFiles )
Initial import of KiCad.
2007-05-06 16:03:28 +00:00
END_EVENT_TABLE()
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
Warn the search pane that pointers are going invalid Fixes https://gitlab.com/kicad/code/kicad/-/issues/16612
2024-01-18 22:50:50 +00:00
wxDEFINE_EVENT( EDA_EVT_SCHEMATIC_CHANGING, wxCommandEvent );
Initial schematic search pane
2023-05-15 01:35:39 +00:00
wxDEFINE_EVENT( EDA_EVT_SCHEMATIC_CHANGED, wxCommandEvent );
Initial import of KiCad.
2007-05-06 16:03:28 +00:00
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
Formatting.
2020-12-03 15:10:14 +00:00
SCH_EDIT_FRAME::SCH_EDIT_FRAME( KIWAY* aKiway, wxWindow* aParent ) :
SCH_BASE_FRAME( aKiway, aParent, FRAME_SCH, wxT( "Eeschema" ), wxDefaultPosition,
wxDefaultSize, KICAD_DEFAULT_DRAWFRAME_STYLE, SCH_EDIT_FRAME_NAME ),
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
m_ercDialog( nullptr ),
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
m_diffSymbolDialog( nullptr ),
Symbol Fields Table: make non-modal Fixes: https://gitlab.com/kicad/code/kicad/-/issues/2141
2023-08-14 14:41:28 +00:00
m_symbolFieldsTableDialog( nullptr ),
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
m_netNavigator( nullptr ),
m_highlightedConnChanged( false )
Initial import of KiCad.
2007-05-06 16:03:28 +00:00
{
Maximize main editors by default if config is missing Also set default size for other windows to something slightly larger than it was before
2020-10-18 18:38:40 +00:00
m_maximizeByDefault = true;
Project settings fixes from review - Fix file extension for new project - Fixes for exceptions on MSW - Fix some ASAN issues - Allow SETTINGS_MANAGER to run headless - Don't flag schematic as modified after schematic setup is closed - Don't automatically unload projects when LoadProject is called - Don't unload project if it's the same as the current one - Make sure to properly init/de-init template field names
2020-06-20 14:36:16 +00:00
m_schematic = new SCHEMATIC( nullptr );
New connectivity algorithm and bus upgrades Bus upgrades: core new connectivity code Bus upgrades: eeschema integration and modifications Bus upgrades: eeschema dialogs Bus upgrades: netlist export Bus upgrades: file format changes
2019-03-11 21:32:05 +00:00
More EDA_DRAW_FRAME encapsulation work.
2011-12-14 20:03:15 +00:00
m_showBorderAndTitleBlock = true; // true to show sheet references
Reduce duplication of settings.
2021-12-02 20:19:15 +00:00
m_supportsAutoSave = true;
Cross-probing/selection for multiple items (PCB -> SCH) Fixes https://gitlab.com/kicad/code/kicad/issues/10469
2022-07-19 15:00:35 +00:00
m_syncingPcbToSchSelection = false;
Do not translate name in version info Leave the application name in version info untranslated when viewed, copied, or used in a bug report. Fixes https://gitlab.com/kicad/code/kicad/-/issues/13298
2022-12-31 23:39:04 +00:00
m_aboutTitle = _HKI( "KiCad Schematic Editor" );
Initial schematic search pane
2023-05-15 01:35:39 +00:00
m_show_search = false;
*) Introduce "invoke_a_dialog.h" to information hide between top frame and various DIALOG classes called from top frames. See comments in {eeschema,pcbnew}/invoke_a_dialog.h. *) Move some dialog classes into *.cpp files from *.h files. *) void SCH_EDIT_FRAME::OnErc( wxCommandEvent& event ) was opening the modeless ERC dialog more than once if icon was clicked more than once. *) Remove BOM stuff.
2013-06-07 20:56:55 +00:00
Rework Eeschema find/replace for modern toolset. Fixes: lp:1827274 * https://bugs.launchpad.net/kicad/+bug/1827274 Fixes: lp:1827240 * https://bugs.launchpad.net/kicad/+bug/1827240
2019-05-19 21:04:04 +00:00
m_findReplaceDialog = nullptr;
Replace wxFindReplaceData with our own container By dropping the flags, we can be strict with options. Also it makes future usage of search functionality a little more "UI" framework independent
2022-08-05 02:40:38 +00:00
m_findReplaceData = std::make_unique<SCH_SEARCH_DATA>();
annotate dialog HIGification, refactor and beautify associated annotation code
2008-02-26 01:07:38 +00:00
// Give an icon
Remove *.ico files and used only xpm or new pgn bitmaps for icons under Window. Fix minor other issues. Remove unused files.
2011-09-09 19:30:59 +00:00
wxIcon icon;
Add multiple size icons for programs In theory, the WM should now choose the closest size icon for its purpose, making it easier to distinguish in space-constrained settings Fixes https://gitlab.com/kicad/code/kicad/issues/6798
2020-12-22 19:41:32 +00:00
wxIconBundle icon_bundle;
Explicitly add 48, 128, 256 to icon bundles for each app
2024-01-16 22:21:01 +00:00
icon.CopyFromBitmap( KiBitmap( BITMAPS::icon_eeschema, 48 ) );
icon_bundle.AddIcon( icon );
icon.CopyFromBitmap( KiBitmap( BITMAPS::icon_eeschema, 128 ) );
icon_bundle.AddIcon( icon );
icon.CopyFromBitmap( KiBitmap( BITMAPS::icon_eeschema, 256 ) );
Add multiple size icons for programs In theory, the WM should now choose the closest size icon for its purpose, making it easier to distinguish in space-constrained settings Fixes https://gitlab.com/kicad/code/kicad/issues/6798
2020-12-22 19:41:32 +00:00
icon_bundle.AddIcon( icon );
Rework bitmap system to load from archived PNGs Bitmaps are now identified by an enum class instead of by pointers. Bitmap loading and caching is now handled by a class in common, and we no longer compile most bitmaps into the binary, so there is no longer a bitmaps static library. Instead, bitmaps are archived to a .tar.gz file which is installed in ${KICAD_DATA}/resources/images.tar.gz The source PNGs are checked in to Git as the original CPP files were, so that people can build without the required dependencies to convert SVGs to PNGs. Initial support is also added for dark theme icons, although this is not yet exposed in the GUI. Stubs are present for multi-resolution image resources, but this is not fully-baked yet and could use some refinement.
2021-03-08 02:59:07 +00:00
icon.CopyFromBitmap( KiBitmap( BITMAPS::icon_eeschema_32 ) );
Add multiple size icons for programs In theory, the WM should now choose the closest size icon for its purpose, making it easier to distinguish in space-constrained settings Fixes https://gitlab.com/kicad/code/kicad/issues/6798
2020-12-22 19:41:32 +00:00
icon_bundle.AddIcon( icon );
Rework bitmap system to load from archived PNGs Bitmaps are now identified by an enum class instead of by pointers. Bitmap loading and caching is now handled by a class in common, and we no longer compile most bitmaps into the binary, so there is no longer a bitmaps static library. Instead, bitmaps are archived to a .tar.gz file which is installed in ${KICAD_DATA}/resources/images.tar.gz The source PNGs are checked in to Git as the original CPP files were, so that people can build without the required dependencies to convert SVGs to PNGs. Initial support is also added for dark theme icons, although this is not yet exposed in the GUI. Stubs are present for multi-resolution image resources, but this is not fully-baked yet and could use some refinement.
2021-03-08 02:59:07 +00:00
icon.CopyFromBitmap( KiBitmap( BITMAPS::icon_eeschema_16 ) );
Add multiple size icons for programs In theory, the WM should now choose the closest size icon for its purpose, making it easier to distinguish in space-constrained settings Fixes https://gitlab.com/kicad/code/kicad/issues/6798
2020-12-22 19:41:32 +00:00
icon_bundle.AddIcon( icon );
SetIcons( icon_bundle );
annotate dialog HIGification, refactor and beautify associated annotation code
2008-02-26 01:07:38 +00:00
Restore separate libedit settings for common settings params Be careful when calling config() in eeschema/libedit/pcbnew/modedit It's usually not the thing you want. A better fix for #4389
2020-05-10 22:02:58 +00:00
LoadSettings( eeconfig() );
Comment translations and other minor updates. * Complete comment translation for all EESchema source files. * Complete comment translation for all 3D viewer source files. * Rename class class_hierarchical_PIN_sheet to SCH_SHEET_PIN. * Rename class DrawSheetStruct to SCH_SHEET. * Tool tip capitalization fixes. * Uncrustify and spell check comments and strings in all modified source files.
2009-11-04 20:46:53 +00:00
Attempt to untangle junction dot preferences.
2021-09-02 11:40:45 +00:00
// NB: also links the schematic to the loaded project
Fix saving undo/redo limits in Eeschema.
2015-08-06 00:10:52 +00:00
CreateScreens();
Schematic: set current sheet after initializing screens Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13238
2023-01-03 17:10:38 +00:00
SetCurrentSheet( Schematic().GetSheets()[0] );
Fix saving undo/redo limits in Eeschema.
2015-08-06 00:10:52 +00:00
Start moving some LibEdit and SchEdit menubar menus to actions. Also includes a bunch of bug fixes that got intermingled. Fixes: lp:1828826 * https://bugs.launchpad.net/kicad/+bug/1828826 Fixes: lp:1828826 * https://bugs.launchpad.net/kicad/+bug/1828826 Fixes: lp:1828793 * https://bugs.launchpad.net/kicad/+bug/1828793
2019-05-13 20:42:40 +00:00
setupTools();
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
setupUIConditions();
annotate dialog HIGification, refactor and beautify associated annotation code
2008-02-26 01:07:38 +00:00
ReCreateMenuBar();
ReCreateHToolbar();
ReCreateVToolbar();
ReCreateOptToolbar();
Marco's AUI patch, basically
2009-11-02 22:24:55 +00:00
Add QA tests and expand serialization for API
2024-01-20 23:35:29 +00:00
#ifdef KICAD_IPC_API
wxTheApp->Bind( EDA_EVT_PLUGIN_AVAILABILITY_CHANGED,
[&]( wxCommandEvent& aEvt )
{
wxLogTrace( traceApi, "SCH frame: EDA_EVT_PLUGIN_AVAILABILITY_CHANGED" );
ReCreateHToolbar();
aEvt.Skip();
} );
#endif
Use consistent naming.
2022-12-12 11:46:20 +00:00
m_hierarchy = new HIERARCHY_PANE( this );
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
Alexander's patches, with refinements
2012-03-26 21:45:05 +00:00
// Initialize common print setup dialog settings.
m_pageSetupData.GetPrintData().SetPrintMode( wxPRINT_MODE_PRINTER );
m_pageSetupData.GetPrintData().SetQuality( wxPRINT_QUALITY_MEDIUM );
m_pageSetupData.GetPrintData().SetBin( wxPRINTBIN_AUTO );
m_pageSetupData.GetPrintData().SetNoCopies( 1 );
EESchema printing fixes and print dialog improvements. * Remove unnecessary options from EESchema print dialog. * Expose page setup dialog to fix page orientation problems on wxGTK. * Added custom schematic print preview frame. * Print dialog and preview frame remember size and position settings between sessions. * Added monochrome and print sheet reference settings to project file.
2010-02-02 15:01:09 +00:00
Initial schematic search pane
2023-05-15 01:35:39 +00:00
m_searchPane = new SCH_SEARCH_PANE( this );
ADDED: Properties panel for schematic editor Initial infrastructure work; follow-ons will add more properties for schematic items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/6351 Fixes https://gitlab.com/kicad/code/kicad/-/issues/14105
2023-06-21 01:57:20 +00:00
m_propertiesPanel = new SCH_PROPERTIES_PANEL( this, this );
Nullptr safety for various panels. Also moves preference saving out to parent as different parents save different settings.
2023-09-25 11:35:31 +00:00
m_propertiesPanel->SetSplitterProportion( eeconfig()->m_AuiPanels.properties_splitter );
Initial schematic search pane
2023-05-15 01:35:39 +00:00
ADDED: Selection filter for schematic editor Fixes https://gitlab.com/kicad/code/kicad/-/issues/14988
2024-02-25 22:39:14 +00:00
m_selectionFilterPanel = new PANEL_SCH_SELECTION_FILTER( this );
Comment translations and other minor updates. * Complete comment translation for all EESchema source files. * Complete comment translation for all 3D viewer source files. * Rename class class_hierarchical_PIN_sheet to SCH_SHEET_PIN. * Rename class DrawSheetStruct to SCH_SHEET. * Tool tip capitalization fixes. * Uncrustify and spell check comments and strings in all modified source files.
2009-11-04 20:46:53 +00:00
m_auimgr.SetManagedWindow( this );
Marco's AUI patch, basically
2009-11-02 22:24:55 +00:00
Allow both aui-manager-based infobars and window overlay infobars.
2020-12-22 21:35:25 +00:00
CreateInfoBar();
Fix some issue with hierarchy panel on OSX. Also moves the option toolbars tight to the canvas for all windows. Fixes https://gitlab.com/kicad/code/kicad/issues/12087
2022-07-26 11:13:16 +00:00
// Rows; layers 4 - 6
More wxSing
2023-01-17 04:14:38 +00:00
m_auimgr.AddPane( m_mainToolBar, EDA_PANE().HToolbar().Name( wxS( "MainToolbar" ) )
Fix some issues with Infobar sizing. This also commits to the new strategy as it wasn't really compatible with if-def-ing anymore.
2020-12-11 12:09:37 +00:00
.Top().Layer( 6 ) );
Fix some issue with hierarchy panel on OSX. Also moves the option toolbars tight to the canvas for all windows. Fixes https://gitlab.com/kicad/code/kicad/issues/12087
2022-07-26 11:13:16 +00:00
More wxSing
2023-01-17 04:14:38 +00:00
m_auimgr.AddPane( m_messagePanel, EDA_PANE().Messages().Name( wxS( "MsgPanel" ) )
Fix some issue with hierarchy panel on OSX. Also moves the option toolbars tight to the canvas for all windows. Fixes https://gitlab.com/kicad/code/kicad/issues/12087
2022-07-26 11:13:16 +00:00
.Bottom().Layer( 6 ) );
// Columns; layers 1 - 3
Eeschema, Hierarchy navigator: add tool to Hide/show the panel. Add also a close button to the pane.
2022-06-07 09:00:13 +00:00
m_auimgr.AddPane( m_hierarchy, EDA_PANE().Palette().Name( SchematicHierarchyPaneName() )
Fix some issue with hierarchy panel on OSX. Also moves the option toolbars tight to the canvas for all windows. Fixes https://gitlab.com/kicad/code/kicad/issues/12087
2022-07-26 11:13:16 +00:00
.Caption( _( "Schematic Hierarchy" ) )
Fix ordering of selection filter and net navigator
2024-03-03 01:20:58 +00:00
.Left().Layer( 3 ).Position( 1 )
Eeschema, hierarchy navigator: fixes and enhancements. Work in progress.
2022-06-08 16:09:25 +00:00
.TopDockable( false )
.BottomDockable( false )
Remove close buttons from schematic AUI Harmonizes with PCB editor Fixes https://gitlab.com/kicad/code/kicad/-/issues/17415
2024-03-12 23:51:27 +00:00
.CloseButton( false )
Sprinkle FromDIP in SCH_EDIT_FRAME aui setup
2024-01-18 03:05:54 +00:00
.MinSize( FromDIP( wxSize( 120, 60 ) ) )
.BestSize( FromDIP( wxSize( 200, 200 ) ) )
.FloatingSize( FromDIP( wxSize( 200, 200 ) ) )
.FloatingPosition( FromDIP( wxPoint( 50, 50 ) ) )
Fix some issue with hierarchy panel on OSX. Also moves the option toolbars tight to the canvas for all windows. Fixes https://gitlab.com/kicad/code/kicad/issues/12087
2022-07-26 11:13:16 +00:00
.Show( false ) );
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
FromDIP symbol and footprint editor aui panes
2024-01-18 04:08:38 +00:00
m_auimgr.AddPane( m_propertiesPanel, defaultPropertiesPaneInfo( this ) );
ADDED: Selection filter for schematic editor Fixes https://gitlab.com/kicad/code/kicad/-/issues/14988
2024-02-25 22:39:14 +00:00
m_auimgr.AddPane( m_selectionFilterPanel, defaultSchSelectionFilterPaneInfo( this ) );
ADDED: Properties panel for schematic editor Initial infrastructure work; follow-ons will add more properties for schematic items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/6351 Fixes https://gitlab.com/kicad/code/kicad/-/issues/14105
2023-06-21 01:57:20 +00:00
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
m_auimgr.AddPane( createHighlightedNetNavigator(), defaultNetNavigatorPaneInfo() );
More wxSing
2023-01-17 04:14:38 +00:00
m_auimgr.AddPane( m_optionsToolBar, EDA_PANE().VToolbar().Name( wxS( "OptToolbar" ) )
Fix some issue with hierarchy panel on OSX. Also moves the option toolbars tight to the canvas for all windows. Fixes https://gitlab.com/kicad/code/kicad/issues/12087
2022-07-26 11:13:16 +00:00
.Left().Layer( 2 ) );
More wxSing
2023-01-17 04:14:38 +00:00
m_auimgr.AddPane( m_drawToolBar, EDA_PANE().VToolbar().Name( wxS( "ToolsToolbar" ) )
Fix some issues with Infobar sizing. This also commits to the new strategy as it wasn't really compatible with if-def-ing anymore.
2020-12-11 12:09:37 +00:00
.Right().Layer( 2 ) );
Fix some issue with hierarchy panel on OSX. Also moves the option toolbars tight to the canvas for all windows. Fixes https://gitlab.com/kicad/code/kicad/issues/12087
2022-07-26 11:13:16 +00:00
// Center
More wxSing
2023-01-17 04:14:38 +00:00
m_auimgr.AddPane( GetCanvas(), EDA_PANE().Canvas().Name( wxS( "DrawFrame" ) )
Fix some issues with Infobar sizing. This also commits to the new strategy as it wasn't really compatible with if-def-ing anymore.
2020-12-11 12:09:37 +00:00
.Center() );
Initial schematic search pane
2023-05-15 01:35:39 +00:00
m_auimgr.AddPane( m_searchPane, EDA_PANE()
Don't specify sizes when we don't need to. However, in some places we *do* have to because otherwise wxWidgets will pick a minimum size for us (and it's rather large). Fixes https://gitlab.com/kicad/code/kicad/-/issues/16039
2023-11-07 13:40:24 +00:00
.Name( SearchPaneName() )
.Bottom()
.Caption( _( "Search" ) )
.PaneBorder( false )
Sprinkle FromDIP in SCH_EDIT_FRAME aui setup
2024-01-18 03:05:54 +00:00
.MinSize( FromDIP( wxSize( 180, 60 ) ) )
.BestSize( FromDIP( wxSize( 180, 100 ) ) )
.FloatingSize( FromDIP( wxSize( 480, 200 ) ) )
Remove close buttons from schematic AUI Harmonizes with PCB editor Fixes https://gitlab.com/kicad/code/kicad/-/issues/17415
2024-03-12 23:51:27 +00:00
.CloseButton( false )
Don't specify sizes when we don't need to. However, in some places we *do* have to because otherwise wxWidgets will pick a minimum size for us (and it's rather large). Fixes https://gitlab.com/kicad/code/kicad/-/issues/16039
2023-11-07 13:40:24 +00:00
.DestroyOnClose( false )
.Show( m_show_search ) );
Initial schematic search pane
2023-05-15 01:35:39 +00:00
Fix some issue with hierarchy panel on OSX. Also moves the option toolbars tight to the canvas for all windows. Fixes https://gitlab.com/kicad/code/kicad/issues/12087
2022-07-26 11:13:16 +00:00
FinishAUIInitialization();
Eeschema, hierarchy navigator: fixes and enhancements. Work in progress.
2022-06-08 16:09:25 +00:00
Fix some issue with hierarchy panel on OSX. Also moves the option toolbars tight to the canvas for all windows. Fixes https://gitlab.com/kicad/code/kicad/issues/12087
2022-07-26 11:13:16 +00:00
resolveCanvasType();
SwitchCanvas( m_canvasType );
Eeschema, hierarchy navigator: fixes and enhancements. Work in progress.
2022-06-08 16:09:25 +00:00
Fix some issue with hierarchy panel on OSX. Also moves the option toolbars tight to the canvas for all windows. Fixes https://gitlab.com/kicad/code/kicad/issues/12087
2022-07-26 11:13:16 +00:00
GetCanvas()->GetGAL()->SetAxesEnabled( false );
KIGFX::SCH_VIEW* view = GetCanvas()->GetView();
static_cast<KIGFX::SCH_PAINTER*>( view->GetPainter() )->SetSchematic( m_schematic );
ADDED: Selection filter for schematic editor Fixes https://gitlab.com/kicad/code/kicad/-/issues/14988
2024-02-25 22:39:14 +00:00
wxAuiPaneInfo& hierarchy_pane = m_auimgr.GetPane( SchematicHierarchyPaneName() );
wxAuiPaneInfo& netNavigatorPane = m_auimgr.GetPane( NetNavigatorPaneName() );
wxAuiPaneInfo& propertiesPane = m_auimgr.GetPane( PropertiesPaneName() );
wxAuiPaneInfo& selectionFilterPane = m_auimgr.GetPane( wxS( "SelectionFilter" ) );
Fix some issue with hierarchy panel on OSX. Also moves the option toolbars tight to the canvas for all windows. Fixes https://gitlab.com/kicad/code/kicad/issues/12087
2022-07-26 11:13:16 +00:00
EESCHEMA_SETTINGS* cfg = eeconfig();
hierarchy_pane.Show( cfg->m_AuiPanels.show_schematic_hierarchy );
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
netNavigatorPane.Show( cfg->m_AuiPanels.show_net_nav_panel );
ADDED: Properties panel for schematic editor Initial infrastructure work; follow-ons will add more properties for schematic items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/6351 Fixes https://gitlab.com/kicad/code/kicad/-/issues/14105
2023-06-21 01:57:20 +00:00
propertiesPane.Show( cfg->m_AuiPanels.show_properties );
ADDED: Selection filter for schematic editor Fixes https://gitlab.com/kicad/code/kicad/-/issues/14988
2024-02-25 22:39:14 +00:00
updateSelectionFilterVisbility();
// The selection filter doesn't need to grow in the vertical direction when docked
selectionFilterPane.dock_proportion = 0;
Fix some issue with hierarchy panel on OSX. Also moves the option toolbars tight to the canvas for all windows. Fixes https://gitlab.com/kicad/code/kicad/issues/12087
2022-07-26 11:13:16 +00:00
if( cfg->m_AuiPanels.hierarchy_panel_float_width > 0
&& cfg->m_AuiPanels.hierarchy_panel_float_height > 0 )
{
// Show at end, after positioning
hierarchy_pane.FloatingSize( cfg->m_AuiPanels.hierarchy_panel_float_width,
cfg->m_AuiPanels.hierarchy_panel_float_height );
Eeschema, hierarchy navigator: fixes and enhancements. Work in progress.
2022-06-08 16:09:25 +00:00
}
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
if( cfg->m_AuiPanels.net_nav_panel_float_size.GetWidth() > 0
&& cfg->m_AuiPanels.net_nav_panel_float_size.GetHeight() > 0 )
{
netNavigatorPane.FloatingSize( cfg->m_AuiPanels.net_nav_panel_float_size );
EEschema, net navigator: save settings when closing Eeschema. Fixes #16845 https://gitlab.com/kicad/code/kicad/-/issues/16845
2024-02-01 11:53:33 +00:00
netNavigatorPane.FloatingPosition( cfg->m_AuiPanels.net_nav_panel_float_pos );
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
}
ADDED: Properties panel for schematic editor Initial infrastructure work; follow-ons will add more properties for schematic items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/6351 Fixes https://gitlab.com/kicad/code/kicad/-/issues/14105
2023-06-21 01:57:20 +00:00
if( cfg->m_AuiPanels.properties_panel_width > 0 )
SetAuiPaneSize( m_auimgr, propertiesPane, cfg->m_AuiPanels.properties_panel_width, -1 );
Fix some issue with hierarchy panel on OSX. Also moves the option toolbars tight to the canvas for all windows. Fixes https://gitlab.com/kicad/code/kicad/issues/12087
2022-07-26 11:13:16 +00:00
if( cfg->m_AuiPanels.schematic_hierarchy_float )
hierarchy_pane.Float();
Modify my previous patch about zoom issues in eeschema (remove zoom limitations). Also fix a minor zoom page issue in Libedit. wxMSW, version 2.8.x must be patched. Some zoom values smaller than 3 to 5 create artifacts on screen, mainly values < 1. (corresponding to draw scale factor > 1 ) * see http://trac.wxwidgets.org/ticket/9554 This is fixed in version 2.9.x Workaround: ( that is not a full fix, but remaining artifacts are acceptable ) edit file edit file <wxWidgets>/src/msw/dc.cpp >> search for line static const int VIEWPORT_EXTENT = 1000; >> and replace by static const int VIEWPORT_EXTENT = 10000;
2011-04-12 12:41:13 +00:00
eeschema: Fix Search pane not remembering docking sizes and positions Fixes https://gitlab.com/kicad/code/kicad/-/issues/14120 for eeschema Fixes that Show Search Panel Checkbox can get out of sync when restarting eeschema while the search pane is active
2023-05-19 20:51:57 +00:00
if( cfg->m_AuiPanels.search_panel_height > 0
&& ( cfg->m_AuiPanels.search_panel_dock_direction == wxAUI_DOCK_TOP
|| cfg->m_AuiPanels.search_panel_dock_direction == wxAUI_DOCK_BOTTOM ) )
Initial schematic search pane
2023-05-15 01:35:39 +00:00
{
wxAuiPaneInfo& searchPane = m_auimgr.GetPane( SearchPaneName() );
eeschema: Fix Search pane not remembering docking sizes and positions Fixes https://gitlab.com/kicad/code/kicad/-/issues/14120 for eeschema Fixes that Show Search Panel Checkbox can get out of sync when restarting eeschema while the search pane is active
2023-05-19 20:51:57 +00:00
searchPane.Direction( cfg->m_AuiPanels.search_panel_dock_direction );
Initial schematic search pane
2023-05-15 01:35:39 +00:00
SetAuiPaneSize( m_auimgr, searchPane, -1, cfg->m_AuiPanels.search_panel_height );
}
eeschema: Fix Search pane not remembering docking sizes and positions Fixes https://gitlab.com/kicad/code/kicad/-/issues/14120 for eeschema Fixes that Show Search Panel Checkbox can get out of sync when restarting eeschema while the search pane is active
2023-05-19 20:51:57 +00:00
else if( cfg->m_AuiPanels.search_panel_width > 0
&& ( cfg->m_AuiPanels.search_panel_dock_direction == wxAUI_DOCK_LEFT
|| cfg->m_AuiPanels.search_panel_dock_direction == wxAUI_DOCK_RIGHT ) )
{
wxAuiPaneInfo& searchPane = m_auimgr.GetPane( SearchPaneName() );
searchPane.Direction( cfg->m_AuiPanels.search_panel_dock_direction );
SetAuiPaneSize( m_auimgr, searchPane, cfg->m_AuiPanels.search_panel_width, -1 );
}
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
if( cfg->m_AuiPanels.float_net_nav_panel )
netNavigatorPane.Float();
Fix some issue with hierarchy panel on OSX. Also moves the option toolbars tight to the canvas for all windows. Fixes https://gitlab.com/kicad/code/kicad/issues/12087
2022-07-26 11:13:16 +00:00
if( cfg->m_AuiPanels.hierarchy_panel_docked_width > 0 )
{
Coding policy and Doxygen comment fixes.
2023-10-12 13:36:28 +00:00
// If the net navigator is not show, let the hierarchy navigator take all of the vertical
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
// space.
if( !cfg->m_AuiPanels.show_net_nav_panel )
{
SetAuiPaneSize( m_auimgr, hierarchy_pane,
cfg->m_AuiPanels.hierarchy_panel_docked_width, -1 );
}
else
{
SetAuiPaneSize( m_auimgr, hierarchy_pane,
cfg->m_AuiPanels.hierarchy_panel_docked_width,
cfg->m_AuiPanels.hierarchy_panel_docked_height );
SetAuiPaneSize( m_auimgr, netNavigatorPane,
cfg->m_AuiPanels.net_nav_panel_docked_size.GetWidth(),
cfg->m_AuiPanels.net_nav_panel_docked_size.GetHeight() );
}
Fix some issue with hierarchy panel on OSX. Also moves the option toolbars tight to the canvas for all windows. Fixes https://gitlab.com/kicad/code/kicad/issues/12087
2022-07-26 11:13:16 +00:00
// wxAUI hack: force width by setting MinSize() and then Fixed()
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
// thanks to ZenJu https://github.com/wxWidgets/wxWidgets/issues/13180
hierarchy_pane.MinSize( cfg->m_AuiPanels.hierarchy_panel_docked_width, 60 );
Fix some issue with hierarchy panel on OSX. Also moves the option toolbars tight to the canvas for all windows. Fixes https://gitlab.com/kicad/code/kicad/issues/12087
2022-07-26 11:13:16 +00:00
hierarchy_pane.Fixed();
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
netNavigatorPane.MinSize( cfg->m_AuiPanels.net_nav_panel_docked_size.GetWidth(), 60 );
netNavigatorPane.Fixed();
Fix some issue with hierarchy panel on OSX. Also moves the option toolbars tight to the canvas for all windows. Fixes https://gitlab.com/kicad/code/kicad/issues/12087
2022-07-26 11:13:16 +00:00
m_auimgr.Update();
// now make it resizable again
hierarchy_pane.Resizable();
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
netNavigatorPane.Resizable();
Fix some issue with hierarchy panel on OSX. Also moves the option toolbars tight to the canvas for all windows. Fixes https://gitlab.com/kicad/code/kicad/issues/12087
2022-07-26 11:13:16 +00:00
m_auimgr.Update();
// Note: DO NOT call m_auimgr.Update() anywhere after this; it will nuke the size
// back to minimum.
Sprinkle FromDIP in SCH_EDIT_FRAME aui setup
2024-01-18 03:05:54 +00:00
hierarchy_pane.MinSize( FromDIP( wxSize( 120, 60 ) ) );
netNavigatorPane.MinSize( FromDIP( wxSize( 120, 60 ) ) );
Fix some issue with hierarchy panel on OSX. Also moves the option toolbars tight to the canvas for all windows. Fixes https://gitlab.com/kicad/code/kicad/issues/12087
2022-07-26 11:13:16 +00:00
}
else
{
m_auimgr.Update();
}
Add acceleratedGraphics prompt for eeschema
2020-10-31 21:49:50 +00:00
Delay loading eeschema "project settings" to after the ui is ready
2021-05-01 20:13:48 +00:00
LoadProjectSettings();
ADDED operating point overlay for SCH_EDIT_FRAME. Fixes https://gitlab.com/kicad/code/kicad/issues/11253
2023-02-09 17:18:56 +00:00
view->SetLayerVisible( LAYER_ERC_ERR, cfg->m_Appearance.show_erc_errors );
view->SetLayerVisible( LAYER_ERC_WARN, cfg->m_Appearance.show_erc_warnings );
view->SetLayerVisible( LAYER_ERC_EXCLUSION, cfg->m_Appearance.show_erc_exclusions );
view->SetLayerVisible( LAYER_OP_VOLTAGES, cfg->m_Appearance.show_op_voltages );
view->SetLayerVisible( LAYER_OP_CURRENTS, cfg->m_Appearance.show_op_currents );
Mark null project initial screen as zoom-initialized The variable `m_Initialized` in `BASE_SCREEN` is used by `SCH_EDIT_FRAME` to mark whether a screen had its zoom level initialized by the "zoom to fit screen" action. When this variable is `false`, the function `SCH_EDIT_FRAME::DisplayCurrentSheet()` performs "zoom to fit screen", modifying the zoom level. This function is indirectly called in the undo routines, so if `m_Initialized` is not set to `true`, a zoom change will occur when the user undoes an operation, a behavior that is undesired. `m_Initialized` was not initialized to `true` for the null schematic (the schematic that is loaded if no project is loaded), causing the aforementioned undesired behavior. To prevent this, I've changed the `SCH_EDIT_FRAME` constructor to set `m_Initialized` to `true`, since it zooms to fit screen already. I've moved `m_Initialized` from `BASE_SCREEN` to `SCH_SCREEN`, as it is used only in Eeschema, and renamed it to `m_zoomInitialized`, a name I believe that better describes what this variable does. I've also introduced the function `SCH_EDIT_FRAME::initScreenZoom()` to group the "zoom to fit screen" action with setting `m_Initialized` to `true`, as they often should occur together. I'd also like to say that I'm not confident whether `SCH_EDIT_FRAME::DisplayCurrentSheet()` should perform the zoom level initialization at this point, but I have decided to not change this behavior for now, as the commit history suggests it's several years old. Fixes https://gitlab.com/kicad/code/kicad/issues/7343
2021-01-30 22:47:39 +00:00
initScreenZoom();
Eeschema: enhancement on Windows: adds a show console option for BOM plugin execution (needed for instance by python plugins which are run with pythonw)
2016-03-31 06:28:16 +00:00
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
m_hierarchy->Bind( wxEVT_SIZE, &SCH_EDIT_FRAME::OnResizeHierarchyNavigator, this );
m_netNavigator->Bind( wxEVT_TREE_SEL_CHANGING, &SCH_EDIT_FRAME::onNetNavigatorSelChanging,
this );
m_netNavigator->Bind( wxEVT_TREE_SEL_CHANGED, &SCH_EDIT_FRAME::onNetNavigatorSelection, this );
m_netNavigator->Bind( wxEVT_SIZE, &SCH_EDIT_FRAME::onResizeNetNavigator, this );
Eeschema: fixes about Hierarchy panel/pane handling
2022-06-09 17:39:35 +00:00
Fix initial zoom to fit size in schematic and board editors. This may affect other EDA_DRAW_FRAME objects as well but it doesn't seem to be as noticeable in the symbol, footprint, and worksheet editors. Fixes https://gitlab.com/kicad/code/kicad/issues/5248
2020-08-20 14:33:12 +00:00
// This is used temporarily to fix a client size issue on GTK that causes zoom to fit
// to calculate the wrong zoom size. See SCH_EDIT_FRAME::onSize().
Bind( wxEVT_SIZE, &SCH_EDIT_FRAME::onSize, this );
Switch to showing metric/imperial units in comboboxes and menus This will always show 1 unit from each system, with the primary unit being the current frame unit and the secondary unit being the most recent unit used from the other system. These are saved in the settings, so they are saved between runs.
2020-10-05 19:26:33 +00:00
setupUnits( eeconfig() );
Update exit strategy to match UI guidelines In singletop mode, all frames show the "Quit" option in the file menu and will quit on Ctrl-Q. When launched from the main KiCad interface, sub-programs show the "Close" option instead and will close with Ctrl-W. In this mode, Ctrl-Q will instruct the main program to exit. Fixes: lp:1779938 * https://bugs.launchpad.net/kicad/+bug/1779938
2019-06-25 04:44:34 +00:00
Eeschema: enhancement on Windows: adds a show console option for BOM plugin execution (needed for instance by python plugins which are run with pythonw)
2016-03-31 06:28:16 +00:00
// Net list generator
DefaultExecFlags();
Eeschema: add symbol library table editor dialog. Create a new dialog to edit global and project specific symbol library tables. Add menu entries for new symbol library table editor in schematic editor and symbol library editor main frame menus. Add command event handler for symbol library table editor dialog to SCH_BASE_FRAME so it is accessible from derived frames. Fix bug in default environment variables initialization. A test for existing user defined environment variables was preventing any new default environment variables added to the list from being initialized.
2017-08-12 12:09:39 +00:00
Fix naming of `updateTitle()` This is a private function so should be lowercased to avoid confusion
2023-01-12 00:05:43 +00:00
updateTitle();
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
m_toolManager->GetTool<SCH_NAVIGATE_TOOL>()->ResetHistory();
Add shutdown blocking on Windows for pcbnew, eeschema and pleditor ADDED: Block shutdown/logoff on Windows when contents have been modified
2019-12-19 14:11:11 +00:00
Add QA tests and expand serialization for API
2024-01-20 23:35:29 +00:00
#ifdef KICAD_IPC_API
m_apiHandler = std::make_unique<API_HANDLER_SCH>( this );
Pgm().GetApiServer().RegisterHandler( m_apiHandler.get() );
#endif
Add shutdown blocking on Windows for pcbnew, eeschema and pleditor ADDED: Block shutdown/logoff on Windows when contents have been modified
2019-12-19 14:11:11 +00:00
// Default shutdown reason until a file is loaded
Move shutdown blocker to kiplatform
2020-09-01 10:14:51 +00:00
KIPLATFORM::APP::SetShutdownBlockReason( this, _( "New schematic file is unsaved" ) );
Rewrite window positioning logic Now only reposition a window if it is completely on a disconnected display or if only one corner is on screen and it is within a region close to the screen border. CHANGED: Window position on startup should be preserved more
2020-04-17 23:32:29 +00:00
ADDED: Implement Drag and Drop dropping files to Kicad manager : *.kicad_pro, *.pro -> open project; gerber and job files -> open in Gerbview editor; Eagle and Cadstar files -> open project. dropping file to schematic editor -> append schematic; dropping library file to Symbol editor -> add library; dropping board file to PCB editor -> append board; dropping library or footprint file to Footprint editor -> add library or import footprint; dropping ZIP file or gerber files to Gerbview editor -> open files; dropping sheet file to Drawing Sheet editor -> open sheet. Fixes https://gitlab.com/kicad/code/kicad/-/issues/11638
2022-09-14 22:28:09 +00:00
// Init for dropping files
Kick the wildcards and file exts into a static class, export it from kicommon
2023-12-28 02:10:01 +00:00
m_acceptedExts.emplace( FILEEXT::KiCadSchematicFileExtension, &EE_ACTIONS::ddAppendFile );
ADDED: Implement Drag and Drop dropping files to Kicad manager : *.kicad_pro, *.pro -> open project; gerber and job files -> open in Gerbview editor; Eagle and Cadstar files -> open project. dropping file to schematic editor -> append schematic; dropping library file to Symbol editor -> add library; dropping board file to PCB editor -> append board; dropping library or footprint file to Footprint editor -> add library or import footprint; dropping ZIP file or gerber files to Gerbview editor -> open files; dropping sheet file to Drawing Sheet editor -> open sheet. Fixes https://gitlab.com/kicad/code/kicad/-/issues/11638
2022-09-14 22:28:09 +00:00
DragAcceptFiles( true );
Rewrite window positioning logic Now only reposition a window if it is completely on a disconnected display or if only one corner is on screen and it is within a region close to the screen border. CHANGED: Window position on startup should be preserved more
2020-04-17 23:32:29 +00:00
// Ensure the window is on top
Raise();
Eeschema, hierarchy navigator: fixes and enhancements. Work in progress.
2022-06-08 16:09:25 +00:00
Fix some issue with hierarchy panel on OSX. Also moves the option toolbars tight to the canvas for all windows. Fixes https://gitlab.com/kicad/code/kicad/issues/12087
2022-07-26 11:13:16 +00:00
// Now that all sizes are fixed, set the initial hierarchy_pane floating position to the
// top-left corner of the canvas
Eeschema, hierarchy navigator: fixes and enhancements. Work in progress.
2022-06-08 16:09:25 +00:00
wxPoint canvas_pos = GetCanvas()->GetScreenPosition();
hierarchy_pane.FloatingPosition( canvas_pos.x + 10, canvas_pos.y + 10 );
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
Bind( EDA_EVT_CLOSE_DIALOG_BOOK_REPORTER, &SCH_EDIT_FRAME::onCloseSymbolDiffDialog, this );
Bind( EDA_EVT_CLOSE_ERC_DIALOG, &SCH_EDIT_FRAME::onCloseErcDialog, this );
Symbol Fields Table: make non-modal Fixes: https://gitlab.com/kicad/code/kicad/-/issues/2141
2023-08-14 14:41:28 +00:00
Bind( EDA_EVT_CLOSE_DIALOG_SYMBOL_FIELDS_TABLE, &SCH_EDIT_FRAME::onCloseSymbolFieldsTableDialog,
this );
Initial import of KiCad.
2007-05-06 16:03:28 +00:00
}
Minor fixes and lots of coding policy changes.
2010-12-08 20:12:46 +00:00
SCH_EDIT_FRAME::~SCH_EDIT_FRAME()
Initial import of KiCad.
2007-05-06 16:03:28 +00:00
{
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
m_hierarchy->Unbind( wxEVT_SIZE, &SCH_EDIT_FRAME::OnResizeHierarchyNavigator, this );
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
Eeschema: ensure the actual canvas type is saved in config. The saved type was not updated after switching the canvas type from Preferences.
2021-05-17 09:44:17 +00:00
// Ensure m_canvasType is up to date, to save it in config
m_canvasType = GetCanvas()->GetBackend();
More NULL expunging.
2021-07-16 20:13:26 +00:00
SetScreen( nullptr );
Modular KiCad Blueprint Milestone B), major portions: *) When kicad.exe closes a project, close any open KIFACEs so that they cannot get disassociated from their true PROJECT. *) Allow loading eeschema library editor from kicad.exe *) Allow loading pcbnew library editor from kicad.exe *) Rename LIB_COMPONENT to LIB_PART. *) Add class PART_LIBS, and PART_LIB. *) Make PART_LIBS non-global, i.e. PROJECT specific. *) Implement "data on demand" for PART_LIBS *) Implement "data on demand" for schematic SEARCH_STACK. *) Use RSTRINGs to retain eeschema editor's notion of last library and part being edited. *) Get rid of library search on every SCH_COMPONENT::Draw() call, instead use a weak pointer. *) Remove all chdir() calls so projects don't need to be CWD. *) Romove APPEND support from OpenProjectFiles(). *) Make OpenProjectFiles() robust, even for creating new projects. *) Load EESCHEMA colors in the KIWAY::OnKiwayStart() rather in window open, and save them in the .eeschema config file, not in the project file. *) Fix bug with wxDir() while accessing protected dirs in kicad.exe *) Consolidate template copying into PROJECT class, not in kicad.exe source. *) Generally untangle eeschema, making its libraries not global but rather held in the PROJECT.
2014-08-13 20:28:54 +00:00
Add SCHEMATIC_LISTENER equivalent to BOARD_LISTENER
2023-05-11 02:53:10 +00:00
if( m_schematic )
m_schematic->RemoveAllListeners();
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
delete m_schematic;
Don't access tools after they've shut down.
2020-12-29 17:29:24 +00:00
m_schematic = nullptr;
Make sure projects are cleaned up nicely when frames close PROJECT objects will be deleted by SETTINGS_MANAGER::UnloadProject so we need to make sure that this is called at an early enough point in the closing process that anything needed by the PROJECT dtor is still around. Also fix an issue where the schematic worksheet was depending on the project existing after the schematic had been reset.
2020-08-08 20:52:57 +00:00
// Close the project if we are standalone, so it gets cleaned up properly
if( Kiface().IsSingle() )
Coverity issue fixes.
2021-11-13 16:38:19 +00:00
{
try
{
GetSettingsManager()->UnloadProject( &Prj(), false );
}
catch( const nlohmann::detail::type_error& exc )
{
// This may be overkill and could be an assertion but we are more likely to
// find any settings manager errors this way.
wxLogError( wxT( "Settings exception '%s' occurred." ), exc.what() );
}
}
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
delete m_hierarchy;
ADDED: Selection filter for schematic editor Fixes https://gitlab.com/kicad/code/kicad/-/issues/14988
2024-02-25 22:39:14 +00:00
delete m_selectionFilterPanel;
2008-Feb-12 UPDATE Tim Hanson sideskate@gmail.com ================================================================================ +eeschema * commiting my changes to allow multiple instances of a given schematic file within a hierarchy: ** internally, m_currentScreen has been replaced with m_currentSheet, which is a list or 'path' of screens. The path of screens is used to generate a series of timestamps, which is converted to flat component reference via a look-up table in the schematic files. ** this means that m_currentScreen is no longer used -- use GetScreen(). ** GetScreen is virtual, as some of the dialogs keep around a WinEDA_BaseScreen pointer. ** all sub-sheets in a given schematic must have different names to generate a meaningful netlist.
2008-02-12 21:12:46 +00:00
}
annotate dialog HIGification, refactor and beautify associated annotation code
2008-02-26 01:07:38 +00:00
Lock file improvements.
2014-09-07 19:01:26 +00:00
Eeschema: fixes about Hierarchy panel/pane handling
2022-06-09 17:39:35 +00:00
void SCH_EDIT_FRAME::OnResizeHierarchyNavigator( wxSizeEvent& aEvent )
{
aEvent.Skip();
// Called when resizing the Hierarchy Navigator panel
// Store the current pane size
// It allows to retrieve the last defined pane size when switching between
// docked and floating pane state
Coding policy and Doxygen comment fixes.
2023-10-12 13:36:28 +00:00
// Note: *DO NOT* call m_auimgr.Update() here: it crashes KiCad at least on Windows
Eeschema: fixes about Hierarchy panel/pane handling
2022-06-09 17:39:35 +00:00
EESCHEMA_SETTINGS* cfg = dynamic_cast<EESCHEMA_SETTINGS*>( Kiface().KifaceSettings() );
wxAuiPaneInfo& hierarchy_pane = m_auimgr.GetPane( SchematicHierarchyPaneName() );
Use IsShownOnScreen(), not IsShown(), if you really want to know if its visible.
2021-08-19 21:28:54 +00:00
if( cfg && m_hierarchy->IsShownOnScreen() )
Eeschema: fixes about Hierarchy panel/pane handling
2022-06-09 17:39:35 +00:00
{
cfg->m_AuiPanels.hierarchy_panel_float_width = hierarchy_pane.floating_size.x;
cfg->m_AuiPanels.hierarchy_panel_float_height = hierarchy_pane.floating_size.y;
// initialize hierarchy_panel_docked_width and best size only if the hierarchy_pane
// width is > 0 (i.e. if its size is already set and has meaning)
// if it is floating, its size is not initialized (only floating_size is initialized)
// initializing hierarchy_pane.best_size is useful when switching to float pane and
// after switching to the docked pane, to retrieve the last docked pane width
if( hierarchy_pane.rect.width > 50 ) // 50 is a good margin
{
cfg->m_AuiPanels.hierarchy_panel_docked_width = hierarchy_pane.rect.width;
hierarchy_pane.best_size.x = hierarchy_pane.rect.width;
}
}
}
Move to direct tool registration. It was confusing that the primary frames registered their tools differently than the other frames. In addition, since the other frames also added their own tools, foo_actions::RegisterAllTools() didn't really register all tool but rather those used by the principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
2019-05-04 11:23:04 +00:00
void SCH_EDIT_FRAME::setupTools()
{
// Create the manager and dispatcher & route draw panel events to the dispatcher
m_toolManager = new TOOL_MANAGER;
Flatten some settings and remove some more globals.
2020-05-23 15:50:08 +00:00
m_toolManager->SetEnvironment( &Schematic(), GetCanvas()->GetView(),
Push a couple of layers of indirection out of grid settings.
2020-06-12 10:58:56 +00:00
GetCanvas()->GetViewControls(), config(), this );
Naming changes to reflect sharing between SchEdit and LibEdit.
2019-05-10 17:19:48 +00:00
m_actions = new EE_ACTIONS();
Remove ACTIONS::TranslateLegacyId and TOOL_DISPATCHER::DispatchWxCommand After commit 9535153f9e there were no more IDs inside the legacy ID system. Therefore the entire system for dispatching and looking up the legacy ideas and handling those events can now be removed and the tool dispatcher simplified (it no longer needs to know about the ACTIONS class).
2021-03-27 20:02:34 +00:00
m_toolDispatcher = new TOOL_DISPATCHER( m_toolManager );
Move to direct tool registration. It was confusing that the primary frames registered their tools differently than the other frames. In addition, since the other frames also added their own tools, foo_actions::RegisterAllTools() didn't really register all tool but rather those used by the principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
2019-05-04 11:23:04 +00:00
// Register tools
Move hotkeys to ACTION architecture.
2019-06-09 21:57:23 +00:00
m_toolManager->RegisterTool( new COMMON_CONTROL );
Move to direct tool registration. It was confusing that the primary frames registered their tools differently than the other frames. In addition, since the other frames also added their own tools, foo_actions::RegisterAllTools() didn't really register all tool but rather those used by the principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
2019-05-04 11:23:04 +00:00
m_toolManager->RegisterTool( new COMMON_TOOLS );
m_toolManager->RegisterTool( new ZOOM_TOOL );
Naming changes to reflect sharing between SchEdit and LibEdit.
2019-05-10 17:19:48 +00:00
m_toolManager->RegisterTool( new EE_SELECTION_TOOL );
Push Eeschema & PLEditor PICKER_TOOLs down into common. Also implements a more robust push/pop tool strategy for pickers.
2019-07-15 23:44:01 +00:00
m_toolManager->RegisterTool( new PICKER_TOOL );
Move Pin, Symbol Text and Symbol Anchor to modern toolset.
2019-05-07 18:49:53 +00:00
m_toolManager->RegisterTool( new SCH_DRAWING_TOOLS );
Use more reflective naming of what the tool does.
2019-06-16 13:42:40 +00:00
m_toolManager->RegisterTool( new SCH_LINE_WIRE_BUS_TOOL );
Do some refactoring in prep for sharing some sch tools with libedit.
2019-05-04 13:02:05 +00:00
m_toolManager->RegisterTool( new SCH_MOVE_TOOL );
Move to direct tool registration. It was confusing that the primary frames registered their tools differently than the other frames. In addition, since the other frames also added their own tools, foo_actions::RegisterAllTools() didn't really register all tool but rather those used by the principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
2019-05-04 11:23:04 +00:00
m_toolManager->RegisterTool( new SCH_EDIT_TOOL );
ADDED: schematic tables. Fixes https://gitlab.com/kicad/code/kicad/-/issues/6806
2023-11-25 12:38:24 +00:00
m_toolManager->RegisterTool( new SCH_EDIT_TABLE_TOOL );
Naming changes to reflect sharing between SchEdit and LibEdit.
2019-05-10 17:19:48 +00:00
m_toolManager->RegisterTool( new EE_INSPECTION_TOOL );
Move to direct tool registration. It was confusing that the primary frames registered their tools differently than the other frames. In addition, since the other frames also added their own tools, foo_actions::RegisterAllTools() didn't really register all tool but rather those used by the principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
2019-05-04 11:23:04 +00:00
m_toolManager->RegisterTool( new SCH_EDITOR_CONTROL );
Move find/replace to own tool so it doesn't rob events from cross-probing.
2023-01-11 14:17:36 +00:00
m_toolManager->RegisterTool( new SCH_FIND_REPLACE_TOOL );
Naming changes to reflect sharing between SchEdit and LibEdit.
2019-05-10 17:19:48 +00:00
m_toolManager->RegisterTool( new EE_POINT_EDITOR );
Implement hypertext links for intersheet references.
2020-10-02 20:18:07 +00:00
m_toolManager->RegisterTool( new SCH_NAVIGATE_TOOL );
ADDED: Properties panel for schematic editor Initial infrastructure work; follow-ons will add more properties for schematic items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/6351 Fixes https://gitlab.com/kicad/code/kicad/-/issues/14105
2023-06-21 01:57:20 +00:00
m_toolManager->RegisterTool( new PROPERTIES_TOOL );
Move to direct tool registration. It was confusing that the primary frames registered their tools differently than the other frames. In addition, since the other frames also added their own tools, foo_actions::RegisterAllTools() didn't really register all tool but rather those used by the principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
2019-05-04 11:23:04 +00:00
m_toolManager->InitTools();
// Run the selection tool, it is supposed to be always active
Separate immediate and delayed action dispatch Using a boolean argument just leads to a lot of trailing booleans in the function calls and is not user friendly. Instead, introduce PostAction() to send an action that runs after the coroutine (equivalent to passing false or the default argument), and leave RunAction as the immediate execution function.
2023-06-26 22:16:51 +00:00
m_toolManager->PostAction( EE_ACTIONS::selectionActivate );
Move to direct tool registration. It was confusing that the primary frames registered their tools differently than the other frames. In addition, since the other frames also added their own tools, foo_actions::RegisterAllTools() didn't really register all tool but rather those used by the principal frame (PCB_EDIT_FRAME, SCH_EDIT_FRAME, etc.)
2019-05-04 11:23:04 +00:00
GetCanvas()->SetEventDispatcher( m_toolDispatcher );
}
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
void SCH_EDIT_FRAME::setupUIConditions()
{
SCH_BASE_FRAME::setupUIConditions();
Treat undo as backspace and/or escape when drawing. Ignore redo. Undo == backspace when drawing a polygon or chained lines. Otherwise it's an escape. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14961
2023-06-16 20:44:16 +00:00
ACTION_MANAGER* mgr = m_toolManager->GetActionManager();
Schematic: new feature, force 45 degree lines * New modes to force 45 deg angle at beginning or end of line * Backspace will undo most recent segment added * / will toggle posture of 90 and 45 degree lines * Added alg::signbit for convenience Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10869 Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9175
2022-03-22 16:49:38 +00:00
SCH_EDITOR_CONDITIONS cond( this );
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
wxASSERT( mgr );
eeschema: Add select all to schematic and library editor Fixes https://gitlab.com/kicad/code/kicad/issues/2497
2020-08-20 23:05:21 +00:00
auto hasElements =
[ this ] ( const SELECTION& aSel )
{
Check before dereference Fixes a crash where the screen was destroyed during new loading but still gets dereferenced by the UI update. Also puts defensive checks in the UI conditions against null configuration settings
2021-09-28 15:41:46 +00:00
return GetScreen() &&
( !GetScreen()->Items().empty() || !SELECTION_CONDITIONS::Idle( aSel ) );
eeschema: Add select all to schematic and library editor Fixes https://gitlab.com/kicad/code/kicad/issues/2497
2020-08-20 23:05:21 +00:00
};
Implement UI condition for search panel visibility. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14826
2023-06-04 14:01:06 +00:00
auto searchPaneCond =
Nullptr safety for UI Conditions. We don't really control when these are called, so best not to assume we've finished initialization of the frame/screen/document/whatever. Possible fix for KICAD-KY.
2023-06-12 11:38:50 +00:00
[this] ( const SELECTION& )
{
return m_auimgr.GetPane( SearchPaneName() ).IsShown();
};
Implement UI condition for search panel visibility. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14826
2023-06-04 14:01:06 +00:00
ADDED: Properties panel for schematic editor Initial infrastructure work; follow-ons will add more properties for schematic items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/6351 Fixes https://gitlab.com/kicad/code/kicad/-/issues/14105
2023-06-21 01:57:20 +00:00
auto propertiesCond =
[this] ( const SELECTION& )
{
return m_auimgr.GetPane( PropertiesPaneName() ).IsShown();
};
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
auto hierarchyNavigatorCond =
[ this ] ( const SELECTION& aSel )
{
Eeschema, Hierarchy navigator: add tool to Hide/show the panel. Add also a close button to the pane.
2022-06-07 09:00:13 +00:00
return m_auimgr.GetPane( SchematicHierarchyPaneName() ).IsShown();
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
};
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
auto netNavigatorCond =
[ this ] (const SELECTION& aSel )
{
return m_auimgr.GetPane( NetNavigatorPaneName() ).IsShown();
};
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
Treat undo as backspace and/or escape when drawing. Ignore redo. Undo == backspace when drawing a polygon or chained lines. Otherwise it's an escape. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14961
2023-06-16 20:44:16 +00:00
auto undoCond =
[ this ] (const SELECTION& aSel )
{
if( SCH_LINE_WIRE_BUS_TOOL::IsDrawingLineWireOrBus( aSel ) )
return true;
return GetUndoCommandCount() > 0;
};
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
#define ENABLE( x ) ACTION_CONDITIONS().Enable( x )
#define CHECK( x ) ACTION_CONDITIONS().Check( x )
Always enable save; move dirty bit to asterisk in title bar. Also unifies PCB Editor and Schematic Editor names with other locations in the GUI (which were still Pcbnew and Eeschema). Fixes https://gitlab.com/kicad/code/kicad/issues/7587 Fixes https://gitlab.com/kicad/code/kicad/issues/7594
2021-02-18 15:49:35 +00:00
mgr->SetConditions( ACTIONS::save, ENABLE( SELECTION_CONDITIONS::ShowAlways ) );
Treat undo as backspace and/or escape when drawing. Ignore redo. Undo == backspace when drawing a polygon or chained lines. Otherwise it's an escape. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14961
2023-06-16 20:44:16 +00:00
mgr->SetConditions( ACTIONS::undo, ENABLE( undoCond ) );
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
mgr->SetConditions( ACTIONS::redo, ENABLE( cond.RedoAvailable() ) );
Implement UI condition for search panel visibility. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14826
2023-06-04 14:01:06 +00:00
mgr->SetConditions( EE_ACTIONS::showSearch, CHECK( searchPaneCond ) );
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
mgr->SetConditions( EE_ACTIONS::showHierarchy, CHECK( hierarchyNavigatorCond ) );
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
mgr->SetConditions( EE_ACTIONS::showNetNavigator, CHECK( netNavigatorCond ) );
ADDED: Properties panel for schematic editor Initial infrastructure work; follow-ons will add more properties for schematic items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/6351 Fixes https://gitlab.com/kicad/code/kicad/-/issues/14105
2023-06-21 01:57:20 +00:00
mgr->SetConditions( ACTIONS::showProperties, CHECK( propertiesCond ) );
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
mgr->SetConditions( ACTIONS::toggleGrid, CHECK( cond.GridVisible() ) );
Grid Overrides: support grids-per-type that override the current grid. Schematic only at this point while we test and refine. PCB support is a future addition. Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14756
2023-07-23 17:51:42 +00:00
mgr->SetConditions( ACTIONS::toggleGridOverrides, CHECK( cond.GridOverrides() ) );
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
mgr->SetConditions( ACTIONS::toggleCursorStyle, CHECK( cond.FullscreenCursor() ) );
More NULL expunging.
2021-07-16 20:13:26 +00:00
mgr->SetConditions( ACTIONS::millimetersUnits,
CHECK( cond.Units( EDA_UNITS::MILLIMETRES ) ) );
Introduce new action to switch to mils as a unit
2020-10-03 23:34:23 +00:00
mgr->SetConditions( ACTIONS::inchesUnits, CHECK( cond.Units( EDA_UNITS::INCHES ) ) );
mgr->SetConditions( ACTIONS::milsUnits, CHECK( cond.Units( EDA_UNITS::MILS ) ) );
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
mgr->SetConditions( EE_ACTIONS::lineModeFree,
CHECK( cond.LineMode( LINE_MODE::LINE_MODE_FREE ) ) );
mgr->SetConditions( EE_ACTIONS::lineMode90,
CHECK( cond.LineMode( LINE_MODE::LINE_MODE_90 ) ) );
mgr->SetConditions( EE_ACTIONS::lineMode45,
CHECK( cond.LineMode( LINE_MODE::LINE_MODE_45 ) ) );
Schematic: new feature, force 45 degree lines * New modes to force 45 deg angle at beginning or end of line * Backspace will undo most recent segment added * / will toggle posture of 90 and 45 degree lines * Added alg::signbit for convenience Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10869 Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9175
2022-03-22 16:49:38 +00:00
Remove conditions from common immediate-mode keys The conditions prevent use in immediate mode for common actions. While this makes enable/disable easier in menu items, this fix is a patch until we refactor the action framework to distinguish between immediate mode hotkeys that should start without selections and menu items that need a selection before running. Fixes https://gitlab.com/kicad/code/kicad/issues/5333
2021-01-31 22:43:46 +00:00
mgr->SetConditions( ACTIONS::cut, ENABLE( hasElements ) );
mgr->SetConditions( ACTIONS::copy, ENABLE( hasElements ) );
Revert "Use lambdas to fix paste conditions" This reverts commit 65c7c77c3df1791bfde29a01a76007ec68e93c4c.
2021-05-31 01:25:42 +00:00
mgr->SetConditions( ACTIONS::paste, ENABLE( SELECTION_CONDITIONS::Idle ) );
mgr->SetConditions( ACTIONS::pasteSpecial, ENABLE( SELECTION_CONDITIONS::Idle ) );
Remove conditions from common immediate-mode keys The conditions prevent use in immediate mode for common actions. While this makes enable/disable easier in menu items, this fix is a patch until we refactor the action framework to distinguish between immediate mode hotkeys that should start without selections and menu items that need a selection before running. Fixes https://gitlab.com/kicad/code/kicad/issues/5333
2021-01-31 22:43:46 +00:00
mgr->SetConditions( ACTIONS::doDelete, ENABLE( hasElements ) );
mgr->SetConditions( ACTIONS::duplicate, ENABLE( hasElements ) );
eeschema: Add select all to schematic and library editor Fixes https://gitlab.com/kicad/code/kicad/issues/2497
2020-08-20 23:05:21 +00:00
mgr->SetConditions( ACTIONS::selectAll, ENABLE( hasElements ) );
Add Unselect all in menu
2023-09-06 23:44:39 +00:00
mgr->SetConditions( ACTIONS::unselectAll, ENABLE( hasElements ) );
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
Rotate/Mirror: unbreak immediate mode actions
2023-01-03 21:05:52 +00:00
mgr->SetConditions( EE_ACTIONS::rotateCW, ENABLE( hasElements ) );
mgr->SetConditions( EE_ACTIONS::rotateCCW, ENABLE( hasElements ) );
mgr->SetConditions( EE_ACTIONS::mirrorH, ENABLE( hasElements ) );
mgr->SetConditions( EE_ACTIONS::mirrorV, ENABLE( hasElements ) );
Add conditions for rotate/group/lock items in toolbar. Also fixes cut/copy/delete conditions to allow use in immediate mode.
2021-02-18 00:07:28 +00:00
More NULL expunging.
2021-07-16 20:13:26 +00:00
mgr->SetConditions( ACTIONS::zoomTool,
CHECK( cond.CurrentTool( ACTIONS::zoomTool ) ) );
mgr->SetConditions( ACTIONS::selectionTool,
CHECK( cond.CurrentTool( ACTIONS::selectionTool ) ) );
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
Fix python console toggle to work across pcbnew/eeschema
2021-07-02 19:05:16 +00:00
if( SCRIPTING::IsWxAvailable() )
Add show/hide controls for ERC markers. ADDED show/hide controls for ERC warnings, ERC errors and ERC exclusions. Fixes https://gitlab.com/kicad/code/kicad/issues/7270
2021-11-05 21:16:26 +00:00
{
More NULL expunging.
2021-07-16 20:13:26 +00:00
mgr->SetConditions( EE_ACTIONS::showPythonConsole,
CHECK( cond.ScriptingConsoleVisible() ) );
Add show/hide controls for ERC markers. ADDED show/hide controls for ERC warnings, ERC errors and ERC exclusions. Fixes https://gitlab.com/kicad/code/kicad/issues/7270
2021-11-05 21:16:26 +00:00
}
Fix python console toggle to work across pcbnew/eeschema
2021-07-02 19:05:16 +00:00
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
auto showHiddenPinsCond =
Add show/hide controls for ERC markers. ADDED show/hide controls for ERC warnings, ERC errors and ERC exclusions. Fixes https://gitlab.com/kicad/code/kicad/issues/7270
2021-11-05 21:16:26 +00:00
[this]( const SELECTION& )
{
return GetShowAllPins();
};
auto showHiddenFieldsCond =
[this]( const SELECTION& )
{
EESCHEMA_SETTINGS* cfg = eeconfig();
return cfg && cfg->m_Appearance.show_hidden_fields;
};
ADDED: show/hide controls for directive labels.
2023-04-27 16:59:53 +00:00
auto showDirectiveLabelsCond =
[this]( const SELECTION& )
{
EESCHEMA_SETTINGS* cfg = eeconfig();
return cfg && cfg->m_Appearance.show_directive_labels;
};
Add show/hide controls for ERC markers. ADDED show/hide controls for ERC warnings, ERC errors and ERC exclusions. Fixes https://gitlab.com/kicad/code/kicad/issues/7270
2021-11-05 21:16:26 +00:00
auto showERCErrorsCond =
[this]( const SELECTION& )
{
EESCHEMA_SETTINGS* cfg = eeconfig();
return cfg && cfg->m_Appearance.show_erc_errors;
};
auto showERCWarningsCond =
[this]( const SELECTION& )
{
EESCHEMA_SETTINGS* cfg = eeconfig();
return cfg && cfg->m_Appearance.show_erc_warnings;
};
auto showERCExclusionsCond =
[this]( const SELECTION& )
{
EESCHEMA_SETTINGS* cfg = eeconfig();
return cfg && cfg->m_Appearance.show_erc_exclusions;
};
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
ADDED: markers for excluded-from-sim items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15382
2024-06-03 12:59:40 +00:00
auto markSimExclusionsCond =
[this]( const SELECTION& )
{
EESCHEMA_SETTINGS* cfg = eeconfig();
return cfg && cfg->m_Appearance.mark_sim_exclusions;
};
ADDED operating point overlay for SCH_EDIT_FRAME. Fixes https://gitlab.com/kicad/code/kicad/issues/11253
2023-02-09 17:18:56 +00:00
auto showOPVoltagesCond =
[this]( const SELECTION& )
{
EESCHEMA_SETTINGS* cfg = eeconfig();
return cfg && cfg->m_Appearance.show_op_voltages;
};
auto showOPCurrentsCond =
[this]( const SELECTION& )
{
EESCHEMA_SETTINGS* cfg = eeconfig();
return cfg && cfg->m_Appearance.show_op_currents;
};
Schematic: add automatic annotation toggle
2022-04-21 17:06:28 +00:00
auto showAnnotateAutomaticallyCond =
[this]( const SELECTION& )
{
EESCHEMA_SETTINGS* cfg = eeconfig();
return cfg && cfg->m_AnnotatePanel.automatic;
};
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
auto remapSymbolsCondition =
Add show/hide controls for ERC markers. ADDED show/hide controls for ERC warnings, ERC errors and ERC exclusions. Fixes https://gitlab.com/kicad/code/kicad/issues/7270
2021-11-05 21:16:26 +00:00
[&]( const SELECTION& aSel )
{
SCH_SCREENS schematic( Schematic().Root() );
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
Add show/hide controls for ERC markers. ADDED show/hide controls for ERC warnings, ERC errors and ERC exclusions. Fixes https://gitlab.com/kicad/code/kicad/issues/7270
2021-11-05 21:16:26 +00:00
// The remapping can only be performed on legacy projects.
return schematic.HasNoFullyDefinedLibIds();
};
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
auto belowRootSheetCondition =
Add show/hide controls for ERC markers. ADDED show/hide controls for ERC warnings, ERC errors and ERC exclusions. Fixes https://gitlab.com/kicad/code/kicad/issues/7270
2021-11-05 21:16:26 +00:00
[this]( const SELECTION& aSel )
{
Nullptr safety for UI Conditions. We don't really control when these are called, so best not to assume we've finished initialization of the frame/screen/document/whatever. Possible fix for KICAD-KY.
2023-06-12 11:38:50 +00:00
SCH_NAVIGATE_TOOL* navigateTool = m_toolManager->GetTool<SCH_NAVIGATE_TOOL>();
return navigateTool && navigateTool->CanGoUp();
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
};
auto navSchematicHasPreviousSheet =
[this]( const SELECTION& aSel )
{
Nullptr safety for UI Conditions. We don't really control when these are called, so best not to assume we've finished initialization of the frame/screen/document/whatever. Possible fix for KICAD-KY.
2023-06-12 11:38:50 +00:00
SCH_NAVIGATE_TOOL* navigateTool = m_toolManager->GetTool<SCH_NAVIGATE_TOOL>();
return navigateTool && navigateTool->CanGoPrevious();
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
};
auto navSchematicHasNextSheet =
[this]( const SELECTION& aSel )
{
Nullptr safety for UI Conditions. We don't really control when these are called, so best not to assume we've finished initialization of the frame/screen/document/whatever. Possible fix for KICAD-KY.
2023-06-12 11:38:50 +00:00
SCH_NAVIGATE_TOOL* navigateTool = m_toolManager->GetTool<SCH_NAVIGATE_TOOL>();
return navigateTool && navigateTool->CanGoNext();
Add show/hide controls for ERC markers. ADDED show/hide controls for ERC warnings, ERC errors and ERC exclusions. Fixes https://gitlab.com/kicad/code/kicad/issues/7270
2021-11-05 21:16:26 +00:00
};
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
ADDED: show/hide controls for directive labels.
2023-04-27 16:59:53 +00:00
mgr->SetConditions( EE_ACTIONS::leaveSheet, ENABLE( belowRootSheetCondition ) );
Leave back/forward/up nav buttons enabled so the action doesn't change. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14783
2023-05-31 09:21:49 +00:00
/* Some of these are bound by default to arrow keys which will get a different action if we
* disable the buttons. So always leave them enabled so the action is consistent.
* https://gitlab.com/kicad/code/kicad/-/issues/14783
ADDED: show/hide controls for directive labels.
2023-04-27 16:59:53 +00:00
mgr->SetConditions( EE_ACTIONS::navigateUp, ENABLE( belowRootSheetCondition ) );
mgr->SetConditions( EE_ACTIONS::navigateForward, ENABLE( navHistoryHasForward ) );
Leave back/forward/up nav buttons enabled so the action doesn't change. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14783
2023-05-31 09:21:49 +00:00
mgr->SetConditions( EE_ACTIONS::navigateBack, ENABLE( navHistoryHsBackward ) );
*/
ADDED: show/hide controls for directive labels.
2023-04-27 16:59:53 +00:00
mgr->SetConditions( EE_ACTIONS::navigatePrevious, ENABLE( navSchematicHasPreviousSheet ) );
mgr->SetConditions( EE_ACTIONS::navigateNext, ENABLE( navSchematicHasNextSheet ) );
mgr->SetConditions( EE_ACTIONS::remapSymbols, ENABLE( remapSymbolsCondition ) );
mgr->SetConditions( EE_ACTIONS::toggleHiddenPins, CHECK( showHiddenPinsCond ) );
mgr->SetConditions( EE_ACTIONS::toggleHiddenFields, CHECK( showHiddenFieldsCond ) );
mgr->SetConditions( EE_ACTIONS::toggleDirectiveLabels, CHECK( showDirectiveLabelsCond ) );
mgr->SetConditions( EE_ACTIONS::toggleERCErrors, CHECK( showERCErrorsCond ) );
mgr->SetConditions( EE_ACTIONS::toggleERCWarnings, CHECK( showERCWarningsCond ) );
mgr->SetConditions( EE_ACTIONS::toggleERCExclusions, CHECK( showERCExclusionsCond ) );
ADDED: markers for excluded-from-sim items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15382
2024-06-03 12:59:40 +00:00
mgr->SetConditions( EE_ACTIONS::markSimExclusions, CHECK( markSimExclusionsCond ) );
ADDED: show/hide controls for directive labels.
2023-04-27 16:59:53 +00:00
mgr->SetConditions( EE_ACTIONS::toggleOPVoltages, CHECK( showOPVoltagesCond ) );
mgr->SetConditions( EE_ACTIONS::toggleOPCurrents, CHECK( showOPCurrentsCond ) );
mgr->SetConditions( EE_ACTIONS::toggleAnnotateAuto, CHECK( showAnnotateAutomaticallyCond ) );
mgr->SetConditions( ACTIONS::toggleBoundingBoxes, CHECK( cond.BoundingBoxes() ) );
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
#define CURRENT_TOOL( action ) mgr->SetConditions( action, CHECK( cond.CurrentTool( action ) ) )
CURRENT_TOOL( ACTIONS::deleteTool );
CURRENT_TOOL( EE_ACTIONS::highlightNetTool );
CURRENT_TOOL( EE_ACTIONS::placeSymbol );
CURRENT_TOOL( EE_ACTIONS::placePower );
CURRENT_TOOL( EE_ACTIONS::drawWire );
CURRENT_TOOL( EE_ACTIONS::drawBus );
CURRENT_TOOL( EE_ACTIONS::placeBusWireEntry );
CURRENT_TOOL( EE_ACTIONS::placeNoConnect );
CURRENT_TOOL( EE_ACTIONS::placeJunction );
CURRENT_TOOL( EE_ACTIONS::placeLabel );
SCH_NETCLASS_FLAGs and SCH_FIELDs for labels. ADDED: a new label type for netclass flags. ADDED: the ability to define fields on labels.
2021-10-12 20:05:37 +00:00
CURRENT_TOOL( EE_ACTIONS::placeClassLabel );
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
CURRENT_TOOL( EE_ACTIONS::placeGlobalLabel );
CURRENT_TOOL( EE_ACTIONS::placeHierLabel );
Add SCH_RULE_AREA shapes to eeschema Includes: - Fix GAL to draw closed polygons in eeschema - Add functionality to eeschema to draw arbitary polygons - Update polygon item previews to have customisable edge colour - Add new SCH_RULE_AREA class, derived from a poly SCH_SHAPE - Add SCH_RULE_AREA to paint and plot methods - Add new rule area color preference to themes
2024-04-25 14:24:46 +00:00
CURRENT_TOOL( EE_ACTIONS::drawRuleArea );
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
CURRENT_TOOL( EE_ACTIONS::drawSheet );
Add Feature: synchronize hierarchical labels and sheet pins
2024-02-25 14:23:59 +00:00
CURRENT_TOOL( EE_ACTIONS::placeSheetPin );
CURRENT_TOOL( EE_ACTIONS::syncSheetPins );
Schematic and symbol text boxes. Also fixes some plot bugs with arcs. Also moves polygonization of arcs (when required) in plotting code from 5 degrees to calculated based on ARC_HIGH_DEF. Fixes https://gitlab.com/kicad/code/kicad/issues/5017
2022-01-25 22:33:37 +00:00
CURRENT_TOOL( EE_ACTIONS::drawRectangle );
CURRENT_TOOL( EE_ACTIONS::drawCircle );
CURRENT_TOOL( EE_ACTIONS::drawArc );
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
CURRENT_TOOL( EE_ACTIONS::drawLines );
CURRENT_TOOL( EE_ACTIONS::placeSchematicText );
Schematic and symbol text boxes. Also fixes some plot bugs with arcs. Also moves polygonization of arcs (when required) in plotting code from 5 degrees to calculated based on ARC_HIGH_DEF. Fixes https://gitlab.com/kicad/code/kicad/issues/5017
2022-01-25 22:33:37 +00:00
CURRENT_TOOL( EE_ACTIONS::drawTextBox );
ADDED: schematic tables. Fixes https://gitlab.com/kicad/code/kicad/-/issues/6806
2023-11-25 12:38:24 +00:00
CURRENT_TOOL( EE_ACTIONS::drawTable );
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
CURRENT_TOOL( EE_ACTIONS::placeImage );
#undef CURRENT_TOOL
#undef CHECK
#undef ENABLE
}
Added a lot of consts and refactored a few lines
2021-03-06 09:27:41 +00:00
void SCH_EDIT_FRAME::SaveCopyForRepeatItem( const SCH_ITEM* aItem )
BUG FIX: eeschema as segfaulting on the 'Insert' key because the m_itemToRepeat was simply a pointer to an object on the display list. At times this object would disappear from the display list, in the test case because of a concatonation of two wires, and if you then tried to clone the non-existent object you'd get a crash. This was not merely a bug, but a naive design choice. IMO. Now the item to repeat is cloned, so will never also be on the display list.
2013-08-05 21:02:41 +00:00
{
// we cannot store a pointer to an item in the display list here since
Cleanup.
2019-07-02 20:09:23 +00:00
// that item may be deleted, such as part of a line concatenation or other.
BUG FIX: eeschema as segfaulting on the 'Insert' key because the m_itemToRepeat was simply a pointer to an object on the display list. At times this object would disappear from the display list, in the test case because of a concatonation of two wires, and if you then tried to clone the non-existent object you'd get a crash. This was not merely a bug, but a naive design choice. IMO. Now the item to repeat is cloned, so will never also be on the display list.
2013-08-05 21:02:41 +00:00
// So simply always keep a copy of the object which is to be repeated.
Don't try to copy a null item. Fixes: lp:1836126 * https://bugs.launchpad.net/kicad/+bug/1836126
2019-07-11 17:23:11 +00:00
if( aItem )
{
Improve repeat-last-item to handle unfold-from-bus. Fixes https://gitlab.com/kicad/code/kicad/issues/12018
2022-09-09 17:08:18 +00:00
m_items_to_repeat.clear();
AddCopyForRepeatItem( aItem );
}
}
BUG FIX: eeschema as segfaulting on the 'Insert' key because the m_itemToRepeat was simply a pointer to an object on the display list. At times this object would disappear from the display list, in the test case because of a concatonation of two wires, and if you then tried to clone the non-existent object you'd get a crash. This was not merely a bug, but a naive design choice. IMO. Now the item to repeat is cloned, so will never also be on the display list.
2013-08-05 21:02:41 +00:00
Improve repeat-last-item to handle unfold-from-bus. Fixes https://gitlab.com/kicad/code/kicad/issues/12018
2022-09-09 17:08:18 +00:00
void SCH_EDIT_FRAME::AddCopyForRepeatItem( const SCH_ITEM* aItem )
{
// we cannot store a pointer to an item in the display list here since
// that item may be deleted, such as part of a line concatenation or other.
// So simply always keep a copy of the object which is to be repeated.
if( aItem )
{
Don't use Clone() for duplicating. It returns the same UUID. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14162
2023-09-03 18:05:33 +00:00
std::unique_ptr<SCH_ITEM> repeatItem( static_cast<SCH_ITEM*>( aItem->Duplicate() ) );
More NULL expunging.
2021-07-16 20:13:26 +00:00
Don't try to copy a null item. Fixes: lp:1836126 * https://bugs.launchpad.net/kicad/+bug/1836126
2019-07-11 17:23:11 +00:00
// Clone() preserves the flags, we want 'em cleared.
Improve repeat-last-item to handle unfold-from-bus. Fixes https://gitlab.com/kicad/code/kicad/issues/12018
2022-09-09 17:08:18 +00:00
repeatItem->ClearFlags();
m_items_to_repeat.emplace_back( std::move( repeatItem ) );
Don't try to copy a null item. Fixes: lp:1836126 * https://bugs.launchpad.net/kicad/+bug/1836126
2019-07-11 17:23:11 +00:00
}
BUG FIX: eeschema as segfaulting on the 'Insert' key because the m_itemToRepeat was simply a pointer to an object on the display list. At times this object would disappear from the display list, in the test case because of a concatonation of two wires, and if you then tried to clone the non-existent object you'd get a crash. This was not merely a bug, but a naive design choice. IMO. Now the item to repeat is cloned, so will never also be on the display list.
2013-08-05 21:02:41 +00:00
}
Added a lot of consts and refactored a few lines
2021-03-06 09:27:41 +00:00
EDA_ITEM* SCH_EDIT_FRAME::GetItem( const KIID& aId ) const
Lay some groundwork for adding distances to DRC errors. modified: eeschema/lib_rectangle.cpp
2020-04-24 13:36:10 +00:00
{
Performance for large hierarchies: lookups Don't bother to sort sheet lists when we're just looking up a UUID, sheet count, other symbol units, etc.
2024-06-06 10:31:22 +00:00
return Schematic().GetItem( aId );
Lay some groundwork for adding distances to DRC errors. modified: eeschema/lib_rectangle.cpp
2020-04-24 13:36:10 +00:00
}
Minor fixes and lots of coding policy changes.
2010-12-08 20:12:46 +00:00
void SCH_EDIT_FRAME::SetSheetNumberAndCount()
Compiler warning, object name, bug, and string fixes. * Fixed EESchema options dialog focus bug so escape key now works in GTK. * Rename schematic objects for improved readability. * Fixed GCC compiler warnings in plot code. * Added paragraph in UIpolicies.txt about setting dialog box sizes. * Lots of message box string clean up.
2009-12-02 21:44:03 +00:00
{
Kick SetSheetNumberAndCount to SCHEMATIC
2022-11-03 03:38:02 +00:00
Schematic().SetSheetNumberAndCount();
eeschema: code cleaning, comments added, and the true number of sheets and sheets numbers in complex hierarchies
2009-01-04 18:52:57 +00:00
}
screen number and screen count now are set
2008-04-30 17:04:22 +00:00
Minor fixes and lots of coding policy changes.
2010-12-08 20:12:46 +00:00
SCH_SCREEN* SCH_EDIT_FRAME::GetScreen() const
annotate dialog HIGification, refactor and beautify associated annotation code
2008-02-26 01:07:38 +00:00
{
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
return GetCurrentSheet().LastScreen();
}
eeschema: fix use-after-free crash in GetScreen()/GetCurrentSheet()
2019-05-20 18:54:44 +00:00
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
SCHEMATIC& SCH_EDIT_FRAME::Schematic() const
{
return *m_schematic;
2008-Feb-12 UPDATE Tim Hanson sideskate@gmail.com ================================================================================ +eeschema * commiting my changes to allow multiple instances of a given schematic file within a hierarchy: ** internally, m_currentScreen has been replaced with m_currentSheet, which is a list or 'path' of screens. The path of screens is used to generate a series of timestamps, which is converted to flat component reference via a look-up table in the schematic files. ** this means that m_currentScreen is no longer used -- use GetScreen(). ** GetScreen is virtual, as some of the dialogs keep around a WinEDA_BaseScreen pointer. ** all sub-sheets in a given schematic must have different names to generate a meaningful netlist.
2008-02-12 21:12:46 +00:00
}
annotate dialog HIGification, refactor and beautify associated annotation code
2008-02-26 01:07:38 +00:00
Changed some 'magic numbers' into constants. Added const modifier in appropriate spots.
2013-09-11 09:34:10 +00:00
wxString SCH_EDIT_FRAME::GetScreenDesc() const
Support SHEET_PATH when printing. Fixes https://gitlab.com/kicad/code/kicad/issues/14233
2023-03-12 22:23:48 +00:00
{
Don't destroy ERC dialog twice. (And some other cleanup.)
2023-07-15 21:39:07 +00:00
return GetCurrentSheet().Last()->GetName();
Support SHEET_PATH when printing. Fixes https://gitlab.com/kicad/code/kicad/issues/14233
2023-03-12 22:23:48 +00:00
}
wxString SCH_EDIT_FRAME::GetFullScreenDesc() const
2008-Feb-12 UPDATE Tim Hanson sideskate@gmail.com ================================================================================ +eeschema * commiting my changes to allow multiple instances of a given schematic file within a hierarchy: ** internally, m_currentScreen has been replaced with m_currentSheet, which is a list or 'path' of screens. The path of screens is used to generate a series of timestamps, which is converted to flat component reference via a look-up table in the schematic files. ** this means that m_currentScreen is no longer used -- use GetScreen(). ** GetScreen is virtual, as some of the dialogs keep around a WinEDA_BaseScreen pointer. ** all sub-sheets in a given schematic must have different names to generate a meaningful netlist.
2008-02-12 21:12:46 +00:00
{
Don't destroy ERC dialog twice. (And some other cleanup.)
2023-07-15 21:39:07 +00:00
return GetCurrentSheet().PathHumanReadable();
2008-Feb-12 UPDATE Tim Hanson sideskate@gmail.com ================================================================================ +eeschema * commiting my changes to allow multiple instances of a given schematic file within a hierarchy: ** internally, m_currentScreen has been replaced with m_currentSheet, which is a list or 'path' of screens. The path of screens is used to generate a series of timestamps, which is converted to flat component reference via a look-up table in the schematic files. ** this means that m_currentScreen is no longer used -- use GetScreen(). ** GetScreen is virtual, as some of the dialogs keep around a WinEDA_BaseScreen pointer. ** all sub-sheets in a given schematic must have different names to generate a meaningful netlist.
2008-02-12 21:12:46 +00:00
}
annotate dialog HIGification, refactor and beautify associated annotation code
2008-02-26 01:07:38 +00:00
Minor fixes and lots of coding policy changes.
2010-12-08 20:12:46 +00:00
void SCH_EDIT_FRAME::CreateScreens()
2008-Feb-12 UPDATE Tim Hanson sideskate@gmail.com ================================================================================ +eeschema * commiting my changes to allow multiple instances of a given schematic file within a hierarchy: ** internally, m_currentScreen has been replaced with m_currentSheet, which is a list or 'path' of screens. The path of screens is used to generate a series of timestamps, which is converted to flat component reference via a look-up table in the schematic files. ** this means that m_currentScreen is no longer used -- use GetScreen(). ** GetScreen is virtual, as some of the dialogs keep around a WinEDA_BaseScreen pointer. ** all sub-sheets in a given schematic must have different names to generate a meaningful netlist.
2008-02-12 21:12:46 +00:00
{
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
m_schematic->Reset();
Port Eeschema to new project settings DRC/ERC error serialization changed to use explicit tokens Old stored severities and ignored errors are discarded
2020-06-08 02:19:46 +00:00
m_schematic->SetProject( &Prj() );
Fix some things about template fieldname synchronization
2020-07-03 03:42:36 +00:00
Fix yet another symbol instance issue when loading legacy schematics.
2022-10-15 18:15:51 +00:00
SCH_SHEET* rootSheet = new SCH_SHEET( m_schematic );
m_schematic->SetRoot( rootSheet );
EESchema code refactoring and other minor fixes.
2010-12-31 19:47:39 +00:00
Move SCH_SCREEN project access to SCHEMATIC SCH_SCREEN no longer needs to be a KIWAY_HOLDER
2020-05-21 02:27:48 +00:00
SCH_SCREEN* rootScreen = new SCH_SCREEN( m_schematic );
Fix yet another symbol instance issue when loading legacy schematics.
2022-10-15 18:15:51 +00:00
const_cast<KIID&>( rootSheet->m_Uuid ) = rootScreen->GetUuid();
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
m_schematic->Root().SetScreen( rootScreen );
SetScreen( Schematic().RootScreen() );
EESchema code refactoring and other minor fixes.
2010-12-31 19:47:39 +00:00
Fix yet another symbol instance issue when loading legacy schematics.
2022-10-15 18:15:51 +00:00
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
m_schematic->RootScreen()->SetFileName( wxEmptyString );
carve out TITLE_BLOCK class from BASE_SCREEN, add hashtables.h for PROPERTIES
2012-01-09 08:35:06 +00:00
Don't allow empty page numbers Fixes https://gitlab.com/kicad/code/kicad/-/issues/6698
2021-01-20 23:34:10 +00:00
// Don't leave root page number empty
SCH_SHEET_PATH rootSheetPath;
Move schematic sheet instance information into file sheet definition. This will make it possible to maintain sheet instance information when copying and pasting from any sheet other that the root sheet of a project. Setting and getting sheet page numbers must now be performed using a sheet path. This was done to ensure that the instance paths were not getting changed unexpectedly from different code paths.
2022-11-22 19:35:27 +00:00
rootSheetPath.push_back( rootSheet );
Don't allow empty page numbers Fixes https://gitlab.com/kicad/code/kicad/-/issues/6698
2021-01-20 23:34:10 +00:00
m_schematic->RootScreen()->SetPageNumber( wxT( "1" ) );
Move schematic sheet instance information into file sheet definition. This will make it possible to maintain sheet instance information when copying and pasting from any sheet other that the root sheet of a project. Setting and getting sheet page numbers must now be performed using a sheet path. This was done to ensure that the instance paths were not getting changed unexpectedly from different code paths.
2022-11-22 19:35:27 +00:00
rootSheetPath.SetPageNumber( wxT( "1" ) );
Don't allow empty page numbers Fixes https://gitlab.com/kicad/code/kicad/-/issues/6698
2021-01-20 23:34:10 +00:00
More NULL expunging.
2021-07-16 20:13:26 +00:00
if( GetScreen() == nullptr )
Fix saving undo/redo limits in Eeschema.
2015-08-06 00:10:52 +00:00
{
Move SCH_SCREEN project access to SCHEMATIC SCH_SCREEN no longer needs to be a KIWAY_HOLDER
2020-05-21 02:27:48 +00:00
SCH_SCREEN* screen = new SCH_SCREEN( m_schematic );
Fix saving undo/redo limits in Eeschema.
2015-08-06 00:10:52 +00:00
SetScreen( screen );
}
Initial import of KiCad.
2007-05-06 16:03:28 +00:00
}
annotate dialog HIGification, refactor and beautify associated annotation code
2008-02-26 01:07:38 +00:00
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
SCH_SHEET_PATH& SCH_EDIT_FRAME::GetCurrentSheet() const
Encapsulate LIB_PIN class and begin encapsulating SCH_EDIT_FRAME class.
2011-12-08 21:05:43 +00:00
{
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
return m_schematic->CurrentSheet();
Encapsulate LIB_PIN class and begin encapsulating SCH_EDIT_FRAME class.
2011-12-08 21:05:43 +00:00
}
void SCH_EDIT_FRAME::SetCurrentSheet( const SCH_SHEET_PATH& aSheet )
{
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
if( aSheet != GetCurrentSheet() )
Performance optimization for Symbol Fields Editor.
2018-10-17 01:03:50 +00:00
{
Move ERC error reporting over to the new framework. Fixes https://gitlab.com/kicad/code/kicad/issues/1989
2020-03-16 11:05:01 +00:00
FocusOnItem( nullptr );
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
Schematic().SetCurrentSheet( aSheet );
GetCanvas()->DisplaySheet( aSheet.LastScreen() );
Performance optimization for Symbol Fields Editor.
2018-10-17 01:03:50 +00:00
}
Encapsulate LIB_PIN class and begin encapsulating SCH_EDIT_FRAME class.
2011-12-08 21:05:43 +00:00
}
Implement HardRedraw for eeschema and libedit.
2018-10-17 11:14:09 +00:00
void SCH_EDIT_FRAME::HardRedraw()
{
Performance enhancements for fonts.
2022-01-07 17:42:43 +00:00
SCH_SCREEN* screen = GetCurrentSheet().LastScreen();
for( SCH_ITEM* item : screen->Items() )
item->ClearCaches();
Don't accidentally add NULL ptrs to the LibSymbols cache. Operator[] will add a blank element if it isn't found in the map. Probably Sentry KICAD-23Y. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14927
2023-06-11 14:44:12 +00:00
for( const std::pair<const wxString, LIB_SYMBOL*>& libSymbol : screen->GetLibSymbols() )
Prevent nullptr dereference. Fixes https://gitlab.com/kicad/code/kicad/issues/12516
2022-11-28 13:38:26 +00:00
{
Replace wxASSERT with wxCHECK2.
2022-11-29 21:12:31 +00:00
wxCHECK2( libSymbol.second, continue );
libSymbol.second->ClearCaches();
Prevent nullptr dereference. Fixes https://gitlab.com/kicad/code/kicad/issues/12516
2022-11-28 13:38:26 +00:00
}
Performance enhancements for fonts.
2022-01-07 17:42:43 +00:00
Don't do a full connection database reset on redraw All we need here is an updated intersheet reference, the connectivity database remains valid and shouldn't be touched
2023-01-20 22:11:23 +00:00
if( Schematic().Settings().m_IntersheetRefsShow )
RecomputeIntersheetRefs();
Move ERC error reporting over to the new framework. Fixes https://gitlab.com/kicad/code/kicad/issues/1989
2020-03-16 11:05:01 +00:00
FocusOnItem( nullptr );
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
GetCanvas()->DisplaySheet( GetCurrentSheet().LastScreen() );
Don't let selection VIEW_GROUP get lost from VIEW. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14969
2023-06-16 15:03:04 +00:00
if( EE_SELECTION_TOOL* selectionTool = m_toolManager->GetTool<EE_SELECTION_TOOL>() )
selectionTool->Reset( TOOL_BASE::REDRAW );
Grid rid of GetCanvas/GetGalCanvas distinction now that there's only gal.
2019-06-13 17:28:55 +00:00
GetCanvas()->ForceRefresh();
Implement HardRedraw for eeschema and libedit.
2018-10-17 11:14:09 +00:00
}
Save file / window states for kicad project locally
2020-08-24 02:01:14 +00:00
bool SCH_EDIT_FRAME::canCloseWindow( wxCloseEvent& aEvent )
Initial import of KiCad.
2007-05-06 16:03:28 +00:00
{
Commit pending changes before quitting. Fixes https://gitlab.com/kicad/code/kicad/issues/6239
2020-10-31 11:49:52 +00:00
// Exit interactive editing
// Note this this will commit *some* pending changes. For instance, the EE_POINT_EDITOR
// will cancel any drag currently in progress, but commit all changes from previous drags.
if( m_toolManager )
Separate immediate and delayed action dispatch Using a boolean argument just leads to a lot of trailing booleans in the function calls and is not user friendly. Instead, introduce PostAction() to send an action that runs after the coroutine (equivalent to passing false or the default argument), and leave RunAction as the immediate execution function.
2023-06-26 22:16:51 +00:00
m_toolManager->RunAction( ACTIONS::cancelInteractive );
Commit pending changes before quitting. Fixes https://gitlab.com/kicad/code/kicad/issues/6239
2020-10-31 11:49:52 +00:00
Add shutdown blocking on Windows for pcbnew, eeschema and pleditor ADDED: Block shutdown/logoff on Windows when contents have been modified
2019-12-19 14:11:11 +00:00
// Shutdown blocks must be determined and vetoed as early as possible
Move shutdown blocker to kiplatform
2020-09-01 10:14:51 +00:00
if( KIPLATFORM::APP::SupportsShutdownBlockReason() && aEvent.GetId() == wxEVT_QUERY_END_SESSION
Performance for large hierarchies: lookups Don't bother to sort sheet lists when we're just looking up a UUID, sheet count, other symbol units, etc.
2024-06-06 10:31:22 +00:00
&& IsContentModified() )
Add shutdown blocking on Windows for pcbnew, eeschema and pleditor ADDED: Block shutdown/logoff on Windows when contents have been modified
2019-12-19 14:11:11 +00:00
{
Save file / window states for kicad project locally
2020-08-24 02:01:14 +00:00
return false;
Add shutdown blocking on Windows for pcbnew, eeschema and pleditor ADDED: Block shutdown/logoff on Windows when contents have been modified
2019-12-19 14:11:11 +00:00
}
Modular-Kicad milestone B), major portions: *) Rework the set language support, simplify it by using KIWAY. Now any major frame with a "change language" menu can change the language for all KIWAY_PLAYERs in the whole KIWAY. Multiple KIWAYs are not supported yet. *) Simplify "modal wxFrame" support, and add that support exclusively to KIWAY_PLAYER where it is inherited by all derivatives. The function KIWAY_PLAYER::ShowModal() is in the vtable and so is cross module capable. *) Remove the requirements and assumptions that the wxFrame hierarchy always had PCB_EDIT_FRAME and SCH_EDIT_FRAME as immediate parents of their viewers and editors. This is no longer the case, nor required. *) Use KIWAY::Player() everywhere to make KIWAY_PLAYERs, this registers the KIWAY_PLAYER within the KIWAY and makes it very easy to find an open frame quickly. It also gives control to the KIWAY as to frame hierarchical relationships. *) Change single_top to use the KIWAY for loading a KIFACE and instantiating the single KIWAY_PLAYER, see bullet immediately above. *) Add KIWAY::OnKiwayEnd() and call it from PGM_BASE at program termination, this gives the KIFACEs a chance to save their final configuration dope to disk. *) Add dedicated FRAME_T's for the modal frames, so m_Ident can be tested and these modal frames are distinctly different than their non-modal equivalents. KIWAY_PLAYER::IsModal() is !not! a valid test during the wxFrame's constructor, so this is another important reason for having a dedicated FRAME_T for each modal wxFrame. On balance, more lines were deleted than were added to achieve all this.
2014-05-03 17:40:19 +00:00
if( Kiface().IsSingle() )
{
LibEdit -> SymbolEditor
2020-10-31 01:27:16 +00:00
auto* symbolEditor = (SYMBOL_EDIT_FRAME*) Kiway().Player( FRAME_SCH_SYMBOL_EDITOR, false );
More component -> symbol.
2020-11-15 17:03:27 +00:00
if( symbolEditor && !symbolEditor->Close() ) // Can close symbol editor?
Save file / window states for kicad project locally
2020-08-24 02:01:14 +00:00
return false;
Modular-Kicad milestone B), major portions: *) Rework the set language support, simplify it by using KIWAY. Now any major frame with a "change language" menu can change the language for all KIWAY_PLAYERs in the whole KIWAY. Multiple KIWAYs are not supported yet. *) Simplify "modal wxFrame" support, and add that support exclusively to KIWAY_PLAYER where it is inherited by all derivatives. The function KIWAY_PLAYER::ShowModal() is in the vtable and so is cross module capable. *) Remove the requirements and assumptions that the wxFrame hierarchy always had PCB_EDIT_FRAME and SCH_EDIT_FRAME as immediate parents of their viewers and editors. This is no longer the case, nor required. *) Use KIWAY::Player() everywhere to make KIWAY_PLAYERs, this registers the KIWAY_PLAYER within the KIWAY and makes it very easy to find an open frame quickly. It also gives control to the KIWAY as to frame hierarchical relationships. *) Change single_top to use the KIWAY for loading a KIFACE and instantiating the single KIWAY_PLAYER, see bullet immediately above. *) Add KIWAY::OnKiwayEnd() and call it from PGM_BASE at program termination, this gives the KIFACEs a chance to save their final configuration dope to disk. *) Add dedicated FRAME_T's for the modal frames, so m_Ident can be tested and these modal frames are distinctly different than their non-modal equivalents. KIWAY_PLAYER::IsModal() is !not! a valid test during the wxFrame's constructor, so this is another important reason for having a dedicated FRAME_T for each modal wxFrame. On balance, more lines were deleted than were added to achieve all this.
2014-05-03 17:40:19 +00:00
Update naming.
2020-12-25 23:37:01 +00:00
auto* symbolViewer = (SYMBOL_VIEWER_FRAME*) Kiway().Player( FRAME_SCH_VIEWER, false );
LibEdit -> SymbolEditor
2020-10-31 01:27:16 +00:00
More component -> symbol.
2020-11-15 17:03:27 +00:00
if( symbolViewer && !symbolViewer->Close() ) // Can close symbol viewer?
Save file / window states for kicad project locally
2020-08-24 02:01:14 +00:00
return false;
annotate dialog HIGification, refactor and beautify associated annotation code
2008-02-26 01:07:38 +00:00
Push most of DIALOG_CHOOSE_SYMBOL down into PANEL_SYMBOL_CHOOSER. Includes a dialog wrapper (DIALOG_SYMBOL_CHOOSER) and a frame wrapper (SYMBOL_CHOOSER_FRAME).
2023-09-28 13:09:45 +00:00
// SYMBOL_CHOOSER_FRAME is always modal so this shouldn't come up, but better safe than
// sorry.
auto* chooser = (SYMBOL_CHOOSER_FRAME*) Kiway().Player( FRAME_SYMBOL_CHOOSER, false );
Fix incorrect management of SCH_SHEET_PIN items when adding or removing them. Especially new SCH_SHEET_PIN items were added twice, thus creating crashes. Fixes: lp:1799606 https://bugs.launchpad.net/kicad/+bug/1799606
2018-10-24 14:18:19 +00:00
Push most of DIALOG_CHOOSE_SYMBOL down into PANEL_SYMBOL_CHOOSER. Includes a dialog wrapper (DIALOG_SYMBOL_CHOOSER) and a frame wrapper (SYMBOL_CHOOSER_FRAME).
2023-09-28 13:09:45 +00:00
if( chooser && !chooser->Close() ) // Can close symbol chooser?
Save file / window states for kicad project locally
2020-08-24 02:01:14 +00:00
return false;
Modular-Kicad milestone B), major portions: *) Rework the set language support, simplify it by using KIWAY. Now any major frame with a "change language" menu can change the language for all KIWAY_PLAYERs in the whole KIWAY. Multiple KIWAYs are not supported yet. *) Simplify "modal wxFrame" support, and add that support exclusively to KIWAY_PLAYER where it is inherited by all derivatives. The function KIWAY_PLAYER::ShowModal() is in the vtable and so is cross module capable. *) Remove the requirements and assumptions that the wxFrame hierarchy always had PCB_EDIT_FRAME and SCH_EDIT_FRAME as immediate parents of their viewers and editors. This is no longer the case, nor required. *) Use KIWAY::Player() everywhere to make KIWAY_PLAYERs, this registers the KIWAY_PLAYER within the KIWAY and makes it very easy to find an open frame quickly. It also gives control to the KIWAY as to frame hierarchical relationships. *) Change single_top to use the KIWAY for loading a KIFACE and instantiating the single KIWAY_PLAYER, see bullet immediately above. *) Add KIWAY::OnKiwayEnd() and call it from PGM_BASE at program termination, this gives the KIFACEs a chance to save their final configuration dope to disk. *) Add dedicated FRAME_T's for the modal frames, so m_Ident can be tested and these modal frames are distinctly different than their non-modal equivalents. KIWAY_PLAYER::IsModal() is !not! a valid test during the wxFrame's constructor, so this is another important reason for having a dedicated FRAME_T for each modal wxFrame. On balance, more lines were deleted than were added to achieve all this.
2014-05-03 17:40:19 +00:00
}
Don't leave stranded symbols/footprints in editors when doc closes. Fixes https://gitlab.com/kicad/code/kicad/issues/10026
2021-12-22 14:27:38 +00:00
else
{
auto* symbolEditor = (SYMBOL_EDIT_FRAME*) Kiway().Player( FRAME_SCH_SYMBOL_EDITOR, false );
if( symbolEditor && symbolEditor->IsSymbolFromSchematic() )
{
if( !symbolEditor->CanCloseSymbolFromSchematic( true ) )
return false;
}
}
All: fix a very minor issue: when a window is closed mazimized, and later reopened, it was not maximized. But this is very annoying when using 2 monitors with a different size Very minor other enhancements and fixes
2011-04-07 17:48:26 +00:00
Move simulator to tool framework.
2023-01-01 23:37:24 +00:00
if( !Kiway().PlayerClose( FRAME_SIMULATOR, false ) ) // Can close the simulator?
Save file / window states for kicad project locally
2020-08-24 02:01:14 +00:00
return false;
Sch editor and Simulator: close the simulator frame when the schematic editor is closed, to avoid crash, due to the fact the simulator can try to access to a no more existing frame..
2016-08-29 17:47:08 +00:00
Symbol Fields Table: make non-modal Fixes: https://gitlab.com/kicad/code/kicad/-/issues/2141
2023-08-14 14:41:28 +00:00
if( m_symbolFieldsTableDialog
&& !m_symbolFieldsTableDialog->Close( false ) ) // Can close the symbol fields table?
{
return false;
}
Prevent segfault on schematic frame close We are seeing multiple events firing when closing via the manager frame. Cleaning up the schematic should only happen once.
2020-08-11 22:56:47 +00:00
// We may have gotten multiple events; don't clean up twice
if( !Schematic().IsValid() )
Save file / window states for kicad project locally
2020-08-24 02:01:14 +00:00
return false;
Prevent segfault on schematic frame close We are seeing multiple events firing when closing via the manager frame. Cleaning up the schematic should only happen once.
2020-08-11 22:56:47 +00:00
Performance for large hierarchies: lookups Don't bother to sort sheet lists when we're just looking up a UUID, sheet count, other symbol units, etc.
2024-06-06 10:31:22 +00:00
if( IsContentModified() )
annotate dialog HIGification, refactor and beautify associated annotation code
2008-02-26 01:07:38 +00:00
{
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
wxFileName fileName = Schematic().RootScreen()->GetFileName();
More error message regularization.
2021-06-28 23:44:07 +00:00
wxString msg = _( "Save changes to '%s' before closing?" );
annotate dialog HIGification, refactor and beautify associated annotation code
2008-02-26 01:07:38 +00:00
Fix OSX button order issue in Unsaved Changes dialog. Also changes the presentation of the string when the checkbox appears so that the "Changes will be lost" warning isn't hidden by the turndown. This last part may require conditional compilation as it's undocumented. Lastly, regularizes the Unsaved Changes strings between the apps.
2019-06-17 15:59:39 +00:00
if( !HandleUnsavedChanges( this, wxString::Format( msg, fileName.GetFullName() ),
Formatting.
2021-10-01 20:49:14 +00:00
[&]() -> bool
{
return SaveProject();
} ) )
annotate dialog HIGification, refactor and beautify associated annotation code
2008-02-26 01:07:38 +00:00
{
Save file / window states for kicad project locally
2020-08-24 02:01:14 +00:00
return false;
annotate dialog HIGification, refactor and beautify associated annotation code
2008-02-26 01:07:38 +00:00
}
}
Save file / window states for kicad project locally
2020-08-24 02:01:14 +00:00
return true;
}
void SCH_EDIT_FRAME::doCloseWindow()
{
Performance for large hierarchies: lookups Don't bother to sort sheet lists when we're just looking up a UUID, sheet count, other symbol units, etc.
2024-06-06 10:31:22 +00:00
SCH_SHEET_LIST sheetlist = Schematic().GetUnorderedSheets();
Move tool shutdown to after all cancel opportunities. Fixes https://gitlab.com/kicad/code/kicad/issues/4401
2020-05-11 23:06:48 +00:00
Commit pending changes before quitting. Fixes https://gitlab.com/kicad/code/kicad/issues/6239
2020-10-31 11:49:52 +00:00
// Shutdown all running tools
Move tool shutdown to after all cancel opportunities. Fixes https://gitlab.com/kicad/code/kicad/issues/4401
2020-05-11 23:06:48 +00:00
if( m_toolManager )
m_toolManager->ShutdownAllTools();
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
// Close modeless dialogs. They're trouble when they get destroyed after the frame.
Unbind( EDA_EVT_CLOSE_DIALOG_BOOK_REPORTER, &SCH_EDIT_FRAME::onCloseSymbolDiffDialog, this );
Unbind( EDA_EVT_CLOSE_ERC_DIALOG, &SCH_EDIT_FRAME::onCloseErcDialog, this );
Symbol Fields Table: make non-modal Fixes: https://gitlab.com/kicad/code/kicad/-/issues/2141
2023-08-14 14:41:28 +00:00
Unbind( EDA_EVT_CLOSE_DIALOG_SYMBOL_FIELDS_TABLE,
&SCH_EDIT_FRAME::onCloseSymbolFieldsTableDialog, this );
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
m_netNavigator->Unbind( wxEVT_TREE_SEL_CHANGING, &SCH_EDIT_FRAME::onNetNavigatorSelChanging,
this );
m_netNavigator->Unbind( wxEVT_TREE_SEL_CHANGED, &SCH_EDIT_FRAME::onNetNavigatorSelection,
this );
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
Fix source comment/doc typos (follow-up) Found via `codespell -q 3 -S *.po,./thirdparty -L aactual,acount,aline,alocation,alog,anormal,anumber,aother,apoints,aparent,aray,dout,einstance,modul,ot,overide,serie,te,,tesselate,tesselator,tht`
2021-07-03 22:37:31 +00:00
// Close the find dialog and preserve its setting if it is displayed.
Rework Eeschema find/replace for modern toolset. Fixes: lp:1827274 * https://bugs.launchpad.net/kicad/+bug/1827274 Fixes: lp:1827240 * https://bugs.launchpad.net/kicad/+bug/1827240
2019-05-19 21:04:04 +00:00
if( m_findReplaceDialog )
Fix for hidden find dialog when display settings change.
2011-11-10 17:01:33 +00:00
{
Rework Eeschema find/replace for modern toolset. Fixes: lp:1827274 * https://bugs.launchpad.net/kicad/+bug/1827274 Fixes: lp:1827240 * https://bugs.launchpad.net/kicad/+bug/1827240
2019-05-19 21:04:04 +00:00
m_findStringHistoryList = m_findReplaceDialog->GetFindEntries();
m_replaceStringHistoryList = m_findReplaceDialog->GetReplaceEntries();
Fix crash with opening find dialog twice. Fixes: lp:1830224 * https://bugs.launchpad.net/kicad/+bug/1830224
2019-05-23 17:31:10 +00:00
m_findReplaceDialog->Destroy();
m_findReplaceDialog = nullptr;
Fix for hidden find dialog when display settings change.
2011-11-10 17:01:33 +00:00
}
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
if( m_diffSymbolDialog )
{
m_diffSymbolDialog->Destroy();
m_diffSymbolDialog = nullptr;
}
if( m_ercDialog )
{
m_ercDialog->Destroy();
m_ercDialog = nullptr;
}
Symbol Fields Table: make non-modal Fixes: https://gitlab.com/kicad/code/kicad/-/issues/2141
2023-08-14 14:41:28 +00:00
if( m_symbolFieldsTableDialog )
{
m_symbolFieldsTableDialog->Destroy();
m_symbolFieldsTableDialog = nullptr;
}
ADDED: Selection filter for schematic editor Fixes https://gitlab.com/kicad/code/kicad/-/issues/14988
2024-02-25 22:39:14 +00:00
// Make sure local settings are persisted
SaveProjectLocalSettings();
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
// Shutdown all running tools
if( m_toolManager )
{
m_toolManager->ShutdownAllTools();
Prevent crash during schematic window close
2023-04-09 00:30:42 +00:00
// prevent the canvas from trying to dispatch events during close
GetCanvas()->SetEventDispatcher( nullptr );
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
delete m_toolManager;
m_toolManager = nullptr;
}
Fix some issue with hierarchy panel on OSX. Also moves the option toolbars tight to the canvas for all windows. Fixes https://gitlab.com/kicad/code/kicad/issues/12087
2022-07-26 11:13:16 +00:00
wxAuiPaneInfo& hierarchy_pane = m_auimgr.GetPane( SchematicHierarchyPaneName() );
if( hierarchy_pane.IsShown() && hierarchy_pane.IsFloating() )
{
hierarchy_pane.Show( false );
m_auimgr.Update();
}
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
SCH_SCREENS screens( Schematic().Root() );
More auto save improvements. * Factor test for auto save file into base frame class. * Added auto save feature to Eeschema for saving schematics, addresses launchpad question 173631. * Add auto save interval control to Eeschema options dialog. * Fix problem with subsequent auto saves in last commit.
2011-10-15 13:25:57 +00:00
wxFileName fn;
More NULL expunging.
2021-07-16 20:13:26 +00:00
for( SCH_SCREEN* screen = screens.GetFirst(); screen != nullptr; screen = screens.GetNext() )
More auto save improvements. * Factor test for auto save file into base frame class. * Added auto save feature to Eeschema for saving schematics, addresses launchpad question 173631. * Add auto save interval control to Eeschema options dialog. * Fix problem with subsequent auto saves in last commit.
2011-10-15 13:25:57 +00:00
{
Modular KiCad Blueprint Milestone B), major portions: *) When kicad.exe closes a project, close any open KIFACEs so that they cannot get disassociated from their true PROJECT. *) Allow loading eeschema library editor from kicad.exe *) Allow loading pcbnew library editor from kicad.exe *) Rename LIB_COMPONENT to LIB_PART. *) Add class PART_LIBS, and PART_LIB. *) Make PART_LIBS non-global, i.e. PROJECT specific. *) Implement "data on demand" for PART_LIBS *) Implement "data on demand" for schematic SEARCH_STACK. *) Use RSTRINGs to retain eeschema editor's notion of last library and part being edited. *) Get rid of library search on every SCH_COMPONENT::Draw() call, instead use a weak pointer. *) Remove all chdir() calls so projects don't need to be CWD. *) Romove APPEND support from OpenProjectFiles(). *) Make OpenProjectFiles() robust, even for creating new projects. *) Load EESCHEMA colors in the KIWAY::OnKiwayStart() rather in window open, and save them in the .eeschema config file, not in the project file. *) Fix bug with wxDir() while accessing protected dirs in kicad.exe *) Consolidate template copying into PROJECT class, not in kicad.exe source. *) Generally untangle eeschema, making its libraries not global but rather held in the PROJECT.
2014-08-13 20:28:54 +00:00
fn = Prj().AbsolutePath( screen->GetFileName() );
More auto save improvements. * Factor test for auto save file into base frame class. * Added auto save feature to Eeschema for saving schematics, addresses launchpad question 173631. * Add auto save interval control to Eeschema options dialog. * Fix problem with subsequent auto saves in last commit.
2011-10-15 13:25:57 +00:00
Refactor autosave prefix into FILEEXT.
2024-04-22 00:58:13 +00:00
// Auto save file name is the normal file name prepended with FILEEXT::AutoSaveFilePrefix.
fn.SetName( FILEEXT::AutoSaveFilePrefix + fn.GetName() );
More auto save improvements. * Factor test for auto save file into base frame class. * Added auto save feature to Eeschema for saving schematics, addresses launchpad question 173631. * Add auto save interval control to Eeschema options dialog. * Fix problem with subsequent auto saves in last commit.
2011-10-15 13:25:57 +00:00
Eeschema: fix broken auto save feature. Make auto save recover all auto saved sheet files not just the root sheet. This does not fix existing auto save issues because recovery would require an iterative reload for each automatically saved sheet file and would only happen once. Fixes https://gitlab.com/kicad/code/kicad/-/issues/9288
2021-10-13 18:48:28 +00:00
if( fn.IsFileWritable() )
More auto save improvements. * Factor test for auto save file into base frame class. * Added auto save feature to Eeschema for saving schematics, addresses launchpad question 173631. * Add auto save interval control to Eeschema options dialog. * Fix problem with subsequent auto saves in last commit.
2011-10-15 13:25:57 +00:00
wxRemoveFile( fn.GetFullPath() );
}
Eeschema: fix broken auto save feature. Make auto save recover all auto saved sheet files not just the root sheet. This does not fix existing auto save issues because recovery would require an iterative reload for each automatically saved sheet file and would only happen once. Fixes https://gitlab.com/kicad/code/kicad/-/issues/9288
2021-10-13 18:48:28 +00:00
wxFileName tmpFn = Prj().GetProjectFullName();
wxFileName autoSaveFileName( tmpFn.GetPath(), getAutoSaveFileName() );
if( autoSaveFileName.IsFileWritable() )
wxRemoveFile( autoSaveFileName.GetFullPath() );
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
sheetlist.ClearModifyStatus();
annotate dialog HIGification, refactor and beautify associated annotation code
2008-02-26 01:07:38 +00:00
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
wxString fileName = Prj().AbsolutePath( Schematic().RootScreen()->GetFileName() );
Modular KiCad Blueprint Milestone B), major portions: *) When kicad.exe closes a project, close any open KIFACEs so that they cannot get disassociated from their true PROJECT. *) Allow loading eeschema library editor from kicad.exe *) Allow loading pcbnew library editor from kicad.exe *) Rename LIB_COMPONENT to LIB_PART. *) Add class PART_LIBS, and PART_LIB. *) Make PART_LIBS non-global, i.e. PROJECT specific. *) Implement "data on demand" for PART_LIBS *) Implement "data on demand" for schematic SEARCH_STACK. *) Use RSTRINGs to retain eeschema editor's notion of last library and part being edited. *) Get rid of library search on every SCH_COMPONENT::Draw() call, instead use a weak pointer. *) Remove all chdir() calls so projects don't need to be CWD. *) Romove APPEND support from OpenProjectFiles(). *) Make OpenProjectFiles() robust, even for creating new projects. *) Load EESCHEMA colors in the KIWAY::OnKiwayStart() rather in window open, and save them in the .eeschema config file, not in the project file. *) Fix bug with wxDir() while accessing protected dirs in kicad.exe *) Consolidate template copying into PROJECT class, not in kicad.exe source. *) Generally untangle eeschema, making its libraries not global but rather held in the PROJECT.
2014-08-13 20:28:54 +00:00
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
if( !Schematic().GetFileName().IsEmpty() && !Schematic().RootScreen()->IsEmpty() )
Modular KiCad Blueprint Milestone B), major portions: *) When kicad.exe closes a project, close any open KIFACEs so that they cannot get disassociated from their true PROJECT. *) Allow loading eeschema library editor from kicad.exe *) Allow loading pcbnew library editor from kicad.exe *) Rename LIB_COMPONENT to LIB_PART. *) Add class PART_LIBS, and PART_LIB. *) Make PART_LIBS non-global, i.e. PROJECT specific. *) Implement "data on demand" for PART_LIBS *) Implement "data on demand" for schematic SEARCH_STACK. *) Use RSTRINGs to retain eeschema editor's notion of last library and part being edited. *) Get rid of library search on every SCH_COMPONENT::Draw() call, instead use a weak pointer. *) Remove all chdir() calls so projects don't need to be CWD. *) Romove APPEND support from OpenProjectFiles(). *) Make OpenProjectFiles() robust, even for creating new projects. *) Load EESCHEMA colors in the KIWAY::OnKiwayStart() rather in window open, and save them in the .eeschema config file, not in the project file. *) Fix bug with wxDir() while accessing protected dirs in kicad.exe *) Consolidate template copying into PROJECT class, not in kicad.exe source. *) Generally untangle eeschema, making its libraries not global but rather held in the PROJECT.
2014-08-13 20:28:54 +00:00
UpdateFileHistory( fileName );
annotate dialog HIGification, refactor and beautify associated annotation code
2008-02-26 01:07:38 +00:00
Free item memory when closing schematic window This fires the dtor for each item on the screen, allowing us to properly close and remove them from the connection graph Fixes https://gitlab.com/kicad/code/kicad/-/issues/17961
2024-05-16 16:57:20 +00:00
Schematic().RootScreen()->Clear( true );
annotate dialog HIGification, refactor and beautify associated annotation code
2008-02-26 01:07:38 +00:00
Add specific bitmaps in export IDF and export DSN menus. Add missing calls to Show( false ) to some main frames (Kicad, eeschema, gerbview), to force config saving when closing these windows. Code cleanup and minor coding style fixes in footprint_wizard_frame
2014-01-29 17:01:42 +00:00
// all sub sheets are deleted, only the main sheet is usable
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
GetCurrentSheet().clear();
Add specific bitmaps in export IDF and export DSN menus. Add missing calls to Show( false ) to some main frames (Kicad, eeschema, gerbview), to force config saving when closing these windows. Code cleanup and minor coding style fixes in footprint_wizard_frame
2014-01-29 17:01:42 +00:00
Make sure projects are cleaned up nicely when frames close PROJECT objects will be deleted by SETTINGS_MANAGER::UnloadProject so we need to make sure that this is called at an early enough point in the closing process that anything needed by the PROJECT dtor is still around. Also fix an issue where the schematic worksheet was depending on the project existing after the schematic had been reset.
2020-08-08 20:52:57 +00:00
// Clear view before destroying schematic as repaints depend on schematic being valid
SetScreen( nullptr );
Full-project automatic backup system Fixes https://gitlab.com/kicad/code/kicad/-/issues/4763
2020-07-03 13:40:31 +00:00
Schematic().Reset();
Prevent makeup events from contaminating the system
2023-06-02 23:04:08 +00:00
// Prevents any rogue events from continuing (i.e. search panel tries to redraw)
Initial schematic search pane
2023-05-15 01:35:39 +00:00
Show( false );
annotate dialog HIGification, refactor and beautify associated annotation code
2008-02-26 01:07:38 +00:00
Destroy();
Initial import of KiCad.
2007-05-06 16:03:28 +00:00
}
Be more consistent about annotation warngings. This can be a particular problem if you go to run ERC, it shows the annotation warnging so you re-annotate (but don't notice that your scope is set to Selection). Also adds some missing defensive code around closing a modeless RC checker before the document (which we had for DRC dialog but not the ERC dialog). Also fixes a missing override of GetSeverity which kept ERC messages from having the right prefix.
2021-11-29 13:41:02 +00:00
SEVERITY SCH_EDIT_FRAME::GetSeverity( int aErrorCode ) const
{
return Schematic().ErcSettings().GetSeverity( aErrorCode );
}
Unify Eeschema orient commands and other minor fixes. * Create command event handler for orienting schematic items and block. * Remove redundant orient item and block command handler code and IDs. * Remove redundant cancel current command event table entry. * Remove unnecessary schematic bitmap object virtual functions. * Set path when saving schematic sheet files to prevent assertion in updated path and file write permission test function. * Restore directory and file name write permission test function to it's previous behavior to prevent unexpected save results. * Add an assertion to verify the path is not empty to directory and file write permission test function. * Improve documentation for path and file write permission test function. * Fix Doxygen link warnings.
2011-10-28 20:30:50 +00:00
void SCH_EDIT_FRAME::OnModify()
Eeschema date in frame reference updated at each modification.
2010-02-18 20:07:29 +00:00
{
Push autosave-require down in to EDA_BASE_FRAME. Fixes https://gitlab.com/kicad/code/kicad/issues/11790
2022-10-10 13:03:10 +00:00
EDA_BASE_FRAME::OnModify();
Don't destroy ERC dialog twice. (And some other cleanup.)
2023-07-15 21:39:07 +00:00
wxCHECK( GetScreen(), /* void */ );
Eeschema: fix a crash on closing the schematic editor if the point editor is active. If the point editor is active and a change is made, the tool was shut down after deleting the board data, in the frame Dtor. Therefore a crash happened because a call to GetScreen()->SetModify(); using a null pointer, and after the test for modifications was done. Now tools are stopped when closing the window, before any test for modifications.
2020-02-07 09:02:47 +00:00
Rename modification flag routines Differentiates better between the EDA_ITEM IsModified(), referring to items themselves changing and the EDA_SCREEN IsContentModified(), referring to whether we have made any unsaved changes.
2021-05-28 19:07:04 +00:00
GetScreen()->SetContentModified();
Push autosave-require down in to EDA_BASE_FRAME. Fixes https://gitlab.com/kicad/code/kicad/issues/11790
2022-10-10 13:03:10 +00:00
m_autoSaveRequired = true;
Eeschema date in frame reference updated at each modification.
2010-02-18 20:07:29 +00:00
Retire EDA_DRAW_PANEL and legacy_wx/EDA_DRAW_FRAME.
2019-05-31 17:37:07 +00:00
GetCanvas()->Refresh();
Be more aggressive about updating title to show dirty status. Fixes https://gitlab.com/kicad/code/kicad/issues/7613
2021-02-19 21:58:22 +00:00
More wxSing
2023-01-17 04:14:38 +00:00
if( !GetTitle().StartsWith( wxS( "*" ) ) )
Fix naming of `updateTitle()` This is a private function so should be lowercased to avoid confusion
2023-01-12 00:05:43 +00:00
updateTitle();
Eeschema date in frame reference updated at each modification.
2010-02-18 20:07:29 +00:00
}
Comment translations and other minor updates. * Complete comment translation for all EESchema source files. * Complete comment translation for all 3D viewer source files. * Rename class class_hierarchical_PIN_sheet to SCH_SHEET_PIN. * Rename class DrawSheetStruct to SCH_SHEET. * Tool tip capitalization fixes. * Uncrustify and spell check comments and strings in all modified source files.
2009-11-04 20:46:53 +00:00
Eeschema find and replace improvements. * Add check box and flag to ignore replacing the component reference designator field. * Fix a resizing bug when switching between the find and replace modes of the find/replace dialog. * Fix replace component reference designator field bug. * Force rebuild of search list when schematic is modified and the replace dialog is closed. * Prevent finding the next item when the find/replace dialog is closed. * Respect warp mouse pointer setting when closing find/replace dialog. * Fix duplicate mnemonic control accelerator keys in find/replace dialog.
2011-12-21 20:21:15 +00:00
eeschema: single click PCB update feature added
2016-01-29 10:24:39 +00:00
void SCH_EDIT_FRAME::OnUpdatePCB( wxCommandEvent& event )
Options for board update KiWay request (MAIL_SCH_UPDATE[_REQUEST]) Board update KiWay request may now contain options in the message payload: - "no-annotate": do not enforce annotation - "quiet-annotate": annotate without displaying a dialog - "by-reference": update netlist by reference, no dialog displayed - "by-timestamp": update netlist by timestamp, no dialog displayed
2018-02-16 18:26:11 +00:00
{
Make sure PCBNew is open when running F8. Fixes: lp:1830256 * https://bugs.launchpad.net/kicad/+bug/1830256
2019-05-23 18:25:07 +00:00
if( Kiface().IsSingle() )
{
Cleanup.
2019-07-02 20:09:23 +00:00
DisplayError( this, _( "Cannot update the PCB, because the Schematic Editor is opened"
" in stand-alone mode. In order to create/update PCBs from"
Always enable save; move dirty bit to asterisk in title bar. Also unifies PCB Editor and Schematic Editor names with other locations in the GUI (which were still Pcbnew and Eeschema). Fixes https://gitlab.com/kicad/code/kicad/issues/7587 Fixes https://gitlab.com/kicad/code/kicad/issues/7594
2021-02-18 15:49:35 +00:00
" schematics, launch the KiCad shell and create a project." ) );
Make sure PCBNew is open when running F8. Fixes: lp:1830256 * https://bugs.launchpad.net/kicad/+bug/1830256
2019-05-23 18:25:07 +00:00
return;
}
Remove vestiages of old open-PCB-for-settings hack. We used to have to open a PCB_EDIT_FRAME to get the settings for the footprint editor and footprint viewer. This necessitated some special processing when opening a PCB_EDIT_FRAME to actually edit a board as it might already be open but unloaded. Since the new settings architecture allows the footprint editor and footprint viewer to init themselves we no longer need the special- case code.
2020-07-10 16:59:06 +00:00
KIWAY_PLAYER* frame = Kiway().Player( FRAME_PCB_EDITOR, false );
Make sure PCBNew is open when running F8. Fixes: lp:1830256 * https://bugs.launchpad.net/kicad/+bug/1830256
2019-05-23 18:25:07 +00:00
Remove vestiages of old open-PCB-for-settings hack. We used to have to open a PCB_EDIT_FRAME to get the settings for the footprint editor and footprint viewer. This necessitated some special processing when opening a PCB_EDIT_FRAME to actually edit a board as it might already be open but unloaded. Since the new settings architecture allows the footprint editor and footprint viewer to init themselves we no longer need the special- case code.
2020-07-10 16:59:06 +00:00
if( !frame )
Make sure PCB document is opened when doing an update. Fixes: lp:1830256 * https://bugs.launchpad.net/kicad/+bug/1830256
2019-05-24 19:41:29 +00:00
{
Remove vestiages of old open-PCB-for-settings hack. We used to have to open a PCB_EDIT_FRAME to get the settings for the footprint editor and footprint viewer. This necessitated some special processing when opening a PCB_EDIT_FRAME to actually edit a board as it might already be open but unloaded. Since the new settings architecture allows the footprint editor and footprint viewer to init themselves we no longer need the special- case code.
2020-07-10 16:59:06 +00:00
wxFileName fn = Prj().GetProjectFullName();
Kick the wildcards and file exts into a static class, export it from kicommon
2023-12-28 02:10:01 +00:00
fn.SetExt( FILEEXT::PcbFileExtension );
Remove vestiages of old open-PCB-for-settings hack. We used to have to open a PCB_EDIT_FRAME to get the settings for the footprint editor and footprint viewer. This necessitated some special processing when opening a PCB_EDIT_FRAME to actually edit a board as it might already be open but unloaded. Since the new settings architecture allows the footprint editor and footprint viewer to init themselves we no longer need the special- case code.
2020-07-10 16:59:06 +00:00
frame = Kiway().Player( FRAME_PCB_EDITOR, true );
Avoid crashes when, for some reason, a dll cannot be loaded. In this case a null pointer was returned by the internal code. This pointer is now tested against nullptr to avoid the application crashing. Fixes #12080 https://gitlab.com/kicad/code/kicad/issues/12080
2022-07-24 17:42:50 +00:00
// If Kiway() cannot create the Pcbnew frame, it shows a error message, and
// frame is null
if( !frame )
return;
Make sure PCB document is opened when doing an update. Fixes: lp:1830256 * https://bugs.launchpad.net/kicad/+bug/1830256
2019-05-24 19:41:29 +00:00
frame->OpenProjectFiles( std::vector<wxString>( 1, fn.GetFullPath() ) );
}
Remove vestiages of old open-PCB-for-settings hack. We used to have to open a PCB_EDIT_FRAME to get the settings for the footprint editor and footprint viewer. This necessitated some special processing when opening a PCB_EDIT_FRAME to actually edit a board as it might already be open but unloaded. Since the new settings architecture allows the footprint editor and footprint viewer to init themselves we no longer need the special- case code.
2020-07-10 16:59:06 +00:00
if( !frame->IsVisible() )
frame->Show( true );
Make sure PCBNew is open when running F8. Fixes: lp:1830256 * https://bugs.launchpad.net/kicad/+bug/1830256
2019-05-23 18:25:07 +00:00
// On Windows, Raise() does not bring the window on screen, when iconized
if( frame->IsIconized() )
frame->Iconize( false );
frame->Raise();
Support synchronous messaging over KIWAY EXPRESS. This allows us to make the various netlist and pcb update routines more atomic and less reliant on carefully sequenced asynchronous messages. This is also a prelude to adding support for footprint testing without a netlist.
2019-03-27 22:37:26 +00:00
std::string payload;
Update frame type enum to match current class names.
2019-09-05 22:00:47 +00:00
Kiway().ExpressMail( FRAME_PCB_EDITOR, MAIL_PCB_UPDATE, payload, this );
eeschema: single click PCB update feature added
2016-01-29 10:24:39 +00:00
}
eeschema: code cleaning, comments added, and the true number of sheets and sheets numbers in complex hierarchies
2009-01-04 18:52:57 +00:00
Convert symbol library editor over to use symbol library table. Simplify some of the library editing code. There have been a few minor changes in the behavior of the editor. If the current symbol is deleted from the library, the next symbol in the library is not loaded. The deleted symbol is cleared and the current symbol is empty. Change component to symbol to align with the preferred terminology discussed on the developer's mailing list. Add separate update UI event for save library as to enable the menu entry whenever a library is selected. Change the select symbol list dialog to a single column using the LIB_ID format LIB_NICKNAME:LIB_ITEM_NAME so that the selection can be parsed by LIB_ID. Add method to expand URI to LIB_TABLE_BASE. Override wxApp::OnExceptionInMainLoop() in debug builds to make debugging easier when an unhandled exception occurs in a wxUpdateUIEvent handler. Change SCH_SCREENS::HasNoFullyDefinedLibIds() to return false when the schematic has no symbols to prevent the remapping dialog from being run. Use SCH_COMPONENT part reference when creating netlist rather than looking up the library symbol.
2017-10-06 18:07:43 +00:00
Minor net navigator improvements. Ignore bus member connection subgraphs. They do not have a valid net name nor do they contain schematic items. This prevents empty nodes from being added to the tree. They can be reintroduced in the future if someone wants to pursue it. Freeze the wxTreeCtrl while populating it and thaw when done to prevent any unnecessary repainting. Add profiling to test how long it takes to rebuild the net navigator. The recently added populate the navigator with all nets when no net is highlighted has exposed some potential performances issues with some versions of wxWidgets on certain platforms. Namely wxWidgets 3.2.4 on Linux GTK. Fix an issue where a sheet name change would not update the highlighted net navigator resulting in a stale human readable sheet path. Prevent the highlighted net navigator from being rebuilt twice when loading a schematic. SCH_EDIT_FRAME::RefreshNetNavigator() was being called from both SCH_EDIT_FRAME::UpdateHierarchyNavigator() and SCH_EDIT_FRAME::RecalculateConnectivity(). Add a new trace helper "KICAD_UI_PROFILE" to show trace output when profiling user interface performance. It's used in the net navigator profiling mentioned above. Reuse PROF_TIMER::Show() to generate string for PROF_TIMER::to_string().
2024-04-17 18:31:50 +00:00
void SCH_EDIT_FRAME::UpdateHierarchyNavigator( bool aRefreshNetNavigator )
eeschema: Allow hierarchy navigator to stay open ADD: User can now decide to keep the hierarchy navigator open while working on a schematic. This behavior can be configured in eeschema->preferences->eeschema->Editing options.
2019-10-24 17:07:01 +00:00
{
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
m_toolManager->GetTool<SCH_NAVIGATE_TOOL>()->CleanHistory();
m_hierarchy->UpdateHierarchyTree();
Minor net navigator improvements. Ignore bus member connection subgraphs. They do not have a valid net name nor do they contain schematic items. This prevents empty nodes from being added to the tree. They can be reintroduced in the future if someone wants to pursue it. Freeze the wxTreeCtrl while populating it and thaw when done to prevent any unnecessary repainting. Add profiling to test how long it takes to rebuild the net navigator. The recently added populate the navigator with all nets when no net is highlighted has exposed some potential performances issues with some versions of wxWidgets on certain platforms. Namely wxWidgets 3.2.4 on Linux GTK. Fix an issue where a sheet name change would not update the highlighted net navigator resulting in a stale human readable sheet path. Prevent the highlighted net navigator from being rebuilt twice when loading a schematic. SCH_EDIT_FRAME::RefreshNetNavigator() was being called from both SCH_EDIT_FRAME::UpdateHierarchyNavigator() and SCH_EDIT_FRAME::RecalculateConnectivity(). Add a new trace helper "KICAD_UI_PROFILE" to show trace output when profiling user interface performance. It's used in the net navigator profiling mentioned above. Reuse PROF_TIMER::Show() to generate string for PROF_TIMER::to_string().
2024-04-17 18:31:50 +00:00
if( aRefreshNetNavigator )
RefreshNetNavigator();
eeschema: Allow hierarchy navigator to stay open ADD: User can now decide to keep the hierarchy navigator open while working on a schematic. This behavior can be configured in eeschema->preferences->eeschema->Editing options.
2019-10-24 17:07:01 +00:00
}
New EESchema find dialog and other minor fixes. * Replaced find dialog with wxFormBuilder version. * New find dialog is modeless, supports more advanced search features, remembers it's last position, size, search history, and search settings, and implements initial support for replacing. * Added Shift+F5 hot key to search for next DRC marker. F5 now just repeats previous search. * Minor cosmetic enhancements to label edit dialog. * Remove tab from grid size text printf to fix toolbar grid combobox display in wxGTK. * Updated my TODO list items.
2010-03-16 18:22:59 +00:00
HIERARCHY_NAVIG_DLG: fix crash when in a subsheet one open the dialog and switch to the paren sheet from the context menu. Mainly, change the way the dialog is managed from the sch_edit_frame: the pointer to find the created dialog is replaced by a call to wxWidows::FindWindowByName(). Using a pointer set and cleared by events is a recipe for crashes.
2020-01-08 14:01:22 +00:00
HIERARCHY_PANE: Update tree labels when editing a sheet name or number Fixes #16650 https://gitlab.com/kicad/code/kicad/-/issues/16650
2024-01-25 17:20:43 +00:00
void SCH_EDIT_FRAME::UpdateLabelsHierarchyNavigator()
{
// Update only the hierarchy navigation tree labels.
// The tree list is expectyed to be up to date
m_hierarchy->UpdateLabelsHierarchyTree();
}
GUI improvements to hierarchy navigator. (1) and (3) from the linked issue. Fixes https://gitlab.com/kicad/code/kicad/issues/11762
2022-10-24 22:00:10 +00:00
void SCH_EDIT_FRAME::UpdateHierarchySelection()
{
m_hierarchy->UpdateHierarchySelection();
}
Rework Eeschema find/replace for modern toolset. Fixes: lp:1827274 * https://bugs.launchpad.net/kicad/+bug/1827274 Fixes: lp:1827240 * https://bugs.launchpad.net/kicad/+bug/1827240
2019-05-19 21:04:04 +00:00
void SCH_EDIT_FRAME::ShowFindReplaceDialog( bool aReplace )
{
Preload eeschema find with selection when appropriate. Fixes https://gitlab.com/kicad/code/kicad/issues/11148
2022-03-18 23:30:45 +00:00
wxString findString;
EE_SELECTION& selection = m_toolManager->GetTool<EE_SELECTION_TOOL>()->GetSelection();
if( selection.Size() == 1 )
{
EDA_ITEM* front = selection.Front();
switch( front->Type() )
{
case SCH_SYMBOL_T:
Fix a bunch more issues with sheetpaths and allowExtraText. A sheetpath is required to correctly resolve text variables. Depending on currentSheet is rife with bugs. There are many places where we do *not* want to be prepending field names to the field values, such as netlisting, building PDF hypertext menus, etc. Also, Find/Replace needs to work on unresolved text, as that's what we're going to display (and if replace nuked your variable references you wouldn't be happy).
2023-05-05 13:21:56 +00:00
{
SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( front );
findString = UnescapeString( symbol->GetField( VALUE_FIELD )->GetText() );
Preload eeschema find with selection when appropriate. Fixes https://gitlab.com/kicad/code/kicad/issues/11148
2022-03-18 23:30:45 +00:00
break;
Fix a bunch more issues with sheetpaths and allowExtraText. A sheetpath is required to correctly resolve text variables. Depending on currentSheet is rife with bugs. There are many places where we do *not* want to be prepending field names to the field values, such as netlisting, building PDF hypertext menus, etc. Also, Find/Replace needs to work on unresolved text, as that's what we're going to display (and if replace nuked your variable references you wouldn't be happy).
2023-05-05 13:21:56 +00:00
}
Preload eeschema find with selection when appropriate. Fixes https://gitlab.com/kicad/code/kicad/issues/11148
2022-03-18 23:30:45 +00:00
case SCH_FIELD_T:
Fix a bunch more issues with sheetpaths and allowExtraText. A sheetpath is required to correctly resolve text variables. Depending on currentSheet is rife with bugs. There are many places where we do *not* want to be prepending field names to the field values, such as netlisting, building PDF hypertext menus, etc. Also, Find/Replace needs to work on unresolved text, as that's what we're going to display (and if replace nuked your variable references you wouldn't be happy).
2023-05-05 13:21:56 +00:00
findString = UnescapeString( static_cast<SCH_FIELD*>( front )->GetText() );
Preload eeschema find with selection when appropriate. Fixes https://gitlab.com/kicad/code/kicad/issues/11148
2022-03-18 23:30:45 +00:00
break;
case SCH_LABEL_T:
case SCH_GLOBAL_LABEL_T:
case SCH_HIER_LABEL_T:
case SCH_SHEET_PIN_T:
Fix a bunch more issues with sheetpaths and allowExtraText. A sheetpath is required to correctly resolve text variables. Depending on currentSheet is rife with bugs. There are many places where we do *not* want to be prepending field names to the field values, such as netlisting, building PDF hypertext menus, etc. Also, Find/Replace needs to work on unresolved text, as that's what we're going to display (and if replace nuked your variable references you wouldn't be happy).
2023-05-05 13:21:56 +00:00
findString = UnescapeString( static_cast<SCH_LABEL_BASE*>( front )->GetText() );
Preload eeschema find with selection when appropriate. Fixes https://gitlab.com/kicad/code/kicad/issues/11148
2022-03-18 23:30:45 +00:00
break;
case SCH_TEXT_T:
Fix a bunch more issues with sheetpaths and allowExtraText. A sheetpath is required to correctly resolve text variables. Depending on currentSheet is rife with bugs. There are many places where we do *not* want to be prepending field names to the field values, such as netlisting, building PDF hypertext menus, etc. Also, Find/Replace needs to work on unresolved text, as that's what we're going to display (and if replace nuked your variable references you wouldn't be happy).
2023-05-05 13:21:56 +00:00
findString = UnescapeString( static_cast<SCH_TEXT*>( front )->GetText() );
Preload eeschema find with selection when appropriate. Fixes https://gitlab.com/kicad/code/kicad/issues/11148
2022-03-18 23:30:45 +00:00
if( findString.Contains( wxT( "\n" ) ) )
findString = findString.Before( '\n' );
break;
default:
break;
}
}
Fix crash with opening find dialog twice. Fixes: lp:1830224 * https://bugs.launchpad.net/kicad/+bug/1830224
2019-05-23 17:31:10 +00:00
if( m_findReplaceDialog )
m_findReplaceDialog->Destroy();
Improve Eeschema find code and add initial replace plumbing. * Replace Eeschema find code with a collector based implementation. * Fixed a search bug when all subsequent searches of an item would ignore the remaining valid child items when an item had more than one child item that matched the search criteria. * Add SCH_FIND_COLLECTOR class to find all items that meet the specified search criteria. * Add SCH_FIND_COLLECT0R_DATA to keep track of information for all matching items. * Use collector to iterate over the list of items that match the search criteria rather than trying to start at the last matched item. * Remove unused searching methods from sheet path and sheet path list objects. * Add replace and replace all functionality to Eeschema find dialog. * Push matching methods down to EDA_ITEM class so they can be used by other derived objects. * Add method to EDA_ITEM to test if item supports replacing. * Add flag to find/replace data to support replace feature. * Disable wild card matching check box when dialog is in replace mode as wild card replacement is not supported at this time. * The usual Doxygen comment and coding policy fixes.
2011-12-01 16:49:28 +00:00
Fix a bunch more issues with sheetpaths and allowExtraText. A sheetpath is required to correctly resolve text variables. Depending on currentSheet is rife with bugs. There are many places where we do *not* want to be prepending field names to the field values, such as netlisting, building PDF hypertext menus, etc. Also, Find/Replace needs to work on unresolved text, as that's what we're going to display (and if replace nuked your variable references you wouldn't be happy).
2023-05-05 13:21:56 +00:00
m_findReplaceDialog = new DIALOG_SCH_FIND( this,
static_cast<SCH_SEARCH_DATA*>( m_findReplaceData.get() ),
wxDefaultPosition, wxDefaultSize,
aReplace ? wxFR_REPLACEDIALOG : 0 );
Fix for hidden find dialog when display settings change.
2011-11-10 17:01:33 +00:00
Preload eeschema find with selection when appropriate. Fixes https://gitlab.com/kicad/code/kicad/issues/11148
2022-03-18 23:30:45 +00:00
m_findReplaceDialog->SetFindEntries( m_findStringHistoryList, findString );
Rework Eeschema find/replace for modern toolset. Fixes: lp:1827274 * https://bugs.launchpad.net/kicad/+bug/1827274 Fixes: lp:1827240 * https://bugs.launchpad.net/kicad/+bug/1827240
2019-05-19 21:04:04 +00:00
m_findReplaceDialog->SetReplaceEntries( m_replaceStringHistoryList );
m_findReplaceDialog->Show( true );
New EESchema find dialog and other minor fixes. * Replaced find dialog with wxFormBuilder version. * New find dialog is modeless, supports more advanced search features, remembers it's last position, size, search history, and search settings, and implements initial support for replacing. * Added Shift+F5 hot key to search for next DRC marker. F5 now just repeats previous search. * Minor cosmetic enhancements to label edit dialog. * Remove tab from grid size text printf to fix toolbar grid combobox display in wxGTK. * Updated my TODO list items.
2010-03-16 18:22:59 +00:00
}
Move eeschema find notification to the infobar and improve the infobar widget * Move it to a panel along with the canvas to have a better UI * Allow the infobar to automatically close after a set time CHANGED: The eeschema find notifications now use the infobar instead of a popup window
2020-05-20 01:31:47 +00:00
void SCH_EDIT_FRAME::ShowFindReplaceStatus( const wxString& aMsg, int aStatusTime )
New EESchema find dialog and other minor fixes. * Replaced find dialog with wxFormBuilder version. * New find dialog is modeless, supports more advanced search features, remembers it's last position, size, search history, and search settings, and implements initial support for replacing. * Added Shift+F5 hot key to search for next DRC marker. F5 now just repeats previous search. * Minor cosmetic enhancements to label edit dialog. * Remove tab from grid size text printf to fix toolbar grid combobox display in wxGTK. * Updated my TODO list items.
2010-03-16 18:22:59 +00:00
{
Move eeschema find notification to the infobar and improve the infobar widget * Move it to a panel along with the canvas to have a better UI * Allow the infobar to automatically close after a set time CHANGED: The eeschema find notifications now use the infobar instead of a popup window
2020-05-20 01:31:47 +00:00
// Prepare the infobar, since we don't know its state
m_infoBar->RemoveAllButtons();
m_infoBar->AddCloseButton();
EESchema find dialog improvements. * Add option to disable warping mouse to item found. * Add code to warp mouse when dialog is closed.
2011-02-03 21:57:02 +00:00
Move eeschema find notification to the infobar and improve the infobar widget * Move it to a panel along with the canvas to have a better UI * Allow the infobar to automatically close after a set time CHANGED: The eeschema find notifications now use the infobar instead of a popup window
2020-05-20 01:31:47 +00:00
m_infoBar->ShowMessageFor( aMsg, aStatusTime, wxICON_INFORMATION );
Rework Eeschema find/replace for modern toolset. Fixes: lp:1827274 * https://bugs.launchpad.net/kicad/+bug/1827274 Fixes: lp:1827240 * https://bugs.launchpad.net/kicad/+bug/1827240
2019-05-19 21:04:04 +00:00
}
void SCH_EDIT_FRAME::ClearFindReplaceStatus()
{
Move eeschema find notification to the infobar and improve the infobar widget * Move it to a panel along with the canvas to have a better UI * Allow the infobar to automatically close after a set time CHANGED: The eeschema find notifications now use the infobar instead of a popup window
2020-05-20 01:31:47 +00:00
m_infoBar->Dismiss();
Rework Eeschema find/replace for modern toolset. Fixes: lp:1827274 * https://bugs.launchpad.net/kicad/+bug/1827274 Fixes: lp:1827240 * https://bugs.launchpad.net/kicad/+bug/1827240
2019-05-19 21:04:04 +00:00
}
void SCH_EDIT_FRAME::OnFindDialogClose()
{
m_findStringHistoryList = m_findReplaceDialog->GetFindEntries();
m_replaceStringHistoryList = m_findReplaceDialog->GetReplaceEntries();
Fix crash with opening find dialog twice. Fixes: lp:1830224 * https://bugs.launchpad.net/kicad/+bug/1830224
2019-05-23 17:31:10 +00:00
Rework Eeschema find/replace for modern toolset. Fixes: lp:1827274 * https://bugs.launchpad.net/kicad/+bug/1827274 Fixes: lp:1827240 * https://bugs.launchpad.net/kicad/+bug/1827240
2019-05-19 21:04:04 +00:00
m_findReplaceDialog->Destroy();
Fix crash with opening find dialog twice. Fixes: lp:1830224 * https://bugs.launchpad.net/kicad/+bug/1830224
2019-05-23 17:31:10 +00:00
m_findReplaceDialog = nullptr;
Correctly de-highlight found items when closing Find dialog. Fixes https://gitlab.com/kicad/code/kicad/issues/5775
2020-09-24 17:46:01 +00:00
Separate immediate and delayed action dispatch Using a boolean argument just leads to a lot of trailing booleans in the function calls and is not user friendly. Instead, introduce PostAction() to send an action that runs after the coroutine (equivalent to passing false or the default argument), and leave RunAction as the immediate execution function.
2023-06-26 22:16:51 +00:00
m_toolManager->RunAction( ACTIONS::updateFind );
Fix escape key handling in annotate dialog and some eeschema code refactoring.
2008-02-27 19:38:16 +00:00
}
eeschema: code cleaning, comments added, and the true number of sheets and sheets numbers in complex hierarchies
2009-01-04 18:52:57 +00:00
Minor fixes and lots of coding policy changes.
2010-12-08 20:12:46 +00:00
void SCH_EDIT_FRAME::OnLoadFile( wxCommandEvent& event )
Fix escape key handling in annotate dialog and some eeschema code refactoring.
2008-02-27 19:38:16 +00:00
{
* KIWAY Milestone A): Make major modules into DLL/DSOs. ! The initial testing of this commit should be done using a Debug build so that all the wxASSERT()s are enabled. Also, be sure and keep enabled the USE_KIWAY_DLLs option. The tree won't likely build without it. Turning it off is senseless anyways. If you want stable code, go back to a prior version, the one tagged with "stable". * Relocate all functionality out of the wxApp derivative into more finely targeted purposes: a) DLL/DSO specific b) PROJECT specific c) EXE or process specific d) configuration file specific data e) configuration file manipulations functions. All of this functionality was blended into an extremely large wxApp derivative and that was incompatible with the desire to support multiple concurrently loaded DLL/DSO's ("KIFACE")s and multiple concurrently open projects. An amazing amount of organization come from simply sorting each bit of functionality into the proper box. * Switch to wxConfigBase from wxConfig everywhere except instantiation. * Add classes KIWAY, KIFACE, KIFACE_I, SEARCH_STACK, PGM_BASE, PGM_KICAD, PGM_SINGLE_TOP, * Remove "Return" prefix on many function names. * Remove obvious comments from CMakeLists.txt files, and from else() and endif()s. * Fix building boost for use in a DSO on linux. * Remove some of the assumptions in the CMakeLists.txt files that windows had to be the host platform when building windows binaries. * Reduce the number of wxStrings being constructed at program load time via static construction. * Pass wxConfigBase* to all SaveSettings() and LoadSettings() functions so that these functions are useful even when the wxConfigBase comes from another source, as is the case in the KICAD_MANAGER_FRAME. * Move the setting of the KIPRJMOD environment variable into class PROJECT, so that it can be moved into a project variable soon, and out of FP_LIB_TABLE. * Add the KIWAY_PLAYER which is associated with a particular PROJECT, and all its child wxFrames and wxDialogs now have a Kiway() member function which returns a KIWAY& that that window tree branch is in support of. This is like wxWindows DNA in that child windows get this member with proper value at time of construction. * Anticipate some of the needs for milestones B) and C) and make code adjustments now in an effort to reduce work in those milestones. * No testing has been done for python scripting, since milestone C) has that being largely reworked and re-thought-out.
2014-03-20 00:42:08 +00:00
wxString fn = GetFileFromHistory( event.GetId(), _( "Schematic" ) );
Fix escape key handling in annotate dialog and some eeschema code refactoring.
2008-02-27 19:38:16 +00:00
* KIWAY Milestone A): Make major modules into DLL/DSOs. ! The initial testing of this commit should be done using a Debug build so that all the wxASSERT()s are enabled. Also, be sure and keep enabled the USE_KIWAY_DLLs option. The tree won't likely build without it. Turning it off is senseless anyways. If you want stable code, go back to a prior version, the one tagged with "stable". * Relocate all functionality out of the wxApp derivative into more finely targeted purposes: a) DLL/DSO specific b) PROJECT specific c) EXE or process specific d) configuration file specific data e) configuration file manipulations functions. All of this functionality was blended into an extremely large wxApp derivative and that was incompatible with the desire to support multiple concurrently loaded DLL/DSO's ("KIFACE")s and multiple concurrently open projects. An amazing amount of organization come from simply sorting each bit of functionality into the proper box. * Switch to wxConfigBase from wxConfig everywhere except instantiation. * Add classes KIWAY, KIFACE, KIFACE_I, SEARCH_STACK, PGM_BASE, PGM_KICAD, PGM_SINGLE_TOP, * Remove "Return" prefix on many function names. * Remove obvious comments from CMakeLists.txt files, and from else() and endif()s. * Fix building boost for use in a DSO on linux. * Remove some of the assumptions in the CMakeLists.txt files that windows had to be the host platform when building windows binaries. * Reduce the number of wxStrings being constructed at program load time via static construction. * Pass wxConfigBase* to all SaveSettings() and LoadSettings() functions so that these functions are useful even when the wxConfigBase comes from another source, as is the case in the KICAD_MANAGER_FRAME. * Move the setting of the KIPRJMOD environment variable into class PROJECT, so that it can be moved into a project variable soon, and out of FP_LIB_TABLE. * Add the KIWAY_PLAYER which is associated with a particular PROJECT, and all its child wxFrames and wxDialogs now have a Kiway() member function which returns a KIWAY& that that window tree branch is in support of. This is like wxWindows DNA in that child windows get this member with proper value at time of construction. * Anticipate some of the needs for milestones B) and C) and make code adjustments now in an effort to reduce work in those milestones. * No testing has been done for python scripting, since milestone C) has that being largely reworked and re-thought-out.
2014-03-20 00:42:08 +00:00
if( fn.size() )
OpenProjectFiles( std::vector<wxString>( 1, fn ) );
Fix escape key handling in annotate dialog and some eeschema code refactoring.
2008-02-27 19:38:16 +00:00
}
Added Backannotate Footprints from Stuff File Feature
2008-05-07 15:08:16 +00:00
eeschema: code cleaning, comments added, and the true number of sheets and sheets numbers in complex hierarchies
2009-01-04 18:52:57 +00:00
Rework the file history menus to not need references to the file history Keeping a pointer to the actual file history inside a special file history menu led to many cases of use after free crashes, so instead rework the actual file history to add the menu items. Fixes https://gitlab.com/kicad/code/kicad/issues/3741
2020-02-25 15:46:56 +00:00
void SCH_EDIT_FRAME::OnClearFileHistory( wxCommandEvent& aEvent )
{
ClearFileHistory();
}
Implement common file menu actions and move Eeschema over.
2019-05-24 23:36:31 +00:00
void SCH_EDIT_FRAME::NewProject()
Fix escape key handling in annotate dialog and some eeschema code refactoring.
2008-02-27 19:38:16 +00:00
{
Guard actions that change project against running in non-standalone mode Fixes https://gitlab.com/kicad/code/kicad/-/issues/16942
2024-02-11 14:36:17 +00:00
// Only standalone mode can directly load a new document
if( !Kiface().IsSingle() )
return;
Default and most recently used path fixes. (fixes: 1494210) * Rename Eda_FileSelector to EDA_FILE_SELECTOR. * Add optional pointer to wxString to save the most recently used path to EDA_FILE_SELECTOR. * Rename Eda_DirectorySelector to EDA_PATH_SELECTOR. * Replace wxGetCwd() with wxStandardPaths::GetDocumentsDir(). This fixes the windows issue where wxGetCwd() returns the path where the executable files are located. * Add code to handle most recently used path to EDA_BASE_FRAME. * Fix string formatting error in kicad/files-io.cpp. * Remove setting and restoring current working directory when launching GerbView. Setting the CWD has no effect on the launched executable which starts with it's own CWD. * Allow project path to be passed to GerbView when launched from KiCad. * Note: this is a work in progress. Do not expect every path and/or file selection dialog to properly update the most recently used path. The correct solution to this problem requires a much more well though out solution which will not happen until after the next stable release.
2015-09-25 19:38:09 +00:00
wxString pro_dir = m_mruPath;
Modular KiCad Blueprint Milestone B), major portions: *) When kicad.exe closes a project, close any open KIFACEs so that they cannot get disassociated from their true PROJECT. *) Allow loading eeschema library editor from kicad.exe *) Allow loading pcbnew library editor from kicad.exe *) Rename LIB_COMPONENT to LIB_PART. *) Add class PART_LIBS, and PART_LIB. *) Make PART_LIBS non-global, i.e. PROJECT specific. *) Implement "data on demand" for PART_LIBS *) Implement "data on demand" for schematic SEARCH_STACK. *) Use RSTRINGs to retain eeschema editor's notion of last library and part being edited. *) Get rid of library search on every SCH_COMPONENT::Draw() call, instead use a weak pointer. *) Remove all chdir() calls so projects don't need to be CWD. *) Romove APPEND support from OpenProjectFiles(). *) Make OpenProjectFiles() robust, even for creating new projects. *) Load EESCHEMA colors in the KIWAY::OnKiwayStart() rather in window open, and save them in the .eeschema config file, not in the project file. *) Fix bug with wxDir() while accessing protected dirs in kicad.exe *) Consolidate template copying into PROJECT class, not in kicad.exe source. *) Generally untangle eeschema, making its libraries not global but rather held in the PROJECT.
2014-08-13 20:28:54 +00:00
Eeschema: implement s-expression schematic file formatter. Please note that the symbol cache is not embedded in the schematic file to allow for round robin testing with the existing file format. Once the parser round robin testing is complete, the symbol cache will be embedded in the schematic file.
2020-03-16 13:04:50 +00:00
wxFileDialog dlg( this, _( "New Schematic" ), pro_dir, wxEmptyString,
Kick the wildcards and file exts into a static class, export it from kicommon
2023-12-28 02:10:01 +00:00
FILEEXT::KiCadSchematicFileWildcard(), wxFD_SAVE );
* KIWAY Milestone A): Make major modules into DLL/DSOs. ! The initial testing of this commit should be done using a Debug build so that all the wxASSERT()s are enabled. Also, be sure and keep enabled the USE_KIWAY_DLLs option. The tree won't likely build without it. Turning it off is senseless anyways. If you want stable code, go back to a prior version, the one tagged with "stable". * Relocate all functionality out of the wxApp derivative into more finely targeted purposes: a) DLL/DSO specific b) PROJECT specific c) EXE or process specific d) configuration file specific data e) configuration file manipulations functions. All of this functionality was blended into an extremely large wxApp derivative and that was incompatible with the desire to support multiple concurrently loaded DLL/DSO's ("KIFACE")s and multiple concurrently open projects. An amazing amount of organization come from simply sorting each bit of functionality into the proper box. * Switch to wxConfigBase from wxConfig everywhere except instantiation. * Add classes KIWAY, KIFACE, KIFACE_I, SEARCH_STACK, PGM_BASE, PGM_KICAD, PGM_SINGLE_TOP, * Remove "Return" prefix on many function names. * Remove obvious comments from CMakeLists.txt files, and from else() and endif()s. * Fix building boost for use in a DSO on linux. * Remove some of the assumptions in the CMakeLists.txt files that windows had to be the host platform when building windows binaries. * Reduce the number of wxStrings being constructed at program load time via static construction. * Pass wxConfigBase* to all SaveSettings() and LoadSettings() functions so that these functions are useful even when the wxConfigBase comes from another source, as is the case in the KICAD_MANAGER_FRAME. * Move the setting of the KIPRJMOD environment variable into class PROJECT, so that it can be moved into a project variable soon, and out of FP_LIB_TABLE. * Add the KIWAY_PLAYER which is associated with a particular PROJECT, and all its child wxFrames and wxDialogs now have a Kiway() member function which returns a KIWAY& that that window tree branch is in support of. This is like wxWindows DNA in that child windows get this member with proper value at time of construction. * Anticipate some of the needs for milestones B) and C) and make code adjustments now in an effort to reduce work in those milestones. * No testing has been done for python scripting, since milestone C) has that being largely reworked and re-thought-out.
2014-03-20 00:42:08 +00:00
if( dlg.ShowModal() != wxID_CANCEL )
{
Modular KiCad Blueprint Milestone B), major portions: *) When kicad.exe closes a project, close any open KIFACEs so that they cannot get disassociated from their true PROJECT. *) Allow loading eeschema library editor from kicad.exe *) Allow loading pcbnew library editor from kicad.exe *) Rename LIB_COMPONENT to LIB_PART. *) Add class PART_LIBS, and PART_LIB. *) Make PART_LIBS non-global, i.e. PROJECT specific. *) Implement "data on demand" for PART_LIBS *) Implement "data on demand" for schematic SEARCH_STACK. *) Use RSTRINGs to retain eeschema editor's notion of last library and part being edited. *) Get rid of library search on every SCH_COMPONENT::Draw() call, instead use a weak pointer. *) Remove all chdir() calls so projects don't need to be CWD. *) Romove APPEND support from OpenProjectFiles(). *) Make OpenProjectFiles() robust, even for creating new projects. *) Load EESCHEMA colors in the KIWAY::OnKiwayStart() rather in window open, and save them in the .eeschema config file, not in the project file. *) Fix bug with wxDir() while accessing protected dirs in kicad.exe *) Consolidate template copying into PROJECT class, not in kicad.exe source. *) Generally untangle eeschema, making its libraries not global but rather held in the PROJECT.
2014-08-13 20:28:54 +00:00
// Enforce the extension, wxFileDialog is inept.
Kick the wildcards and file exts into a static class, export it from kicommon
2023-12-28 02:10:01 +00:00
wxFileName create_me =
EnsureFileExtension( dlg.GetPath(), FILEEXT::KiCadSchematicFileExtension );
Modular KiCad Blueprint Milestone B), major portions: *) When kicad.exe closes a project, close any open KIFACEs so that they cannot get disassociated from their true PROJECT. *) Allow loading eeschema library editor from kicad.exe *) Allow loading pcbnew library editor from kicad.exe *) Rename LIB_COMPONENT to LIB_PART. *) Add class PART_LIBS, and PART_LIB. *) Make PART_LIBS non-global, i.e. PROJECT specific. *) Implement "data on demand" for PART_LIBS *) Implement "data on demand" for schematic SEARCH_STACK. *) Use RSTRINGs to retain eeschema editor's notion of last library and part being edited. *) Get rid of library search on every SCH_COMPONENT::Draw() call, instead use a weak pointer. *) Remove all chdir() calls so projects don't need to be CWD. *) Romove APPEND support from OpenProjectFiles(). *) Make OpenProjectFiles() robust, even for creating new projects. *) Load EESCHEMA colors in the KIWAY::OnKiwayStart() rather in window open, and save them in the .eeschema config file, not in the project file. *) Fix bug with wxDir() while accessing protected dirs in kicad.exe *) Consolidate template copying into PROJECT class, not in kicad.exe source. *) Generally untangle eeschema, making its libraries not global but rather held in the PROJECT.
2014-08-13 20:28:54 +00:00
if( create_me.FileExists() )
{
Add GAL refresh for some more commands and remove unused DC params.
2018-09-09 21:06:38 +00:00
wxString msg;
Consistent terminology and punctuation.
2021-06-16 22:35:00 +00:00
msg.Printf( _( "Schematic file '%s' already exists." ), create_me.GetFullName() );
Modular KiCad Blueprint Milestone B), major portions: *) When kicad.exe closes a project, close any open KIFACEs so that they cannot get disassociated from their true PROJECT. *) Allow loading eeschema library editor from kicad.exe *) Allow loading pcbnew library editor from kicad.exe *) Rename LIB_COMPONENT to LIB_PART. *) Add class PART_LIBS, and PART_LIB. *) Make PART_LIBS non-global, i.e. PROJECT specific. *) Implement "data on demand" for PART_LIBS *) Implement "data on demand" for schematic SEARCH_STACK. *) Use RSTRINGs to retain eeschema editor's notion of last library and part being edited. *) Get rid of library search on every SCH_COMPONENT::Draw() call, instead use a weak pointer. *) Remove all chdir() calls so projects don't need to be CWD. *) Romove APPEND support from OpenProjectFiles(). *) Make OpenProjectFiles() robust, even for creating new projects. *) Load EESCHEMA colors in the KIWAY::OnKiwayStart() rather in window open, and save them in the .eeschema config file, not in the project file. *) Fix bug with wxDir() while accessing protected dirs in kicad.exe *) Consolidate template copying into PROJECT class, not in kicad.exe source. *) Generally untangle eeschema, making its libraries not global but rather held in the PROJECT.
2014-08-13 20:28:54 +00:00
DisplayError( this, msg );
return ;
}
// OpenProjectFiles() requires absolute
More wxSing
2023-01-17 04:14:38 +00:00
wxASSERT_MSG( create_me.IsAbsolute(), wxS( "wxFileDialog returned non-absolute path" ) );
Modular KiCad Blueprint Milestone B), major portions: *) When kicad.exe closes a project, close any open KIFACEs so that they cannot get disassociated from their true PROJECT. *) Allow loading eeschema library editor from kicad.exe *) Allow loading pcbnew library editor from kicad.exe *) Rename LIB_COMPONENT to LIB_PART. *) Add class PART_LIBS, and PART_LIB. *) Make PART_LIBS non-global, i.e. PROJECT specific. *) Implement "data on demand" for PART_LIBS *) Implement "data on demand" for schematic SEARCH_STACK. *) Use RSTRINGs to retain eeschema editor's notion of last library and part being edited. *) Get rid of library search on every SCH_COMPONENT::Draw() call, instead use a weak pointer. *) Remove all chdir() calls so projects don't need to be CWD. *) Romove APPEND support from OpenProjectFiles(). *) Make OpenProjectFiles() robust, even for creating new projects. *) Load EESCHEMA colors in the KIWAY::OnKiwayStart() rather in window open, and save them in the .eeschema config file, not in the project file. *) Fix bug with wxDir() while accessing protected dirs in kicad.exe *) Consolidate template copying into PROJECT class, not in kicad.exe source. *) Generally untangle eeschema, making its libraries not global but rather held in the PROJECT.
2014-08-13 20:28:54 +00:00
OpenProjectFiles( std::vector<wxString>( 1, create_me.GetFullPath() ), KICTL_CREATE );
Default and most recently used path fixes. (fixes: 1494210) * Rename Eda_FileSelector to EDA_FILE_SELECTOR. * Add optional pointer to wxString to save the most recently used path to EDA_FILE_SELECTOR. * Rename Eda_DirectorySelector to EDA_PATH_SELECTOR. * Replace wxGetCwd() with wxStandardPaths::GetDocumentsDir(). This fixes the windows issue where wxGetCwd() returns the path where the executable files are located. * Add code to handle most recently used path to EDA_BASE_FRAME. * Fix string formatting error in kicad/files-io.cpp. * Remove setting and restoring current working directory when launching GerbView. Setting the CWD has no effect on the launched executable which starts with it's own CWD. * Allow project path to be passed to GerbView when launched from KiCad. * Note: this is a work in progress. Do not expect every path and/or file selection dialog to properly update the most recently used path. The correct solution to this problem requires a much more well though out solution which will not happen until after the next stable release.
2015-09-25 19:38:09 +00:00
m_mruPath = create_me.GetPath();
* KIWAY Milestone A): Make major modules into DLL/DSOs. ! The initial testing of this commit should be done using a Debug build so that all the wxASSERT()s are enabled. Also, be sure and keep enabled the USE_KIWAY_DLLs option. The tree won't likely build without it. Turning it off is senseless anyways. If you want stable code, go back to a prior version, the one tagged with "stable". * Relocate all functionality out of the wxApp derivative into more finely targeted purposes: a) DLL/DSO specific b) PROJECT specific c) EXE or process specific d) configuration file specific data e) configuration file manipulations functions. All of this functionality was blended into an extremely large wxApp derivative and that was incompatible with the desire to support multiple concurrently loaded DLL/DSO's ("KIFACE")s and multiple concurrently open projects. An amazing amount of organization come from simply sorting each bit of functionality into the proper box. * Switch to wxConfigBase from wxConfig everywhere except instantiation. * Add classes KIWAY, KIFACE, KIFACE_I, SEARCH_STACK, PGM_BASE, PGM_KICAD, PGM_SINGLE_TOP, * Remove "Return" prefix on many function names. * Remove obvious comments from CMakeLists.txt files, and from else() and endif()s. * Fix building boost for use in a DSO on linux. * Remove some of the assumptions in the CMakeLists.txt files that windows had to be the host platform when building windows binaries. * Reduce the number of wxStrings being constructed at program load time via static construction. * Pass wxConfigBase* to all SaveSettings() and LoadSettings() functions so that these functions are useful even when the wxConfigBase comes from another source, as is the case in the KICAD_MANAGER_FRAME. * Move the setting of the KIPRJMOD environment variable into class PROJECT, so that it can be moved into a project variable soon, and out of FP_LIB_TABLE. * Add the KIWAY_PLAYER which is associated with a particular PROJECT, and all its child wxFrames and wxDialogs now have a Kiway() member function which returns a KIWAY& that that window tree branch is in support of. This is like wxWindows DNA in that child windows get this member with proper value at time of construction. * Anticipate some of the needs for milestones B) and C) and make code adjustments now in an effort to reduce work in those milestones. * No testing has been done for python scripting, since milestone C) has that being largely reworked and re-thought-out.
2014-03-20 00:42:08 +00:00
}
Fix escape key handling in annotate dialog and some eeschema code refactoring.
2008-02-27 19:38:16 +00:00
}
eeschema: code cleaning, comments added, and the true number of sheets and sheets numbers in complex hierarchies
2009-01-04 18:52:57 +00:00
Implement common file menu actions and move Eeschema over.
2019-05-24 23:36:31 +00:00
void SCH_EDIT_FRAME::LoadProject()
Fix escape key handling in annotate dialog and some eeschema code refactoring.
2008-02-27 19:38:16 +00:00
{
Guard actions that change project against running in non-standalone mode Fixes https://gitlab.com/kicad/code/kicad/-/issues/16942
2024-02-11 14:36:17 +00:00
// Only standalone mode can directly load a new document
if( !Kiface().IsSingle() )
return;
Default and most recently used path fixes. (fixes: 1494210) * Rename Eda_FileSelector to EDA_FILE_SELECTOR. * Add optional pointer to wxString to save the most recently used path to EDA_FILE_SELECTOR. * Rename Eda_DirectorySelector to EDA_PATH_SELECTOR. * Replace wxGetCwd() with wxStandardPaths::GetDocumentsDir(). This fixes the windows issue where wxGetCwd() returns the path where the executable files are located. * Add code to handle most recently used path to EDA_BASE_FRAME. * Fix string formatting error in kicad/files-io.cpp. * Remove setting and restoring current working directory when launching GerbView. Setting the CWD has no effect on the launched executable which starts with it's own CWD. * Allow project path to be passed to GerbView when launched from KiCad. * Note: this is a work in progress. Do not expect every path and/or file selection dialog to properly update the most recently used path. The correct solution to this problem requires a much more well though out solution which will not happen until after the next stable release.
2015-09-25 19:38:09 +00:00
wxString pro_dir = m_mruPath;
Kick the wildcards and file exts into a static class, export it from kicommon
2023-12-28 02:10:01 +00:00
wxString wildcards = FILEEXT::AllSchematicFilesWildcard()
+ wxS( "|" ) + FILEEXT::KiCadSchematicFileWildcard()
+ wxS( "|" ) + FILEEXT::LegacySchematicFileWildcard();
* KIWAY Milestone A): Make major modules into DLL/DSOs. ! The initial testing of this commit should be done using a Debug build so that all the wxASSERT()s are enabled. Also, be sure and keep enabled the USE_KIWAY_DLLs option. The tree won't likely build without it. Turning it off is senseless anyways. If you want stable code, go back to a prior version, the one tagged with "stable". * Relocate all functionality out of the wxApp derivative into more finely targeted purposes: a) DLL/DSO specific b) PROJECT specific c) EXE or process specific d) configuration file specific data e) configuration file manipulations functions. All of this functionality was blended into an extremely large wxApp derivative and that was incompatible with the desire to support multiple concurrently loaded DLL/DSO's ("KIFACE")s and multiple concurrently open projects. An amazing amount of organization come from simply sorting each bit of functionality into the proper box. * Switch to wxConfigBase from wxConfig everywhere except instantiation. * Add classes KIWAY, KIFACE, KIFACE_I, SEARCH_STACK, PGM_BASE, PGM_KICAD, PGM_SINGLE_TOP, * Remove "Return" prefix on many function names. * Remove obvious comments from CMakeLists.txt files, and from else() and endif()s. * Fix building boost for use in a DSO on linux. * Remove some of the assumptions in the CMakeLists.txt files that windows had to be the host platform when building windows binaries. * Reduce the number of wxStrings being constructed at program load time via static construction. * Pass wxConfigBase* to all SaveSettings() and LoadSettings() functions so that these functions are useful even when the wxConfigBase comes from another source, as is the case in the KICAD_MANAGER_FRAME. * Move the setting of the KIPRJMOD environment variable into class PROJECT, so that it can be moved into a project variable soon, and out of FP_LIB_TABLE. * Add the KIWAY_PLAYER which is associated with a particular PROJECT, and all its child wxFrames and wxDialogs now have a Kiway() member function which returns a KIWAY& that that window tree branch is in support of. This is like wxWindows DNA in that child windows get this member with proper value at time of construction. * Anticipate some of the needs for milestones B) and C) and make code adjustments now in an effort to reduce work in those milestones. * No testing has been done for python scripting, since milestone C) has that being largely reworked and re-thought-out.
2014-03-20 00:42:08 +00:00
Eeschema: implement s-expression schematic file formatter. Please note that the symbol cache is not embedded in the schematic file to allow for round robin testing with the existing file format. Once the parser round robin testing is complete, the symbol cache will be embedded in the schematic file.
2020-03-16 13:04:50 +00:00
wxFileDialog dlg( this, _( "Open Schematic" ), pro_dir, wxEmptyString,
Eeschema: implement s-expression schematic file format parser. Fix a few issues with the s-expression schematic file formatter.
2020-03-25 15:27:15 +00:00
wildcards, wxFD_OPEN | wxFD_FILE_MUST_EXIST );
* KIWAY Milestone A): Make major modules into DLL/DSOs. ! The initial testing of this commit should be done using a Debug build so that all the wxASSERT()s are enabled. Also, be sure and keep enabled the USE_KIWAY_DLLs option. The tree won't likely build without it. Turning it off is senseless anyways. If you want stable code, go back to a prior version, the one tagged with "stable". * Relocate all functionality out of the wxApp derivative into more finely targeted purposes: a) DLL/DSO specific b) PROJECT specific c) EXE or process specific d) configuration file specific data e) configuration file manipulations functions. All of this functionality was blended into an extremely large wxApp derivative and that was incompatible with the desire to support multiple concurrently loaded DLL/DSO's ("KIFACE")s and multiple concurrently open projects. An amazing amount of organization come from simply sorting each bit of functionality into the proper box. * Switch to wxConfigBase from wxConfig everywhere except instantiation. * Add classes KIWAY, KIFACE, KIFACE_I, SEARCH_STACK, PGM_BASE, PGM_KICAD, PGM_SINGLE_TOP, * Remove "Return" prefix on many function names. * Remove obvious comments from CMakeLists.txt files, and from else() and endif()s. * Fix building boost for use in a DSO on linux. * Remove some of the assumptions in the CMakeLists.txt files that windows had to be the host platform when building windows binaries. * Reduce the number of wxStrings being constructed at program load time via static construction. * Pass wxConfigBase* to all SaveSettings() and LoadSettings() functions so that these functions are useful even when the wxConfigBase comes from another source, as is the case in the KICAD_MANAGER_FRAME. * Move the setting of the KIPRJMOD environment variable into class PROJECT, so that it can be moved into a project variable soon, and out of FP_LIB_TABLE. * Add the KIWAY_PLAYER which is associated with a particular PROJECT, and all its child wxFrames and wxDialogs now have a Kiway() member function which returns a KIWAY& that that window tree branch is in support of. This is like wxWindows DNA in that child windows get this member with proper value at time of construction. * Anticipate some of the needs for milestones B) and C) and make code adjustments now in an effort to reduce work in those milestones. * No testing has been done for python scripting, since milestone C) has that being largely reworked and re-thought-out.
2014-03-20 00:42:08 +00:00
if( dlg.ShowModal() != wxID_CANCEL )
{
OpenProjectFiles( std::vector<wxString>( 1, dlg.GetPath() ) );
Default and most recently used path fixes. (fixes: 1494210) * Rename Eda_FileSelector to EDA_FILE_SELECTOR. * Add optional pointer to wxString to save the most recently used path to EDA_FILE_SELECTOR. * Rename Eda_DirectorySelector to EDA_PATH_SELECTOR. * Replace wxGetCwd() with wxStandardPaths::GetDocumentsDir(). This fixes the windows issue where wxGetCwd() returns the path where the executable files are located. * Add code to handle most recently used path to EDA_BASE_FRAME. * Fix string formatting error in kicad/files-io.cpp. * Remove setting and restoring current working directory when launching GerbView. Setting the CWD has no effect on the launched executable which starts with it's own CWD. * Allow project path to be passed to GerbView when launched from KiCad. * Note: this is a work in progress. Do not expect every path and/or file selection dialog to properly update the most recently used path. The correct solution to this problem requires a much more well though out solution which will not happen until after the next stable release.
2015-09-25 19:38:09 +00:00
m_mruPath = Prj().GetProjectPath();
* KIWAY Milestone A): Make major modules into DLL/DSOs. ! The initial testing of this commit should be done using a Debug build so that all the wxASSERT()s are enabled. Also, be sure and keep enabled the USE_KIWAY_DLLs option. The tree won't likely build without it. Turning it off is senseless anyways. If you want stable code, go back to a prior version, the one tagged with "stable". * Relocate all functionality out of the wxApp derivative into more finely targeted purposes: a) DLL/DSO specific b) PROJECT specific c) EXE or process specific d) configuration file specific data e) configuration file manipulations functions. All of this functionality was blended into an extremely large wxApp derivative and that was incompatible with the desire to support multiple concurrently loaded DLL/DSO's ("KIFACE")s and multiple concurrently open projects. An amazing amount of organization come from simply sorting each bit of functionality into the proper box. * Switch to wxConfigBase from wxConfig everywhere except instantiation. * Add classes KIWAY, KIFACE, KIFACE_I, SEARCH_STACK, PGM_BASE, PGM_KICAD, PGM_SINGLE_TOP, * Remove "Return" prefix on many function names. * Remove obvious comments from CMakeLists.txt files, and from else() and endif()s. * Fix building boost for use in a DSO on linux. * Remove some of the assumptions in the CMakeLists.txt files that windows had to be the host platform when building windows binaries. * Reduce the number of wxStrings being constructed at program load time via static construction. * Pass wxConfigBase* to all SaveSettings() and LoadSettings() functions so that these functions are useful even when the wxConfigBase comes from another source, as is the case in the KICAD_MANAGER_FRAME. * Move the setting of the KIPRJMOD environment variable into class PROJECT, so that it can be moved into a project variable soon, and out of FP_LIB_TABLE. * Add the KIWAY_PLAYER which is associated with a particular PROJECT, and all its child wxFrames and wxDialogs now have a Kiway() member function which returns a KIWAY& that that window tree branch is in support of. This is like wxWindows DNA in that child windows get this member with proper value at time of construction. * Anticipate some of the needs for milestones B) and C) and make code adjustments now in an effort to reduce work in those milestones. * No testing has been done for python scripting, since milestone C) has that being largely reworked and re-thought-out.
2014-03-20 00:42:08 +00:00
}
Fix escape key handling in annotate dialog and some eeschema code refactoring.
2008-02-27 19:38:16 +00:00
}
eeschema: code cleaning, comments added, and the true number of sheets and sheets numbers in complex hierarchies
2009-01-04 18:52:57 +00:00
Minor fixes and lots of coding policy changes.
2010-12-08 20:12:46 +00:00
void SCH_EDIT_FRAME::OnOpenPcbnew( wxCommandEvent& event )
Fix escape key handling in annotate dialog and some eeschema code refactoring.
2008-02-27 19:38:16 +00:00
{
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
wxFileName kicad_board = Prj().AbsolutePath( Schematic().GetFileName() );
Fix escape key handling in annotate dialog and some eeschema code refactoring.
2008-02-27 19:38:16 +00:00
Fix double call of OnPgmExit Also fix bad filename being passed to pcbnew when starting from a blank schematic in standalone mode Fixes https://gitlab.com/kicad/code/kicad/-/issues/5786
2020-10-04 22:39:21 +00:00
if( kicad_board.IsOk() && !Schematic().GetFileName().IsEmpty() )
Fix escape key handling in annotate dialog and some eeschema code refactoring.
2008-02-27 19:38:16 +00:00
{
Kick the wildcards and file exts into a static class, export it from kicommon
2023-12-28 02:10:01 +00:00
kicad_board.SetExt( FILEEXT::PcbFileExtension );
Eeschema: fix Bug #1475905: Opening a legacy (.brd) file from a schematic fails. Now opening a board from eeschema works like from Kicamanager: if a .brd file exists and the .kicad_pcb file does not exists, the .brd file will be loaded.
2015-07-19 14:38:02 +00:00
wxFileName legacy_board( kicad_board );
Kick the wildcards and file exts into a static class, export it from kicommon
2023-12-28 02:10:01 +00:00
legacy_board.SetExt( FILEEXT::LegacyPcbFileExtension );
Moving PageLayout editor to GAL canvas and modern toolset.
2019-05-20 10:23:32 +00:00
wxFileName& boardfn = legacy_board;
if( !legacy_board.FileExists() || kicad_board.FileExists() )
boardfn = kicad_board;
fix Bug #578532, document and embellish QuoteFullPath()
2010-05-11 14:35:13 +00:00
add back missing pcbnew cross probing event handlers. eeschema launches kiface versions of pcbnew & cvpcb if not single.
2014-04-20 04:35:34 +00:00
if( Kiface().IsSingle() )
{
New paramaterized interface doesn't like quoted parameters. (At least on MSW, anyway.)
2021-10-02 13:08:36 +00:00
ExecuteFile( PCBNEW_EXE, boardfn.GetFullPath() );
add back missing pcbnew cross probing event handlers. eeschema launches kiface versions of pcbnew & cvpcb if not single.
2014-04-20 04:35:34 +00:00
}
else
{
Remove vestiages of old open-PCB-for-settings hack. We used to have to open a PCB_EDIT_FRAME to get the settings for the footprint editor and footprint viewer. This necessitated some special processing when opening a PCB_EDIT_FRAME to actually edit a board as it might already be open but unloaded. Since the new settings architecture allows the footprint editor and footprint viewer to init themselves we no longer need the special- case code.
2020-07-10 16:59:06 +00:00
KIWAY_PLAYER* frame = Kiway().Player( FRAME_PCB_EDITOR, false );
add back missing pcbnew cross probing event handlers. eeschema launches kiface versions of pcbnew & cvpcb if not single.
2014-04-20 04:35:34 +00:00
Remove vestiages of old open-PCB-for-settings hack. We used to have to open a PCB_EDIT_FRAME to get the settings for the footprint editor and footprint viewer. This necessitated some special processing when opening a PCB_EDIT_FRAME to actually edit a board as it might already be open but unloaded. Since the new settings architecture allows the footprint editor and footprint viewer to init themselves we no longer need the special- case code.
2020-07-10 16:59:06 +00:00
if( !frame )
add back missing pcbnew cross probing event handlers. eeschema launches kiface versions of pcbnew & cvpcb if not single.
2014-04-20 04:35:34 +00:00
{
Remove vestiages of old open-PCB-for-settings hack. We used to have to open a PCB_EDIT_FRAME to get the settings for the footprint editor and footprint viewer. This necessitated some special processing when opening a PCB_EDIT_FRAME to actually edit a board as it might already be open but unloaded. Since the new settings architecture allows the footprint editor and footprint viewer to init themselves we no longer need the special- case code.
2020-07-10 16:59:06 +00:00
frame = Kiway().Player( FRAME_PCB_EDITOR, true );
Avoid crashes when, for some reason, a dll cannot be loaded. In this case a null pointer was returned by the internal code. This pointer is now tested against nullptr to avoid the application crashing. Fixes #12080 https://gitlab.com/kicad/code/kicad/issues/12080
2022-07-24 17:42:50 +00:00
// frame can be null if Cvpcb cannot be run. No need to show a warning
// Kiway() generates the error messages
if( !frame )
return;
Eeschema: fix Bug #1475905: Opening a legacy (.brd) file from a schematic fails. Now opening a board from eeschema works like from Kicamanager: if a .brd file exists and the .kicad_pcb file does not exists, the .brd file will be loaded.
2015-07-19 14:38:02 +00:00
frame->OpenProjectFiles( std::vector<wxString>( 1, boardfn.GetFullPath() ) );
add back missing pcbnew cross probing event handlers. eeschema launches kiface versions of pcbnew & cvpcb if not single.
2014-04-20 04:35:34 +00:00
}
Eeschema: fix a minor bug: the board editor was not launched from the toolbar, if the footprint viewer or the footprint editor was previously run from Eeschema.
2015-06-23 10:59:38 +00:00
Remove vestiages of old open-PCB-for-settings hack. We used to have to open a PCB_EDIT_FRAME to get the settings for the footprint editor and footprint viewer. This necessitated some special processing when opening a PCB_EDIT_FRAME to actually edit a board as it might already be open but unloaded. Since the new settings architecture allows the footprint editor and footprint viewer to init themselves we no longer need the special- case code.
2020-07-10 16:59:06 +00:00
if( !frame->IsVisible() )
frame->Show( true );
Eeschema: fix a minor bug: the board editor was not launched from the toolbar, if the footprint viewer or the footprint editor was previously run from Eeschema.
2015-06-23 10:59:38 +00:00
// On Windows, Raise() does not bring the window on screen, when iconized
if( frame->IsIconized() )
frame->Iconize( false );
frame->Raise();
add back missing pcbnew cross probing event handlers. eeschema launches kiface versions of pcbnew & cvpcb if not single.
2014-04-20 04:35:34 +00:00
}
Fix escape key handling in annotate dialog and some eeschema code refactoring.
2008-02-27 19:38:16 +00:00
}
else
Unify Eeschema orient commands and other minor fixes. * Create command event handler for orienting schematic items and block. * Remove redundant orient item and block command handler code and IDs. * Remove redundant cancel current command event table entry. * Remove unnecessary schematic bitmap object virtual functions. * Set path when saving schematic sheet files to prevent assertion in updated path and file write permission test function. * Restore directory and file name write permission test function to it's previous behavior to prevent unexpected save results. * Add an assertion to verify the path is not empty to directory and file write permission test function. * Improve documentation for path and file write permission test function. * Fix Doxygen link warnings.
2011-10-28 20:30:50 +00:00
{
Fix double call of OnPgmExit Also fix bad filename being passed to pcbnew when starting from a blank schematic in standalone mode Fixes https://gitlab.com/kicad/code/kicad/-/issues/5786
2020-10-04 22:39:21 +00:00
// If we are running inside a project, it should be impossible for this case to happen
wxASSERT( Kiface().IsSingle() );
Use more descriptive terminology for preferred text editor. Also improves execution to allow the preferred editor to include parameters, such as "/usr/bin/open -e". Fixes https://gitlab.com/kicad/code/kicad/issues/9131
2021-09-19 13:45:27 +00:00
ExecuteFile( PCBNEW_EXE );
Unify Eeschema orient commands and other minor fixes. * Create command event handler for orienting schematic items and block. * Remove redundant orient item and block command handler code and IDs. * Remove redundant cancel current command event table entry. * Remove unnecessary schematic bitmap object virtual functions. * Set path when saving schematic sheet files to prevent assertion in updated path and file write permission test function. * Restore directory and file name write permission test function to it's previous behavior to prevent unexpected save results. * Add an assertion to verify the path is not empty to directory and file write permission test function. * Improve documentation for path and file write permission test function. * Fix Doxygen link warnings.
2011-10-28 20:30:50 +00:00
}
Fix escape key handling in annotate dialog and some eeschema code refactoring.
2008-02-27 19:38:16 +00:00
}
eeschema: code cleaning, comments added, and the true number of sheets and sheets numbers in complex hierarchies
2009-01-04 18:52:57 +00:00
Minor fixes and lots of coding policy changes.
2010-12-08 20:12:46 +00:00
void SCH_EDIT_FRAME::OnOpenCvpcb( wxCommandEvent& event )
Fix escape key handling in annotate dialog and some eeschema code refactoring.
2008-02-27 19:38:16 +00:00
{
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
wxFileName fn = Prj().AbsolutePath( Schematic().GetFileName() );
Kick the wildcards and file exts into a static class, export it from kicommon
2023-12-28 02:10:01 +00:00
fn.SetExt( FILEEXT::NetlistFileExtension );
Fix escape key handling in annotate dialog and some eeschema code refactoring.
2008-02-27 19:38:16 +00:00
Implement more precise annotation-required messages. Also moves the message to an infobar so it's more noticeable. Fixes https://gitlab.com/kicad/code/kicad/issues/7332
2021-01-30 16:30:35 +00:00
if( !ReadyToNetlist( _( "Assigning footprints requires a fully annotated schematic." ) ) )
Fixed a crash when _cvpcb.kiface is not available when opening cvpcb
2017-11-27 16:11:12 +00:00
return;
try
Unify Eeschema orient commands and other minor fixes. * Create command event handler for orienting schematic items and block. * Remove redundant orient item and block command handler code and IDs. * Remove redundant cancel current command event table entry. * Remove unnecessary schematic bitmap object virtual functions. * Set path when saving schematic sheet files to prevent assertion in updated path and file write permission test function. * Restore directory and file name write permission test function to it's previous behavior to prevent unexpected save results. * Add an assertion to verify the path is not empty to directory and file write permission test function. * Improve documentation for path and file write permission test function. * Fix Doxygen link warnings.
2011-10-28 20:30:50 +00:00
{
Modular KiCad Blueprint Milestone B), major portions: *) When kicad.exe closes a project, close any open KIFACEs so that they cannot get disassociated from their true PROJECT. *) Allow loading eeschema library editor from kicad.exe *) Allow loading pcbnew library editor from kicad.exe *) Rename LIB_COMPONENT to LIB_PART. *) Add class PART_LIBS, and PART_LIB. *) Make PART_LIBS non-global, i.e. PROJECT specific. *) Implement "data on demand" for PART_LIBS *) Implement "data on demand" for schematic SEARCH_STACK. *) Use RSTRINGs to retain eeschema editor's notion of last library and part being edited. *) Get rid of library search on every SCH_COMPONENT::Draw() call, instead use a weak pointer. *) Remove all chdir() calls so projects don't need to be CWD. *) Romove APPEND support from OpenProjectFiles(). *) Make OpenProjectFiles() robust, even for creating new projects. *) Load EESCHEMA colors in the KIWAY::OnKiwayStart() rather in window open, and save them in the .eeschema config file, not in the project file. *) Fix bug with wxDir() while accessing protected dirs in kicad.exe *) Consolidate template copying into PROJECT class, not in kicad.exe source. *) Generally untangle eeschema, making its libraries not global but rather held in the PROJECT.
2014-08-13 20:28:54 +00:00
KIWAY_PLAYER* player = Kiway().Player( FRAME_CVPCB, false ); // test open already.
if( !player )
{
player = Kiway().Player( FRAME_CVPCB, true );
Avoid crashes when, for some reason, a dll cannot be loaded. In this case a null pointer was returned by the internal code. This pointer is now tested against nullptr to avoid the application crashing. Fixes #12080 https://gitlab.com/kicad/code/kicad/issues/12080
2022-07-24 17:42:50 +00:00
// player can be null if Cvpcb cannot be run. No need to show a warning
// Kiway() generates the error messages
if( !player )
return;
Modular KiCad Blueprint Milestone B), major portions: *) When kicad.exe closes a project, close any open KIFACEs so that they cannot get disassociated from their true PROJECT. *) Allow loading eeschema library editor from kicad.exe *) Allow loading pcbnew library editor from kicad.exe *) Rename LIB_COMPONENT to LIB_PART. *) Add class PART_LIBS, and PART_LIB. *) Make PART_LIBS non-global, i.e. PROJECT specific. *) Implement "data on demand" for PART_LIBS *) Implement "data on demand" for schematic SEARCH_STACK. *) Use RSTRINGs to retain eeschema editor's notion of last library and part being edited. *) Get rid of library search on every SCH_COMPONENT::Draw() call, instead use a weak pointer. *) Remove all chdir() calls so projects don't need to be CWD. *) Romove APPEND support from OpenProjectFiles(). *) Make OpenProjectFiles() robust, even for creating new projects. *) Load EESCHEMA colors in the KIWAY::OnKiwayStart() rather in window open, and save them in the .eeschema config file, not in the project file. *) Fix bug with wxDir() while accessing protected dirs in kicad.exe *) Consolidate template copying into PROJECT class, not in kicad.exe source. *) Generally untangle eeschema, making its libraries not global but rather held in the PROJECT.
2014-08-13 20:28:54 +00:00
player->Show( true );
}
3D viewer: fix a bug introduced in rev 5579s. Remove a few useless wxBusyCursor. Minor other fixes.
2015-04-08 12:50:36 +00:00
Eeschema, open CvPcb: ensure the netlist sent to CvPcb is up to date. Fixes #16762 https://gitlab.com/kicad/code/kicad/-/issues/16762
2024-01-26 08:24:38 +00:00
// Ensure the netlist (mainly info about symbols) is up to date
RecalculateConnections( nullptr, GLOBAL_CLEANUP );
Begin refactoring netlist creation
2019-03-17 19:15:08 +00:00
sendNetlistToCvpcb();
Use KiwayExpress messaging for CvPcb footprint assignment instead of *.cmp file. * Remove global s_NetObjectslist. * Separate out non-owning version of NETLIST_OBJECTS_LIST into NETLIST_OBJECTS. * Fix double free pertaining to ~NETLIST_READER(). * Remove all file-io from CvPCB. * Remove exe launcher cvpcb, retain only cvpcb.kiface, since cvpcb.kiface has no file i/o. * Add void CVPCB_MAINFRAME::KiwayMailIn( KIWAY_EXPRESS& mail ) and teach it to use old netlist loading code with a STRING_LINE_READER LINE_READER. * Fix BEGIN_EVENT_TABLE( CVPCB_MAINFRAME, KIWAY_PLAYER )
2015-06-07 18:18:45 +00:00
Eeschema: enable a few disabled stand alone mode options. * Enable CvPcb launching in stand alone mode. * Enable footprint editor launching in stand alone mode. * Remove some dead code left over from the change in CvPcb behavior. * These changes were made for users who prefer to work in a less project- centric work flow. KiCad should not be in the business of dictating work flow whenever possible.
2015-09-08 18:45:11 +00:00
player->Raise();
Unify Eeschema orient commands and other minor fixes. * Create command event handler for orienting schematic items and block. * Remove redundant orient item and block command handler code and IDs. * Remove redundant cancel current command event table entry. * Remove unnecessary schematic bitmap object virtual functions. * Set path when saving schematic sheet files to prevent assertion in updated path and file write permission test function. * Restore directory and file name write permission test function to it's previous behavior to prevent unexpected save results. * Add an assertion to verify the path is not empty to directory and file write permission test function. * Improve documentation for path and file write permission test function. * Fix Doxygen link warnings.
2011-10-28 20:30:50 +00:00
}
Fix warnings for unreferenced local variables
2018-04-18 07:10:29 +00:00
catch( const IO_ERROR& )
Fixed a crash when _cvpcb.kiface is not available when opening cvpcb
2017-11-27 16:11:12 +00:00
{
DisplayError( this, _( "Could not open CvPcb" ) );
}
Fix escape key handling in annotate dialog and some eeschema code refactoring.
2008-02-27 19:38:16 +00:00
}
Minor coding policy fixes.
2014-02-21 00:06:37 +00:00
Move quit back to wxIDs. wxWidgets like to muck around with the location on OSX.
2019-05-26 22:22:03 +00:00
void SCH_EDIT_FRAME::OnExit( wxCommandEvent& event )
{
Update exit strategy to match UI guidelines In singletop mode, all frames show the "Quit" option in the file menu and will quit on Ctrl-Q. When launched from the main KiCad interface, sub-programs show the "Close" option instead and will close with Ctrl-W. In this mode, Ctrl-Q will instruct the main program to exit. Fixes: lp:1779938 * https://bugs.launchpad.net/kicad/+bug/1779938
2019-06-25 04:44:34 +00:00
if( event.GetId() == wxID_EXIT )
Kiway().OnKiCadExit();
if( event.GetId() == wxID_CLOSE || Kiface().IsSingle() )
Close( false );
Move quit back to wxIDs. wxWidgets like to muck around with the location on OSX.
2019-05-26 22:22:03 +00:00
}
Make RENDER_SETTINGS argument const
2020-12-20 18:18:54 +00:00
void SCH_EDIT_FRAME::PrintPage( const RENDER_SETTINGS* aSettings )
fix 2 minor bugs: GERBVIEW: Button "Erase all layers" not working, EESCHEMA: Plot to Clipboard: EDA_DRAW_FRAME::PrintPage() error
2011-03-28 19:26:31 +00:00
{
Factor common parts of SCH_ & LIB_SYMBOL into SYMBOL.
2024-04-02 17:28:17 +00:00
wxString fileName = Prj().AbsolutePath( GetScreen()->GetFileName() );
const SCH_RENDER_SETTINGS* cfg = static_cast<const SCH_RENDER_SETTINGS*>( aSettings );
COLOR4D bg = GetColorSettings()->GetColor( LAYER_SCHEMATIC_BACKGROUND );
Modular KiCad Blueprint Milestone B), major portions: *) When kicad.exe closes a project, close any open KIFACEs so that they cannot get disassociated from their true PROJECT. *) Allow loading eeschema library editor from kicad.exe *) Allow loading pcbnew library editor from kicad.exe *) Rename LIB_COMPONENT to LIB_PART. *) Add class PART_LIBS, and PART_LIB. *) Make PART_LIBS non-global, i.e. PROJECT specific. *) Implement "data on demand" for PART_LIBS *) Implement "data on demand" for schematic SEARCH_STACK. *) Use RSTRINGs to retain eeschema editor's notion of last library and part being edited. *) Get rid of library search on every SCH_COMPONENT::Draw() call, instead use a weak pointer. *) Remove all chdir() calls so projects don't need to be CWD. *) Romove APPEND support from OpenProjectFiles(). *) Make OpenProjectFiles() robust, even for creating new projects. *) Load EESCHEMA colors in the KIWAY::OnKiwayStart() rather in window open, and save them in the .eeschema config file, not in the project file. *) Fix bug with wxDir() while accessing protected dirs in kicad.exe *) Consolidate template copying into PROJECT class, not in kicad.exe source. *) Generally untangle eeschema, making its libraries not global but rather held in the PROJECT.
2014-08-13 20:28:54 +00:00
Factor common parts of SCH_ & LIB_SYMBOL into SYMBOL.
2024-04-02 17:28:17 +00:00
cfg->GetPrintDC()->SetBackground( wxBrush( bg.ToColour() ) );
cfg->GetPrintDC()->Clear();
Fill gc with background color before copying to clipboard Fixes https://gitlab.com/kicad/code/kicad/issues/7995
2021-04-12 13:38:10 +00:00
Factor common parts of SCH_ & LIB_SYMBOL into SYMBOL.
2024-04-02 17:28:17 +00:00
cfg->GetPrintDC()->SetLogicalFunction( wxCOPY );
GetScreen()->Print( cfg );
PrintDrawingSheet( cfg, GetScreen(), Schematic().GetProperties(), schIUScale.IU_PER_MILS, fileName );
fix 2 minor bugs: GERBVIEW: Button "Erase all layers" not working, EESCHEMA: Plot to Clipboard: EDA_DRAW_FRAME::PrintPage() error
2011-03-28 19:26:31 +00:00
}
EESchema multiple item hit testing and other minor improvements. * Add item clarification context menu to EESchema when multiple unresolved items are found at the current cross hair position. * Add collector class SCH_COLLECTOR for supporting multiple item hit testing. * Removed bit wise masked filtering from schematic item hit testing. * Removed all old hit testing functions and methods scattered about the EESchema source code. * Move terminal point test function into SCH_SCREEN object. * Fixed bug in terminal point test when terminating a bus to a label. * Define the < operator for sorting schematic items. * Add area calculation method to EDA_Rect item. * Add method for returning an item's bitmap for menu display purposes. * Add method for returning an item's menu text for menu display purposes. * Changed EDA_ITEMS container from boost::ptr_vector to std::vector. * Factor coordinate string conversion code from EDA_DRAW_FRAME to function CoordinateToString().
2011-03-25 19:16:05 +00:00
Add hit testing clarification to schematic library editor. * Create library collector class. * Add clarification menu to library editor when multiple items are found at the current position. * Add get clarification menu text to all objects derived from LIB_ITEM. * Add get menu bitmap for all objects derived from LIB_ITEM. * Improve LIB_PIN bounding box calculation. * Rename LIB_ITEM::DoGenCopy to doClone to match behavior defined in base class EDA_ITEM. * Minor class renaming for improved code consistency. * Added less than operator to EDA_ITEM.
2011-04-27 19:44:32 +00:00
ADDED operating point text variables for labels and symbols. ADDED formatting for cursors and operationg points Also fixes a bunch of bugs to make the new cursors work with .ac sims. Fixes https://gitlab.com/kicad/code/kicad/issues/11253 Fixes https://gitlab.com/kicad/code/kicad/issues/6965
2023-02-05 20:47:27 +00:00
void SCH_EDIT_FRAME::RefreshOperatingPointDisplay()
{
ADDED operating point overlay for SCH_EDIT_FRAME. Fixes https://gitlab.com/kicad/code/kicad/issues/11253
2023-02-09 17:18:56 +00:00
SCHEMATIC_SETTINGS& settings = m_schematic->Settings();
SIM_LIB_MGR simLibMgr( &Prj() );
Fix nullptr crash in undo.
2023-05-07 20:52:31 +00:00
NULL_REPORTER devnull;
Don't display OP overlay when we have no data. Also fixes a copy-pasta bug with settings (and adds a fixup for those already bitten by it). Fixes https://gitlab.com/kicad/code/kicad/issues/13881
2023-02-13 18:07:58 +00:00
// Patch for bug early in V7.99 dev
if( settings.m_OPO_VRange.EndsWith( 'A' ) )
settings.m_OPO_VRange[ settings.m_OPO_VRange.Length() - 1 ] = 'V';
ADDED operating point overlay for SCH_EDIT_FRAME. Fixes https://gitlab.com/kicad/code/kicad/issues/11253
2023-02-09 17:18:56 +00:00
// Update items which may have ${OP} text variables
//
ADDED operating point text variables for labels and symbols. ADDED formatting for cursors and operationg points Also fixes a bunch of bugs to make the new cursors work with .ac sims. Fixes https://gitlab.com/kicad/code/kicad/issues/11253 Fixes https://gitlab.com/kicad/code/kicad/issues/6965
2023-02-05 20:47:27 +00:00
GetCanvas()->GetView()->UpdateAllItemsConditionally(
[&]( KIGFX::VIEW_ITEM* aItem ) -> int
{
int flags = 0;
ADDED: markers for excluded-from-sim items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15382
2024-06-03 12:59:40 +00:00
auto invalidateTextVars =
[&flags]( EDA_TEXT* text )
{
if( text->HasTextVars() )
{
text->ClearRenderCache();
text->ClearBoundingBoxCache();
flags |= KIGFX::GEOMETRY | KIGFX::REPAINT;
}
};
ADDED operating point text variables for labels and symbols. ADDED formatting for cursors and operationg points Also fixes a bunch of bugs to make the new cursors work with .ac sims. Fixes https://gitlab.com/kicad/code/kicad/issues/11253 Fixes https://gitlab.com/kicad/code/kicad/issues/6965
2023-02-05 20:47:27 +00:00
if( SCH_ITEM* item = dynamic_cast<SCH_ITEM*>( aItem ) )
{
item->RunOnChildren(
ADDED: markers for excluded-from-sim items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15382
2024-06-03 12:59:40 +00:00
[&invalidateTextVars]( SCH_ITEM* aChild )
ADDED operating point text variables for labels and symbols. ADDED formatting for cursors and operationg points Also fixes a bunch of bugs to make the new cursors work with .ac sims. Fixes https://gitlab.com/kicad/code/kicad/issues/11253 Fixes https://gitlab.com/kicad/code/kicad/issues/6965
2023-02-05 20:47:27 +00:00
{
ADDED: markers for excluded-from-sim items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15382
2024-06-03 12:59:40 +00:00
if( EDA_TEXT* text = dynamic_cast<EDA_TEXT*>( aChild ) )
invalidateTextVars( text );
ADDED operating point text variables for labels and symbols. ADDED formatting for cursors and operationg points Also fixes a bunch of bugs to make the new cursors work with .ac sims. Fixes https://gitlab.com/kicad/code/kicad/issues/11253 Fixes https://gitlab.com/kicad/code/kicad/issues/6965
2023-02-05 20:47:27 +00:00
} );
}
ADDED: markers for excluded-from-sim items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15382
2024-06-03 12:59:40 +00:00
if( EDA_TEXT* text = dynamic_cast<EDA_TEXT*>( aItem ) )
invalidateTextVars( text );
ADDED operating point text variables for labels and symbols. ADDED formatting for cursors and operationg points Also fixes a bunch of bugs to make the new cursors work with .ac sims. Fixes https://gitlab.com/kicad/code/kicad/issues/11253 Fixes https://gitlab.com/kicad/code/kicad/issues/6965
2023-02-05 20:47:27 +00:00
return flags;
} );
ADDED operating point overlay for SCH_EDIT_FRAME. Fixes https://gitlab.com/kicad/code/kicad/issues/11253
2023-02-09 17:18:56 +00:00
// Update OP overlay items
//
for( SCH_ITEM* item : GetScreen()->Items() )
{
ADDED: support for DNP & friends at the sheet level. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14387
2024-06-02 21:26:49 +00:00
if( GetCurrentSheet().GetExcludedFromSim() )
continue;
ADDED operating point overlay for SCH_EDIT_FRAME. Fixes https://gitlab.com/kicad/code/kicad/issues/11253
2023-02-09 17:18:56 +00:00
if( item->Type() == SCH_LINE_T )
{
Clear operating points on all sim types. (We'll fill them back in if we have data.) Also improves handling when a plot tab is closed. Also fixes dirtying of the view for op changes. Fixes https://gitlab.com/kicad/code/kicad/issues/13990
2023-02-22 13:52:52 +00:00
SCH_LINE* line = static_cast<SCH_LINE*>( item );
if( !line->GetOperatingPoint().IsEmpty() )
GetCanvas()->GetView()->Update( line );
line->SetOperatingPoint( wxEmptyString );
ADDED operating point overlay for SCH_EDIT_FRAME. Fixes https://gitlab.com/kicad/code/kicad/issues/11253
2023-02-09 17:18:56 +00:00
// update value from netlist, below
}
else if( item->Type() == SCH_SYMBOL_T )
{
SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( item );
wxString ref = symbol->GetRef( &GetCurrentSheet() );
std::vector<SCH_PIN*> pins = symbol->GetPins( &GetCurrentSheet() );
More uniform handling of power symbols and exclude-from-simulation.
2023-04-14 18:40:41 +00:00
// Power symbols and other symbols which have the reference starting with "#" are
// not included in simulation
Exclude from Sim: move from field to attribute
2023-08-08 16:32:08 +00:00
if( ref.StartsWith( '#' ) || symbol->GetExcludedFromSim() )
More uniform handling of power symbols and exclude-from-simulation.
2023-04-14 18:40:41 +00:00
continue;
ADDED operating point overlay for SCH_EDIT_FRAME. Fixes https://gitlab.com/kicad/code/kicad/issues/11253
2023-02-09 17:18:56 +00:00
for( SCH_PIN* pin : pins )
Clear operating points on all sim types. (We'll fill them back in if we have data.) Also improves handling when a plot tab is closed. Also fixes dirtying of the view for op changes. Fixes https://gitlab.com/kicad/code/kicad/issues/13990
2023-02-22 13:52:52 +00:00
{
if( !pin->GetOperatingPoint().IsEmpty() )
GetCanvas()->GetView()->Update( pin );
ADDED operating point overlay for SCH_EDIT_FRAME. Fixes https://gitlab.com/kicad/code/kicad/issues/11253
2023-02-09 17:18:56 +00:00
pin->SetOperatingPoint( wxEmptyString );
Clear operating points on all sim types. (We'll fill them back in if we have data.) Also improves handling when a plot tab is closed. Also fixes dirtying of the view for op changes. Fixes https://gitlab.com/kicad/code/kicad/issues/13990
2023-02-22 13:52:52 +00:00
}
ADDED operating point overlay for SCH_EDIT_FRAME. Fixes https://gitlab.com/kicad/code/kicad/issues/11253
2023-02-09 17:18:56 +00:00
if( pins.size() == 2 )
{
wxString op = m_schematic->GetOperatingPoint( ref, settings.m_OPO_IPrecision,
settings.m_OPO_IRange );
Don't display OP overlay when we have no data. Also fixes a copy-pasta bug with settings (and adds a fixup for those already bitten by it). Fixes https://gitlab.com/kicad/code/kicad/issues/13881
2023-02-13 18:07:58 +00:00
if( !op.IsEmpty() && op != wxS( "--" ) && op != wxS( "?" ) )
Clear operating points on all sim types. (We'll fill them back in if we have data.) Also improves handling when a plot tab is closed. Also fixes dirtying of the view for op changes. Fixes https://gitlab.com/kicad/code/kicad/issues/13990
2023-02-22 13:52:52 +00:00
{
ADDED operating point overlay for SCH_EDIT_FRAME. Fixes https://gitlab.com/kicad/code/kicad/issues/11253
2023-02-09 17:18:56 +00:00
pins[0]->SetOperatingPoint( op );
Clear operating points on all sim types. (We'll fill them back in if we have data.) Also improves handling when a plot tab is closed. Also fixes dirtying of the view for op changes. Fixes https://gitlab.com/kicad/code/kicad/issues/13990
2023-02-22 13:52:52 +00:00
GetCanvas()->GetView()->Update( symbol );
}
ADDED operating point overlay for SCH_EDIT_FRAME. Fixes https://gitlab.com/kicad/code/kicad/issues/11253
2023-02-09 17:18:56 +00:00
}
else
{
Coding policy and Doxygen comment fixes.
2023-10-12 13:36:28 +00:00
SIM_MODEL& model = simLibMgr.CreateModel( &GetCurrentSheet(), *symbol,
devnull ).model;
Handle SPICE prefixes for operating point data. Also adjusts the min-pin lenght as some symbols have very short pins.
2023-02-13 18:38:43 +00:00
SPICE_ITEM spiceItem;
spiceItem.refName = ref;
ref = model.SpiceGenerator().ItemName( spiceItem );
ADDED operating point overlay for SCH_EDIT_FRAME. Fixes https://gitlab.com/kicad/code/kicad/issues/11253
2023-02-09 17:18:56 +00:00
for( const auto& modelPin : model.GetPins() )
{
SCH_PIN* symbolPin = symbol->GetPin( modelPin.get().symbolPinNumber );
Raw spice models don't have pin names.
2024-05-10 19:53:30 +00:00
wxString signalName = ref + wxS( ":" ) + modelPin.get().modelPinName;
ADDED operating point overlay for SCH_EDIT_FRAME. Fixes https://gitlab.com/kicad/code/kicad/issues/11253
2023-02-09 17:18:56 +00:00
wxString op = m_schematic->GetOperatingPoint( signalName,
settings.m_OPO_IPrecision,
settings.m_OPO_IRange );
Don't display OP overlay when we have no data. Also fixes a copy-pasta bug with settings (and adds a fixup for those already bitten by it). Fixes https://gitlab.com/kicad/code/kicad/issues/13881
2023-02-13 18:07:58 +00:00
if( symbolPin && !op.IsEmpty() && op != wxS( "--" ) && op != wxS( "?" ) )
ADDED operating point overlay for SCH_EDIT_FRAME. Fixes https://gitlab.com/kicad/code/kicad/issues/11253
2023-02-09 17:18:56 +00:00
{
symbolPin->SetOperatingPoint( op );
GetCanvas()->GetView()->Update( symbol );
}
}
}
}
}
for( const auto& [ key, subgraphList ] : m_schematic->m_connectionGraph->GetNetMap() )
{
wxString op = m_schematic->GetOperatingPoint( key.Name, settings.m_OPO_VPrecision,
settings.m_OPO_VRange );
Don't display OP overlay when we have no data. Also fixes a copy-pasta bug with settings (and adds a fixup for those already bitten by it). Fixes https://gitlab.com/kicad/code/kicad/issues/13881
2023-02-13 18:07:58 +00:00
if( !op.IsEmpty() && op != wxS( "--" ) && op != wxS( "?" ) )
ADDED operating point overlay for SCH_EDIT_FRAME. Fixes https://gitlab.com/kicad/code/kicad/issues/11253
2023-02-09 17:18:56 +00:00
{
for( CONNECTION_SUBGRAPH* subgraph : subgraphList )
{
SCH_LINE* longestWire = nullptr;
double length = 0.0;
ADDED: support for DNP & friends at the sheet level. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14387
2024-06-02 21:26:49 +00:00
if( subgraph->GetSheet().GetExcludedFromSim() )
continue;
Clean exposure of CONNECTION_SUBGRAPH Removes internals from public consumption.
2023-03-03 22:06:41 +00:00
for( SCH_ITEM* item : subgraph->GetItems() )
ADDED operating point overlay for SCH_EDIT_FRAME. Fixes https://gitlab.com/kicad/code/kicad/issues/11253
2023-02-09 17:18:56 +00:00
{
if( item->IsType( { SCH_ITEM_LOCATE_WIRE_T } ) )
{
SCH_LINE* wire = static_cast<SCH_LINE*>( item );
if( wire->GetLength() > length )
{
longestWire = wire;
length = wire->GetLength();
}
}
}
if( longestWire )
{
longestWire->SetOperatingPoint( op );
GetCanvas()->GetView()->Update( longestWire );
}
}
}
}
ADDED operating point text variables for labels and symbols. ADDED formatting for cursors and operationg points Also fixes a bunch of bugs to make the new cursors work with .ac sims. Fixes https://gitlab.com/kicad/code/kicad/issues/11253 Fixes https://gitlab.com/kicad/code/kicad/issues/6965
2023-02-05 20:47:27 +00:00
}
Schematic: Add swap action
2022-08-30 13:01:48 +00:00
void SCH_EDIT_FRAME::AutoRotateItem( SCH_SCREEN* aScreen, SCH_ITEM* aItem )
{
if( aItem->IsType( { SCH_GLOBAL_LABEL_T, SCH_HIER_LABEL_T } ) )
{
Don't destroy ERC dialog twice. (And some other cleanup.)
2023-07-15 21:39:07 +00:00
SCH_LABEL_BASE* label = static_cast<SCH_LABEL_BASE*>( aItem );
Schematic: Add swap action
2022-08-30 13:01:48 +00:00
if( label->AutoRotateOnPlacement() )
{
Push TEXT_SPIN_STYLE from SCH_TEXT out to SCH_LABEL_BASE. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15444
2023-09-07 16:09:53 +00:00
SPIN_STYLE spin = aScreen->GetLabelOrientationForPoint( label->GetPosition(),
label->GetSpinStyle(),
&GetCurrentSheet() );
Don't destroy ERC dialog twice. (And some other cleanup.)
2023-07-15 21:39:07 +00:00
Push TEXT_SPIN_STYLE from SCH_TEXT out to SCH_LABEL_BASE. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15444
2023-09-07 16:09:53 +00:00
if( spin != label->GetSpinStyle() )
Schematic: Add swap action
2022-08-30 13:01:48 +00:00
{
Push TEXT_SPIN_STYLE from SCH_TEXT out to SCH_LABEL_BASE. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15444
2023-09-07 16:09:53 +00:00
label->SetSpinStyle( spin );
Don't destroy ERC dialog twice. (And some other cleanup.)
2023-07-15 21:39:07 +00:00
Schematic: Add swap action
2022-08-30 13:01:48 +00:00
for( SCH_ITEM* item : aScreen->Items().OfType( SCH_GLOBAL_LABEL_T ) )
{
SCH_LABEL_BASE* otherLabel = static_cast<SCH_LABEL_BASE*>( item );
Don't destroy ERC dialog twice. (And some other cleanup.)
2023-07-15 21:39:07 +00:00
Schematic: Add swap action
2022-08-30 13:01:48 +00:00
if( otherLabel != label && otherLabel->GetText() == label->GetText() )
otherLabel->AutoplaceFields( aScreen, false );
}
}
}
}
}
Fix naming of `updateTitle()` This is a private function so should be lowercased to avoid confusion
2023-01-12 00:05:43 +00:00
void SCH_EDIT_FRAME::updateTitle()
Eeschema: Fix erroneous message [Read Only] after creating a new project, and obviously the corresponding schematic file does not yet exist (replaced by [no file])
2012-01-14 11:52:46 +00:00
{
Eeschema: don't stat files when updating title bar text. The tests for file existence and write status perform two file stats which cause performance issues on slow network shares. Now the file state is determined at load time and stored in the SCH_SCREEN object so file access is no longer required. Fixes https://gitlab.com/kicad/code/kicad/-/issues/9343
2021-10-14 13:12:40 +00:00
SCH_SCREEN* screen = GetScreen();
wxCHECK( screen, /* void */ );
Eeschema: Fix erroneous message [Read Only] after creating a new project, and obviously the corresponding schematic file does not yet exist (replaced by [no file])
2012-01-14 11:52:46 +00:00
wxString title;
Eeschema: don't stat files when updating title bar text. The tests for file existence and write status perform two file stats which cause performance issues on slow network shares. Now the file state is determined at load time and stored in the SCH_SCREEN object so file access is no longer required. Fixes https://gitlab.com/kicad/code/kicad/-/issues/9343
2021-10-14 13:12:40 +00:00
if( !screen->GetFileName().IsEmpty() )
Eeschema: Fix erroneous message [Read Only] after creating a new project, and obviously the corresponding schematic file does not yet exist (replaced by [no file])
2012-01-14 11:52:46 +00:00
{
Eeschema: don't stat files when updating title bar text. The tests for file existence and write status perform two file stats which cause performance issues on slow network shares. Now the file state is determined at load time and stored in the SCH_SCREEN object so file access is no longer required. Fixes https://gitlab.com/kicad/code/kicad/-/issues/9343
2021-10-14 13:12:40 +00:00
wxFileName fn( Prj().AbsolutePath( screen->GetFileName() ) );
Always enable save; move dirty bit to asterisk in title bar. Also unifies PCB Editor and Schematic Editor names with other locations in the GUI (which were still Pcbnew and Eeschema). Fixes https://gitlab.com/kicad/code/kicad/issues/7587 Fixes https://gitlab.com/kicad/code/kicad/issues/7594
2021-02-18 15:49:35 +00:00
bool readOnly = false;
bool unsaved = false;
Eeschema: Fix erroneous message [Read Only] after creating a new project, and obviously the corresponding schematic file does not yet exist (replaced by [no file])
2012-01-14 11:52:46 +00:00
Eeschema: don't stat files when updating title bar text. The tests for file existence and write status perform two file stats which cause performance issues on slow network shares. Now the file state is determined at load time and stored in the SCH_SCREEN object so file access is no longer required. Fixes https://gitlab.com/kicad/code/kicad/-/issues/9343
2021-10-14 13:12:40 +00:00
if( fn.IsOk() && screen->FileExists() )
readOnly = screen->IsReadOnly();
Eeschema: Fix erroneous message [Read Only] after creating a new project, and obviously the corresponding schematic file does not yet exist (replaced by [no file])
2012-01-14 11:52:46 +00:00
else
Always enable save; move dirty bit to asterisk in title bar. Also unifies PCB Editor and Schematic Editor names with other locations in the GUI (which were still Pcbnew and Eeschema). Fixes https://gitlab.com/kicad/code/kicad/issues/7587 Fixes https://gitlab.com/kicad/code/kicad/issues/7594
2021-02-18 15:49:35 +00:00
unsaved = true;
Application title bar: app name after filename Fixes https://gitlab.com/kicad/code/kicad/issues/2096
2020-04-13 20:02:35 +00:00
Workaround a few more OSX printf problems. Also regularizes the frame title processing. Also fixes a type where the library name wasn't processed for variable expansion. Fixes https://gitlab.com/kicad/code/kicad/issues/7742
2021-06-20 21:46:41 +00:00
if( IsContentModified() )
title = wxT( "*" );
title += fn.GetName();
Slight improvement to schematic editor title bar. Also improves some other clients of PathHumanReadable(), such as the set page number dialog.
2022-12-12 11:00:18 +00:00
wxString sheetPath = GetCurrentSheet().PathHumanReadable( false, true );
if( sheetPath != title )
title += wxString::Format( wxT( " [%s]" ), sheetPath );
Workaround a few more OSX printf problems. Also regularizes the frame title processing. Also fixes a type where the library name wasn't processed for variable expansion. Fixes https://gitlab.com/kicad/code/kicad/issues/7742
2021-06-20 21:46:41 +00:00
if( readOnly )
title += wxS( " " ) + _( "[Read Only]" );
if( unsaved )
title += wxS( " " ) + _( "[Unsaved]" );
Eeschema: Fix erroneous message [Read Only] after creating a new project, and obviously the corresponding schematic file does not yet exist (replaced by [no file])
2012-01-14 11:52:46 +00:00
}
Workaround a few more OSX printf problems. Also regularizes the frame title processing. Also fixes a type where the library name wasn't processed for variable expansion. Fixes https://gitlab.com/kicad/code/kicad/issues/7742
2021-06-20 21:46:41 +00:00
else
{
title = _( "[no schematic loaded]" );
}
title += wxT( " \u2014 " ) + _( "Schematic Editor" );
Fix capitalization issues in title bar and config files (broken by bzr rev 3543)
2012-05-10 06:25:27 +00:00
SetTitle( title );
Eeschema: Fix erroneous message [Read Only] after creating a new project, and obviously the corresponding schematic file does not yet exist (replaced by [no file])
2012-01-14 11:52:46 +00:00
}
Add environment variable configuration dialog to Eeschema. Fixes lp:1739910 https://bugs.launchpad.net/kicad/+bug/1739910
2017-12-24 17:57:57 +00:00
Mark null project initial screen as zoom-initialized The variable `m_Initialized` in `BASE_SCREEN` is used by `SCH_EDIT_FRAME` to mark whether a screen had its zoom level initialized by the "zoom to fit screen" action. When this variable is `false`, the function `SCH_EDIT_FRAME::DisplayCurrentSheet()` performs "zoom to fit screen", modifying the zoom level. This function is indirectly called in the undo routines, so if `m_Initialized` is not set to `true`, a zoom change will occur when the user undoes an operation, a behavior that is undesired. `m_Initialized` was not initialized to `true` for the null schematic (the schematic that is loaded if no project is loaded), causing the aforementioned undesired behavior. To prevent this, I've changed the `SCH_EDIT_FRAME` constructor to set `m_Initialized` to `true`, since it zooms to fit screen already. I've moved `m_Initialized` from `BASE_SCREEN` to `SCH_SCREEN`, as it is used only in Eeschema, and renamed it to `m_zoomInitialized`, a name I believe that better describes what this variable does. I've also introduced the function `SCH_EDIT_FRAME::initScreenZoom()` to group the "zoom to fit screen" action with setting `m_Initialized` to `true`, as they often should occur together. I'd also like to say that I'm not confident whether `SCH_EDIT_FRAME::DisplayCurrentSheet()` should perform the zoom level initialization at this point, but I have decided to not change this behavior for now, as the commit history suggests it's several years old. Fixes https://gitlab.com/kicad/code/kicad/issues/7343
2021-01-30 22:47:39 +00:00
void SCH_EDIT_FRAME::initScreenZoom()
{
Separate immediate and delayed action dispatch Using a boolean argument just leads to a lot of trailing booleans in the function calls and is not user friendly. Instead, introduce PostAction() to send an action that runs after the coroutine (equivalent to passing false or the default argument), and leave RunAction as the immediate execution function.
2023-06-26 22:16:51 +00:00
m_toolManager->RunAction( ACTIONS::zoomFitScreen );
Mark null project initial screen as zoom-initialized The variable `m_Initialized` in `BASE_SCREEN` is used by `SCH_EDIT_FRAME` to mark whether a screen had its zoom level initialized by the "zoom to fit screen" action. When this variable is `false`, the function `SCH_EDIT_FRAME::DisplayCurrentSheet()` performs "zoom to fit screen", modifying the zoom level. This function is indirectly called in the undo routines, so if `m_Initialized` is not set to `true`, a zoom change will occur when the user undoes an operation, a behavior that is undesired. `m_Initialized` was not initialized to `true` for the null schematic (the schematic that is loaded if no project is loaded), causing the aforementioned undesired behavior. To prevent this, I've changed the `SCH_EDIT_FRAME` constructor to set `m_Initialized` to `true`, since it zooms to fit screen already. I've moved `m_Initialized` from `BASE_SCREEN` to `SCH_SCREEN`, as it is used only in Eeschema, and renamed it to `m_zoomInitialized`, a name I believe that better describes what this variable does. I've also introduced the function `SCH_EDIT_FRAME::initScreenZoom()` to group the "zoom to fit screen" action with setting `m_Initialized` to `true`, as they often should occur together. I'd also like to say that I'm not confident whether `SCH_EDIT_FRAME::DisplayCurrentSheet()` should perform the zoom level initialization at this point, but I have decided to not change this behavior for now, as the commit history suggests it's several years old. Fixes https://gitlab.com/kicad/code/kicad/issues/7343
2021-01-30 22:47:39 +00:00
GetScreen()->m_zoomInitialized = true;
}
Upgrade some symbol editor stuff to SCHEMATIC_COMMIT. Also renames SCHEMATIC_COMMIT to SCH_COMMIT since it's not schematic-specifc.
2023-06-09 21:41:33 +00:00
void SCH_EDIT_FRAME::RecalculateConnections( SCH_COMMIT* aCommit, SCH_CLEANUP_FLAGS aCleanupFlags )
New connectivity algorithm and bus upgrades Bus upgrades: core new connectivity code Bus upgrades: eeschema integration and modifications Bus upgrades: eeschema dialogs Bus upgrades: netlist export Bus upgrades: file format changes
2019-03-11 21:32:05 +00:00
{
Fix potential stale pointer bug in schematic highlight connection code. SCH_CONNECTION objects are temporary and can become stale any time the connectivity is updated. Keeping them around to reference later is a bad idea. Even if the object pointer is still valid in an SCH_ITEM in the undo/redo buffers, comparing the pointer against another pointer as a test to see if they are the same connection is not valid. Saving the connection name is safe and ensures the connection is the same even if the pointers differ.
2023-05-17 00:06:21 +00:00
wxString highlightedConn = GetHighlightedConnection();
net navigator: show all nets when none are highlighted
2024-04-03 18:44:40 +00:00
bool hasHighlightedConn = !highlightedConn.IsEmpty();
ADDED: eeschema: Add intersheets references function Add a new function to place intersheets references next to global labels.
2020-08-31 14:11:54 +00:00
SCHEMATIC_SETTINGS& settings = Schematic().Settings();
Disable two prof_counters if not ifdefed
2021-05-01 14:08:21 +00:00
SCH_SHEET_LIST list = Schematic().GetSheets();
Upgrade some symbol editor stuff to SCHEMATIC_COMMIT. Also renames SCHEMATIC_COMMIT to SCH_COMMIT since it's not schematic-specifc.
2023-06-09 21:41:33 +00:00
SCH_COMMIT localCommit( m_toolManager );
Upgrade many editing actions to SCHEMATIC_COMMIT.
2023-06-09 16:24:49 +00:00
if( !aCommit )
Upgrade some symbol editor stuff to SCHEMATIC_COMMIT. Also renames SCHEMATIC_COMMIT to SCH_COMMIT since it's not schematic-specifc.
2023-06-09 21:41:33 +00:00
aCommit = &localCommit;
Fix potential stale pointer bug in schematic highlight connection code. SCH_CONNECTION objects are temporary and can become stale any time the connectivity is updated. Keeping them around to reference later is a bad idea. Even if the object pointer is still valid in an SCH_ITEM in the undo/redo buffers, comparing the pointer against another pointer as a test to see if they are the same connection is not valid. Saving the connection name is safe and ensures the connection is the same even if the pointers differ.
2023-05-17 00:06:21 +00:00
Disable two prof_counters if not ifdefed
2021-05-01 14:08:21 +00:00
#ifdef PROFILE
Replace PROF_COUNTER with PROF_TIMER in some conditional places.
2022-09-17 18:43:46 +00:00
PROF_TIMER timer;
Disable two prof_counters if not ifdefed
2021-05-01 14:08:21 +00:00
#endif
Add profiling to SchematicCleanUp portion of connectivity calculations
2019-04-11 03:29:17 +00:00
New connectivity algorithm and bus upgrades Bus upgrades: core new connectivity code Bus upgrades: eeschema integration and modifications Bus upgrades: eeschema dialogs Bus upgrades: netlist export Bus upgrades: file format changes
2019-03-11 21:32:05 +00:00
// Ensure schematic graph is accurate
Be more explicit about extent of schematic cleanups. The new connectivity algorithm had a tendency to cleanup globally, but that could insert undo records from other sheets into the current screen's undo stack. Needless to say, this was a recipie for segfaults. Fixes: lp:1846247 * https://bugs.launchpad.net/kicad/+bug/1846247
2019-11-10 23:24:27 +00:00
if( aCleanupFlags == LOCAL_CLEANUP )
{
Upgrade many editing actions to SCHEMATIC_COMMIT.
2023-06-09 16:24:49 +00:00
SchematicCleanUp( aCommit, GetScreen() );
Be more explicit about extent of schematic cleanups. The new connectivity algorithm had a tendency to cleanup globally, but that could insert undo records from other sheets into the current screen's undo stack. Needless to say, this was a recipie for segfaults. Fixes: lp:1846247 * https://bugs.launchpad.net/kicad/+bug/1846247
2019-11-10 23:24:27 +00:00
}
else if( aCleanupFlags == GLOBAL_CLEANUP )
eeschema: Avoid modifying the schematic in undo OnModify() is called when staging the undo/redo modifications. This requires that it not create changes that themselves need to be placed in the undo/redo stack
2019-04-13 02:46:12 +00:00
{
Perform a slightly more aggressive cleanup. Also removes the functionality that selects the newly-added item as we don't do that with any of the other drawing tools. Fixes https://gitlab.com/kicad/code/kicad/issues/7833
2021-03-09 21:24:03 +00:00
for( const SCH_SHEET_PATH& sheet : list )
Upgrade many editing actions to SCHEMATIC_COMMIT.
2023-06-09 16:24:49 +00:00
SchematicCleanUp( aCommit, sheet.LastScreen() );
eeschema: Avoid modifying the schematic in undo OnModify() is called when staging the undo/redo modifications. This requires that it not create changes that themselves need to be placed in the undo/redo stack
2019-04-13 02:46:12 +00:00
}
New connectivity algorithm and bus upgrades Bus upgrades: core new connectivity code Bus upgrades: eeschema integration and modifications Bus upgrades: eeschema dialogs Bus upgrades: netlist export Bus upgrades: file format changes
2019-03-11 21:32:05 +00:00
Disable two prof_counters if not ifdefed
2021-05-01 14:08:21 +00:00
#ifdef PROFILE
Add profiling to SchematicCleanUp portion of connectivity calculations
2019-04-11 03:29:17 +00:00
timer.Stop();
wxLogTrace( "CONN_PROFILE", "SchematicCleanUp() %0.4f ms", timer.msecs() );
Disable two prof_counters if not ifdefed
2021-05-01 14:08:21 +00:00
#endif
Add profiling to SchematicCleanUp portion of connectivity calculations
2019-04-11 03:29:17 +00:00
Fix a crash bug trying to update the view before it was ready.
2020-12-20 17:48:15 +00:00
if( settings.m_IntersheetRefsShow )
Fix a couple of bugs in intersheet references. 1) init reference pages before trying to draw the SCH_FIELDs when turning intersheet references on 2) don't double redraw because we accidentally cleared the last hover item on a non-mouse-moved event. 3) make sure the root sheet gets a name for the hypertext menu.
2020-11-29 16:31:43 +00:00
RecomputeIntersheetRefs();
ADDED: eeschema: Add intersheets references function Add a new function to place intersheets references next to global labels.
2020-08-31 14:11:54 +00:00
Remove duplicated TestDanglingEnds routines. Also adds a changedItemHandler so that the single remaining version can update the view. Fixes https://gitlab.com/kicad/code/kicad/issues/6581
2020-12-06 21:23:16 +00:00
std::function<void( SCH_ITEM* )> changeHandler =
[&]( SCH_ITEM* aChangedItem ) -> void
{
GetCanvas()->GetView()->Update( aChangedItem, KIGFX::REPAINT );
Fix potential stale pointer bug in schematic highlight connection code. SCH_CONNECTION objects are temporary and can become stale any time the connectivity is updated. Keeping them around to reference later is a bad idea. Even if the object pointer is still valid in an SCH_ITEM in the undo/redo buffers, comparing the pointer against another pointer as a test to see if they are the same connection is not valid. Saving the connection name is safe and ensures the connection is the same even if the pointers differ.
2023-05-17 00:06:21 +00:00
SCH_CONNECTION* connection = aChangedItem->Connection();
net navigator: show all nets when none are highlighted
2024-04-03 18:44:40 +00:00
if( m_highlightedConnChanged )
return;
Minor net navigator improvements. Ignore bus member connection subgraphs. They do not have a valid net name nor do they contain schematic items. This prevents empty nodes from being added to the tree. They can be reintroduced in the future if someone wants to pursue it. Freeze the wxTreeCtrl while populating it and thaw when done to prevent any unnecessary repainting. Add profiling to test how long it takes to rebuild the net navigator. The recently added populate the navigator with all nets when no net is highlighted has exposed some potential performances issues with some versions of wxWidgets on certain platforms. Namely wxWidgets 3.2.4 on Linux GTK. Fix an issue where a sheet name change would not update the highlighted net navigator resulting in a stale human readable sheet path. Prevent the highlighted net navigator from being rebuilt twice when loading a schematic. SCH_EDIT_FRAME::RefreshNetNavigator() was being called from both SCH_EDIT_FRAME::UpdateHierarchyNavigator() and SCH_EDIT_FRAME::RecalculateConnectivity(). Add a new trace helper "KICAD_UI_PROFILE" to show trace output when profiling user interface performance. It's used in the net navigator profiling mentioned above. Reuse PROF_TIMER::Show() to generate string for PROF_TIMER::to_string().
2024-04-17 18:31:50 +00:00
if( !hasHighlightedConn )
{
// No highlighted connection, but connectivity has changed, so refresh
// the list of all nets
net navigator: show all nets when none are highlighted
2024-04-03 18:44:40 +00:00
m_highlightedConnChanged = true;
Minor net navigator improvements. Ignore bus member connection subgraphs. They do not have a valid net name nor do they contain schematic items. This prevents empty nodes from being added to the tree. They can be reintroduced in the future if someone wants to pursue it. Freeze the wxTreeCtrl while populating it and thaw when done to prevent any unnecessary repainting. Add profiling to test how long it takes to rebuild the net navigator. The recently added populate the navigator with all nets when no net is highlighted has exposed some potential performances issues with some versions of wxWidgets on certain platforms. Namely wxWidgets 3.2.4 on Linux GTK. Fix an issue where a sheet name change would not update the highlighted net navigator resulting in a stale human readable sheet path. Prevent the highlighted net navigator from being rebuilt twice when loading a schematic. SCH_EDIT_FRAME::RefreshNetNavigator() was being called from both SCH_EDIT_FRAME::UpdateHierarchyNavigator() and SCH_EDIT_FRAME::RecalculateConnectivity(). Add a new trace helper "KICAD_UI_PROFILE" to show trace output when profiling user interface performance. It's used in the net navigator profiling mentioned above. Reuse PROF_TIMER::Show() to generate string for PROF_TIMER::to_string().
2024-04-17 18:31:50 +00:00
}
net navigator: show all nets when none are highlighted
2024-04-03 18:44:40 +00:00
else if( connection
&& ( connection->Name() == highlightedConn
|| connection->HasDriverChanged() ) )
{
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
m_highlightedConnChanged = true;
net navigator: show all nets when none are highlighted
2024-04-03 18:44:40 +00:00
}
Remove duplicated TestDanglingEnds routines. Also adds a changedItemHandler so that the single remaining version can update the view. Fixes https://gitlab.com/kicad/code/kicad/issues/6581
2020-12-06 21:23:16 +00:00
};
Add ability to update subgraphs based on changeset Previously, almost all connectivity updates were full updates, meaning that the entire connectivity graph would be rebuilt each time a change was made to the schematic. This update modifies the update to only correct the subgraphs that are directly affected by the change. It uses the existing connection graph to find all affected subgraphs as well as connections to the changes based on the visible schematic. These elements are removed from the existing connectivity graph and marked dirty. They then have a new connectivity graph built only around their changes. The resulting graph is merged into the original. Currently, this ability is behind an advanced config flag `IncrementalConnectivity` while testing. Fixes https://gitlab.com/kicad/code/kicad/issues/10846 Fixes https://gitlab.com/kicad/code/kicad/issues/1794
2023-04-08 15:22:34 +00:00
if( !ADVANCED_CFG::GetCfg().m_IncrementalConnectivity || aCleanupFlags == GLOBAL_CLEANUP
Turn off incremental connectivity for small schematics The benefit of incremental connectivity is only for larger schematics. For smaller schematics, the downside of larger bug surface outweighs the current benefits
2024-06-03 18:33:29 +00:00
|| m_undoList.m_CommandsList.empty()|| Schematic().ConnectionGraph()->IsMinor() )
Add ability to update subgraphs based on changeset Previously, almost all connectivity updates were full updates, meaning that the entire connectivity graph would be rebuilt each time a change was made to the schematic. This update modifies the update to only correct the subgraphs that are directly affected by the change. It uses the existing connection graph to find all affected subgraphs as well as connections to the changes based on the visible schematic. These elements are removed from the existing connectivity graph and marked dirty. They then have a new connectivity graph built only around their changes. The resulting graph is merged into the original. Currently, this ability is behind an advanced config flag `IncrementalConnectivity` while testing. Fixes https://gitlab.com/kicad/code/kicad/issues/10846 Fixes https://gitlab.com/kicad/code/kicad/issues/1794
2023-04-08 15:22:34 +00:00
{
Add SCH_RULE_AREA shapes to eeschema Includes: - Fix GAL to draw closed polygons in eeschema - Add functionality to eeschema to draw arbitary polygons - Update polygon item previews to have customisable edge colour - Add new SCH_RULE_AREA class, derived from a poly SCH_SHAPE - Add SCH_RULE_AREA to paint and plot methods - Add new rule area color preference to themes
2024-04-25 14:24:46 +00:00
// Update all rule areas so we can cascade implied connectivity changes
std::unordered_set<SCH_SCREEN*> all_screens;
for( const SCH_SHEET_PATH& path : list )
all_screens.insert( path.LastScreen() );
SCH_RULE_AREA::UpdateRuleAreasInScreens( all_screens, GetCanvas()->GetView() );
// Recalculate all connectivity
Add ability to update subgraphs based on changeset Previously, almost all connectivity updates were full updates, meaning that the entire connectivity graph would be rebuilt each time a change was made to the schematic. This update modifies the update to only correct the subgraphs that are directly affected by the change. It uses the existing connection graph to find all affected subgraphs as well as connections to the changes based on the visible schematic. These elements are removed from the existing connectivity graph and marked dirty. They then have a new connectivity graph built only around their changes. The resulting graph is merged into the original. Currently, this ability is behind an advanced config flag `IncrementalConnectivity` while testing. Fixes https://gitlab.com/kicad/code/kicad/issues/10846 Fixes https://gitlab.com/kicad/code/kicad/issues/1794
2023-04-08 15:22:34 +00:00
Schematic().ConnectionGraph()->Recalculate( list, true, &changeHandler );
}
else
{
Add SCH_RULE_AREA shapes to eeschema Includes: - Fix GAL to draw closed polygons in eeschema - Add functionality to eeschema to draw arbitary polygons - Update polygon item previews to have customisable edge colour - Add new SCH_RULE_AREA class, derived from a poly SCH_SHAPE - Add SCH_RULE_AREA to paint and plot methods - Add new rule area color preference to themes
2024-04-25 14:24:46 +00:00
struct CHANGED_ITEM
{
SCH_ITEM* item;
SCH_ITEM* linked_item;
SCH_SCREEN* screen;
};
Properly handle incremental bus connections - Incremental extraction needs the newly created items. The modified items are already set in the connection graph but the newly created items don't exist yet, so we need to add those explicitly - Bus parents need to ensure that the bus children exist because we iterate on the updates from the top of the graph down
2023-09-16 19:42:48 +00:00
PICKED_ITEMS_LIST* changed_list = m_undoList.m_CommandsList.back();
Add ability to update subgraphs based on changeset Previously, almost all connectivity updates were full updates, meaning that the entire connectivity graph would be rebuilt each time a change was made to the schematic. This update modifies the update to only correct the subgraphs that are directly affected by the change. It uses the existing connection graph to find all affected subgraphs as well as connections to the changes based on the visible schematic. These elements are removed from the existing connectivity graph and marked dirty. They then have a new connectivity graph built only around their changes. The resulting graph is merged into the original. Currently, this ability is behind an advanced config flag `IncrementalConnectivity` while testing. Fixes https://gitlab.com/kicad/code/kicad/issues/10846 Fixes https://gitlab.com/kicad/code/kicad/issues/1794
2023-04-08 15:22:34 +00:00
Add SCH_RULE_AREA shapes to eeschema Includes: - Fix GAL to draw closed polygons in eeschema - Add functionality to eeschema to draw arbitary polygons - Update polygon item previews to have customisable edge colour - Add new SCH_RULE_AREA class, derived from a poly SCH_SHAPE - Add SCH_RULE_AREA to paint and plot methods - Add new rule area color preference to themes
2024-04-25 14:24:46 +00:00
// Final change sets
std::set<SCH_ITEM*> changed_items;
std::set<VECTOR2I> pts;
std::set<std::pair<SCH_SHEET_PATH, SCH_ITEM*>> item_paths;
Incremental schematic connectivity fixes.
2024-01-21 16:53:05 +00:00
Add SCH_RULE_AREA shapes to eeschema Includes: - Fix GAL to draw closed polygons in eeschema - Add functionality to eeschema to draw arbitary polygons - Update polygon item previews to have customisable edge colour - Add new SCH_RULE_AREA class, derived from a poly SCH_SHAPE - Add SCH_RULE_AREA to paint and plot methods - Add new rule area color preference to themes
2024-04-25 14:24:46 +00:00
// Working change sets
std::unordered_set<SCH_SCREEN*> changed_screens;
std::set<std::pair<SCH_RULE_AREA*, SCH_SCREEN*>> changed_rule_areas;
std::vector<CHANGED_ITEM> changed_connectable_items;
Test for schematic type when changing The schematic editor undo list may hold page layout types as well
2023-05-10 18:25:53 +00:00
Add SCH_RULE_AREA shapes to eeschema Includes: - Fix GAL to draw closed polygons in eeschema - Add functionality to eeschema to draw arbitary polygons - Update polygon item previews to have customisable edge colour - Add new SCH_RULE_AREA class, derived from a poly SCH_SHAPE - Add SCH_RULE_AREA to paint and plot methods - Add new rule area color preference to themes
2024-04-25 14:24:46 +00:00
// Lambda to add an item to the connectivity update sets
Fix warning.
2024-04-26 11:56:37 +00:00
auto addItemToChangeSet = [&changed_items, &pts, &item_paths]( CHANGED_ITEM itemData )
Add SCH_RULE_AREA shapes to eeschema Includes: - Fix GAL to draw closed polygons in eeschema - Add functionality to eeschema to draw arbitary polygons - Update polygon item previews to have customisable edge colour - Add new SCH_RULE_AREA class, derived from a poly SCH_SHAPE - Add SCH_RULE_AREA to paint and plot methods - Add new rule area color preference to themes
2024-04-25 14:24:46 +00:00
{
Remove cover types.
2024-06-03 10:11:04 +00:00
std::vector<SCH_SHEET_PATH>& paths = itemData.screen->GetClientSheetPaths();
Test for schematic type when changing The schematic editor undo list may hold page layout types as well
2023-05-10 18:25:53 +00:00
Add SCH_RULE_AREA shapes to eeschema Includes: - Fix GAL to draw closed polygons in eeschema - Add functionality to eeschema to draw arbitary polygons - Update polygon item previews to have customisable edge colour - Add new SCH_RULE_AREA class, derived from a poly SCH_SHAPE - Add SCH_RULE_AREA to paint and plot methods - Add new rule area color preference to themes
2024-04-25 14:24:46 +00:00
std::vector<VECTOR2I> tmp_pts = itemData.item->GetConnectionPoints();
Replace stale pin references with UNDO copy When we replace a symbol with one that has fewer pins, the old pins are released, which leaves points to them in the connection graph dangling. This updates the pointer to use the cloned copy in the undo stack until the connection graph is rebuilt with the new data Fixes https://gitlab.com/kicad/code/kicad/-/issues/17851
2024-04-24 19:44:32 +00:00
pts.insert( tmp_pts.begin(), tmp_pts.end() );
Add SCH_RULE_AREA shapes to eeschema Includes: - Fix GAL to draw closed polygons in eeschema - Add functionality to eeschema to draw arbitary polygons - Update polygon item previews to have customisable edge colour - Add new SCH_RULE_AREA class, derived from a poly SCH_SHAPE - Add SCH_RULE_AREA to paint and plot methods - Add new rule area color preference to themes
2024-04-25 14:24:46 +00:00
changed_items.insert( itemData.item );
Properly handle incremental bus connections - Incremental extraction needs the newly created items. The modified items are already set in the connection graph but the newly created items don't exist yet, so we need to add those explicitly - Bus parents need to ensure that the bus children exist because we iterate on the updates from the top of the graph down
2023-09-16 19:42:48 +00:00
Ensure that missing pins are added to extraction When changing from a larger part to a smaller part, the previously existing pins may be removed from the screen but still linked to elements in the connection graph because we don't set them dirty unless the changed element overlaps Fixes https://gitlab.com/kicad/code/kicad/-/issues/17851
2024-04-24 02:35:29 +00:00
for( SCH_SHEET_PATH& path : paths )
Add SCH_RULE_AREA shapes to eeschema Includes: - Fix GAL to draw closed polygons in eeschema - Add functionality to eeschema to draw arbitary polygons - Update polygon item previews to have customisable edge colour - Add new SCH_RULE_AREA class, derived from a poly SCH_SHAPE - Add SCH_RULE_AREA to paint and plot methods - Add new rule area color preference to themes
2024-04-25 14:24:46 +00:00
item_paths.insert( std::make_pair( path, itemData.item ) );
Ensure that missing pins are added to extraction When changing from a larger part to a smaller part, the previously existing pins may be removed from the screen but still linked to elements in the connection graph because we don't set them dirty unless the changed element overlaps Fixes https://gitlab.com/kicad/code/kicad/-/issues/17851
2024-04-24 02:35:29 +00:00
Add SCH_RULE_AREA shapes to eeschema Includes: - Fix GAL to draw closed polygons in eeschema - Add functionality to eeschema to draw arbitary polygons - Update polygon item previews to have customisable edge colour - Add new SCH_RULE_AREA class, derived from a poly SCH_SHAPE - Add SCH_RULE_AREA to paint and plot methods - Add new rule area color preference to themes
2024-04-25 14:24:46 +00:00
if( !itemData.linked_item || !itemData.linked_item->IsConnectable() )
return;
Ensure that missing pins are added to extraction When changing from a larger part to a smaller part, the previously existing pins may be removed from the screen but still linked to elements in the connection graph because we don't set them dirty unless the changed element overlaps Fixes https://gitlab.com/kicad/code/kicad/-/issues/17851
2024-04-24 02:35:29 +00:00
Add SCH_RULE_AREA shapes to eeschema Includes: - Fix GAL to draw closed polygons in eeschema - Add functionality to eeschema to draw arbitary polygons - Update polygon item previews to have customisable edge colour - Add new SCH_RULE_AREA class, derived from a poly SCH_SHAPE - Add SCH_RULE_AREA to paint and plot methods - Add new rule area color preference to themes
2024-04-25 14:24:46 +00:00
tmp_pts = itemData.linked_item->GetConnectionPoints();
Replace stale pin references with UNDO copy When we replace a symbol with one that has fewer pins, the old pins are released, which leaves points to them in the connection graph dangling. This updates the pointer to use the cloned copy in the undo stack until the connection graph is rebuilt with the new data Fixes https://gitlab.com/kicad/code/kicad/-/issues/17851
2024-04-24 19:44:32 +00:00
pts.insert( tmp_pts.begin(), tmp_pts.end() );
Add SCH_RULE_AREA shapes to eeschema Includes: - Fix GAL to draw closed polygons in eeschema - Add functionality to eeschema to draw arbitary polygons - Update polygon item previews to have customisable edge colour - Add new SCH_RULE_AREA class, derived from a poly SCH_SHAPE - Add SCH_RULE_AREA to paint and plot methods - Add new rule area color preference to themes
2024-04-25 14:24:46 +00:00
changed_items.insert( itemData.linked_item );
Ensure that missing pins are added to extraction When changing from a larger part to a smaller part, the previously existing pins may be removed from the screen but still linked to elements in the connection graph because we don't set them dirty unless the changed element overlaps Fixes https://gitlab.com/kicad/code/kicad/-/issues/17851
2024-04-24 02:35:29 +00:00
// We have to directly add the pins here because the link may not exist on the schematic
// anymore and so won't be picked up by GetScreen()->Items().Overlapping() below.
Add SCH_RULE_AREA shapes to eeschema Includes: - Fix GAL to draw closed polygons in eeschema - Add functionality to eeschema to draw arbitary polygons - Update polygon item previews to have customisable edge colour - Add new SCH_RULE_AREA class, derived from a poly SCH_SHAPE - Add SCH_RULE_AREA to paint and plot methods - Add new rule area color preference to themes
2024-04-25 14:24:46 +00:00
if( SCH_SYMBOL* symbol = dynamic_cast<SCH_SYMBOL*>( itemData.linked_item ) )
Ensure that missing pins are added to extraction When changing from a larger part to a smaller part, the previously existing pins may be removed from the screen but still linked to elements in the connection graph because we don't set them dirty unless the changed element overlaps Fixes https://gitlab.com/kicad/code/kicad/-/issues/17851
2024-04-24 02:35:29 +00:00
{
std::vector<SCH_PIN*> pins = symbol->GetPins();
changed_items.insert( pins.begin(), pins.end() );
}
Properly handle incremental bus connections - Incremental extraction needs the newly created items. The modified items are already set in the connection graph but the newly created items don't exist yet, so we need to add those explicitly - Bus parents need to ensure that the bus children exist because we iterate on the updates from the top of the graph down
2023-09-16 19:42:48 +00:00
for( SCH_SHEET_PATH& path : paths )
Add SCH_RULE_AREA shapes to eeschema Includes: - Fix GAL to draw closed polygons in eeschema - Add functionality to eeschema to draw arbitary polygons - Update polygon item previews to have customisable edge colour - Add new SCH_RULE_AREA class, derived from a poly SCH_SHAPE - Add SCH_RULE_AREA to paint and plot methods - Add new rule area color preference to themes
2024-04-25 14:24:46 +00:00
item_paths.insert( std::make_pair( path, itemData.linked_item ) );
};
// Get all changed connectable items and determine all changed screens
for( unsigned ii = 0; ii < changed_list->GetCount(); ++ii )
{
SCH_ITEM* item = dynamic_cast<SCH_ITEM*>( changed_list->GetPickedItem( ii ) );
if( item )
{
SCH_SCREEN* screen =
static_cast<SCH_SCREEN*>( changed_list->GetScreenForItem( ii ) );
changed_screens.insert( screen );
if( item->Type() == SCH_RULE_AREA_T )
{
SCH_RULE_AREA* ruleArea = static_cast<SCH_RULE_AREA*>( item );
// Clear item and directive associations for this rule area
ruleArea->ResetDirectivesAndItems( GetCanvas()->GetView() );
changed_rule_areas.insert( { ruleArea, screen } );
}
else if( item->IsConnectable() )
{
SCH_ITEM* linked_item =
dynamic_cast<SCH_ITEM*>( changed_list->GetPickedItemLink( ii ) );
changed_connectable_items.push_back( { item, linked_item, screen } );
}
}
}
// Update rule areas in changed screens to propagate any directive connectivity changes
std::vector<std::pair<SCH_RULE_AREA*, SCH_SCREEN*>> forceUpdateRuleAreas =
SCH_RULE_AREA::UpdateRuleAreasInScreens( changed_screens, GetCanvas()->GetView() );
std::for_each( forceUpdateRuleAreas.begin(), forceUpdateRuleAreas.end(),
[&]( std::pair<SCH_RULE_AREA*, SCH_SCREEN*>& updatedRuleArea )
{
changed_rule_areas.insert( updatedRuleArea );
} );
// If a SCH_RULE_AREA was changed, we need to add all past and present contained items to
// update their connectivity
for( const std::pair<SCH_RULE_AREA*, SCH_SCREEN*>& changedRuleArea : changed_rule_areas )
{
for( SCH_ITEM* containedItem :
changedRuleArea.first->GetPastAndPresentContainedItems() )
{
addItemToChangeSet( { containedItem, nullptr, changedRuleArea.second } );
}
}
// Add all changed items, and associated items, to the change set
for( CHANGED_ITEM& changed_item_data : changed_connectable_items )
{
addItemToChangeSet( changed_item_data );
// If a SCH_DIRECTIVE_LABEL was changed which is attached to a SCH_RULE_AREA, we need
// to add the contained items to the change set to force update of their connectivity
if( changed_item_data.item->Type() == SCH_DIRECTIVE_LABEL_T )
{
const std::vector<VECTOR2I> labelConnectionPoints =
changed_item_data.item->GetConnectionPoints();
EE_RTREE::EE_TYPE candidateRuleAreas =
changed_item_data.screen->Items().Overlapping(
SCH_RULE_AREA_T, changed_item_data.item->GetBoundingBox() );
for( SCH_ITEM* candidateRuleArea : candidateRuleAreas )
{
SCH_RULE_AREA* ruleArea = static_cast<SCH_RULE_AREA*>( candidateRuleArea );
std::vector<SHAPE*> borderShapes = ruleArea->MakeEffectiveShapes( true );
if( ruleArea->GetPolyShape().CollideEdge( labelConnectionPoints[0], nullptr,
5 ) )
{
for( SCH_ITEM* containedItem : ruleArea->GetPastAndPresentContainedItems() )
addItemToChangeSet(
{ containedItem, nullptr, changed_item_data.screen } );
}
}
}
Add ability to update subgraphs based on changeset Previously, almost all connectivity updates were full updates, meaning that the entire connectivity graph would be rebuilt each time a change was made to the schematic. This update modifies the update to only correct the subgraphs that are directly affected by the change. It uses the existing connection graph to find all affected subgraphs as well as connections to the changes based on the visible schematic. These elements are removed from the existing connectivity graph and marked dirty. They then have a new connectivity graph built only around their changes. The resulting graph is merged into the original. Currently, this ability is behind an advanced config flag `IncrementalConnectivity` while testing. Fixes https://gitlab.com/kicad/code/kicad/issues/10846 Fixes https://gitlab.com/kicad/code/kicad/issues/1794
2023-04-08 15:22:34 +00:00
}
Replace stale pin references with UNDO copy When we replace a symbol with one that has fewer pins, the old pins are released, which leaves points to them in the connection graph dangling. This updates the pointer to use the cloned copy in the undo stack until the connection graph is rebuilt with the new data Fixes https://gitlab.com/kicad/code/kicad/-/issues/17851
2024-04-24 19:44:32 +00:00
for( const VECTOR2I& pt: pts )
Add ability to update subgraphs based on changeset Previously, almost all connectivity updates were full updates, meaning that the entire connectivity graph would be rebuilt each time a change was made to the schematic. This update modifies the update to only correct the subgraphs that are directly affected by the change. It uses the existing connection graph to find all affected subgraphs as well as connections to the changes based on the visible schematic. These elements are removed from the existing connectivity graph and marked dirty. They then have a new connectivity graph built only around their changes. The resulting graph is merged into the original. Currently, this ability is behind an advanced config flag `IncrementalConnectivity` while testing. Fixes https://gitlab.com/kicad/code/kicad/issues/10846 Fixes https://gitlab.com/kicad/code/kicad/issues/1794
2023-04-08 15:22:34 +00:00
{
Eradicate a bunch of calls to dyn_cast.
2023-06-24 17:19:44 +00:00
for( SCH_ITEM* item : GetScreen()->Items().Overlapping( pt ) )
Add ability to update subgraphs based on changeset Previously, almost all connectivity updates were full updates, meaning that the entire connectivity graph would be rebuilt each time a change was made to the schematic. This update modifies the update to only correct the subgraphs that are directly affected by the change. It uses the existing connection graph to find all affected subgraphs as well as connections to the changes based on the visible schematic. These elements are removed from the existing connectivity graph and marked dirty. They then have a new connectivity graph built only around their changes. The resulting graph is merged into the original. Currently, this ability is behind an advanced config flag `IncrementalConnectivity` while testing. Fixes https://gitlab.com/kicad/code/kicad/issues/10846 Fixes https://gitlab.com/kicad/code/kicad/issues/1794
2023-04-08 15:22:34 +00:00
{
Fix incremental connectivity The connectivity routine would consider symbols, overwriting unused subgraphs for pins that were not in the change list. This is resolved by updating the full connectivity to only use pins in the graph since symbols are not connected independently. In the process of adding QA tests for this change, additional issues with the schematic QA were discovered. Specifically, we were not properly setting the root sheet UUID. This was partially masked by a const_cast setting of the RefDes in sch_symbol when called the RefDes getter. This exposed the fact that our QA ERC numbers did not match the schematic editor stand alone ERC numbers. So the test value for one check needed to be updated Fixes https://gitlab.com/kicad/code/kicad/-/issues/17528
2024-04-10 23:40:43 +00:00
// Leave this check in place. Overlapping items are not necessarily connectable.
if( !item->IsConnectable() )
continue;
Eradicate a bunch of calls to dyn_cast.
2023-06-24 17:19:44 +00:00
if( item->Type() == SCH_LINE_T )
Add ability to update subgraphs based on changeset Previously, almost all connectivity updates were full updates, meaning that the entire connectivity graph would be rebuilt each time a change was made to the schematic. This update modifies the update to only correct the subgraphs that are directly affected by the change. It uses the existing connection graph to find all affected subgraphs as well as connections to the changes based on the visible schematic. These elements are removed from the existing connectivity graph and marked dirty. They then have a new connectivity graph built only around their changes. The resulting graph is merged into the original. Currently, this ability is behind an advanced config flag `IncrementalConnectivity` while testing. Fixes https://gitlab.com/kicad/code/kicad/issues/10846 Fixes https://gitlab.com/kicad/code/kicad/issues/1794
2023-04-08 15:22:34 +00:00
{
Eradicate a bunch of calls to dyn_cast.
2023-06-24 17:19:44 +00:00
if( item->HitTest( pt ) )
Add ability to update subgraphs based on changeset Previously, almost all connectivity updates were full updates, meaning that the entire connectivity graph would be rebuilt each time a change was made to the schematic. This update modifies the update to only correct the subgraphs that are directly affected by the change. It uses the existing connection graph to find all affected subgraphs as well as connections to the changes based on the visible schematic. These elements are removed from the existing connectivity graph and marked dirty. They then have a new connectivity graph built only around their changes. The resulting graph is merged into the original. Currently, this ability is behind an advanced config flag `IncrementalConnectivity` while testing. Fixes https://gitlab.com/kicad/code/kicad/issues/10846 Fixes https://gitlab.com/kicad/code/kicad/issues/1794
2023-04-08 15:22:34 +00:00
changed_items.insert( item );
}
Fix incremental connectivity The connectivity routine would consider symbols, overwriting unused subgraphs for pins that were not in the change list. This is resolved by updating the full connectivity to only use pins in the graph since symbols are not connected independently. In the process of adding QA tests for this change, additional issues with the schematic QA were discovered. Specifically, we were not properly setting the root sheet UUID. This was partially masked by a const_cast setting of the RefDes in sch_symbol when called the RefDes getter. This exposed the fact that our QA ERC numbers did not match the schematic editor stand alone ERC numbers. So the test value for one check needed to be updated Fixes https://gitlab.com/kicad/code/kicad/-/issues/17528
2024-04-10 23:40:43 +00:00
else if( item->Type() == SCH_SYMBOL_T && item->IsConnected( pt ) )
Bug Fixes for new incremental connectivity - Ensure that critical paths (ERC/netlister) are fully-rechecked - Handle symbol/pin distinction in change markers - Fully connect hierarchical pins in one pass descending
2023-04-21 20:25:01 +00:00
{
Eradicate a bunch of calls to dyn_cast.
2023-06-24 17:19:44 +00:00
SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( item );
std::vector<SCH_PIN*> pins = symbol->GetPins();
Bug Fixes for new incremental connectivity - Ensure that critical paths (ERC/netlister) are fully-rechecked - Handle symbol/pin distinction in change markers - Fully connect hierarchical pins in one pass descending
2023-04-21 20:25:01 +00:00
changed_items.insert( pins.begin(), pins.end() );
}
Incremental schematic connectivity fixes.
2024-01-21 16:53:05 +00:00
else if( item->Type() == SCH_SHEET_T )
{
SCH_SHEET* sheet = static_cast<SCH_SHEET*>( item );
wxCHECK2( sheet, continue );
std::vector<SCH_SHEET_PIN*> sheetPins = sheet->GetPins();
changed_items.insert( sheetPins.begin(), sheetPins.end() );
}
else
Eradicate a bunch of calls to dyn_cast.
2023-06-24 17:19:44 +00:00
{
if( item->IsConnected( pt ) )
changed_items.insert( item );
}
Add ability to update subgraphs based on changeset Previously, almost all connectivity updates were full updates, meaning that the entire connectivity graph would be rebuilt each time a change was made to the schematic. This update modifies the update to only correct the subgraphs that are directly affected by the change. It uses the existing connection graph to find all affected subgraphs as well as connections to the changes based on the visible schematic. These elements are removed from the existing connectivity graph and marked dirty. They then have a new connectivity graph built only around their changes. The resulting graph is merged into the original. Currently, this ability is behind an advanced config flag `IncrementalConnectivity` while testing. Fixes https://gitlab.com/kicad/code/kicad/issues/10846 Fixes https://gitlab.com/kicad/code/kicad/issues/1794
2023-04-08 15:22:34 +00:00
}
}
std::set<std::pair<SCH_SHEET_PATH, SCH_ITEM*>> all_items =
Retire AddItemToCommitAndScreen() It duplicates a bunch of stuff in SCH_COMMIT and isn't really compatible with it. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14933
2023-06-12 18:33:52 +00:00
Schematic().ConnectionGraph()->ExtractAffectedItems( changed_items );
Add ability to update subgraphs based on changeset Previously, almost all connectivity updates were full updates, meaning that the entire connectivity graph would be rebuilt each time a change was made to the schematic. This update modifies the update to only correct the subgraphs that are directly affected by the change. It uses the existing connection graph to find all affected subgraphs as well as connections to the changes based on the visible schematic. These elements are removed from the existing connectivity graph and marked dirty. They then have a new connectivity graph built only around their changes. The resulting graph is merged into the original. Currently, this ability is behind an advanced config flag `IncrementalConnectivity` while testing. Fixes https://gitlab.com/kicad/code/kicad/issues/10846 Fixes https://gitlab.com/kicad/code/kicad/issues/1794
2023-04-08 15:22:34 +00:00
Properly handle incremental bus connections - Incremental extraction needs the newly created items. The modified items are already set in the connection graph but the newly created items don't exist yet, so we need to add those explicitly - Bus parents need to ensure that the bus children exist because we iterate on the updates from the top of the graph down
2023-09-16 19:42:48 +00:00
all_items.insert( item_paths.begin(), item_paths.end() );
Add ability to update subgraphs based on changeset Previously, almost all connectivity updates were full updates, meaning that the entire connectivity graph would be rebuilt each time a change was made to the schematic. This update modifies the update to only correct the subgraphs that are directly affected by the change. It uses the existing connection graph to find all affected subgraphs as well as connections to the changes based on the visible schematic. These elements are removed from the existing connectivity graph and marked dirty. They then have a new connectivity graph built only around their changes. The resulting graph is merged into the original. Currently, this ability is behind an advanced config flag `IncrementalConnectivity` while testing. Fixes https://gitlab.com/kicad/code/kicad/issues/10846 Fixes https://gitlab.com/kicad/code/kicad/issues/1794
2023-04-08 15:22:34 +00:00
CONNECTION_GRAPH new_graph( &Schematic() );
new_graph.SetLastCodes( Schematic().ConnectionGraph() );
for( auto&[ path, item ] : all_items )
{
More issue #16846 invalid pointer checks. This has now pushed the issue down to a broken RTree issue. Skipping the asserts in debug builds will still crash but now it's pushed down to the RTree.
2024-02-10 20:41:10 +00:00
wxCHECK2( item, continue );
Fix incremental connectivity The connectivity routine would consider symbols, overwriting unused subgraphs for pins that were not in the change list. This is resolved by updating the full connectivity to only use pins in the graph since symbols are not connected independently. In the process of adding QA tests for this change, additional issues with the schematic QA were discovered. Specifically, we were not properly setting the root sheet UUID. This was partially masked by a const_cast setting of the RefDes in sch_symbol when called the RefDes getter. This exposed the fact that our QA ERC numbers did not match the schematic editor stand alone ERC numbers. So the test value for one check needed to be updated Fixes https://gitlab.com/kicad/code/kicad/-/issues/17528
2024-04-10 23:40:43 +00:00
item->SetConnectivityDirty();
Add ability to update subgraphs based on changeset Previously, almost all connectivity updates were full updates, meaning that the entire connectivity graph would be rebuilt each time a change was made to the schematic. This update modifies the update to only correct the subgraphs that are directly affected by the change. It uses the existing connection graph to find all affected subgraphs as well as connections to the changes based on the visible schematic. These elements are removed from the existing connectivity graph and marked dirty. They then have a new connectivity graph built only around their changes. The resulting graph is merged into the original. Currently, this ability is behind an advanced config flag `IncrementalConnectivity` while testing. Fixes https://gitlab.com/kicad/code/kicad/issues/10846 Fixes https://gitlab.com/kicad/code/kicad/issues/1794
2023-04-08 15:22:34 +00:00
}
new_graph.Recalculate( list, false, &changeHandler );
Schematic().ConnectionGraph()->Merge( new_graph );
}
Preserve highlighted connection through a recalculation
2021-07-03 20:42:14 +00:00
Better cache invalidation for text objects with references. Fixes https://gitlab.com/kicad/code/kicad/issues/13059
2022-12-03 13:25:20 +00:00
GetCanvas()->GetView()->UpdateAllItemsConditionally(
Make sure screen RTrees are updated when changing bounding boxes.
2023-02-07 15:09:24 +00:00
[&]( KIGFX::VIEW_ITEM* aItem ) -> int
Move update-wires-if-driver-changed logic. This prevents RecalculateConnections from getting called twice before we run the logic. In that case the driver would change on the first recalc, and then it would look like it didn't change on the second (which is where we were checking). Fixes https://gitlab.com/kicad/code/kicad/issues/8812
2021-07-23 15:44:15 +00:00
{
Fix variable updating in SCH_FIELDs (which are not directly in the view).
2023-02-05 20:50:24 +00:00
int flags = 0;
SCH_ITEM* item = dynamic_cast<SCH_ITEM*>( aItem );
Move update-wires-if-driver-changed logic. This prevents RecalculateConnections from getting called twice before we run the logic. In that case the driver would change on the first recalc, and then it would look like it didn't change on the second (which is where we were checking). Fixes https://gitlab.com/kicad/code/kicad/issues/8812
2021-07-23 15:44:15 +00:00
SCH_CONNECTION* connection = item ? item->Connection() : nullptr;
ADDED: markers for excluded-from-sim items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15382
2024-06-03 12:59:40 +00:00
auto invalidateTextVars =
[&flags]( EDA_TEXT* text )
{
if( text->HasTextVars() )
{
text->ClearRenderCache();
text->ClearBoundingBoxCache();
flags |= KIGFX::GEOMETRY | KIGFX::REPAINT;
}
};
Move update-wires-if-driver-changed logic. This prevents RecalculateConnections from getting called twice before we run the logic. In that case the driver would change on the first recalc, and then it would look like it didn't change on the second (which is where we were checking). Fixes https://gitlab.com/kicad/code/kicad/issues/8812
2021-07-23 15:44:15 +00:00
if( connection && connection->HasDriverChanged() )
{
connection->ClearDriverChanged();
Fix variable updating in SCH_FIELDs (which are not directly in the view).
2023-02-05 20:50:24 +00:00
flags |= KIGFX::REPAINT;
Move update-wires-if-driver-changed logic. This prevents RecalculateConnections from getting called twice before we run the logic. In that case the driver would change on the first recalc, and then it would look like it didn't change on the second (which is where we were checking). Fixes https://gitlab.com/kicad/code/kicad/issues/8812
2021-07-23 15:44:15 +00:00
}
Fix variable updating in SCH_FIELDs (which are not directly in the view).
2023-02-05 20:50:24 +00:00
if( item )
Better cache invalidation for text objects with references. Fixes https://gitlab.com/kicad/code/kicad/issues/13059
2022-12-03 13:25:20 +00:00
{
Fix variable updating in SCH_FIELDs (which are not directly in the view).
2023-02-05 20:50:24 +00:00
item->RunOnChildren(
ADDED: markers for excluded-from-sim items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15382
2024-06-03 12:59:40 +00:00
[&invalidateTextVars]( SCH_ITEM* aChild )
Fix variable updating in SCH_FIELDs (which are not directly in the view).
2023-02-05 20:50:24 +00:00
{
ADDED: markers for excluded-from-sim items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15382
2024-06-03 12:59:40 +00:00
if( EDA_TEXT* text = dynamic_cast<EDA_TEXT*>( aChild ) )
invalidateTextVars( text );
Fix variable updating in SCH_FIELDs (which are not directly in the view).
2023-02-05 20:50:24 +00:00
} );
Make sure screen RTrees are updated when changing bounding boxes.
2023-02-07 15:09:24 +00:00
if( flags & KIGFX::GEOMETRY )
GetScreen()->Update( item, false ); // Refresh RTree
Better cache invalidation for text objects with references. Fixes https://gitlab.com/kicad/code/kicad/issues/13059
2022-12-03 13:25:20 +00:00
}
Move update-wires-if-driver-changed logic. This prevents RecalculateConnections from getting called twice before we run the logic. In that case the driver would change on the first recalc, and then it would look like it didn't change on the second (which is where we were checking). Fixes https://gitlab.com/kicad/code/kicad/issues/8812
2021-07-23 15:44:15 +00:00
ADDED: markers for excluded-from-sim items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/15382
2024-06-03 12:59:40 +00:00
if( EDA_TEXT* text = dynamic_cast<EDA_TEXT*>( aItem ) )
invalidateTextVars( text );
Fix variable updating in SCH_FIELDs (which are not directly in the view).
2023-02-05 20:50:24 +00:00
return flags;
Move update-wires-if-driver-changed logic. This prevents RecalculateConnections from getting called twice before we run the logic. In that case the driver would change on the first recalc, and then it would look like it didn't change on the second (which is where we were checking). Fixes https://gitlab.com/kicad/code/kicad/issues/8812
2021-07-23 15:44:15 +00:00
} );
net navigator: show all nets when none are highlighted
2024-04-03 18:44:40 +00:00
if( m_highlightedConnChanged
|| !Schematic().ConnectionGraph()->FindFirstSubgraphByName( highlightedConn ) )
Fix potential stale pointer bug in schematic highlight connection code. SCH_CONNECTION objects are temporary and can become stale any time the connectivity is updated. Keeping them around to reference later is a bad idea. Even if the object pointer is still valid in an SCH_ITEM in the undo/redo buffers, comparing the pointer against another pointer as a test to see if they are the same connection is not valid. Saving the connection name is safe and ensures the connection is the same even if the pointers differ.
2023-05-17 00:06:21 +00:00
{
net navigator: show all nets when none are highlighted
2024-04-03 18:44:40 +00:00
GetToolManager()->RunAction( EE_ACTIONS::updateNetHighlighting );
RefreshNetNavigator();
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
m_highlightedConnChanged = false;
Fix potential stale pointer bug in schematic highlight connection code. SCH_CONNECTION objects are temporary and can become stale any time the connectivity is updated. Keeping them around to reference later is a bad idea. Even if the object pointer is still valid in an SCH_ITEM in the undo/redo buffers, comparing the pointer against another pointer as a test to see if they are the same connection is not valid. Saving the connection name is safe and ensures the connection is the same even if the pointers differ.
2023-05-17 00:06:21 +00:00
}
Upgrade many editing actions to SCHEMATIC_COMMIT.
2023-06-09 16:24:49 +00:00
Upgrade some symbol editor stuff to SCHEMATIC_COMMIT. Also renames SCHEMATIC_COMMIT to SCH_COMMIT since it's not schematic-specifc.
2023-06-09 21:41:33 +00:00
if( !localCommit.Empty() )
localCommit.Push( _( "Schematic Cleanup" ) );
New connectivity algorithm and bus upgrades Bus upgrades: core new connectivity code Bus upgrades: eeschema integration and modifications Bus upgrades: eeschema dialogs Bus upgrades: netlist export Bus upgrades: file format changes
2019-03-11 21:32:05 +00:00
}
Re-write IntersheetRefs on top of SCH_FIELDs and textVars. 1) Generalize SCH_ITEM owners (SCH_COMPONENT, SCH_SHEET, and now SCH_GLOBALLABEL) 2) Generalize hypertext items 3) Use SCH_FIELD autoplace infrastructure for placing intersheet references 4) Use textVar infrastructure for buildin intersheet references. As an important side-effect this also fixes the undo issues with intersheet refs.
2020-11-17 16:02:47 +00:00
Better cache invalidation for text objects with references. Fixes https://gitlab.com/kicad/code/kicad/issues/13059
2022-12-03 13:25:20 +00:00
void SCH_EDIT_FRAME::RecomputeIntersheetRefs()
ADDED: eeschema: Add intersheets references function Add a new function to place intersheets references next to global labels.
2020-08-31 14:11:54 +00:00
{
Better cache invalidation for text objects with references. Fixes https://gitlab.com/kicad/code/kicad/issues/13059
2022-12-03 13:25:20 +00:00
Schematic().RecomputeIntersheetRefs( [&]( SCH_GLOBALLABEL* label )
Stuff RecomputeIntersheetRefs into SCHEMATIC for reuse
2022-11-03 04:12:53 +00:00
{
Better cache invalidation for text objects with references. Fixes https://gitlab.com/kicad/code/kicad/issues/13059
2022-12-03 13:25:20 +00:00
for( SCH_FIELD& field : label->GetFields() )
field.ClearBoundingBoxCache();
label->ClearBoundingBoxCache();
Stuff RecomputeIntersheetRefs into SCHEMATIC for reuse
2022-11-03 04:12:53 +00:00
GetCanvas()->GetView()->Update( label );
Better cache invalidation for text objects with references. Fixes https://gitlab.com/kicad/code/kicad/issues/13059
2022-12-03 13:25:20 +00:00
} );
ADDED: eeschema: Add intersheets references function Add a new function to place intersheets references next to global labels.
2020-08-31 14:11:54 +00:00
}
Re-write IntersheetRefs on top of SCH_FIELDs and textVars. 1) Generalize SCH_ITEM owners (SCH_COMPONENT, SCH_SHEET, and now SCH_GLOBALLABEL) 2) Generalize hypertext items 3) Use SCH_FIELD autoplace infrastructure for placing intersheet references 4) Use textVar infrastructure for buildin intersheet references. As an important side-effect this also fixes the undo issues with intersheet refs.
2020-11-17 16:02:47 +00:00
void SCH_EDIT_FRAME::ShowAllIntersheetRefs( bool aShow )
{
Better cache invalidation for text objects with references. Fixes https://gitlab.com/kicad/code/kicad/issues/13059
2022-12-03 13:25:20 +00:00
RecomputeIntersheetRefs();
Fix a couple of bugs in intersheet references. 1) init reference pages before trying to draw the SCH_FIELDs when turning intersheet references on 2) don't double redraw because we accidentally cleared the last hover item on a non-mouse-moved event. 3) make sure the root sheet gets a name for the hypertext menu.
2020-11-29 16:31:43 +00:00
SCH_NETCLASS_FLAGs and SCH_FIELDs for labels. ADDED: a new label type for netclass flags. ADDED: the ability to define fields on labels.
2021-10-12 20:05:37 +00:00
GetCanvas()->GetView()->SetLayerVisible( LAYER_INTERSHEET_REFS, aShow );
ADDED: eeschema: Add intersheets references function Add a new function to place intersheets references next to global labels.
2020-08-31 14:11:54 +00:00
}
New connectivity algorithm and bus upgrades Bus upgrades: core new connectivity code Bus upgrades: eeschema integration and modifications Bus upgrades: eeschema dialogs Bus upgrades: netlist export Bus upgrades: file format changes
2019-03-11 21:32:05 +00:00
Re-write IntersheetRefs on top of SCH_FIELDs and textVars. 1) Generalize SCH_ITEM owners (SCH_COMPONENT, SCH_SHEET, and now SCH_GLOBALLABEL) 2) Generalize hypertext items 3) Use SCH_FIELD autoplace infrastructure for placing intersheet references 4) Use textVar infrastructure for buildin intersheet references. As an important side-effect this also fixes the undo issues with intersheet refs.
2020-11-17 16:02:47 +00:00
Update text variables even when they're changed from other binary. For instance, you might have PCBNew open but change the variable value through EEschema > Schematic Setup. Fixes https://gitlab.com/kicad/code/kicad/issues/4918
2020-07-17 20:04:14 +00:00
void SCH_EDIT_FRAME::CommonSettingsChanged( bool aEnvVarsChanged, bool aTextVarsChanged )
Implement primitive icon scaling for high DPI This is meant as a stopgap for 5.0, with plans to add proper scaled icons in the 6.0 cycle. A function KiScaledBitmap() is added, which works like KiBitmap() except it scales the bitmap according to the calling window's font size. Controls have been added to all the main applications to let the user select scaling manually (these were omitted from smaller apps that didn't already have a place to put them). In addition, in eeschema only, the pixel height of the system font is shown in the options dialog for diagnostics. This is only for collecting feedback before 5.0 release from users with different displays and will be removed.
2018-01-08 04:05:03 +00:00
{
Refresh schematic's copy of template fieldnames after preferences. Fixes https://gitlab.com/kicad/code/kicad/issues/13203
2023-01-23 23:40:58 +00:00
SCH_BASE_FRAME::CommonSettingsChanged( aEnvVarsChanged, aTextVarsChanged );
ADDED: eeschema: Add intersheets references function Add a new function to place intersheets references next to global labels.
2020-08-31 14:11:54 +00:00
SCHEMATIC_SETTINGS& settings = Schematic().Settings();
Update junction-dot-size-cache when Schematic Setup changes. Fixes https://gitlab.com/kicad/code/kicad/issues/9541
2021-11-07 13:48:51 +00:00
settings.m_JunctionSize = GetSchematicJunctionSize();
Update text variables even when they're changed from other binary. For instance, you might have PCBNew open but change the variable value through EEschema > Schematic Setup. Fixes https://gitlab.com/kicad/code/kicad/issues/4918
2020-07-17 20:04:14 +00:00
Re-write IntersheetRefs on top of SCH_FIELDs and textVars. 1) Generalize SCH_ITEM owners (SCH_COMPONENT, SCH_SHEET, and now SCH_GLOBALLABEL) 2) Generalize hypertext items 3) Use SCH_FIELD autoplace infrastructure for placing intersheet references 4) Use textVar infrastructure for buildin intersheet references. As an important side-effect this also fixes the undo issues with intersheet refs.
2020-11-17 16:02:47 +00:00
ShowAllIntersheetRefs( settings.m_IntersheetRefsShow );
ADDED: eeschema: Add intersheets references function Add a new function to place intersheets references next to global labels.
2020-08-31 14:11:54 +00:00
Add show/hide controls for ERC markers. ADDED show/hide controls for ERC warnings, ERC errors and ERC exclusions. Fixes https://gitlab.com/kicad/code/kicad/issues/7270
2021-11-05 21:16:26 +00:00
EESCHEMA_SETTINGS* cfg = Pgm().GetSettingsManager().GetAppSettings<EESCHEMA_SETTINGS>();
All the preferences, all the time. Fixes https://gitlab.com/kicad/code/kicad/issues/7877 Fixes https://gitlab.com/kicad/code/kicad/issues/5153
2021-08-29 23:33:08 +00:00
GetGalDisplayOptions().ReadWindowSettings( cfg->m_Window );
Move default font to RENDER_SETTINGS. Fixes https://gitlab.com/kicad/code/kicad/issues/12723
2022-10-22 20:32:10 +00:00
GetRenderSettings()->SetDefaultFont( cfg->m_Appearance.default_font );
All the preferences, all the time. Fixes https://gitlab.com/kicad/code/kicad/issues/7877 Fixes https://gitlab.com/kicad/code/kicad/issues/5153
2021-08-29 23:33:08 +00:00
Add show/hide controls for ERC markers. ADDED show/hide controls for ERC warnings, ERC errors and ERC exclusions. Fixes https://gitlab.com/kicad/code/kicad/issues/7270
2021-11-05 21:16:26 +00:00
KIGFX::VIEW* view = GetCanvas()->GetView();
view->SetLayerVisible( LAYER_ERC_ERR, cfg->m_Appearance.show_erc_errors );
view->SetLayerVisible( LAYER_ERC_WARN, cfg->m_Appearance.show_erc_warnings );
view->SetLayerVisible( LAYER_ERC_EXCLUSION, cfg->m_Appearance.show_erc_exclusions );
ADDED operating point overlay for SCH_EDIT_FRAME. Fixes https://gitlab.com/kicad/code/kicad/issues/11253
2023-02-09 17:18:56 +00:00
view->SetLayerVisible( LAYER_OP_VOLTAGES, cfg->m_Appearance.show_op_voltages );
view->SetLayerVisible( LAYER_OP_CURRENTS, cfg->m_Appearance.show_op_currents );
RefreshOperatingPointDisplay();
Add show/hide controls for ERC markers. ADDED show/hide controls for ERC warnings, ERC errors and ERC exclusions. Fixes https://gitlab.com/kicad/code/kicad/issues/7270
2021-11-05 21:16:26 +00:00
Refresh schematic's copy of template fieldnames after preferences. Fixes https://gitlab.com/kicad/code/kicad/issues/13203
2023-01-23 23:40:58 +00:00
settings.m_TemplateFieldNames.DeleteAllFieldNameTemplates( true /* global */ );
if( !cfg->m_Drawing.field_names.IsEmpty() )
settings.m_TemplateFieldNames.AddTemplateFieldNames( cfg->m_Drawing.field_names );
Clear caches when changing global default font.
2022-01-09 00:44:24 +00:00
SCH_SCREEN* screen = GetCurrentSheet().LastScreen();
for( SCH_ITEM* item : screen->Items() )
item->ClearCaches();
Don't accidentally add NULL ptrs to the LibSymbols cache. Operator[] will add a blank element if it isn't found in the map. Probably Sentry KICAD-23Y. Fixes https://gitlab.com/kicad/code/kicad/-/issues/14927
2023-06-11 14:44:12 +00:00
for( const auto& [ libItemName, libSymbol ] : screen->GetLibSymbols() )
libSymbol->ClearCaches();
Clear caches when changing global default font.
2022-01-09 00:44:24 +00:00
All the preferences, all the time. Fixes https://gitlab.com/kicad/code/kicad/issues/7877 Fixes https://gitlab.com/kicad/code/kicad/issues/5153
2021-08-29 23:33:08 +00:00
GetCanvas()->ForceRefresh();
Synchronize toolbars state with current options after rebuilding them. Previously, for instance after modifying preferences or language, they were rebuilt but the tools state was not set due to a missing call to SyncToolbars() after rebuilding.
2019-07-20 15:52:30 +00:00
RecreateToolbars();
Implement primitive icon scaling for high DPI This is meant as a stopgap for 5.0, with plans to add proper scaled icons in the 6.0 cycle. A function KiScaledBitmap() is added, which works like KiBitmap() except it scales the bitmap according to the calling window's font size. Controls have been added to all the main applications to let the user select scaling manually (these were omitted from smaller apps that didn't already have a place to put them). In addition, in eeschema only, the pixel height of the system font is shown in the options dialog for diagnostics. This is only for collecting feedback before 5.0 release from users with different displays and will be removed.
2018-01-08 04:05:03 +00:00
Layout();
SendSizeEvent();
}
Fix a few more missing language-change updates. Fixes: lp:1779513 * https://bugs.launchpad.net/kicad/+bug/1779513 (cherry picked from commit 8389c5c)
2018-06-30 22:38:04 +00:00
Eeschema: adjust the working/drawing area size on the page size. This makes using Scrollbars more easy to use, especially for "small" page sizes like A or B. Note also the working/drawing area size is bigger than the page size (3 times)
2018-11-20 14:11:22 +00:00
void SCH_EDIT_FRAME::OnPageSettingsChange()
{
Eeschema: fix zoom change on undo/redo command. It was a side effect of commit e10025 fixing another zoom issue. Fixes #7170 https://gitlab.com/kicad/code/kicad/issues/7170
2021-01-18 15:07:09 +00:00
// Store the current zoom level into the current screen before calling
// DisplayCurrentSheet() that set the zoom to GetScreen()->m_LastZoomLevel
GetScreen()->m_LastZoomLevel = GetCanvas()->GetView()->GetScale();
Coding policy and Doxygen comment fixes.
2023-10-12 13:36:28 +00:00
Eeschema: adjust the working/drawing area size on the page size. This makes using Scrollbars more easy to use, especially for "small" page sizes like A or B. Note also the working/drawing area size is bigger than the page size (3 times)
2018-11-20 14:11:22 +00:00
// Rebuild the sheet view (draw area and any other items):
DisplayCurrentSheet();
}
Fix a few more missing language-change updates. Fixes: lp:1779513 * https://bugs.launchpad.net/kicad/+bug/1779513 (cherry picked from commit 8389c5c)
2018-06-30 22:38:04 +00:00
void SCH_EDIT_FRAME::ShowChangedLanguage()
{
// call my base class
SCH_BASE_FRAME::ShowChangedLanguage();
// tooltips in toolbars
Synchronize toolbars state with current options after rebuilding them. Previously, for instance after modifying preferences or language, they were rebuilt but the tools state was not set due to a missing call to SyncToolbars() after rebuilding.
2019-07-20 15:52:30 +00:00
RecreateToolbars();
Fix a few more missing language-change updates. Fixes: lp:1779513 * https://bugs.launchpad.net/kicad/+bug/1779513 (cherry picked from commit 8389c5c)
2018-06-30 22:38:04 +00:00
Handle language changes for Schematic Hierarchy Navigator. Fixes https://gitlab.com/kicad/code/kicad/issues/13291
2022-12-28 00:11:05 +00:00
m_auimgr.GetPane( m_hierarchy ).Caption( _( "Schematic Hierarchy" ) );
ADDED: Selection filter for schematic editor Fixes https://gitlab.com/kicad/code/kicad/-/issues/14988
2024-02-25 22:39:14 +00:00
m_auimgr.GetPane( m_selectionFilterPanel ).Caption( _( "Selection Filter" ) );
m_auimgr.GetPane( m_propertiesPanel ).Caption( _( "Properties" ) );
Handle language changes for Schematic Hierarchy Navigator. Fixes https://gitlab.com/kicad/code/kicad/issues/13291
2022-12-28 00:11:05 +00:00
m_auimgr.Update();
m_hierarchy->UpdateHierarchyTree();
Fix a few more missing language-change updates. Fixes: lp:1779513 * https://bugs.launchpad.net/kicad/+bug/1779513 (cherry picked from commit 8389c5c)
2018-06-30 22:38:04 +00:00
// status bar
UpdateMsgPanel();
Eeschema: fix an option toolbar refresh bug. For some reason, changing languages was causing the options (left) toolbar to get redrawn with some of the main toolbar entries. Changing the window size causes the toolbar to be redrawn correctly. The normal call to function wxWindow::Refresh() does not. Fixes lp:1816492 https://bugs.launchpad.net/kicad/+bug/1816492
2019-02-25 18:26:14 +00:00
Fix naming of `updateTitle()` This is a private function so should be lowercased to avoid confusion
2023-01-12 00:05:43 +00:00
updateTitle();
On-the-fly translations for pin electrical types. Also add on-the-fly translation for editor title bars. Fixes https://gitlab.com/kicad/code/kicad/issues/11324
2022-04-05 12:15:27 +00:00
Eeschema: fix an option toolbar refresh bug. For some reason, changing languages was causing the options (left) toolbar to get redrawn with some of the main toolbar entries. Changing the window size causes the toolbar to be redrawn correctly. The normal call to function wxWindow::Refresh() does not. Fixes lp:1816492 https://bugs.launchpad.net/kicad/+bug/1816492
2019-02-25 18:26:14 +00:00
// This ugly hack is to fix an option(left) toolbar update bug that seems to only affect
// windows. See https://bugs.launchpad.net/kicad/+bug/1816492. For some reason, calling
// wxWindow::Refresh() does not resolve the issue. Only a resize event seems to force the
// toolbar to update correctly.
#if defined( __WXMSW__ )
PostSizeEvent();
#endif
Fix a few more missing language-change updates. Fixes: lp:1779513 * https://bugs.launchpad.net/kicad/+bug/1779513 (cherry picked from commit 8389c5c)
2018-06-30 22:38:04 +00:00
}
Don't set the viewport when switching screens. That's the job of ZoomAutomatique(). Fixes: lp:1799436 * https://bugs.launchpad.net/kicad/+bug/1799436
2018-11-04 16:37:29 +00:00
Clear pin net-name-driving cache when changing annotation. Also update connectivity after clear annotation, annotate or back annotate. Also update status bar for highlighted nets. Fixes https://gitlab.com/kicad/code/kicad/issues/5170
2020-08-13 21:30:30 +00:00
void SCH_EDIT_FRAME::UpdateNetHighlightStatus()
{
Fix potential stale pointer bug in schematic highlight connection code. SCH_CONNECTION objects are temporary and can become stale any time the connectivity is updated. Keeping them around to reference later is a bad idea. Even if the object pointer is still valid in an SCH_ITEM in the undo/redo buffers, comparing the pointer against another pointer as a test to see if they are the same connection is not valid. Saving the connection name is safe and ensures the connection is the same even if the pointers differ.
2023-05-17 00:06:21 +00:00
if( !GetHighlightedConnection().IsEmpty() )
Clear pin net-name-driving cache when changing annotation. Also update connectivity after clear annotation, annotate or back annotate. Also update status bar for highlighted nets. Fixes https://gitlab.com/kicad/code/kicad/issues/5170
2020-08-13 21:30:30 +00:00
{
SetStatusText( wxString::Format( _( "Highlighted net: %s" ),
Fix potential stale pointer bug in schematic highlight connection code. SCH_CONNECTION objects are temporary and can become stale any time the connectivity is updated. Keeping them around to reference later is a bad idea. Even if the object pointer is still valid in an SCH_ITEM in the undo/redo buffers, comparing the pointer against another pointer as a test to see if they are the same connection is not valid. Saving the connection name is safe and ensures the connection is the same even if the pointers differ.
2023-05-17 00:06:21 +00:00
UnescapeString( GetHighlightedConnection() ) ) );
Clear pin net-name-driving cache when changing annotation. Also update connectivity after clear annotation, annotate or back annotate. Also update status bar for highlighted nets. Fixes https://gitlab.com/kicad/code/kicad/issues/5170
2020-08-13 21:30:30 +00:00
}
else
{
SetStatusText( wxT( "" ) );
}
}
eeschema-gal: initial GALified version. Lots of stuff still to do!
2018-08-03 12:18:26 +00:00
void SCH_EDIT_FRAME::SetScreen( BASE_SCREEN* aScreen )
{
Fix crash when loading new schematic with something selected
2020-10-28 02:04:43 +00:00
if( m_toolManager )
Separate immediate and delayed action dispatch Using a boolean argument just leads to a lot of trailing booleans in the function calls and is not user friendly. Instead, introduce PostAction() to send an action that runs after the coroutine (equivalent to passing false or the default argument), and leave RunAction as the immediate execution function.
2023-06-26 22:16:51 +00:00
m_toolManager->RunAction( EE_ACTIONS::clearSelection );
Fix crash when loading new schematic with something selected
2020-10-28 02:04:43 +00:00
Implement drawing tools in modern toolset. Fixes: lp:1825192 * https://bugs.launchpad.net/kicad/+bug/1825192
2019-04-17 19:09:48 +00:00
SCH_BASE_FRAME::SetScreen( aScreen );
Retire EDA_DRAW_PANEL and legacy_wx/EDA_DRAW_FRAME.
2019-05-31 17:37:07 +00:00
GetCanvas()->DisplaySheet( static_cast<SCH_SCREEN*>( aScreen ) );
Fix handling of selection overlay in schematic editor We weren't actually using the overlay group at all Fixes https://gitlab.com/kicad/code/kicad/-/issues/11142
2023-02-15 04:46:35 +00:00
if( m_toolManager )
m_toolManager->ResetTools( TOOL_BASE::MODEL_RELOAD );
eeschema-gal: initial GALified version. Lots of stuff still to do!
2018-08-03 12:18:26 +00:00
}
Don't set the viewport when switching screens. That's the job of ZoomAutomatique(). Fixes: lp:1799436 * https://bugs.launchpad.net/kicad/+bug/1799436
2018-11-04 16:37:29 +00:00
Refactor GetDocumentExtents() CHANGED: GetDocumentExtents() in 'eda_draw_frame.h' now has a bool parameter "aIncludeAllVisible" with a default value "true" which makes it behave as it did before adding parameter. If "aIncludeAllVisible" is false, the returned bbox ignores some items depending on which program it is running in. CHANGED: Made "Zoom to Objects" use only PCB edge in Pcbnew. This allows text, notes, etc outside the PCB edge to be excluded in the zoom calculation. CHANGED: Added "Zoom to Objects" to Pcbnew main menu, and to RMB context menus for Eeschema and Pcbnew. Fixes https://gitlab.com/kicad/code/kicad/issues/5787
2020-09-25 07:31:56 +00:00
const BOX2I SCH_EDIT_FRAME::GetDocumentExtents( bool aIncludeAllVisible ) const
eeschema-gal: initial GALified version. Lots of stuff still to do!
2018-08-03 12:18:26 +00:00
{
Refactor GetDocumentExtents() CHANGED: GetDocumentExtents() in 'eda_draw_frame.h' now has a bool parameter "aIncludeAllVisible" with a default value "true" which makes it behave as it did before adding parameter. If "aIncludeAllVisible" is false, the returned bbox ignores some items depending on which program it is running in. CHANGED: Made "Zoom to Objects" use only PCB edge in Pcbnew. This allows text, notes, etc outside the PCB edge to be excluded in the zoom calculation. CHANGED: Added "Zoom to Objects" to Pcbnew main menu, and to RMB context menus for Eeschema and Pcbnew. Fixes https://gitlab.com/kicad/code/kicad/issues/5787
2020-09-25 07:31:56 +00:00
BOX2I bBoxDoc;
eeschema-gal: initial GALified version. Lots of stuff still to do!
2018-08-03 12:18:26 +00:00
Refactor GetDocumentExtents() CHANGED: GetDocumentExtents() in 'eda_draw_frame.h' now has a bool parameter "aIncludeAllVisible" with a default value "true" which makes it behave as it did before adding parameter. If "aIncludeAllVisible" is false, the returned bbox ignores some items depending on which program it is running in. CHANGED: Made "Zoom to Objects" use only PCB edge in Pcbnew. This allows text, notes, etc outside the PCB edge to be excluded in the zoom calculation. CHANGED: Added "Zoom to Objects" to Pcbnew main menu, and to RMB context menus for Eeschema and Pcbnew. Fixes https://gitlab.com/kicad/code/kicad/issues/5787
2020-09-25 07:31:56 +00:00
if( aIncludeAllVisible )
{
// Get the whole page size and return that
Repoint IU_PER_MILS
2022-09-16 23:25:07 +00:00
int sizeX = GetScreen()->GetPageSettings().GetWidthIU( schIUScale.IU_PER_MILS );
int sizeY = GetScreen()->GetPageSettings().GetHeightIU( schIUScale.IU_PER_MILS );
Refactor GetDocumentExtents() CHANGED: GetDocumentExtents() in 'eda_draw_frame.h' now has a bool parameter "aIncludeAllVisible" with a default value "true" which makes it behave as it did before adding parameter. If "aIncludeAllVisible" is false, the returned bbox ignores some items depending on which program it is running in. CHANGED: Made "Zoom to Objects" use only PCB edge in Pcbnew. This allows text, notes, etc outside the PCB edge to be excluded in the zoom calculation. CHANGED: Added "Zoom to Objects" to Pcbnew main menu, and to RMB context menus for Eeschema and Pcbnew. Fixes https://gitlab.com/kicad/code/kicad/issues/5787
2020-09-25 07:31:56 +00:00
bBoxDoc = BOX2I( VECTOR2I( 0, 0 ), VECTOR2I( sizeX, sizeY ) );
}
else
{
Round 2 of Worksheet -> Drawing Sheet.
2021-02-22 23:47:17 +00:00
// Get current drawing-sheet in a form we can compare to an EDA_ITEM
DS_PROXY_VIEW_ITEM* ds = SCH_BASE_FRAME::GetCanvas()->GetView()->GetDrawingSheet();
EDA_ITEM* dsAsItem = static_cast<EDA_ITEM*>( ds );
Refactor GetDocumentExtents() CHANGED: GetDocumentExtents() in 'eda_draw_frame.h' now has a bool parameter "aIncludeAllVisible" with a default value "true" which makes it behave as it did before adding parameter. If "aIncludeAllVisible" is false, the returned bbox ignores some items depending on which program it is running in. CHANGED: Made "Zoom to Objects" use only PCB edge in Pcbnew. This allows text, notes, etc outside the PCB edge to be excluded in the zoom calculation. CHANGED: Added "Zoom to Objects" to Pcbnew main menu, and to RMB context menus for Eeschema and Pcbnew. Fixes https://gitlab.com/kicad/code/kicad/issues/5787
2020-09-25 07:31:56 +00:00
// Calc the bounding box of all items on screen except the page border
for( EDA_ITEM* item : GetScreen()->Items() )
{
Round 2 of Worksheet -> Drawing Sheet.
2021-02-22 23:47:17 +00:00
if( item != dsAsItem ) // Ignore the drawing-sheet itself
Remove a few EDA_RECT instances.
2022-08-30 23:28:18 +00:00
bBoxDoc.Merge( item->GetBoundingBox() );
Refactor GetDocumentExtents() CHANGED: GetDocumentExtents() in 'eda_draw_frame.h' now has a bool parameter "aIncludeAllVisible" with a default value "true" which makes it behave as it did before adding parameter. If "aIncludeAllVisible" is false, the returned bbox ignores some items depending on which program it is running in. CHANGED: Made "Zoom to Objects" use only PCB edge in Pcbnew. This allows text, notes, etc outside the PCB edge to be excluded in the zoom calculation. CHANGED: Added "Zoom to Objects" to Pcbnew main menu, and to RMB context menus for Eeschema and Pcbnew. Fixes https://gitlab.com/kicad/code/kicad/issues/5787
2020-09-25 07:31:56 +00:00
}
}
Remove a few EDA_RECT instances.
2022-08-30 23:28:18 +00:00
Refactor GetDocumentExtents() CHANGED: GetDocumentExtents() in 'eda_draw_frame.h' now has a bool parameter "aIncludeAllVisible" with a default value "true" which makes it behave as it did before adding parameter. If "aIncludeAllVisible" is false, the returned bbox ignores some items depending on which program it is running in. CHANGED: Made "Zoom to Objects" use only PCB edge in Pcbnew. This allows text, notes, etc outside the PCB edge to be excluded in the zoom calculation. CHANGED: Added "Zoom to Objects" to Pcbnew main menu, and to RMB context menus for Eeschema and Pcbnew. Fixes https://gitlab.com/kicad/code/kicad/issues/5787
2020-09-25 07:31:56 +00:00
return bBoxDoc;
eeschema-gal: initial GALified version. Lots of stuff still to do!
2018-08-03 12:18:26 +00:00
}
eeschema: automatically insert junctions at pin connections if needed during file load EEschema optimizes wires by merging colinear segments. If a schematic opened without a valid cache library or missing installed libraries and later saved, this optimization can cause connectivity errors. In order to fix that we check each pin-wire connection and junctions if necessary.
2019-06-23 15:12:25 +00:00
Eeschema: allow symbols to be edited in place. ADDED: Support to allow schematic symbols to be edited in place.
2020-08-31 15:06:23 +00:00
Unify IsSave and IsModify The flags and calls were used identically, leading to potential confusion/bugs. Testing for modification should go through IsContentModified()
2021-05-27 23:07:48 +00:00
bool SCH_EDIT_FRAME::IsContentModified() const
Unify unsaved changes detection logic in all frames Create an IsContentModified() function in each frame that provides if the content has been modified, and use that instead of always copying the checks.
2019-12-19 15:34:01 +00:00
{
Performance for large hierarchies: lookups Don't bother to sort sheet lists when we're just looking up a UUID, sheet count, other symbol units, etc.
2024-06-06 10:31:22 +00:00
return Schematic().GetUnorderedSheets().IsModified();
Unify unsaved changes detection logic in all frames Create an IsContentModified() function in each frame that provides if the content has been modified, and use that instead of always copying the checks.
2019-12-19 15:34:01 +00:00
}
Schematic editor: fix not working tool to show/hide invisible pins. Fixes #4222 https://gitlab.com/kicad/code/kicad/issues/4222
2020-04-18 07:57:04 +00:00
bool SCH_EDIT_FRAME::GetShowAllPins() const
{
EESCHEMA_SETTINGS* cfg = eeconfig();
Check before dereference Fixes a crash where the screen was destroyed during new loading but still gets dereferenced by the UI update. Also puts defensive checks in the UI conditions against null configuration settings
2021-09-28 15:41:46 +00:00
return cfg && cfg->m_Appearance.show_hidden_pins;
Schematic editor: fix not working tool to show/hide invisible pins. Fixes #4222 https://gitlab.com/kicad/code/kicad/issues/4222
2020-04-18 07:57:04 +00:00
}
Eeschema: remove automatic conversion of time stamp UUIDs. In order to avoid confusion when loading legacy schematics, updating time stamp UUIDs is no longer performed. If users where not experiencing issues with time stamp clashes with shared schematics then this was probably a case of me being overly cautious. The original conversion code has be moved to SCH_EDIT_FRAME::ConvertTimeStampUuids() so the working functionality is not lost. This function should not be used until a way is found to update the board from the schematics with the appropriate settings.
2020-05-07 13:26:43 +00:00
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
void SCH_EDIT_FRAME::FocusOnItem( SCH_ITEM* aItem )
{
static KIID lastBrightenedItemID( niluuid );
SCH_SHEET_PATH dummy;
Performance for large hierarchies: lookups Don't bother to sort sheet lists when we're just looking up a UUID, sheet count, other symbol units, etc.
2024-06-06 10:31:22 +00:00
SCH_ITEM* lastItem = Schematic().GetItem( lastBrightenedItemID, &dummy );
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
if( lastItem && lastItem != aItem )
{
lastItem->ClearBrightened();
Performance improvements for SchematicCleanup(). Fixes https://gitlab.com/kicad/code/kicad/issues/4563
2020-08-10 11:40:58 +00:00
UpdateItem( lastItem );
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
lastBrightenedItemID = niluuid;
}
if( aItem )
{
Cross-probing/selection for multiple items (PCB -> SCH) Fixes https://gitlab.com/kicad/code/kicad/issues/10469
2022-07-19 15:00:35 +00:00
if( !aItem->IsBrightened() )
{
aItem->SetBrightened();
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
Cross-probing/selection for multiple items (PCB -> SCH) Fixes https://gitlab.com/kicad/code/kicad/issues/10469
2022-07-19 15:00:35 +00:00
UpdateItem( aItem );
lastBrightenedItemID = aItem->m_Uuid;
}
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
FocusOnLocation( aItem->GetFocusPosition() );
}
}
Store the current filename in the history on close
2020-05-16 23:08:01 +00:00
wxString SCH_EDIT_FRAME::GetCurrentFileName() const
{
Move Eeschema globals to new SCHEMATIC object Set up a new lineage for SCH_ITEMS to get back to the SCHEMATIC they live on: Items will all be parented to the SCH_SCREEN that they are added to, and each SCH_SCREEN will point back to the SCHEMATIC that it is part of. Note that this hierarchy is not the same as the actual schematic hierarchy, which continues to be managed through SCH_SHEETs and SCH_SHEET_PATHS.
2020-05-13 02:00:37 +00:00
return Schematic().GetFileName();
Store the current filename in the history on close
2020-05-16 23:08:01 +00:00
}
Migrate eeschema, libview and libedit to the UI condition framework Also, fix some issues in other frames identified along the way.
2020-08-06 23:03:58 +00:00
SELECTION& SCH_EDIT_FRAME::GetCurrentSelection()
{
return m_toolManager->GetTool<EE_SELECTION_TOOL>()->GetSelection();
}
Fix initial zoom to fit size in schematic and board editors. This may affect other EDA_DRAW_FRAME objects as well but it doesn't seem to be as noticeable in the symbol, footprint, and worksheet editors. Fixes https://gitlab.com/kicad/code/kicad/issues/5248
2020-08-20 14:33:12 +00:00
void SCH_EDIT_FRAME::onSize( wxSizeEvent& aEvent )
{
if( IsShown() )
{
// We only need this until the frame is done resizing and the final client size is
// established.
Unbind( wxEVT_SIZE, &SCH_EDIT_FRAME::onSize, this );
Separate immediate and delayed action dispatch Using a boolean argument just leads to a lot of trailing booleans in the function calls and is not user friendly. Instead, introduce PostAction() to send an action that runs after the coroutine (equivalent to passing false or the default argument), and leave RunAction as the immediate execution function.
2023-06-26 22:16:51 +00:00
GetToolManager()->RunAction( ACTIONS::zoomFitScreen );
Fix initial zoom to fit size in schematic and board editors. This may affect other EDA_DRAW_FRAME objects as well but it doesn't seem to be as noticeable in the symbol, footprint, and worksheet editors. Fixes https://gitlab.com/kicad/code/kicad/issues/5248
2020-08-20 14:33:12 +00:00
}
// Skip() is called in the base class.
EDA_DRAW_FRAME::OnSize( aEvent );
}
Eeschema: allow symbols to be edited in place. ADDED: Support to allow schematic symbols to be edited in place.
2020-08-31 15:06:23 +00:00
Don't rely on selection when updating edited symbol in schematic. Fixes https://gitlab.com/kicad/code/kicad/issues/9600
2021-11-11 16:42:25 +00:00
void SCH_EDIT_FRAME::SaveSymbolToSchematic( const LIB_SYMBOL& aSymbol,
const KIID& aSchematicSymbolUUID )
Eeschema: allow symbols to be edited in place. ADDED: Support to allow schematic symbols to be edited in place.
2020-08-31 15:06:23 +00:00
{
Upgrade some symbol editor stuff to SCHEMATIC_COMMIT. Also renames SCHEMATIC_COMMIT to SCH_COMMIT since it's not schematic-specifc.
2023-06-09 21:41:33 +00:00
SCH_SHEET_PATH principalPath;
SCH_ITEM* item = Schematic().GetSheets().GetItem( aSchematicSymbolUUID, &principalPath );
SCH_SYMBOL* principalSymbol = dynamic_cast<SCH_SYMBOL*>( item );
SCH_COMMIT commit( m_toolManager );
Eeschema: allow symbols to be edited in place. ADDED: Support to allow schematic symbols to be edited in place.
2020-08-31 15:06:23 +00:00
Update all units when a schematic symbol is edited in the Symbol Editor. Fixes https://gitlab.com/kicad/code/kicad/issues/13208
2022-12-19 21:05:56 +00:00
if( !principalSymbol )
return;
Eeschema: allow symbols to be edited in place. ADDED: Support to allow schematic symbols to be edited in place.
2020-08-31 15:06:23 +00:00
Update all units when a schematic symbol is edited in the Symbol Editor. Fixes https://gitlab.com/kicad/code/kicad/issues/13208
2022-12-19 21:05:56 +00:00
wxString principalRef;
Eeschema: allow symbols to be edited in place. ADDED: Support to allow schematic symbols to be edited in place.
2020-08-31 15:06:23 +00:00
Update all units when a schematic symbol is edited in the Symbol Editor. Fixes https://gitlab.com/kicad/code/kicad/issues/13208
2022-12-19 21:05:56 +00:00
if( principalSymbol->IsAnnotated( &principalPath ) )
principalRef = principalSymbol->GetRef( &principalPath, false );
Eeschema: allow symbols to be edited in place. ADDED: Support to allow schematic symbols to be edited in place.
2020-08-31 15:06:23 +00:00
Upgrade a couple of schematic actions to SCHEMATIC_COMMIT.
2023-06-07 14:30:56 +00:00
std::vector< std::pair<SCH_SYMBOL*, SCH_SHEET_PATH> > allUnits;
Iterator safety. Fixes https://gitlab.com/kicad/code/kicad/issues/13341
2023-01-02 11:36:26 +00:00
Update all units when a schematic symbol is edited in the Symbol Editor. Fixes https://gitlab.com/kicad/code/kicad/issues/13208
2022-12-19 21:05:56 +00:00
for( const SCH_SHEET_PATH& path : Schematic().GetSheets() )
{
for( SCH_ITEM* candidate : path.LastScreen()->Items().OfType( SCH_SYMBOL_T ) )
Eeschema: allow symbols to be edited in place. ADDED: Support to allow schematic symbols to be edited in place.
2020-08-31 15:06:23 +00:00
{
Update all units when a schematic symbol is edited in the Symbol Editor. Fixes https://gitlab.com/kicad/code/kicad/issues/13208
2022-12-19 21:05:56 +00:00
SCH_SYMBOL* candidateSymbol = static_cast<SCH_SYMBOL*>( candidate );
Eeschema: allow symbols to be edited in place. ADDED: Support to allow schematic symbols to be edited in place.
2020-08-31 15:06:23 +00:00
Update all units when a schematic symbol is edited in the Symbol Editor. Fixes https://gitlab.com/kicad/code/kicad/issues/13208
2022-12-19 21:05:56 +00:00
if( candidateSymbol == principalSymbol
|| ( candidateSymbol->IsAnnotated( &path )
&& candidateSymbol->GetRef( &path, false ) == principalRef ) )
{
Upgrade a couple of schematic actions to SCHEMATIC_COMMIT.
2023-06-07 14:30:56 +00:00
allUnits.emplace_back( candidateSymbol, path );
Iterator safety. Fixes https://gitlab.com/kicad/code/kicad/issues/13341
2023-01-02 11:36:26 +00:00
}
}
}
Update all units when a schematic symbol is edited in the Symbol Editor. Fixes https://gitlab.com/kicad/code/kicad/issues/13208
2022-12-19 21:05:56 +00:00
Upgrade a couple of schematic actions to SCHEMATIC_COMMIT.
2023-06-07 14:30:56 +00:00
for( auto& [ unit, path ] : allUnits )
Iterator safety. Fixes https://gitlab.com/kicad/code/kicad/issues/13341
2023-01-02 11:36:26 +00:00
{
// This needs to be done before the LIB_SYMBOL is changed to prevent stale
// library symbols in the schematic file.
Upgrade a couple of schematic actions to SCHEMATIC_COMMIT.
2023-06-07 14:30:56 +00:00
path.LastScreen()->Remove( unit );
Update all units when a schematic symbol is edited in the Symbol Editor. Fixes https://gitlab.com/kicad/code/kicad/issues/13208
2022-12-19 21:05:56 +00:00
Upgrade a couple of schematic actions to SCHEMATIC_COMMIT.
2023-06-07 14:30:56 +00:00
if( !unit->IsNew() )
commit.Modify( unit, path.LastScreen() );
Iterator safety. Fixes https://gitlab.com/kicad/code/kicad/issues/13341
2023-01-02 11:36:26 +00:00
Upgrade a couple of schematic actions to SCHEMATIC_COMMIT.
2023-06-07 14:30:56 +00:00
unit->SetLibSymbol( aSymbol.Flatten().release() );
unit->UpdateFields( &GetCurrentSheet(),
Coding policy and Doxygen comment fixes.
2023-10-12 13:36:28 +00:00
true, /* update style */
true, /* update ref */
true, /* update other fields */
false, /* reset ref */
false /* reset other fields */ );
Iterator safety. Fixes https://gitlab.com/kicad/code/kicad/issues/13341
2023-01-02 11:36:26 +00:00
Upgrade a couple of schematic actions to SCHEMATIC_COMMIT.
2023-06-07 14:30:56 +00:00
path.LastScreen()->Append( unit );
GetCanvas()->GetView()->Update( unit );
Eeschema: allow symbols to be edited in place. ADDED: Support to allow schematic symbols to be edited in place.
2020-08-31 15:06:23 +00:00
}
Upgrade a couple of schematic actions to SCHEMATIC_COMMIT.
2023-06-07 14:30:56 +00:00
if( !commit.Empty() )
commit.Push( _( "Save Symbol to Schematic" ) );
Eeschema: allow symbols to be edited in place. ADDED: Support to allow schematic symbols to be edited in place.
2020-08-31 15:06:23 +00:00
}
Performance enhancements for fonts.
2022-01-07 17:42:43 +00:00
void SCH_EDIT_FRAME::UpdateItem( EDA_ITEM* aItem, bool isAddOrDelete, bool aUpdateRtree )
{
SCH_BASE_FRAME::UpdateItem( aItem, isAddOrDelete, aUpdateRtree );
if( SCH_ITEM* sch_item = dynamic_cast<SCH_ITEM*>( aItem ) )
sch_item->ClearCaches();
Schematic: new feature, force 45 degree lines * New modes to force 45 deg angle at beginning or end of line * Backspace will undo most recent segment added * / will toggle posture of 90 and 45 degree lines * Added alg::signbit for convenience Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10869 Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9175
2022-03-22 16:49:38 +00:00
}
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
void SCH_EDIT_FRAME::DisplayCurrentSheet()
{
Coverity fixes and code cleaning.
2023-03-06 12:12:11 +00:00
wxCHECK( m_toolManager, /* void */ );
Separate immediate and delayed action dispatch Using a boolean argument just leads to a lot of trailing booleans in the function calls and is not user friendly. Instead, introduce PostAction() to send an action that runs after the coroutine (equivalent to passing false or the default argument), and leave RunAction as the immediate execution function.
2023-06-26 22:16:51 +00:00
m_toolManager->RunAction( ACTIONS::cancelInteractive );
m_toolManager->RunAction( EE_ACTIONS::clearSelection );
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
SCH_SCREEN* screen = GetCurrentSheet().LastScreen();
Coverity fixes and code cleaning.
2023-03-06 12:12:11 +00:00
wxCHECK( screen, /* void */ );
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
Separate immediate and delayed action dispatch Using a boolean argument just leads to a lot of trailing booleans in the function calls and is not user friendly. Instead, introduce PostAction() to send an action that runs after the coroutine (equivalent to passing false or the default argument), and leave RunAction as the immediate execution function.
2023-06-26 22:16:51 +00:00
m_toolManager->RunAction( EE_ACTIONS::clearSelection );
Remove extra canvas redraws when changing sheets.
2023-03-05 01:33:07 +00:00
SCH_BASE_FRAME::SetScreen( screen );
Coverity fixes and code cleaning.
2023-03-06 12:12:11 +00:00
m_toolManager->ResetTools( TOOL_BASE::MODEL_RELOAD );
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
Make sure that current sheet's units and dangling states are correct. We used to store the symbol units of the current sheet and then restore them, but we didn't handle the dangling states. The new code uses a different strategy and just makes sure that if any of the sheets are going to modify the current screen, the current sheet gets to go last so that its modifications will "stick". Fixes https://gitlab.com/kicad/code/kicad/-/issues/15392
2023-10-26 12:06:59 +00:00
// update the references, units, and intersheet-refs
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
GetCurrentSheet().UpdateAllScreenReferences();
Make sure that current sheet's units and dangling states are correct. We used to store the symbol units of the current sheet and then restore them, but we didn't handle the dangling states. The new code uses a different strategy and just makes sure that if any of the sheets are going to modify the current screen, the current sheet gets to go last so that its modifications will "stick". Fixes https://gitlab.com/kicad/code/kicad/-/issues/15392
2023-10-26 12:06:59 +00:00
// dangling state can also have changed if different units with different pin locations are
// used
GetCurrentSheet().LastScreen()->TestDanglingEnds();
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
SetSheetNumberAndCount();
ADDED operating point overlay for SCH_EDIT_FRAME. Fixes https://gitlab.com/kicad/code/kicad/issues/11253
2023-02-09 17:18:56 +00:00
RefreshOperatingPointDisplay();
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
Update find status when switching sheets. (Not just when switching sheet during find.) Fixes https://gitlab.com/kicad/code/kicad/issues/13351
2023-01-02 18:43:35 +00:00
EE_SELECTION_TOOL* selectionTool = m_toolManager->GetTool<EE_SELECTION_TOOL>();
Coverity fixes and code cleaning.
2023-03-06 12:12:11 +00:00
wxCHECK( selectionTool, /* void */ );
Update find status when switching sheets. (Not just when switching sheet during find.) Fixes https://gitlab.com/kicad/code/kicad/issues/13351
2023-01-02 18:43:35 +00:00
auto visit =
[&]( EDA_ITEM* item )
{
if( m_findReplaceDialog
&& !m_findReplaceData->findString.IsEmpty()
&& item->Matches( *m_findReplaceData, &GetCurrentSheet() ) )
{
item->SetForceVisible( true );
selectionTool->BrightenItem( item );
}
else if( item->IsBrightened() )
{
item->SetForceVisible( false );
selectionTool->UnbrightenItem( item );
}
};
for( SCH_ITEM* item : screen->Items() )
{
visit( item );
item->RunOnChildren(
[&]( SCH_ITEM* aChild )
{
visit( aChild );
} );
}
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
if( !screen->m_zoomInitialized )
{
initScreenZoom();
}
else
{
// Set zoom to last used in this screen
GetCanvas()->GetView()->SetScale( GetScreen()->m_LastZoomLevel );
Remove extra canvas redraws when changing sheets.
2023-03-05 01:33:07 +00:00
GetCanvas()->GetView()->SetCenter( GetScreen()->m_ScrollCenter );
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
}
Fix naming of `updateTitle()` This is a private function so should be lowercased to avoid confusion
2023-01-12 00:05:43 +00:00
updateTitle();
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
HardRedraw(); // Ensure all items are redrawn (especially the drawing-sheet items)
Fix selection overlay being wiped when changing sheets
2023-02-16 22:14:08 +00:00
// Allow tools to re-add their VIEW_ITEMs after the last call to Clear in HardRedraw
m_toolManager->ResetTools( TOOL_BASE::MODEL_RELOAD );
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
SCH_EDITOR_CONTROL* editTool = m_toolManager->GetTool<SCH_EDITOR_CONTROL>();
Coverity fixes and code cleaning.
2023-03-06 12:12:11 +00:00
wxCHECK( editTool, /* void */ );
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
TOOL_EVENT dummy;
editTool->UpdateNetHighlighting( dummy );
m_hierarchy->UpdateHierarchySelection();
Schematic/Fields Table: handle sheet changes
2023-08-20 20:13:07 +00:00
m_schematic->OnSchSheetChanged();
Hierarchy: turn into a left side pane Drop auto-closing option as well.
2022-06-02 21:56:17 +00:00
}
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
DIALOG_BOOK_REPORTER* SCH_EDIT_FRAME::GetSymbolDiffDialog()
{
if( !m_diffSymbolDialog )
m_diffSymbolDialog = new DIALOG_BOOK_REPORTER( this, DIFF_SYMBOLS_DIALOG_NAME,
String and dialog layout fixes.
2023-12-13 16:07:09 +00:00
_( "Compare Symbol with Library" ) );
Fix mode-less dialog issues. Don't assume the dialog is mode-less and call Destroy() from within a dialog method. This will most assuredly crash if the dialog is shown modally or quasi-modally. Don't leak memory for mode-less dialogs created on the stack. Make sure when the parent frame window is closed that all mode-less dialog memory is cleaned up. Dialogs are not child windows like controls and toolbars so their memory does not automatically get cleaned up when the parent window is destroyed. Do not directly access frame parent window's pointer in dialog destructors. Apparently the tear down order when destroying mode-less dialogs is not guaranteed so the parent window may get deleted before the dialog causing a crash when accessing the parent window pointer from the dialog dtor. Do not close mode-less dialogs in the parent frame's destructor. This doesn't guarantee that the dialog(s) will be destroyed before the parent but it may reduce some careless mode-less dialog event handling in the future.
2023-03-13 16:03:48 +00:00
return m_diffSymbolDialog;
}
void SCH_EDIT_FRAME::onCloseSymbolDiffDialog( wxCommandEvent& aEvent )
{
if( m_diffSymbolDialog && aEvent.GetString() == DIFF_SYMBOLS_DIALOG_NAME )
{
m_diffSymbolDialog->Destroy();
m_diffSymbolDialog = nullptr;
}
}
DIALOG_ERC* SCH_EDIT_FRAME::GetErcDialog()
{
if( !m_ercDialog )
m_ercDialog = new DIALOG_ERC( this );
return m_ercDialog;
}
void SCH_EDIT_FRAME::onCloseErcDialog( wxCommandEvent& aEvent )
{
if( m_ercDialog )
{
m_ercDialog->Destroy();
m_ercDialog = nullptr;
}
}
Initial schematic search pane
2023-05-15 01:35:39 +00:00
Symbol Fields Table: make non-modal Fixes: https://gitlab.com/kicad/code/kicad/-/issues/2141
2023-08-14 14:41:28 +00:00
DIALOG_SYMBOL_FIELDS_TABLE* SCH_EDIT_FRAME::GetSymbolFieldsTableDialog()
{
if( !m_symbolFieldsTableDialog )
m_symbolFieldsTableDialog = new DIALOG_SYMBOL_FIELDS_TABLE( this );
return m_symbolFieldsTableDialog;
}
void SCH_EDIT_FRAME::onCloseSymbolFieldsTableDialog( wxCommandEvent& aEvent )
{
if( m_symbolFieldsTableDialog )
{
m_symbolFieldsTableDialog->Destroy();
m_symbolFieldsTableDialog = nullptr;
}
}
Initial schematic search pane
2023-05-15 01:35:39 +00:00
void SCH_EDIT_FRAME::AddSchematicChangeListener( wxEvtHandler* aListener )
{
auto it = std::find( m_schematicChangeListeners.begin(), m_schematicChangeListeners.end(),
aListener );
// Don't add duplicate listeners.
if( it == m_schematicChangeListeners.end() )
m_schematicChangeListeners.push_back( aListener );
}
void SCH_EDIT_FRAME::RemoveSchematicChangeListener( wxEvtHandler* aListener )
{
auto it = std::find( m_schematicChangeListeners.begin(), m_schematicChangeListeners.end(),
aListener );
// Don't add duplicate listeners.
if( it != m_schematicChangeListeners.end() )
m_schematicChangeListeners.erase( it );
Fix potential stale pointer bug in schematic highlight connection code. SCH_CONNECTION objects are temporary and can become stale any time the connectivity is updated. Keeping them around to reference later is a bad idea. Even if the object pointer is still valid in an SCH_ITEM in the undo/redo buffers, comparing the pointer against another pointer as a test to see if they are the same connection is not valid. Saving the connection name is safe and ensures the connection is the same even if the pointers differ.
2023-05-17 00:06:21 +00:00
}
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
wxTreeCtrl* SCH_EDIT_FRAME::createHighlightedNetNavigator()
{
m_netNavigator = new wxTreeCtrl( this, wxID_ANY, wxPoint( 0, 0 ),
FromDIP( wxSize( 160, 250 ) ),
wxTR_DEFAULT_STYLE | wxNO_BORDER );
return m_netNavigator;
}
Minor schematic net navigator improvements. - Expand tree and highlight object selected with net highlight tool. - Expand tree and highlight object that are currently highlighted with the selection tool. - Use more descriptive object text rather than menu entry text for tree strings. - Rebuild tree on unit changes.
2023-06-09 18:34:40 +00:00
void SCH_EDIT_FRAME::SetHighlightedConnection( const wxString& aConnection,
const NET_NAVIGATOR_ITEM_DATA* aSelection )
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
{
bool refreshNetNavigator = aConnection != m_highlightedConn;
m_highlightedConn = aConnection;
if( refreshNetNavigator )
Minor schematic net navigator improvements. - Expand tree and highlight object selected with net highlight tool. - Expand tree and highlight object that are currently highlighted with the selection tool. - Use more descriptive object text rather than menu entry text for tree strings. - Rebuild tree on unit changes.
2023-06-09 18:34:40 +00:00
RefreshNetNavigator( aSelection );
}
void SCH_EDIT_FRAME::unitsChangeRefresh()
{
Always refresh the navigator when changing units Units are displayed even if the net is not selected
2024-04-19 01:20:43 +00:00
if( m_netNavigator )
Minor schematic net navigator improvements. - Expand tree and highlight object selected with net highlight tool. - Expand tree and highlight object that are currently highlighted with the selection tool. - Use more descriptive object text rather than menu entry text for tree strings. - Rebuild tree on unit changes.
2023-06-09 18:34:40 +00:00
{
NET_NAVIGATOR_ITEM_DATA itemData;
wxTreeItemId selection = m_netNavigator->GetSelection();
bool refreshSelection = selection.IsOk() && ( selection != m_netNavigator->GetRootItem() );
if( refreshSelection )
{
NET_NAVIGATOR_ITEM_DATA* tmp =
dynamic_cast<NET_NAVIGATOR_ITEM_DATA*>( m_netNavigator->GetItemData( selection ) );
wxCHECK( tmp, /* void */ );
itemData = *tmp;
}
m_netNavigator->DeleteAllItems();
RefreshNetNavigator( refreshSelection ? &itemData : nullptr );
}
ADDED: Properties panel for schematic editor Initial infrastructure work; follow-ons will add more properties for schematic items. Fixes https://gitlab.com/kicad/code/kicad/-/issues/6351 Fixes https://gitlab.com/kicad/code/kicad/-/issues/14105
2023-06-21 01:57:20 +00:00
UpdateProperties();
Add net navigator panel to schematic editor. [ADDED]: A panel to the schematic editor that allows quick access to all of the items connected to the currently highlighted net. This is an initial swag at implementing a full net navigator feature. For now it only shows the currently highlighted net nodes. The incremental net list advanced setting must be enabled in order to use this feature due to performance reasons. There are still some issues with saving the panel position which will be addressed in the future. Initial code for serializing wxAuiPaneInfo settings to and from JSON have be implemented.
2023-05-20 17:47:12 +00:00
}
ADDED: Selection filter for schematic editor Fixes https://gitlab.com/kicad/code/kicad/-/issues/14988
2024-02-25 22:39:14 +00:00
void SCH_EDIT_FRAME::updateSelectionFilterVisbility()
{
wxAuiPaneInfo& hierarchyPane = m_auimgr.GetPane( SchematicHierarchyPaneName() );
wxAuiPaneInfo& netNavigatorPane = m_auimgr.GetPane( NetNavigatorPaneName() );
wxAuiPaneInfo& propertiesPane = m_auimgr.GetPane( PropertiesPaneName() );
wxAuiPaneInfo& selectionFilterPane = m_auimgr.GetPane( wxS( "SelectionFilter" ) );
// Don't give the selection filter its own visibility controls; instead show it if
// anything else is visible
bool showFilter = ( hierarchyPane.IsShown() && hierarchyPane.IsDocked() )
|| ( netNavigatorPane.IsShown() && netNavigatorPane.IsDocked() )
|| ( propertiesPane.IsShown() && propertiesPane.IsDocked() );
selectionFilterPane.Show( showFilter );
}