d75329b6f1
Quote BOM executable for spaces
2022-02-09 10:53:09 -08:00
861589d837
Use wxEmptyString instead of wxT( "" )
...
Also fixes places where ternaries did autopromotion instead of returning
an empty wxString
2022-02-09 10:33:52 -08:00
a444addd89
Default eeschema strings to wide
...
Prevents stack bug on MacOS
2022-02-08 15:14:54 -08:00
4657614e4f
More wxString wide literals.
2022-02-04 23:12:09 +00:00
50d3a507d0
Mark some limits as constexpr
...
gcc doesn't need it and computes during compile regardless, but experimenting in godbolt, both clang and MSVC actually do need it or else it's partially computed at runtime
(cherry picked from commit ca7840334c
2022-02-04 12:50:54 +00:00
7642a9db79
Setup selection when repeating
...
We need the item to be currently selected when repeating the last symbol
insert. This ensures we have a valid selection before starting the move
tool and possibly getting odd system behavior from mouse positions
Fixes https://gitlab.com/kicad/code/kicad/issues/10619
2022-02-03 17:09:31 -08:00
69b69aa431
Update text variables when they change.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10734
2022-02-04 00:34:20 +00:00
ccf2a63f45
When undoing creation of the sheet, get out first
...
We can't stay in a sheet that is deleted by the action of undo. Checks
the current sheet and, if we are currently using it, ensures that the
following action is to leave the current sheet
Fixes https://gitlab.com/kicad/code/kicad/issues/10733
2022-02-03 11:19:33 -08:00
0ffa266315
DIALOG_SPICE_MODEL: fix a cosmetic issue (no room for the help text)
...
Fixes #10170
https://gitlab.com/kicad/code/kicad/issues/10170
(cherry picked from commit 7c3f0612f1
2022-02-03 15:01:04 +00:00
fecb625459
Resolve text variables in eeschema before passing to pcbnew.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10429
(cherry picked from commit 2b14b60c32
2022-02-03 15:00:39 +00:00
01f3a14dc3
Allow more (lots more) unfold from bus menu entries.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10529
(cherry picked from commit 4665cdcdc5
2022-02-03 15:00:39 +00:00
70d00689ca
Fully select a line for transformation
...
When not trying to select points, we need to ensure that the full
line is selected for transformation
Fixes https://gitlab.com/kicad/code/kicad/issues/10566
2022-01-29 17:36:54 -08:00
fddfce4fb1
Force a size event to avoid multiple yields
...
When the grid editor is shown, we also want to ensure that the grid gets
resized to account for the new editor. Queuing the event will ensure
that happens after the editor is emplaced in the grid
Fixes https://gitlab.com/kicad/code/kicad/issues/5690
2022-01-24 15:31:45 -08:00
a1615cce7e
Enforce strictly weak ordering in sheets
...
This ensures that irreflexivity is given in sort ordering. This may
have been triggering issues in MacOS when adding sheets
Fixes https://gitlab.com/kicad/code/kicad/issues/10557
2022-01-24 10:41:02 -08:00
871556ebda
Allow time to update editor
...
On GTK, the full editor needs to be shown and, for some systems, the
editor will not show correctly. By yielding we should allow the time to
recalculate sizes for the editor in the grid
Fixes https://gitlab.com/kicad/code/kicad/issues/5690
2022-01-24 09:55:46 -08:00
f12d0cb0e2
Get all eeschema layers properly ordered
...
Layers not in the given order are drawn behind everyone else. Missing
the text prevents global labels from showing properly in GAL order
Fixes https://gitlab.com/kicad/code/kicad/issues/10546
2022-01-23 10:03:03 -08:00
029e42f8d1
DIALOG_SIM_SETTINGS: fix incorrect validation of DC souces in DC Transfer panel
...
From Master branch
Fixes #10568
https://gitlab.com/kicad/code/kicad/issues/10568
2022-01-23 17:01:55 +01:00
e9a5e5466c
SYMBOL_VIEWER_FRAME: fix refresh of the canvas after selecting a new symbol.
...
From Master branch
2022-01-21 17:34:51 +01:00
323a069738
Clear Undo list when renaming
...
Our undo/redo list is tied to the screen that gets cleared when we
reload the file after renaming. We need to clear the Undo list at this
point to prevent possible crashes when moving too far back in the stack
Fixes https://gitlab.com/kicad/code/kicad/issues/10504
2022-01-20 11:28:41 -08:00
615eda816e
Don't close filled polylines when printing
...
Eeschema/libedit support open, filled polylines. When printing, this
should be drawn as a fill, followed by the polyline to avoid assumptions
about closed polygons in the graphic code
Fixes https://gitlab.com/kicad/code/kicad/issues/10537
2022-01-20 10:53:57 -08:00
dcb8f29317
Handle rotated symbol rectangles in Eagle import
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10360
2022-01-12 15:10:42 -08:00
57d58fe335
Handle Unicode clipboard data in pcbnew and symbol editor
...
Fixes #10323
(cherry picked from commit 8373180cbb
2022-01-12 09:23:24 -08:00
56d87a8613
Catch default autowire case
...
Since we are dereferencing the optional, we need to ensure it exists in
all cases
Fixes https://gitlab.com/kicad/code/kicad/issues/10394
2022-01-12 09:02:39 -08:00
55020c2b89
Better fix for missing end segment
...
Rather than skipping our endEdit() call in libedit, we need to
parameterize whether we want the shape open/closed. Closed will remove
the last segment if it lands on the first point. We don't want that
but we do want to remove the last point if it duplicates the second to
last (in the case of double-clicking)
Fixes https://gitlab.com/kicad/code/kicad/issues/10334
2022-01-10 13:37:47 -08:00
62f8603353
Don't deduplicate symbol polygons
...
SHAPE_LINE_CHAIN will, by default, remove duplicate points when
appending. We don't want to do this when constructing our polygons in
symbol editor, so we need to explicitly call the routine without
deduplication
Fixes https://gitlab.com/kicad/code/kicad/issues/10289
2022-01-07 08:25:09 -08:00
9a2332dfcf
Clear edited point when exiting tool
...
When leaving the main point editor loop, we need to ensure that the edit
point is cleared as well. This is usually cleared by a ClearEvent call
but in case this is missed, we need to ensure that other tools are not
caught out
Fixes https://gitlab.com/kicad/code/kicad/issues/10288
2022-01-07 08:23:31 -08:00
3069b198b1
PANEL_TEMPLATE_FIELDNAMES: fix incorrect management of boolean options
...
(it was impossible to disable them)
From Master branch.
Fixes https://gitlab.com/kicad/code/kicad/issues/10280
2022-01-06 19:44:23 +01:00
71e7b4b77b
Use 'special' escaping for certain fields
...
Most fields are escaped using the `\` notation. But the VALUE field and
the symbol name need to be escaped using braces notation.
Fixes https://gitlab.com/kicad/code/kicad/issues/10097
2022-01-05 17:18:39 -08:00
b8a7a66a0a
Keep symbol synced with edit tool
...
Undo/Redo can change the symbol referenced by the symbol drawing tool.
This updates the current symbol before important steps to keep the
system synced
Fixes https://gitlab.com/kicad/code/kicad/issues/10125
2022-01-05 16:51:41 -08:00
55087a9e82
Don't remove last point in libedit
...
SHAPE_LINE_CHAIN in libedit doesn't make a polygon, so we always need
the last point and it shouldn't be closed
Fixes https://gitlab.com/kicad/code/kicad/issues/9934
2022-01-05 16:02:50 -08:00
7afe188a29
eeschema: automatic generated symbol library from EAGLE plugin does not include footprint reference
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10262
(cherry picked from commit 3ced3afa68
2022-01-05 15:28:05 -05:00
d60e77176f
eeschema: EAGLE plugin does not reference footprint with library suffix
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10261
(cherry picked from commit 502e34349e
2022-01-05 14:39:43 -05:00
7f1648934f
Update pin cache when undoing
...
The pin cache is invalidated by swap, so we need to ensure that it is
reset when we undo a change to the pins in schematic editor
Fixes https://gitlab.com/kicad/code/kicad/issues/10272
2022-01-05 11:33:03 -08:00
bef762e652
Don't strip extensions twice in BOM export
...
Exporting the Bill of Materials uses the netlist exporter. Both of
these routines were stripping the extension, leading to projects like
"test.project.kicad_pro" having the project name stripped. We separate
the BOM netlist export from generic plugin netlist export to allow the
correct behavior when exporting netlists and generating BOMs
Fixes https://gitlab.com/kicad/code/kicad/issues/10270
2022-01-05 11:07:23 -08:00
a05ec04ee8
Set readable flags correctly on open
...
Missing files may be thrown during open. These should have existence
and readable flags set correctly
2022-01-05 09:54:10 -08:00
b1658fdf9a
Don't rename existing schematic file
...
We should never leave a situation where the schematic file may no longer
exist (if the first rename succeeds and the second fails). So, make a
backup copy of the original schematic file and then attempt to rename
the autosave over the first file. In this case, if either attempt
fails, we do not lose the original file
Fixes https://gitlab.com/kicad/code/kicad/issues/10074
Fixes https://gitlab.com/kicad/code/kicad/issues/10256
Fixes https://gitlab.com/kicad/code/kicad/issues/10219
2022-01-04 20:27:43 -08:00
a326d777f0
Don't split legacy paths
...
The '.' is a valid character in the legacy preferences, not a separator.
Also adds fail-safe catch for JSON throws
Fixes https://gitlab.com/kicad/code/kicad/issues/10211
2022-01-04 19:08:12 +00:00
5e884d14c7
Rename ComparePageNumAndName -> ComparePageNum
2022-01-02 23:27:15 +00:00
ea99c42df6
Move duplicate field handling into field parser
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10130
2022-01-02 13:19:31 -05:00
addc5574b4
Ensure merged line gets selected if either parent is
...
We were only checking for the selection of a single line that gets
merged. This prevents the merged line from being highlighted but not
selected after merging
Fixes https://gitlab.com/kicad/code/kicad/issues/10202
2022-01-01 16:53:31 -08:00
6fd93eaa1e
Silence MSVC warnings about type mismatch and unused var
...
(cherry picked from commit 34e90e5045
2022-01-01 19:50:11 +00:00
cf8c614a02
Use virtual page number when real page numbers are blank
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10158
(cherry picked from commit a0d708e04d
2022-01-01 18:39:49 +00:00
e19acb4632
Correctly handle excluding an ERC marker in eeschema when right clicking
...
In addition, hide the option to exclude a marker if the selected marker
is already excluded.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10173
(cherry picked from commit 701e256b3f
2021-12-30 17:16:04 +00:00
67fe8904c0
Add win32 VERSION_INFO resource blocks for the DLLs
...
(cherry picked from commit 3f711b8958
2021-12-29 04:56:26 +00:00
b80595903c
Eeschema: draw dangling end shadows
...
(cherry picked from commit bf2c4c1584
2021-12-28 16:10:40 -08:00
32be48222a
Fix parent of schematic setup parent nodes
...
(cherry picked from commit 705aa64c24
2021-12-28 01:16:18 +00:00
e7cc177d94
Allow a 0 pin-symbol-size.
...
This is particularly important when reading legacy projects as 0 is
what signals the painter to use the old algorithm (1/2 pin name/number
size).
Fixes https://gitlab.com/kicad/code/kicad/issues/10100
(cherry picked from commit f089cf44a7
2021-12-23 17:01:48 +00:00
ad583eab13
Add hot-updating of units in common wxGrids.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10020
(cherry picked from commit 6e2460ad37
2021-12-23 17:01:34 +00:00
76fd029cd6
Don't leave stranded symbols/footprints in editors when doc closes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10026
(cherry picked from commit 9af33cdfe8
2021-12-23 17:01:25 +00:00
2efa878287
Use a bigger hammer to update adjacent segments.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9927
(cherry picked from commit ee5db73113
2021-12-23 17:01:22 +00:00
34d855cd53
Make sure undo/redo of pagesetup is done to correct sheet.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9999
(cherry picked from commit aa4dcb2bf1
2021-12-23 17:01:15 +00:00
9cb36e5bc5
Restore units to a bunch of wxGrids.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10063
(cherry picked from commit 8b52e969d6
2021-12-23 17:01:10 +00:00
160328abc7
Fix arc printing for flipped shapes.
2021-12-20 18:07:27 +00:00
f2ad8bffe0
Fix a mistake in Altium parser
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10011
2021-12-16 05:49:39 +03:00
40d44c94cd
Fix single-threaded loads/connectivity
...
We cannot set thread counts to hardware_concurrency()-1 without
considering that single core machines will get a thread count of 0.
2021-12-14 17:18:46 -08:00
1ca90f31bf
Fix hidden column in DIALOG_SYMBOL_FIELDS_TABLE.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9987
2021-12-15 00:03:33 +00:00
2dbc6ef6ca
If present, tune Spice_Model instead of Value
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9880
2021-12-14 14:02:25 +01:00
4fd5c9cfa8
Adjust macOS BOM plugin Python path
2021-12-13 22:52:31 +00:00
5e2ca2aa2a
Install kicad_utils.py BOM plugin helper
2021-12-13 22:52:31 +00:00
755607b8f8
Fix a few wxUpdateUIEvent retrigger loops.
2021-12-13 15:46:13 -05:00
653c7b78d7
Move NC pin logic so we set it before we need it.
...
Also fixes drawing the dangling symbol in the Pin Properties dialog
and when printing.
Fixes https://gitlab.com/kicad/code/kicad/issues/9962
2021-12-12 22:25:36 +00:00
067fa65756
Eeschema: fix a multitude of LIB_FIELD object comparison and index bugs.
...
It is no longer acceptable to set a LIB_FIELD index to -1. This was
trashing the sorting on load cause all kinds of false field comparison
failures. There are now assertions when attempting to use -1 as a field
index.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9811
2021-12-12 17:06:32 -05:00
4ccfc21324
Fix event id intersections when toggling some columns via popup.
...
Also increases maximum show/hide column count to 50.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9765
2021-12-13 00:35:44 +03:00
885979ba75
Fix selection logic to handle LIB_ITEM as well as SCH_ITEM.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9954
2021-12-12 17:38:38 +00:00
88fc6d25a7
Correctly handle deleting multiple selections in some grids.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9952
2021-12-12 17:28:17 +00:00
d1e6c216e1
And the modify bit wasn't getting set either.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9926
2021-12-11 01:09:13 +00:00
15d1abeeef
Sigh. But addCorner() *does* need mapCoords().
...
And it's got an off-by-one error in it too. I don't think this
ever worked at all.
Fixes https://gitlab.com/kicad/code/kicad/issues/9926
2021-12-11 01:06:36 +00:00
1f126c5619
Hittesting already handles inverse coordinate system.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9926
2021-12-11 00:32:24 +00:00
91dace3e5e
Update Eagle importer
...
Fixes arc orientation
Sets root schematic and page numbers
Fixes https://gitlab.com/kicad/code/kicad/issues/9907
2021-12-10 15:41:25 -08:00
8c5dd46861
Undo for SCH add/remove corner.
...
(PCB_POINT_EDITOR uses a BOARD_COMMIT and so already handles undo.)
Fixes https://gitlab.com/kicad/code/kicad/issues/9925
2021-12-10 23:08:16 +00:00
1b2a278de9
Don't put "exclude from board" symbols in CvPCB netlist.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9939
2021-12-10 23:00:50 +00:00
65cbf2d2b7
Eeschema: fix draw issue for global labels in Cairo mode.
...
Fixes #9933
https://gitlab.com/kicad/code/kicad/issues/9933
2021-12-10 20:47:17 +01:00
0ad0627bb0
Overhaul drag-select logic to handle children better.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6662
2021-12-10 18:44:07 +00:00
4f60d7ac78
Don't use lib tree target if lib tree isn't shown.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9913
2021-12-10 00:34:22 +00:00
832eb0d019
Fix off-by-one error in grid snapping.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9013
2021-12-09 16:35:11 +00:00
af280f80e0
Fix debug assertion in Altium and CADSTAR schematic importers.
2021-12-09 12:56:03 +00:00
b7af66e3f9
Eeschema: fix broken page numbers when renaming a sheet file name.
...
Always use full sheet paths when storing sheet instances. Partial sheet
paths cannot be full resolved resulting in lost page numbers when renaming
sheet file name.
Fixes #9782
2021-12-09 12:56:03 +00:00
f7fb756f78
All imported schematics need connectivity update
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9907
2021-12-08 16:27:24 -08:00
9c619d8f4e
Allow some navigation tools when selecting
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9565
2021-12-07 23:00:39 +00:00
3d97138d92
Bug fix for dangling symbols on pins.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9667
2021-12-07 21:39:06 +00:00
c4336de868
Bug fixes in new dangling symbol drawing code.
2021-12-07 21:31:42 +00:00
84cdc9701f
Partially reverts d877f041
...
Based on discussion in https://gitlab.com/kicad/code/kicad/-/merge_requests/1029
we will keep the original behavior. The new routines to get stock paths
are still useful (possibly in scripting) and are kept
2021-12-06 16:14:40 -08:00
73b39e836d
Set modify bit when editing page layout.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9891
2021-12-06 23:08:33 +00:00
2e342ed8c9
Draw dangling symbols on a separate layer.
...
This allows us to draw them in front of wires, pins, and most
importantly, junction dots.
Fixes https://gitlab.com/kicad/code/kicad/issues/9667
2021-12-06 18:50:50 +00:00
a03e6e4926
Revert "Eeschema: fix broken page numbers when renaming a sheet file name."
...
This reverts commit a468a79948
2021-12-06 07:47:18 -05:00
5ae844ba93
Revert "Fix SCH_SHEET object assignment operator bug."
...
This reverts commit 37d53a7147
2021-12-06 07:47:02 -05:00
a205595404
PROF_COUNTER -> PROF_TIMER
...
I want to add an event counter, and this one is a timer
2021-12-05 14:25:37 -05:00
10be483430
Make an exception for SCH_TEXT in SELECTION::GetCenter()
...
And undo the previous changes in SCH_TEXT::Rotate().
We continue hitting this with a wrench until it gets fixed or becomes
broken beyond any recognition.
2021-12-04 05:32:48 +01:00
cb482eb8eb
Symbol Fields Table: Highlight proper symbols even if they aren't annotated
2021-12-03 20:35:54 +00:00
9efbeaa064
Dark theme support for SPICE model editor
2021-12-03 03:41:32 +01:00
83162364e7
Restore old rotation behavior for SCH_LABEL
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9861
2021-12-03 01:43:02 +01:00
d877f04198
fixe paths
2021-12-02 20:23:00 +00:00
863699f2d1
Fix logic error in selection tool.
...
Any new selection made by clicking is not a hover selection.
Fixes https://gitlab.com/kicad/code/kicad/issues/9857
2021-12-02 16:56:47 +00:00
4ba110e1ec
Restore original SCH_TEXT::GetBoundingBox()
...
Didn't intend to commit this, it was a mistake.
2021-12-02 16:43:19 +01:00
bb08ef2f41
Fix SCH_TEXT rotation around a reference point
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9690
2021-12-02 16:35:35 +01:00
50c1a91d44
Add a simple open wrapper for the bom python plugins to handle directory creation
2021-12-02 01:07:55 -05:00
3960c2441b
Snap rotation center to half-grid, not grid
2021-12-01 17:53:42 +01:00
9f568d3658
Eeschema: Add support for leading zeroes when auto-incrementing names ( fixes #9831 )
2021-12-01 13:20:35 +00:00
37d53a7147
Fix SCH_SHEET object assignment operator bug.
2021-12-01 07:19:30 -05:00
3a00d76207
Fix a compil warning (shadowed var) and add a comment.
2021-12-01 11:05:16 +01:00
Seth Hillbrand
Jeff Young
Marek Roszko
jean-pierre charras
dana
Steffen Mauch
Roberto Fernandez Bautista
Jon Evans
Mike Williams
dsa-t
Mikolaj Wielgus
Adam Wolf
Wayne Stambaugh
Franck Bourdonnec
kliment