Jeff Young
34d855cd53
Make sure undo/redo of pagesetup is done to correct sheet.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9999
(cherry picked from commit aa4dcb2bf1
)
2021-12-23 17:01:15 +00:00
Jeff Young
9cb36e5bc5
Restore units to a bunch of wxGrids.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10063
(cherry picked from commit 8b52e969d6
)
2021-12-23 17:01:10 +00:00
Jeff Young
160328abc7
Fix arc printing for flipped shapes.
2021-12-20 18:07:27 +00:00
dsa-t
f2ad8bffe0
Fix a mistake in Altium parser
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/10011
2021-12-16 05:49:39 +03:00
Seth Hillbrand
40d44c94cd
Fix single-threaded loads/connectivity
...
We cannot set thread counts to hardware_concurrency()-1 without
considering that single core machines will get a thread count of 0.
2021-12-14 17:18:46 -08:00
Jeff Young
1ca90f31bf
Fix hidden column in DIALOG_SYMBOL_FIELDS_TABLE.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9987
2021-12-15 00:03:33 +00:00
Mikolaj Wielgus
2dbc6ef6ca
If present, tune Spice_Model instead of Value
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9880
2021-12-14 14:02:25 +01:00
Adam Wolf
4fd5c9cfa8
Adjust macOS BOM plugin Python path
2021-12-13 22:52:31 +00:00
Adam Wolf
5e2ca2aa2a
Install kicad_utils.py BOM plugin helper
2021-12-13 22:52:31 +00:00
Wayne Stambaugh
755607b8f8
Fix a few wxUpdateUIEvent retrigger loops.
2021-12-13 15:46:13 -05:00
Jeff Young
653c7b78d7
Move NC pin logic so we set it before we need it.
...
Also fixes drawing the dangling symbol in the Pin Properties dialog
and when printing.
Fixes https://gitlab.com/kicad/code/kicad/issues/9962
2021-12-12 22:25:36 +00:00
Wayne Stambaugh
067fa65756
Eeschema: fix a multitude of LIB_FIELD object comparison and index bugs.
...
It is no longer acceptable to set a LIB_FIELD index to -1. This was
trashing the sorting on load cause all kinds of false field comparison
failures. There are now assertions when attempting to use -1 as a field
index.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9811
2021-12-12 17:06:32 -05:00
dsa-t
4ccfc21324
Fix event id intersections when toggling some columns via popup.
...
Also increases maximum show/hide column count to 50.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9765
2021-12-13 00:35:44 +03:00
Jeff Young
885979ba75
Fix selection logic to handle LIB_ITEM as well as SCH_ITEM.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9954
2021-12-12 17:38:38 +00:00
Jeff Young
88fc6d25a7
Correctly handle deleting multiple selections in some grids.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9952
2021-12-12 17:28:17 +00:00
Jeff Young
d1e6c216e1
And the modify bit wasn't getting set either.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9926
2021-12-11 01:09:13 +00:00
Jeff Young
15d1abeeef
Sigh. But addCorner() *does* need mapCoords().
...
And it's got an off-by-one error in it too. I don't think this
ever worked at all.
Fixes https://gitlab.com/kicad/code/kicad/issues/9926
2021-12-11 01:06:36 +00:00
Jeff Young
1f126c5619
Hittesting already handles inverse coordinate system.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9926
2021-12-11 00:32:24 +00:00
Seth Hillbrand
91dace3e5e
Update Eagle importer
...
Fixes arc orientation
Sets root schematic and page numbers
Fixes https://gitlab.com/kicad/code/kicad/issues/9907
2021-12-10 15:41:25 -08:00
Jeff Young
8c5dd46861
Undo for SCH add/remove corner.
...
(PCB_POINT_EDITOR uses a BOARD_COMMIT and so already handles undo.)
Fixes https://gitlab.com/kicad/code/kicad/issues/9925
2021-12-10 23:08:16 +00:00
Jeff Young
1b2a278de9
Don't put "exclude from board" symbols in CvPCB netlist.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9939
2021-12-10 23:00:50 +00:00
jean-pierre charras
65cbf2d2b7
Eeschema: fix draw issue for global labels in Cairo mode.
...
Fixes #9933
https://gitlab.com/kicad/code/kicad/issues/9933
2021-12-10 20:47:17 +01:00
Jeff Young
0ad0627bb0
Overhaul drag-select logic to handle children better.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/6662
2021-12-10 18:44:07 +00:00
Jeff Young
4f60d7ac78
Don't use lib tree target if lib tree isn't shown.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9913
2021-12-10 00:34:22 +00:00
Jeff Young
832eb0d019
Fix off-by-one error in grid snapping.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9013
2021-12-09 16:35:11 +00:00
Wayne Stambaugh
af280f80e0
Fix debug assertion in Altium and CADSTAR schematic importers.
2021-12-09 12:56:03 +00:00
Wayne Stambaugh
b7af66e3f9
Eeschema: fix broken page numbers when renaming a sheet file name.
...
Always use full sheet paths when storing sheet instances. Partial sheet
paths cannot be full resolved resulting in lost page numbers when renaming
sheet file name.
Fixes #9782
2021-12-09 12:56:03 +00:00
Seth Hillbrand
f7fb756f78
All imported schematics need connectivity update
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9907
2021-12-08 16:27:24 -08:00
dsa-t
9c619d8f4e
Allow some navigation tools when selecting
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9565
2021-12-07 23:00:39 +00:00
Jeff Young
3d97138d92
Bug fix for dangling symbols on pins.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9667
2021-12-07 21:39:06 +00:00
Jeff Young
c4336de868
Bug fixes in new dangling symbol drawing code.
2021-12-07 21:31:42 +00:00
Seth Hillbrand
84cdc9701f
Partially reverts d877f041
...
Based on discussion in https://gitlab.com/kicad/code/kicad/-/merge_requests/1029
we will keep the original behavior. The new routines to get stock paths
are still useful (possibly in scripting) and are kept
2021-12-06 16:14:40 -08:00
Jeff Young
73b39e836d
Set modify bit when editing page layout.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9891
2021-12-06 23:08:33 +00:00
Jeff Young
2e342ed8c9
Draw dangling symbols on a separate layer.
...
This allows us to draw them in front of wires, pins, and most
importantly, junction dots.
Fixes https://gitlab.com/kicad/code/kicad/issues/9667
2021-12-06 18:50:50 +00:00
Wayne Stambaugh
a03e6e4926
Revert "Eeschema: fix broken page numbers when renaming a sheet file name."
...
This reverts commit a468a79948
.
2021-12-06 07:47:18 -05:00
Wayne Stambaugh
5ae844ba93
Revert "Fix SCH_SHEET object assignment operator bug."
...
This reverts commit 37d53a7147
.
2021-12-06 07:47:02 -05:00
Jon Evans
a205595404
PROF_COUNTER -> PROF_TIMER
...
I want to add an event counter, and this one is a timer
2021-12-05 14:25:37 -05:00
Mikolaj Wielgus
10be483430
Make an exception for SCH_TEXT in SELECTION::GetCenter()
...
And undo the previous changes in SCH_TEXT::Rotate().
We continue hitting this with a wrench until it gets fixed or becomes
broken beyond any recognition.
2021-12-04 05:32:48 +01:00
dsa-t
cb482eb8eb
Symbol Fields Table: Highlight proper symbols even if they aren't annotated
2021-12-03 20:35:54 +00:00
Mikolaj Wielgus
9efbeaa064
Dark theme support for SPICE model editor
2021-12-03 03:41:32 +01:00
Mikolaj Wielgus
83162364e7
Restore old rotation behavior for SCH_LABEL
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9861
2021-12-03 01:43:02 +01:00
Franck Bourdonnec
d877f04198
fixe paths
2021-12-02 20:23:00 +00:00
Jeff Young
863699f2d1
Fix logic error in selection tool.
...
Any new selection made by clicking is not a hover selection.
Fixes https://gitlab.com/kicad/code/kicad/issues/9857
2021-12-02 16:56:47 +00:00
Mikolaj Wielgus
4ba110e1ec
Restore original SCH_TEXT::GetBoundingBox()
...
Didn't intend to commit this, it was a mistake.
2021-12-02 16:43:19 +01:00
Mikolaj Wielgus
bb08ef2f41
Fix SCH_TEXT rotation around a reference point
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9690
2021-12-02 16:35:35 +01:00
Marek Roszko
50c1a91d44
Add a simple open wrapper for the bom python plugins to handle directory creation
2021-12-02 01:07:55 -05:00
Mikolaj Wielgus
3960c2441b
Snap rotation center to half-grid, not grid
2021-12-01 17:53:42 +01:00
kliment
9f568d3658
Eeschema: Add support for leading zeroes when auto-incrementing names ( fixes #9831 )
2021-12-01 13:20:35 +00:00
Wayne Stambaugh
37d53a7147
Fix SCH_SHEET object assignment operator bug.
2021-12-01 07:19:30 -05:00
jean-pierre charras
3a00d76207
Fix a compil warning (shadowed var) and add a comment.
2021-12-01 11:05:16 +01:00
dsa-t
bfe595819a
Prevent error when loading bitmaps from some old schematics
2021-12-01 09:54:48 +00:00
Ian McInerney
6d8642e44c
Remove default settings missed in 025d9f82ea
2021-12-01 01:59:40 +00:00
Seth Hillbrand
85ab4e5886
Don't deselect wires when aligning
...
This makes undo/redo look really strange as the other elements get
aligned but the wires do not (or rather their unconnected ends do not)
Fixes https://gitlab.com/kicad/code/kicad/issues/9275
2021-11-30 16:30:28 -08:00
Wayne Stambaugh
a468a79948
Eeschema: fix broken page numbers when renaming a sheet file name.
...
Remove duplicate instance data saved in both root SCH_SCREEN and SCH_SHEET
objects that was causing them to be out of sync. All sheet instance data
is stored in the SCH_SHEET object itself and rebuilt on the fly so it is
always current.
Remove Get/SetPageNumber from SCH_SHEET_PATH object so it doesn't obfuscate
where the actual sheet page number information exists.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9782
2021-11-30 08:11:24 -05:00
dsa-t
5750e38102
Re-enable and fix Move+Autoplace Fields
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9766
2021-11-29 20:48:16 +00:00
Jeff Young
a0711bdb56
Keep previous commit from violating string freeze.
2021-11-29 20:09:35 +00:00
Jeff Young
78be5df39a
Don't allow negative line widths to shrink bounding box.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9776
2021-11-29 20:02:03 +00:00
Jeff Young
a0f1d77eaa
Quiet wxWidgets assert.
2021-11-29 18:54:47 +00:00
jean-pierre charras
91363dd93c
PANEL_EESCHEMA_COLOR_SETTINGS: fix a minor cosmetic issue.
2021-11-29 15:30:38 +01:00
Jeff Young
3a51fb6ac6
Be more consistent about annotation warngings.
...
This can be a particular problem if you go to run ERC, it shows the
annotation warnging so you re-annotate (but don't notice that your
scope is set to Selection).
Also adds some missing defensive code around closing a modeless RC
checker before the document (which we had for DRC dialog but not the
ERC dialog).
Also fixes a missing override of GetSeverity which kept ERC messages
from having the right prefix.
2021-11-29 14:24:45 +00:00
Jeff Young
a224d8dd6c
Disable autoplace fields when dragging/moving.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9766
2021-11-28 19:18:08 +00:00
Mikolaj Wielgus
9bb370e6b4
SCH_SHEET_PIN: Rename GetEdge, SetEdge to GetSide, SetSide
2021-11-28 20:07:06 +01:00
Jeff Young
80d6b9e76d
Tighten up hittesting for symbols and other items.
...
Grid-based accuracy doesn't need to be any larger than 1/2 the
diagonal as we'll snap to one side or the other. And symbols don't
need as much slop as other items since there's plenty of "meat" on
them.
Fixes https://gitlab.com/kicad/code/kicad/issues/9805
2021-11-28 19:03:51 +00:00
Mikolaj Wielgus
71bfbfaa70
Test SCH_PIN rotation and mirroring
2021-11-28 19:37:13 +01:00
Mikolaj Wielgus
2e1862de1c
Run AutoAutoplaceFields() in SCH_SHEET constructor
...
A constructor should create a fully initialized object.
2021-11-28 18:46:28 +01:00
Jeff Young
75d750a3cb
Copy lastResolved stuff when pasting.
...
This of course assumes the paste came from the same document. If not
then pasted items will get default lastResolved stuff.
2021-11-28 17:09:24 +00:00
Jeff Young
58b5ac4970
Don't create SCH_LINE till we know the layer.
...
The CTOR makes some decisions on initialization based on the layer.
2021-11-28 17:09:24 +00:00
Jeff Young
f23cd9c9e5
Clearer naming.
2021-11-28 17:09:24 +00:00
Jon Evans
d7f5917fb0
ERC: flag duplicated local labels with no pins as floating
...
See https://gitlab.com/kicad/code/kicad/-/issues/9593
2021-11-27 22:34:11 -05:00
Mikolaj Wielgus
65af3a8568
Make sheet pin positions invariant to four rotations more often
2021-11-28 02:18:18 +01:00
Roberto Fernandez Bautista
dd219419a0
Quiet wxWidgets asserts (sheet & symbol properties dialogs)
...
Ensure we don't set column size smaller than 1. If so, set to
-1 to auto size.
2021-11-27 21:03:42 +00:00
Roberto Fernandez Bautista
3660597082
Use canonical names when saving sheet name and filename fields
2021-11-27 20:38:51 +00:00
Mikolaj Wielgus
f35b0446e6
Properly initialize SCH_TEXT spin style
2021-11-27 19:42:11 +01:00
Jeff Young
9f7db24871
Selection bug fixes for Symbol Editor.
...
1) Make sure the y-coord is correctly inverted before calling collision
routines.
2) Give LIB_SHAPE poly lines the same extra slop as SCH_LINEs.
Fixes https://gitlab.com/kicad/code/kicad/issues/9791
2021-11-27 15:17:05 +00:00
Jeff Young
87e71072b1
Default line width to 0 in symbol editor.
...
Also removes some atrophied settings for repeated non-pins in
symbol editor (which only ever repeats pins).
Fixes https://gitlab.com/kicad/code/kicad/issues/9776
2021-11-27 11:53:38 +00:00
jean-pierre charras
b8b8c0d34c
dialog text properties: fix a focus issue.
...
Fixes #9792
https://gitlab.com/kicad/code/kicad/issues/9792
2021-11-27 10:08:30 +01:00
Jeff Young
698a668af7
Coverity fixes.
2021-11-26 18:14:29 +00:00
Jon Evans
08cb573e11
Do not propagate bus entries across buses and wires at the same point
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9678
2021-11-25 13:36:30 -05:00
Jon Evans
aa5f496727
Properly migrate bus-bus entries on load of legacy schematic
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9678
2021-11-25 12:12:01 -05:00
Jeff Young
5863bc0937
Put Repair Schematic behind Advanced Config.
2021-11-25 12:56:46 +00:00
Simon Schaak
c7dd98fb1a
Fix outdated syntax in help text
2021-11-25 12:53:29 +00:00
Jon Evans
9f6910f1e6
Expand autoplace collision search to include potential field locations
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9762
2021-11-25 07:48:05 -05:00
Jeff Young
5e6da9f964
Auto-start-wire tool requires an up-to-date connectivity.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9628
2021-11-25 01:24:35 +00:00
Jeff Young
5d751bef74
Be cognizant of connectivity dirtiness when cloning wires.
...
While the root case is wires, it really applies to all SCH_ITEMs.
Fixes https://gitlab.com/kicad/code/kicad/issues/9628
2021-11-25 01:24:35 +00:00
Jeff Young
f11cc904d2
More fixes for realtime connectivity being off.
...
Don't update net highlighting until after connectivity has been
rebuilt.
Fixes https://gitlab.com/kicad/code/kicad/issues/9628
2021-11-25 01:24:35 +00:00
Jeff Young
ed705986e0
No realtime connectivity fixes for junctions.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9628
2021-11-25 01:24:35 +00:00
Roberto Fernandez Bautista
2eb5d4fa7a
Symbol Editor: Allow save as all the time, as long as we have a symbol to save
...
There doesn't appear to be any reason why the LIBID needs to be populated
before a "save as", seeing as the user will be inputting the new lib name
and lib nickname via the dialog.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9744
2021-11-24 19:43:09 +00:00
Jeff Young
7fc04c3cf2
Fixes for realtime connectivity being off.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9628
2021-11-24 13:20:44 +00:00
Jeff Young
9e999f4de4
ADDED Repair Schematic.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9749
2021-11-24 13:20:44 +00:00
Jeff Young
228edd4121
Don't generate duplicate IDs in line/wire/bus tool.
...
Also cleans up existing duplicate IDs when reading.
Fixes https://gitlab.com/kicad/code/kicad/issues/9749
2021-11-24 13:20:44 +00:00
Jeff Young
b052d56c7b
R/W uuids for junctions.
2021-11-24 13:20:44 +00:00
Jeff Young
696f7c47fb
Reduce use of auto.
2021-11-24 13:20:44 +00:00
Seth Hillbrand
65fc47cb8f
Don't lose track of the sheet's screen
...
Corner cases need to clear screen before loading a new file. Aborting
needs to restore the screen or risk segfaults
Fixes https://gitlab.com/kicad/code/kicad/issues/9739
2021-11-23 10:57:12 -08:00
Seth Hillbrand
126563c839
Fix initilization project / ordering
...
We cannot resolve the Canvas type without the canvas being initialized.
But saving settings sometimes requests canvas access. This protects the
calls against failure by checking for canvas before saving
canvas-specific settings
Fixes https://gitlab.com/kicad/code/kicad/issues/9729
2021-11-22 11:47:42 -08:00
Seth Hillbrand
3f2d86adec
Make OpenGL default for all apps
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9699
2021-11-21 12:33:07 -08:00
Jeff Young
016a98df86
Increment numbers which have suffixes too.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9706
2021-11-21 18:02:17 +00:00
Jeff Young
15f309c8a8
Add a SCH_ITEM::operator= so the connections caches don't get copied.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9710
2021-11-21 16:54:46 +00:00
Jeff Young
c1703212dc
"Document" properties go in File menu; Edit menu is for item props.
2021-11-20 22:44:43 +00:00
Seth Hillbrand
2159acc9ce
Fix missing handler for multiple labels
...
This was intended to handle multiple labels but we missed the selection
condition.
Fixes https://gitlab.com/kicad/code/kicad/issues/9704
2021-11-20 14:37:18 -08:00
Jeff Young
5a5af91d88
Tidy up the SCH_PREVIEW_PANEL visibility flags.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9701
2021-11-20 15:28:17 +00:00
Seth Hillbrand
766a09c338
Remove autocomplete when we lose focus
...
Prevents the excess dropdown from persisting over windows
Fixes https://gitlab.com/kicad/code/kicad/issues/9651
2021-11-19 17:24:16 -08:00
Jeff Young
c01649fc6e
Make it easier to open legacy files.
2021-11-19 13:36:14 +00:00
Jeff Young
7bda077f69
Disable EE_POINT_EDITOR for uneditable symbol graphics.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9675
2021-11-18 15:38:46 +00:00
Jeff Young
1bb750814d
Cleanup dead code.
2021-11-17 12:49:53 +00:00
Jon Evans
9238b27f63
Silence IsWritable warning message
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9656
2021-11-16 21:02:32 -05:00
Jeff Young
969bef9a36
Fix stroking error when printing polygons.
2021-11-17 01:53:44 +00:00
Jeff Young
7760d3275d
Fix printing of LIB_SHAPE arcs.
2021-11-17 01:39:16 +00:00
Jeff Young
20328ab331
Back out last arc change.
2021-11-17 01:03:22 +00:00
Jeff Young
18d8053a6c
Fix an arithmetic precedence order bug and fine tune autoplacement.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9345
2021-11-17 00:49:42 +00:00
Jeff Young
b4ac53d93d
Attempt #1 to fix LIB_SHAPE arc printing.
2021-11-17 00:34:05 +00:00
Simon Schaak
399f2c116e
Symbol editor: save changed field properties
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9648
2021-11-15 20:40:32 +01:00
Jeff Young
12a75ffb94
A fuller implementation of allowing cut/copy/paste in search boxes.
...
This one also works for other text entry widgets, and also works
for other frames.
2021-11-15 18:13:35 +00:00
Christian Pfluger
9941a52e75
fix for issue #9345 autoplacing in schematic
...
this fix moves designator fields to the side in case of collision with
symbols or wires.
2021-11-14 18:02:36 +01:00
Jon Evans
ae24daa033
Do not include text when computing drag origin for a group
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9630
2021-11-14 11:54:04 -05:00
Jeff Young
b747ae5bdf
Make sure redraw happens regardless of order of panel commits.
...
(We don't control the order of the TransferDataFromWindow calls
for the various panels and here the junction dot size is dependant
on the default netclass wire size. So that calc has to be done
after all the various TransferDataFromWindow calls are made.)
Fixes https://gitlab.com/kicad/code/kicad/issues/9541
2021-11-13 23:20:56 +00:00
Jeff Young
025d9f82ea
Remove atrophied schematic default wire and bus widths.
...
(They're now in the netclasses, and specifically the default netclass
if no other netclass is assigned.)
Fixes https://gitlab.com/kicad/code/kicad/issues/9628
2021-11-13 22:56:50 +00:00
Jeff Young
efc64e972c
Fix pasting into LIB_TREE search control.
...
We have a hack for turning accelerator keys that wxWidgets turns into
menu commands back in to accelerator keys -- but it requires that the
corresponding menu items be enabled in order to work.
2021-11-13 19:45:10 +00:00
Jeff Young
cc6e3841ae
Formatting.
2021-11-13 19:45:10 +00:00
Wayne Stambaugh
80c5b1efb1
File formatting improvements and fixes.
...
Symbol library IDs included the library nickname which is incorrect
and meaningless since it will be overwritten by the symbol library
table code. This is not a file format change as there are no behavioral
differences.
2021-11-13 12:57:18 -05:00
Wayne Stambaugh
53f5d616aa
Coverity issue fixes.
2021-11-13 11:38:31 -05:00
jean-pierre charras
e218471d24
DIALOG_CHANGE_SYMBOLS: fix a bug introduced by my commit 686b32db
...
the filtering for mandatory fields was disabled.
2021-11-13 13:47:09 +01:00
Jeff Young
1e151b1bcb
Fix effective pen width when plotting wires.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9625
2021-11-12 16:27:55 +00:00
Jeff Young
da58e9ee4c
Don't rely on selection when updating edited symbol in schematic.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9600
2021-11-11 16:43:06 +00:00
jean-pierre charras
686b32dbd3
fix issue in DIALOG_CHANGE_SYMBOLS, in non English locale.
...
Mandatory field names where compared in list, using translated and not translated names.
Fixes #9596
https://gitlab.com/kicad/code/kicad/issues/9596
2021-11-11 10:56:09 +01:00
Jeff Young
54e00569d8
Don't fetch the root sheet's UUID out of the sheet instances.
...
1) we're storing it now anyway
2) the root sheet UUID is the one UUID that's *not* in the instance
array, and previously we were erroneously grabbing the first sub-sheet's
UUID (producing duplicate UUIDs).
2021-11-09 16:07:30 +00:00
Seth Hillbrand
6e5a918377
Writeable -> Writable
2021-11-08 15:56:51 -08:00
Jeff Young
de93a071e2
Fix error in python command string generation.
...
(We can now go back to using double-quotes since that bug is fixed.)
Fixes https://gitlab.com/kicad/code/kicad/issues/9552
2021-11-08 21:05:54 +00:00
Seth Hillbrand
cd3ecdfc78
Fix sort to be irreflexive
...
Switching the order of the parameters must switch the sort order (no <=)
otherwise the sort is non-determinant and fails std::sort preconditions
2021-11-08 11:25:13 -08:00
Mikolaj Wielgus
38bd4b07e4
Close the simulator before changing schematic
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9501
2021-11-07 23:35:06 +00:00
Roberto Fernandez Bautista
04a30638f0
eeschema: Pasted items are moving as soon as they are pasted
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9539
2021-11-07 15:14:11 +00:00
Jeff Young
f9a282278c
Update junction-dot-size-cache when Schematic Setup changes.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9541
2021-11-07 14:12:44 +00:00
Roberto Fernandez Bautista
b572781a8a
eeschema: Update anchor position of pasted items after initial move
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9534
2021-11-06 16:03:41 +00:00
Roberto Fernandez Bautista
d1bab3116d
eeschema: Warp to origin when moving - add missing text items
...
Schematic fields and text items were not being warped to origin when
moving.
2021-11-06 15:19:22 +00:00
jean-pierre charras
2f22b9dd81
Do not replace delimiter " by ' inside a command string, round 2.
2021-11-05 18:28:44 +01:00
Jeff Young
83e5208213
Fix a couple of holes in the IsTestEnabled() checks.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/7270
2021-11-04 16:24:06 +00:00
Jeff Young
996a5b85a6
Overhaul IsJunctionNeeded logic to support all the different cases.
...
Several clients were using this with different needs. The API is
now more explicit (and there are more options under the hood).
Fixes https://gitlab.com/kicad/code/kicad/issues/9518
2021-11-04 12:57:16 +00:00
Seth Hillbrand
cf6b18ec7e
Remove escaped double-quotes
...
For some reason, escaped double quotes in wxString::Format cause issues
on Mac. We can replace them with single quotes in most places without
loss of clarity
2021-11-03 17:03:14 -07:00
Jeff Young
179628d1d2
Repair field properties dialog for rotation and mirroring.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9508
2021-11-03 18:11:59 +00:00
Roberto Fernandez Bautista
5e040ad126
eeschema settings: Default to mouse drag is drag action on first install
...
This is to be consistent with other EDA tools like Altium and CADSTAR.
2021-11-03 16:58:11 +00:00
Jeff Young
c2371f3943
Revert e4b61de792
.
...
It doesn't seem to fix the testcase on Linux, and the tests pass on
my machine in either configuration.
2021-11-03 10:30:34 +00:00
Jeff Young
e4b61de792
Special case sheet ordering in file.
2021-11-02 23:14:01 +00:00
Seth Hillbrand
7cf72aaa41
Fix bezier import in Altium schematics
2021-11-02 15:45:30 -07:00
Jeff Young
4d46445ce1
Fix Bezier reading.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9512
2021-11-02 22:19:41 +00:00
Jeff Young
4acff58c7a
Implement a forced ordering for LIB_ITEMs until we have UUIDs.
...
(Once we read/write the UUIDs, we should just compare the type
and then the UUID like we do for SCH_ITEMs.)
2021-11-02 20:07:34 +00:00
Jeff Young
eaf10a04dd
Improved naming.
2021-11-02 20:07:34 +00:00
Jeff Young
21cb56dfe7
Formatting.
2021-11-02 20:07:34 +00:00
Seth Hillbrand
9e760512ac
Update schematic when saving tuned value
...
Also avoids a known(!) crash when the existing item has been deleted
while tuning.
Fixes https://gitlab.com/kicad/code/kicad/issues/9502
2021-11-01 17:05:22 -07:00
Simon Schaak
f79cb382c4
Symbol editor: fix name corruption in pin table
...
Discard changes to pin numbers of grouped pins in the pin table to avoid
setting all pins of the group to the same number.
2021-11-01 22:10:13 +00:00
Jeff Young
af95a4b424
Fix duplicate stroke when formatting circles.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/9507
2021-11-01 21:29:46 +00:00
Jeff Young
40b4052ad4
Improve text hittesting in schematics.
...
Text has a fairly big bounding box to account for descenders, overbars,
etc., but it makes it feel too sloppy for hittesting. This change
allows selection disambiguation to look at the actual strokes of the
text when deciding what's "closest".
Fixes https://gitlab.com/kicad/code/kicad/issues/9506
2021-11-01 21:13:12 +00:00