Jeff Young
b2679b7648
Swap pins for undo.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14100
(cherry picked from commit c266913ec7
)
2023-03-14 11:56:33 +00:00
Jeff Young
c5a69f073c
Added PSPICE/LTSPICE JFET model parameters.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12425
(cherry picked from commit 3bc5e3dd8a
)
2023-03-12 21:05:06 +00:00
Jeff Young
3025671b1a
Add missing command to SPICE directives list.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14215
(cherry picked from commit 6d29088668
)
2023-03-12 21:04:50 +00:00
Wayne Stambaugh
9e1fd16329
Coverity fixes and code cleaning.
...
(cherry picked from commit 4e99812145
)
2023-03-10 11:21:19 -05:00
Salvador E. Tropea
f135881bd6
Use constants for the names of the built-in colors
...
- Avoid repetition and errors from typos
- Allow simple changes
- Simpler data type handling, the constants are wxString
2023-03-07 10:32:18 +00:00
Seth Hillbrand
839301f81e
Revert "Consolidated ERC fixes"
...
This reverts commit 2127712115
.
Version uses functions only available in the master branch. Will revert
for 7.0.2 to allow targeted update
2023-03-06 21:22:55 -08:00
James J
2127712115
Consolidated ERC fixes
...
- Consistent calculation of IsStacked() for pins across ERC checks
- Correct placement of ERC marker for unresolved field variables
- Add sheet-specific paths to two ERC check results
(cherry picked from commit 39e56485fc
)
2023-03-06 16:38:11 -08:00
Graham Keeth
9b2aeda51e
Fix column offset in BOM script
...
Debugged by @svk28
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14128
(cherry picked from commit cc110399ea
)
2023-03-06 16:23:31 -08:00
JamesJCode
b82020722b
Eeschema netlist output: Propagate NC across hierarchical schematics
...
Fixes #12580
Additionally does not export no_connect netlist annotation on pins
which are both connected to another pin and a NC item, unless all
connected pins are stacked at the symbol level.
Adds testing of pin types to netlist QA unit tests.
(cherry picked from commit 9dca70a773
)
2023-03-06 16:22:25 -08:00
Jeff Young
4076461347
Make SPICE netlist title explicit.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14183
(cherry picked from commit 6838de962b
)
2023-03-06 23:09:51 +00:00
aris-kimi
f1e060902b
Simulator: Fix RLGC c unit
...
(Cherry-picked from db2780090c
)
2023-03-06 15:59:54 +00:00
aris-kimi
05ab9e3836
Simulator: Fix diode ibv unit
...
(Cherry-picked from 5b43dc4e7b
)
2023-03-06 14:20:33 +00:00
Jeff Young
a4e0f1f7aa
Support both wxWidgets APIs for excluded characters.
...
(Sadly they're mutually incompatible.)
Fixes https://gitlab.com/kicad/code/kicad/issues/14153
(cherry picked from commit b5060d2951
)
2023-03-06 14:17:11 +00:00
Jeff Young
a8f27d13e6
Use name (even for fallback models) *if* it's specified in dropdown.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12425
(cherry picked from commit 7547e550aa
)
2023-03-06 11:18:14 +00:00
Alex
8f1237e629
bom_csv_grouped_extra: use field-specific methods for data.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14129
(cherry picked from commit c1f4911d7e
)
2023-03-05 00:26:46 +00:00
Wayne Stambaugh
2c7f44f78d
Coverity fixes and code cleaning.
...
(cherry picked from commit 789bf6455a
)
2023-03-04 13:14:59 -05:00
Jeff Young
9b61b350fe
Don't commit changes on paint events or updateUI events.
...
Also use std::numeric_limits::epsilon for comparing doubles.
Fixes https://gitlab.com/kicad/code/kicad/issues/13851
(cherry picked from commit d714ff8549
)
2023-03-04 00:10:39 +00:00
Alex
e3cf65fbdf
Fix bitmap scaling when reading legacy schematic as well.
...
(cherry picked from commit bfc3e2d29b
)
2023-03-03 22:39:38 +00:00
Jeff Young
e51d43568e
Prefer Clamp() to std::min( std::max() ).
...
(cherry picked from commit d545216432
)
2023-03-03 21:32:19 +00:00
Seth Hillbrand
adc7a3ba4a
Correct parent symbol for lib_text
...
The edited symbol should be pulled from the parent window when there is
not an existing text object
(cherry picked from commit 59fc62e898
)
2023-03-03 12:40:56 -08:00
Jeff Young
94ec6cc362
Convert inline models in Sim.Params fields to SPICE syntax.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14157
(cherry picked from commit 14f1f3ec79
)
2023-03-03 18:18:32 +00:00
Jeff Young
bbdb5eb6e3
Use resolved fields when generating LIB_TREE info.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13737
(cherry picked from commit 2fb24347ad
)
2023-03-03 17:23:13 +00:00
Jeff Young
e487ca8bd8
Handle alternate pin definitions when printing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14122
(cherry picked from commit 2973d292d9
)
2023-03-03 12:57:03 +00:00
Jeff Young
f5b0e20f78
The screen for undo is the screen that *owns* the SCH_SHEET...
...
... not the screen the SCH_SHEET owns.
Fixes https://gitlab.com/kicad/code/kicad/issues/14099
(cherry picked from commit 5849458476
)
2023-03-03 00:23:41 +00:00
Jeff Young
8619705e44
Hook up AddField handler to GRID_TRICKS for SCH dialogs.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/git/14153
2023-03-02 18:16:02 +00:00
Jeff Young
c216ed2d1f
Make SME prop-grid hack Mac-only.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13852
(cherry picked from commit dcba555d44
)
2023-03-02 14:59:57 +00:00
Jeff Young
3a95826b42
Move only-write-model-if-it-contains-overrides up to base class.
...
It's necessary to keep us from writing out model lines for included
models and fall-backs of included models.
(cherry picked from commit f5edcf82f2
)
2023-03-01 13:44:26 +00:00
jean-pierre charras
dcc1009162
plotters rework: add plot fct to use TEXT_ATTRIBUTES class to pass text settings
...
Old PLOTTER::Text is not (yet) removed, but it use negative text size
to mirrored text, which is not really compatible with some plotters (especially PDF).
Using TEXT_ATTRIBUTES is much easy and much better,
so PLOTTER::PlotText() is added.
Note: "old" PLOTTER::Text() is not removed yet.
From master, commit 51d46c0e73
2023-03-01 10:45:23 +01:00
qu1ck
90eb5e9c31
PCM: auto reload global libs after dialog is run
...
This adds Reset() method to KIFACE to reload global libs stored in
global static vars.
Also refactors some lib reload code in various frames to have
common MAIL_RELOAD_LIB handler.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12500
(cherry picked from commit 2975f53647
)
2023-02-28 16:48:28 -05:00
Seth Hillbrand
17c34c88dc
Avoid forcing all units
...
When the enduser is not allowed to change the status of "common to all
units", then it should be disabled
Fixes https://gitlab.com/kicad/code/kicad/issues/14084
(cherry picked from commit 3207d1386e
)
2023-02-28 13:42:51 -08:00
aris-kimi
ff6f658f9d
Simulator: Fix some cases with initial conditions
...
(cherry picked from commit 4a761179d0
)
2023-02-28 21:31:45 +00:00
jean-pierre charras
764ddd4773
Fix compil warnings.
2023-02-28 18:00:22 +01:00
Graham Keeth
f7d9f1f69d
Fix SPICE pins for BJTs and MESFETs
...
- MESFETs don't have a substrate/bulk pin
- BJTs have a substrate pin, and HICUM/VBIC have TJ
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13848
(cherry picked from commit 6af3dadaee
)
2023-02-28 14:21:12 +00:00
Jeff Young
42efd2d005
Make substrate and thermal junction nodes optional.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14083
(cherry picked from commit 1fdc81e68d
)
2023-02-28 14:21:12 +00:00
Jeff Young
d32e13daee
Clear model name when switching to internal model.
...
Also fixes a bug to ensure that a modelLine gets written when using
an internal model.
Fixes https://gitlab.com/kicad/code/kicad/issues/14083
(cherry picked from commit 2e5bf0210a
)
2023-02-28 14:21:12 +00:00
Jeff Young
e82c21e944
Get rid of m_sortedSymbolPinList in favour of a properly scoped variable.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14083
(cherry picked from commit 2a79a453ec
)
2023-02-28 14:21:12 +00:00
Jeff Young
59d8110801
Always highlight children when they're selected on their own.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13876
(cherry picked from commit a1ceb585c7
)
2023-02-28 14:21:11 +00:00
Jeff Young
d028b381fa
Make SIM_MODEL_SPICE_FALLBACK act more like the model it's a fallback for.
...
In particular, install/show the parameters, and keep the existing name
field.
Fixes https://gitlab.com/kicad/code/kicad/issues/14102
(cherry picked from commit 281fde71b9
)
2023-02-28 14:21:11 +00:00
Roberto Fernandez Bautista
c96f0f2396
Fix CADSTAR importer memory leaks
...
We were leaking the xml tree when throwing exceptions
(cherry picked from commit b03366c9e8
)
2023-02-27 22:58:41 +00:00
Fabien Corona
46c8985661
sim - switches: open <-> closed in description
2023-02-27 19:04:48 +01:00
Jeff Young
b3c6f559b2
Don't eval empty string.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13756
(cherry picked from commit 79f13ea9c7
)
2023-02-26 23:14:40 +00:00
Jeff Young
4aba595b2b
Add second instance of "don't mess up user formatting" fix.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13989
(cherry picked from commit 4b427b2d0c
)
2023-02-26 22:00:20 +00:00
Jeff Young
4ffe742b69
Log new undo record at the start of Change Symbols.
...
Also fixes a bug where the "screen" variable was used with stale
data.
Fixes https://gitlab.com/kicad/code/kicad/issues/14061
(cherry picked from commit 2b96161d0e
)
2023-02-26 21:58:57 +00:00
Roberto Fernandez Bautista
955bd5a6d1
CADSTAR Sch: Fix loading of graphical arc shapes
...
Correctly load arc shapes as real arcs instead of approximating now that
v7 supports graphical arcs in the schematic.
Also fix calculation of arc geometry for ccw arcs.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14101
(cherry picked from commit 698d0b7e92
)
2023-02-26 18:47:39 +00:00
Jon Evans
d08157f7db
Re-disable validator for VALUE and add comment explaining it
2023-02-25 08:05:42 -05:00
Jon Evans
981bf328ae
Value field needs to use the normal text control
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14056
2023-02-24 22:18:31 -05:00
Jeff Young
f604bcb557
Only write included models if they have overridden parameters.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13953
(cherry picked from commit 5a12e5ee76
)
2023-02-24 20:47:22 +00:00
Jeff Young
eccf9eb4a4
Change strategy for committing values from SIM_MODEL propGrid.
...
Note that the PCB editor's propGrid doesn't seem to need this workaround,
but I haven't yet figured out what's different between it and the sim model
propGrid.
Fixes https://gitlab.com/kicad/code/kicad/issues/13852
(cherry picked from commit c188318174
)
2023-02-24 20:47:22 +00:00
Jeff Young
39403fa885
Cleanup some dead code, and add a potentially needed fix for non-Mac.
...
(The Mac bug is fixed in 4e5b1da81fce7cd9ffedaec878ed07bfcfff4fe2 in
our wxWidgets fork.)
(cherry picked from commit 200a06a677
)
2023-02-24 20:47:22 +00:00
Jeff Young
5e7cc30564
Don't mess up user formatting if eval'ing didn't actually change value.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13989
(cherry picked from commit 8059edff0e
)
2023-02-24 20:47:22 +00:00