Jeff Young
e59867d479
Add backspace modifier handling to SCINTILLA_TRICKS.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13910
2023-05-08 18:41:13 +01:00
Jeff Young
8e1bcaed37
Holes need a parent.
...
SetHole() handles all this for us. Make sure it's called.
Fixes https://gitlab.com/kicad/code/kicad/issues/14702
(cherry picked from commit 5b3798a370
)
2023-05-08 14:51:47 +01:00
Jon Evans
f3c864c178
PNS: Remove holes when removing items with holes
...
Related to https://gitlab.com/kicad/code/kicad/-/issues/14702
(cherry picked from commit b06f90335b
)
2023-05-08 02:48:55 +00:00
Jeff Young
947923509e
Fix a typo.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14515
(cherry picked from commit 6059e895d7
)
2023-05-08 03:32:32 +03:00
Jeff Young
4e0f77c0f4
Don't allow thickness of 0 in case of an empty stackup.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/10790
2023-05-07 22:30:01 +01:00
Jeff Young
6f0505f19c
Field bounding boxes no longer contain interline spacing.
...
That's entirely done through FIELD_PADDING now.
Fixes https://gitlab.com/kicad/code/kicad/issues/14127
2023-05-07 22:30:01 +01:00
Marek Roszko
98bf66cb25
Use _fgetc_nolock with msvc
...
(cherry picked from commit 5dcc221950
)
2023-05-07 21:28:59 +00:00
Jon Evans
f9b641b24d
Allow for settings to be added during load
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14691
(cherry picked from commit 2ab47ee1e9
)
2023-05-07 23:48:26 +03:00
jean-pierre charras
3894314ab2
DIALOG_SHIM: fix missing aEvent.Skip() in DIALOG_SHIM::onChildSetFocus().
...
This method was added in commit a914f6e9
.
Missing Skip() created issues on Windows (text edit cursor not shown in dialogs)
Fixes https://gitlab.com/kicad/code/kicad/issues/14692
(cherry picked from commit e208685f85
)
2023-05-07 19:16:41 +03:00
Marek Roszko
edc9d38680
Change the spacemouse driver flag to true for windows by default
...
(cherry picked from commit b92f62337f
)
2023-05-07 16:12:57 +00:00
Seth Hillbrand
ce5f72207e
Cleanup printf bits
...
(cherry picked from commit 990641d2eb
)
2023-05-07 19:02:02 +03:00
Marek Roszko
ff8d009022
Add missing footprint load progress, usually in schematic editor
...
(cherry picked from commit c7eaef2d13
)
2023-05-07 15:17:27 +00:00
Jeff Young
589c33ec05
Fix capitalization of text vars for Eagle importer.
...
Also fixes the test gold files to expect the correct variable
references.
(cherry picked from commit 8bd21edd8a
)
2023-05-06 23:53:18 +01:00
Jeff Young
28fe5b0df5
Expand solder mask for pads *defined* to be on copper layers.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14693
2023-05-06 21:29:18 +01:00
Jeff Young
5a3dfe598f
Handle Eagle user-defined attributes.
...
(We map these to text variables.)
Fixes https://gitlab.com/kicad/code/kicad/issues/13798
(cherry picked from commit 8fe02ee83c
)
2023-05-06 21:11:16 +01:00
Jeff Young
d0c132ccd4
Defense in depth for "mouse stuck in canvas".
...
Fixes https://gitlab.com/kicad/code/kicad/issues/12653
(cherry picked from commit 49655ae742
)
2023-05-06 11:29:05 +01:00
Jeff Young
826541548c
Make sure mouse isn't captured when dialog is raised.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14685
(cherry picked from commit c016bea020
)
2023-05-06 11:29:01 +01:00
Jeff Young
e3adc76a72
Rewrite linebreaking algorithm.
...
Previous version was overly simplistic to deal correctly
with multiple spaces or textruns not separated by spaces.
Fixes https://gitlab.com/kicad/code/kicad/issues/14683
2023-05-05 22:32:03 +01:00
Wayne Stambaugh
2ae2d7ee1a
Verify parent symbol shared pointer is still valid in symbol editor.
...
(cherry picked from commit 51fd7ca5ed
)
2023-05-05 13:50:06 -04:00
Jeff Young
e28b50e8d6
Fix a bunch more issues with sheetpaths and allowExtraText.
...
A sheetpath is required to correctly resolve text variables.
Depending on currentSheet is rife with bugs.
There are many places where we do *not* want to be prepending
field names to the field values, such as netlisting,
building PDF hypertext menus, etc.
Also, Find/Replace needs to work on unresolved text, as
that's what we're going to display (and if replace nuked
your variable references you wouldn't be happy).
(cherry picked from commit b41d446f58
)
2023-05-05 18:02:59 +01:00
Wayne Stambaugh
9c78d86f58
Don't include power symbol pin when exporting netlist.
...
The netlist exporter was never updated to exclude symbols that are
tagged as power symbols. Only the legacy power symbol name prefix
('#') was used as the power symbol check. Power symbols no longer
require the '#' name prefix.
(cherry picked from commit fb6b8eaeea
)
2023-05-05 11:36:39 -04:00
Marek Roszko
a6b23a751e
Add env var to force logging on msw
...
(cherry picked from commit 18dd623122
)
2023-05-05 00:59:41 +00:00
Seth Hillbrand
34d5f1f9fe
Fix a28d590b9b
...
Needs to be static, so keep the reference from the associated symbol and
not the SCH_SYMBOL instance. Both will likely have the same prefix,
which is all we care about here
(cherry picked from commit 2cac992801
)
2023-05-04 15:53:15 -04:00
Seth Hillbrand
43ad15dc0e
Force not-on-board symbols to NONE priority
...
Symbols that are not on the board should not affect the arbitrary names
assigned to unlabeled nets.
(cherry picked from commit a28d590b9b
)
2023-05-04 15:52:57 -04:00
Jeff Young
d20147c79f
Use correct sheetpath when exporting netlist.
...
(cherry picked from commit c20ef06f56
)
2023-05-04 14:28:40 +01:00
Jeff Young
7cc014cf9e
Be careful of infobar outliving symbol.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14680
2023-05-04 11:52:02 +01:00
Jeff Young
9e735fc940
First <ESC> after an edit in a textEdit cancels the edit.
...
(Second will exit the dialog.)
Fixes https://gitlab.com/kicad/code/kicad/issues/14514
(cherry picked from commit a914f6e992
)
2023-05-04 11:52:02 +01:00
Jeff Young
4fecf6c50d
Add select-all to TEXT_ENTRY_TRICKS.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14237
Fixes https://gitlab.com/kicad/code/kicad/issues/13304
(cherry picked from commit 9252793fdb
)
2023-05-04 11:52:02 +01:00
Jeff Young
c31c14e46b
Don't call BuildInitialTrace() for entry gateways.
...
We're going to call it to connect the entry and target gateways
anyway, so all we need are gateways at 22.5 degrees to setup entry
at +/- 45 degrees from the current direction.
Fixes https://gitlab.com/kicad/code/kicad/issues/14324
Fixes https://gitlab.com/kicad/code/kicad/issues/12459
(cherry picked from commit 507a25f150
)
2023-05-04 11:52:02 +01:00
jean-pierre charras
349dbb98a6
bom_csv_grouped_by_value_with_fp.py: fix compatibility with python < 3.9
...
From master branch
2023-05-04 08:54:55 +02:00
Jeff Young
f4fa5bb0fc
Don't store resolved values in symbol fields table editor dataStore.
...
We're going to use the dataStore to update the symbol, so
if we store resolved values it will nuke any text variables
even if the field wasn't edited.
Not sure if the BOM generator has a separate resolve-variables
step or not. But it will need one as the code removed here
only worked for Values and Footprint fields anyway.
2023-05-04 00:08:18 +01:00
Seth Hillbrand
4cdf75dc72
Remove matching parents/neighbors in subgraphs
...
This ensures that when bus elements or labels matching bus elements are
removed that the stale neighbor/parent references are similarly removed
2023-05-03 13:35:51 -07:00
Seth Hillbrand
53eb39e033
Avoid NaNs when applying fillets
...
Segments that are inline with each other will create NaNs when
filleting. This double check prevents NaN points from being added to
the polygon
(cherry picked from commit b72c6e5cb0
)
2023-05-03 11:50:47 -07:00
Mark Roszko
57ae43890c
Update 5 files
...
- /eeschema/CMakeLists.txt
- /eeschema/eeschema.cpp
- /pcbnew/pcbnew.cpp
- /qa/qa_utils/pcb_test_frame.cpp
- /qa/unittests/eeschema/test_module.cpp
2023-05-03 17:32:55 +00:00
jean-pierre charras
1c59574cbf
FOOTPRINT_EDIT_FRAME: do not delete settings when closing the frame.
...
They now are read when starting kicad, and must be not deleted.
(cherry picked from commit 0c544f1f45
)
2023-05-03 17:27:28 +00:00
Seth Hillbrand
7ddef03aba
Initialize settings for SINGLE_TOP
...
(cherry picked from commit 82ba67db82
)
2023-05-03 17:26:57 +00:00
Seth Hillbrand
4258738b89
Remove extraneous symbol editor settings
...
(cherry picked from commit 2cd861dbd5
)
2023-05-03 17:26:26 +00:00
Seth Hillbrand
594864e117
Remove extraneous includes
...
(cherry picked from commit 892e4536b0
)
2023-05-03 17:26:13 +00:00
Seth Hillbrand
a5698ce480
Remove locks from settings
...
Settings should be initialized on start-up. This removes the option of
lazily loading the settings from file and instead requires all settings
needed to be loaded on KiFACE start before requesting data from the
settings object
(cherry picked from commit e6ab9a88ce
)
2023-05-03 17:25:17 +00:00
Seth Hillbrand
1a2c9011e6
Rework Copper Sliver check
...
Adds QA checks to copper sliver tests. Adds the following checks:
- Dot product between two arms (quickly avoids checks for >90°)
- Checks the sliver is convex (area test)
- Eliminates minor slivers with angles that are approximately 0 and ones
with the opposite side width beneath a configurable level
- Updates Clipper2 to fix a couple of jagged edges on inflate
- Adds simplify during zone fill inflation to limit jaggies
Fixes https://gitlab.com/kicad/code/kicad/issues/14549
(cherry picked from commit f7f52d77e4
)
2023-05-03 10:22:49 -07:00
Jeff Young
600ac72a3d
Add missing property to footprint texts table.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14357
2023-05-03 17:58:29 +01:00
jean-pierre charras
1118eed080
Use operator at() instead of [] to access a std::array item
...
It helps debug.
From Master branch
2023-05-03 17:21:36 +02:00
jean-pierre charras
e42c66bd0e
Pcbnew: fix crash when loading a file having vias on connected layers only.
...
It was due to an access out of bounds in a std::array
Fixes #14668
https://gitlab.com/kicad/code/kicad/issues/14668
2023-05-03 17:18:28 +02:00
Jeff Young
ff8fae377c
Pass aEvent by value.
...
It will have changed by the time CallAfter() is executed.
Fixes https://gitlab.com/kicad/code/kicad/issues/12475
2023-05-03 12:27:45 +01:00
Jeff Young
6931252ed9
Pull back more sheetPath fixes from master.
2023-05-03 12:04:46 +01:00
Mike Williams
ef8e549d86
PCB Search Pane: show Board Setup / Net Classes on net activation
...
(cherry picked from commit bc8f81b14d
)
2023-05-03 11:55:50 +01:00
Mike Williams
a5470029a8
PCB Search Pane: activate item opens properties dialog
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/12475
(cherry picked from commit 71b687622b
)
2023-05-03 11:55:14 +01:00
Mike Williams
13fb23d59d
Search Pane: add Activation (enter/double click) event support
...
(cherry picked from commit d915cb780e
)
2023-05-03 11:54:49 +01:00
Jeff Young
a3197578d6
Tighten lifecycle management of CN_ANCHOR/CN_ITEM.
...
In particular, when a CN_ITEM is freed set all its anchor's
item pointers to NULL. (The anchors have a separate
lifecycle due to being std::shared_ptrs.)
Hopefully fixes Sentry KICAD-KV.
(cherry picked from commit 0eac5c6748
)
2023-05-03 10:51:20 +01:00
Jeff Young
ebc14b35f5
Commenting and formatting.
2023-05-02 14:14:05 +01:00