Jeff Young
a39fb03822
Remove some references to g_UserUnit
...
(cherry picked from commit 614d832)
2018-07-17 15:09:56 +01:00
Carsten Schoenert
9f7109826d
fix misspelled 'allows to' -> 'allows one to'
...
Fixup small grammar issues around used 'allows to ...' almost in
code comments.
2018-07-11 10:35:03 -04:00
Seth Hillbrand
f6bd6b1360
3d: Replace glFinish with glFlush
...
glFinish is meant to ensure every aspect of the screen is fully-drawn
before continuing. This causes issues with certain chipsets (Intel
4-8k)
glFlush is more of a suggestion that CPU work is complete and the GPU
should complete its work in a "timely" fashion.
We add an additional glFinish call before getting a screenshot as this
will copy the actual data from the card buffer.
Fixes: lp:1775976
* https://bugs.launchpad.net/kicad/+bug/1775976
2018-06-13 15:32:18 -07:00
Jeff Young
a300006956
Fix dialog layout of Add 3D Shape.
...
Fixes: lp:1747652
* https://bugs.launchpad.net/kicad/+bug/1747652
2018-06-06 00:01:47 +01:00
Jeff Young
10ec39a107
Move 3D file error messages to tracePathsAndFiles key.
...
Fixes: lp:1772255
* https://bugs.launchpad.net/kicad/+bug/1772255
2018-05-21 13:18:41 +01:00
Jeff Young
3a8a718e43
A pesky bug, this one is. (Said in best Yoda impression.)
...
There were two examples of the somewhat annoying error message.
This gets the second one.
Fixes: lp:1772255
* https://bugs.launchpad.net/kicad/+bug/1772255
2018-05-21 00:19:55 +01:00
jean-pierre charras
6e5131be5a
Minor fix in fp editor and fp viewer: display the fp info instead of the useless board info.
...
board info makes sense only in board editor, not in fp editor and fp viewer.
2018-05-12 10:44:31 +02:00
jean-pierre charras
e339007d22
3D viewer: fix some issues when opened from a frame and changes are made in a other frame:
...
* Refresh the view only when changes are made in the caller frame.
* Allows recreate a new instances when try to open the 3D view from a frame taht is not the initial caller
* Remove duplicate code in kicad frames.
2018-05-10 12:49:20 +02:00
jean-pierre charras
4cc62ce038
3D viewer: minor enhancement: display the name of the 3D shape being loaded.
2018-05-08 16:07:09 +02:00
Jeff Young
aa7da5dfcd
Treat ${...} and $(...) envvar references uniformly.
...
Fixes: lp:1769282
* https://bugs.launchpad.net/kicad/+bug/1769282
2018-05-05 23:40:40 +01:00
Thomas Pointhuber
cad2d0656c
Remove Items from Menubar of 3D Viewer which are available over dialog
2018-05-05 12:33:04 -04:00
Thomas Pointhuber
32af04c6a6
Adjust Menubar of 3D Viewer to common style
2018-05-05 12:28:09 -04:00
jean-pierre charras
ccb668c105
3D viewer: fix polygon contours of pads solder paste when solder paste ratio was not null.
...
(the oval and round rect pads 3D contours were incorrect)
Fixes: lp:1767209
https://bugs.launchpad.net/kicad/+bug/1767209
2018-04-28 20:31:50 +02:00
jean-pierre charras
458f9f5c97
3D viewer: fix incorrect calculation of pad shapes with clearance (i.e. pad shapes on solder paste and solder mask layers)
...
Fixes: lp:1767209
https://bugs.launchpad.net/kicad/+bug/1767209
2018-04-28 12:41:43 +02:00
Jeff Young
09a6bada03
Delegation of keyEvents from 3D toolbar to 3D canvas.
...
Fixes: lp:1759803
* https://bugs.launchpad.net/kicad/+bug/1759803
2018-04-25 14:19:32 +01:00
Wayne Stambaugh
fc8b852c41
Derive 3D model selection dialog from DIALOG_SHIM.
2018-04-20 10:15:05 -04:00
jean-pierre charras
9865fcd929
3D viewer: fix hotkeys in 3D preview panel, and incorrect icons in context menu.
2018-04-17 09:59:21 +02:00
jean-pierre charras
8fcdc4f6c3
3D viewer: fixes about hotkeys and menubar.
...
Move code to specific files 3d_menubar.cpp and hotkeys.cpp like in other tools.
2018-04-15 14:07:33 +02:00
Seth Hillbrand
86f744a1fd
Adding initialization to GLM vectors
2018-04-11 10:59:28 -07:00
Ievgenii Meshcheriakov
18b0b78397
Correctly initialize module matrices in raytracer
...
Initialize module matrices to identity matrices instead of default zero
matrices while creating scenes for raytracer. This fixes disappearing
modules in raytracer view.
Fixes: lp:1763026
* https://bugs.launchpad.net/kicad/+bug/1763026
2018-04-11 10:06:36 -07:00
jean-pierre charras
20c30a4425
3D viewer: Cosmetic enhancement in DIALOG_3D_VIEW_OPTIONS.
2018-04-09 19:37:17 +02:00
Carsten Schoenert
a11714b1a4
fix misspelled 'an other' -> 'another'
2018-04-08 13:24:37 -04:00
jean-pierre charras
7f6e26e55a
DrawGraphicText: remove a static variable, and replace it (when needed) by a new parameter in argument list.
...
It make this function thread-safe (as far as wxString is thread-safe)
2018-04-07 19:57:26 +02:00
Jeff Young
0dc719ca1a
Update 3D view immediately when user changes parameters.
...
The ray-tracer runs in the background so you can still change
other settings while it's redrawing.
Fixes: lp:1612419
* https://bugs.launchpad.net/kicad/+bug/1612419
2018-04-06 17:03:00 +01:00
Jeff Young
cd0cd242d1
Move 3D polygon approximation to absolute-error algorithm.
...
Also inflates via and pad hole polygons to bisect their circles.
Fixes: lp:1758137
* https://bugs.launchpad.net/kicad/+bug/1758137
2018-03-23 12:46:17 +00:00
Jeff Young
b335ef0531
Don't involve user in implementation details.
...
Fixes: lp:1756299
* https://bugs.launchpad.net/kicad/+bug/1756299
2018-03-16 16:57:38 +00:00
Wayne Stambaugh
3f52e87224
Standardize terminology for automatic zoom to "Zoom to Fit".
...
Fixes lp:1753336
https://bugs.launchpad.net/kicad/+bug/1753336
2018-03-16 08:38:36 -04:00
Seth Hillbrand
7fbf7bbf42
Spelling improoved -> improved
2018-03-09 09:43:54 -08:00
Seth Hillbrand
5fea89ebd5
Standardize plural menu items
2018-03-08 12:33:32 -08:00
Maciej Suminski
5bbb4489b3
Fixed out of bounds access to m_shaderBuffer array in 3D viewer raytracer
2018-03-05 17:49:34 +01:00
Bernhard Stegmaier
a786078747
Fix clang-mp build error (don't declare const variables as being firstprivate)
2018-03-04 12:22:12 -05:00
Jeff Young
b3884669cf
Proper error reporting for Annotate dialog.
...
Also fixes:
- forcing the annotation scope to "full schematic" when run
as a prerequisite to Generate Netlist.
- a long-standing bug where displaying extra items in a dialog
would mess up the height of the HTML_REPORT_PANEL (becasue
we were setting the html window's height rather than its
parent flexgrid.
- initializing the annotation radio buttons to safe values
(full schematic and keep existing)
Fixes: lp:1750062
* https://bugs.launchpad.net/kicad/+bug/1750062
2018-02-18 15:08:24 -05:00
Jeff Young
1afbfad44a
Use "..." uniformly in menus.
...
See the bug report for some wording changes and a couple of
menu restructurings that were also cleaned up.
Fixes: lp:1597827
* https://bugs.launchpad.net/kicad/+bug/1597827
2018-02-10 17:32:28 -05:00
Jean Philippe EIMER
e0f7958dbd
Compatibility fixes for GLM 0.9.9
...
Fixes: lp:1746546
* https://bugs.launchpad.net/kicad/+bug/1746546
2018-02-06 13:30:13 +01:00
jean-pierre charras
5d72aebd22
Fix code after renaming files
2018-01-29 16:40:22 +01:00
jean-pierre charras
4c5bd01887
Rename a few files
2018-01-28 22:02:31 +01:00
jean-pierre charras
5d08f1a0d9
Breaks the large create_layer_items.cpp file into 2 smaller specialized files, to make changes in 3D shapes calculations more easy.
2018-01-28 14:05:17 +01:00
Wayne Stambaugh
650207a6e1
Pcbnew: fix 3D viewer panel default size issue.
...
The 3D viewer panel had a default size that was causing sizing issue
with the footprint properties dialog. Set the default size to -1;-1
and set the proportion setting to 1 when adding the panel to the sizer
which allows the panel to file in the correct size.
Fixed some minor control spacing issues in the footprint properties
dialog properties tab.
Please note that is only a partial fix for this issue. There is still
too much vertical space which is partially due to the use of wxSpinCtrl
instead of wxDoubleSpinCtrl.
Fixes lp:1742701
https://bugs.launchpad.net/kicad/+bug/1742701
2018-01-12 20:58:44 -05:00
jean-pierre charras
6f2beebf2c
PANEL_PREV_3D: replace wxStaticBoxSizers by a wxBoxSiser and a static text.
...
On KDE, wxStaticBoxSizers do not work very well (incorrect sizes).
2018-01-11 18:14:50 +01:00
Camille
f5f7ba4746
Fix loop variable copy in for-range loop, use const reference instead
2018-01-09 19:18:44 -05:00
Camille
5c4f8abd24
Fix type promotion in math function
2018-01-09 19:11:27 -05:00
Camille
9ff66a5274
Fix unnecessary value parameter detected by clang-tidy. - Replace value parameter by const reference parameter or move-assignement in some cases
2018-01-09 18:55:51 -05:00
Mark Roszko
b98cc0b937
Some coverity fixes
2018-01-05 22:51:03 -07:00
Thomas Pointhuber
786ac8143e
Request refresh of 3d canvas on resize event
...
This is a partial fix for https://bugs.launchpad.net/kicad/+bug/1695897
2018-01-05 07:25:13 -07:00
jean-pierre charras
5ca5783448
3D viewer, view options dialog: add missing option.
2017-12-28 14:14:46 +01:00
jean-pierre charras
00c2257b26
3D viewer: Remove outdated option "show holes in zones" that was no longer used in opengl mode, and useless in ray tracing
...
(it was only used to reduce the calculation time)
Also add a wxBusyCursor when rebuilding the 3D scene.
2017-12-28 11:01:10 +01:00
jean-pierre charras
27171e1a88
3D viewer: re-enable 3D viewer display options, and update this dialog.
2017-12-28 09:30:18 +01:00
Wayne Stambaugh
4d64a2f53f
Set reasonable 3D model select dialog default path.
...
Passing an empty path to the 3D model select dialog results in the file
select control displaying the root path which requires the user to drill
down to get to the 3D models. Use the KISYS3DMOD path as the default
and fall back to the project path as required for the initial file
select control path.
Clean up some coding policy violations.
Fixes lp:1737094
https://bugs.launchpad.net/kicad/+bug/1737094
2017-12-27 12:43:26 -05:00
Wayne Stambaugh
71ea6dc2b9
Common, 3D viewer, CvPcb, and Eeschema dialog tweaks.
...
Improve dialog layout and fix UI policy issues with all of the dialog
boxes in the common, 3D viewer, CvPcb, and Eeschema code paths.
Updated the use of component to symbol.
2017-12-26 09:38:45 -05:00
jean-pierre charras
d9a2b5161c
Fix issues due to internal code change in DRAWSEGMENT class, for S_POLYGON shape.
...
Remove also duplicate code in 3D viewer, for this DRAWSEGMENT shape.
2017-12-21 15:07:03 +01:00
Bernhard Stegmaier
0135d11412
Fix macOS pinch-to-zoom for 3d-viewer.
2017-12-18 16:26:01 +01:00
Bernhard Stegmaier
909d95b5be
Create HIDPI_GL_CANVAS wrapper for transparent wxGLCanvas HiDPI/Retina support. Enable HiDPI/Retina for 3d-viewer.
2017-12-18 16:26:01 +01:00
Jon Evans
48388695ae
Use explicit shift in hotkeys instead of mixed-case characters
...
Because of how wxMenuItem decodes the label text, the case of
alphabetic hotkeys is not preserved when displaying the menu. So,
alphabetic hotkeys that use the Shift key must be defined this way.
Fixes: lp:1737303
* https://bugs.launchpad.net/kicad/+bug/1737303
2017-12-09 19:59:55 +01:00
jean-pierre charras
68268973b7
To avoid mistakes between graphic layers for pads, holes and not plated holes, rename 3 GAL_LAYER_ID names:
...
LAYER_NON_PLATED to LAYER_NON_PLATEDHOLES
LAYER_PADS_HOLES to LAYER_PADS_PLATEDHOLES
LAYER_PADS to LAYER_PADS_TH
and add comments and fix a render issue in gal mode for non plated holes.
2017-11-29 09:48:41 +01:00
Oliver
b80449b069
Fixes for 3D model offset
...
- Display offset units in 3D preview window (inches or mm)
- Fix offset in 3D renderer
- Fix offset in Raytracing renderer
- Fix offset in STEP export
- Fix offset in VRML export
2017-11-20 17:46:03 -05:00
jean-pierre charras
10de79260d
Fix an assert when starting the 3D viewer in Debug mode (Linux only)
...
Fixes: lp:1731344
https://bugs.launchpad.net/kicad/+bug/1731344
2017-11-17 10:20:55 +01:00
Wayne Stambaugh
f3908bd87c
Revert premature commit of 17ab319b
, "Fixes for 3D model offset".
...
This reverts commit 17ab319b99
.
2017-11-11 20:04:46 -05:00
Oliver
17ab319b99
Fixes for 3D model offset
...
- Display offset units in 3D preview window (inches or mm)
- Fix offset in 3D renderer
- Fix offset in Raytracing renderer
- Fix offset in STEP export
- Fix offset in VRML export
2017-11-11 15:08:08 -05:00
Marvin Schmidt
69974b73db
Remove some extra semicolons
2017-11-09 19:52:18 +01:00
jean-pierre charras
1c356899ab
Fix wxWidget warning in panel_prev_3d_base.cpp dialog
2017-11-07 09:43:27 +01:00
Tomasz Włostowski
81d1e17f02
refactoring: renamed pcbstruct.h to pcb_display_options.h, DISPLAY_OPTIONS->PCB_DISPLAY_OPTIONS
2017-11-03 20:02:06 +01:00
Tomasz Włostowski
90ab5860dc
refactoring: removed dependency of libpcbcommon on 3d-viewer.
2017-11-03 20:01:42 +01:00
jean-pierre charras
e0b9a21417
Modify a few messages to make translations more easy.
2017-10-12 10:39:32 +02:00
Baranovskiy Konstantin
4612a52b50
3D Viewer: fixed entry labels in popup menu.
2017-09-29 15:31:36 +02:00
Maciej Suminski
068a29952c
Changed AUI toolbars background from gradient to solid
...
Based on patches from Windsor Schmidt <windsor.schmidt@gmail.com>
2017-09-27 23:23:06 +02:00
jean-pierre charras
a43f3ab1fe
replace "BasicShape" by "Primitive" in code, a better name
2017-09-20 12:51:10 +02:00
jean-pierre charras
e2d3fcec02
Add support for custom pad shape. Full support in DRC and PnS.
...
add option to use shape or convex hull as clearance area in zones.
simplify code to handle clearance area
2017-09-19 09:02:53 +02:00
jean-pierre charras
e15acbb00d
Fp editor and board editor have now a separate color setup.
...
fp viewer uses the default colors, because it has no color setup dialog.
class_colors_design_settings: remove not used members.
Fix issue in modedit: the color config was never read.
2017-09-11 18:51:48 +02:00
Maciej Suminski
55c7d9816e
Traverse 3D viewer plugin subdirectories in debug build directory
...
Before the change, the plugins had to be installed to one of the default
search paths, but it should not be necessary for developers working on
3D viewer plugins.
2017-08-21 14:17:01 +02:00
jean-pierre charras
2e96a5bc9f
Pcbnew: fix a crash when editing footprint properties and trying to open the footprint 3D properties.
...
This was due to a missing initialization of the dummy board color settings (used to draw the footprint in the 3D view).
Fixes: lp:1708712
https://bugs.launchpad.net/kicad/+bug/1708712
2017-08-05 16:37:51 +02:00
Tomasz Włostowski
32185ddcd3
Multiple improvements concerning colors, configuration handling and legacy features in pcbnew:
...
- support for background color setting
- removed several global config settings (such as g_Drc_On)
- wrapped most of global config settings in PCB_GENERAL_SETTINGS class
- reorganized PCB general options dialog to clearly mark which options concern only the legacy canvas
- new GAL feature for legacy users: double-click (or E) to change track width available as an option.
Fixes: lp:1530543
* https://bugs.launchpad.net/kicad/+bug/1530543
Fixes: lp:1707145
* https://bugs.launchpad.net/kicad/+bug/1707145
2017-08-04 16:06:57 +02:00
jean-pierre charras
43084daa40
Fix a few doxygen warnings
2017-07-03 10:45:56 +02:00
Maciej Suminski
1e87ae6c50
Fixed a memleak in raytracer
2017-06-27 10:58:43 +02:00
jean-pierre charras
6a3c1720b2
Fix a few doxygen warnings
2017-06-25 11:26:04 +02:00
Tomasz Włostowski
3b16d3cffe
further DLIST/Iterators cleanup, some code formatting
2017-06-23 11:12:37 +02:00
Tomasz Włostowski
94a80acb36
DLIST_ITERATOR improvements
2017-06-23 11:12:36 +02:00
jean-pierre charras
70226ecdeb
Fix a few doxygen warnings
2017-06-20 10:47:30 +02:00
Wayne Stambaugh
66e97fa905
Doxygen comment improvements.
...
Fix lots of Doxygen warnings.
Fix Doxygen comment for IO_MGR::FootprintEnumerate() which was recently
changed.
2017-06-13 19:47:46 -04:00
Kristoffer Ödmark
19d5cc7548
Removed all exception specifiers since deprecated.
...
Exception specifiers are deprecated in cpp11, so went through them all
and removed them from the code.
2017-06-12 13:54:55 -04:00
Simon Richter
d5e85726ea
Doxygen improvements
2017-06-11 18:09:14 -04:00
Simon Richter
a9ca1e9930
Remove unreferenced local variables
2017-06-11 17:52:49 -04:00
Fabrizio Tappero
ac9a64a173
general UI fix. Fixed a lot of icons and a lot of menu.
...
Also a few no longer used .cpp icon files are removed.
2017-06-02 11:51:11 +02:00
jean-pierre charras
200df95f00
fix bug (incorrect validation, on Windows only) in S3D_FILENAME_RESOLVER::ValidateFileName().
2017-05-28 18:56:49 +02:00
jean-pierre charras
1fda668f24
3D viewer: cosmetic enhancements: fix an incorrect icon, and add shortcut keys in right popup menu.
...
Also fix an incorrect legend in hotkey list.
2017-05-26 13:28:51 +02:00
jean-pierre charras
305a166e95
Pcbnew: update immediately the 3D viewer opened from the footprint editor/viewer/wizard after a change.
2017-05-13 08:17:06 +02:00
Cirilo Bernardo
68a7a5235e
Fix 3D plugins mutiarch support.
...
Use CMAKE_INSTALL_LIBDIR instead of wxStandardPaths::GetPluginsDir() to
determine plugin directory.
Fixes lp:1682812
https://bugs.launchpad.net/kicad/+bug/1682812
2017-04-18 09:11:53 -04:00
jean-pierre charras
6eb2000b69
fix Coverity warning (CID 151565) (CID 155147)
2017-04-01 20:05:33 +02:00
Jon Evans
3ec28e2acf
Refactor layer enumerations to all live in the same place
2017-03-30 16:01:48 -04:00
jean-pierre charras
68b141dcb8
Make polygon built by BOARD::GetBoardPolygonOutlines strictly simple.
...
It fixes issues in 3d viewer (crashes and incorrect 3D board outline in some cases)
Fixes: lp:167484
https://bugs.launchpad.net/kicad/+bug/1674844
2017-03-23 08:56:52 +01:00
jean-pierre charras
05220a86f1
BOARD::GetBoardPolygonOutlines(): do not generate a separate SHAPE_POLY_SET for holes.
...
They are already managed by SHAPE_POLY_SET board outline.
2017-03-22 11:47:03 +01:00
Kristoffer Ödmark
d6dd176aca
Changed default increment values and added shift+scroll for fine tuning
...
Fixes: lp:1669550
* https://bugs.launchpad.net/kicad/+bug/1669550
2017-03-13 11:25:40 -04:00
jean-pierre charras
bbedad3456
Fix a Coverity warning, which looks like a (minor) bug in ccontainer2d.cpp.
2017-03-13 12:53:01 +01:00
Maciej Suminski
14cbdcec1f
Fixed mismatched new[]/delete in 3D viewer
2017-03-08 09:12:16 +01:00
Cirilo Bernardo
68bcdec87e
Workaround for non-ASCII filenames in Windows
2017-03-03 14:30:47 -05:00
Kristoffer Ödmark
49c7400ca9
Reallow large scaling of 3D models
...
Fixes: lp:1669510
* https://bugs.launchpad.net/kicad/+bug/1669510
2017-03-03 10:30:09 -05:00
Maciej Suminski
1dfd74bec9
Display S3DSG in single line during CMake configuration step
2017-03-03 13:38:12 +01:00
Kevin Cozens
458b0e75e0
Prevent raytracing render engine option from crashing the 3D viewer
...
Fix for lp bug #1667722 using a change made by Mario Luzeiro.
Fixes lp:1667722
https://bugs.launchpad.net/kicad/+bug/1667722
2017-03-01 18:34:19 -05:00
Simon Richter
70b3edd06f
Drop unnecessary and possibly harmful optimization setting
...
Using -O3 is default for release builds with gcc/clang anyway, so this
doesn't gain anything, but overwriting the existing flags might remove some
that might be needed.
2017-02-23 14:44:15 -05:00
Maciej Suminski
0dc88bb4cf
Changed COLOR4D defines to static consts
2017-02-22 17:35:00 +01:00
Jon Evans
a52250a91e
Change from EDA_COLOR_T to COLOR4D globally; arbitrary color support
...
eeschema now supports arbitrary colors for all object types, and
pcbnew does in GAL canvas. When switching from GAL to legacy canvas,
pcbnew will convert colors to the nearest legacy color.
2017-02-22 17:35:00 +01:00