Jeff Young
826b72c499
Don't suppress hole plotting for utility layers.
...
Also simplifies the handling of DXF outline plotting.
Also removes some comments which were no longer accurate.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17166
2024-05-20 19:48:06 +01:00
Mike Williams
52f9060b3b
Symbol Fields Table: make sure power symbols don't get added by commits
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/17544
2024-05-20 14:11:38 -04:00
Mike Williams
a81891053e
Schematic: add Power tab to searcher
2024-05-20 13:59:42 -04:00
Mike Williams
8e286d44fc
Update Footprint: add checkbox for text content
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/17935
2024-05-20 09:16:04 -04:00
Mike Williams
21022b4fa4
Symbol Fields Table: better handle variable fields with attributes
...
Attributes need to be checked first since we do some internally hackery
to make the checkboxes work.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/18005
2024-05-20 08:52:00 -04:00
John Beard
ce758adca3
Enable horizontal scroll panning
...
Allow a horizontal scroll event to fall through to the panning branch.
This still restricts zooming to use only the vertical axis, but it
(re-?)enables the horizontal pan function that currently doesn't work
even if the user has set "allow horizontal panning", as the horizontal
scroll doesn't have a modifier, which is the default for vertical scroll
zoom, and thus it skips over the whole panning branch.
If the user has not set horizontal panning, the earlier early return
means that there is no handling of any horizontal scroll event, so this
won't change anything for these users.
2024-05-20 19:23:23 +08:00
John Beard
caee430761
No longer auto-set the Footprint field when setting the FPID
...
This avoids forcing the field to the footprint name in the
library editor, which gets in the way. This doesn't specifically
inhibit the use of the field, and doesn't interfere with fields
users may have set manually (it can be cleared manually if
wished).
Removing the footprint field entirely either from all footprints
or from footprints in fpedit is quite a bit more invasive to
existing designs.
(cherry picked from commit 44b0ef64e8
)
Cherry-picking forward to master to at least keep things consistent
for the time being.
Relates-To: https://gitlab.com/kicad/code/kicad/-/issues/17998
2024-05-20 17:32:02 +08:00
John Beard
6992afeb38
Consider a bus entry hitting a wire corner or tee to be dot-worthy
...
This doesn't change the connectivity, it just makes putting the
dot more closely match what the connectivity already does.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/18046
2024-05-20 12:40:29 +08:00
John Beard
6313b58ad6
Break out junction analysis so it can be tested in isolation
...
There are some corner cases with bus entries that could do with
care and it's a bit tricky to keep all the cases in mind at once!
2024-05-20 12:40:29 +08:00
John Beard
d3e03c51bf
Bus unfold: snap the entry to the bus, even if the cursor isn't right on the bus
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/18011
2024-05-20 12:40:06 +08:00
Alex Shvartzkop
615f216ef6
STEP export: don't double-check the wire.
2024-05-19 04:08:43 +03:00
Alex Shvartzkop
1a0ce67155
STEP export: reverse Wire when adding it to Face as a hole.
...
Better fix for https://gitlab.com/kicad/code/kicad/-/issues/17446
(cherry picked from commit 1264230973
)
2024-05-19 04:02:35 +03:00
Alex Shvartzkop
6dd5c7d733
Make IBIS errors visible / more obvious.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18041
(cherry picked from commit 6dfd417767
)
2024-05-19 01:44:56 +03:00
Jon Evans
90ee5e097a
Clear undo/redo lists when removing board layers
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17613
2024-05-18 18:16:07 -04:00
Jon Evans
7a3db2d176
Don't drag multiple coincident vias
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17915
2024-05-18 17:50:52 -04:00
Alex Shvartzkop
3f704cb1f1
Fix an assert in isCopperOutside.
...
(cherry picked from commit dfd8aa402d
)
2024-05-18 22:52:41 +03:00
Alex Shvartzkop
e00219f459
STEP export: allow closing (and constructing) the wire with 1nm edges.
...
This is ok (and required) because we don't mess with BRepBuilderAPI::Precision nowadays.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18030
(cherry picked from commit 5b1c84b5dd
)
2024-05-18 22:52:41 +03:00
Jon Evans
aaf3142e9a
Fix broken hit test for arcs in via placer
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17844
2024-05-18 13:12:12 -04:00
Jeff Young
d82b149f29
Make hole-to-hole report tag match constraint name.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18040
2024-05-18 15:44:03 +01:00
Jon Evans
4f3117aea0
Altium: avoid crash when imported zone has no fill
...
Fix https://gitlab.com/kicad/code/kicad/-/issues/18025
2024-05-17 20:16:01 -04:00
Jeff Young
af5ed5a118
Reset zone offsets when exporting footprints.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17794
2024-05-17 21:28:30 +01:00
Jeff Young
ea72beb2f7
Remove & then re-add undo items to parent group.
...
Removing the item from the board will also remove it
from any parent group, which then wasn't getting
restored. This makes it more clear that we need to
remove and then re-add.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18017
2024-05-17 19:34:21 +01:00
Jon Evans
7f03666f96
Support LIB_ID queries in searchFootprints too
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18039
(cherry picked from commit fee0028ee9
)
Co-authored-by: Jon Evans <jon@craftyjon.com>
2024-05-17 17:57:42 +00:00
Jeff Young
25bb3f77fa
Fix keep-upright algo for footprint text.
...
Also removes PCB_FIELDs from rotation centre calc in
footprint editor if there is other stuff selected.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16896
2024-05-17 18:34:44 +01:00
Alex Shvartzkop
0772739cf1
3D model export: Improve 3D layer placement calculation algorithm.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18035
2024-05-17 18:20:24 +03:00
Jon Evans
4c42f5dae0
Remove extra NeedRIGHT in textbox parser
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18033
2024-05-17 09:05:04 -04:00
Jeff Young
26906f383c
Expose violation severity for co-located holes.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18028
2024-05-17 11:15:44 +01:00
Jeff Young
c5162f5483
Fix PEGTL flagParam grammar.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16393
2024-05-17 11:15:44 +01:00
John Beard
7e02f1254e
Remember the bus unfold label orientation between invocations
2024-05-17 09:55:40 +08:00
Jon Evans
2836025402
Clear field listener when quitting
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18016
2024-05-16 20:49:27 -04:00
Alex Shvartzkop
fd438cb8e0
VRML to XCAFDoc reader is only available in OCCT 7.7.0+
2024-05-16 22:52:19 +03:00
Alex Shvartzkop
8fd12d8b7e
Allow reading VRML models for glTF export.
...
Note that some VRML 2.0 models fill fail until our patches are integrated into OCCT 7.9.0.
2024-05-16 21:57:48 +03:00
Seth Hillbrand
5e5741edd3
Minor optimizations
...
Most of the lines in KiCad are on 45° angles. We can avoid sqrts by
recognizing that this implies the x/y values are the same. Therefore,
the length of the hypotenuse is sqrt(2) * x.
2024-05-16 11:50:48 -07:00
Seth Hillbrand
9fbda137cb
Free item memory when closing schematic window
...
This fires the dtor for each item on the screen, allowing us to properly
close and remove them from the connection graph
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17961
2024-05-16 09:59:10 -07:00
Seth Hillbrand
f61ee3ff4b
Remove unused code generation path
...
After 11 years, I doubt we're making this file format
2024-05-16 09:19:06 -07:00
Jeff Young
f7bef5e09b
Generalize EnhanceAttr() function.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17735
2024-05-16 16:28:13 +01:00
jean-pierre charras
87d3d38552
Eeschema, Pin helpers: fix wrong label orientation if the symbol is rotated
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18012
2024-05-16 17:15:06 +02:00
Jeff Young
ea013f3ca3
Fill device colour on foreground layer.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18002
2024-05-16 15:24:11 +01:00
Alex Shvartzkop
2179685dd2
STEP export: Use TDocStd_XLinkTool to copy model with colors instead of our DIY routine.
...
Now supports older OCCT versions.
Also puts components at a higher level in the hierarchy.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17549
2024-05-16 13:01:40 +03:00
Jeff Young
a4583fdbc1
Separate out selection processing for dragging footprints.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18010
2024-05-16 10:27:54 +01:00
dsa-t
e2294a769a
Revert "STEP export: Use TDocStd_XLinkTool to copy model with colors instead of our DIY routine."
...
This reverts commit f735c9bdc2
2024-05-15 22:55:19 +00:00
Jeff Young
98f4e60b90
Contour cache must be sensitive to size.
...
(While we scale the contours afterwards, font hint
data is size-sensitive so the contours are already
size-specific.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/18014
2024-05-15 23:36:57 +01:00
Alex Shvartzkop
f735c9bdc2
STEP export: Use TDocStd_XLinkTool to copy model with colors instead of our DIY routine.
...
Also puts components at a higher level in the hierarchy.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17549
2024-05-16 01:33:06 +03:00
jean-pierre charras
f17b13655b
DIALOG_SYMBOL_FIELDS_TABLE::syncBomPresetSelection(): fix not working comparison
...
for non English languages.
The main issue was the function compared a English string to a translated string.
However, even with this fix, the code, although working, is not very good:
It compare 2 members (BOM_PRESET .sortField string) that are not very significant
and can be or not translated.
2024-05-15 16:25:05 +02:00
Jeff Young
498d2c9db1
Lazily re-evaluate worst-clearance cache.
...
This prevents crashes when trying to re-evaluate
during destruction, etc. and is a cleaner solution
than trying to keep a flag updated.
It should also be a performance win for very large
documents.
Also implements proper threadlocking for the cache.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17950
2024-05-15 14:11:11 +01:00
Jeff Young
e0e9321ea9
Consistency in command names.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17314
2024-05-15 13:50:42 +01:00
Alex Shvartzkop
18fde2b9cb
Fix background transparency option in kicad-cli pcb render.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17865
2024-05-15 14:46:53 +03:00
Jeff Young
20b2e11f21
Only toggle net selection when coming from hotkey.
...
(The context menu has separate commands for highlight
and clear highlight.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17709
2024-05-15 12:44:33 +01:00
Jeff Young
02bc093b55
Use consistent sorting for footprint libs.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17731
2024-05-15 10:56:09 +01:00
Jeff Young
9e1330184c
Patch another dynamic_cast-across-compile-unit-boundaries issue.
2024-05-15 10:55:51 +01:00