haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
43,283 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

346 Commits

Author SHA1 Message Date
Mike Williams 6ae8968a5b Symbol Fields Table: add selection controls 
Allows cross-probing to other editors.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/8188
 2023-08-07 15:05:24 -04:00
Mike Williams 457e58d0d5 Schematic: select connections working for multiple selection 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/11022
 2023-08-03 11:27:29 -04:00
Jon Evans 35c372a072 Support expanding selection for schematic graphic lines 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/12032
 2023-08-01 21:22:35 -04:00
jean-pierre charras 5ea170baab Symbol editor: fix crash when trying to "drag" an item. 
Drag or move is an option of the schematic editor, and not in symbol editor.
So it cannot be tested in code for the symbol editor.
Fixes #15264
https://gitlab.com/kicad/code/kicad/-/issues/15264
 2023-07-26 08:58:22 +02:00
Mike Williams 132a0ada73 Grid Overrides: support grids-per-type that override the current grid. 
Schematic only at this point while we test and refine.

PCB support is a future addition.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/14756
 2023-07-25 10:17:57 -04:00
Jeff Young 5419055acb We no longer need activate actions with RunSynchronousAction. 2023-07-16 14:43:29 +01:00
Jeff Young eedf319ba4 Don't double-offset effective text shapes. 
Also fixes several bugs with intersheet ref fields.  (It's possible for
other fields to have an ID of 0.)

Fixes https://gitlab.com/kicad/code/kicad/-/issues/15165
 2023-07-10 19:32:00 +01:00
Alex Shvartzkop 55b31030c0 Perf: don't search for niluuid items when moving cursor in eeschema. 
Reduces CPU usage by 60% in some cases.
 2023-07-03 02:15:05 +03:00
Ian McInerney 2fb6f19a84 Separate immediate and delayed action dispatch 
Using a boolean argument just leads to a lot of trailing booleans in the
function calls and is not user friendly. Instead, introduce PostAction()
to send an action that runs after the coroutine (equivalent to passing
false or the default argument), and leave RunAction as the immediate
execution function.
 2023-06-27 00:57:59 +01:00
Jeff Young 300a60e88e Eradicate a bunch of calls to dyn_cast. 2023-06-25 11:10:05 +01:00
Ian McInerney 19f5c16708 Ensure const-ness matches across draw wire event parameters 2023-06-21 14:06:25 +01:00
Ian McInerney 480223f67c More RunAction specialization 2023-06-20 21:52:50 +01:00
Wayne Stambaugh e9dc00cda3 Minor schematic net navigator improvements. 
- Expand tree and highlight object selected with net highlight tool.
- Expand tree and highlight object that are currently highlighted with the
  selection tool.
- Use more descriptive object text rather than menu entry text for tree
  strings.
- Rebuild tree on unit changes.
 2023-06-09 14:34:54 -04:00
Jeff Young 4ed267394a Outline font performance improvements. 
1) Don't fracture font glyphs when generating them; we're going
   to fracture during triangulation anyway.
2) Don't check for self-intersection when deciding to fracture.
   It costs nearly as much as the fracture does.
3) Cache drawing sheet text.
4) Use the current font when checking for cache validity.
5) Parallelize glyph triangulation.
6) Don't invalidate bounding box caches when offset by {0,0}
7) Use the glyph cache when generating text effective shape.
8) Short-circuit NormalizeJustification() if its center/center.
9) Don't triangulate for GuessSelectionCandidates()
10) Avoid sqrt whenever possible.
11) Pre-allocate bezier and SHAPE_LINE_CHAIN buffers.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/14303
 2023-05-27 01:35:40 +01:00
Wayne Stambaugh 831a6d55fc Fix potential stale pointer bug in schematic highlight connection code. 
SCH_CONNECTION objects are temporary and can become stale any time the
connectivity is updated.  Keeping them around to reference later is a
bad idea.  Even if the object pointer is still valid in an SCH_ITEM in
the undo/redo buffers, comparing the pointer against another pointer as
a test to see if they are the same connection is not valid.  Saving the
connection name is safe and ensures the connection is the same even if
the pointers differ.
 2023-05-16 20:06:21 -04:00
Jeff Young 49655ae742 Defense in depth for "mouse stuck in canvas". 
Fixes https://gitlab.com/kicad/code/kicad/issues/12653
 2023-05-06 11:28:14 +01:00
Jeff Young e1b39946fe ADDED: show/hide controls for directive labels. 2023-04-28 00:32:49 +01:00
Jeff Young 66f48d56ae Separate sheet reloads (MODEL_RELOAD) and schematic reloads (SUPERMODEL_RELOAD). 
Fixes https://gitlab.com/kicad/code/kicad/issues/14523
 2023-04-12 11:51:09 +01:00
Jeff Young a9b2234f4e Use a softer Reset for grid settings. 
Fixes https://gitlab.com/kicad/code/kicad/issues/14458
 2023-04-04 17:05:21 +01:00
Jon Evans 053d20e13d Fix selection overlay being wiped when changing sheets 2023-02-16 17:14:08 -05:00
Jon Evans 0f18a36f8f Fix handling of selection overlay in schematic editor 
We weren't actually using the overlay group at all

Fixes https://gitlab.com/kicad/code/kicad/-/issues/11142
 2023-02-15 21:16:58 -05:00
James Jackson 661eed7fed Eeschema: ensure wire / bus auto-start respects bus labels 
Fixes #13506 and further ensures correct behaviour for heirarchical labels and sheet pins
 2023-01-15 19:25:28 +00:00
Jeff Young c3ca1ce014 Tune the hit-test extra-slop for lines (and apply it to arcs too). 
Fixes https://gitlab.com/kicad/code/kicad/issues/13429
 2023-01-07 23:06:51 +00:00
Mike Williams 068b714908 Schematic: merge dual import sheet pin actions 
I believe I have managed to keep the slightly distinct functionality of
both implementations: the action will now use the selected sheet or find
one under the cursor if it's there.

It will also keep placing pins while they exist, which was inconsistent
in the behavior of the single click version before (other single click
commands keep placing until you cancel, e.g. no-connects )

Also, it will automatically end the tool when it runs out of sheet pins.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13296
 2022-12-29 09:36:29 -05:00
Mike Williams 9b782fa827 Schematic: don't deselect line ends when right clicking off-selection 2022-12-22 14:16:38 -05:00
Mike Williams 8b7d0d71fb Schematic: show update/change symbols for multiple symbol selection 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13231
 2022-12-22 14:00:51 -05:00
Mike Williams 389f0655cd Schematic: re-enable old break wire functionality, add slice 
Also fix break/slice wires for multiple wires. The shortcut and code
always allowed it, the context menu just didn't appear.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13163
 2022-12-19 15:55:59 -05:00
Mike Williams 243727428a Selection: non-greedy box selection of wires ends only when dangling 
See discussion:
https://gitlab.com/kicad/code/kicad/-/issues/13022#note_1205902448
 2022-12-12 15:04:33 -05:00
Mike Williams 5ce0fe5998 Selection: drop non-greedy full line selection from middle 
It's too inconsistent to have greedy and non-greedy mode, and also have
tweaks to the non-greedy mode that make it greedier.
 2022-12-12 14:45:06 -05:00
Mike Williams f4fb70e04c Schematic: re-allow partial selection of line ends 
Also fix some XOR selecting issues.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/13022
 2022-12-10 13:17:42 -05:00
Mike Williams 0e75bf02fa Selection: refactor modifier checking 2022-12-08 14:12:12 -05:00
Mike Williams 4b02e5efb4 Schematic: allowing ctrl/shift-clicking point editor points 2022-12-08 14:12:12 -05:00
Mike Williams 8f646fa9fb Schematic: fix XOR unselecting one end of fully selected line 2022-12-01 15:00:06 -05:00
Jeff Young 651b3f1349 SCH_FIELDs are in parent's coord system. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12979
 2022-11-23 13:22:50 +00:00
Alex 12a55f20d3 Fix a mistake in grip margin. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12952
 2022-11-21 00:25:19 +05:00
Jeff Young b84066610e Use drag origin instead of current mouse pos for drag checking. 2022-11-19 21:01:45 +00:00
Jeff Young 9d8fdd8d53 Fire selection events from SelectAll(). 
Fixes https://gitlab.com/kicad/code/kicad/issues/12896
 2022-11-13 22:59:21 +00:00
Jeff Young 1825905011 Replace more-than-half-line algorithm with greedy/stingy check. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10860
 2022-10-10 20:23:48 +01:00
Jeff Young cb20a39693 Always select whole lines with greedy selection. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10869
 2022-10-10 20:17:15 +01:00
jean-pierre charras fd4cd17f4f fix a compil warning 2022-09-20 18:55:20 +02:00
Jeff Young 30a4d3d2de Coverity fixes. 2022-09-20 00:19:15 +01:00
Marek Roszko 61e11d6896 Strip out Mils2Iu 2022-09-16 21:09:27 -04:00
kliment b97f9ea329 Add support for symbol unit display names in eeschema and symbol editor 2022-09-14 22:11:37 +00:00
Jeff Young f2abf0832a Filter pins by unit. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12076
 2022-09-09 13:41:13 +01:00
Alex d67c81a657 When deselecting items, pick only selected ones. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10292
 2022-09-06 19:44:29 +00:00
Jeff Young ebe9617e77 More EDA_RECT expungification, and an attempt to fix the python test. 2022-08-31 17:19:48 +01:00
Jeff Young 5679b9dbdc Remove a few EDA_RECT instances. 2022-08-31 01:22:49 +01:00
Seth Hillbrand b736460e71 Move optional access from value() to *operator 
`value()` throws.  Where we check for existence, we don't need to use
the throwing version and should just use the unprotected variant
 2022-08-30 13:59:39 -07:00
Jeff Young 122a6d7f46 Move hypertext linking to user-page-numbers. 
Also moves most navigation code to SCH_NAVIGATION_TOOL.
Also changes page number href to anchor syntax ('#foo').
Also adds hypertext processing to SCH_TEXTBOXes.
Also adds combobox with schematic pages to text properties dialog.
 2022-08-27 19:17:43 +01:00
Seth Hillbrand f1261e71d4 Replace boost::optional with std::optional 2022-08-25 15:50:47 -07:00
Alex 3a76d42630 Cross-probing/selection for multiple items (PCB -> SCH) 
Fixes https://gitlab.com/kicad/code/kicad/issues/10469
 2022-08-22 19:33:39 +00:00
Jeff Young 4f0136db3b Attempt to fix std::initializer_list lifetime issue. 2022-08-21 20:54:41 +01:00
Jeff Young aa2ad3b44c Move KICAD_T[] to std::initializer_list<KICAD_T>. 2022-08-20 10:28:11 +01:00
jean-pierre charras 993c446fdf Fix some warnings detected by PVS-STUDIO (most are not used vars) 2022-07-25 18:23:52 +02:00
Jeff Young 3def3d659e Allow click-selection and greedy-drag selection of visible pin text. 
Stingy drag still works only on the pin itself.

Fixes https://gitlab.com/kicad/code/kicad/issues/11723
 2022-07-23 23:27:14 +01:00
Jeff Young f48755cc67 Restore unique-item filtering when collecting nearby items from view. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12076
 2022-07-23 15:09:58 +01:00
Jeff Young cb77e68076 Don't assume a SCH_EDIT_FRAME in EE_SELECTION_TOOL. 
It's also used in the symbol editor.

But in any case, pins of other units have no business being in an
SCH_SYMBOL anyway.

Fixes https://gitlab.com/kicad/code/kicad/issues/12076
 2022-07-23 14:28:07 +01:00
Jeff Young 0d5302f375 Add preference for esc-clears-net-highlighting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8760
 2022-07-23 10:32:43 +01:00
Jeff Young 45393f228a Promote pin selections to symbols when preference is set. 
Also make additional line slop zoom-relative.

Fixes https://gitlab.com/kicad/code/kicad/issues/12034
 2022-07-19 10:31:49 +01:00
Jeff Young e5a664c6b3 Try a slightly different tack for cancelling net highlighting. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12029
 2022-07-19 10:31:49 +01:00
Alex c6d9dcdad5 Schematic editor: allow box-selecting pins. 2022-07-18 18:51:52 +00:00
Alex d343d87b73 Speed-up EE_SELECTION_TOOL::RequestSelection. 2022-07-18 18:51:52 +00:00
Jeff Young 57acce9e55 Share more code between selection tools. 2022-07-11 19:04:08 -06:00
Jeff Young 4685dc49cc Show more than 9 items in disambiguation menu. 
(But only the first 9 get hotkeys.)

Fixes https://gitlab.com/kicad/code/kicad/issues/11966
 2022-07-10 20:11:22 -06:00
Jeff Young b759d860c0 Don't disambiguate if the user is dragging a multiple selection. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10108
 2022-07-10 19:45:56 -06:00
Jeff Young e122dc38bd Add context menu item for clearing net highlighting. 
In selection tools, drawing tools, router tool, line_wire_bus tool.

Fixes https://gitlab.com/kicad/code/kicad/issues/11920
 2022-07-10 17:15:20 -06:00
Jeff Young 00fc225306 Give <esc>-with-no-selection-clears-net-highlight a test. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8760
 2022-07-09 11:56:16 -06:00
Mike Williams 857990a883 Hierarchy: turn into a left side pane 
Drop auto-closing option as well.
 2022-06-02 21:56:17 +00:00
Jeff Young d5d8d36d86 Implement expanding Select Connection. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8579
 2022-05-29 22:51:33 +01:00
jean-pierre charras 38c54ffa8f Eeschema, Symbol Library Browser: fix crash when left clicking on the canvas. 2022-04-17 09:54:19 +02:00
Seth Hillbrand 250a246761 Clear flags after we're done with them 
The CANDIDATE flag is a temporary element that should not be maintained
outside of the routine in which is it temporarily set

Fixes https://gitlab.com/kicad/code/kicad/issues/11361
 2022-04-16 15:45:17 -07:00
Jeff Young 546b3bfbc0 Select wire ends in select all. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10958
 2022-04-11 19:36:54 +01:00
Mike Williams e51ab86225 Schematic Drag: fixes and improvements 
Fixes:
* Various special cases around junctions on pins and dragging.

* Some rotations of endpoints resulting in a 45 degree rotate.

* Some cases where it was possible to get a line with neither
  endpoint selected, and also substractive unselecting only one of two
  selected endpoints unselecting both.

* Use line midpoint for sorting.  Start and endpoints aren't
  consistent in the order they appear on the X or Y axis. So,
  we need to use the midpoint for our position for consistent
  sorting when dragging groups of parallel lines where some
  have the start and end reversed.

Other:
* Rename TEMP_SELECTED TO SELECTED_BY_DRAG. This is the actual meaning
  of the flag, and should reduce confusion as
  to when it should be used.

* Move usage of TEMP_SELECTED as an algorithmic mark to CANDIDATE
  instead.

* Fix mistaken clearing of START_POINT and ENDPOINT.

* Move endpoint setting and clearing out of narrowSelection, and into
  selectPoint and selectMultiple.

* Don't show dangling end warnings on new lines
 2022-03-28 16:02:48 -04:00
Jeff Young 63b5ad7df1 Fix some issues with global-label fields' bounding boxes. 2022-03-19 19:37:01 +00:00
Jeff Young 39fa4e2065 Include textbox in movable objects. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11058
 2022-03-07 10:33:59 +00:00
Mike Williams 5503afc09a Schematic: disallow center rotation, allow both endpoint rotations 
Center rotation will often misalign lines to the grid, which is bad
until fix off grid items on the schematic.

We can rotate a connection end into a new connection or to become
collinear with an existing line, so we need to check for this at the end
of rotation.

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10565
(cherry picked from commit 7d4cb91f39)
 2022-02-28 08:50:12 -08:00
Jeff Young c4d2ac570f Don't allow break commands (or labelling cmds) on multiple wire selections. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10934
 2022-02-27 23:15:07 +00:00
Seth Hillbrand 535ea800c0 Honor modifier keys in diambiguation 
Needs to be reset for the new action before selecting elements at a
point.

Fixes https://gitlab.com/kicad/code/kicad/issues/9712

(cherry picked from commit a30ad0b54a)
 2022-02-25 16:16:15 -08:00
Jeff Young 6d8507d44f Formatting. 2022-02-25 17:36:35 +00:00
Mike Williams 567168fffc Schematic: make grabbing whole lines more intuitive 
Selecting end and midpoint will select whole line. Some changes for
orthogonal dragging made this worse than in 6.0.

Improves, but does not fully resolve:
https://gitlab.com/kicad/code/kicad/-/issues/10860
 2022-02-16 19:15:55 +00:00
Jeff Young 4e5b30ad80 Rewrite autostart to not need connectivity. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10579
 2022-02-14 01:15:06 +00:00
Mike Williams 013d6d088f Eeschema: fix pin starting wire bus bug 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10819
 2022-02-13 15:02:09 +00:00
Mike Williams a5e8575091 Eeschema: Implement orthogonal dragging 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1956
 2022-02-10 18:38:40 +00:00
Mike Williams 7c91cd73e3 Eeschema: unconnected ends of wire entries should allow auto start wires 2022-02-07 23:31:24 +00:00
Seth Hillbrand 38706fdd95 Fully select a line for transformation 
When not trying to select points, we need to ensure that the full
line is selected for transformation

Fixes https://gitlab.com/kicad/code/kicad/issues/10566

(cherry picked from commit 70d00689ca)
 2022-01-29 17:37:30 -08:00
Jeff Young 3409783d9f Break sch_text.h/.cpp into sch_text and sch_label. 
Also moves SCH_NETCLASS_FLAG to SCH_DIRECTIVE_LABEL, and remaps Altium
harnesses from SCH_TEXT to SCH_DIRECTIVE_LABEL.
 2022-01-28 21:38:15 +00:00
Mike Williams ecb32b1fb0 Eeschema: hover start from wire end should copy wire properties 
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/10128
 2022-01-27 17:17:45 +00:00
dsa-t bc1ff6756f Cross-probing/selection for multiple items (SCH->PCB) 2022-01-16 20:29:03 +00:00
Seth Hillbrand 5a3d53d9e4 Catch default autowire case 
Since we are dereferencing the optional, we need to ensure it exists in
all cases

Fixes https://gitlab.com/kicad/code/kicad/issues/10394

(cherry picked from commit 56d87a8613)
 2022-01-12 09:03:44 -08:00
Roberto Fernandez Bautista 701e256b3f Correctly handle excluding an ERC marker in eeschema when right clicking 
In addition, hide the option to exclude a marker if the selected marker
is already excluded.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/10173
 2021-12-30 17:14:36 +00:00
Jeff Young 889970a449 SCH_NETCLASS_FLAGs and SCH_FIELDs for labels. 
ADDED: a new label type for netclass flags.
ADDED: the ability to define fields on labels.
 2021-12-24 16:13:27 +00:00
Jeff Young 2bc86fa0a8 Shapes for schematic. 
ADDED arc, circle and rectangle shapes for schematic.  Shapes support
line styles and fill colors.

CHANGED sheet background color in Edit Text & Graphics Properties to
fill color (and it now affects shapes).

Pushed STROKE_PARAMS down into common and moved all shapes to using it
for stroke descriptions.
 2021-12-23 20:36:07 +00:00
Jeff Young 885979ba75 Fix selection logic to handle LIB_ITEM as well as SCH_ITEM. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9954
 2021-12-12 17:38:38 +00:00
Jeff Young 0ad0627bb0 Overhaul drag-select logic to handle children better. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6662
 2021-12-10 18:44:07 +00:00
dsa-t 9c619d8f4e Allow some navigation tools when selecting 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/9565
 2021-12-07 23:00:39 +00:00
Jeff Young 863699f2d1 Fix logic error in selection tool. 
Any new selection made by clicking is not a hover selection.

Fixes https://gitlab.com/kicad/code/kicad/issues/9857
 2021-12-02 16:56:47 +00:00
Jeff Young 80d6b9e76d Tighten up hittesting for symbols and other items. 
Grid-based accuracy doesn't need to be any larger than 1/2 the
diagonal as we'll snap to one side or the other.  And symbols don't
need as much slop as other items since there's plenty of "meat" on
them.

Fixes https://gitlab.com/kicad/code/kicad/issues/9805
 2021-11-28 19:03:51 +00:00
Jeff Young 9f7db24871 Selection bug fixes for Symbol Editor. 
1) Make sure the y-coord is correctly inverted before calling collision
routines.
2) Give LIB_SHAPE poly lines the same extra slop as SCH_LINEs.

Fixes https://gitlab.com/kicad/code/kicad/issues/9791
 2021-11-27 15:17:05 +00:00
Jeff Young 5e6da9f964 Auto-start-wire tool requires an up-to-date connectivity. 
Fixes https://gitlab.com/kicad/code/kicad/issues/9628
 2021-11-25 01:24:35 +00:00
Wayne Stambaugh 53f5d616aa Coverity issue fixes. 2021-11-13 11:38:31 -05:00