haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
42,285 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

217 Commits

Author SHA1 Message Date
Jeff Young bbd6c80507 Collapse FP_* down into their PCB_* equivalents. 2023-03-31 22:57:46 +01:00
Jeff Young d6dd58fff9 Keep track of single-pad-islands so we can discount spokes to them. 2023-03-25 10:44:46 +00:00
Seth Hillbrand 283770fc45 Check for dirtied items in the cluster 
When drawing the ratsnest, we need to be careful to avoid accessing
CONN_ITEMs that have been changed by the underlying model.  Checking for
dirty items instead of valid items will prevent us looking at data that
are out of date

Fixes https://gitlab.com/kicad/code/kicad/issues/14265
 2023-03-13 16:10:39 -07:00
Jeff Young a0adb59437 Update dimension units when opening PCBs in CLI. 
Fixes https://gitlab.com/kicad/code/kicad/issues/14170
 2023-03-13 20:26:11 +00:00
Seth Hillbrand f0892598a4 Force initialization of board units 
Unitialized variables are the devil's playground
 2023-03-13 11:38:17 -07:00
Jon Evans 8eaa3cfac9 Do not try to process invalid ratsnest nodes 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14254
 2023-03-11 16:12:10 -05:00
Seth Hillbrand d7a6875b0b 3dviewer: Show footprint board regardless of proj 
The settings for the project in terms of visibility should not impact
our ability to preview the 3d model of a footprint

Fixes https://gitlab.com/kicad/code/kicad/issues/14246
 2023-03-10 15:18:45 -08:00
Jeff Young 9b9efb9002 Cache for netclass pattern assignments. 2023-03-06 13:56:04 +00:00
jean-pierre charras 7256a51e8e Fixes in build board outlines as polygon and convert_shape_list_to_polygon: 
- Ensure Bezier curves have their polygon build before use it.
- When building board outlines as polygon the same chaining epsilon value
for DRC, export step and 3D view (default 0.01mm).
Fixes #14115
https://gitlab.com/kicad/code/kicad/issues/14115
Fixes #14009
https://gitlab.com/kicad/code/kicad/issues/14009
 2023-02-28 16:45:03 +01:00
qu1ck 9f10c142c4 Sync pcbnew selection with selected items after plugin is run 2023-02-16 02:29:06 +00:00
Jeff Young 13391176ae Remove DRC exclusions that no longer have items. 
Fixes https://gitlab.com/kicad/code/kicad/issues/13802
 2023-02-11 20:43:00 +00:00
Jon Evans 200bf696af Fix importing of legacy netclasses 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/13746
 2023-02-02 08:29:43 -05:00
Seth Hillbrand e713a3eac2 Handle cleanup safely 
Make sure that the connectivity has successfully completed before
attempting to merge segments.  Also avoids reaching into the shared_ptr
if we don't need to

Fixes https://gitlab.com/kicad/code/kicad/issues/13639
 2023-01-23 15:56:46 -08:00
Jeff Young 26c821962f Simplify and regularize text variable substitution architecture. 
EDA_ITEMs are responsible for giving their parent a crack at it if
they failed to resolve it.  This recurses all the way up to the schematic/
board, and then to the project.

Cross-reference handling is also move to the EDA_ITEMs.  It must be done
before bubbling up so that we don't end up in loops.  (The aDepth parameter
will break the loop, but without having done anything useful.)

Fixes https://gitlab.com/kicad/code/kicad/issues/13541
 2023-01-17 17:05:41 +00:00
Jon Evans c530bdb5a1 Rename GetSelectMenuText to GetItemDescription 
This descriptive text is used for many more things than
just the select menu these days.
 2023-01-11 22:27:44 -05:00
Jeff Young 8238973bf4 Make sure std::unique_ptr gets initialized. 
(Fixes unit test failure.)
 2023-01-11 18:28:29 +00:00
Jeff Young c85dcbc4e1 Improve performance of IncrementTimestamp so it can be called at will. 2023-01-11 17:41:08 +00:00
Jeff Young 03f79f512c Nullptr safety. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12966
 2022-11-30 14:02:22 +00:00
Jeff Young 32836da14b Don't show annular rings controls for vias that span only a single layer. 2022-11-24 18:05:37 +00:00
Jeff Young 97fd99ec99 Re-resolve netclasses after assigning netclass to pattern. 
Fixes https://gitlab.com/kicad/code/kicad/issues/12965
 2022-11-22 14:54:08 +00:00
Jeff Young 138f835672 Retire group bbox cache. 
It's too hard to maintain when changes to other items (the groups
members) affect it.
 2022-11-11 20:31:31 +00:00
Jeff Young 03ba14c6d3 Tighten lifecycle management of parent group pointers. 
Also adds some debugging to try to catch dangling pointers.

Also adds a cache for group bounding boxes (which will be expensive
to calculate for large groups).

Fixes https://gitlab.com/kicad/code/kicad/issues/12875
 2022-11-11 17:27:28 +00:00
Jeff Young d16b23d16e Name shortening and line-break reduction. 2022-10-21 18:41:39 +01:00
Seth Hillbrand d1bf889e71 Resolve embedded text vars 
Title Block text variables are embedded into the pcb file and should
be used for resolving when the project file is missing
 2022-10-21 08:37:37 -07:00
Alex 22917860ef Move Enter Group for easier access. 2022-10-07 03:03:33 +03:00
Jeff Young e49de68a59 Implement a more durable zone bounding box caching strategy. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10821
 2022-10-01 22:10:43 +01:00
Jeff Young d67437a2aa Move ratsnest exclusion processing to a post-pass. 
Also fixes a few cases where we were unnecessarily rebuilding
connectivity more than once for an operation.
 2022-09-29 17:08:49 +01:00
Marek Roszko 707a598e5d Prevent a crash due to the 3d preview dummy board stealing setting ownership 2022-09-25 23:04:13 -04:00
Ian McInerney ea259fd093 Remove extra creation of an outline for the soldermask zone 
The zone class initializes the outline with an empty SHAPE_POLY_SET, so
adding a new SHAPE_POLY_SET outline in the BOARD constructor causes a
leak of the original.
 2022-09-25 15:41:39 +01:00
Jeff Young 839d31d427 Only update properties from a "real" project. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6268
 2022-09-22 10:14:08 +01:00
Jeff Young 64a6fc0fd4 Push UNITS_PROVIDER down into a low-level mixin. 
This allows us to also construct cheap UNIT_PROVIDERs for specific
tasks when necessary.
 2022-09-19 17:10:59 +01:00
Marek Roszko a8613ee80f Combine Iu2Millimeter & remove PcbMm2iu 2022-09-16 21:09:26 -04:00
Seth Hillbrand 26a1114e3c Avoid Yields when the results are ready 
We always need to check for calculation results before yielding the
system otherwise we will delay outcomes

Fixes https://gitlab.com/kicad/code/kicad/issues/12228
 2022-09-14 13:30:04 -07:00
Roberto Fernandez Bautista 2d203bc975 Don't move items inside a group: move the whole group instead 2022-09-04 00:59:57 +02:00
Jeff Young c30a557810 ADDED netclass assignment from PCB canvas. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5975
 2022-09-03 19:29:59 +01:00
Jeff Young b4492e0bd2 More EDA_RECE yeetage. 2022-08-31 17:19:50 +01:00
Jeff Young 2dc6300501 Move EDA_ITEM bounding boxes to BOX2I. 2022-08-31 10:16:55 +01:00
Jeff Young 5679b9dbdc Remove a few EDA_RECT instances. 2022-08-31 01:22:49 +01:00
Jeff Young 77c79b6f6a Apply searchArea architecture to courtyard functions. 2022-08-28 21:20:03 +01:00
Jeff Young 667a54ad86 Retire insideArea in favour of intersectsArea and enclosedByArea. 2022-08-28 18:02:41 +01:00
Jeff Young f99761e5bd entirelyInsideArea() prototype. 2022-08-26 13:22:57 +01:00
Marek Roszko 3e451ca516 Add RemoveAllListeners function for future addons 2022-08-22 23:29:04 -04:00
Jeff Young 4f0136db3b Attempt to fix std::initializer_list lifetime issue. 2022-08-21 20:54:41 +01:00
Seth Hillbrand af34835fdf Restore removed data 
Functions and definitions used in Python scripting should not be
removed.  Comments in header files should never be removed (only
updated/corrected)
 2022-08-20 08:40:08 -07:00
Jeff Young aa2ad3b44c Move KICAD_T[] to std::initializer_list<KICAD_T>. 2022-08-20 10:28:11 +01:00
Jon Evans 55bb374370 Fix crash when unloading board 2022-08-14 22:49:51 -04:00
Jeff Young a9536b5de9 CHANGED netclass assignments now done via canvas or via patterns. 2022-08-14 22:56:29 +01:00
Jeff Young 96f01d33c8 Performance improvements. 
1) Move a bunch of std::map's to std::unordered_map to get constant-time
look-ups
2) Lengthen progress-reporting intervals to spend more time doing work
and less time talking about it
3) Reverse order of SHAPE_LINE_CHAINs in thermal intersection checks to
make (much) better use of bbox caches
4) Don't re-generate bboxes we already have
5) Fix some autos that weren't by reference (and were therefore copying
large datasets)
6) Rename delta progressDelta so it's easier to search for in future
7) Get rid of a few more autos (because I don't like them)
8) Pass large items to lambdas by reference

Fixes https://gitlab.com/kicad/code/kicad/issues/12130
 2022-08-03 11:59:42 +01:00
Marek Roszko a8505d9c76 SEARCH_RESULT -> INSPECT_RESULT 
To fix the name squatting it's doing for future functionality
 2022-07-29 20:01:10 -04:00
Jeff Young f0ef6932b8 Fix issues with plotting textbox outlines. 
Fixes https://gitlab.com/kicad/code/kicad/issues/11943
 2022-07-23 13:53:03 +01:00
Mike Williams 3669cb4673 PCB Editor: Add User Background Images 2022-07-14 11:23:23 +00:00
Jeff Young 8a9bf02b7e Smarten up silk clearance & tented item handling. 
The inspection tool will report whether or not the item is tented
(indicating in that case that any clearance will only be applied
to any hole).

The DRC test ignores tented items without a hole, and runs the
clearance test against the hole for items with a hole.

Fixes https://gitlab.com/kicad/code/kicad/issues/11954

Fixes https://gitlab.com/kicad/code/kicad/issues/11951
 2022-07-08 17:27:05 -06:00
Seth Hillbrand 03c279ffd4 ADDED: Threadpool 
Thread pools are long-lasting executors that have close to zero overhead
when launching new jobs.  This is advantageous over creating new threads
as we can use this for threading smalling jobs and smaller quanta.  It
also avoids the heuristics needed to determine the optimal number of
threads to spawn
 2022-06-24 22:59:24 +00:00
Jeff Young 97b0005780 More caching for DRC. 
Also fixes a bug where some physical clearance tests would be run even
if the clearance was 0 (or if the rule was set to IGNORE).
 2022-06-17 23:58:31 +01:00
Seth Hillbrand b5c2f0d39a Remove the open array in favor of std containers 
The containers allow iteration, size knowledge and lower bug surface
 2022-03-03 16:03:26 -08:00
Seth Hillbrand f0e4448a9d Remove broken call to normalize outlines 
We should never be editing the user's outlines for them.  This creates
broken zones that are hard to repair.  In this case, there was also a
secondary zone with no outline that would crash the system

Fixes https://gitlab.com/kicad/code/kicad/issues/10904

(cherry picked from commit f0d7a09af9)
 2022-02-18 09:31:52 -08:00
jean-pierre charras 2fddc9daf3 Pcbnew: fix missing connectivity update when adding an item. 
Skipping connectivity update when adding an item is possible only when loading a file
Fixes #10879
https://gitlab.com/kicad/code/kicad/issues/10879
 2022-02-18 13:24:14 +01:00
Jeff Young d8c4f2cb09 Performance improvements for zone filler. 2022-02-15 19:19:02 +00:00
Jeff Young 5c9e718407 Performance enhancements for connectivity. 
1) Generate SHAPE_POLY_SET triangulation by outline so they can be
shared between connectivity system and other clients.
2) Don't add items to connectivity when reading board; we're going
to do a total rebuild anyway.
3) Use multithreading when caching triangulation.
 2022-02-15 12:20:34 +00:00
Jeff Young 3deaf902bb Retire the V5 zone fill algorithm. 
Fixes https://gitlab.com/kicad/code/kicad/issues/10578
 2022-02-11 13:10:52 +00:00
Jeff Young 7ccac79192 More wxString wide literals. 2022-02-05 21:29:34 +00:00
Jeff Young 5739505aa3 TextBoxes for PCBNew. 2022-01-31 20:00:47 +00:00
Marek Roszko c91d3e3cf9 Remove some more wxPoint 2022-01-01 14:12:20 -05:00
Marek Roszko c4c56de708 Neurotically update position wxPoint usages 2022-01-01 11:55:51 -05:00
Jeff Young fa908e1f98 Dimensions for footprints. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8441
 2021-12-24 21:10:28 +00:00
Jeff Young b4c5e64db2 Exclusions for Unconnected Items; Markers & exclusions for Parity checks 
Fixes https://gitlab.com/kicad/code/kicad/issues/5589

Fixes https://gitlab.com/kicad/code/kicad/issues/5504
 2021-12-24 21:10:28 +00:00
Jeff Young 5f37c2b247 Custom rule severities. 
ADDED severity token to custom rule syntax.  Each rule can now define
its own severity.

Fixes https://gitlab.com/kicad/code/kicad/issues/6148
 2021-12-24 15:42:22 +00:00
Jeff Young a48867ea01 Solder mask integrity testing. 
ADDED DRC test for solder mask aperture bridging copper from different
nets.
ADDED visualization of minimum web width processing for solder masks.
ADDED allow_soldermask_bridges property for footprints.

Fixes https://gitlab.com/kicad/code/kicad/issues/2183

Fixes https://gitlab.com/kicad/code/kicad/issues/1792
 2021-12-23 22:31:14 +00:00
Jeff Young e26341d424 Cleanup. 2021-12-23 20:36:18 +00:00
Jeff Young 4b6bf3095a Radial dimensions. 
ADDED radial type dimensions.

Fixes https://gitlab.com/kicad/code/kicad/issues/2056
 2021-12-23 19:34:54 +00:00
Jon Evans 8026863d4c Use progress reporting in more places when loading a board 
Prevents application-not-responding events while opening large designs
 2021-11-25 11:19:03 -05:00
Wayne Stambaugh 1f7fd436a2 Move board object polygon code into the object source files. 
Having the board object polygon code all defined in a separate file made
finding the polygon code for an object difficult to find.
 2021-10-25 17:42:11 -04:00
Jeff Young a41944020d Push most of PCB_SHAPE impl down in to EDA_SHAPE. 2021-10-15 12:45:43 +01:00
Jeff Young f606679164 Proper numeric sorting for intersheet refs. 
Also expunges the horrifically named std::remove and std::remove_if
(neither of which remove anything).
 2021-10-01 18:29:21 +01:00
Jeff Young fac48ddafb Don't include stale nets in net counts. 
Fixes bug reported by Franck.
 2021-09-28 14:28:12 +01:00
Jeff Young f34e280c81 Garden-variety 100X performance improvement. 
Adds a compile mode for layer strings.
 2021-08-15 22:24:51 +01:00
Jeff Young 6aaf4413b3 Fix kicad_string.h / string.cpp mismatch. 
They don't define a KiCad string class, so the header file name was
somewhat misleading. But the fact that they didn't match definitely
made coding more difficult.
 2021-07-29 16:03:25 +01:00
Jeff Young d613292b67 Fix type in group command enablement. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8821
 2021-07-25 13:31:52 +01:00
Jeff Young 70ac70f360 Don't attempt to round-trip netnames through wxListBox. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8684
 2021-06-27 12:02:21 +01:00
Jeff Young 096e342386 Prefix TRACK, ARC and VIA. 2021-06-11 22:07:02 +01:00
luz paz f968fc8719 Fix source comment / documentation typos 2021-06-09 19:32:58 +00:00
Marek Roszko 10e60acf34 Clean up including of board_design_settings.h 2021-06-06 15:03:42 -04:00
Wayne Stambaugh 2a6c7a7c0f Pcbnew header housekeeping round 1. 2021-06-04 09:08:38 -04:00
Ian McInerney 4f05262705 Cleanup includes in board.h and footprint.h 2021-06-03 20:19:52 +01:00
Marek Roszko 4df3cb912d Remove another leaky wx/log.h header 2021-06-03 08:11:15 -04:00
Jon Evans bc6b9b527a Allow stackup height to be excluded from length calculations 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8384
 2021-05-10 22:11:58 -04:00
Jon Evans ce01a28aad Don't double-remove nets when netcodes are reused 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8206
 2021-05-10 19:52:19 -04:00
Ian McInerney ecd9bf696e Be consistent about using nullptr instead of 0 
0 can be too easily overloaded into an int, so ensure we use nullptr
when we mean pointers.
 2021-04-22 22:20:34 +01:00
Jon Evans 29c45743b7 Fix calculation of arc lengths; include them in net inspector 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8140
 2021-04-15 21:06:35 -04:00
Jon Evans 36ef198610 Clean up nets from items when deleting in the inspector 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/8162
 2021-04-12 21:17:42 -04:00
Jon Evans c7ecb51f77 Update PNS length tuning algorithm to match the new BOARD algorithm 
Now tracks inside pads are optimized to give a more accurate length.
Also, the start/end of the assembled line is used to identify the right
pad joints for pad-to-die length calculation.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/4204
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1765
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6877
 2021-04-04 20:27:22 -04:00
Jon Evans 41c54d383e Fix some edge cases with length calculation 2021-04-04 19:38:54 -04:00
Jon Evans cdfb014ab6 CHANGED: Account for via height in track length calculations 2021-04-04 13:59:18 -04:00
Jon Evans 80728f8d78 Improve algorithm for calculating net length; use it for netinfo message panel 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4258
 2021-04-04 12:27:09 -04:00
Dominik Wernberger e2aa7be4b3 Added a lot of consts and refactored a few lines 2021-03-08 12:49:48 -08:00
Jeff Young 86aaa2e9cb Rationalize footprint bounding boxes and cache all of them. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7720
 2021-02-26 13:50:27 +00:00
Jeff Young a3b9e8ddb4 Round 2 of Worksheet -> Drawing Sheet. 2021-02-23 11:57:44 +00:00
Jeff Young b08862e445 Fix group undo/redo bugs. 
1) Don't remove items from group when the group is being deleted as
well.  We need those pointers for undo/redo.
2) Flip the GROUP/UNGROUP undo status when undoing/redoing group and
ungroup actions.
3) Remove PCB_GROUP_T from the rebuild-netlists section.  Nothing
about an item's group/ungrouped status changes its netlisting.
4) Add PCB_PAD_T to the rebuild-netlists section.  It can probably
only happen in the footprint editor where we don't care about
netlisting, but it's conceptually more correct and who knows what
might change in the future....

Fixes https://gitlab.com/kicad/code/kicad/issues/7540
 2021-02-15 14:13:43 +00:00
Wayne Stambaugh 5ecef204cd Coding policy fixes. 
Using "this->" violates coding policy section 2.7.
 2021-02-09 11:35:43 -05:00
Jeff Young d261fa3792 Make sure items are removed from groups when deleted. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7387
 2021-02-02 14:23:29 +00:00